Change in osmo-bsc[master]: assignment_fsm: use activate.info.s15_s0 for ASS. COMPL.

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13039 ) Change subject: assignment_fsm: use activate.info.s15_s0 for ASS. COMPL. .. assignment_fsm: use activate.info.s15_s0 for ASS. COMPL.

Change in osmo-remsim[master]: slotmap: Log file/line when changing state

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13184 ) Change subject: slotmap: Log file/line when changing state .. slotmap: Log file/line when changing state Change-Id: Idc7b350b464ddc5

Change in osmo-remsim[master]: slotmap: Introduce slotmap_{rd, wr, un}lock() wrappers for lock debugging

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13185 ) Change subject: slotmap: Introduce slotmap_{rd,wr,un}lock() wrappers for lock debugging .. slotmap: Introduce slotmap_{rd,wr,un}lock

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13173 ) Change subject: sms queue: avoid repeated Paging for a failed SMS .. Patch Set 2: Code-Review-1 Missing comment feedback -- To view, visit

Change in osmo-msc[master]: vty: add cmd subscriber ID sms delete-all

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13174 ) Change subject: vty: add cmd subscriber ID sms delete-all .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13174

Change in osmo-iuh[master]: osmo-hnbgw: logging tweaks

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13146 ) Change subject: osmo-hnbgw: logging tweaks .. Patch Set 2: Code-Review+2 triviality +2 -- To view, visit https://gerrit.osmocom.org/13146

Change in osmo-iuh[master]: osmo-hnbgw: reply with RESET ACK when receiving a RESET

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13147 ) Change subject: osmo-hnbgw: reply with RESET ACK when receiving a RESET .. osmo-hnbgw: reply with RESET ACK when receiving a RESET

Change in osmo-iuh[master]: osmo-hnbgw: logging tweaks

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13146 ) Change subject: osmo-hnbgw: logging tweaks .. osmo-hnbgw: logging tweaks Log about: - sending RESET messages to CN; - accepting a n

Change in libosmocore[master]: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer()

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13143 ) Change subject: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer() .. fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer() Du

Change in libosmocore[master]: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer()

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13143 ) Change subject: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer() .. Patch Set 2: Code-Review+2 (apply previous +2) -- To view, visi

Change in libosmocore[master]: add gsm0808_cell_id_from_cgi(), gsm0808_cell_id_to_cgi()

2019-03-07 Thread Neels Hofmeyr
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13122 to look at the new patch set (#6). Change subject: add gsm0808_cell_id_from_cgi(), gsm0808_cell_id_to_cgi() .. a

Change in libosmocore[master]: add gsm0808_cell_id_from_cgi(), gsm0808_cell_id_to_cgi()

2019-03-07 Thread Neels Hofmeyr
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13122 to look at the new patch set (#5). Change subject: add gsm0808_cell_id_from_cgi(), gsm0808_cell_id_to_cgi() .. a

Change in libosmocore[master]: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer()

2019-03-07 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13143 to look at the new patch set (#2). Change subject: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer() ..

Change in osmo-iuh[master]: osmo-hnbgw: logging tweaks

2019-03-07 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13146 to look at the new patch set (#2). Change subject: osmo-hnbgw: logging tweaks .. osmo-hnbgw: logging tweaks Log abou

Change in osmo-iuh[master]: osmo-hnbgw: logging tweaks

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13146 ) Change subject: osmo-hnbgw: logging tweaks .. Patch Set 1: shucks, the fix for that ended up in the next patch (the RESET ACK one) -- To

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_reset: add final delay to fix spurious failure

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13171 ) Change subject: msc: f_tc_sgsap_reset: add final delay to fix spurious failure .. msc: f_tc_sgsap_reset: add final delay to fix spur

Change in osmo-ttcn3-hacks[master]: msc: as_clear_cmd_compl_disc: log unexpected message

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13169 ) Change subject: msc: as_clear_cmd_compl_disc: log unexpected message .. msc: as_clear_cmd_compl_disc: log unexpected message When r

Change in osmo-ttcn3-hacks[master]: msc: move sms sending to BSC_ConnHdlr and send from within test flow

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13170 ) Change subject: msc: move sms sending to BSC_ConnHdlr and send from within test flow .. msc: move sms sending to BSC_ConnHdlr and s

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_nothing: also do f_sgsap_bssmap_screening

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13193 Change subject: msc: f_tc_sgsap_mt_sms_and_nothing: also do f_sgsap_bssmap_screening .. msc: f_tc_sgsap_mt_sms_and_nothing: also do f_sgsap_

Change in osmo-ttcn3-hacks[master]: msc: TC_lu_disconnect: add final delay to fix spurious failure

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13194 Change subject: msc: TC_lu_disconnect: add final delay to fix spurious failure .. msc: TC_lu_disconnect: add final delay to fix spurious fail

Change in osmo-ttcn3-hacks[master]: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe

2019-03-07 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13187 to look at the new patch set (#2). Change subject: msc: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe ..

Change in osmo-ttcn3-hacks[master]: msc: for mo and mt call, interleave MGCP and Assignment

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13191 Change subject: msc: for mo and mt call, interleave MGCP and Assignment .. msc: for mo and mt call, interleave MGCP and Assignment Upcoming

Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on failed MT SMS, and clear the failed SMS

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13192 Change subject: msc: expect only one Paging on failed MT SMS, and clear the failed SMS .. msc: expect only one Paging on failed MT SMS, and

Change in osmo-msc[master]: vty: add cmd subscriber ID sms delete-all

2019-03-07 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13174 to look at the new patch set (#2). Change subject: vty: add cmd subscriber ID sms delete-all .. vty: ad

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-03-07 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13173 to look at the new patch set (#2). Change subject: sms queue: avoid repeated Paging for a failed SMS .. sms queue: av

Change in osmo-ttcn3-hacks[master]: msc: add codec to all Assignment Complete messages

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13186 Change subject: msc: add codec to all Assignment Complete messages .. msc: add codec to all Assignment Complete messages So far we omit a Sp

Change in osmo-ttcn3-hacks[master]: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13187 Change subject: TC_gsup_cancel: end with f_expect_clear() to avoid broken pipe .. TC_gsup_cancel: end with f_expect_clear() to avoid broken p

Change in osmo-ttcn3-hacks[master]: msc: add as_optional_cc_rel to ignore CC REL during call abort tests

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13167 ) Change subject: msc: add as_optional_cc_rel to ignore CC REL during call abort tests .. msc: add as_optional_cc_rel to ignore CC RE

Change in libosmocore[master]: fix tdef_test.c: do call the function-to-test in all cases

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13142 ) Change subject: fix tdef_test.c: do call the function-to-test in all cases .. fix tdef_test.c: do call the function-to-test in all c

Change in libosmocore[master]: tdef_test: tweak output to prepare for a fix

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13141 ) Change subject: tdef_test: tweak output to prepare for a fix .. tdef_test: tweak output to prepare for a fix - Always print the sta

Change in osmo-remsim[master]: generalize slotmap to make use of it outside of bankd

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13177 ) Change subject: generalize slotmap to make use of it outside of bankd .. generalize slotmap to make use of it outside of bankd Chang

Change in osmo-remsim[master]: slotmap: Return newly-created map from slotmap_add()

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13180 ) Change subject: slotmap: Return newly-created map from slotmap_add() .. slotmap: Return newly-created map from slotmap_add() Change-

Change in osmo-remsim[master]: slotmap: Introduce the concept of a slotmap state

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13179 ) Change subject: slotmap: Introduce the concept of a slotmap state .. slotmap: Introduce the concept of a slotmap state ... which is

Change in osmo-remsim[master]: slotmap: Introduce slotmap-printing function and use it

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13178 ) Change subject: slotmap: Introduce slotmap-printing function and use it .. slotmap: Introduce slotmap-printing function and use it .

Change in osmo-remsim[master]: slotmap: Add slotmap_get_id() function to get numeric ID of slot map

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13182 ) Change subject: slotmap: Add slotmap_get_id() function to get numeric ID of slot map .. slotmap: Add slotmap_get_id() function to ge

Change in osmo-remsim[master]: slotmap: Add _slotmap_del() for callers that already have a lock

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13183 ) Change subject: slotmap: Add _slotmap_del() for callers that already have a lock .. slotmap: Add _slotmap_del() for callers that alre

Change in osmo-remsim[master]: slotmap: Add "DELETE_REQ" state

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13181 ) Change subject: slotmap: Add "DELETE_REQ" state .. slotmap: Add "DELETE_REQ" state Change-Id: I953e72e304d6403b2e47f7546a36abfdf246e

Change in osmo-remsim[master]: share debug.[ch] across all executables

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13176 ) Change subject: share debug.[ch] across all executables .. share debug.[ch] across all executables This avoids us having to re-defin

Change in osmo-remsim[master]: slotmap: Add "DELETE_REQ" state

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13181 ) Change subject: slotmap: Add "DELETE_REQ" state .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13181 To unsubsc

Change in osmo-remsim[master]: client: Connect to server before connecting to bankd

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13175 ) Change subject: client: Connect to server before connecting to bankd .. client: Connect to server before connecting to bankd So far

Change in osmo-remsim[master]: client: Connect to server before connecting to bankd

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13175 ) Change subject: client: Connect to server before connecting to bankd .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom

Change in osmo-remsim[master]: slotmap: Introduce slotmap_{rd, wr, un}lock() wrappers for lock debugging

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13185 ) Change subject: slotmap: Introduce slotmap_{rd,wr,un}lock() wrappers for lock debugging .. Patch Set 1: Code-Review+2 -- To view, visit ht

Change in osmo-remsim[master]: slotmap: Log file/line when changing state

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13184 Change subject: slotmap: Log file/line when changing state .. slotmap: Log file/line when changing state Change-Id: Idc7b350b464ddc50076f92da

Change in osmo-remsim[master]: slotmap: Log file/line when changing state

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13184 ) Change subject: slotmap: Log file/line when changing state .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13184

Change in osmo-remsim[master]: slotmap: Introduce slotmap_{rd, wr, un}lock() wrappers for lock debugging

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13185 Change subject: slotmap: Introduce slotmap_{rd,wr,un}lock() wrappers for lock debugging .. slotmap: Introduce slotmap_{rd,wr,un}lock() wrappe

Change in osmo-remsim[master]: slotmap: Add _slotmap_del() for callers that already have a lock

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13183 ) Change subject: slotmap: Add _slotmap_del() for callers that already have a lock .. Patch Set 1: Code-Review+2 -- To view, visit https://ge

Change in osmo-remsim[master]: slotmap: Introduce slotmap-printing function and use it

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13178 ) Change subject: slotmap: Introduce slotmap-printing function and use it .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmo

Change in osmo-remsim[master]: generalize slotmap to make use of it outside of bankd

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13177 ) Change subject: generalize slotmap to make use of it outside of bankd .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-remsim[master]: slotmap: Add slotmap_get_id() function to get numeric ID of slot map

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13182 ) Change subject: slotmap: Add slotmap_get_id() function to get numeric ID of slot map .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-remsim[master]: slotmap: Return newly-created map from slotmap_add()

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13180 ) Change subject: slotmap: Return newly-created map from slotmap_add() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom

Change in osmo-remsim[master]: slotmap: Introduce the concept of a slotmap state

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13179 ) Change subject: slotmap: Introduce the concept of a slotmap state .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in osmo-remsim[master]: share debug.[ch] across all executables

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13176 ) Change subject: share debug.[ch] across all executables .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13176 To

Change in osmo-remsim[master]: respro_util: Add rspro_gen_ConfigClientRes() function

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13105 ) Change subject: respro_util: Add rspro_gen_ConfigClientRes() function .. respro_util: Add rspro_gen_ConfigClientRes() function Chang

Change in osmo-remsim[master]: move osmo_fsm_register() into constructor function

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13104 ) Change subject: move osmo_fsm_register() into constructor function .. move osmo_fsm_register() into constructor function This way ea

Change in osmo-remsim[master]: slotmap: Introduce the concept of a slotmap state

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13179 Change subject: slotmap: Introduce the concept of a slotmap state .. slotmap: Introduce the concept of a slotmap state ... which is required

Change in osmo-remsim[master]: slotmap: Return newly-created map from slotmap_add()

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13180 Change subject: slotmap: Return newly-created map from slotmap_add() .. slotmap: Return newly-created map from slotmap_add() Change-Id: I1bc6

Change in osmo-remsim[master]: rspro_util: Add rspro_IpAddr2str() to get stringified version of IpAd...

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13107 ) Change subject: rspro_util: Add rspro_IpAddr2str() to get stringified version of IpAddr_t .. rspro_util: Add rspro_IpAddr2str() to g

Change in osmo-remsim[master]: generalize slotmap to make use of it outside of bankd

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13177 Change subject: generalize slotmap to make use of it outside of bankd .. generalize slotmap to make use of it outside of bankd Change-Id: I0c

Change in osmo-remsim[master]: slotmap: Add "DELETE_REQ" state

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13181 Change subject: slotmap: Add "DELETE_REQ" state .. slotmap: Add "DELETE_REQ" state Change-Id: I953e72e304d6403b2e47f7546a36abfdf246e44b --- M

Change in osmo-remsim[master]: slotmap: Add _slotmap_del() for callers that already have a lock

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13183 Change subject: slotmap: Add _slotmap_del() for callers that already have a lock .. slotmap: Add _slotmap_del() for callers that already have

Change in osmo-remsim[master]: rspro_util: Add rspro_comp_id_retrieve()

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13106 ) Change subject: rspro_util: Add rspro_comp_id_retrieve() .. rspro_util: Add rspro_comp_id_retrieve() This function can be used to ob

Change in osmo-remsim[master]: client: Connect to server before connecting to bankd

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13175 Change subject: client: Connect to server before connecting to bankd .. client: Connect to server before connecting to bankd So far we skippe

Change in osmo-remsim[master]: slotmap: Introduce slotmap-printing function and use it

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13178 Change subject: slotmap: Introduce slotmap-printing function and use it .. slotmap: Introduce slotmap-printing function and use it ... avoid

Change in osmo-remsim[master]: slotmap: Add slotmap_get_id() function to get numeric ID of slot map

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13182 Change subject: slotmap: Add slotmap_get_id() function to get numeric ID of slot map .. slotmap: Add slotmap_get_id() function to get numeric

Change in osmo-remsim[master]: share debug.[ch] across all executables

2019-03-07 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13176 Change subject: share debug.[ch] across all executables .. share debug.[ch] across all executables This avoids us having to re-define log_inf

Change in osmo-remsim[master]: move osmo_fsm_register() into constructor function

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13104 ) Change subject: move osmo_fsm_register() into constructor function .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.o

Change in osmo-remsim[master]: respro_util: Add rspro_gen_ConfigClientRes() function

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13105 ) Change subject: respro_util: Add rspro_gen_ConfigClientRes() function .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in osmo-remsim[master]: rspro_util: Add rspro_IpAddr2str() to get stringified version of IpAd...

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13107 ) Change subject: rspro_util: Add rspro_IpAddr2str() to get stringified version of IpAddr_t .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-remsim[master]: rspro_util: Add rspro_comp_id_retrieve()

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13106 ) Change subject: rspro_util: Add rspro_comp_id_retrieve() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13106 T

Change in libosmocore[master]: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer()

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13143 ) Change subject: fsm: add osmo_fsm_inst_state_chg_keep_or_start_timer() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmoc

Change in libosmocore[master]: fix tdef_test.c: do call the function-to-test in all cases

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13142 ) Change subject: fix tdef_test.c: do call the function-to-test in all cases .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.o

Change in libosmocore[master]: tdef_test: tweak output to prepare for a fix

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13141 ) Change subject: tdef_test: tweak output to prepare for a fix .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/131

Change in osmo-bsc[master]: assignment_fsm: use activate.info.s15_s0 for ASS. COMPL.

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13039 ) Change subject: assignment_fsm: use activate.info.s15_s0 for ASS. COMPL. .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osm

Change in osmo-gsm-tester[master]: nitb_netreg_mass: Provide 100 subscribers

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13131 ) Change subject: nitb_netreg_mass: Provide 100 subscribers .. Patch Set 3: Code-Review+2 if pau is happy here, please go ahead and merge this

Change in libosmocore[master]: add osmo_use_count API

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13121 ) Change subject: add osmo_use_count API .. Patch Set 2: > > use a [0] sized array at the end of the counter > > I actually had exactly this

Change in libosmocore[master]: add osmo_use_count API

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13121 ) Change subject: add osmo_use_count API .. Patch Set 2: > I've gone through a few iterations, some using limited size arrays, > some using e

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_reset: add final delay to fix spurious failure

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13171 ) Change subject: msc: f_tc_sgsap_reset: add final delay to fix spurious failure .. Patch Set 1: Code-Review+2 -- To view, visit https://gerr

Change in osmo-ttcn3-hacks[master]: msc: move sms sending to BSC_ConnHdlr and send from within test flow

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13170 ) Change subject: msc: move sms sending to BSC_ConnHdlr and send from within test flow .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: msc: as_clear_cmd_compl_disc: log unexpected message

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13169 ) Change subject: msc: as_clear_cmd_compl_disc: log unexpected message .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13168 ) Change subject: msc: f_call_hangup: ignore MDCX .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13168/1//COMMIT_MSG Commit Messa

Change in osmo-ttcn3-hacks[master]: log time in tcpdump-start and -stop.sh

2019-03-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13166 ) Change subject: log time in tcpdump-start and -stop.sh .. log time in tcpdump-start and -stop.sh Also log the testcase name in tcpdu

Change in osmo-ttcn3-hacks[master]: msc: add as_optional_cc_rel to ignore CC REL during call abort tests

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13167 ) Change subject: msc: add as_optional_cc_rel to ignore CC REL during call abort tests .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in osmo-ttcn3-hacks[master]: log time in tcpdump-start and -stop.sh

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13166 ) Change subject: log time in tcpdump-start and -stop.sh .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13166 To

Change in osmo-pcu[master]: Log (M)CS UL update errors

2019-03-07 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13162 ) Change subject: Log (M)CS UL update errors .. Log (M)CS UL update errors Previously some of the errors in update_cs_ul() call were silently i

Change in osmo-pcu[master]: Log (M)CS UL update errors

2019-03-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13162 ) Change subject: Log (M)CS UL update errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13162 To unsubscribe, or for he

Change in osmo-pcu[master]: Enable LGLOBAL logging for TBF tests

2019-03-07 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13165 ) Change subject: Enable LGLOBAL logging for TBF tests .. Enable LGLOBAL logging for TBF tests This exposes the bug in BSSGP rate counter group

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_reset: add final delay to fix spurious failure

2019-03-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13171 ) Change subject: msc: f_tc_sgsap_reset: add final delay to fix spurious failure .. Patch Set 1: It might be worth clarifying which failures you're refe

Change in osmo-ttcn3-hacks[master]: log time in tcpdump-start and -stop.sh

2019-03-07 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13166 ) Change subject: log time in tcpdump-start and -stop.sh .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13166 To unsubscrib

Change in osmo-msc[master]: vty: add cmd subscriber ID sms delete-all

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13174 ) Change subject: vty: add cmd subscriber ID sms delete-all .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13174

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-03-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13173 ) Change subject: sms queue: avoid repeated Paging for a failed SMS .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13173/1//COMMI

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13173 Change subject: sms queue: avoid repeated Paging for a failed SMS .. sms queue: avoid repeated Paging for a failed SMS So far, sms_pending_f

Change in osmo-msc[master]: vty: add cmd subscriber ID sms delete-all

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13174 Change subject: vty: add cmd subscriber ID sms delete-all .. vty: add cmd subscriber ID sms delete-all In ttcn3-msc-tests, so far we leave a

Change in osmo-ttcn3-hacks[master]: log time in tcpdump-start and -stop.sh

2019-03-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13166 ) Change subject: log time in tcpdump-start and -stop.sh .. Patch Set 1: Code-Review+1 Fine, but $TESTNAME.pcap.stdout will contain alread

Change in osmo-bsc[master]: assignment_fsm: Properly support assigning signalling mode TCH/x

2019-03-07 Thread tnt
tnt has uploaded this change for review. ( https://gerrit.osmocom.org/13172 Change subject: assignment_fsm: Properly support assigning signalling mode TCH/x .. assignment_fsm: Properly support assigning signalling mode TCH/x To

Change in osmo-msc[master]: SMS queue: properly log failed attempts number

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13154 ) Change subject: SMS queue: properly log failed attempts number .. SMS queue: properly log failed attempts number Change-Id: I16f2d2

Change in osmo-msc[master]: use only accepted ran_conns for new transactions

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13152 ) Change subject: use only accepted ran_conns for new transactions .. use only accepted ran_conns for new transactions In connection_

Change in osmo-msc[master]: gsm_04_11_gsup.c: drop unused conn lookup

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13153 ) Change subject: gsm_04_11_gsup.c: drop unused conn lookup .. gsm_04_11_gsup.c: drop unused conn lookup An earlier code state used t

Change in osmo-ttcn3-hacks[master]: msc: move sms sending to BSC_ConnHdlr and send from within test flow

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13170 Change subject: msc: move sms sending to BSC_ConnHdlr and send from within test flow .. msc: move sms sending to BSC_ConnHdlr and send from

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_reset: add final delay to fix spurious failure

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13171 Change subject: msc: f_tc_sgsap_reset: add final delay to fix spurious failure .. msc: f_tc_sgsap_reset: add final delay to fix spurious fail

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-03-07 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13168 Change subject: msc: f_call_hangup: ignore MDCX .. msc: f_call_hangup: ignore MDCX Upcoming osmo-msc changes move away from the current MDCX

  1   2   >