Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13392 ) Change subject: fsm: support graceful osmo_fsm_inst_term() cascades .. Patch Set 4: (1 comment)

Change in libosmocore[master]: fsm: support graceful osmo_fsm_inst_term() cascades

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13392 ) Change subject: fsm: support graceful osmo_fsm_inst_term() cascades .. Patch Set 4: (1 comment) (one stray remark...)

Change in osmo-hlr[master]: fix USSD routing to multiple MSC

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13479 ) Change subject: fix USSD routing to multiple MSC .. Patch Set 4: (1 comment) This is an improvement, but...

Change in osmo-hlr[master]: fix USSD routing to multiple MSC

2019-04-01 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13479 to look at the new patch set (#4). Change subject: fix USSD routing to multiple MSC .. fix USSD routing to multiple

Change in osmo-hlr[master]: fix USSD routing to multiple MSC

2019-04-01 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13479 to look at the new patch set (#3). Change subject: fix USSD routing to multiple MSC .. fix USSD routing to multiple

Change in osmo-hlr[master]: fix USSD routing to multiple MSC

2019-04-01 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13479 to look at the new patch set (#2). Change subject: fix USSD routing to multiple MSC .. fix USSD routing to multiple

Change in osmo-hlr[master]: fix USSD routing to multiple MSC

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13479 Change subject: fix USSD routing to multiple MSC .. fix USSD routing to multiple MSC hlr_ussd.c so far hardcoded osmo-msc's default

Change in osmo-bts[master]: common/oml.c: fix: properly push abis_nm_ipa_magic

2019-04-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13471 ) Change subject: common/oml.c: fix: properly push abis_nm_ipa_magic .. common/oml.c: fix: properly push abis_nm_ipa_magic In

Change in osmo-bts[master]: common/oml.c: fix: properly push abis_nm_ipa_magic

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13471 ) Change subject: common/oml.c: fix: properly push abis_nm_ipa_magic .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13366 ) Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length .. Patch Set 4: Code-Review+2 -- To view, visit

Change in pysim[master]: wavemobile-sim: write mnc-length field ine EF.AD

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13478 ) Change subject: wavemobile-sim: write mnc-length field ine EF.AD .. Patch Set 1: Code-Review+2 -- To view, visit

Change in pysim[master]: cosmetic: fix sourecode formatting

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13476 ) Change subject: cosmetic: fix sourecode formatting .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13476 To

Change in osmo-ci[master]: build-old-tags: build libosmo-legacy-mgcp

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13454 ) Change subject: build-old-tags: build libosmo-legacy-mgcp .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13454

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 5: please don't abandon but revisit/rebase on top of

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-04-01 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 5: (2 comments) > I completely agree with the intent, that's

Change in osmo-msc[master]: MT-forwardSM Message Reference fix.

2019-04-01 Thread Mykola Shchetinin
Mykola Shchetinin has abandoned this change. ( https://gerrit.osmocom.org/13464 ) Change subject: MT-forwardSM Message Reference fix. .. Abandoned -- To view, visit https://gerrit.osmocom.org/13464 To unsubscribe, or for help

Change in osmo-ci[master]: build-old-tags: build libosmo-legacy-mgcp

2019-04-01 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13454 ) Change subject: build-old-tags: build libosmo-legacy-mgcp .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: a_iface_bssap: check bssmap length field

2019-04-01 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13307 ) Change subject: a_iface_bssap: check bssmap length field .. Patch Set 5: (3 comments) > In current osmo-msc refactoring, I have the same checks

Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

2019-04-01 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13366 ) Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length .. Patch Set 3: (2 comments) > Build Successful > >

Change in pysim[master]: wavemobile-sim: write mnc-length field ine EF.AD

2019-04-01 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13478 Change subject: wavemobile-sim: write mnc-length field ine EF.AD .. wavemobile-sim: write mnc-length field ine EF.AD The length field in wavemobile

Change in libosmo-sccp[master]: sccp_scoc: Add more comments describing conn_id and local_ref members

2019-04-01 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13477 ) Change subject: sccp_scoc: Add more comments describing conn_id and local_ref members .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: sccp_scoc: Add more comments describing conn_id and local_ref members

2019-04-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13477 ) Change subject: sccp_scoc: Add more comments describing conn_id and local_ref members .. sccp_scoc: Add more comments describing

Change in libosmo-abis[master]: Add IPA keep-alive FSM implementation

2019-04-01 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13196 ) Change subject: Add IPA keep-alive FSM implementation .. Add IPA keep-alive FSM implementation The IPA keep-alive FSM code takes

Change in libosmo-sccp[master]: sccp_scoc: Add more comments describing conn_id and local_ref members

2019-04-01 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13477 ) Change subject: sccp_scoc: Add more comments describing conn_id and local_ref members .. Patch Set 1: Code-Review+1 -- To view, visit

Change in libosmo-sccp[master]: sccp_scoc: Add more comments describing conn_id and local_ref members

2019-04-01 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13477 Change subject: sccp_scoc: Add more comments describing conn_id and local_ref members .. sccp_scoc: Add more comments describing conn_id and

Change in pysim[master]: sysmo-usim-sjs1: update EF.AD with correct MNC length

2019-04-01 Thread dexter
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13366 to look at the new patch set (#4). Change subject: sysmo-usim-sjs1: update EF.AD with correct MNC length

Change in pysim[master]: fixup

2019-04-01 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/13475 ) Change subject: fixup .. Abandoned -- To view, visit https://gerrit.osmocom.org/13475 To unsubscribe, or for help writing mail filters, visit

Change in pysim[master]: fixup

2019-04-01 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13475 Change subject: fixup .. fixup Change-Id: Iecec05aeaca4ab4578a5a240802c01a24cd52597 --- M pySim/cards.py 1 file changed, 8 insertions(+), 1

Change in pysim[master]: cosmetic: fix sourecode formatting

2019-04-01 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13476 Change subject: cosmetic: fix sourecode formatting .. cosmetic: fix sourecode formatting Change-Id: I4836826811ffb0aeb103d32eb874f5fa52af4186 --- M

Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...

2019-04-01 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. cards: sysmo-usim-sjs1: add

Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...

2019-04-01 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. Patch Set 3: Code-Review+1 --

Change in osmo-msc[master]: Log protocol for which transaction is allocated

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13420 ) Change subject: Log protocol for which transaction is allocated .. Patch Set 2: Code-Review-2 this patch is obsoleted by the patch called

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 5: Code-Review-2 I completely agree with the intent,

Change in osmo-msc[master]: a_iface_bssap: check bssmap length field

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13307 ) Change subject: a_iface_bssap: check bssmap length field .. Patch Set 5: Code-Review-2 In current osmo-msc refactoring, I have the same

Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

2019-04-01 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13450 ) Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() .. libmsc/sms_queue.c: fix memleak in

Change in osmo-msc[master]: tests/sms_queue: track the use of NULL talloc memory contexts

2019-04-01 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13469 ) Change subject: tests/sms_queue: track the use of NULL talloc memory contexts .. tests/sms_queue: track the use of NULL talloc

Change in osmo-msc[master]: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms()

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13450 ) Change subject: libmsc/sms_queue.c: fix memleak in smsq_take_next_sms() .. Patch Set 4: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: libmsc/db.c: fix incorrect SMS UD length truncation

2019-04-01 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13470 ) Change subject: libmsc/db.c: fix incorrect SMS UD length truncation .. Patch Set 1: Code-Review+1 (1 comment) makes sense from the type

Change in osmo-trx[master]: multi-ARFCN: fix maximum number of carriers limitation

2019-04-01 Thread Vadim Yanitskiy
Hello Pau Espin Pedrol, Tom Tsou, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13472 to look at the new patch set (#2). Change subject: multi-ARFCN: fix maximum number of carriers limitation

Change in osmo-trx[master]: multi-ARFCN: fix maximum number of carriers limitation

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13472 ) Change subject: multi-ARFCN: fix maximum number of carriers limitation .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: MT-forwardSM Message Reference fix.

2019-04-01 Thread Mykola Shchetinin
Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13464 ) Change subject: MT-forwardSM Message Reference fix. .. Patch Set 1: > there is still a risk of collision: imagine SMSC initiating a MT

Change in osmo-trx[master]: osmo-trx: Use signalfd to serialize signals in main thread ctx

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13468 ) Change subject: osmo-trx: Use signalfd to serialize signals in main thread ctx .. osmo-trx: Use signalfd to serialize signals in

Change in osmo-trx[master]: osmo-trx: Use signalfd to serialize signals in main thread ctx

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13468 ) Change subject: osmo-trx: Use signalfd to serialize signals in main thread ctx .. Set Ready For Review -- To view, visit

Change in osmo-trx[master]: doc/configuration.adoc: fix incorrect number of physical RF channels ...

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13473 ) Change subject: doc/configuration.adoc: fix incorrect number of physical RF channels for B210 .. Patch Set 1: Code-Review+2 -- To

Change in osmo-trx[master]: multi-ARFCN: fix maximum number of carriers limitation

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13472 ) Change subject: multi-ARFCN: fix maximum number of carriers limitation .. Patch Set 1: Code-Review+1 (2 comments)

Change in osmo-bts[master]: common/oml.c: fix: properly push abis_nm_ipa_magic

2019-04-01 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13471 ) Change subject: common/oml.c: fix: properly push abis_nm_ipa_magic .. Patch Set 1: Code-Review+1 -- To view, visit

Change in gr-gsm[master]: Improve slightly interface of plotting so it's easier to use it

2019-04-01 Thread Piotr Krysik
Piotr Krysik has submitted this change and it was merged. ( https://gerrit.osmocom.org/13474 ) Change subject: Improve slightly interface of plotting so it's easier to use it .. Improve slightly interface of plotting so it's

Change in gr-gsm[master]: Improve slightly interface of plotting so it's easier to use it

2019-04-01 Thread Piotr Krysik
Piotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/13474 ) Change subject: Improve slightly interface of plotting so it's easier to use it .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit

Change in gr-gsm[master]: Improve slightly interface of plotting so it's easier to use it

2019-04-01 Thread Piotr Krysik
Piotr Krysik has uploaded this change for review. ( https://gerrit.osmocom.org/13474 Change subject: Improve slightly interface of plotting so it's easier to use it .. Improve slightly interface of plotting so it's easier to