Change in osmo-mgw[master]: move MGW endpoint FSM from osmo-bsc to here

2019-04-26 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13590 to look at the new patch set (#4). Change subject: move MGW endpoint FSM from osmo-bsc to here .. move MGW endpoint

Change in osmo-mgw[master]: fix: multiple initial CRCX

2019-04-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13591 to look at the new patch set (#4). Change subject: fix: multiple initial CRCX .. fix: multiple initial

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.04/x86_64

2019-04-26 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last

Change in libosmocore[master]: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13259 ) Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr .. Patch Set 11: Given the other patches waiting for this on

Change in osmo-bsc[master]: fix inter-BSC-HO-incoming for AoIP (2/2)

2019-04-26 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13585 to look at the new patch set (#2). Change subject: fix inter-BSC-HO-incoming for AoIP (2/2) .. fix

Change in osmo-bsc[master]: fix inter-BSC-HO-incoming for AoIP (1/2)

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13797 Change subject: fix inter-BSC-HO-incoming for AoIP (1/2) .. fix inter-BSC-HO-incoming for AoIP (1/2) Move the

Change in osmo-bsc[master]: use libosmocore osmo_tdef

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13795 Change subject: use libosmocore osmo_tdef .. use libosmocore osmo_tdef Move the T_defs API to libosmocore as osmo_tdefs: remove the local

Change in osmo-hlr[master]: add missing error log: invalid IMSI

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13587 ) Change subject: add missing error log: invalid IMSI .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/13587/1/src/hlr.c File

Change in osmo-hlr[master]: add missing error log: invalid IMSI

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13587 ) Change subject: add missing error log: invalid IMSI .. add missing error log: invalid IMSI Change-Id:

Change in osmo-hlr[master]: fix error logging for GSUP route

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13517 ) Change subject: fix error logging for GSUP route .. fix error logging for GSUP route The addr may not be nul terminated.

Change in osmo-msc[master]: vlr subscr get/put: also check against NULL

2019-04-26 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13745 ) Change subject: vlr subscr get/put: also check against NULL .. vlr subscr get/put: also check against NULL Change-Id:

Change in osmo-trx[master]: lms: Improve log during flush recv error

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13783 ) Change subject: lms: Improve log during flush recv error .. lms: Improve log during flush recv error Change-Id:

Change in osmo-trx[master]: lms: flush_recv: alloc buf on stack instead of heap

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13782 ) Change subject: lms: flush_recv: alloc buf on stack instead of heap .. lms: flush_recv: alloc buf on stack instead of heap No

Change in osmo-trx[master]: lms: Log underrun/overrun events

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13786 ) Change subject: lms: Log underrun/overrun events .. lms: Log underrun/overrun events Change-Id:

Change in osmo-trx[master]: Move duplicated thread_enable_cancel to CommonLibs

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13785 ) Change subject: Move duplicated thread_enable_cancel to CommonLibs .. Move duplicated thread_enable_cancel to CommonLibs

Change in osmo-trx[master]: lms: Remove unused var m_last_tx_overruns

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13788 ) Change subject: lms: Remove unused var m_last_tx_overruns .. lms: Remove unused var m_last_tx_overruns Change-Id:

Change in osmo-trx[master]: lms: Remove references to ALERT loglevel

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13787 ) Change subject: lms: Remove references to ALERT loglevel .. lms: Remove references to ALERT loglevel ALERT log level is not

Change in osmo-trx[master]: cosmetic: Threads.h: Remove trailing whitespace

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13784 ) Change subject: cosmetic: Threads.h: Remove trailing whitespace .. cosmetic: Threads.h: Remove trailing whitespace Change-Id:

Change in osmo-trx[master]: lms: Catch and log dropped packets by HW during recv

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13789 ) Change subject: lms: Catch and log dropped packets by HW during recv .. lms: Catch and log dropped packets by HW during recv

Change in osmo-trx[master]: lms: Catch and log dropped packets by HW during recv

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13789 ) Change subject: lms: Catch and log dropped packets by HW during recv .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: Remove unused var m_last_tx_overruns

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13788 ) Change subject: lms: Remove unused var m_last_tx_overruns .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13788

Change in osmo-trx[master]: lms: Remove references to ALERT loglevel

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13787 ) Change subject: lms: Remove references to ALERT loglevel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13787

Change in osmo-trx[master]: lms: Log underrun/overrun events

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13786 ) Change subject: lms: Log underrun/overrun events .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13786 To

Change in osmo-trx[master]: Move duplicated thread_enable_cancel to CommonLibs

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13785 ) Change subject: Move duplicated thread_enable_cancel to CommonLibs .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: cosmetic: Threads.h: Remove trailing whitespace

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13784 ) Change subject: cosmetic: Threads.h: Remove trailing whitespace .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: flush_recv: alloc buf on stack instead of heap

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13782 ) Change subject: lms: flush_recv: alloc buf on stack instead of heap .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: Improve log during flush recv error

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13783 ) Change subject: lms: Improve log during flush recv error .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13783

Change in osmo-msc[master]: libmsc/db.c: fix storing SMS with empty TP-User-Data

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13630 ) Change subject: libmsc/db.c: fix storing SMS with empty TP-User-Data .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: jenkins docker: Install lcov and lcov-cobertura

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13551 ) Change subject: jenkins docker: Install lcov and lcov-cobertura .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: ansible: Document how to use ProxyJump to access ipv6 nodes

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13794 ) Change subject: ansible: Document how to use ProxyJump to access ipv6 nodes .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ci[master]: ansible: Document how to use ProxyJump to access ipv6 nodes

2019-04-26 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13794 ) Change subject: ansible: Document how to use ProxyJump to access ipv6 nodes .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: ansible: Document how to use ProxyJump to access ipv6 nodes

2019-04-26 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13794 ) Change subject: ansible: Document how to use ProxyJump to access ipv6 nodes .. ansible: Document how to use ProxyJump to access ipv6

Change in osmo-ci[master]: generalize the install-poky-sdk role to support multiple sdks

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13793 ) Change subject: generalize the install-poky-sdk role to support multiple sdks .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-ci[master]: osmocom-jenkins-slave: fix jessie-backports as it got deprecated

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13792 ) Change subject: osmocom-jenkins-slave: fix jessie-backports as it got deprecated .. Patch Set 2: Code-Review+2 (1 comment)

Change in osmo-ci[master]: osmocom-jenkins-slave: fix jessie-backports as it got deprecated

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13792 ) Change subject: osmocom-jenkins-slave: fix jessie-backports as it got deprecated .. osmocom-jenkins-slave: fix jessie-backports

Change in osmo-ci[master]: generalize the install-poky-sdk role to support multiple sdks

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13793 ) Change subject: generalize the install-poky-sdk role to support multiple sdks .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: generalize the install-poky-sdk role to support multiple sdks

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/13793 ) Change subject: generalize the install-poky-sdk role to support multiple sdks .. generalize the install-poky-sdk role to support

Change in osmo-ci[master]: osmocom-jenkins-slave: fix jessie-backports as it got deprecated

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13792 ) Change subject: osmocom-jenkins-slave: fix jessie-backports as it got deprecated .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-ci[master]: ansible: Document how to use ProxyJump to access ipv6 nodes

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13794 Change subject: ansible: Document how to use ProxyJump to access ipv6 nodes .. ansible: Document how to use ProxyJump to access ipv6

Change in osmo-ci[master]: osmocom-jenkins-slave: fix jessie-backports as it got deprecated

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded a new patch set (#2) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/13792 ) Change subject: osmocom-jenkins-slave: fix jessie-backports as it got deprecated ..

Change in osmo-ci[master]: generalize the install-poky-sdk role to support multiple sdks

2019-04-26 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13793 Change subject: generalize the install-poky-sdk role to support multiple sdks .. generalize the install-poky-sdk role to support multiple

Change in osmo-ci[master]: osmocom-jenkins-slave: fix jessie-backports as it got deprecated

2019-04-26 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13792 Change subject: osmocom-jenkins-slave: fix jessie-backports as it got deprecated .. osmocom-jenkins-slave: fix jessie-backports as it got

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use 0.0 as default for mp_ipa_up_delay

2019-04-26 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13791 ) Change subject: BTS_Tests: use 0.0 as default for mp_ipa_up_delay .. BTS_Tests: use 0.0 as default for mp_ipa_up_delay The module

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use 0.0 as default for mp_ipa_up_delay

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13791 ) Change subject: BTS_Tests: use 0.0 as default for mp_ipa_up_delay .. Patch Set 1: You are going to have issues with real HW tests then

Change in osmo-ttcn3-hacks[master]: BTS_Tests: use 0.0 as default for mp_ipa_up_delay

2019-04-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13791 ) Change subject: BTS_Tests: use 0.0 as default for mp_ipa_up_delay .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13609 ) Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) .. Patch Set 4: Some comment/reference to what PCO is would

Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/13608/4/ggsn/ggsn.c File ggsn/ggsn.c:

Change in osmo-msc[master]: libmsc/db.c: fix storing SMS with empty TP-User-Data

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13630 ) Change subject: libmsc/db.c: fix storing SMS with empty TP-User-Data .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13630/1//COMMIT_MSG

Change in osmo-msc[master]: Introduce initial unit test for db_sms_* API

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13629 ) Change subject: Introduce initial unit test for db_sms_* API .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13629/1/src/libmsc/db.c File

Change in osmo-msc[master]: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13655 ) Change subject: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length .. Patch Set 1: (2 comments)

Change in libosmocore[master]: make all library-internal static buffers thread-local

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13436 ) Change subject: make all library-internal static buffers thread-local .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/13436/6//COMMIT_MSG

Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13723 ) Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence .. Patch Set 4: (2 comments)

Change in osmo-trx[master]: lms: flush_recv: alloc buf on stack instead of heap

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13782 ) Change subject: lms: flush_recv: alloc buf on stack instead of heap .. Patch Set 1: > Using the stack is quicker. What makes you think that? Do you

Change in osmo-trx[master]: lms: Remove references to ALERT loglevel

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13787 ) Change subject: lms: Remove references to ALERT loglevel .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13787 To

Change in osmo-trx[master]: lms: Remove unused var m_last_tx_overruns

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13788 ) Change subject: lms: Remove unused var m_last_tx_overruns .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13788 To

Change in osmo-trx[master]: cosmetic: Threads.h: Remove trailing whitespace

2019-04-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13784 ) Change subject: cosmetic: Threads.h: Remove trailing whitespace .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13784 To

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-04-26 Thread Mykola Shchetinin
Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. .. Patch Set 7: (1 comment)

Change in osmo-sgsn[master]: gprs_gmm: send Service Reject when no PDP ctxs are available.

2019-04-26 Thread Mykola Shchetinin
Hello lynxis lazus, Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13744 to look at the new patch set (#7). Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available.

Change in docker-playground[master]: Add script to bisect test failures with ttcn3 and docker

2019-04-26 Thread Daniel Willmann
Daniel Willmann has posted comments on this change. ( https://gerrit.osmocom.org/13790 ) Change subject: Add script to bisect test failures with ttcn3 and docker .. Patch Set 1: Verified+1 Worked in my tests. Not used in

Change in docker-playground[master]: Add script to bisect test failures with ttcn3 and docker

2019-04-26 Thread Daniel Willmann
Daniel Willmann has uploaded this change for review. ( https://gerrit.osmocom.org/13790 Change subject: Add script to bisect test failures with ttcn3 and docker .. Add script to bisect test failures with ttcn3 and docker With

Change in docker-playground[master]: Add OSMO_*_BRANCH environment variables for build args

2019-04-26 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13779 ) Change subject: Add OSMO_*_BRANCH environment variables for build args .. Add OSMO_*_BRANCH environment variables for build args