Change in libosmocore[master]: Add code coverage support

2019-10-28 Thread vvvelichkov
vvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13496 ) Change subject: Add code coverage support .. Patch Set 7: > Patch Set 6: > > > Let me know if I have to modify some of the

Change in libosmocore[master]: Add code coverage support

2019-10-28 Thread vvvelichkov
Hello fixeria, Max, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/13496 to look at the new patch set (#7). Change subject: Add code coverage support

Change in osmo-dev[master]: ttcn3: run ttcn3 testsuites from osmo-dev

2019-10-28 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/15778 ) Change subject: ttcn3: run ttcn3 testsuites from osmo-dev .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: also log MNCC_SETUP_REQ

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15845 ) Change subject: also log MNCC_SETUP_REQ .. Patch Set 1: Code-Review+1 Back to pespin -- To view, visit

Change in osmo-bts[master]: scheduler_trx: use gsm0502_fn_remap() to calculate frame number

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15757 ) Change subject: scheduler_trx: use gsm0502_fn_remap() to calculate frame number .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block .. Patch Set 9: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm0508: add functions to calculate beginning of a block

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15719 ) Change subject: gsm0508: add functions to calculate beginning of a block .. gsm0508: add functions to calculate beginning of a block The

Change in osmocom-bb[master]: Fix typo: miliseconds -> milliseconds

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/15791 ) Change subject: Fix typo: miliseconds -> milliseconds .. Fix typo: miliseconds -> milliseconds Change-Id:

Change in osmo-msc[master]: CC: add error handling for CRCX responses

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15853 ) Change subject: CC: add error handling for CRCX responses .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: rtp_stream: sanely cancel MGW endpoint FSM notify

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15851 ) Change subject: rtp_stream: sanely cancel MGW endpoint FSM notify .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: use osmo_sockaddr_str_is_nonzero()

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15852 ) Change subject: use osmo_sockaddr_str_is_nonzero() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: jobs: Introduce ttcn3-stp-test(-latest) jenkins job

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/15873 ) Change subject: jobs: Introduce ttcn3-stp-test(-latest) jenkins job .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: accept MGCP without SDP

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15840 ) Change subject: accept MGCP without SDP .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: clear pending requests on MGCP failure

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15837 ) Change subject: clear pending requests on MGCP failure .. clear pending requests on MGCP failure If an MGCP operation on one conn of an

Change in osmo-mgw[master]: mgcp_client_fsm cleanup: Do not assert on DLCX failure

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15836 ) Change subject: mgcp_client_fsm cleanup: Do not assert on DLCX failure .. mgcp_client_fsm cleanup: Do not assert on DLCX failure During FSM

Change in osmo-mgw[master]: clear pending requests on MGCP failure

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15837 ) Change subject: clear pending requests on MGCP failure .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: mgcp_client_fsm cleanup: Do not assert on DLCX failure

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15836 ) Change subject: mgcp_client_fsm cleanup: Do not assert on DLCX failure .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 ) Change subject: fsm: add osmo_fsm_set_term_stops_actions() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: fsm_dealloc_test: enable term_stops_actions

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15834 ) Change subject: fsm_dealloc_test: enable term_stops_actions .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: fsm: add osmo_fsm_set_term_stops_actions()

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15833 ) Change subject: fsm: add osmo_fsm_set_term_stops_actions() .. Patch Set 1: Agreeing with pau, we shoould try to make the New

Change in libosmocore[master]: add osmo_sockaddr_str_is_nonzero()

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15835 ) Change subject: add osmo_sockaddr_str_is_nonzero() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 ) Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free .. Patch Set 2: I'm not particularly happy about all

Change in libosmo-sccp[master]: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15862 ) Change subject: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known .. ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if

Change in libosmo-sccp[master]: xua: Verify all route ctxs received in ASPAC msg

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15874 ) Change subject: xua: Verify all route ctxs received in ASPAC msg .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15862 ) Change subject: ss7: Set Traffic mode and Route Ctx in ASPAC ACK msg if known .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: xua: Verify all route ctxs received in ASPAC msg

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15874 ) Change subject: xua: Verify all route ctxs received in ASPAC msg .. xua: Verify all route ctxs received in ASPAC msg Change-Id:

Change in libosmo-sccp[master]: ss7: Only override traffic mode from recv REG REQ if not set by VTY

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15804 ) Change subject: ss7: Only override traffic mode from recv REG REQ if not set by VTY .. Patch Set 6: Code-Review+2 -- To view,

Change in libosmo-sccp[master]: ss7: Implement AS traffic mode loadshare using round robin ASP selection

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15802 ) Change subject: ss7: Implement AS traffic mode loadshare using round robin ASP selection .. ss7: Implement AS traffic mode loadshare

Change in libosmo-sccp[master]: ss7: Set configured AS traffic mode when sending Routing Key Register...

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15803 ) Change subject: ss7: Set configured AS traffic mode when sending Routing Key Register msg .. ss7: Set configured AS traffic mode when

Change in libosmo-sccp[master]: ss7: Only override traffic mode from recv REG REQ if not set by VTY

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15804 ) Change subject: ss7: Only override traffic mode from recv REG REQ if not set by VTY .. ss7: Only override traffic mode from recv REG REQ

Change in libosmocore[master]: vty: Return error if cmd returns CMD_WARNING while reading cfg file

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15827 ) Change subject: vty: Return error if cmd returns CMD_WARNING while reading cfg file .. vty: Return error if cmd returns CMD_WARNING while

Change in libosmocore[master]: vty: Return error if cmd returns CMD_WARNING while reading cfg file

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15827 ) Change subject: vty: Return error if cmd returns CMD_WARNING while reading cfg file .. Patch Set 2: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15881 ) Change subject: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT .. Patch Set 2: Code-Review+2 -- To view,

Change in docker-playground[master]: Introduce ttcn3-stp-test

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/15872 ) Change subject: Introduce ttcn3-stp-test .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883 ) Change subject: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT .. Patch Set 2: Code-Review+2 -- To

Change in osmo-bsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15882 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. Patch Set 1: Actually, at second thought

Change in osmo-bsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2019-10-28 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15882 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. rsl: Send IE MS Power Param during CHAN ACT and MS PWR

Change in osmo-bsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15882 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-bsc[master]: bsc_vty: Fix typo in 'no depends-on-bts' cmd

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15880 ) Change subject: bsc_vty: Fix typo in 'no depends-on-bts' cmd .. bsc_vty: Fix typo in 'no depends-on-bts' cmd Change-Id:

Change in osmo-bsc[master]: bsc_vty: Fix typo in 'no depends-on-bts' cmd

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15880 ) Change subject: bsc_vty: Fix typo in 'no depends-on-bts' cmd .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: configure: Introduce --disable-libsctp and error by default if libsct...

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15871 ) Change subject: configure: Introduce --disable-libsctp and error by default if libsctp not found .. Patch Set 2: Code-Review+2

Change in osmo-bts[master]: cosmetic: l1sap.c: Fix typo

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15879 ) Change subject: cosmetic: l1sap.c: Fix typo .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: cosmetic: l1sap.c: Fix typo

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15879 ) Change subject: cosmetic: l1sap.c: Fix typo .. cosmetic: l1sap.c: Fix typo Change-Id: I9fee7be915546cfd11810c74d511beb8ec10d044 --- M

Change in libosmocore[master]: configure: Introduce --disable-libsctp and error by default if libsct...

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15871 ) Change subject: configure: Introduce --disable-libsctp and error by default if libsctp not found .. configure: Introduce --disable-libsctp

Change in libosmocore[master]: socket.c: build multiaddr socket API helpers only if used by public APIs

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15870 ) Change subject: socket.c: build multiaddr socket API helpers only if used by public APIs .. socket.c: build multiaddr socket API helpers

Change in libosmocore[master]: socket.c: build multiaddr socket API helpers only if used by public APIs

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15870 ) Change subject: socket.c: build multiaddr socket API helpers only if used by public APIs .. Patch Set 1: Code-Review+2 -- To

Change in osmo-bts[master]: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits .. bts-trx: loops.c: Take into account RSL CHAN ACT ms

Change in osmo-bts[master]: loops.h: Fix missing include for struct l1sched_trx

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15878 ) Change subject: loops.h: Fix missing include for struct l1sched_trx .. loops.h: Fix missing include for struct l1sched_trx Change-Id:

Change in osmo-bts[master]: power_control.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15884 ) Change subject: power_control.c: Take into account RSL CHAN ACT ms power level limits .. power_control.c: Take into account RSL CHAN ACT ms

Change in osmo-bts[master]: power_control.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15884 ) Change subject: power_control.c: Take into account RSL CHAN ACT ms power level limits .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-bts[master]: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15877 ) Change subject: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits .. Patch Set 3: Code-Review+2 -- To view,

Change in osmo-bts[master]: cosmetic: bts-trx: document variable power level

2019-10-28 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable power level .. cosmetic: bts-trx: document variable power level Change-Id:

Change in osmo-bts[master]: cosmetic: bts-trx: document variable power level

2019-10-28 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable power level .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: power_control.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15884 ) Change subject: power_control.c: Take into account RSL CHAN ACT ms power level limits .. power_control.c: Take into account RSL

Change in osmo-ttcn3-hacks[master]: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT

2019-10-28 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883 to look at the new patch set (#2). Change subject: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT

Change in osmo-ttcn3-hacks[master]: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT

2019-10-28 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883 ) Change subject: bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT .. bsc: Verify ms power level value

Change in osmo-ttcn3-hacks[master]: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT

2019-10-28 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15881 to look at the new patch set (#2). Change subject: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT

Change in osmo-bsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2019-10-28 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15882 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. rsl: Send IE MS Power Param during CHAN ACT

Change in osmo-ttcn3-hacks[master]: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT

2019-10-28 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15881 ) Change subject: bsc: Verify RSL IE MS Power Parameters is send upon CHAN ACT .. bsc: Verify RSL IE MS Power Parameters is

Change in osmo-bsc[master]: bsc_vty: Fix typo in 'no depends-on-bts' cmd

2019-10-28 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15880 ) Change subject: bsc_vty: Fix typo in 'no depends-on-bts' cmd .. bsc_vty: Fix typo in 'no depends-on-bts' cmd Change-Id:

Change in osmo-bts[master]: cosmetic: bts-trx: document variable power level

2019-10-28 Thread pespin
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15876 to look at the new patch set (#2). Change subject: cosmetic: bts-trx: document variable power level

Change in osmo-bts[master]: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits

2019-10-28 Thread pespin
Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15877 to look at the new patch set (#3). Change subject: bts-trx: loops.c: Take into account RSL CHAN ACT ms power level limits

Change in osmo-bts[master]: cosmetic: bts-trx: document variable and fix typo in ms_power_diff()

2019-10-28 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15876 ) Change subject: cosmetic: bts-trx: document variable and fix typo in ms_power_diff() .. Patch Set 1: (1 comment)

Build failed in Jenkins: master-simtrace2 ยป a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #551

2019-10-28 Thread jenkins
See -- [...truncated 157.39 KB...] 1216 0 5211737 6c9 obj/owhw/dfu_uart_console.o