Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-04 Thread Robert Falkenberg
Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 ) Change subject: Set uSIM to 'type approval operations' in EF['AD'] .. Patch Set 1: The ``EF_AD`` field contains administrativ

Change in pysim[master]: Set uSIM to 'type approval operations' in EF['AD']

2021-04-04 Thread Robert Falkenberg
Robert Falkenberg has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23632 ) Change subject: Set uSIM to 'type approval operations' in EF['AD'] .. Set uSIM to 'type approval operations' in EF['AD'] Cha

Change in pysim[master]: Use zero padding for EF['ACC'] field

2021-04-04 Thread Robert Falkenberg
Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Patch Set 1: The ``EF_ACC`` field defines the access control class (A

Change in pysim[master]: Use zero padding for EF['ACC'] field

2021-04-04 Thread Robert Falkenberg
Robert Falkenberg has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/23631 ) Change subject: Use zero padding for EF['ACC'] field .. Use zero padding for EF['ACC'] field Change-Id: I1b8dc01a6c48adad1ed

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.04/x86_64

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_20.10/x86_64

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_20.10/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_20.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Change in libosmocore[master]: vty/logging: logp: properly handle library specific sub-systems

2021-04-04 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/23630 to look at the new patch set (#3). Change subject: vty/logging: logp: properly handle library specific sub-systems ...

Change in libosmocore[master]: vty/logging: ensure consistent '%' prefix for warnings

2021-04-04 Thread fixeria
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/23629 to look at the new patch set (#2). Change subject: vty/logging: ensure consistent '%' prefix for warnings

Change in libosmocore[master]: vty/logging: logp: properly handle library specific sub-systems

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23630 ) Change subject: vty/logging: logp: properly handle library specific sub-systems .. vty/logging: logp: properly handle library spe

Change in libosmocore[master]: vty/logging: ensure consistent '%' prefix for warnings

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23629 ) Change subject: vty/logging: ensure consistent '%' prefix for warnings .. vty/logging: ensure consistent '%' prefix for warnings

Change in libosmocore[master]: vty/logging: use consistent quiting in warning messages

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/23628 ) Change subject: vty/logging: use consistent quiting in warning messages .. vty/logging: use consistent quiting in warning message

Build failure of network:osmocom:nightly/simtrace2 in xUbuntu_18.04/x86_64

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of bui

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/x86_64

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log:

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/i586

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/i586 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/armv7l

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/armv7l Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log:

Build failure of network:osmocom:nightly/simtrace2 in Debian_9.0/aarch64

2021-04-04 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_9.0/aarch64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build lo

Jenkins build is back to normal : master-osmo-sip-connector ยป a1=default,a2=default,a3=default,a4=default,osmocom-master-debian9 #3363

2021-04-04 Thread jenkins
See

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23615 ) Change subject: minor add comments .. minor add comments this is just to better understand the flow Change-Id: I045286836176da729cc8c863866d

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23615 ) Change subject: minor add comments .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23615

Change in simtrace2[master]: add ISO 7816-3 library to remsim project

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23613 ) Change subject: add ISO 7816-3 library to remsim project .. add ISO 7816-3 library to remsim project Change-Id: I99f3fecbc00d2379c3a6dc457b04

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23614 ) Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} .. rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} While this differs from th

Change in simtrace2[master]: add library providing ISO 7816-3 utilities

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23612 ) Change subject: add library providing ISO 7816-3 utilities .. add library providing ISO 7816-3 utilities this will become part of libosmocore

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23614 ) Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osm

Change in simtrace2[master]: add library providing ISO 7816-3 utilities

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23612 ) Change subject: add library providing ISO 7816-3 utilities .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.

Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23617 ) Change subject: cardemu: different init for simtrace board which uses uart timers .. Patch Set 2: Code-Review-1 I have the feeling

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23615 ) Change subject: minor add comments .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23615

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23614 ) Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osm

Change in simtrace2[master]: add library providing ISO 7816-3 utilities

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23612 ) Change subject: add library providing ISO 7816-3 utilities .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.

Change in simtrace2[master]: cardem: Use USART timeout for waiting time

2021-04-04 Thread laforge
Hello Jenkins Builder, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23620 to look at the new patch set (#2). Change subject: cardem: Use USART timeout for waiting time ..

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
Hello Jenkins Builder, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23615 to look at the new patch set (#2). Change subject: minor add comments .. minor add comments

Change in simtrace2[master]: cardem: use edge-triggered VCC ADC logic

2021-04-04 Thread laforge
Hello Jenkins Builder, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23616 to look at the new patch set (#2). Change subject: cardem: use edge-triggered VCC ADC logic

Change in simtrace2[master]: rename PIN_PHONE_{CLK, IO} to PIN_USIM1_{CLK, IO}

2021-04-04 Thread laforge
Hello Jenkins Builder, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23614 to look at the new patch set (#2). Change subject: rename PIN_PHONE_{CLK,IO} to PIN_USIM1_{CLK,IO} .

Change in simtrace2[master]: add library providing ISO 7816-3 utilities

2021-04-04 Thread laforge
Hello Jenkins Builder, tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23612 to look at the new patch set (#2). Change subject: add library providing ISO 7816-3 utilities ..

Change in osmo-bsc[master]: abis_nm: finally handle BTS_TYPE_VARIANT, match BTS type

2021-04-04 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18618 ) Change subject: abis_nm: finally handle BTS_TYPE_VARIANT, match BTS type .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/

Change in osmo-bsc[master]: abis_nm: rework warnings about unknown / not supported features

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18599 ) Change subject: abis_nm: rework warnings about unknown / not supported features .. Patch Set 7: (1 comment) https://gerrit.osmocom.

Change in osmo-bsc[master]: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types

2021-04-04 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18616 ) Change subject: Split GSM_BTS_TYPE_OSMOBTS to individual BTS types .. Abandoned See https://gerrit.osmocom.org/c/osmo-bsc/+/23625. -- To view

Change in osmo-bsc[master]: Replace all references to 'sysmobts' with 'osmo-bts'

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23627 ) Change subject: Replace all references to 'sysmobts' with 'osmo-bts' .. Replace all references to 'sysmobts' with 'osmo-bts' sysmoB

Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...

2021-04-04 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 ) Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. .. Patch Set 4: Sorry, I pushed to Patchs

Change in ...osmo-python-tests[master]: Use proper python3 shebang in all modules

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/23626 ) Change subject: Use proper python3 shebang in all modules .. Use proper python3 shebang in all modules Change-Id: I

Change in osmo-bsc[master]: vty: deprecate BTS type 'sysmobts' in favor of 'osmo-bts'

2021-04-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23625 ) Change subject: vty: deprecate BTS type 'sysmobts' in favor of 'osmo-bts' .. vty: deprecate BTS type 'sysmobts' in favor of 'osmo-bt

Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...

2021-04-04 Thread keith
keith has uploaded a new patch set (#4) to the change originally created by ipse. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 ) Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. ..

Change in osmo-bsc[master]: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR s...

2021-04-04 Thread keith
keith has uploaded a new patch set (#3) to the change originally created by ipse. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18703 ) Change subject: stats: Count transitions from BORKEN state due to LCHAN_EV_TS_ERROR signal. ..

Change in simtrace2[master]: cardem: currently simtrace does not support cardem

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23619 ) Change subject: cardem: currently simtrace does not support cardem .. cardem: currently simtrace does not support cardem the SIMtrace board d

Change in simtrace2[master]: cardem: use USART timeout for waiting time

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23620 ) Change subject: cardem: use USART timeout for waiting time .. Patch Set 1: (5 comments) https://gerrit.osmocom.org/c/simtrace2/+/2

Change in simtrace2[master]: cardem: use USART timeout for waiting time

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23620 ) Change subject: cardem: use USART timeout for waiting time .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/simtrace2/+/2

Change in simtrace2[master]: cardem: currently simtrace does not support cardem

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23619 ) Change subject: cardem: currently simtrace does not support cardem .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.

Change in simtrace2[master]: make sim switch board specific

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23618 ) Change subject: make sim switch board specific .. Patch Set 1: the point here is that not only the type of switch is different, but

Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23617 ) Change subject: cardemu: different init for simtrace board which uses uart timers .. Patch Set 1: the goal is probably to move awa

Change in simtrace2[master]: different voltage comparison on powerup

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23616 ) Change subject: different voltage comparison on powerup .. Patch Set 1: needs a better description in the commit log. I will work o

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23615 ) Change subject: minor add comments .. Patch Set 1: Code-Review-1 the general coding style in Osmcoom is /* not //, I will re-work t

Change in simtrace2[master]: rename PIN_PHONE_IO to PIN_USIM1_IO

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23614 ) Change subject: rename PIN_PHONE_IO to PIN_USIM1_IO .. Patch Set 1: IMHO it doesn't make sense to rename only the IO pin but keep t

Change in simtrace2[master]: add ISO 7816-3 library to remsim project

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23613 ) Change subject: add ISO 7816-3 library to remsim project .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 ) Change subject: cardem: choose a more reasonable default ATR .. cardem: choose a more reasonable default ATR PCSCd does not like invalid ATRs

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 ) Change subject: cardem: choose a more reasonable default ATR .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmoco

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 ) Change subject: cardem: choose a more reasonable default ATR .. Patch Set 2: Code-Review+1 Looks good to me now. -- To view, visi

Change in osmo-bsc[master]: bts_osmobts: update the list of supported features

2021-04-04 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18617 ) Change subject: bts_osmobts: update the list of supported features .. Abandoned Ok, I see. This change is just a result of my misunderstandin

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 ) Change subject: cardem: choose a more reasonable default ATR .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/simtrace2/+

Change in simtrace2[master]: cardem: ensure VCC_PHONE is floating

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23621 to review the following change. Change subject: cardem: ensure VCC_PHONE is floating .. cardem: ensure VCC_PH

Change in simtrace2[master]: cardem: fix TPDU state check

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23622 to review the following change. Change subject: cardem: fix TPDU state check .. cardem: fix TPDU state check

Change in simtrace2[master]: Revert "cardem: disable upload for simtrace2"

2021-04-04 Thread laforge
Hello Hoernchen, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23624 to review the following change. Change subject: Revert "cardem: disable upload for simtrace2" .. Revert "carde

Change in simtrace2[master]: cardem: ignore set ATR

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23623 to review the following change. Change subject: cardem: ignore set ATR .. cardem: ignore set ATR the PPS pro

Change in simtrace2[master]: cardem: currently simtrace does not support cardem

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23619 to review the following change. Change subject: cardem: currently simtrace does not support cardem .. cardem:

Change in simtrace2[master]: cardem: use USART timeout for waiting time

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23620 to review the following change. Change subject: cardem: use USART timeout for waiting time .. cardem: use USA

Change in simtrace2[master]: make sim switch board specific

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23618 to review the following change. Change subject: make sim switch board specific .. make sim switch board speci

Change in simtrace2[master]: different voltage comparison on powerup

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23616 to review the following change. Change subject: different voltage comparison on powerup .. different voltage

Change in simtrace2[master]: cardemu: different init for simtrace board which uses uart timers

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23617 to review the following change. Change subject: cardemu: different init for simtrace board which uses uart timers ...

Change in simtrace2[master]: minor add comments

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23615 to review the following change. Change subject: minor add comments .. minor add comments this is just to bet

Change in simtrace2[master]: rename PIN_PHONE_IO to PIN_USIM1_IO

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23614 to review the following change. Change subject: rename PIN_PHONE_IO to PIN_USIM1_IO .. rename PIN_PHONE_IO to

Change in simtrace2[master]: add library providing ISO 7816-3 utilities

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23612 to review the following change. Change subject: add library providing ISO 7816-3 utilities .. add library pro

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread laforge
Hello Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23611 to look at the new patch set (#2). Change subject: cardem: choose a more reasonable default ATR .

Change in simtrace2[master]: add ISO 7816-3 library to remsim project

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23613 to review the following change. Change subject: add ISO 7816-3 library to remsim project .. add ISO 7816-3 li

Change in osmo-bsc[master]: abis_nm: rework warnings about unknown / not supported features

2021-04-04 Thread fixeria
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18599 to look at the new patch set (#7). Change subject: abis_nm: rework warnings about unknown / not supported features .

Change in osmo-bsc[master]: abis_nm: cosmetic: use osmo_bts_feature_name()

2021-04-04 Thread fixeria
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18604 to look at the new patch set (#6). Change subject: abis_nm: cosmetic: use osmo_bts_feature_name() ..

Change in osmo-bsc[master]: bts_osmobts: update the list of supported features

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18617 ) Change subject: bts_osmobts: update the list of supported features .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bs

Change in libosmocore[master]: gprs_ns2: add vty `nse <0-65535> restart sns`

2021-04-04 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23184 ) Change subject: gprs_ns2: add vty `nse <0-65535> restart sns` .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libo

Change in osmo-bsc[master]: abis_nm: rework warnings about unknown / not supported features

2021-04-04 Thread fixeria
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18599 to look at the new patch set (#6). Change subject: abis_nm: rework warnings about unknown / not supported features .

Change in osmo-bsc[master]: abis_nm: cosmetic: use osmo_bts_feature_name()

2021-04-04 Thread fixeria
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18604 to look at the new patch set (#4). Change subject: abis_nm: cosmetic: use osmo_bts_feature_name() ..

Change in osmo-bsc[master]: abis_nm: rework warnings about unknown / not supported features

2021-04-04 Thread fixeria
Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/18599 to look at the new patch set (#5). Change subject: abis_nm: rework warnings about unknown / not supported features .

Change in osmo-dev[master]: net/templates/osmo-sgsn.cfg: update format

2021-04-04 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/23418 ) Change subject: net/templates/osmo-sgsn.cfg: update format .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmo

Change in osmo-dev[master]: net/templates/osmo-gbproxy.cfg: update format

2021-04-04 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/23419 ) Change subject: net/templates/osmo-gbproxy.cfg: update format .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.o

Change in libosmocore[master]: ns2: Dump frame relay state to VTY during "show ns"

2021-04-04 Thread lynxis lazus
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23546 ) Change subject: ns2: Dump frame relay state to VTY during "show ns" .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/

Change in osmo-bsc[master]: abis_nm: properly warn about unknown / not supported features

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18599 ) Change subject: abis_nm: properly warn about unknown / not supported features .. Patch Set 4: (1 comment) https://gerrit.osmocom.or

Change in osmo-bsc[master]: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21644 ) Change subject: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state .. debug log, lchan_fsm: explain leaving wait_rll_rtp_estab

Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 ) Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63 .. Ignore CHANnel ReQuireD with Access Delay IE > 63 It is observed that a C

Change in osmo-bsc[master]: Ignore CHANnel ReQuireD with Access Delay IE > 63

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23574 ) Change subject: Ignore CHANnel ReQuireD with Access Delay IE > 63 .. Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc

Change in simtrace2[master]: firmware: allow verbose builds

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23610 ) Change subject: firmware: allow verbose builds .. firmware: allow verbose builds make V=1 can be used to echo all compilation commands, which

Change in simtrace2[master]: firmware: do not allow undefined symbols

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23609 ) Change subject: firmware: do not allow undefined symbols .. firmware: do not allow undefined symbols For some reason undefined symbols were d

Change in simtrace2[master]: minor: use same LED pattern for cardem as other applications

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23608 ) Change subject: minor: use same LED pattern for cardem as other applications .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in simtrace2[master]: minor: use same LED pattern for cardem as other applications

2021-04-04 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23608 ) Change subject: minor: use same LED pattern for cardem as other applications .. minor: use same LED pattern for cardem as other applications

Change in simtrace2[master]: firmware: do not allow undefined symbols

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23609 ) Change subject: firmware: do not allow undefined symbols .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.or

Change in simtrace2[master]: firmware: allow verbose builds

2021-04-04 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23610 ) Change subject: firmware: allow verbose builds .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtra

Change in osmo-bsc[master]: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21644 ) Change subject: debug log, lchan_fsm: explain leaving wait_rll_rtp_establish state .. Patch Set 5: Code-Review+2 -- To view, visit

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23611 ) Change subject: cardem: choose a more reasonable default ATR .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/simtrace2/+

Change in simtrace2[master]: firmware: allow verbose builds

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23610 ) Change subject: firmware: allow verbose builds .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtra

Change in simtrace2[master]: firmware: do not allow undefined symbols

2021-04-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23609 ) Change subject: firmware: do not allow undefined symbols .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in simtrace2[master]: minor: use same LED pattern for cardem as other applications

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23608 to look at the new patch set (#2). Change subject: minor: use same LED pattern for cardem as other applications .

Change in simtrace2[master]: firmware: do not allow undefined symbols

2021-04-04 Thread laforge
Hello Hoernchen, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23609 to review the following change. Change subject: firmware: do not allow undefined symbols .. firmware: do not a

Change in simtrace2[master]: cardem: choose a more reasonable default ATR

2021-04-04 Thread laforge
Hello Hoernchen, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23611 to review the following change. Change subject: cardem: choose a more reasonable default ATR .. cardem: choose

Change in simtrace2[master]: firmware: allow verbose builds

2021-04-04 Thread laforge
Hello Hoernchen, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23610 to review the following change. Change subject: firmware: allow verbose builds .. firmware: allow verbose buil

Change in simtrace2[master]: minor: use same LED pattern for cardem as other opplications

2021-04-04 Thread laforge
Hello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23608 to review the following change. Change subject: minor: use same LED pattern for cardem as other opplications .

  1   2   >