[S] Change in gapk[master]: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence

2023-03-27 Thread Matan Perelman
Attention is currently required from: Matan Perelman. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/gapk/+/32094 to look at the new patch set (#2). Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence .

[S] Change in gapk[master]: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence

2023-03-27 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence .. Patch Set 1: (1 comment) File src/fmt_rtp_efr.

[S] Change in gapk[master]: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence

2023-03-27 Thread Matan Perelman
Matan Perelman has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence .. fmt_rtp_amr,fmt_rtp_efr: replace damaged packets

[S] Change in osmo-msc[master]: coverity: sdp_msg_test.c: check rc of sdp_msg_from_sdp_str()

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31864 ) Change subject: coverity: sdp_msg_test.c: check rc of sdp_msg_from_sdp_str() .. coverity: sdp_msg_test.c: check rc of sdp_msg_from_sdp_str() Rel

[S] Change in libosmocore[master]: logging: add timestamp fmt 'date' = 2018-01-16,01:44:34.681

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5815 ) Change subject: logging: add timestamp fmt 'date' = 2018-01-16,01:44:34.681 .. Patch

[M] Change in libosmocore[master]: logging vty: add 'logging print timestamp', deprecate other timestamp...

2023-03-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5861 ) Change subject: logging vty: add 'logging print timestamp', deprecate other timestamp cmds .. Patch Set 4: This change is ready for

[M] Change in libosmocore[master]: logging: use enum to set timestamp format

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5857 ) Change subject: logging: use enum to set timestamp format .. Patch Set 6: This chang

[M] Change in libosmocore[master]: logging: add 'logging timezone (localtime|utc)'

2023-03-27 Thread neels
Attention is currently required from: laforge, fixeria, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32043 to look at the new patch set (#2). Change subject: logging: add 'logging timezone (localtime|utc

[S] Change in libosmocore[master]: logging_vty.c: rename static function

2023-03-27 Thread neels
Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32045 ) Change subject: logging_vty.c: rename static function .. Patch Set 1: (1 co

[M] Change in libosmocore[master]: logging: add 'logging timezone (localtime|utc)'

2023-03-27 Thread neels
Attention is currently required from: laforge, fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32043 ) Change subject: logging: add 'logging timezone (localtime|utc)' ..

[M] Change in libosmocore[master]: logging vty: add 'logging print timestamp', deprecate other timestamp...

2023-03-27 Thread neels
neels has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5861 ) Change subject: logging vty: add 'logging print timestamp', deprecate other timestamp cmds .. Removed Code-Review-2 by neels -- T

[M] Change in libosmocore[master]: logging: use enum to set timestamp format

2023-03-27 Thread neels
neels has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/5857 ) Change subject: logging: use enum to set timestamp format .. Removed Code-Review-2 by neels -- To view, visit https://gerrit.osmoc

[M] Change in osmo-msc[master]: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32069 ) Change subject: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G .. Patch Set

[M] Change in osmo-msc[master]: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32069 ) Change subject: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G .. Patch Set

[M] Change in osmo-msc[master]: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G

2023-03-27 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/32069 to look at the new patch set (#3). Change subject: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G .

[M] Change in osmo-msc[master]: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G

2023-03-27 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/32069 to look at the new patch set (#2). Change subject: 3G: decapsulate IuUP to AMR at the MGW; allow 3G<-AMR->2G .

[M] Change in osmo-msc[master]: fix msc_vlr_test_call SDP mncc_rtp

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32068 ) Change subject: fix msc_vlr_test_call SDP mncc_rtp .. fix msc_vlr_test_call SDP mncc_rtp In msc_vlr_test_call, we fail to send the right MNCC st

[M] Change in osmo-msc[master]: fix msc_vlr_test_call SDP mncc_rtp

2023-03-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32068 ) Change subject: fix msc_vlr_test_call SDP mncc_rtp .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_pfcp_expect()

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766 ) Change subject: hnbgw: add f_pfcp_expect() .. hnbgw: add f_pfcp_expect() End the guessing when seeing "timeout of T_guard": set a precis

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_rua_expect()

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 ) Change subject: hnbgw: add f_rua_expect() .. hnbgw: add f_rua_expect() End the guessing when seeing "timeout of T_guard": set a precise

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_bssap_expect()

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767 ) Change subject: hnbgw: add f_bssap_expect() .. hnbgw: add f_bssap_expect() End the guessing when seeing "timeout of T_guard": set a prec

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_bssap_expect()

2023-03-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767 ) Change subject: hnbgw: add f_bssap_expect() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_pfcp_expect()

2023-03-27 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766 ) Change subject: hnbgw: add f_pfcp_expect() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-

[M] Change in osmo-hnbgw[master]: [RFC] drop list of HNBAP UE Context

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32041 ) Change subject: [RFC] drop list of HNBAP UE Context .. Patch Set 2: (1 comment) Pat

[S] Change in osmo-hnbgw[master]: release UE Contexts on SCTP_RESTART

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32038 ) Change subject: release UE Contexts on SCTP_RESTART .. release UE Contexts on SCTP_RESTART When receiving SCTP_RESTART for a given HNB, direct

[S] Change in osmo-hnbgw[master]: vty: 'show ue': show which HNB the UE is registered on

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32040 ) Change subject: vty: 'show ue': show which HNB the UE is registered on .. vty: 'show ue': show which HNB the UE is registered on Change-Id: If

[S] Change in osmo-hnbgw[master]: log: in new RUA,SCCP FSM IDs, indicate CS/PS

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32039 ) Change subject: log: in new RUA,SCCP FSM IDs, indicate CS/PS .. log: in new RUA,SCCP FSM IDs, indicate CS/PS During tests without an SGSN, I n

[S] Change in osmo-hnbgw[master]: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036 ) Change subject: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC .. map_sccp: on timeout during WAIT_CC, send N-DISCONNECT

[S] Change in osmo-hnbgw[master]: release UE Contexts on HNB (Re-)Register

2023-03-27 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32037 ) Change subject: release UE Contexts on HNB (Re-)Register .. release UE Contexts on HNB (Re-)Register Whenever a HNB reconnects, we want to dis

[S] Change in osmo-hnbgw[master]: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC

2023-03-27 Thread neels
Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32036 ) Change subject: map_sccp: on timeout during WAIT_CC, send N-DISCONNECT to SCCP-SCOC ..

[L] Change in osmo-bts[master]: Replace explicit gsm_lchan_name() calls with LOGPLCHAN

2023-03-27 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32093 ) Change subject: Replace explicit gsm_lchan_name() calls with LOGPLCHAN .. Patch Set 1: (4 comments) File src/common/rsl.c:

[L] Change in osmo-bts[master]: Replace explicit gsm_lchan_name() calls with LOGPLCHAN

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32093 ) Change subject: Replace explicit gsm_lchan_name() calls with LOGPLCHAN .. Replace explicit gsm_lchan_name() calls with LOGPLCHAN Th

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32087 to look at the new patch set (#3). Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ..

[S] Change in osmo-bts[master]: common/vty: Print AMR MultiRate Configuration in "show lchan"

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32091 ) Change subject: common/vty: Print AMR MultiRate Configuration in "show lchan" .. common/vty: Print AMR MultiRate Configuration in "s

[S] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Dump logical channel params during MPH-ACTIVAT...

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32092 ) Change subject: bts-{sysmo,oc2g,lc15}: Dump logical channel params during MPH-ACTIVATE.req .. bts-{sysmo,oc2g,lc15}: Dump logical c

[S] Change in osmo-bsc[master]: nm_channel_fsm: do not send SET CHAN ATTR before SET BTS ATTR

2023-03-27 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32090 ) Change subject: nm_channel_fsm: do not send SET CHAN ATTR before SET BTS ATTR .. nm_channel_fsm: do not send SET CHAN ATTR before SE

[S] Change in osmocom-bb[master]: layer23: modem: fill imsi & imei in vty 'test gmm attach'

2023-03-27 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32081 ) Change subject: layer23: modem: fill imsi & imei in vty 'test gmm attach' .. Patch S

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers

2023-03-27 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32080 ) Change subject: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers ..

[S] Change in osmocom-bb[master]: layer23: rlcmac: Support GMM detaching from VTY

2023-03-27 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32051 ) Change subject: layer23: rlcmac: Support GMM detaching from VTY .. Patch Set 2: Code

[S] Change in osmo-bts[master]: cosmetic: Replace %i with %d

2023-03-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32089 ) Change subject: cosmetic: Replace %i with %d .. Patch Set 1: Code-Review+1 -- To vi

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number .. Patch S

[S] Change in osmo-bts[master]: cosmetic: Replace %i with %d

2023-03-27 Thread pespin
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32089 ) Change subject: cosmetic: Replace %i with %d .. Patch Set 1: Code-Review+2 -- To vie

[S] Change in osmo-bts[master]: cosmetic: Replace %i with %d

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32089 ) Change subject: cosmetic: Replace %i with %d .. cosmetic: Replace %i with %d Our linter will fail on %i, so let's replace any legac

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread laforge
Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/32087 to look at the new patch set (#2). Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ..

[M] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1

2023-03-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32088 ) Change subject: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1 .. Patch Set 1: Co

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number .. Patch S

[S] Change in osmo-bts[master]: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET

2023-03-27 Thread fixeria
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32086 ) Change subject: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET .. Patch

[M] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32088 ) Change subject: bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1 .. bts-{sysmo,oc2g,lc15}: Fix RTP of AMR SID_FIRST_P1 When we re

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number .. Patch Set 1: (1 comment) File src/common/meas

[M] Change in osmo-bts[master]: Introduce LOGPLCFN() for logging lchan-name + frame number

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 ) Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number .. Introduce LOGPLCFN() for logging lchan-name + frame nu

[S] Change in osmo-bts[master]: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32086 ) Change subject: DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages about ONSET .. DTX: bts-{sysmo,oc2g,lc15}: Print DEBUG messages abo

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion .. Patch Set 2: Code-Revi

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread dexter
Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion .. Patch Set 2: (1 comme

[M] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case

2023-03-27 Thread falconia
Attention is currently required from: neels, laforge. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32078 ) Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ...

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion .. Patch Set 2: (1 comme

[S] Change in osmo-mgw[master]: mgcp_codec: cosmetic: remove line break in api-doc

2023-03-27 Thread pespin
Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32084 ) Change subject: mgcp_codec: cosmetic: remove line break in api-doc .. Patch Set

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 ) Change subject: gmm: Initial implementation of GPRS Detach .. gmm: Initial implementation of GPRS Detach This patch contains further work o

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread pespin
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 ) Change subject: gmm: Initial implementation of GPRS Detach .. Patch Set 2: Code-Re

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread dexter
Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/32083 to look at the new patch set (#2). Change subject: mgcp_codec: refactor payload type converstion .

[S] Change in osmo-mgw[master]: mgcp_codec: cosmetic: remove line break in api-doc

2023-03-27 Thread dexter
Attention is currently required from: neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32084 ) Change subject: mgcp_codec: cosmetic: remove line break in api-doc .. Patch Set

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 ) Change subject: gmm: Initial implementation of GPRS Detach .. Patch Set 2:

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread pespin
Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 to look at the new patch set (#2). Change subject: gmm: Initial implementation of GPRS

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread pespin
Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 ) Change subject: gmm: Initial implementation of GPRS Detach .. Patch Set 1:

[L] Change in libosmo-gprs[master]: gmm: Initial implementation of GPRS Detach

2023-03-27 Thread osmith
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32050 ) Change subject: gmm: Initial implementation of GPRS Detach .. Patch Set 1:

[S] Change in osmo-msc[master]: msc_main: close SMS db on startup error

2023-03-27 Thread pespin
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32085 ) Change subject: msc_main: close SMS db on startup error .. Patch Set 1: Code-Review-1

[S] Change in osmo-mgw[master]: Revert "mgcp_codec: do not differentiate between oa and bwe when comp...

2023-03-27 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27391 ) Change subject: Revert "mgcp_codec: do not differentiate between oa and bwe when comparing codec" ..

[M] Change in osmo-mgw[master]: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate()

2023-03-27 Thread pespin
Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 ) Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate() .

[S] Change in osmo-mgw[master]: mgcp_codec: cosmetic: remove line break in api-doc

2023-03-27 Thread pespin
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32084 ) Change subject: mgcp_codec: cosmetic: remove line break in api-doc .. Patch Set 1: (1

[M] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case

2023-03-27 Thread neels
Attention is currently required from: falconia, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32078 ) Change subject: osmo_rtp2trau() for FR & EFR: correctly handle the no-data case ...

[S] Change in osmo-msc[master]: msc_main: close SMS db on startup error

2023-03-27 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/32085 ) Change subject: msc_main: close SMS db on startup error .. msc_main: close SMS db on startup error When the SMS sqlite db is opened

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion .. Patch Set 1: (3 comments) File tests/mgcp/mgcp_test.c: Ro

[M] Change in osmo-mgw[master]: mgcp_codec: refactor payload type converstion

2023-03-27 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32083 ) Change subject: mgcp_codec: refactor payload type converstion .. mgcp_codec: refactor payload type converstion in mgcp_codec.c we ha

[S] Change in osmo-mgw[master]: mgcp_codec: cosmetic: remove line break in api-doc

2023-03-27 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32084 ) Change subject: mgcp_codec: cosmetic: remove line break in api-doc .. mgcp_codec: cosmetic: remove line break in api-doc We usually

[M] Change in osmo-mgw[master]: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate()

2023-03-27 Thread dexter
Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27392 ) Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate() .

[M] Change in osmo-mgw[master]: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_translate()

2023-03-27 Thread dexter
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/27392 to look at the new patch set (#5). Change subject: mgcp_codec: fix oa/bwe comparison in mgcp_codec_pt_transl

[S] Change in pysim[master]: pySim-shell: add cardinfo command

2023-03-27 Thread fixeria
Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25805 ) Change subject: pySim-shell: add cardinfo command .. Patch Set 5: Code-Review+1

[S] Change in docker-playground[master]: ttcn3-bts-test: enable running GPRS related tests with trxcon

2023-03-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31975 ) Change subject: ttcn3-bts-test: enable running GPRS related tests with trxcon .. ttcn3-bts-test: enable running GPRS related tests wit

[S] Change in docker-playground[master]: ttcn3-bts-test: enable running GPRS related tests with trxcon

2023-03-27 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31975 ) Change subject: ttcn3-bts-test: enable running GPRS related tests with trxcon .. Patch Set 1: Code-Review+2 -- To view, vi

[S] Change in docker-playground[master]: ttcn3-bts-test: enable running GPRS related tests with trxcon

2023-03-27 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31975 ) Change subject: ttcn3-bts-test: enable running GPRS related tests with trxcon .. Set Ready For Review -- To view, visit ht

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: keep pchan configuration unchanged in TC_pcu_*

2023-03-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31979 ) Change subject: BTS_Tests: keep pchan configuration unchanged in TC_pcu_* .. BTS_Tests: keep pchan configuration unchanged in TC_pcu_*

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.cfg: set mp_l1_supports_gprs to true

2023-03-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31980 ) Change subject: BTS_Tests.cfg: set mp_l1_supports_gprs to true .. BTS_Tests.cfg: set mp_l1_supports_gprs to true This parameter enable

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: do L1CTL.clear in f_pcu_to_l1()

2023-03-27 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31978 ) Change subject: BTS_Tests: do L1CTL.clear in f_pcu_to_l1() .. BTS_Tests: do L1CTL.clear in f_pcu_to_l1() When calling f_pcu_to_l1(), t

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: keep pchan configuration unchanged in TC_pcu_*

2023-03-27 Thread fixeria
Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31979 ) Change subject: BTS_Tests: keep pchan configuration unchanged in TC_pcu_* .. P

[M] Change in osmo-ttcn3-hacks[master]: bts: fix TC_ipa_osmo_pcu_anr_fwd: send/expect proper payloads

2023-03-27 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32077 ) Change subject: bts: fix TC_ipa_osmo_pcu_anr_fwd: send/expect proper payloads .. bts: fix TC_ipa_osmo_pcu_anr_fwd: send/expect proper p

[M] Change in osmo-ttcn3-hacks[master]: bts: fix TC_ipa_osmo_pcu_anr_fwd: send/expect proper payloads

2023-03-27 Thread laforge
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32077 ) Change subject: bts: fix TC_ipa_osmo_pcu_anr_fwd: send/expect proper payloads .

[M] Change in osmo-bts[master]: bts-{sysmo,oc2g,lc15}: Make sure RTP clock ticks during FACCH stealing

2023-03-27 Thread laforge
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/32082 ) Change subject: bts-{sysmo,oc2g,lc15}: Make sure RTP clock ticks during FACCH stealing .. bts-{sysmo,oc2g,lc15}: Make sure RTP cloc

[S] Change in osmocom-bb[master]: layer23: modem: fill imsi & imei in vty 'test gmm attach'

2023-03-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32081 ) Change subject: layer23: modem: fill imsi & imei in vty 'test gmm attach' .. layer23: modem: fill imsi & imei in vty 'test gmm atta

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers

2023-03-27 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32080 ) Change subject: layer23: modem: Forward GMMRR primitives between GMM and RLCMAC layers .. layer23: modem: Forward GMMRR primitives

[M] Change in osmo-pcu[master]: pdch_ul_controller: log reserved frame numbers

2023-03-27 Thread pespin
Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31022 ) Change subject: pdch_ul_controller: log reserved frame numbers .. Patch Set 4:

[M] Change in osmo-pcu[master]: pdch_ul_controller: log reserved frame numbers

2023-03-27 Thread pespin
Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31022 ) Change subject: pdch_ul_controller: log reserved frame numbers .. Patch Set 4:

[S] Change in libosmo-abis[master]: osmo_rtp2trau() for FR & EFR: set SP=0 in DL if the frame is a SID

2023-03-27 Thread pespin
Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32079 ) Change subject: osmo_rtp2trau() for FR & EFR: set SP=0 in DL if the frame is a SID ...

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_bssap_expect()

2023-03-27 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31767 ) Change subject: hnbgw: add f_bssap_expect() .. Patch Set 2: Code-Review+1 --

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_pfcp_expect()

2023-03-27 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31766 ) Change subject: hnbgw: add f_pfcp_expect() .. Patch Set 2: Code-Review+1 -- T

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: add f_rua_expect()

2023-03-27 Thread laforge
Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31765 ) Change subject: hnbgw: add f_rua_expect() .. Patch Set 2: Code-Review+2 -- To

[S] Change in osmo-bsc[master]: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags

2023-03-27 Thread pespin
Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32070 ) Change subject: abis_nm: Only osmo-bts re-purposes the MANUF_ID for BTS feature flags

[M] Change in osmo-bts[master]: gsm_objclass2mo(): Change signature so we can obtain a nack cause in ...

2023-03-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 ) Change subject: gsm_objclass2mo(): Change signature so we can obtain a nack cause in case of error ...

[S] Change in osmo-pcu[master]: PCU interface: Log version when starting listener

2023-03-27 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32066 ) Change subject: PCU interface: Log version when starting listener .. PCU interface: Log version when starting listener Change-Id: Ic831ba20917

[S] Change in osmo-pcu[master]: PCU interface: Log version when starting listener

2023-03-27 Thread laforge
Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32066 ) Change subject: PCU interface: Log version when starting listener .. Patch Set 2: Co

[S] Change in osmo-bts[master]: common: Remove unused function gsm_objclass2nmstate()

2023-03-27 Thread pespin
Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32074 ) Change subject: common: Remove unused function gsm_objclass2nmstate() .. Patch Set 2:

[S] Change in osmo-bts[master]: gsm_objclass2mo(): First check if TRX number is valid

2023-03-27 Thread pespin
Attention is currently required from: arehbein, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32073 ) Change subject: gsm_objclass2mo(): First check if TRX number is valid .. Pat

  1   2   >