[S] Change in pysim[master]: filesystem: fix typo

2023-12-13 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35352?usp=email ) Change subject: filesystem: fix typo .. Patch Set 1: Code-Review+2 -- To

[S] Change in pysim[master]: filesystem: use sort path when selecting an application

2023-12-13 Thread fixeria
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35351?usp=email ) Change subject: filesystem: use sort path when selecting an application

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp

2023-12-13 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35357?usp=email ) Change subject: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp

[S] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSession...

2023-12-13 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35356?usp=email ) Change subject: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSessionResp

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

2023-12-13 Thread arehbein
Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email ) Change subject: Make BSSGP timing data configurable .. Patch Set 9: (1

[M] Change in osmo-bsc[master]: Make NSE timing data configurable

2023-12-13 Thread arehbein
Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email ) Change subject: Make NSE timing data configurable .. Patch Set 8: (3

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands

2023-12-13 Thread arehbein
Attention is currently required from: fixeria, laforge, neels, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email ) Change subject: Introduce per-BTS timers, RLC timer commands

[M] Change in libosmocore[master]: tdef_vty: Introduce generalized per-object tdef support

2023-12-13 Thread arehbein
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email ) Change subject: tdef_vty: Introduce generalized per-object tdef support .. Patch Set 9: (1 comment) Patchset: PS9:

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands

2023-12-13 Thread arehbein
Attention is currently required from: fixeria, laforge, neels, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email ) Change subject: Introduce per-BTS timers, RLC timer commands

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands

2023-12-13 Thread arehbein
Attention is currently required from: arehbein, fixeria, laforge, neels. Hello Jenkins Builder, fixeria, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email to look at the new patch set (#18). The following

[M] Change in osmo-bsc[master]: Make NSE timing data configurable

2023-12-13 Thread arehbein
Attention is currently required from: arehbein. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins

[M] Change in osmo-bsc[master]: Make BSSGP timing data configurable

2023-12-13 Thread arehbein
Attention is currently required from: arehbein. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins

[L] Change in libosmocore[master]: ns2: Use tdef API for timers

2023-12-13 Thread arehbein
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35360?usp=email ) Change subject: ns2: Use tdef API for timers .. Patch Set 1: (1 comment) This change is ready for review. Patchset:

[M] Change in libosmocore[master]: ns2: Improve code consistency

2023-12-13 Thread arehbein
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35359?usp=email ) Change subject: ns2: Improve code consistency .. Set Ready For Review -- To view, visit

[M] Change in libosmocore[master]: tdef_vty: Introduce helper functions/adapt existing helpers

2023-12-13 Thread arehbein
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35328?usp=email ) Change subject: tdef_vty: Introduce helper functions/adapt existing helpers .. Set Ready For Review -- To view,

[M] Change in libosmocore[master]: tdef_vty: Introduce generalized per-object tdef support

2023-12-13 Thread arehbein
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35355?usp=email ) Change subject: tdef_vty: Introduce generalized per-object tdef support .. Set Ready For Review -- To view, visit

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages

2023-12-13 Thread pespin
Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35358?usp=email ) Change subject: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages

2023-12-13 Thread daniel
Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35358?usp=email ) Change subject: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp

2023-12-13 Thread daniel
Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35357?usp=email ) Change subject: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp

[S] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSession...

2023-12-13 Thread daniel
Attention is currently required from: fixeria, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35356?usp=email ) Change subject: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSessionResp

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages

2023-12-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35358?usp=email ) Change subject: library/GTPv2_Emulation: Patch SeqNr only on outbound initial messages ..

[S] Change in osmo-ttcn3-hacks[master]: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSession...

2023-12-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35356?usp=email ) Change subject: library/GTPv2_Templates: Fix seq nr not set in ts_GTP2C_DeleteSessionResp ..

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp

2023-12-13 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35357?usp=email ) Change subject: GTPv2: set TEID and SeqNr in ts_GTP2C_CreateSessionResp .. GTPv2: set TEID and SeqNr in

[M] Change in osmo-iuh[master]: iu_client: Handle empty CR and InitialUE Message in DATA.ind

2023-12-13 Thread daniel
Attention is currently required from: neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email ) Change subject: iu_client: Handle empty CR and InitialUE Message in DATA.ind ..

[M] Change in osmo-iuh[master]: iu_client: Handle empty CR and InitialUE Message in DATA.ind

2023-12-13 Thread Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email ) Change subject: iu_client: Handle empty CR and InitialUE Message in DATA.ind .. Patch Set 1: (6 comments) File

[M] Change in osmo-iuh[master]: iu_client: Handle empty CR and InitialUE Message in DATA.ind

2023-12-13 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email ) Change subject: iu_client: Handle empty CR and InitialUE Message in DATA.ind .. iu_client: Handle empty CR and InitialUE

[S] Change in osmo-iuh[master]: iu_client: Use local variable to track conn_id

2023-12-13 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35353?usp=email ) Change subject: iu_client: Use local variable to track conn_id .. iu_client: Use local variable to track conn_id

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread pespin
Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread dexter
Attention is currently required from: dexter, laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email to look at the new patch set (#5). The following approvals got

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread Jenkins Builder
Attention is currently required from: laforge, neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread dexter
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email to look at the new patch set (#4). Change subject: ecu: force alignment

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread Jenkins Builder
Attention is currently required from: laforge, neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread dexter
Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email to look at the new patch set (#3). The following approvals got outdated

[S] Change in libosmocore[master]: ecu: force alignment of member data in struct osmo_ecu_state

2023-12-13 Thread dexter
Attention is currently required from: laforge, neels, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: force alignment of member data in struct osmo_ecu_state

[S] Change in libosmocore[master]: ipa_ccm_tlv_to_unitdata(): free previous string if present before all...

2023-12-13 Thread pespin
Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35347?usp=email to look at the new patch set (#2). The following approvals got outdated and

[S] Change in pysim[master]: filesystem: use sort path when selecting an application

2023-12-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35351?usp=email ) Change subject: filesystem: use sort path when selecting an application .. filesystem: use sort path when selecting an

[S] Change in pysim[master]: filesystem: fix typo

2023-12-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35352?usp=email ) Change subject: filesystem: fix typo .. filesystem: fix typo Change-Id: I721875d302ab69340d56b33102297b56c070465f --- M

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-12-13 Thread dexter
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in osmo-pcu[master]: Revert "Revert "pdch_ul_controller: migrate from fn_cmp() to gsm0502_...

2023-12-13 Thread pespin
Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35338?usp=email ) Change subject: Revert "Revert "pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()""

[M] Change in libosmo-sccp[master]: ipa: Use ASP name as ipa_unit_name on dynamic ASPs

2023-12-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35348?usp=email ) Change subject: ipa: Use ASP name as ipa_unit_name on dynamic ASPs .. ipa: Use ASP name as ipa_unit_name on dynamic ASPs A

[S] Change in libosmo-sccp[master]: cosmetic: Fix typo in function doc

2023-12-13 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35335?usp=email ) Change subject: cosmetic: Fix typo in function doc .. cosmetic: Fix typo in function doc Change-Id:

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-12-13 Thread pespin
Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ..

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-12-13 Thread fixeria
Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-12-13 Thread dexter
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/34932?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed:

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

2023-12-13 Thread dexter
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file

[S] Change in pysim[master]: runtime: explain how file probing works

2023-12-13 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35251?usp=email ) Change subject: runtime: explain how file probing works .. runtime: explain how file probing works We use a trick to probe a file (that