Neels Hofmeyr has submitted this change and it was merged.
Change subject: configure: add --enable-werror
..
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our
Patch Set 1:
well, as nobody is proposign any feasible alternative, I'm inclined to say "go
ahead mark all of those as +2 and merge it'. I still don't like it, but I
don't have time for a counter-proposal either.
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Patch Set 1:
> So clearly =pragma is wrong
Ah, you meant, not suppress #pragma, but use #pragma instead of #warning. Ok,
possible, but with -Wno-error=cpp we can also keep the #warnings :)
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Patch Set 1:
> Regarding deprecated, I think it's good that it fails when using a
> deprecated symbol, this way it forces us to fix it.
That part is good, yes, but the pattern that has emerged recently is: our
jenkins builds use -Werror. That means as soon as we create some foo2() and
Patch Set 1:
> > Why do you need each of this?
> > -Wno-error=deprecated -Wno-error=deprecated-declarations
> > -Wno-error=cpp
>
> it's all explained in the commit log as well as the ./configure
> --help
Regarding deprecated, I think it's good that it fails when using a deprecated
Patch Set 1:
> Why do you need each of this?
> -Wno-error=deprecated -Wno-error=deprecated-declarations
> -Wno-error=cpp
it's all explained in the commit log as well as the ./configure --help
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit
Patch Set 1: -Code-Review
Why do you need each of this?
-Wno-error=deprecated -Wno-error=deprecated-declarations -Wno-error=cpp
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
> I would really hope there is another method than to add a
> configure.ac flag for every compiler option / CFLAG we ever want to
> sue from our continuous integration setup.
It's not just one CFLAG here, there is a "fine-tuned" combination of warnings
we don't want to see as
Patch Set 1: Code-Review-1
I think using:
CFLAGS="..." ./configure
instead of
./configure CFLAGS="..."
should fix the overwritting issue.
--
To view, visit https://gerrit.osmocom.org/7096
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
I would really hope there is another method than to add a configure.ac flag for
every compiler option / CFLAG we ever want to sue from our continuous
integration setup. I know, it's easy to complain and if it helps, ok. But it
just feels like the wrong approach to me, sorry.
Review at https://gerrit.osmocom.org/7096
configure: add --enable-werror
Provide a sane means of adding the -Werror compiler flag.
Currently, some of our jenkins.sh add -Werror by passing 'CFLAGS="-Werror"',
but that actually *overwrites* all the other CFLAGS we might want to have set.
11 matches
Mail list logo
