Harald Welte has submitted this change and it was merged.
Change subject: ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP
..
ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP
So far, error reporting just says
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5439
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5439
to look at the new patch set (#5).
ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP
So far, error reporting just says "Trap/Reply", more accurately report 'GET
REPLY', 'SET
Patch Set 4:
> That looks like lot's of code duplication. Can we just set error
> string and call some generic function with it as parameter? Smth
> like
> case CTRL_TRAP: handle_incoming("TRAP",...)...
yes, you're right. I thought about the same but in the end didn't get around to
it...
Patch Set 4:
That looks like lot's of code duplication. Can we just set error string and
call some generic function with it as parameter? Smth like
case CTRL_TRAP: handle_incoming("TRAP",...)...
--
To view, visit https://gerrit.osmocom.org/5439
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5439
to look at the new patch set (#4).
ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP
So far, error reporting just says "Trap/Reply", more accurately report 'GET
REPLY', 'SET
Review at https://gerrit.osmocom.org/5439
ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP
So far, error reporting just says "Trap/Reply", more accurately report 'GET
REPLY', 'SET REPLY' and 'TRAP' as appropriate.
Change-Id: Ic25a251502499aeda4e2952ec4190a1fa0bebb01
---
M
