Harald Welte has submitted this change and it was merged.
Change subject: rsl: do not allow MODE MODIFY request with unsupp. codec/rate
..
rsl: do not allow MODE MODIFY request with unsupp. codec/rate
When the BSC sends a MODE
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6097
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b222b7ab19ece90591718bc562b3a8c5e02023
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
I think the pointer to the const static array is not sufficient anyway. Think
of having to set it depending on the DSP firmware version?
--
To view, visit https://gerrit.osmocom.org/6097
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
(4 comments)
> (1 comment)
https://gerrit.osmocom.org/#/c/6097/1/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:
Line 97:const struct bts_cm *cm; /* Table with supp. ch
rate/mode combinations */
> if this is alway an array that needs to be as large
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6097/1/src/common/bts.c
File src/common/bts.c:
Line 693: for (i = 0;; i++) {
> This way: (i = 0; i < _GSM_PCHAN_MAX; i++)
Oops, I was mistaken. As the size of bts->support.cm
array is different for different BTS models, you may
use
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6097/1/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:
Line 97:const struct bts_cm *cm; /* Table with supp. ch
rate/mode combinations */
if this is alway an array that needs to be as large as MAX_PCHAN_T,
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6097/1/src/common/bts.c
File src/common/bts.c:
Line 679: int bts_supports_cm(struct gsm_bts_role_bts *bts,
Why not to use bool here?
Line 693: for (i = 0;; i++) {
This way: (i = 0; i < _GSM_PCHAN_MAX; i++)
Line 702:
Review at https://gerrit.osmocom.org/6097
rsl: do not allow MODE MODIFY request with unsupp. codec/rate
When the BSC sends a MODE MODIFY request with an unsupported
codec, the BTS must respond with a negative acknowledge.
Currently the codec parameter is not checked at all, which may
lead into
