Harald Welte has submitted this change and it was merged.
Change subject: jenkins: add osmo-gsm-tester_run-{prod,rnd}
..
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd
Patch Set 7: Verified+1
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 7
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 6: Code-Review+2
reconsidering, these are the shell instructions for the "Build step" config,
and I think after all they're abstracted enough that we could have two separate
ones. There's also the possibility of configuring env vars for the jenkins job,
which would I think be
Patch Set 6:
I've looked further into. I don't want to add jjb variables in the shell
script. This will break shell scripts quite easy. e.g. if you try to use ${FOO}
in a shell script, it will treat it a {FOO} variable.
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit
Patch Set 6: Code-Review-1
agree with pau
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 6
Gerrit-Project: osmo-ci
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 6
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 6:
Can we unify the sh script instead of having 2 of them with only 1 line
changing?
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7021
to look at the new patch set (#6).
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id:
Patch Set 5: Code-Review-1
Waiting for this patch to be updated to fullfill new resources.conf changes.
See my last comment in this patch regarding this topic.
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 5
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 5:
Please have a look at this osmo-gsm-tester commit, which moved
osmo-gsm-tester.git example/resource.conf to example/resource.conf.{prod,rnd}.
So you can drop all "sed" commands and do: ln -s resources.conf.prod
example/resources.conf
--
To view, visit
Hello Pau Espin Pedrol, Neels Hofmeyr,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7021
to look at the new patch set (#5).
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id:
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 137: repo: osmo-gsm-tester_build-osmo-bsc
> it's used here. This is a macro using another macro.
ok I understand. Interesting to see that one can use macros,
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 127: project: '{repo}'
> where is the {repo} coming from? IIUC the '- project:' section responsible
this is a macro. repo must be given, when calling this
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/7021/4/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 127: project: '{repo}'
where is the {repo} coming from? IIUC the '- project:' section responsible for
these jobs doesn't define repos. Is it
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 4
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Hello Pau Espin Pedrol,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7021
to look at the new patch set (#4).
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id:
Hello Pau Espin Pedrol,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7021
to look at the new patch set (#3).
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id:
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7021/2/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 105: name: osmo-gsm-tester-repo-clean
As discussed, I think we can drop this one completely.
--
To view, visit https://gerrit.osmocom.org/7021
To
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
---
M jobs/osmo-gsm-tester.yml
A jobs/osmo-gsm-tester_run-prod.sh
A jobs/osmo-gsm-tester_run-rnd.sh
3 files changed, 150 insertions(+),
Patch Set 1:
(5 comments)
https://gerrit.osmocom.org/#/c/7021/1/jobs/osmo-gsm-tester.yml
File jobs/osmo-gsm-tester.yml:
Line 119: clean: true
Not sure if we really require another scm (the difference with the other one is
clean true/false right?). Do you see any reason to keep 2 of
Patch Set 1:
Both jobs hasn't been yet deployed on the jenkins.
--
To view, visit https://gerrit.osmocom.org/7021
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
Gerrit-PatchSet: 1
Review at https://gerrit.osmocom.org/7021
jenkins: add osmo-gsm-tester_run-{prod,rnd}
Both jobs doing the actual test run on the prod or rnd tester.
Change-Id: Ic1c4babc547f48402b0bcfaf38e2734e87e565f0
---
M jobs/osmo-gsm-tester.yml
A jobs/osmo-gsm-tester_run-prod.sh
A
23 matches
Mail list logo
