Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2020
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98408e72020a474d378e39263a933eb7567de146
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+1
agreed with max.
--
To view, visit https://gerrit.osmocom.org/2060
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8170bd4134904702b6b272e496100361ba473cbc
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2062
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68dc5e837bd2a3602f7875063c85da4082196274
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2061
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f5407264fc4f209456ffcb73d7853ff315aab86
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix OSMO_VALUE_STRING macro: don't use OSMO_STRINGIFY()
..
fix OSMO_VALUE_STRING macro: don't use OSMO_STRINGIFY()
To be able to use
Patch Set 4:
I think we should refer to latest version of the standard in here which is 3GPP
TS 45.003 and if the test vectors are part of the spec than we should even
refer to particular ยง.
--
To view, visit https://gerrit.osmocom.org/1628
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2038
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I793e7d62df1ca9f9c38d39e22d3868064d446c8d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2039
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66541f9b20e7fd67fbec329283fc3c821c970a56
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2064/1/openbsc/include/openbsc/pcuif_proto.h
File openbsc/include/openbsc/pcuif_proto.h:
Line 10: #define PCU_IF_MSG_DATA_CNF_DT 0x11/* confirm (with direct tlli) */
once again the pcu interface protocol is changed, thus
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2063
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I945f49e62e2a74a7906e2d49940927773edd04a9
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1:
> Let's say we change the interface and bump the version inside the pcu.
So what shall we do if we have to make changes to BSC's copy of the protocol?
We have to checkout latest version of OsmoPCU, see which version was used there
and +1 to it to make sure we don't have different
Harald Welte has submitted this change and it was merged.
Change subject: fix wrong return code
..
fix wrong return code
In case we are a daemon, we do not need to daemonize again.
On the other hand everything is fine and we
Patch Set 2: Code-Review+1
@Tom: You are a maintainer of osmo-trx (I guess the only one?), other people
like me are not. So unless you set a patch to +2, it cannot be merged. Not
sure if you're aware of this.
--
To view, visit https://gerrit.osmocom.org/2074
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: l1sap: fix rach reason (ra) parsing
..
l1sap: fix rach reason (ra) parsing
The ra parameter indicates the reason for the received rach
request. osmo-bts
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1875
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82844ec7a302bac30d6daee9ebca2188fd48ca46
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: milenage_test: enhance to verify new SQN increments
..
milenage_test: enhance to verify new SQN increments
After the legacy mode incrementing with
Patch Set 4:
the address sanitizer bug will have to be resolved first, befor the patch is
verified and can be merged:
+=
+==23280==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x6150d700 at pc 0x7f490faf014e bp
Harald Welte has submitted this change and it was merged.
Change subject: osmo_auth_gen_vec: UMTS auth: fix SQN as SEQ || IND
..
osmo_auth_gen_vec: UMTS auth: fix SQN as SEQ || IND
So far we incremented SQN by 1, which doesn't
Patch Set 1:
To double-check: we bump protocol version when we add new messages or only when
we change existing messages? I mean when adding new message it should still
work with older version: the new message will be ignored with appropriate
warning so it seems backward-compatible.
--
To
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2066/1/openbsc/include/openbsc/pcuif_proto.h
File openbsc/include/openbsc/pcuif_proto.h:
Line 64:uint8_t imsi[3];
this changes the layout of the PCU socket interface protocol, and hence should
be accompaned
Review at https://gerrit.osmocom.org/2085
Handle PCU version received viam OML alert
Explicitly check for and log PCU version received from BTS via OML alert
message.
Change-Id: I3c88663d4e2887a4038b4c3f1387128295b8934e
Related: OS#1614
---
M openbsc/src/libbsc/abis_nm.c
1 file changed, 54
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2059
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28bf0995699618f3f5fa15fc8e1733beddfc482f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2058
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I602b581fab67b3a1c3c03c73a3a99e9afd564e29
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2057
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ea506c8240dac124ccf5522d02ba18e4f0cb90d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: -Code-Review
(3 comments)
https://gerrit.osmocom.org/#/c/2056/1/openbsc/include/openbsc/pcu_if.h
File openbsc/include/openbsc/pcu_if.h:
Line 13:struct osmo_fd conn_bfd;/* fd for connection to lcr */
to lrc?!?
Patch Set 4: -Code-Review
I still think it's suboptimal but as it doesn't break existing code now, sure,
here it is.
--
To view, visit https://gerrit.osmocom.org/1940
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2035
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8efd9bafdcf9504d2e5fc85c44c708fa53f4dff8
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2036
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I672bfaa09c42fbeb0c8459f24bb952de954b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2086
Sync protocol with OsmoPCU
Change-Id: I15e6cc86604947a173e8675ba4b41a3bda2d3296
---
M include/osmo-bts/pcuif_proto.h
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/86/2086/1
diff --git
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: Add commandline option to display version
..
cosmetic: Add commandline option to display version
The -V option to display the Version and the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2041
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifca46dd8b356d0de31cccbd79e406079d3a0d7d2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
> Can we use shared header installed by osmo-pcu similar to #1258?
Actually, I think I start to like the idea of having copies of the header file.
This way, each version in the git repository has the matching version of the
header file to its code. Let's say we
Review at https://gerrit.osmocom.org/2087
Handle TXT indication from OsmoPCU
* handle OML message
* handle OsmoPCU version message
Change-Id: I16e73198501487a5b1076bf83390b85538d5af73
Related: OS#1614, 1615
---
M src/common/pcu_sock.c
1 file changed, 24 insertions(+), 0 deletions(-)
git
Review at https://gerrit.osmocom.org/2092
auth_milenage: fix check against too large ind
To ensure that the IND index appended to SEQ does not affect the SEQ, the check
should read '>= seq_1', not '>'.
Change-Id: Ib1251159eee02aa07fae1b429ffec2e4604bf6a8
---
M src/gsm/auth_milenage.c
1 file
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2081
to look at the new patch set (#4).
UMTS AKA: implement SQN increment according to SEQ and IND
Add ind_bitlen column to auc_3g to record each USIM's IND size according to
Neels Hofmeyr has submitted this change and it was merged.
Change subject: auc tests: fix after SQN scheme changes from libosmocore
..
auc tests: fix after SQN scheme changes from libosmocore
In change-id
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2074
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba48e1df4ede8b477574da3faa15fd02e15c69b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Max has submitted this change and it was merged.
Change subject: Add autoconf-archive to dependencies
..
Add autoconf-archive to dependencies
We use AX_EXT in ./configure for checking CPU features anyway, so it's
better to add
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/osmo-hlr failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-hlr
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
44 matches
Mail list logo
