Review at https://gerrit.osmocom.org/2946
OML Add osmocom-specific way to deactivate radio link timeout
In some situations (e.g. when trying to do measurements/testing on the
BTS receiver / uplink) it is useful to have a way to disable the radio
link timeout and keep any channel open until
Review at https://gerrit.osmocom.org/2947
Add vty command "radio-link-timeout infinite" for uplink rx testing
When we are performing Rx sensitivity testing on a BTS, we want to
deactivate the connection failure criterion / radio link timeout, i.e.
no matter how many SACCH frames in uplink are
Review at https://gerrit.osmocom.org/2952
tlv_test.c: Fix compilation warnings
Several warnings like the one below are fixed:
warning: array subscript is below array bounds [-Warray-bounds]
uint8_t *unchanged_ptr = buf - 1;
Change-Id: I35d7d926939c14700cbca732bd64e588c75424b4
---
M
Review at https://gerrit.osmocom.org/2951
gprs_ns_test.c: Remove unused byte arrays
Commit 0d4e949e229a649ffd0503d8e930dba8be7dd34d changed the code to use
functions with local variables holding the bytes, but forgot to remove
the old global variables.
This test fixes compilation warnings.
Review at https://gerrit.osmocom.org/2948
Fix compilation warning on deprecated macro
A warning was printed even if the deprecation didn't apply to
libosmocore because it is still allowed to use it internally.
This patch fixes this case while still printing a warning if external
projects build
Review at https://gerrit.osmocom.org/2950
sms_test.c: Remove test of deprecated wrapper function
The deprecated function is just a wrapper, and it triggers a compilation
warning.
Change-Id: Iaac701bdf0c0e66c343f68cc31d82550a024ef57
---
M tests/sms/sms_test.c
M tests/sms/sms_test.ok
2 files
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2956
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57fd3e1bf74ec24dec692710359a1ce00ecde75a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2964
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6cb31f38721f79e2cf93f9b8e4776f3720aa07
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1e3255800999669ca9619bfceb4124c773eff2d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2957
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3060cfee8ece86c4c89a65f93c9f5424df0c410b
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
I am all for avoiding complex merges in the history, but don't agree here. a) I
would have had to reconfigure the run job to see a history of multiple runs. b)
We hardly ever revert anything, we can manage a revert every now and then. c)
it doesn't hurt to see in the history that
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: sms_test.c: Remove test of deprecated wrapper function
..
sms_test.c: Remove test of deprecated wrapper function
The deprecated function is just a
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: card_fs_uicc.c: Fix unused compilation warning
..
card_fs_uicc.c: Fix unused compilation warning
This array of bytes is not yet used but is
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: tlv_test.c: Fix compilation warnings
..
tlv_test.c: Fix compilation warnings
Several warnings like the one below are fixed:
warning: array subscript
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: gprs_ns_test.c: Remove unused byte arrays
..
gprs_ns_test.c: Remove unused byte arrays
Commit 0d4e949e229a649ffd0503d8e930dba8be7dd34d changed the
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Fix compilation warning on deprecated macro
..
Fix compilation warning on deprecated macro
A warning was printed even if the deprecation didn't
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Neels Hofmeyr has reverted this change.
Change subject: Revert "osmo-bts-trx: wait some longer before starting
osmo-bts-trx"
..
Uploaded patch set 1.
--
To view, visit https://gerrit.osmocom.org/2965
To unsubscribe, visit
Patch Set 2:
Please next time better create a branch + a new jenkins job to use that branch
to test this kind of stuff rather than pushing something for a few hours then
reverting, in order to have a cleaner history.
--
To view, visit https://gerrit.osmocom.org/2965
To unsubscribe, visit
Patch Set 5:
> > osmo-gsm-tester scripts don't use osmo-ci
>
> So why you've comment in another patch that "each is still callable
> on its own" in the context of osmo-gsm-tester and jenkins_* helpers
> in osmo-bts? Those are using osmo-ci.
I don't get your question? I hope the reasons why
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5386ba3e1f1cc153ba96c29dc71c9075a052aa02
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2929
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ef9d00a031b7d7e59150a28a6972c620ff19e92
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2747
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c70b3b8436e2647fc35d579a302dfbf32a83f0
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: OsmoBTS: Update osmotrx ip to diff between local and remote
..
OsmoBTS: Update osmotrx ip to diff between local and remote
Change Id of the code
Patch Set 1:
what I'm missing here is *why* we are adding those fields, and what they will
be used for. The radio link timeout / connection failure criterion also has
some way of counting bad SACCHs, so I want to make sure we're not adding
redundant information here.
--
To view, visit
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Add support for SMPP testing
..
Add support for SMPP testing
As defined in [1], the different related actors are implemented in this
commit: ESME
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2893
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I840533d5bf9233822bc0534a25c252f1cab0a7b0
Gerrit-PatchSet: 5
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: RSL: check for abnormal SI2q values
..
RSL: check for abnormal SI2q values
Check for impossible index and count values of SI2q messages. The limit
is
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2940
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I351f8e8641a1cb9548154803da70bfde46ee180d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2:
(5 comments)
https://gerrit.osmocom.org/#/c/2924/2/include/osmocom/sigtran/sccp_sap.h
File include/osmocom/sigtran/sccp_sap.h:
Line 252: struct osmo_sccp_addr_list *
i wouldn't call the structure sccp_addr_list but something like
sccp_addr_entry. Calling it 'list' implies that
Review at https://gerrit.osmocom.org/2960
fsm.c: Fix compilation warning: Use PRIu32 for uint32_t
Change-Id: I4c441b20b250c34656f1e8330d6bb4b1ce2b8423
---
M src/fsm.c
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/2960/1
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2958
to look at the new patch set (#3).
configure.ac: Enable -Wall by default
Change-Id: I70f917e05ad46049487710d1752aad2505c96696
---
M configure.ac
1 file changed, 2 insertions(+), 2
Review at https://gerrit.osmocom.org/2961
pseudotalloc: Add poor implementation of talloc_asprintf
fsm.c uses this function. When compiled with --enable-embedded, it
triggers a warning:
fsm.c: In function 'osmo_fsm_inst_alloc':
fsm.c:213:4: warning: implicit declaration of function
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2845
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34f767234f677307bb04891b40f03109901c0f1b
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: Fix typo in sccp_types.h
..
cosmetic: Fix typo in sccp_types.h
change
SCCP_RETURN_CAUSE_SEGMENTATION_FAOLURE
to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2932
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I712cdd79cbba93f457705d38871bd8d4b7f4e897
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2958
configure.ac: Enable -Wall by default
Change-Id: I70f917e05ad46049487710d1752aad2505c96696
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/2958/1
diff --git
Review at https://gerrit.osmocom.org/2957
osmo-sim-test.c: Remove unused functions
Change-Id: I3060cfee8ece86c4c89a65f93c9f5424df0c410b
---
M utils/osmo-sim-test.c
1 file changed, 0 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/2957/1
Review at https://gerrit.osmocom.org/2956
sercomm_test.c: return correctly in main
Change-Id: I57fd3e1bf74ec24dec692710359a1ce00ecde75a
---
M tests/sercomm/sercomm_test.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Review at https://gerrit.osmocom.org/2955
abis_test.c: Fix warning appearing on some buggy gcc versions
Change-Id: I31d5ffc0cf461d207d6c3d43aa0a25a5448d7000
---
M tests/abis/abis_test.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2946
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I736f21f6528db5c16fa80cdb905af20673797be5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: OML Add osmocom-specific way to deactivate radio link timeout
..
OML Add osmocom-specific way to deactivate radio link timeout
In some situations (e.g.
Review at https://gerrit.osmocom.org/2959
timer_gettimeofday.c: Fix implicit use of timeradd
timer_gettimeofday.c: In function 'osmo_gettimeofday_override_add':
timer_gettimeofday.c:54:2: error: implicit declaration of function 'timeradd'
[-Werror=implicit-function-declaration]
Review at https://gerrit.osmocom.org/2949
card_fs_uicc.c: Fix unused compilation warning
This array of bytes is not yet used but is referring to some specs. They
may be used in the future, so leave it there but mark it explicitly as
unused.
Change-Id: I0a61d17f9989ecddafbc68d4b9446853e4c15159
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2952
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35d7d926939c14700cbca732bd64e588c75424b4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2949
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a61d17f9989ecddafbc68d4b9446853e4c15159
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2951
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I140de30038222b0419423d8c4f9da1946651a4e7
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2948
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32212f20756f828af1017482a71e29e4b3adbad4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2933
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9843137b55534a29938d5c2308244a6950de788f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 2:
I would argue to call it OSMO_BYTES_FOR_BITS() or something like that to make
the name more expressive.
--
To view, visit https://gerrit.osmocom.org/2901
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
Hi Gerrie, do you have any questions related to the feedback I provided in my
review a week ago? Would be really great to see this patch move ahead. Thanks!
--
To view, visit https://gerrit.osmocom.org/2870
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/2954
configure.ac: Enable -Werror by default
Change-Id: I1752cad1e34cb6e5f36edf3f538d803eff29d18c
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/2954/1
diff --git
Patch Set 1:
do we have that API documentation in the C files for the speciifc functions for
which you remove the comments in the header? If yes, we can merge this. If
no, then the patch should rather move the comments from .h to .c and
doxygen-ize them.
--
To view, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2941
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45bba5daf8610cbba6af95b92c2142f2256491ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2942
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a838fe3139fa977dfe906246020a14451185714
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2953
lapd_test.c: Convert compilation warning to level message
This way we clean the build of warnings completely and we can enable
-Werror but we still see this FIXME message while compiling.
Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
---
M
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2922/1/TODO-RELEASE
File TODO-RELEASE:
Line 14: libosmovty ABI change redefine _LAST_OSMOVTY_NODE as
a high number to increase node space
> you are removing two enum items and use reserved space, so _LAST_OSMOVTY_NO
the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2947
to look at the new patch set (#2).
Add vty command "radio-link-timeout infinite" for uplink rx testing
When we are performing Rx sensitivity testing on a BTS, we want to
deactivate the
Patch Set 4: Code-Review-1
needs very careful testing in terms of #2329
--
To view, visit https://gerrit.osmocom.org/2861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9c8f88b05cd5dba9920bb08e079a643e713237
Gerrit-PatchSet: 4
Patch Set 2: Code-Review-1
needs very careful testing in terms of #2329
--
To view, visit https://gerrit.osmocom.org/2867
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d369ff9e6da34f4bd98afd3c5d030cac73e54c0
Gerrit-PatchSet: 2
Patch Set 4: Code-Review-1
needs very careful testing in terms of #2329
--
To view, visit https://gerrit.osmocom.org/2813
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife3c791ff50e8a866a97b9783ac7ef3ef2402a70
Gerrit-PatchSet: 4
Review at https://gerrit.osmocom.org/2963
Fix warnings: tolower() and similar require uchar
utils.c: In function 'osmo_str2lower':
utils.c:277:3: warning: array subscript has type 'char' [-Wchar-subscripts]
out[i] = tolower(in[i]);
And according to man:
If c is neither an unsigned char
Review at https://gerrit.osmocom.org/2962
Fix compilation warnings: use correct log type for uint32_t
Change-Id: Ic1e3255800999669ca9619bfceb4124c773eff2d
---
M src/gsm/gsm48.c
M src/utils.c
2 files changed, 4 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/2964
gsm0411_utils.c: Fix compilation warnings
gsm0411_utils.c:102:2: warning: #warning find a portable way to obtain timezone
offset [-Wcpp]
#warning find a portable way to obtain timezone offset
gsm0411_utils.c: In function 'gsm338_get_sms_alphabet':
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2950
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaac701bdf0c0e66c343f68cc31d82550a024ef57
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cb94e0f024934f7baeeb728ca9ed3042fbf16d2
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2954
to look at the new patch set (#4).
configure.ac: Enable -Werror by default
Change-Id: I1752cad1e34cb6e5f36edf3f538d803eff29d18c
---
M configure.ac
1 file changed, 2 insertions(+), 2
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2930
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79926f25de088571fcc2c14388c72fc968c2d382
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Add vty command "radio-link-timeout infinite" for uplink rx
testing
..
Add vty command "radio-link-timeout infinite" for uplink rx testing
When we are
69 matches
Mail list logo
