Patch Set 2: Code-Review+2
It's questionable if this is really the right thing to do in SS7 networks.
Routing can be asymmetric, and particularly with GTT and GT based routing the
source adresss of responses cold be different than the destination address of
requests. But then, in *typical*
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3353
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46b1cc6e5502829e0c1dc84a184cd2002fbd2b18
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: lc15bts_mgr_vty.c: Fix typos in comments
..
cosmetic: lc15bts_mgr_vty.c: Fix typos in comments
Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3354
to look at the new patch set (#2).
sccp: fix possible nullpointer deref
check input parameters local_ip and remote_ip of the function
osmo_sccp_simple_client_on_ss7_id()
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3330
to look at the new patch set (#2).
sccp: derive local address from given sccp instance
The most important parts of an SCCP address are the routing
Review at https://gerrit.osmocom.org/3355
ensure valid primary_pc in osmo_ss7_instance
Add osmo_ss7_instance.cfg.primary_pc_valid flag.
Adjust all code paths setting primary_pc to also set primary_pc_valid.
Adjust all code paths using primary_pc to ensure it is indeed valid.
Rationale:
It
Review at https://gerrit.osmocom.org/3356
lc15: Tweak led colors used in service file
service sets led to orange before/while osmo-bts is being started.
osmo-bts-lc15 sets led to green while operating. (unchanged in here)
service sets led to red when osmo-bts stops running.
Change-Id:
Review at https://gerrit.osmocom.org/3354
sccp: fix possible nullpointer deref
check input parameters local_ip and remote_ip of the function
osmo_sccp_simple_client_on_ss7_id() before using them with
talloc_strdup()
Change-Id: I1a5dd1ea3167513bf9e7ae153f83e1ae3136c905
---
M src/sccp_user.c
1
