Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5698
to look at the new patch set (#3).
Implement support for paging by LAI.
Also, parse the complete cell identifier list for both LAC and LAI.
Change-Id:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5700
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64c8dbad3fc42bcb8dd4ac9b16bbd9c59a0cf5d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/5705/5/include/osmocom/bsc/osmo_bsc_grace.h
File include/osmocom/bsc/osmo_bsc_grace.h:
Line 34: struct gsm_bts *bts);
I think API-wise this might end up rather confusing. So either the BTS
selection is done
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5693
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8fc488ae2c022f75f0ca63483d80ed701e8c40
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5695
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7380f9d536c83ee1d612457af423dde9b96f5ad
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5698
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3c62ff0fccea586794ea4b3c275a0685cc9326e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5706
Set up GNU Autotest infrastructure
Test files are moved from CommonLibs/ to tests/CommonLibs/.
Some tests are disabled in autotest because they generate timedate
related output which cannot exactly match against expected output.
Change-Id:
Review at https://gerrit.osmocom.org/5707
tests: InterThread: adapt to have reproducible output and enable autotest
Change-Id: I05d4067890b526bd72d2eb31cf76de43ee11e80f
---
M tests/CommonLibs/InterthreadTest.cpp
M tests/CommonLibs/InterthreadTest.ok
M tests/testsuite.at
3 files changed, 30
Review at https://gerrit.osmocom.org/5709
tests: Log: adapt to have reproducible output and enable autotest
Change-Id: I77c40230503acadef5f64ab2624cd872f9782b98
---
M tests/CommonLibs/LogTest.cpp
M tests/CommonLibs/LogTest.err
M tests/CommonLibs/LogTest.ok
M tests/testsuite.at
4 files changed,
Review at https://gerrit.osmocom.org/5711
tests: Sockets: adapt to have reproducible output and enable autotest
Change-Id: I5414076c6846b849973bcdeb3f2358b28dcb004c
---
M tests/CommonLibs/SocketsTest.cpp
A tests/CommonLibs/SocketsTest.ok
M tests/testsuite.at
3 files changed, 10 insertions(+),
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3374
to look at the new patch set (#3).
gsm0480: modify USSD structures to support external handling
This change renames the 'ss_request' struct to 'gsm0480_ss_request',
and adds the
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3375
to look at the new patch set (#4).
gsm0480: clean up the parse_process_uss_req() code
This change reduces the degree of code nesting...
Change-Id:
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3378
to look at the new patch set (#4).
gsm0480: handle GSM0480_CTYPE_RETURN_RESULT
Change-Id: I8fb2856acbbf4c53e7d53200a37bc8f79e763bcf
---
M
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3377
to look at the new patch set (#4).
gsm0480: parse GSM0480_MTYPE_FACILITY separately
Change-Id: I6e029c436a50fa8c2823ea39c5d123ee701becfa
---
M
Hello Alexander Chemeris, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3381
to look at the new patch set (#4).
gsm0480: expose the gsm0480_parse_ss_facility_ie()
Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
---
M
Review at https://gerrit.osmocom.org/5708
tests: Timeval: adapt to have reproducible output and enable autotest
Change-Id: I1a79892ba3c934879a171789e0edb357277acae4
---
M tests/CommonLibs/TimevalTest.cpp
M tests/CommonLibs/TimevalTest.ok
M tests/testsuite.at
3 files changed, 20 insertions(+),
Review at https://gerrit.osmocom.org/5712
gsm0480: increase the MAX_LEN_USSD_STRING to 182
According to the GSM 04.08 specification, the maximum size of
a USSD message is 160 bytes. So, for 7-bit data coding schemes,
the maximum number of characters is 182 (160 * 8 / 7) characters.
Change-Id:
Review at https://gerrit.osmocom.org/5705
Implement support for paging based on CI (cell identifier).
This builds upon https://gerrit.osmocom.org/#/c/5698/ which implements
support for paging by LAI.
The ttcn3 test TC_paging_imsi_nochan_ci passes with this code when
run isolation. It does not
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/5698/2/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:
Line 348: lai.digits[0] = data[1 + i * sizeof(lai)];
> this is a really ugly/verbose way of manually copying individual bytes. why
Agreed, a
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5705
to look at the new patch set (#3).
Implement support for paging based on CI (cell identifier).
This builds upon https://gerrit.osmocom.org/#/c/5698/ which implements
support for paging
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5703
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a49aee94e3239194ad9742fb6374324acac0de
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5702
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51cb12d1ab7e103e78190ac71a70fb5bb1d9ff51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
At the same time, "missing header reference to stdio.h" is actual fix...
--
To view, visit https://gerrit.osmocom.org/5697
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/5697/1//COMMIT_MSG
Commit Message:
Line 7: meas_test: fix header file references
Not sure we are fixing anything in this change.
Probably, "drop useless includes" would be better here.
PS1, Line 13: remove all header file references
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5694
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a501715127c2583a630b1efb0d5316574eea173
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5648
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5aebbcacb68eab3c6afb19991dbf63a02524e4d7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5691
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa7f2a655474826630988572616cd26e1e2f3464
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5705
to look at the new patch set (#5).
Implement support for paging based on CI (cell identifier).
This builds upon https://gerrit.osmocom.org/#/c/5698/ which implements
support for paging
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5705
to look at the new patch set (#4).
Implement support for paging based on CI (cell identifier).
This builds upon https://gerrit.osmocom.org/#/c/5698/ which implements
support for paging
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5701
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcd789afe668a5c0271352f1d20d2efda826213a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5704
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I823aea91367d586507bbf352f1b6f25bdd635baa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5698
to look at the new patch set (#2).
Implement support for paging by LAI.
Also, parse the complete cell identifier list for both LAC and LAI.
Change-Id:
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 5
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5699
Add bitvec_set_u8() helper
It's similar to bitvec_set_u64() but does not work with L/H bits. Most
of the time (at least in 3GPP TS 44.018 ยง10.5.2.16 IA Rest Octets) we
only set small values. Having separate helper allows to avoid
unnecessary type
Patch Set 1:
Do you see an actual failure? Would be nice to add it to tests.
--
To view, visit https://gerrit.osmocom.org/5693
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8fc488ae2c022f75f0ca63483d80ed701e8c40
Gerrit-PatchSet: 1
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5692
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a72d36d777ba582815b2cdef8130ee88c060b54
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5689/3/src/gsm/tlv_parser.c
File src/gsm/tlv_parser.c:
Line 230: * \returns number of bytes consumed by the TLV entry / IE parsed
> It may be worth documenting in here that it can returns a negative value. A
Agreed. See patchset 3.
--
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5689/3/src/gsm/tlv_parser.c
File src/gsm/tlv_parser.c:
Line 230: * \returns number of bytes consumed by the TLV entry / IE parsed
> Agreed. See patchset 3.
I meant patchset 4.
--
To view, visit https://gerrit.osmocom.org/5689
To
Review at https://gerrit.osmocom.org/5691
mgcp: log file and line of calls to handle_error()
When the FSM runs into an error condition handle_error() is called with
a cause code. The information about the error is then printed by handle_error(),
by this we do not get the sourcecode line of the
Review at https://gerrit.osmocom.org/5692
Notify per email about master branch build failure
Change-Id: I0a72d36d777ba582815b2cdef8130ee88c060b54
---
M jobs/master-builds.yml
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci
Patch Set 1: Code-Review+1
Would be nice to get some "make check" tests which could be triggered by
jenkins.
--
To view, visit https://gerrit.osmocom.org/5687
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/5693
remove osmodumpdoc.py and osmotestconfig.py from py3 install
Install these scripts as py2 only.
These scripts were added to py3 in error by commit "Improve python3
compatibility", I80e5850a8978d78cda793e2192ef4bd3fd54a121, which only addresses
print()
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5689
to look at the new patch set (#4).
TLVP_PRESENT() should not return TRUE after tlv_parse() fails.
If the length provided in the patcket exceeds the buffer length,
Stefan Sperling has submitted this change and it was merged.
Change subject: Support control connection status query for a particular MSC.
..
Support control connection status query for a particular MSC.
Add a new control
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#19).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5367
to look at the new patch set (#5).
TBF: cleanup state flag handling
* introduce generic function to check whether particular flag was set
for'a TBF and clear it if necessary. Use
Patch Set 4:
Right, thanks for review.
--
To view, visit https://gerrit.osmocom.org/5367
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4560280c72f91700f2e19c6c7f6658dc29625c2
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch:
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5689/3/src/gsm/tlv_parser.c
File src/gsm/tlv_parser.c:
Line 230: * \returns number of bytes consumed by the TLV entry / IE parsed
It may be worth documenting in here that it can returns a negative value. A
reason users of this function
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5214
to look at the new patch set (#8).
osmo-bts-trx: perform error concealment for FR frames
When a bad voice frame is received, it is replaced by
a silence frame. This may
Review at https://gerrit.osmocom.org/5698
Implement support for paging by LAI.
Also, parse the complete cell identifier list for both LAC and LAI.
Change-Id: Ic3c62ff0fccea586794ea4b3c275a0685cc9326e
Related: OS#2751
---
M src/osmo-bsc/osmo_bsc_bssap.c
M tests/bssap/bssap_test.c
2 files
Review at https://gerrit.osmocom.org/5695
cosmetic: setup.py: move osmo_interact_* next to osmo_verify_*
Those scripts are semantically closely related, so place them next to each
other.
Change-Id: Id7380f9d536c83ee1d612457af423dde9b96f5ad
---
M setup.py
1 file changed, 2 insertions(+), 2
Review at https://gerrit.osmocom.org/5694
cosmetic: setup.py: tweak indenting, add vim comment
We usually do only space indenting in our py code, replace tabs with spaces.
Change to one script path per line for easier patch reading in the future.
Add a vim expandtab comment.
Change-Id:
Review at https://gerrit.osmocom.org/5696
Fix BTS location area code assignment in test configuration.
The paging tests expect BTS 0 and 1 in LAC 1, and BTS 2 in LAC 2.
BUt the osmo-bsc configuration file had BTS 1 in LAC 2, and BTS 2 in LAC 1.
Change-Id:
Hello Vadim Yanitskiy, Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5214
to look at the new patch set (#7).
osmo-bts-trx: perform error concealment for FR frames
When a bad voice frame is received, it is replaced by
a silence
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5700
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64c8dbad3fc42bcb8dd4ac9b16bbd9c59a0cf5d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5704
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I823aea91367d586507bbf352f1b6f25bdd635baa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5701
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcd789afe668a5c0271352f1d20d2efda826213a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5698/2/src/osmo-bsc/osmo_bsc_bssap.c
File src/osmo-bsc/osmo_bsc_bssap.c:
Line 348: lai.digits[0] = data[1 + i * sizeof(lai)];
this is a really ugly/verbose way of manually copying individual bytes. why
Harald Welte has submitted this change and it was merged.
Change subject: Fix BTS location area code assignment in test configuration.
..
Fix BTS location area code assignment in test configuration.
The paging tests expect BTS
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5696
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6b02fe06116dee59977422bc93bcafcd3aba76
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5684/2/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:
Line 651: return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] &
mnc[0]);
> The incoming values are defined in BSC_Tests.ttcn as hex
Review at https://gerrit.osmocom.org/5704
Remove Configuration module and libsqlite dependency
Change-Id: I823aea91367d586507bbf352f1b6f25bdd635baa
---
M AUTHORS
D CommonLibs/Configuration.cpp
D CommonLibs/Configuration.h
D CommonLibs/ConfigurationTest.cpp
M CommonLibs/Makefile.am
D
Review at https://gerrit.osmocom.org/5700
cosmetic: Remove trailing whitespace
Change-Id: I64c8dbad3fc42bcb8dd4ac9b16bbd9c59a0cf5d5
---
M AUTHORS
M CommonLibs/LogTest.cpp
M CommonLibs/Makefile.am
M Transceiver52M/Makefile.am
M configure.ac
5 files changed, 4 insertions(+), 10 deletions(-)
Review at https://gerrit.osmocom.org/5701
Logger: Stop using Log.Alarms.Max from config
This is a first step towards removing ConfigurationTable class and
sqlite3 dependency.
Change-Id: Idcd789afe668a5c0271352f1d20d2efda826213a
---
M CommonLibs/Configuration.cpp
M CommonLibs/Logger.cpp
2
Review at https://gerrit.osmocom.org/5702
Logger: Stop using Log.File and Log.Level from config
This is a required step towards getting rid of ConfigurationTable class
and libsqlite dependency.
As a side effect, support for different log levels for different files
is dropped, but it's not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5704
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I823aea91367d586507bbf352f1b6f25bdd635baa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/5704
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I823aea91367d586507bbf352f1b6f25bdd635baa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5702
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51cb12d1ab7e103e78190ac71a70fb5bb1d9ff51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5715
utils: Functions to encode/decode EF SPN.
According to TS 51 011.
Change-Id: Ida184bc5c81cc8c228b8981b703f77d017e53334
---
M pySim/utils.py
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim
Review at https://gerrit.osmocom.org/5717
Add methods to get ATR for a card or a link.
Implemented for both serial and PCSC readers.
Change-Id: Ic12e4b115d24a8b7e483a5603dd6cec90ad289cc
---
M pySim/commands.py
M pySim/transport/pcsc.py
M pySim/transport/serial.py
3 files changed, 19
Review at https://gerrit.osmocom.org/5716
utils: Fix documentation. 3+3=6 digits equals 3 bytes, not 6
Change-Id: I2722d788a69976e1c64a9caf6cf3049af27f9a30
---
M pySim/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim
Review at https://gerrit.osmocom.org/5718
cards: Extend Card class with access functions for some of the standard EF
files.
Change-Id: Icb7227fa7ebc837fccab456cbfad529f6ee81a28
---
M pySim/cards.py
1 file changed, 67 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/5713
Fix comment: Ki -> OPC
Change-Id: I566cf7bc658c730b4381c0f145bfc4f805cca42a
---
M pySim-prog.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/5713/1
diff --git a/pySim-prog.py
Review at https://gerrit.osmocom.org/5720
pySim-prog: Replace magic numbers with a readable EF file name.
Change-Id: Ibda7d5a4132971e884f6d760baf20cd33025a2af
---
M pySim-prog.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim
Review at https://gerrit.osmocom.org/5721
cards: Implement card type autodetection based on ATR.
Change-Id: I1099a96626c0ce74243b47a8fdfa25b0d76a1ef3
---
M pySim/cards.py
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/5721/1
Review at https://gerrit.osmocom.org/5722
cards: Add Fairwaves SIM implementation.
Change-Id: Ia10ac433d3b0482bdf727c31f65a10042152797b
---
M pySim/cards.py
1 file changed, 145 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/5722/1
diff --git
Review at https://gerrit.osmocom.org/5719
pySim-prog: ADM code can be longer 8 digits, it's implementation specific.
E.g. Fairwaves SIM cards have longer ADM codes.
Change-Id: I87d61764eeba4bcf7525ee4778cb8f244930db9b
---
M pySim-prog.py
1 file changed, 3 insertions(+), 4 deletions(-)
git
77 matches
Mail list logo
