[PATCH] osmo-pcu[master]: Allow specifying sysmocom headers explicitly

2018-01-15 Thread Max
Review at https://gerrit.osmocom.org/5796 Allow specifying sysmocom headers explicitly The headers for LC1.5 are specified explicitly. Add corresponding option to specify sysmoBTS headers location and use it in jenkins build. While at it, unify header fixup code with the one used in OsmoBTS.

[PATCH] osmo-mgw[master]: cosmetic: mgcp_network: typo in log

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5794 cosmetic: mgcp_network: typo in log Change-Id: Ia7675e52fe1082d21bd68dcf54fe34c0f0326f11 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/94/5794/1

[PATCH] osmo-msc[master]: Improve an error message in db_init().

2018-01-15 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/5795 Improve an error message in db_init(). If we cannot open a connection to the sqlite3 database, show the name of the database we failed to access, and also hint at the fact that a likely reason for the problem is a missing sqlite3 driver for libdbi.

osmo-mgw[master]: cosmetic: mgcp_network: typo in log

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5794 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7675e52fe1082d21bd68dcf54fe34c0f0326f11 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-pcu[master]: Allow specifying sysmocom headers explicitly

2018-01-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5796 to look at the new patch set (#3). Allow specifying sysmocom headers explicitly The headers for LC1.5 are specified explicitly. Add corresponding option to specify

[PATCH] osmo-pcu[master]: Allow specifying sysmocom headers explicitly

2018-01-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5796 to look at the new patch set (#4). Allow specifying sysmocom headers explicitly The headers for LC1.5 are specified explicitly. Add corresponding option to specify

osmo-pcu[master]: Allow specifying sysmocom headers explicitly

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5796 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5248e8b389fd240b4d5a0bcf6c954d6115262462 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-msc[master]: Improve an error message in db_init().

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5795 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1c0026e882984b4358ce116ec4a7ad40340517c Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#8). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#12). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

[PATCH] osmo-pcu[master]: Allow specifying sysmocom headers explicitly

2018-01-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5796 to look at the new patch set (#2). Allow specifying sysmocom headers explicitly The headers for LC1.5 are specified explicitly. Add corresponding option to specify

osmo-pcu[master]: Fix sanitizer build

2018-01-15 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5779 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I695baaf8ce78ed938f6f71c40d17120fa690338b Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#11). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#13). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

[PATCH] openbsc[master]: mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS

2018-01-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5797 mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS Currently, we see the following failure: make[3]: Entering directory '/build/openbsc/tests/mgcp' CC mgcp_transcoding_test.o CC mgcp_test.o In file included from

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#10). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

osmocom-bb[master]: bsic decoding of neighbour cells in dedicated mode and parti...

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Note that a detailed description of this patch can be found in http://lists.osmocom.org/pipermail/openbsc/2018-January/011648.html Help required for non-sync Handover Muhammad Awais Aslam mawais.aslam985 at gmail.com Mon Jan 15 13:31:32 UTC 2018 Quoting: We took code related to

[MERGED] openbsc[master]: mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS

2018-01-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS .. mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS Currently, we see the following failure: make[3]:

[PATCH] osmo-ci[master]: jobs: osmo-trx: Set slave_axis to use only debian9

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5798 jobs: osmo-trx: Set slave_axis to use only debian9 Debian 8 contains quite old qemu and proot packages which have some issues running the chroot infrastructure set up in osmo-trx's jenkins.sh. Change-Id: I24665880fff5a5b918bb6ffaf1e7bb51ae860b0b --- M

[MERGED] osmo-pcu[master]: Fix sanitizer build

2018-01-15 Thread Max
Max has submitted this change and it was merged. Change subject: Fix sanitizer build .. Fix sanitizer build Add sanitizer flags to linker as well to resolve linker error. Change-Id: I695baaf8ce78ed938f6f71c40d17120fa690338b

[MERGED] osmo-pcu[master]: Allocate global context for TypesTest

2018-01-15 Thread Max
Max has submitted this change and it was merged. Change subject: Allocate global context for TypesTest .. Allocate global context for TypesTest Missing allocation leads to LSAN error: ==24997==ERROR: LeakSanitizer: detected

osmo-pcu[master]: Allocate global context for TypesTest

2018-01-15 Thread Max
Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/5785 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62c03dad353f459abcdb7a18a69b7782da38dfb7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[PATCH] osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5763 to look at the new patch set (#9). contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests with ARM instruction set The following logic doesn't require root access

osmo-ci[master]: jobs: osmo-trx: Set slave_axis to use only debian9

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5798 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24665880fff5a5b918bb6ffaf1e7bb51ae860b0b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

openbsc[master]: mgcp_transcoding_test: Add LIBOSMOABIS_CFLAGS

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5797 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27c25adfc6ee2c6f07315f3bc76fa7a70202ac4d Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

osmocom-bb[master]: bsic decoding of neighbour cells in dedicated mode and parti...

2018-01-15 Thread Harald Welte
Patch Set 1: Code-Review-2 (8 comments) Hi Muhammad. Thanks for your submission. However, I had to stop after reviewing about one third of the patch, as it seems you have not been using git properly and the patch is removing lots of code from current master. Please make sure to submit a

osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Harald Welte
Patch Set 13: why keeping it in /opt and not in the workspace? The per-job directories on each slave are persistent, aren't they? At least when I log in via SSH I always see plenty of those directories? -- To view, visit https://gerrit.osmocom.org/5763 To unsubscribe, visit

[PATCH] osmo-bsc[master]: Don't make libcommon, libcommon-cs, libfilter, utils depend ...

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#6). Don't make libcommon, libcommon-cs, libfilter, utils depend on mgcp/sigtran The stow-enabled jenkins builds are currently failing like below:

Build failure of network:osmocom:nightly/osmo-trx in Debian_8.0/i586

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_8.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

[PATCH] osmo-mgw[master]: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS, LIBS}

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5799 to look at the new patch set (#3). osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS} The osmo-mgw gerrit build is currently failing with the following error: make[3]: Entering directory

osmo-mgw[master]: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS}

2018-01-15 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5799 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402314532590498a6340dc14101a32b605cd5e09 Gerrit-PatchSet: 3 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[MERGED] osmo-mgw[master]: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS, LIBS}

2018-01-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS} .. osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS} The osmo-mgw gerrit build is currently failing with the

osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Harald Welte
Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5763 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3f4de008662805d8ffc46e1f473e407b088fb8 Gerrit-PatchSet: 13 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-bsc[master]: Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#5). Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils The stow-enabled jenkins builds are currently failing like below: make[3]: Entering

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

osmo-pcu[master]: Set V_N and V_B to known initial state

2018-01-15 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5786 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e14ffa913b49c5394229220de9165cdfaabdf19 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Patch Set 13: Sorry for the all the noise related to this patch. It seems to be working fine now. I ended up pregenerating the image and keeping it inside the jenkins slave (lxc container) in /opt/qemu-img, as otherwise it took really long building the image everytime the job had to run.

[PATCH] osmo-mgw[master]: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS, LIBS}

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5799 to look at the new patch set (#2). osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS} The osmo-mgw gerrit build is currently failing with the following error: make[3]: Entering directory

[PATCH] osmo-bsc[master]: Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#3). Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils The stow-enabled jenkins builds are currently failing like below: make[3]: Entering

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.04/i586

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [

osmo-trx[master]: contrib/jenkins.sh: Use qemu+proot+debootstrap to run tests ...

2018-01-15 Thread Pau Espin Pedrol
Patch Set 13: > why keeping it in /opt and not in the workspace? The per-job > directories on each slave are persistent, aren't they? At least > when I log in via SSH I always see plenty of those directories? They are not persistent in the sense that they get cleaned everytime by

[PATCH] osmo-bsc[master]: Add LIBOSMOSIGTRAN_CFLAGS to libcommon, libcommon-cs, libfil...

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#2). Add LIBOSMOSIGTRAN_CFLAGS to libcommon, libcommon-cs, libfilter, utils The stow-enabled jenkins builds are currently failing like below: make[3]:

[PATCH] osmo-bsc[master]: handover_decision: Fix condition for power budget handover a...

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5801 handover_decision: Fix condition for power budget handover attempt Handover attempt for power budget case should be performed every N SACCH frames, where N = Power Budget Interval. First measurement report with mr->nr = 0 was used for the first

[PATCH] osmo-bsc[master]: handover_decision: log HO causes more accurately

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5802 handover_decision: log HO causes more accurately Tweaked-by: nhofm...@sysmocom.de Change-Id: Ib0a0787ac8b877ac63455d72886389b546e7a337 --- M src/libbsc/handover_decision.c 1 file changed, 15 insertions(+), 5 deletions(-) git pull

[PATCH] osmo-bsc[master]: Make libcommon, libcommon-cs, libfilter, utils depend on mgc...

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#7). Make libcommon, libcommon-cs, libfilter, utils depend on mgcp/sigtran The stow-enabled jenkins builds are currently failing like below: make[3]:

[MERGED] osmo-bsc[master]: Make libcommon, libcommon-cs, libfilter, utils depend on mgc...

2018-01-15 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Make libcommon, libcommon-cs, libfilter, utils depend on mgcp/sigtran .. Make libcommon, libcommon-cs, libfilter, utils depend on mgcp/sigtran The

osmo-bsc[master]: Make libcommon, libcommon-cs, libfilter, utils depend on mgc...

2018-01-15 Thread Harald Welte
Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5800 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b75db6ffba227b05b5413b84b15f69e0c213f2 Gerrit-PatchSet: 7 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-mgw[master]: osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS, LIBS}

2018-01-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5799 osmo-bsc_mgcp: Add LIBOSMONETIF_{CFLAGS,LIBS} The osmo-mgw gerrit build is currently failing with the following error: make[3]: Entering directory '/build/src/osmo-bsc_mgcp' CC mgcp_main.o In file included from

[PATCH] osmo-bsc[master]: Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils

2018-01-15 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5800 to look at the new patch set (#4). Add missing CFLAGS to libcommon, libcommon-cs, libfilter, utils The stow-enabled jenkins builds are currently failing like below: make[3]: Entering

[MERGED] libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

2018-01-15 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: libosmocodec: implement ECU (Error Concealment Unit) for FR .. libosmocodec: implement ECU (Error Concealment Unit) for FR When a bad GSM voice frame

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/aarch64

2018-01-15 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log:

[PATCH] osmo-bsc[master]: Add LIBOSMOSIGTRAN_CFLAGS to libcommon, libcommon-cs, libfil...

2018-01-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5800 Add LIBOSMOSIGTRAN_CFLAGS to libcommon, libcommon-cs, libfilter, utils The stow-enabled jenkins builds are currently failing like below: make[3]: Entering directory '/build/src/libcommon' CC bsc_version.o CC common_vty.o CC

[PATCH] osmo-iuh[master]: cosmetic: hnbgw: hnbap: log rx of unsuccessful outcome

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5808 cosmetic: hnbgw: hnbap: log rx of unsuccessful outcome HNBAP isn't really that important to osmo-hnbgw operation, all we do is service the few requests so that the other side is happy and uses our Iuh. Nevertheless, could at least log if an

[PATCH] osmo-iuh[master]: hnbgw_rua: fix dereference of unset pointer

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5805 hnbgw_rua: fix dereference of unset pointer In the UNITDATA case, there is no map, so a) initialize map as NULL and b) print the RUA ctx id directly from local var context_id instead. Fixes: CID#181969 Change-Id:

[PATCH] osmo-iuh[master]: hnbgw_rua.c: log: fix integer format for cN_DomainIndicator

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5804 hnbgw_rua.c: log: fix integer format for cN_DomainIndicator Fixes: CID#135219 Change-Id: I32c11100c87a59f34d7c1fefd2f0037e5d63f0e0 --- M src/hnbgw_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh

[PATCH] osmo-ttcn3-hacks[master]: Add "SourceInfoFormat := Single; " to all test configs

2018-01-15 Thread Harald Welte
Review at https://gerrit.osmocom.org/5803 Add "SourceInfoFormat := Single;" to all test configs This will make sure that all log files will contain information about the .ttcn source file name and line number that has caused the log, which is extremely useful during debugging. Change-Id:

[PATCH] osmo-iuh[master]: hnbgw_hnbap: fix missing return in rx [un]successful outcome

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5807 hnbgw_hnbap: fix missing return in rx [un]successful outcome Fixes: CID#57732 CID#57733 Change-Id: Iddf76d23c2c7d5824e82708f7da013c88411e832 --- M src/hnbgw_hnbap.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull

[PATCH] osmo-iuh[master]: hnbgw_cn: rx ranap: set rc in all cases

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5806 hnbgw_cn: rx ranap: set rc in all cases There don't seem to be any evaluations of the rc, nevertheless return well-defined values. Fixes: CID#181968 Change-Id: I59295388564e5d270da32db6e7488755231f8a11 --- M src/hnbgw_cn.c 1 file changed, 3

[PATCH] libosmocore[master]: logging: allow to log only the basename of each source

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5814 logging: allow to log only the basename of each source In the VTY print filename command, add another parameter 'basename' to yield: logging print filename (0|1|basename|with-cat) In the C API, add another function log_set_print_basename() (when

[PATCH] libosmocore[master]: logging: separate the '<000b>' subsys from filename logging

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5812 logging: separate the '<000b>' subsys from filename logging Allow to log only the source filename and omit the (weird) hex output of the logging subsystem. The default behavior and old API usage remains unchanged. To remain backwards compatible: -

[PATCH] libosmocore[master]: logging: vty: add 'logging print file (0|1|with-cat)' cmd

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5813 logging: vty: add 'logging print file (0|1|with-cat)' cmd Add a VTY command that allows configuring the output of source filename. So far, this was not configurable by VTY at all. Accomodate the (what I see as) legacy behavior of including the log

[PATCH] libosmocore[master]: logging: color the log category according to level

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5811 logging: color the log category according to level When log_set_use_color() is enabled, color the log category string according to the log level. The log line before and after the log category is printed in the category's configured color. ERROR and

[PATCH] libosmocore[master]: logging: allow adding separators to the extended-timestamp

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5815 logging: allow adding separators to the extended-timestamp Add a log target config to allow separating the extended timestamp. Before: 20180116014434681 After: 2018-01-16 01:44:34.681 The default behavior, previous API argument behavior and VTY

[PATCH] libosmocore[master]: logging: color the log level

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5810 logging: color the log level When log_set_use_color() is enabled, color the log level string according to the log level. The log line before and after the log level is printed in the category's color. ERROR and FATAL are red, NOTICE is yellow, INFO is

[PATCH] libosmocore[master]: logging: add ability to log the log-level with API and vty

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5809 logging: add ability to log the log-level with API and vty Log the log level string after the category name, if enabled. The default behavior remains unchanged. Change-Id: Ie6be365cfa6aeabdf115bff19bac198440c9adf1 --- M include/osmocom/core/logging.h

[PATCH] libosmocore[master]: cosmetic: logging: if color is disabled, don't print ""

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5816 cosmetic: logging: if color is disabled, don't print "" If color output is disabled, skip the empty snprintf() to (not) clear the ANSI color. Also, no need to use a format string of "%s", just pass the string constant directly. That is a micro

[PATCH] python/osmo-python-tests[master]: Print version before tests

2018-01-15 Thread Max
Review at https://gerrit.osmocom.org/5791 Print version before tests This helps with debugging of import-related issues - we know the version under test before the test has a chance to hang. Change-Id: If13cba60a19e9c15885355f85def4d134fa37993 Related: OS#2821 --- M osmopy/__init__.py M

osmo-ci[master]: docker: rebuild: if building fails, try a --no-cache build

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5792 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37110287dabd53d3537d94ecd74cf513396971b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch:

[MERGED] osmo-ci[master]: docker: rebuild: if building fails, try a --no-cache build

2018-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: docker: rebuild: if building fails, try a --no-cache build .. docker: rebuild: if building fails, try a --no-cache build Building a docker image

[PATCH] python/osmo-python-tests[master]: Fix install in the presence of old modules

2018-01-15 Thread Max
Review at https://gerrit.osmocom.org/5793 Fix install in the presence of old modules If older incompatible version of osmopython is already available, it might be chosen fori mport instead of current version. Fix this by explicitly prepending the proper version to path. Change-Id:

[MERGED] python/osmo-python-tests[master]: Print version before tests

2018-01-15 Thread Max
Max has submitted this change and it was merged. Change subject: Print version before tests .. Print version before tests This helps with debugging of import-related issues - we know the version under test before the test has

[PATCH] osmo-ci[master]: docker: rebuild: if building fails, try a --no-cache build

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5792 docker: rebuild: if building fails, try a --no-cache build Building a docker image depending on a debian upstream has the problem that an intermediate build result will depend on an APT package archive that is probable to become outdated. It's

osmo-bsc[master]: Implement support for paging based on LAC and CI.

2018-01-15 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5757 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f596663a97a1db1a00f115a366f4a5a271c127 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

python/osmo-python-tests[master]: Print version before tests

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 jenkins should always print the git hashes, but if you need this... -- To view, visit https://gerrit.osmocom.org/5791 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If13cba60a19e9c15885355f85def4d134fa37993

python/osmo-python-tests[master]: Fix install in the presence of old modules

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5793 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbe2af1e3815406213be29e0c0360432dc9fd6fb Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests

[MERGED] python/osmo-python-tests[master]: Fix install in the presence of old modules

2018-01-15 Thread Max
Max has submitted this change and it was merged. Change subject: Fix install in the presence of old modules .. Fix install in the presence of old modules If older incompatible version of osmopython is already available, it

[PATCH] osmo-pcu[master]: Fix sanitizer build

2018-01-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5779 to look at the new patch set (#2). Fix sanitizer build Add sanitizer flags to linker as well to resolve linker error. Change-Id:

[PATCH] osmo-pcu[master]: Allocate global context for TypesTest

2018-01-15 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5785 to look at the new patch set (#2). Allocate global context for TypesTest Missing allocation leads to LSAN error: ==24997==ERROR: LeakSanitizer: detected memory leaks

[PATCH] osmo-trx[master]: tests: SocketsTest: Avoid hang forever if test fails

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5781 tests: SocketsTest: Avoid hang forever if test fails Change-Id: Ia95e216a2ab6d397ab02c828b70f2b95d1671257 --- M tests/CommonLibs/SocketsTest.cpp 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx

[PATCH] osmo-ci[master]: gerrit-verifications.yml: Build osmo-trx with different opti...

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5784 gerrit-verifications.yml: Build osmo-trx with different optimization instruction sets enabled Change-Id: I1d73165a397d98d8fb630f7adec45f00887c139a --- M jobs/gerrit-verifications.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-trx[master]: tests: SocketsTest: Fail test on write fail

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5782 tests: SocketsTest: Fail test on write fail Change-Id: Ib6b778a2225339ebd2eaa80b3fca6ee8d8646b23 --- M tests/CommonLibs/SocketsTest.cpp 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx

[PATCH] osmo-trx[master]: tests: SocketTests: Pick OS-assigned instead of setting one ...

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5780 tests: SocketTests: Pick OS-assigned instead of setting one manually This fixes failures if the port is already being taken by other apps or if this test is run several times concurrently in the same system. Change-Id:

[PATCH] osmo-ci[master]: master-builds.yml: osmo-sgsn: Remove duplicated concurrent a...

2018-01-15 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/5783 master-builds.yml: osmo-sgsn: Remove duplicated concurrent attribute Change-Id: I32938d4c1854ce65faa718eccaecb5e3143dbcd0 --- M jobs/master-builds.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

osmo-ci[master]: master-builds.yml: Build osmo-trx with different optimizatio...

2018-01-15 Thread Pau Espin Pedrol
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/5759 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651e182dfd62ef4b88d013d8b5960ce7e3562ecf Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: gerrit-verifications.yml: Build osmo-trx with different opti...

2018-01-15 Thread Pau Espin Pedrol
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/5784 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d73165a397d98d8fb630f7adec45f00887c139a Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-pcu[master]: Allocate global context for TypesTest

2018-01-15 Thread Max
Review at https://gerrit.osmocom.org/5785 Allocate global context for TypesTest Missing allocation leads to LSAN error: ==24997==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 230 byte(s) in 2 object(s) allocated from: #0 0x7feaa1b2fb50 in __interceptor_malloc

osmo-ci[master]: README: also hint at /n/home/dub8/.config/jenkins_job_builde...

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/5774 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bb6792ab061edd3d688e387fa69cd8637617dee Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[PATCH] osmo-ci[master]: docker: debian: install stow, now used in various builds

2018-01-15 Thread Neels Hofmeyr
docker: debian: install stow, now used in various builds Recent change I8f5012419495a656912b7b71e4f76ce102c6b63a adds use of stow in osmo-build-dep.sh, hence our jenkins build processes now require the 'stow' dependency. Add 'stow' to our debian docker images, used for various builds (those that

[MERGED] osmo-ci[master]: docker: debian: install stow IN THE RIGHT dockerfile

2018-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: docker: debian: install stow IN THE RIGHT dockerfile .. docker: debian: install stow IN THE RIGHT dockerfile Recent change

[PATCH] osmo-ci[master]: docker: debian: install stow IN THE RIGHT dockerfile

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5790 docker: debian: install stow IN THE RIGHT dockerfile Recent change I8f5012419495a656912b7b71e4f76ce102c6b63a adds use of stow in osmo-build-dep.sh, hence our jenkins build processes now require the 'stow' dependency. Add 'stow' to our debian docker

osmo-ci[master]: docker: debian: install stow IN THE RIGHT dockerfile

2018-01-15 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5790 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If97176f4aea66c42a6820f14ceb4b91369841ca0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch:

[MERGED] python/osmo-python-tests[master]: Fix absolute import issue in py3

2018-01-15 Thread Max
Max has submitted this change and it was merged. Change subject: Fix absolute import issue in py3 .. Fix absolute import issue in py3 As of 577f2a95e4f01c58a0a4f4ccb3b70d9c048b626e in osmo-ci, the contrib/jenkins.sh isused

python/osmo-python-tests[master]: Fix absolute import issue in py3

2018-01-15 Thread Max
Patch Set 2: > In osmo-gsm-tester we use 'from . import foo'. That won't work because tests are in separate subdirectory so we should go one level up. > possible could be a symlink I'd rather keep it in one single place next to comment with explanation. > with a PYTHONPATH env variable set

[PATCH] osmo-ci[master]: docker: debian: install stow, now used in various builds

2018-01-15 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5789 docker: debian: install stow, now used in various builds Recent change I8f5012419495a656912b7b71e4f76ce102c6b63a adds use of stow in osmo-build-dep.sh, hence our jenkins build processes now require the 'stow' dependency. Add 'stow' to our debian docker

[MERGED] osmo-ci[master]: README: also hint at /n/home/dub8/.config/jenkins_job_builde...

2018-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: README: also hint at /n/home/dub8/.config/jenkins_job_builder/jenkins_jobs.ini .. README: also hint at

osmo-ci[master]: docker: debian: install stow, now used in various builds

2018-01-15 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5789 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a44ba5ed130a3311460185507f76151c6daa7f1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch:

[MERGED] osmo-ci[master]: docker: debian: install stow, now used in various builds

2018-01-15 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: docker: debian: install stow, now used in various builds .. docker: debian: install stow, now used in various builds Recent change

  1   2   >