Review at https://gerrit.osmocom.org/6629
Add initial OsmoBTS test suite
This Test suite implements the BSC-side of Abis RSL and is used to
test OsmoBTS. It contains provisions for using L1CTL against
(virt_phy + osmo-bts-virtual) or (trxcon + fake_trx + osmo-bts-trx)
to also simulate the
Review at https://gerrit.osmocom.org/6627
RSL_Emulation: Introduce notion of 'bts_role'
So far we assumed we emulate the BTS side and talk to a BSC.
Let's make this configurable and disable the BTS-side spcific code
paths by means of a 'bts_role' boolean type.
Change-Id:
Review at https://gerrit.osmocom.org/6628
RSL_Emulation: Pass ASP_IPA_EVENT_UP to RSL_CCHAN port
When emulating the BSC side of RSL, this can be used by a test case
to wait for the RSL connection to be established.
Change-Id: Iad2f6e4cb6a8f3b77e452f36a83ec11e7554e6c7
---
M
Review at https://gerrit.osmocom.org/6626
IPA_Emulation: Don't log IPAC_MSGT_ID_RESP as "Unknown/unsupported"
Change-Id: I6ea3855a1f3d1cba6ac173b0f9cf9052d5d028fc
---
M library/IPA_Emulation.ttcnpp
1 file changed, 3 insertions(+), 0 deletions(-)
git pull
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6612
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d6df1578c3a4c1a37bd0d69952d443f62eed2ab
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6611
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1133e181183bec8dabe2fa77d0385f783458503f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3905
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64cf78c5cfc78664766f9769dd5cde632dab92b0
Gerrit-PatchSet: 17
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: configure.ac: Check for pkg-config
..
configure.ac: Check for pkg-config
Change-Id: I1a851181a99f2f35ea4ff1b38c7afe27a04e5f18
---
M configure.ac
1
Review at https://gerrit.osmocom.org/6630
HO: fix minor issues found by coverity
handover_decision_2:
- lchan->conn should never be NULL, but if it is, don't crash in LOGPHO*
macros.
- make certain to avoid modulo-zero. It's cosmetic since that config item is
not allowed to be zero.
Patch Set 1:
commitlog is missing the important part on "why" (I know, but the commit log is
for everyone to read/understand)
--
To view, visit https://gerrit.osmocom.org/6625
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
commitlog is missing the important part on "why" (I know, but the commit log is
for everyone to read/understand)
--
To view, visit https://gerrit.osmocom.org/6624
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Simplify TS alloc: move slot check into functions
..
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of
Harald Welte has submitted this change and it was merged.
Change subject: Simplify TS alloc: move slot assignment
..
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL
Patch Set 27:
(1 comment)
https://gerrit.osmocom.org/#/c/3895/27/tests/alloc/AllocTest.err
File tests/alloc/AllocTest.err:
Line 196: [DL] algo A (suggested TRX: -1): failed to find a usable TRX
(TFI exhausted)
why does the old log line statte "multi" and the new one "single"? This looks
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6623/1/include/osmocom/vty/ports.h
File include/osmocom/vty/ports.h:
Line 34: #define OSMO_VTY_PORT_TRX 4263
I would argue for a lower port number. Trdaitionally we've had lower port
numbers for lower elements in the stack (i.e. BTS
Patch Set 1:
commitlog is missing the important part on "why" (I know, but the commit log is
for everyone to read/understand)
--
To view, visit https://gerrit.osmocom.org/6622
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6643
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I509f2a7bbfa96c70bdfea4ff2488ee371e914620
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6645
sgsn_test: guard against struct gprs_ra_id changing
sgsn_test initializes various struct gprs_ra_id without naming the actual
members, which is vulnerable to struct member re-ordering. Name the members
explicitly.
An upcoming ABI change in libosmocore
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6642
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26765a64153368016921c2ac115b1c4aec9bc5e4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6641
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6d50c6f4e2348b23f31c3415b0f5577a3f5be50
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 4:
I would prefer to integrate both talloc and signal handlers separately...
--
To view, visit https://gerrit.osmocom.org/6618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
Review at https://gerrit.osmocom.org/6650
vty: Implement VTY cfg parsing for current parameters
At this stage, osmo-trx still uses the cmdline parameters top run the
device, but it is already able to parse all the same parameters from a
cfg file through the VTY and filling a trx_ctx structure
Review at https://gerrit.osmocom.org/6651
osmo-trx: Drop cmd lines and use VTY cfg
Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 99 insertions(+), 319 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#5).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6618
to look at the new patch set (#5).
Depend on libosmocore
Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
---
M Transceiver52M/Makefile.am
M configure.ac
M contrib/jenkins.sh
3
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6620
to look at the new patch set (#5).
Logger: Use libosmocore logging system
We still need an intermediate class Logger due to osmo-trx being
multi-threaded and requiring to have a lock
Review at https://gerrit.osmocom.org/6648
osmo-trx.cpp: Move trx start and stop to helper functions
Make main() smaller, and make it easier to replace cmdline parameters in
following commits.
Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b
---
M Transceiver52M/osmo-trx.cpp
1 file
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review-1
I support the idea of using a proper enum X instead of int.
But do we really have to move these enums away from classes?
I believe there should be a way to avoid this...
--
To view, visit https://gerrit.osmocom.org/6649
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6649/1//COMMIT_MSG
Commit Message:
Line 9: This patch is a preparation for next patches, which add full VTY cfg
Moreover, the commit message doesn't explain why
this is necessary :?
--
To view, visit https://gerrit.osmocom.org/6649
To
Review at https://gerrit.osmocom.org/6647
osmo-trx: Set up talloc ctx
Change-Id: I67f1980fc615ab74371cbe1c4f83e987381299bc
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/47/6647/1
diff --git
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 79: #define DEFAULT_CONFIG_FILE"/etc/osmocom/osmo-trx.cfg"
I am not sure, is this common for Osmocom projects to
keep the configuration files in
Review at https://gerrit.osmocom.org/6646
osmo-trx: set up signals using libosmocore helpers
Change-Id: I86e78cd6054d0deff1b1aa061299d9f307e2a352
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 20 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6646/1/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 248: fprintf(stdout, "SIGINT received, shutting down\n");
We already printed, which signal was received.
Let's either drop the 'SIGINT received'
Review at https://gerrit.osmocom.org/6649
Move enums required by VTY to a separate header
This patch is a preparation for next patches, which add full VTY cfg
support.
Change-Id: I3d5b0576aa96869756f1629a40306c0043b6304b
---
M CommonLibs/Makefile.am
A CommonLibs/config_defs.h
M
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/CommonLibs/trx_vty.h
File CommonLibs/trx_vty.h:
Line 7: struct trx_ctx {
Please add a comment with brief description of this
structure and further plans, i.e. what is it going
to be used for?
--
To view, visit
Patch Set 4:
(2 comments)
And do we really need to test logging here?
It's already being tested in libosmocore,
so testing here for me seems useless...
https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am
File CommonLibs/Makefile.am:
Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS)
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I977dc729ba856631245aedf76afd48eac92166f7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 345: config->config_file = (char *)DEFAULT_CONFIG_FILE;
Why do we need this cast?
It should already be (char *), am I wrong?
--
To view,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6634
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd2571726d1284a7431b3f9b23ad3185e832ed1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6647
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67f1980fc615ab74371cbe1c4f83e987381299bc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 4:
(2 comments)
Re: testing again here:
It still makes sense to check logging here as it uses this Log class on top,
which adds locking mechanism.
https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am
File CommonLibs/Makefile.am:
Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS)
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
> Why not to use a macros here?
what's wrong with a function? it gets inlined by the compiler anyway...
--
To view,
101 - 143 of 143 matches
Mail list logo
