Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7158/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:
Line 30: ##
> don't see why this comment. I'm allowed to instantiate a Pcu class and use
You cannot do it because this is an abstract class (as specified
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7273
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b666f23402a6d94af2d903e514770d1fd5157f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> from a python doc point of view, nothing has changed at all. If a function
This change improves legibility of the code
Review at https://gerrit.osmocom.org/7277
msc_mgcp: fix mgw timeout handling
When the MGW does not respond to an MGCP message then the mgcp FSM
terminates, but the CC handler (gsm_04_08.c) is not informed. This
lets the CC handler think that the MGCP connection would be successful,
so it also
Review at https://gerrit.osmocom.org/7279
cosmetic: remove disabled (debug) code gsm_04_08.c
gsm_04_08.c seems to contain some lines of old debug code that
is commented out. Presumably the commented lines are a leftover
from a debug session.
- remove those commented code lines
Change-Id:
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/7160/3/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 26: class Bts(log.Origin, metaclass=ABCMeta):
> could you explain ABCMeta? What does it help us with?
https://docs.python.org/3/library/abc.html
It helps us
Review at https://gerrit.osmocom.org/7280
MSC_Tests: Respond to BSSMAP rlease
The testcase TC_mo_crcx_ran_timeout does not respond to the BSSMAP
relase request that is sent when the MGW times out.
- Acknowledge the releas request before waiting for the MSC
to clear the SSCP connection
Review at https://gerrit.osmocom.org/7278
gsm_04_08: clear SCCP connection when release is not acknowledged
When call control messages time out (e.g. because the mobile does
not answer anymore) then the BSSAP connection is not cleared.
- fix the CC timeout handler, so that it clears the
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/7168/4/src/osmo_gsm_tester/bts_nanobts.py
File src/osmo_gsm_tester/bts_nanobts.py:
Line 36: if conf.get('addr', None) is None:
> AFAIR if you don't pass a second argument, then it throws an exception if t
Hm actually it does not,
Patch Set 4:
(5 comments)
https://gerrit.osmocom.org/#/c/7168/4/src/osmo_gsm_tester/bts_nanobts.py
File src/osmo_gsm_tester/bts_nanobts.py:
Line 36: if conf.get('addr', None) is None:
> conf.get('addr') is identical to passing None explicitly
AFAIR if you don't pass a second argument,
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: get IMSI from ofono
..
modem: get IMSI from ofono
There's no need to specify the IMSI manually in resource config
and it's also prone to
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: example: Maintain different resources.conf for RnD and prod
..
example: Maintain different resources.conf for RnD and prod
We still want to maintain
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7275
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifec851c7ac6fca6b294e57dfe86b92f214ae8f42
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7277
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcd0d71fad53274e82f6d87c80042d06283bc5d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: msc_mgcp: fix mgw timeout handling
..
msc_mgcp: fix mgw timeout handling
When the MGW does not respond to an MGCP message then the mgcp FSM
terminates,
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Respond to BSSMAP release
..
MSC_Tests: Respond to BSSMAP release
The testcase TC_mo_crcx_ran_timeout does not respond to the BSSMAP
relase
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7280
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf9ebd2cc5184524ecae735257ed12a0ca70f71
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/7281
use libosmocom to parse cell identifier in bssmap_rx_l3_compl()
Use the new gsm0808_dec_cell_id_list2() API to decode the cell
identifier in the bssap COMPLETE LAYER 3 information message.
Related: OS#2847
Change-Id:
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7273
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b666f23402a6d94af2d903e514770d1fd5157f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: be sure that pending mgcp transactions are canceled
before free
..
mgcp: be sure that pending mgcp transactions are canceled before free
When the
Harald Welte has submitted this change and it was merged.
Change subject: trans_free: safeguard against a still running CC timer on free
..
trans_free: safeguard against a still running CC timer on free
Make sure to deactivate
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7167
to look at the new patch set (#4).
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the interface to be used by child
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7168
to look at the new patch set (#5).
Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/defaults.conf
M
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7166
to look at the new patch set (#4).
pcu.py: Introduce PcuDummy class
It will be used in later commits by BTS without proper PCU control such
as NanoBts.
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7158
to look at the new patch set (#4).
Create Pcu abstract class and make OsmoPcu inherit from it
This base class will be used to describe the required
Patch Set 3:
right, so we have a bunch of +1s ... who's going to +2 then? I think even
though this is not a real fix, we should merge this now to prevent segfaults
upon this error, i.e. for general MSC stability. I'm about to +2 myself, but
giving you guys a chance to comment first.
--
To
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7282
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ff55e48a95cc4c556a97ad2593bad1cc1aa69bd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7281
to look at the new patch set (#3).
use libosmocom to parse cell identifier in bssmap_rx_l3_compl()
Use the new gsm0808_dec_cell_id_list2() API to decode the cell
Review at https://gerrit.osmocom.org/7286
fsm: Update the name as well if the id is updated and accept NULL
If the name stays the same the log messages will still log with the old
id. Since we can now change the id we need to update the name as well.
NULL as id was allowed before so we should
Review at https://gerrit.osmocom.org/7288
fix a cell identifier parsing bug in libosmocore
Global and LAI+LAC cell IDs were being misparsed due to an off-by-one.
This code was incorrectly converted from osmo-bsc, where an additional
offset of one byte was needed to skip the cell identifier
Review at https://gerrit.osmocom.org/7289
use libosmocore to parse cell identifiers in osmo-bsc
This replaces custom cell identifier parsing in the paging code with
calls to the new cell identifier parser implementation in libosmocore
(which was derived from the code that is now being replaced
Patch Set 3:
> I think you're missing the fact that this also fixes
> https://osmocom.org/issues/2980
Is that a reason not to merge this patch?
The scope of issue #2980 seems to be larger than this patch. The issue is
asking for ttcn3 tests, and is asking about potential changes to the VLR
Review at https://gerrit.osmocom.org/7290
MSC_Tests: Support wildcarded endpoints
At the moment the testsuit is unable to detect when the call agent
performs a CRCX request with a wildcarded endpoint.
- Set a default endpoint name in cpars in case the MSC does
a CRCX request with wildcarded
Patch Set 1:
You're right. It's package dependency issue on my side.
I just corrected the dependencies for the libosmoctrl-devel package.
--
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/7287
fix cell identifier generation in ttcn3 paging tests
The cell identifier used by the paging tests is 001-01, i.e. uses a
2-digit MNC. With the introduction of 3-digit MNC support in osmo-bsc,
the paging tests became incompatible with a osmo-bsc config
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7289
to look at the new patch set (#2).
use libosmocore to parse cell identifiers in osmo-bsc
This replaces custom cell identifier parsing in the paging code with
calls to the new cell
Review at https://gerrit.osmocom.org/7291
modem: workaround ofono crash
Since commit bfd0b2310cf09e32cb7d5dbe74ec57606a7d2aab, the IMSI is
retreived from ofono. To get the IMSI, the modme must be powered ON
previously. The imsi() method is called before calling connect() in
order to set up the
Patch Set 5:
Please have a look at this osmo-gsm-tester commit, which moved
osmo-gsm-tester.git example/resource.conf to example/resource.conf.{prod,rnd}.
So you can drop all "sed" commands and do: ln -s resources.conf.prod
example/resources.conf
--
To view, visit
Patch Set 1:
> You're right. It's package dependency issue on my side.
> I just corrected the dependencies for the libosmoctrl-devel
> package.
Please also have a look at the 'libosmoctrl.pc'.
--
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7279
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb84e4b0696fef1326c3f9ebc8427581057db44f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7278/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
Line 1552: msc_subscr_conn_close(trans->conn, GSM_CAUSE_NET_FAIL);
I'm not convinced. There can be any number of transactions in parallel, such
as
Review at https://gerrit.osmocom.org/7283
build: check if libosmogsm is available
Change-Id: I0a3f6efdc25c16edd97f101a3e42b1b9a7223b55
---
M configure.ac
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/83/7283/1
diff --git
Review at https://gerrit.osmocom.org/7284
L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info
Previously, the L1CTL_CRYPTO_REQ message contained only a ciphering
algorithm and actual Kc key to be used. The key length was
calculated manually using the MSGB API.
Let's avoid manual
Review at https://gerrit.osmocom.org/7285
common/l1ctl.c move TCH bit-ordering to the firmware
Previously, TCH frames coming from L1 were reordered to the RTP
format. Moreover, the implementation had a few problems:
- L1CTL is not the best place for such manipulations;
- payloads with
Patch Set 1: Code-Review+1
I presume you have tested this with actual phones?
--
To view, visit https://gerrit.osmocom.org/7285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81ec8ed3c9e72a62b22c1720c299cdc68b733cf1
Gerrit-PatchSet: 1
Patch Set 1:
> I presume you have tested this with actual phones?
Yes, tested during GAPK integration.
Please see the 'fixeria/audio' branch for detais.
--
To view, visit https://gerrit.osmocom.org/7285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 2:
The 9b1d398685e70e3bc9ed2fa1a07209a24e2b31b6 introduced an
unrelated change of 'src/host/layer23/.gitignore'. Probably,
this was accidentally done during some rebase process
in the past...
@Harald, should I correct this in a separate change?
Or is it ok to recover here?
--
To
Patch Set 1:
Ok, no problem. Please see:
https://gerrit.osmocom.org/7284/
https://gerrit.osmocom.org/7285/
As soon as we merge both, I'll update this one.
--
To view, visit https://gerrit.osmocom.org/7263
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7285
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81ec8ed3c9e72a62b22c1720c299cdc68b733cf1
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info
..
L1CTL/L1CTL_CRYPTO_REQ: add key length and channel info
Previously, the L1CTL_CRYPTO_REQ
Harald Welte has submitted this change and it was merged.
Change subject: common/l1ctl.c move TCH bit-ordering to the firmware
..
common/l1ctl.c move TCH bit-ordering to the firmware
Previously, TCH frames coming from L1 were
Patch Set 1:
Hmm, seems this is a dependency of the libosmoctrl:
$ pkg-config --libs libosmoctrl
-L/usr/local/lib -ltalloc -losmoctrl -losmogsm -losmocore
So, I guess libosmoctrl will not build without libosmogsm itself.
--
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe,
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7263
to look at the new patch set (#2).
Merge branch 'fixeria/trx' into master
This change introduces the following:
- trxcon - a similar to the osmocon application, which
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7284
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fab079907c5276322d3ec2b46cab81f10c7ed09
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
[ 29s] /bin/sh /home/abuild/rpmbuild/BUILD/osmo-trx-0.2.0.64/libtool
--tag=CXX --mode=link g++ -lpthread -I/usr/include/libosmocore/
-I/usr/include/libosmocore/ -I/usr/include/libosmocore/ -fmessage-length=0
-grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6673
to look at the new patch set (#2).
msc_mgcp: use more conceise error msg on truncation
When a truncation check (osmo_strlcpy()) fails handle_error()
is called with
Patch Set 2: Code-Review-1
Hmm, just found one small problem...
--
To view, visit https://gerrit.osmocom.org/7263
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83094ca021a0b84c107f7301e10a603e4b342e6e
Gerrit-PatchSet: 2
Patch Set 2: Code-Review-1
I think you're missing the fact that this also fixes
https://osmocom.org/issues/2980
--
To view, visit https://gerrit.osmocom.org/7281
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2: Code-Review+1 Verified+1
> Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7273
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86b666f23402a6d94af2d903e514770d1fd5157f
Gerrit-PatchSet: 2
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/7283/1/configure.ac
File configure.ac:
Line 80: PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.10.0)
Could you please clarify for what do we need libosmogsm?
I don't think it's used anywhere in code at the moment.
--
To
Review at https://gerrit.osmocom.org/7282
mgcp: be sure that pending mgcp transactions are canceled before free
When the FSM reaches ST_HALT it frees itsself and all context
information but it is not ensured that there are still pending
MGW transactions that might hit late and eventually cause
Harald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: use pointer arithmetics for CMD parsing
..
Transceiver.cpp: use pointer arithmetics for CMD parsing
It looks like the author of control
Harald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: prevent out-of-range array access
..
Transceiver.cpp: prevent out-of-range array access
There was no a simple range check for both
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7174
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24a5f70e8e8097f218d7cbdef8cb10df2c35416f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
..
Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
No need to keep this value on stack.
Harald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: fix incorrect format string for SETTSC
..
Transceiver.cpp: fix incorrect format string for SETTSC
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: properly zero-terminate received commands
..
Transceiver.cpp: properly zero-terminate received commands
Previously it was assumed that
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7171
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f413f33156c38a853efc5a8cdc66fbfb0ca6af
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7292
Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.
The IMMEDIATE ASSIGN REJECT message contains a wait indicator which
tells an MS requesting a channel to wait for a specified amount of
time before trying to request a channel again, i.e. the
Review at https://gerrit.osmocom.org/7295
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increasing number of MS. This avoids overload at
startup time in cases where a lot of MS would discover the new
cell and
Review at https://gerrit.osmocom.org/7294
Add stat items for the BTS's channel load average and T3122.
In addition to logging the current values of a BTS's channel load
average and T3122 override, maintain stat items for these values.
This allows for plotting these values over time, for
Review at https://gerrit.osmocom.org/7293
bts chan_load: ignore unusable BTS
For unconnected BTS, the channel load would report a "bogus channel load
sample" every second (on RLL debug). Instead, skip unusable BTS.
This follows up on commit 6cee893a0f2c4e53155a2631aff12a5f615b973d /
Patch Set 1: Code-Review+2
sounds like you'd want a unit test within libosmocore ?
--
To view, visit https://gerrit.osmocom.org/7288
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3e8ace26176e9cbfe2542961d2a95662aa4d97
Patch Set 3:
It's no reason to not merge the patch, but it's customary to
* include all relevant changes in the commitlog [it only states using a new API
and nothing about semantic changes]
* add the related issue as OS#... to the changelog.
--
To view, visit https://gerrit.osmocom.org/7281
Harald Welte has submitted this change and it was merged.
Change subject: bts chan_load: ignore unusable BTS
..
bts chan_load: ignore unusable BTS
For unconnected BTS, the channel load would report a "bogus channel load
Harald Welte has submitted this change and it was merged.
Change subject: msc_mgcp: use more conceise error msg on truncation
..
msc_mgcp: use more conceise error msg on truncation
When a truncation check (osmo_strlcpy())
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6673
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb85c1933a30b2aa491b495119919f45782e2c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7290
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0efeae0f8a6e98deb843e79648f84a262f1d98f8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7170
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7294
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I766bd51f539dd96236b9c81d661e9d31f5027db4
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.
..
Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.
The IMMEDIATE ASSIGN REJECT
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7295
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5c4fd7ea2e10086d9b26deee3a71f9469d1280
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7293
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd50d101244641a6ffdde17e60d7a89719225c65
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7292
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9df0e790ece8108212b2ddf718cf2953f5b9bd4
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: fix cell identifier generation in ttcn3 paging tests
..
fix cell identifier generation in ttcn3 paging tests
The cell identifier used by the paging
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7287
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide5228b403e43de8649b6eda18749ea2a9f592a9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7289
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2002fbbe135287e9ce09caa3f0a85a84529463
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7290
to look at the new patch set (#2).
MSC_Tests: Support wildcarded endpoints
At the moment the testsuite is unable to detect when the call agent
performs a CRCX request with a wildcarded
Patch Set 2:
changed "testsuit" into "testsuite". I've seen this several times during past
weeks now, so it's not an odd typo. Please keep in mind: Suit is a piece of
clothing, a suite is a set of (rooms, musical pieces, tests).
--
To view, visit https://gerrit.osmocom.org/7290
To
Harald Welte has submitted this change and it was merged.
Change subject: mcgp: let the MGW allocate the MGCP endpoint
..
mcgp: let the MGW allocate the MGCP endpoint
osmo-msc still uses endpoints that are allocated locally by
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6319
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee3e446b6689626516f01c521abe3d4603cd3e13
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: MSC_Tests: Support wildcarded endpoints
..
MSC_Tests: Support wildcarded endpoints
At the moment the testsuite is unable to detect when the call agent
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7173
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If69a478121a31aa7df945548cc17271c476d6a6b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7172
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I226ca0771e63228cf5e04ef9766057d4107fdd11
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
I just checked the dependencies of *all* osmocom-related devel-packages a and
also found (and fixed) issues in
libosmocoding-devel
libosmogb-devel
libosmoctrl-devel
--
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings
95 matches
Mail list logo
