Review at https://gerrit.osmocom.org/7603
use osmo_init_logging2() with proper talloc ctx
Completely drop bts_log_init(), call osmo_init_logging2() directly instead: all
callers of bts_log_init() passed NULL as category string, so all it ever did
was call osmo_init_logging(). The bts_log_info
Review at https://gerrit.osmocom.org/7604
use osmo_init_logging2() with proper talloc ctx
There is a duality of initialization: early_init() in bts.cpp wants to init
logging even before static instances get initialized. Make sure that
tall_pcu_ctx is initialized during early_init() as well.
Review at https://gerrit.osmocom.org/7602
use osmo_init_logging2() with proper talloc ctx
Change-Id: I3e2a9aef5242efdf11a64536f79099a6e9cec53f
---
M src/osmo-bsc_mgcp/mgcp_main.c
M src/osmo-mgw/mgw_main.c
M tests/legacy_mgcp/mgcp_test.c
M tests/legacy_mgcp/mgcp_transcoding_test.c
M
Patch Set 4: Code-Review+1
(1 comment)
I'd +2 but let's give others a chance to comment
https://gerrit.osmocom.org/#/c/7601/4/regen-makefile.sh
File regen-makefile.sh:
Line 51: if [ -n "$USE_CCACHE" ]; then
(if I set my env to 'USE_CCACHE=0' then this still evaluates true. slightly
nicer
Patch Set 1:
> Uploaded patch set 2.
I chose to add a separate sed script instead of another shell script.
Either way, the process used here should be easier to understand now.
--
To view, visit https://gerrit.osmocom.org/7601
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7601
to look at the new patch set (#3).
support ccache to speed up ttcn3 test compilation
If ccache exists in PATH, use it to cache compiled C++ object files.
Rebuilding the
Patch Set 1:
I agree on all suggestions, except one:
Posix specifies that sed supports more than one input file:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
Both the GNU sed and OpenBSD sed implementations support multiple input files.
Passing each file to sed
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7601
to look at the new patch set (#2).
support ccache to speed up ttcn3 test compilation
If ccache exists in PATH, use it to cache compiled C++ object files.
Rebuilding the
Harald Welte has submitted this change and it was merged.
Change subject: improve documentation of templates used in GGSN_Tests
..
improve documentation of templates used in GGSN_Tests
Various improvements to the comments
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc21a5ba74e0505457e4874f93501ad7c68b7b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7601
to look at the new patch set (#4).
support ccache to speed up ttcn3 test compilation
If ccache exists in PATH, use it to cache compiled C++ object files.
Rebuilding the
Patch Set 1:
Oh bummer, just noticed that since the -i option isn't specified in Posix,
brining up Posix doesn't actually help my argument much :)
However, both GNU and OpenBSD implement 'sed -i' in the same way when mulitple
files are passed (all input files are modified in the same way). It
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7600/1/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:
Line 85:OSMO_GSUP_USSD_IE = 0x29,
During OsmoMSC code writing, I understood that we probably
also need another IE - OSMO_GSUP_USSD_SID_IE,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7600
to look at the new patch set (#2).
GSUP: add USSD encoding / decoding support
In order to be able to transfer USSD messages via GSUP, this
change introduces the new message types
14 matches
Mail list logo
