date:20180622

Build failed in Jenkins: master-osmo-bts » lc15,master,default,osmocom-master-debian9 #807

2018-06-22 Thread jenkins

See 


--
[...truncated 32.84 KB...]
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking for pkg-config... /usr/bin/pkg-config
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.20... yes
checking for ANSI C header files... (cached) yes
checking execinfo.h usability... yes
checking execinfo.h presence... yes
checking for execinfo.h... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/timerfd.h usability... yes
checking sys/timerfd.h presence... yes
checking for sys/timerfd.h... yes
checking syslog.h usability... yes
checking syslog.h presence... yes
checking for syslog.h... yes
checking ctype.h usability... yes
checking ctype.h presence... yes
checking for ctype.h... yes
checking netinet/tcp.h usability... yes
checking netinet/tcp.h presence... yes
checking for netinet/tcp.h... yes
checking for size_t... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for library containing dlopen... -ldl
checking for library containing dlsym... -ldl
checking for backtrace in -lexecinfo... no
checking for doxygen... /usr/bin/doxygen
checking whether SYS_getrandom is declared... yes
checking if gcc supports -fvisibility=hidden... yes
checking whether struct tm has tm_gmtoff member... yes
checking for TALLOC... yes
checking for PCSC... yes
checking for LIBGNUTLS... yes
checking whether C compiler accepts -mavx2... yes
checking whether C compiler accepts -mssse3... yes
checking whether C compiler accepts -msse4.1... yes
checking whether gcc has __builtin_cpu_supports built-in... yes
CFLAGS="-g -O2 -DBUILDING_LIBOSMOCORE -Wall"
CPPFLAGS=" -DBUILDING_LIBOSMOCORE -Wall"
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating libosmocore.pc
config.status: creating libosmocodec.pc
config.status: creating libosmocoding.pc
config.status: creating libosmovty.pc
config.status: creating libosmogsm.pc
config.status: creating libosmogb.pc
config.status: creating libosmoctrl.pc
config.status: creating libosmosim.pc
config.status: creating include/Makefile
config.status: creating src/Makefile
config.status: creating src/vty/Makefile
config.status: creating src/codec/Makefile
config.status: creating src/coding/Makefile
config.status: creating src/sim/Makefile
config.status: creating src/gsm/Makefile
config.status: creating src/gb/Makefile
config.status: creating src/ctrl/Makefile
config.status: creating src/pseudotalloc/Makefile
config.status: creating tests/Makefile
config.status: creating tests/atlocal
config.status: creating utils/Makefile
config.status: creating Doxyfile.core
config.status: creating Doxyfile.gsm
config.status: creating Doxyfile.vty
config.status: creating Doxyfile.codec
config.status: creating Doxyfile.coding
config.status: creating Doxyfile.gb
config.status: creating Doxyfile.ctrl
config.status: creating Makefile
config.status: creating config.h
config.status: executing tests/atconfig commands
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j 8 install
echo 0.11.0.54-60f31 > .version-t && mv .version-t .version
make  install-recursive
make[1]: Entering directory 
'
Making install in include
make[2]: Entering directory

Change in osmo-msc[master]: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9711 )

Change subject: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions
..


Patch Set 1:

> Is there a counter which shows a number of currently active SS/USSD
 > connections? I.e. active at the moment of querying. That's an
 > important metric.

No. I am not sure that it can be implemented with the rate_ctr API.
It can be implemented using the osmo_counter API, which allows
to increment and also *decrement* a counter, but it looks deprecated,
and it is used only once in the whole OsmoMSC...

Maybe, @Harald can advice here?


--
To view, visit https://gerrit.osmocom.org/9711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23c9475abc9951d82f3342fdc5aaa367836f7741
Gerrit-Change-Number: 9711
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 22:24:41 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions

2018-06-22 Thread Alexander Chemeris

Alexander Chemeris has posted comments on this change. ( 
https://gerrit.osmocom.org/9711 )

Change subject: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions
..


Patch Set 1:

Is there a counter which shows a number of currently active SS/USSD 
connections? I.e. active at the moment of querying. That's an important metric.


--
To view, visit https://gerrit.osmocom.org/9711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23c9475abc9951d82f3342fdc5aaa367836f7741
Gerrit-Change-Number: 9711
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 21:57:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: properly handle MS-initiated release

2018-06-22 Thread Alexander Chemeris

Alexander Chemeris has posted comments on this change. ( 
https://gerrit.osmocom.org/9703 )

Change subject: libmsc/gsm_09_11.c: properly handle MS-initiated release
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9703
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76fc277bf9db614a97824b1541cd5bb75aa3e29d
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 21:58:37 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_09_11.c: properly handle MS-initiated release

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9703 )

Change subject: libmsc/gsm_09_11.c: properly handle MS-initiated release
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/9703
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76fc277bf9db614a97824b1541cd5bb75aa3e29d
Gerrit-Change-Number: 9703
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 21:16:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  313s] make[3]: Nothing to be done for 'install-exec-am'.
[  313s] make[3]: Nothing to be done for 'install-data-am'.
[  313s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  313s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  313s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  313s]dh_install
[  313s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  313s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  313s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  313s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  313s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  313s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  313s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  313s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  313s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  313s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  313s] dh_install: missing files, aborting
[  313s] debian/rules:6: recipe for target 'binary' failed
[  313s] make: *** [binary] Error 2
[  313s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  313s] 
[  313s] cloud112 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:51:40 UTC 
2018.
[  313s] 
[  313s] ### VM INTERACTION START ###
[  316s] [  293.460033] reboot: Power down
[  317s] ### VM INTERACTION END ###
[  317s] 
[  317s] cloud112 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:51:44 UTC 
2018.
[  317s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-msc[master]: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/9711


Change subject: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions
..

libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions

This change introduces some new rate counters for call-independent
SS/USSD connections. As OsmoMSC doesn't handle the messages itself,
and only responsible for dispatching messages between both
A and GSUP interfaces, the following is taken into account:

  - MS-initiated and network-initiated requests to establish
a NC SS/USSD session (transaction) - "nc_ss:m{o|t}_requests";

  - successfully established MS-initiated and network-initiated
SS/USSD sessions (transactions) - "nc_ss:m{o|t}_established".

Change-Id: I23c9475abc9951d82f3342fdc5aaa367836f7741
---
M include/osmocom/msc/gsm_data.h
M src/libmsc/gsm_09_11.c
M src/libmsc/msc_vty.c
3 files changed, 38 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/9711/1

diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h
index 73047ee..3af619d 100644
--- a/include/osmocom/msc/gsm_data.h
+++ b/include/osmocom/msc/gsm_data.h
@@ -200,6 +200,10 @@
MSC_CTR_CALL_ACTIVE,
MSC_CTR_CALL_COMPLETE,
MSC_CTR_CALL_INCOMPLETE,
+   MSC_CTR_NC_SS_MO_REQUESTS,
+   MSC_CTR_NC_SS_MO_ESTABLISHED,
+   MSC_CTR_NC_SS_MT_REQUESTS,
+   MSC_CTR_NC_SS_MT_ESTABLISHED,
 };

 static const struct rate_ctr_desc msc_ctr_description[] = {
@@ -227,6 +231,10 @@
[MSC_CTR_CALL_ACTIVE] = {"call:active", "Count total 
amount of calls that ever reached active state."},
[MSC_CTR_CALL_COMPLETE] =   {"call:complete", "Count total 
amount of calls which got terminated by disconnect req or ind after reaching 
active state."},
[MSC_CTR_CALL_INCOMPLETE] = {"call:incomplete", "Count 
total amount of call which got terminated by any other reason after reaching 
active state."},
+   [MSC_CTR_NC_SS_MO_REQUESTS] =   {"nc_ss:mo_requests", "Received 
MS-initiated call independent SS/USSD requests."},
+   [MSC_CTR_NC_SS_MO_ESTABLISHED] ={"nc_ss:mo_established", 
"Established MS-initiated call independent SS/USSD sessions."},
+   [MSC_CTR_NC_SS_MT_REQUESTS] =   {"nc_ss:mt_requests", "Received 
network-initiated call independent SS/USSD requests."},
+   [MSC_CTR_NC_SS_MT_ESTABLISHED] ={"nc_ss:mt_established", 
"Established network-initiated call independent SS/USSD sessions."},
 };

 static const struct rate_ctr_group_desc msc_ctrg_desc = {
diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c
index e7bdcf5..a04b1f9 100644
--- a/src/libmsc/gsm_09_11.c
+++ b/src/libmsc/gsm_09_11.c
@@ -30,6 +30,7 @@
 #include 

 #include 
+#include 
 #include 
 #include 
 #include 
@@ -73,6 +74,9 @@
/* Reuse existing transaction, or create a new one */
trans = trans_find_by_id(conn, pdisc, tid);
if (!trans) {
+   /* Count MS-initiated attempts to establish a NC SS/USSD 
session */
+   
rate_ctr_inc(>network->msc_ctrs->ctr[MSC_CTR_NC_SS_MO_REQUESTS]);
+
/**
 * According to GSM TS 04.80, section 2.4.2 "Register
 * (mobile station to network direction)", the REGISTER
@@ -184,6 +188,10 @@
else
msc_subscr_conn_communicating(conn);

+   /* Count established MS-initiated NC SS/USSD sessions */
+   if (msg_type == GSM0480_MTYPE_REGISTER)
+   
rate_ctr_inc(>network->msc_ctrs->ctr[MSC_CTR_NC_SS_MO_ESTABLISHED]);
+
return 0;

 error:
@@ -232,6 +240,9 @@
/* Sent to the MS, give ownership of ss_msg */
msc_tx_dtap(transt->conn, ss_msg);
transt->ss.msg = NULL;
+
+   /* Count established network-initiated NC SS/USSD sessions */
+   
rate_ctr_inc(>network->msc_ctrs->ctr[MSC_CTR_NC_SS_MT_ESTABLISHED]);
break;
case GSM_PAGING_EXPIRED:
case GSM_PAGING_BUSY:
@@ -377,6 +388,9 @@
/* Attempt to find DTAP-transaction */
trans = trans_find_by_callref(net, gsup_msg->session_id);
if (!trans) {
+   /* Count network-initiated attempts to establish a NC SS/USSD 
session */
+   rate_ctr_inc(>msc_ctrs->ctr[MSC_CTR_NC_SS_MT_REQUESTS]);
+
/* Attempt to establish a new transaction */
trans = establish_nc_ss_trans(net, vsub, gsup_msg);
if (!trans) {
@@ -459,6 +473,10 @@
if (trans_end)
trans_free(trans);

+   /* Count established network-initiated NC SS/USSD sessions */
+   if (gsup_msg->session_state == OSMO_GSUP_SESSION_STATE_BEGIN)
+   rate_ctr_inc(>msc_ctrs->ctr[MSC_CTR_NC_SS_MT_ESTABLISHED]);
+
vlr_subscr_put(vsub);
return 0;
 }
diff

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  387s] make[3]: Nothing to be done for 'install-data-am'.
[  387s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  387s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  387s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  387s]dh_install
[  387s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  387s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  387s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  387s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  387s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  387s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  387s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  387s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  387s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  387s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  387s] dh_install: missing files, aborting
[  387s] debian/rules:6: recipe for target 'binary' failed
[  387s] make: *** [binary] Error 2
[  387s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  387s] 
[  387s] armbuild15 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:02:26 
UTC 2018.
[  387s] 
[  387s] ### VM INTERACTION START ###
[  390s] [  356.285339] sysrq: SysRq : Power Off
[  390s] [  356.287354] reboot: Power down
[  391s] ### VM INTERACTION END ###
[  391s] 
[  391s] armbuild15 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:02:29 
UTC 2018.
[  391s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/x86_64

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  263s]dh_install
[  263s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in ., 
debian/tmp)
[  263s] 
[  263s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  263s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  263s] 
[  263s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  263s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in ., 
debian/tmp)
[  263s] 
[  263s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  263s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in ., debian/tmp)
[  263s] 
[  263s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  263s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  263s] 
[  263s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  263s] dh_install: missing files, aborting
[  263s] debian/rules:6: recipe for target 'binary' failed
[  263s] make: *** [binary] Error 25
[  263s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess 
returned exit status 2
[  263s] 
[  263s] lamb10 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:10:58 UTC 
2018.
[  263s] 
[  263s] ### VM INTERACTION START ###
[  266s] [  256.095587] reboot: Power down
[  266s] ### VM INTERACTION END ###
[  266s] 
[  266s] lamb10 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:11:02 UTC 
2018.
[  266s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  208s]dh_install
[  208s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in ., 
debian/tmp)
[  208s] 
[  208s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  208s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  208s] 
[  208s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  208s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in ., 
debian/tmp)
[  208s] 
[  208s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  208s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in ., debian/tmp)
[  208s] 
[  208s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  208s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  208s] 
[  208s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  208s] dh_install: missing files, aborting
[  208s] debian/rules:6: recipe for target 'binary' failed
[  208s] make: *** [binary] Error 25
[  208s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  208s] 
[  208s] lamb12 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:10:01 UTC 
2018.
[  208s] 
[  208s] ### VM INTERACTION START ###
[  211s] [  202.091498] reboot: Power down
[  211s] ### VM INTERACTION END ###
[  211s] 
[  211s] lamb12 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:10:05 UTC 
2018.
[  211s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/x86_64

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  150s] make[3]: Nothing to be done for 'install-exec-am'.
[  150s] make[3]: Nothing to be done for 'install-data-am'.
[  150s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  150s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  150s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  150s]dh_install
[  150s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  150s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  150s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  150s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  150s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  150s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  150s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  150s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  150s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  150s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  150s] dh_install: missing files, aborting
[  150s] debian/rules:6: recipe for target 'binary' failed
[  150s] make: *** [binary] Error 2
[  150s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  150s] 
[  150s] build71 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:08:51 UTC 
2018.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  146.417499] reboot: Power down
[  154s] ### VM INTERACTION END ###
[  154s] 
[  154s] build71 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:08:55 UTC 
2018.
[  154s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  197s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  197s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  197s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  197s] make[2]: Entering directory '/usr/src/packages/BUILD'
[  197s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  197s] make[3]: Nothing to be done for 'install-exec-am'.
[  197s] make[3]: Nothing to be done for 'install-data-am'.
[  197s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  197s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  197s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  197s]dh_install
[  198s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  198s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  198s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  198s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  198s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  198s] dh_install: missing files, aborting
[  198s] debian/rules:6: recipe for target 'binary' failed
[  198s] make: *** [binary] Error 2
[  198s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  198s] 
[  198s] lamb17 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:06:13 UTC 
2018.
[  198s] 
[  198s] ### VM INTERACTION START ###
[  201s] [  192.175708] reboot: Power down
[  201s] ### VM INTERACTION END ###
[  201s] 
[  201s] lamb17 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:06:17 UTC 
2018.
[  201s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  192s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  192s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  192s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  192s] make[2]: Entering directory '/usr/src/packages/BUILD'
[  192s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  192s] make[3]: Nothing to be done for 'install-exec-am'.
[  192s] make[3]: Nothing to be done for 'install-data-am'.
[  192s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  192s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  192s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  192s]dh_install
[  192s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  192s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  192s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  192s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  192s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  192s] dh_install: missing files, aborting
[  192s] debian/rules:6: recipe for target 'binary' failed
[  192s] make: *** [binary] Error 2
[  192s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  192s] 
[  192s] lamb17 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:14 UTC 
2018.
[  192s] 
[  192s] ### VM INTERACTION START ###
[  195s] [  187.586609] reboot: Power down
[  195s] ### VM INTERACTION END ###
[  195s] 
[  195s] lamb17 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:17 UTC 
2018.
[  195s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  211s] make[3]: Nothing to be done for 'install-exec-am'.
[  211s] make[3]: Nothing to be done for 'install-data-am'.
[  211s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  211s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  211s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  211s]dh_install
[  211s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  211s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  211s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  211s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  211s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  211s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  211s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  211s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  211s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  211s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  211s] dh_install: missing files, aborting
[  211s] debian/rules:6: recipe for target 'binary' failed
[  211s] make: *** [binary] Error 2
[  211s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  211s] 
[  211s] lamb07 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:10 UTC 
2018.
[  211s] 
[  211s] ### VM INTERACTION START ###
[  214s] [  204.335899] reboot: Power down
[  214s] ### VM INTERACTION END ###
[  214s] 
[  214s] lamb07 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:14 UTC 
2018.
[  214s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-06-22 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  220s] make[3]: Nothing to be done for 'install-exec-am'.
[  220s] make[3]: Nothing to be done for 'install-data-am'.
[  220s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  220s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  220s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  220s]dh_install
[  220s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  220s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  220s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  220s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  220s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  220s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  220s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  220s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  220s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  220s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  220s] dh_install: missing files, aborting
[  220s] debian/rules:6: recipe for target 'binary' failed
[  220s] make: *** [binary] Error 2
[  220s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  220s] 
[  220s] lamb07 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:20 UTC 
2018.
[  220s] 
[  220s] ### VM INTERACTION START ###
[  223s] [  214.046709] reboot: Power down
[  224s] ### VM INTERACTION END ###
[  224s] 
[  224s] lamb07 failed "build osmo-trx_0.4.0.dsc" at Fri Jun 22 20:04:24 UTC 
2018.
[  224s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-bsc[master]: fix / clarify rsl dtap cache

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9668 )

Change subject: fix / clarify rsl dtap cache
..


Patch Set 3:

(3 comments)

as all RSL messages at all time now seem to pass thorugh some of the code, the 
logging ("DHO") will need to be reconsidered/modified.

https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h@123
PS3, Line 123:  struct llist_head dtap_cache;
unrelated to this patch: I think "cache" is a misnomer.  It' s simply a queue.  
A "cache" is something you keep for subsequent lookups, not simply something 
you're queueing.


https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1125
PS3, Line 1125: 23
no #define? 23 seems like a lot, btw.


https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1126
PS3, Line 1126: DHO
why do we log this in DHO, if it's now a generic functionality?



--
To view, visit https://gerrit.osmocom.org/9668
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ffd7aa641c8905292c769400048c96aa0949585
Gerrit-Change-Number: 9668
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 22 Jun 2018 15:20:14 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #162

2018-06-22 Thread jenkins

See 


--
[...truncated 3.74 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style

Change in osmo-bts[master]: sysmo: calib_file.c: Avoid decl of unused vars and funcs with femtobt...

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9709 )

Change subject: sysmo: calib_file.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..

sysmo: calib_file.c: Avoid decl of unused vars and funcs with femtobts_v2.7 
build

Change-Id: I853ff6d3562c5852bff58a07e7c23d49329d9a4f
---
M src/osmo-bts-sysmo/calib_file.c
1 file changed, 19 insertions(+), 19 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/calib_file.c b/src/osmo-bts-sysmo/calib_file.c
index 8cb09d9..2f723dd 100644
--- a/src/osmo-bts-sysmo/calib_file.c
+++ b/src/osmo-bts-sysmo/calib_file.c
@@ -111,6 +111,7 @@
},
 };

+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
 static const unsigned int arrsize_by_band[] = {
[GsmL1_FreqBand_850] = 124,
[GsmL1_FreqBand_900] = 194,
@@ -118,21 +119,6 @@
[GsmL1_FreqBand_1900] = 299
 };

-/* determine next calibration file index based on supported bands */
-static int next_calib_file_idx(uint32_t band_mask, int last_idx)
-{
-   int i;
-
-   for (i = last_idx+1; i < ARRAY_SIZE(calib_files); i++) {
-   int band = band_femto2osmo(calib_files[i].band);
-   if (band < 0)
-   continue;
-   if (band_mask & band)
-   return i;
-   }
-   return -1;
-}
-
 static float read_float(FILE *in)
 {
int rc;
@@ -168,7 +154,6 @@

 extern const uint8_t fixup_macs[95][6];

-
 static void determine_fixup(struct femtol1_hdl *fl1h)
 {
uint8_t macaddr[6];
@@ -212,6 +197,7 @@

return fl1h->fixup_needed == FIXUP_NEEDED;
 }
+#endif /* API 2.4.0 */

 static void calib_fixup_rx(struct femtol1_hdl *fl1h, SuperFemto_Prim_t *prim)
 {
@@ -228,7 +214,6 @@
 {
FILE *in;
char fname[PATH_MAX];
-   int i;

fname[0] = '\0';
snprintf(fname, sizeof(fname)-1, "%s/%s", path, desc->fname);
@@ -242,6 +227,7 @@
}

 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
+   int i;
if (desc->rx) {
SuperFemto_SetRxCalibTblReq_t *rx = >u.setRxCalibTblReq;
memset(rx, 0, sizeof(*rx));
@@ -296,10 +282,9 @@

 static int calib_eeprom_read(const struct calib_file_desc *desc, 
SuperFemto_Prim_t *prim)
 {
+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
eeprom_Error_t eerr;
int i;
-
-#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
if (desc->rx) {
SuperFemto_SetRxCalibTblReq_t *rx = >u.setRxCalibTblReq;
eeprom_RxCal_t rx_cal;
@@ -379,6 +364,21 @@
return 0;
 }

+/* determine next calibration file index based on supported bands */
+static int next_calib_file_idx(uint32_t band_mask, int last_idx)
+{
+   int i;
+
+   for (i = last_idx+1; i < ARRAY_SIZE(calib_files); i++) {
+   int band = band_femto2osmo(calib_files[i].band);
+   if (band < 0)
+   continue;
+   if (band_mask & band)
+   return i;
+   }
+   return -1;
+}
+
 /* iteratively download the calibration data into the L1 */

 static int calib_send_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg,

--
To view, visit https://gerrit.osmocom.org/9709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I853ff6d3562c5852bff58a07e7c23d49329d9a4f
Gerrit-Change-Number: 9709
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-bts[master]: jenkins_*.sh: add --enable-werror to configure flags

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9536 )

Change subject: jenkins_*.sh: add --enable-werror to configure flags
..

jenkins_*.sh: add --enable-werror to configure flags

The flag is enabled for all BTS flavour except for lc15, which still
contain several compilation warnings (fixes submitted to gerrit, but not
merged since no contributor is testing lc15 nowadays).

Change-Id: Ib65056633697dafa63831fc2a480b798df550db6
---
M contrib/jenkins_bts_trx.sh
M contrib/jenkins_lc15.sh
M contrib/jenkins_oct.sh
M contrib/jenkins_oct_and_bts_trx.sh
M contrib/jenkins_sysmobts.sh
5 files changed, 20 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve



diff --git a/contrib/jenkins_bts_trx.sh b/contrib/jenkins_bts_trx.sh
index 3e3d8d3..1b723e6 100755
--- a/contrib/jenkins_bts_trx.sh
+++ b/contrib/jenkins_bts_trx.sh
@@ -14,9 +14,10 @@
 cd "$deps"

 configure_flags="\
+  --enable-sanitize \
+  --enable-werror \
   --with-osmo-pcu=$deps/osmo-pcu/include \
   --enable-trx \
-  --enable-sanitize \
   "

 build_bts "osmo-bts-trx" "$configure_flags"
diff --git a/contrib/jenkins_lc15.sh b/contrib/jenkins_lc15.sh
index 38c1f33..c7d62c9 100755
--- a/contrib/jenkins_lc15.sh
+++ b/contrib/jenkins_lc15.sh
@@ -14,7 +14,11 @@
 cd "$deps"
 osmo-layer1-headers.sh lc15 "$FIRMWARE_VERSION"

-configure_flags="--enable-sanitize --with-litecell15=$deps/layer1-headers/inc/ 
--enable-litecell15"
+configure_flags="\
+  --enable-sanitize \
+  --with-litecell15=$deps/layer1-headers/inc/ \
+  --enable-litecell15 \
+  "

 build_bts "osmo-bts-lc15" "$configure_flags"

diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh
index efbd368..bd57dd1 100755
--- a/contrib/jenkins_oct.sh
+++ b/contrib/jenkins_oct.sh
@@ -14,7 +14,12 @@
 cd "$deps"
 osmo-layer1-headers.sh oct "$FIRMWARE_VERSION"

-configure_flags="--enable-sanitize --with-octsdr-2g=$deps/layer1-headers/ 
--enable-octphy"
+configure_flags="\
+  --enable-sanitize \
+  --enable-werror \
+  --with-octsdr-2g=$deps/layer1-headers/ \
+  --enable-octphy \
+  "

 build_bts "osmo-bts-octphy" "$configure_flags"

diff --git a/contrib/jenkins_oct_and_bts_trx.sh 
b/contrib/jenkins_oct_and_bts_trx.sh
index f68a9d3..049f5f7 100755
--- a/contrib/jenkins_oct_and_bts_trx.sh
+++ b/contrib/jenkins_oct_and_bts_trx.sh
@@ -16,6 +16,7 @@
 osmo-layer1-headers.sh oct "$FIRMWARE_VERSION"

 configure_flags="\
+  --enable-werror \
   --with-osmo-pcu=$deps/osmo-pcu/include \
   --with-octsdr-2g=$deps/layer1-headers/ \
   --enable-octphy \
diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh
index 7488419..d0d05ae 100755
--- a/contrib/jenkins_sysmobts.sh
+++ b/contrib/jenkins_sysmobts.sh
@@ -16,7 +16,12 @@
 mkdir -p "$inst/include/sysmocom/femtobts"
 ln -s $deps/layer1-headers/include/* "$inst/include/sysmocom/femtobts/"

-configure_flags="--enable-sanitize --enable-sysmocom-bts 
--with-sysmobts=$inst/include/"
+configure_flags="\
+  --enable-sanitize \
+  --enable-werror \
+  --enable-sysmocom-bts \
+  --with-sysmobts=$inst/include/ \
+  "

 # This will not work for the femtobts
 if [ $FIRMWARE_VERSION != "femtobts_v2.7" ]; then

--
To view, visit https://gerrit.osmocom.org/9536
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib65056633697dafa63831fc2a480b798df550db6
Gerrit-Change-Number: 9536
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2....

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9708 )

Change subject: sysmo: l1_if.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..

sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2.7 build

Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 9fde513..3adb442 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1259,6 +1259,7 @@
 #endif
 }

+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,2,0)
 /*
  * RevC was the last HW revision without an external
  * attenuator. Check for that.
@@ -1268,13 +1269,13 @@
/* older version doesn't have an attenuator */
return hdl->hw_info.ver_major > 2;
 }
+#endif /* 2.2.0 */

 /* activate or de-activate the entire RF-Frontend */
 int l1if_activate_rf(struct femtol1_hdl *hdl, int on)
 {
struct msgb *msg = sysp_msgb_alloc();
SuperFemto_Prim_t *sysp = msgb_sysprim(msg);
-   struct gsm_bts_trx *trx = hdl->phy_inst->trx;

if (on) {
sysp->id = SuperFemto_PrimId_ActivateRfReq;
@@ -1302,6 +1303,7 @@
sysp->u.activateRfReq.rfRx.iClkCor = get_clk_cal(hdl);
 #endif /* API 2.4.0 */
 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,2,0)
+   struct gsm_bts_trx *trx = hdl->phy_inst->trx;
if (has_external_atten(hdl)) {
LOGP(DL1C, LOGL_INFO, "Using external attenuator.\n");
sysp->u.activateRfReq.rfTrx.u8UseExtAtten = 1;
@@ -1426,7 +1428,6 @@
SuperFemto_Prim_t *sysp = msgb_sysprim(resp);
SuperFemto_SystemInfoCnf_t *sic = >u.systemInfoCnf;
struct femtol1_hdl *fl1h = trx_femtol1_hdl(trx);
-   int rc;

fl1h->hw_info.dsp_version[0] = sic->dspVersion.major;
fl1h->hw_info.dsp_version[1] = sic->dspVersion.minor;
@@ -1469,7 +1470,7 @@

 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
/* load calibration tables (if we know their path) */
-   rc = calib_load(fl1h);
+   int rc = calib_load(fl1h);
if (rc < 0)
LOGP(DL1C, LOGL_ERROR, "Operating without calibration; "
"unable to load tables!\n");

--
To view, visit https://gerrit.osmocom.org/9708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
Gerrit-Change-Number: 9708
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: jenkins_*.sh: add --enable-werror to configure flags

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9536 )

Change subject: jenkins_*.sh: add --enable-werror to configure flags
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9536
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib65056633697dafa63831fc2a480b798df550db6
Gerrit-Change-Number: 9536
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:03:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9706 )

Change subject: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0
..

sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

Fixes following compilation warning:
In file included from l1_if.c:32:0:
l1_if.c: In function ‘l1if_mute_rf’:
/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function 
parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ 
[-Werror=sizeof-array-argument]
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
  ^
l1_if.c:1405:29: note: in expansion of macro ‘ARRAY_SIZE’
  if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {
 ^~
l1_if.c:1388:51: note: declared here
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
   ^~~~
In file included from l1_if.c:32:0:
/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function 
parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ 
[-Werror=sizeof-array-argument]
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
  ^
l1_if.c:1408:19: note: in expansion of macro ‘ARRAY_SIZE’
   for (i = 0; i < ARRAY_SIZE(mute); ++i)
   ^~
l1_if.c:1388:51: note: declared here
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
   ^~~~

Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index f1c6602..7fa82f2 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1402,10 +1402,10 @@
LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");
msgb_free(msg);
/* always acknowledge an un-MUTE (which is a no-op if MUTE is not 
supported */
-   if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {
+   if (!memcmp(mute, unmuted, ARRAY_SIZE(unmuted))) {
bts_update_status(BTS_STATUS_RF_MUTE, mute[0]);
oml_mo_rf_lock_chg(>mo, mute, 1);
-   for (i = 0; i < ARRAY_SIZE(mute); ++i)
+   for (i = 0; i < ARRAY_SIZE(unmuted); ++i)
mute_handle_ts(>ts[i], mute[i]);
return 0;
}

--
To view, visit https://gerrit.osmocom.org/9706
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
Gerrit-Change-Number: 9706
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: sysmo: l1if_mute_rf: Declare vars inside ifdef section

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9707 )

Change subject: sysmo: l1if_mute_rf: Declare vars inside ifdef section
..

sysmo: l1if_mute_rf: Declare vars inside ifdef section

Otherwise sysp variable is unused and compiler triggers a warn.

Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 7fa82f2..9fde513 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1387,8 +1387,6 @@
 /* mute/unmute RF time slots */
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
 {
-   struct msgb *msg = sysp_msgb_alloc();
-   SuperFemto_Prim_t *sysp = msgb_sysprim(msg);

LOGP(DL1C, LOGL_INFO, "Tx RF-MUTE.req (%d, %d, %d, %d, %d, %d, %d, 
%d)\n",
 mute[0], mute[1], mute[2], mute[3],
@@ -1400,7 +1398,6 @@
struct gsm_bts_trx *trx = hdl->phy_inst->trx;
int i;
LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");
-   msgb_free(msg);
/* always acknowledge an un-MUTE (which is a no-op if MUTE is not 
supported */
if (!memcmp(mute, unmuted, ARRAY_SIZE(unmuted))) {
bts_update_status(BTS_STATUS_RF_MUTE, mute[0]);
@@ -1411,6 +1408,8 @@
}
return -ENOTSUP;
 #else
+   struct msgb *msg = sysp_msgb_alloc();
+   SuperFemto_Prim_t *sysp = msgb_sysprim(msg);
sysp->id = SuperFemto_PrimId_MuteRfReq;
memcpy(sysp->u.muteRfReq.u8Mute, mute, 
sizeof(sysp->u.muteRfReq.u8Mute));
/* save for later use */

--
To view, visit https://gerrit.osmocom.org/9707
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
Gerrit-Change-Number: 9707
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2....

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9708 )

Change subject: sysmo: l1_if.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
Gerrit-Change-Number: 9708
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:02:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: calib_file.c: Avoid decl of unused vars and funcs with femtobt...

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9709 )

Change subject: sysmo: calib_file.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I853ff6d3562c5852bff58a07e7c23d49329d9a4f
Gerrit-Change-Number: 9709
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:02:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: l1if_mute_rf: Declare vars inside ifdef section

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9707 )

Change subject: sysmo: l1if_mute_rf: Declare vars inside ifdef section
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9707
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
Gerrit-Change-Number: 9707
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:02:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9706 )

Change subject: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9706
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
Gerrit-Change-Number: 9706
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:02:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ggsn: Bind VTY and CTRL ifaces to assigned ip addr

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9710 )

Change subject: ggsn: Bind VTY and CTRL ifaces to assigned ip addr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26735a21cd53183dfe0a75e5bd24954d583c354f
Gerrit-Change-Number: 9710
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:01:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: octphy: add support for 16x oversampling mode

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9704 )

Change subject: octphy: add support for 16x oversampling mode
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h
File include/osmo-bts/phy_link.h:

https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h@77
PS1, Line 77:   uint32_t over_sample_16x;
> It seems this variable is going to be used as a flag (0 or 1), […]
a bool will also need 32bit. but I agree, it would be better style to indicate 
it's just a flag.



--
To view, visit https://gerrit.osmocom.org/9704
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib78f92bfe03ff20aa0a257763c90844fb7b87cf0
Gerrit-Change-Number: 9704
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:00:40 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bts[master]: octphy: add support for 16x oversampling mode

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9704 )

Change subject: octphy: add support for 16x oversampling mode
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h
File include/osmo-bts/phy_link.h:

https://gerrit.osmocom.org/#/c/9704/1/include/osmo-bts/phy_link.h@77
PS1, Line 77:   uint32_t over_sample_16x;
It seems this variable is going to be used as a flag (0 or 1),
so do we really need 4-bytes to store such big range??

I think 'bool' is more suitable here.



--
To view, visit https://gerrit.osmocom.org/9704
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib78f92bfe03ff20aa0a257763c90844fb7b87cf0
Gerrit-Change-Number: 9704
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 12:58:26 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc: move L3 call-control to separate C file (gsm_04_08_cc.c)

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9705 )

Change subject: libmsc: move L3 call-control to separate C file (gsm_04_08_cc.c)
..


Patch Set 1: Code-Review+1

Great change!

I was always thinking about this separation
while working on GSM 09.11...


--
To view, visit https://gerrit.osmocom.org/9705
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb8dd7a8d9d8b4a28c492f12da3cc3305b695cca
Gerrit-Change-Number: 9705
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 12:51:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2....

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9708 )

Change subject: sysmo: l1_if.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
Gerrit-Change-Number: 9708
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 11:11:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: l1if_mute_rf: Declare vars inside ifdef section

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9707 )

Change subject: sysmo: l1if_mute_rf: Declare vars inside ifdef section
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9707
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
Gerrit-Change-Number: 9707
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 11:10:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

2018-06-22 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9706 )

Change subject: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9706
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
Gerrit-Change-Number: 9706
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 11:08:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ggsn: Bind VTY and CTRL ifaces to assigned ip addr

2018-06-22 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9710


Change subject: ggsn: Bind VTY and CTRL ifaces to assigned ip addr
..

ggsn: Bind VTY and CTRL ifaces to assigned ip addr

Change-Id: I26735a21cd53183dfe0a75e5bd24954d583c354f
---
M src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/10/9710/1

diff --git a/src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl 
b/src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl
index 1692db6..3f2d0e7 100644
--- a/src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl
@@ -34,7 +34,9 @@
 stats interval 5
 !
 line vty
- no login
+ bind ${ggsn.ip_address.addr}
+ctrl
+ bind ${ggsn.ip_address.addr}
 !
 ggsn ggsn0
  gtp state-dir ${ggsn.statedir}

--
To view, visit https://gerrit.osmocom.org/9710
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26735a21cd53183dfe0a75e5bd24954d583c354f
Gerrit-Change-Number: 9710
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-bts[master]: sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2....

2018-06-22 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9708


Change subject: sysmo: l1_if.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..

sysmo: l1_if.c: Avoid decl of unused vars and funcs with femtobts_v2.7 build

Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/9708/1

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 9fde513..3adb442 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1259,6 +1259,7 @@
 #endif
 }

+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,2,0)
 /*
  * RevC was the last HW revision without an external
  * attenuator. Check for that.
@@ -1268,13 +1269,13 @@
/* older version doesn't have an attenuator */
return hdl->hw_info.ver_major > 2;
 }
+#endif /* 2.2.0 */

 /* activate or de-activate the entire RF-Frontend */
 int l1if_activate_rf(struct femtol1_hdl *hdl, int on)
 {
struct msgb *msg = sysp_msgb_alloc();
SuperFemto_Prim_t *sysp = msgb_sysprim(msg);
-   struct gsm_bts_trx *trx = hdl->phy_inst->trx;

if (on) {
sysp->id = SuperFemto_PrimId_ActivateRfReq;
@@ -1302,6 +1303,7 @@
sysp->u.activateRfReq.rfRx.iClkCor = get_clk_cal(hdl);
 #endif /* API 2.4.0 */
 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,2,0)
+   struct gsm_bts_trx *trx = hdl->phy_inst->trx;
if (has_external_atten(hdl)) {
LOGP(DL1C, LOGL_INFO, "Using external attenuator.\n");
sysp->u.activateRfReq.rfTrx.u8UseExtAtten = 1;
@@ -1426,7 +1428,6 @@
SuperFemto_Prim_t *sysp = msgb_sysprim(resp);
SuperFemto_SystemInfoCnf_t *sic = >u.systemInfoCnf;
struct femtol1_hdl *fl1h = trx_femtol1_hdl(trx);
-   int rc;

fl1h->hw_info.dsp_version[0] = sic->dspVersion.major;
fl1h->hw_info.dsp_version[1] = sic->dspVersion.minor;
@@ -1469,7 +1470,7 @@

 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
/* load calibration tables (if we know their path) */
-   rc = calib_load(fl1h);
+   int rc = calib_load(fl1h);
if (rc < 0)
LOGP(DL1C, LOGL_ERROR, "Operating without calibration; "
"unable to load tables!\n");

--
To view, visit https://gerrit.osmocom.org/9708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e6d97114289027fbcff00f77cd42db5277a54ab
Gerrit-Change-Number: 9708
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-bts[master]: sysmo: calib_file.c: Avoid decl of unused vars and funcs with femtobt...

2018-06-22 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9709


Change subject: sysmo: calib_file.c: Avoid decl of unused vars and funcs with 
femtobts_v2.7 build
..

sysmo: calib_file.c: Avoid decl of unused vars and funcs with femtobts_v2.7 
build

Change-Id: I853ff6d3562c5852bff58a07e7c23d49329d9a4f
---
M src/osmo-bts-sysmo/calib_file.c
1 file changed, 19 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/9709/1

diff --git a/src/osmo-bts-sysmo/calib_file.c b/src/osmo-bts-sysmo/calib_file.c
index 8cb09d9..2f723dd 100644
--- a/src/osmo-bts-sysmo/calib_file.c
+++ b/src/osmo-bts-sysmo/calib_file.c
@@ -111,6 +111,7 @@
},
 };

+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
 static const unsigned int arrsize_by_band[] = {
[GsmL1_FreqBand_850] = 124,
[GsmL1_FreqBand_900] = 194,
@@ -118,21 +119,6 @@
[GsmL1_FreqBand_1900] = 299
 };

-/* determine next calibration file index based on supported bands */
-static int next_calib_file_idx(uint32_t band_mask, int last_idx)
-{
-   int i;
-
-   for (i = last_idx+1; i < ARRAY_SIZE(calib_files); i++) {
-   int band = band_femto2osmo(calib_files[i].band);
-   if (band < 0)
-   continue;
-   if (band_mask & band)
-   return i;
-   }
-   return -1;
-}
-
 static float read_float(FILE *in)
 {
int rc;
@@ -168,7 +154,6 @@

 extern const uint8_t fixup_macs[95][6];
 
-
 static void determine_fixup(struct femtol1_hdl *fl1h)
 {
uint8_t macaddr[6];
@@ -212,6 +197,7 @@

return fl1h->fixup_needed == FIXUP_NEEDED;
 }
+#endif /* API 2.4.0 */

 static void calib_fixup_rx(struct femtol1_hdl *fl1h, SuperFemto_Prim_t *prim)
 {
@@ -228,7 +214,6 @@
 {
FILE *in;
char fname[PATH_MAX];
-   int i;

fname[0] = '\0';
snprintf(fname, sizeof(fname)-1, "%s/%s", path, desc->fname);
@@ -242,6 +227,7 @@
}

 #if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
+   int i;
if (desc->rx) {
SuperFemto_SetRxCalibTblReq_t *rx = >u.setRxCalibTblReq;
memset(rx, 0, sizeof(*rx));
@@ -296,10 +282,9 @@

 static int calib_eeprom_read(const struct calib_file_desc *desc, 
SuperFemto_Prim_t *prim)
 {
+#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
eeprom_Error_t eerr;
int i;
-
-#if SUPERFEMTO_API_VERSION >= SUPERFEMTO_API(2,4,0)
if (desc->rx) {
SuperFemto_SetRxCalibTblReq_t *rx = >u.setRxCalibTblReq;
eeprom_RxCal_t rx_cal;
@@ -379,6 +364,21 @@
return 0;
 }

+/* determine next calibration file index based on supported bands */
+static int next_calib_file_idx(uint32_t band_mask, int last_idx)
+{
+   int i;
+
+   for (i = last_idx+1; i < ARRAY_SIZE(calib_files); i++) {
+   int band = band_femto2osmo(calib_files[i].band);
+   if (band < 0)
+   continue;
+   if (band_mask & band)
+   return i;
+   }
+   return -1;
+}
+
 /* iteratively download the calibration data into the L1 */

 static int calib_send_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg,

--
To view, visit https://gerrit.osmocom.org/9709
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I853ff6d3562c5852bff58a07e7c23d49329d9a4f
Gerrit-Change-Number: 9709
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-bts[master]: sysmo: l1if_mute_rf: Declare vars inside ifdef section

2018-06-22 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9707


Change subject: sysmo: l1if_mute_rf: Declare vars inside ifdef section
..

sysmo: l1if_mute_rf: Declare vars inside ifdef section

Otherwise sysp variable is unused and compiler triggers a warn.

Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/9707/1

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 7fa82f2..9fde513 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1387,8 +1387,6 @@
 /* mute/unmute RF time slots */
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
 {
-   struct msgb *msg = sysp_msgb_alloc();
-   SuperFemto_Prim_t *sysp = msgb_sysprim(msg);

LOGP(DL1C, LOGL_INFO, "Tx RF-MUTE.req (%d, %d, %d, %d, %d, %d, %d, 
%d)\n",
 mute[0], mute[1], mute[2], mute[3],
@@ -1400,7 +1398,6 @@
struct gsm_bts_trx *trx = hdl->phy_inst->trx;
int i;
LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");
-   msgb_free(msg);
/* always acknowledge an un-MUTE (which is a no-op if MUTE is not 
supported */
if (!memcmp(mute, unmuted, ARRAY_SIZE(unmuted))) {
bts_update_status(BTS_STATUS_RF_MUTE, mute[0]);
@@ -1411,6 +1408,8 @@
}
return -ENOTSUP;
 #else
+   struct msgb *msg = sysp_msgb_alloc();
+   SuperFemto_Prim_t *sysp = msgb_sysprim(msg);
sysp->id = SuperFemto_PrimId_MuteRfReq;
memcpy(sysp->u.muteRfReq.u8Mute, mute, 
sizeof(sysp->u.muteRfReq.u8Mute));
/* save for later use */

--
To view, visit https://gerrit.osmocom.org/9707
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3a3529442a36bb885ef634b8b49ac801bd263da
Gerrit-Change-Number: 9707
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-bts[master]: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

2018-06-22 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9706


Change subject: sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0
..

sysmo: Fix memcmp in RF-MUTE.req for superfemto < 3.6.0

Fixes following compilation warning:
In file included from l1_if.c:32:0:
l1_if.c: In function ‘l1if_mute_rf’:
/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function 
parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ 
[-Werror=sizeof-array-argument]
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
  ^
l1_if.c:1405:29: note: in expansion of macro ‘ARRAY_SIZE’
  if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {
 ^~
l1_if.c:1388:51: note: declared here
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
   ^~~~
In file included from l1_if.c:32:0:
/include/osmocom/core/utils.h:13:30: error: ‘sizeof’ on array function 
parameter ‘mute’ will return size of ‘uint8_t * {aka unsigned char *}’ 
[-Werror=sizeof-array-argument]
 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
  ^
l1_if.c:1408:19: note: in expansion of macro ‘ARRAY_SIZE’
   for (i = 0; i < ARRAY_SIZE(mute); ++i)
   ^~
l1_if.c:1388:51: note: declared here
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
   ^~~~

Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/9706/1

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index f1c6602..7fa82f2 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1402,10 +1402,10 @@
LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");
msgb_free(msg);
/* always acknowledge an un-MUTE (which is a no-op if MUTE is not 
supported */
-   if (!memcmp(mute, unmuted, ARRAY_SIZE(mute))) {
+   if (!memcmp(mute, unmuted, ARRAY_SIZE(unmuted))) {
bts_update_status(BTS_STATUS_RF_MUTE, mute[0]);
oml_mo_rf_lock_chg(>mo, mute, 1);
-   for (i = 0; i < ARRAY_SIZE(mute); ++i)
+   for (i = 0; i < ARRAY_SIZE(unmuted); ++i)
mute_handle_ts(>ts[i], mute[i]);
return 0;
}

--
To view, visit https://gerrit.osmocom.org/9706
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id040aeb35549ddb75072942be0093064a89092a6
Gerrit-Change-Number: 9706
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-bsc[master]: add gsm_timers, for Tnnn definitions usable by FSMs

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9670 )

Change subject: add gsm_timers, for Tnnn definitions usable by FSMs
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9670
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If212fcd042051b6fa53484254223614c5b93a9c6
Gerrit-Change-Number: 9670
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Fri, 22 Jun 2018 08:27:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: move RSL and RR related functions to abis_rsl.[hc]

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9669 )

Change subject: move RSL and RR related functions to abis_rsl.[hc]
..


Patch Set 3:

I'm sorry, but I really don't think its a good idea to mix two completely 
different protocol layers in one file without a really good explanation. RSL is 
a protocol of the Avis interface, and RR is a L3 sub-layer used also on Um all 
the way into the phone.


--
To view, visit https://gerrit.osmocom.org/9669
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8ee334145bf7bc3a601d395ea7ab9b2009b61c7
Gerrit-Change-Number: 9669
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Fri, 22 Jun 2018 08:15:31 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9666 )

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:24:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: sysmo: vty: Add missing include for lchan_deactivate

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9694 )

Change subject: sysmo: vty: Add missing include for lchan_deactivate
..

sysmo: vty: Add missing include for lchan_deactivate

Fixes following compilation warning:
osmo-bts/src/osmo-bts-sysmo/sysmobts_vty.c:349:3: warning: implicit declaration 
of function ‘lchan_deactivate’

Change-Id: I1dba0b08fdb2af199f009842c9abf32e25f74be1
---
M src/osmo-bts-sysmo/sysmobts_vty.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c 
b/src/osmo-bts-sysmo/sysmobts_vty.c
index 039236f..b105bf4 100644
--- a/src/osmo-bts-sysmo/sysmobts_vty.c
+++ b/src/osmo-bts-sysmo/sysmobts_vty.c
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 

 #include "femtobts.h"
 #include "l1_if.h"

--
To view, visit https://gerrit.osmocom.org/9694
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dba0b08fdb2af199f009842c9abf32e25f74be1
Gerrit-Change-Number: 9694
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: l1_if.c: Move decl of vars used in conditional macro

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9693 )

Change subject: l1_if.c: Move decl of vars used in conditional macro
..

l1_if.c: Move decl of vars used in conditional macro

Nowadays, with latest versions of superfemto, those variables are
unused.

Change-Id: Iec6c28840745e1bd99406b777ea5db66ca1d6fd9
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 57e2d5c..f1c6602 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1387,11 +1387,8 @@
 /* mute/unmute RF time slots */
 int l1if_mute_rf(struct femtol1_hdl *hdl, uint8_t mute[8], l1if_compl_cb *cb)
 {
-   const uint8_t unmuted[8] = { 0,0,0,0,0,0,0,0 };
struct msgb *msg = sysp_msgb_alloc();
SuperFemto_Prim_t *sysp = msgb_sysprim(msg);
-   struct gsm_bts_trx *trx = hdl->phy_inst->trx;
-   int i;

LOGP(DL1C, LOGL_INFO, "Tx RF-MUTE.req (%d, %d, %d, %d, %d, %d, %d, 
%d)\n",
 mute[0], mute[1], mute[2], mute[3],
@@ -1399,6 +1396,9 @@
);

 #if SUPERFEMTO_API_VERSION < SUPERFEMTO_API(3,6,0)
+   const uint8_t unmuted[8] = { 0,0,0,0,0,0,0,0 };
+   struct gsm_bts_trx *trx = hdl->phy_inst->trx;
+   int i;
LOGP(DL1C, LOGL_ERROR, "RF-MUTE.req not supported by SuperFemto\n");
msgb_free(msg);
/* always acknowledge an un-MUTE (which is a no-op if MUTE is not 
supported */

--
To view, visit https://gerrit.osmocom.org/9693
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec6c28840745e1bd99406b777ea5db66ca1d6fd9
Gerrit-Change-Number: 9693
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-bts[master]: sysmo: vty: Add missing include for lchan_deactivate

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9694 )

Change subject: sysmo: vty: Add missing include for lchan_deactivate
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9694
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dba0b08fdb2af199f009842c9abf32e25f74be1
Gerrit-Change-Number: 9694
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:22:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bts[master]: l1_if.c: Move decl of vars used in conditional macro

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9693 )

Change subject: l1_if.c: Move decl of vars used in conditional macro
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9693
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec6c28840745e1bd99406b777ea5db66ca1d6fd9
Gerrit-Change-Number: 9693
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:22:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: Drop unused common_vty.c

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9701 )

Change subject: Drop unused common_vty.c
..

Drop unused common_vty.c

Change-Id: I19f1ece5f2f62d1f8f40a9b9d0c6c41ad05e5c76
---
M debian/copyright
M src/libcommon/Makefile.am
D src/libcommon/common_vty.c
3 files changed, 0 insertions(+), 143 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/debian/copyright b/debian/copyright
index 8094f2a..65f3ba7 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -123,7 +123,6 @@
src/gprs/sgsn_libgtp.c
src/gprs/sgsn_main.c
src/gprs/sgsn_vty.c
-   src/libcommon/common_vty.c
src/libcommon/debug.c
src/libcommon/gsm_data.c
src/libcommon/gsm_data_shared.c
diff --git a/src/libcommon/Makefile.am b/src/libcommon/Makefile.am
index 737265b..69fb37d 100644
--- a/src/libcommon/Makefile.am
+++ b/src/libcommon/Makefile.am
@@ -18,7 +18,6 @@
$(NULL)

 libcommon_a_SOURCES = \
-   common_vty.c \
debug.c \
gsm_data.c \
gsm_data_shared.c \
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
deleted file mode 100644
index 6534105..000
--- a/src/libcommon/common_vty.c
+++ /dev/null
@@ -1,141 +0,0 @@
-/* OpenBSC VTY common helpers */
-/* (C) 2009-2010 by Harald Welte 
- * (C) 2009-2010 by Holger Hans Peter Freyther
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see .
- *
- */
-
-#include 
-#include 
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-
-int bsc_vty_go_parent(struct vty *vty)
-{
-   switch (vty->node) {
-   case GSMNET_NODE:
-   vty->node = CONFIG_NODE;
-   vty->index = NULL;
-   break;
-   case BTS_NODE:
-   vty->node = GSMNET_NODE;
-   {
-   /* set vty->index correctly ! */
-   struct gsm_bts *bts = vty->index;
-   vty->index = bts->network;
-   vty->index_sub = NULL;
-   }
-   break;
-   case TRX_NODE:
-   vty->node = BTS_NODE;
-   {
-   /* set vty->index correctly ! */
-   struct gsm_bts_trx *trx = vty->index;
-   vty->index = trx->bts;
-   vty->index_sub = >bts->description;
-   }
-   break;
-   case TS_NODE:
-   vty->node = TRX_NODE;
-   {
-   /* set vty->index correctly ! */
-   struct gsm_bts_trx_ts *ts = vty->index;
-   vty->index = ts->trx;
-   vty->index_sub = >trx->description;
-   }
-   break;
-   case OML_NODE:
-   case OM2K_NODE:
-   vty->node = ENABLE_NODE;
-   /* NOTE: this only works because it's not part of the config
-* tree, where outer commands are searched via vty_go_parent()
-* and only (!) executed when a matching one is found.
-*/
-   talloc_free(vty->index);
-   vty->index = NULL;
-   break;
-   case OM2K_CON_GROUP_NODE:
-   vty->node = BTS_NODE;
-   {
-   struct con_group *cg = vty->index;
-   struct gsm_bts *bts = cg->bts;
-   vty->index = bts;
-   vty->index_sub = >description;
-   }
-   break;
-   case NAT_BSC_NODE:
-   vty->node = NAT_NODE;
-   {
-   struct bsc_config *bsc_config = vty->index;
-   vty->index = bsc_config->nat;
-   }
-   break;
-   case PGROUP_NODE:
-   vty->node = NAT_NODE;
-   vty->index = NULL;
-   break;
-   case GBPROXY_NODE:
-   case SGSN_NODE:
-   case NAT_NODE:
-   case BSC_NODE:
-   case MSC_NODE:
-   case MNCC_INT_NODE:
-   case NITB_NODE:
-

Change in osmo-sgsn[master]: Drop all references of unused MGCP

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9700 )

Change subject: Drop all references of unused MGCP
..

Drop all references of unused MGCP

Change-Id: I1c023d773bf196d41b4251ca7011a82969acb613
---
M contrib/jenkins.sh
M include/osmocom/sgsn/debug.h
M src/gprs/gb_proxy_vty.c
M src/libcommon/common_vty.c
M src/libcommon/debug.c
5 files changed, 3 insertions(+), 15 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 931d14c..d873ee9 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -49,12 +49,12 @@

 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize $enable_werror $MGCP $IU --enable-external-tests
+./configure --enable-sanitize $enable_werror $IU --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $MGCP $IU --enable-external-tests" 
\
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $IU --enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh

diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index eed2921..4d0fc69 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -19,7 +19,6 @@
DMEAS,
DSCCP,
DMSC,
-   DMGCP,
DHO,
DDB,
DREF,
diff --git a/src/gprs/gb_proxy_vty.c b/src/gprs/gb_proxy_vty.c
index 423c582..d7d35fe 100644
--- a/src/gprs/gb_proxy_vty.c
+++ b/src/gprs/gb_proxy_vty.c
@@ -43,7 +43,7 @@
 static struct gbproxy_config *g_cfg = NULL;

 /*
- * vty code for mgcp below
+ * vty code for gbproxy below
  */
 static struct cmd_node gbproxy_node = {
GBPROXY_NODE,
@@ -855,4 +855,3 @@

return 0;
 }
-
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
index 7b80bcb..6534105 100644
--- a/src/libcommon/common_vty.c
+++ b/src/libcommon/common_vty.c
@@ -99,11 +99,6 @@
vty->node = NAT_NODE;
vty->index = NULL;
break;
-   case TRUNK_NODE:
-   vty->node = MGCP_NODE;
-   vty->index = NULL;
-   break;
-   case MGCP_NODE:
case GBPROXY_NODE:
case SGSN_NODE:
case NAT_NODE:
diff --git a/src/libcommon/debug.c b/src/libcommon/debug.c
index 06653a9..27d7575 100644
--- a/src/libcommon/debug.c
+++ b/src/libcommon/debug.c
@@ -99,11 +99,6 @@
.description = "Mobile Switching Center",
.enabled = 1, .loglevel = LOGL_NOTICE,
},
-   [DMGCP] = {
-   .name = "DMGCP",
-   .description = "Media Gateway Control Protocol",
-   .enabled = 1, .loglevel = LOGL_NOTICE,
-   },
[DHO] = {
.name = "DHO",
.description = "Hand-Over",

--
To view, visit https://gerrit.osmocom.org/9700
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c023d773bf196d41b4251ca7011a82969acb613
Gerrit-Change-Number: 9700
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-sgsn[master]: jenkins.sh: Remove non-existent configure options

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9698 )

Change subject: jenkins.sh: Remove non-existent configure options
..

jenkins.sh: Remove non-existent configure options

Change-Id: I331a187ae19125afa076e0a3d629ba7160d4b416
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index 7b8cba3..e60e8a5 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -54,7 +54,7 @@
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="$enable_werror --enable-osmo-bsc --enable-nat 
$SMPP $MGCP $IU --enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $SMPP $MGCP $IU 
--enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh


--
To view, visit https://gerrit.osmocom.org/9698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I331a187ae19125afa076e0a3d629ba7160d4b416
Gerrit-Change-Number: 9698
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-sgsn[master]: Drop all references of unused SMPP

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9699 )

Change subject: Drop all references of unused SMPP
..

Drop all references of unused SMPP

Change-Id: Iffae03fd855e6cbd99e71b9ba0d4157cb7791db2
---
M contrib/jenkins.sh
M include/osmocom/sgsn/debug.h
M src/libcommon/common_vty.c
M src/libcommon/debug.c
4 files changed, 2 insertions(+), 13 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e60e8a5..931d14c 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -49,12 +49,12 @@

 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize $enable_werror $SMPP $MGCP $IU 
--enable-external-tests
+./configure --enable-sanitize $enable_werror $MGCP $IU --enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $SMPP $MGCP $IU 
--enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror $MGCP $IU --enable-external-tests" 
\
   $MAKE distcheck \
   || cat-testlogs.sh

diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h
index 65e197d..eed2921 100644
--- a/include/osmocom/sgsn/debug.h
+++ b/include/osmocom/sgsn/debug.h
@@ -31,7 +31,6 @@
DSLHC,
DNAT,
DCTRL,
-   DSMPP,
DFILTER,
DGTPHUB,
DRANAP,
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
index e960550..7b80bcb 100644
--- a/src/libcommon/common_vty.c
+++ b/src/libcommon/common_vty.c
@@ -103,11 +103,6 @@
vty->node = MGCP_NODE;
vty->index = NULL;
break;
-   case SMPP_ESME_NODE:
-   vty->node = SMPP_NODE;
-   vty->index = NULL;
-   break;
-   case SMPP_NODE:
case MGCP_NODE:
case GBPROXY_NODE:
case SGSN_NODE:
diff --git a/src/libcommon/debug.c b/src/libcommon/debug.c
index 6076409..06653a9 100644
--- a/src/libcommon/debug.c
+++ b/src/libcommon/debug.c
@@ -154,11 +154,6 @@
.description = "Control interface",
.enabled = 1, .loglevel = LOGL_NOTICE,
},
-   [DSMPP] = {
-   .name = "DSMPP",
-   .description = "SMPP interface for external SMS apps",
-   .enabled = 1, .loglevel = LOGL_DEBUG,
-   },
[DFILTER] = {
.name = "DFILTER",
.description = "BSC/NAT IMSI based filtering",

--
To view, visit https://gerrit.osmocom.org/9699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffae03fd855e6cbd99e71b9ba0d4157cb7791db2
Gerrit-Change-Number: 9699
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-sgsn[master]: jenkins.sh: Remove non-existent configure options

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9698 )

Change subject: jenkins.sh: Remove non-existent configure options
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9698
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I331a187ae19125afa076e0a3d629ba7160d4b416
Gerrit-Change-Number: 9698
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:21:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: jenkins.sh: Use --enable-werror only when iu support is disabled

2018-06-22 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9697 )

Change subject: jenkins.sh: Use --enable-werror only when iu support is disabled
..

jenkins.sh: Use --enable-werror only when iu support is disabled

The flag cannot be enabled in all cases because current osmo-iuh header
contain compilation warnings which are then propagated to this project
when building against them.

Change-Id: Ia4285a88af6d4adfba08c055c6734f9d82c1a5a4
---
M contrib/jenkins.sh
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index a32be1e..7b8cba3 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -29,11 +29,14 @@
 osmo-build-dep.sh libosmo-netif
 osmo-build-dep.sh osmo-ggsn

+enable_werror=""
 if [ "x$IU" = "x--enable-iu" ]; then
osmo-build-dep.sh libosmo-sccp
osmo-build-dep.sh libasn1c
#osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in 
osmo-iuh
osmo-build-dep.sh osmo-iuh
+else
+   enable_werror="--enable-werror"
 fi

 set +x
@@ -46,12 +49,12 @@

 cd "$base"
 autoreconf --install --force
-./configure --enable-sanitize $SMPP $MGCP $IU --enable-external-tests
+./configure --enable-sanitize $enable_werror $SMPP $MGCP $IU 
--enable-external-tests
 $MAKE $PARALLEL_MAKE
 LD_LIBRARY_PATH="$inst/lib" $MAKE check \
   || cat-testlogs.sh
 LD_LIBRARY_PATH="$inst/lib" \
-  DISTCHECK_CONFIGURE_FLAGS="--enable-osmo-bsc --enable-nat $SMPP $MGCP $IU 
--enable-external-tests" \
+  DISTCHECK_CONFIGURE_FLAGS="$enable_werror --enable-osmo-bsc --enable-nat 
$SMPP $MGCP $IU --enable-external-tests" \
   $MAKE distcheck \
   || cat-testlogs.sh


--
To view, visit https://gerrit.osmocom.org/9697
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4285a88af6d4adfba08c055c6734f9d82c1a5a4
Gerrit-Change-Number: 9697
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy

Change in osmo-sgsn[master]: jenkins.sh: Use --enable-werror only when iu support is disabled

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9697 )

Change subject: jenkins.sh: Use --enable-werror only when iu support is disabled
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9697
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4285a88af6d4adfba08c055c6734f9d82c1a5a4
Gerrit-Change-Number: 9697
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:21:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: Drop all references of unused MGCP

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9700 )

Change subject: Drop all references of unused MGCP
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9700
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c023d773bf196d41b4251ca7011a82969acb613
Gerrit-Change-Number: 9700
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:20:25 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: Drop all references of unused SMPP

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9699 )

Change subject: Drop all references of unused SMPP
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9699
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffae03fd855e6cbd99e71b9ba0d4157cb7791db2
Gerrit-Change-Number: 9699
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:20:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: Drop unused common_vty.c

2018-06-22 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9701 )

Change subject: Drop unused common_vty.c
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9701
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19f1ece5f2f62d1f8f40a9b9d0c6c41ad05e5c76
Gerrit-Change-Number: 9701
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Fri, 22 Jun 2018 07:19:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

56 matches

Mail list logo