date:20180813

Jenkins build is back to normal : master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #4917

2018-08-13 Thread jenkins

See

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #4916

2018-08-13 Thread jenkins

See 


--
[...truncated 787.53 KB...]
  ^
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:23: warning: 
its scope is only this definition or declaration, which is probably not what 
you want
  A_SEQUENCE_OF(struct Member {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:2: note: in 
expansion of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct Member {
  ^
In file included from 
/build/deps/install/stow/libasn1c/include/asn1c/asn_SEQUENCE_OF.h:8:0,
 from 
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:14,
 from RUA_CriticalityDiagnostics-IE-List.c:7:
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:23: warning: 
'struct Member' declared inside parameter list
  A_SEQUENCE_OF(struct Member {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:2: note: in 
expansion of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct Member {
  ^
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:23: warning: 
its scope is only this definition or declaration, which is probably not what 
you want
  A_SEQUENCE_OF(struct Member {
   ^
/build/deps/install/stow/libasn1c/include/asn1c/asn_SET_OF.h:17:16: note: in 
definition of macro 'A_SET_OF'
   void (*free)(type *);   \
^
../../include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h:28:2: note: in 
expansion of macro 'A_SEQUENCE_OF'
  A_SEQUENCE_OF(struct Member {
  ^
  CC   RUA_InitiatingMessage.o
  CC   RUA_SuccessfulOutcome.o
  CC   RUA_UnsuccessfulOutcome.o
  CC   RUA_Connect.o
  CC   RUA_DirectTransfer.o
  CC   RUA_Disconnect.o
  CC   RUA_ConnectionlessTransfer.o
  CC   RUA_ErrorIndication.o
  CC   RUA_PrivateMessage.o
  CC   RUA_IE.o
  AR   libosmo-asn1-rua.a
make[5]: Entering directory '/build/deps/osmo-iuh/src/rua'
make[5]: Nothing to be done for 'install-exec-am'.
make[5]: Nothing to be done for 'install-data-am'.
make[5]: Leaving directory '/build/deps/osmo-iuh/src/rua'
make[4]: Leaving directory '/build/deps/osmo-iuh/src/rua'
Making install in ranap
make[4]: Entering directory '/build/deps/osmo-iuh/src/ranap'
  CC   RANAP_Presence.lo
  CC   RANAP_Criticality.lo
  CC   RANAP_PrivateIE-ID.lo
  CC   RANAP_ProcedureCode.lo
  CC   RANAP_ProtocolExtensionID.lo
  CC   RANAP_ProtocolIE-ID.lo
  CC   RANAP_TriggeringMessage.lo
  CC   RANAP_IE-Extensions.lo
  CC   RANAP_AccuracyFulfilmentIndicator.lo
  CC   RANAP_AllocationOrRetentionPriority.lo
  CC   RANAP_Alt-RAB-Parameters.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedGuaranteedBitrateInf.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedGuaranteedBitrateList.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedGuaranteedBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-GuaranteedBitrateType.lo
  CC   RANAP_Alt-RAB-Parameter-GuaranteedBitrateInf.lo
  CC   RANAP_Alt-RAB-Parameter-GuaranteedBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-GuaranteedBitrateList.lo
  CC   RANAP_Alt-RAB-Parameter-SupportedGuaranteedBitrateInf.lo
  CC   RANAP_Alt-RAB-Parameter-SupportedGuaranteedBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedMaxBitrateInf.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedMaxBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-ExtendedMaxBitrateList.lo
  CC   RANAP_Alt-RAB-Parameter-MaxBitrateInf.lo
  CC   RANAP_Alt-RAB-Parameter-MaxBitrateType.lo
  CC   RANAP_Alt-RAB-Parameter-MaxBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-MaxBitrateList.lo
  CC   RANAP_AlternativeRABConfigurationRequest.lo
  CC   RANAP_Alt-RAB-Parameter-SupportedMaxBitrates.lo
  CC   RANAP_Alt-RAB-Parameter-SupportedMaxBitrateInf.lo
  CC   RANAP_APN.lo
  CC   RANAP_AreaIdentity.lo
  CC   RANAP_Ass-RAB-Parameters.lo
  CC   RANAP_Ass-RAB-Parameter-ExtendedGuaranteedBitrateList.lo
  CC   RANAP_Ass-RAB-Parameter-ExtendedMaxBitrateList.lo
  CC   RANAP_Ass-RAB-Parameter-GuaranteedBitrateList.lo
In file included from 
/build/deps/install/stow/libasn1c/include/asn1c/asn_SEQUENCE_OF.h:8:0,
 from ../../include/osmocom/ranap/RANAP_IE-Extensions.h:15,
 from ../../include/osmocom/ranap/RANAP_SAI.h:17,
 from ../../include/osmocom/ranap/RANAP_AreaIdentity.h:14,
 from RANAP_AreaIdentity.c:7:
../../include/osmocom/ranap/RANAP_GA-Polygon.h:26:23: warning: 'struct Member'

Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10438 )

Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 10:09:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: doc: update mgw settings in example config file

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10239 )

Change subject: doc: update mgw settings in example config file
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1c5097d98ec2ab97d51f99b1105db3de85c75f
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Mon, 13 Aug 2018 10:10:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: doc: update mgw settings in example config file

2018-08-13 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10239 )

Change subject: doc: update mgw settings in example config file
..

doc: update mgw settings in example config file

The example config file lacks a default port setting for the local
mgcp client port. Lets update that.

Change-Id: I6b1c5097d98ec2ab97d51f99b1105db3de85c75f
Related: OS#2874
---
M doc/examples/osmo-bsc/osmo-bsc.cfg
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg 
b/doc/examples/osmo-bsc/osmo-bsc.cfg
index a5ff1ea..a1bc7e3 100644
--- a/doc/examples/osmo-bsc/osmo-bsc.cfg
+++ b/doc/examples/osmo-bsc/osmo-bsc.cfg
@@ -93,6 +93,7 @@
  amr-config 4_75k forbidden
  mgw remote-ip 127.0.0.1
  mgw remote-port 2427
+ mgw local-port 2727
  mgw endpoint-range 1 31
 bsc
  mid-call-timeout 0

--
To view, visit https://gerrit.osmocom.org/10239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b1c5097d98ec2ab97d51f99b1105db3de85c75f
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter

Change in osmo-bsc[master]: lcls: do not LCLS call legs with different codecs

2018-08-13 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9940 )

Change subject: lcls: do not LCLS call legs with different codecs
..

lcls: do not LCLS call legs with different codecs

It is theoretically possible to LCLS two legs that use different
codecs. However, this requires transcoding capabilities on the
local MGW. If the local MGW lacks transcoding features such a
local circuit should be avoided. Enabeling LCLS under such
coditions should be optional (VTY)

- Add check to avoid LCLS on different codec/rate
- Add VTY-Option to optionally override the check
  (MGW is able to transcode)

Change-Id: I157549129a40c64364dc126f67195759e5f1d60f
Related: OS#1602
---
M include/osmocom/bsc/bsc_msc_data.h
M src/osmo-bsc/osmo_bsc_lcls.c
M src/osmo-bsc/osmo_bsc_vty.c
3 files changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/bsc_msc_data.h 
b/include/osmocom/bsc/bsc_msc_data.h
index 79d2eca..7ec3442 100644
--- a/include/osmocom/bsc/bsc_msc_data.h
+++ b/include/osmocom/bsc/bsc_msc_data.h
@@ -87,6 +87,7 @@
struct gsm_audio_support **audio_support;
int audio_length;
enum bsc_lcls_mode lcls_mode;
+   bool lcls_codec_mismatch_allow;

/* ussd welcome text */
char *ussd_welcome_txt;
diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index 4639c4e..6aeccb3 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -274,6 +274,18 @@
return false;
}

+   if (conn->user_plane.full_rate != conn->lcls.other->user_plane.full_rate
+   && conn->sccp.msc->lcls_codec_mismatch_allow == false) {
+   LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismiatch 
(channel rate)\n");
+   return false;
+   }
+
+   if (conn->user_plane.chan_mode != conn->lcls.other->user_plane.chan_mode
+   && conn->sccp.msc->lcls_codec_mismatch_allow == false) {
+   LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismiatch 
(channel mode)\n");
+   return false;
+   }
+
return true;
 }

diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c
index f6f1b8a..efa12e0 100644
--- a/src/osmo-bsc/osmo_bsc_vty.c
+++ b/src/osmo-bsc/osmo_bsc_vty.c
@@ -184,6 +184,11 @@
vty_out(vty, " lcls-mode %s%s", get_value_string(bsc_lcls_mode_names, 
msc->lcls_mode),
VTY_NEWLINE);

+   if (msc->lcls_codec_mismatch_allow)
+   vty_out(vty, " lcls-codec-mismatch allowed%s", VTY_NEWLINE);
+   else
+   vty_out(vty, " lcls-codec-mismatch forbidden%s", VTY_NEWLINE);
+
/* write MGW configuration */
mgcp_client_config_write(vty, " ");
 }
@@ -650,6 +655,23 @@
return CMD_SUCCESS;
 }

+DEFUN(cfg_net_msc_lcls_mismtch,
+  cfg_net_msc_lcls_mismtch_cmd,
+  "lcls-codec-mismatch (allowed|forbidden)",
+  "Allow 3GPP LCLS (Local Call, Local Switch) when call legs use different 
codec/rate\n"
+  "Allow LCLS only only for calls that use the same codec/rate on both 
legs\n"
+  "Do not Allow LCLS for calls that use a different codec/rate on both 
legs\n")
+{
+   struct bsc_msc_data *data = bsc_msc_data(vty);
+
+   if (strcmp(argv[0], "allowed") == 0)
+   data->lcls_codec_mismatch_allow = true;
+   else
+   data->lcls_codec_mismatch_allow = false;
+
+   return CMD_SUCCESS;
+}
+
 DEFUN(cfg_net_bsc_mid_call_text,
   cfg_net_bsc_mid_call_text_cmd,
   "mid-call-text .TEXT",
@@ -938,6 +960,7 @@
install_element(MSC_NODE, _net_msc_amr_5_15_cmd);
install_element(MSC_NODE, _net_msc_amr_4_75_cmd);
install_element(MSC_NODE, _net_msc_lcls_mode_cmd);
+   install_element(MSC_NODE, _net_msc_lcls_mismtch_cmd);
install_element(MSC_NODE, _msc_acc_lst_name_cmd);
install_element(MSC_NODE, _msc_no_acc_lst_name_cmd);
install_element(MSC_NODE, _msc_cs7_bsc_addr_cmd);

--
To view, visit https://gerrit.osmocom.org/9940
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I157549129a40c64364dc126f67195759e5f1d60f
Gerrit-Change-Number: 9940
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr

Change in osmo-bsc[master]: lcls: do not LCLS call legs with different codecs

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9940 )

Change subject: lcls: do not LCLS call legs with different codecs
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9940
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I157549129a40c64364dc126f67195759e5f1d60f
Gerrit-Change-Number: 9940
Gerrit-PatchSet: 4
Gerrit-Owner: dexter 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Mon, 13 Aug 2018 10:10:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-sgsn[master]: vty: add cmd "reset sgsn state"

2018-08-13 Thread lynxis lazus

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10370

to look at the new patch set (#4).

Change subject: vty: add cmd "reset sgsn state"
..

vty: add cmd "reset sgsn state"

Reset the SGSN internal state. Useful when testing the SGSN via TTCN3.
Depends on the libosmocore commit:
I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325

Change-Id: I92096f3f6ea49e75676e30e9921d00210bac5382
---
M src/gprs/sgsn_vty.c
1 file changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/70/10370/4
--
To view, visit https://gerrit.osmocom.org/10370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I92096f3f6ea49e75676e30e9921d00210bac5382
Gerrit-Change-Number: 10370
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte

Change in osmo-ttcn3-hacks[master]: NS_Emulation: support multiple instances at the same time

2018-08-13 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10376 )

Change subject: NS_Emulation: support multiple instances at the same time
..


Patch Set 7: Code-Review-1

need further testing


--
To view, visit https://gerrit.osmocom.org/10376
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9128f9ad5c372779c38799269393137ba52576cd
Gerrit-Change-Number: 10376
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 13 Aug 2018 14:56:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #214

2018-08-13 Thread jenkins

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking

Build failure of network:osmocom:nightly/osmo-trx-debian8-jessie in Debian_9.0/armv7l

2018-08-13 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx-debian8-jessie/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-trx-debian8-jessie failed to build in 
Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx-debian8-jessie

Last lines of build log:
[  337s]  dpkg-source --after-build BUILD
[  337s] dpkg-buildpackage: info: full upload; Debian-native package (full 
source is included)
[  337s] Warning: mkbaselibs missing in build root, skipping baselibs
[  337s] ... saving statistics
[  337s] ... saving built packages
[  337s] DEBS/osmo-trx_0.4.0_armhf.changes
[  337s] DEBS/osmo-trx_0.4.0.tar.xz
[  337s] DEBS/osmo-trx_0.4.0_all.deb
[  337s] DEBS/osmo-trx_0.4.0.dsc
[  337s] DEBS/osmo-trx-dbg_0.4.0_armhf.deb
[  337s] DEBS/osmo-trx-usrp1_0.4.0_armhf.deb
[  337s] DEBS/osmo-trx-uhd_0.4.0_armhf.deb
[  337s] OTHER/_statistics
[  337s] 
[  337s] armbuild04 finished "build osmo-trx_0.4.0.dsc" at Sun Aug 12 20:11:13 
UTC 2018.
[  337s] 
[  337s] ### VM INTERACTION START ###
[  340s] [  317.516397] SysRq : Power Off
[  340s] [  317.518352] reboot: Power down
[  340s] ### VM INTERACTION END ###
[  340s] build: extracting built packages...
[  340s] DEBS/osmo-trx_0.4.0_armhf.changes
[  340s] DEBS/osmo-trx_0.4.0.tar.xz
[  340s] DEBS/osmo-trx_0.4.0_all.deb
[  340s] DEBS/osmo-trx_0.4.0.dsc
[  340s] DEBS/osmo-trx-dbg_0.4.0_armhf.deb
[  340s] DEBS/osmo-trx-usrp1_0.4.0_armhf.deb
[  340s] DEBS/osmo-trx-uhd_0.4.0_armhf.deb
[  340s] OTHER/_statistics

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx-debian8-jessie in Debian_9.0/armv7l

2018-08-13 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx-debian8-jessie/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-trx-debian8-jessie failed to build in 
Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx-debian8-jessie

Last lines of build log:
[  337s]  dpkg-source --after-build BUILD
[  337s] dpkg-buildpackage: info: full upload; Debian-native package (full 
source is included)
[  337s] Warning: mkbaselibs missing in build root, skipping baselibs
[  337s] ... saving statistics
[  337s] ... saving built packages
[  337s] DEBS/osmo-trx_0.4.0_armhf.changes
[  337s] DEBS/osmo-trx_0.4.0.tar.xz
[  337s] DEBS/osmo-trx_0.4.0_all.deb
[  337s] DEBS/osmo-trx_0.4.0.dsc
[  337s] DEBS/osmo-trx-dbg_0.4.0_armhf.deb
[  337s] DEBS/osmo-trx-usrp1_0.4.0_armhf.deb
[  337s] DEBS/osmo-trx-uhd_0.4.0_armhf.deb
[  337s] OTHER/_statistics
[  337s] 
[  337s] armbuild04 finished "build osmo-trx_0.4.0.dsc" at Sun Aug 12 20:11:13 
UTC 2018.
[  337s] 
[  337s] ### VM INTERACTION START ###
[  340s] [  317.516397] SysRq : Power Off
[  340s] [  317.518352] reboot: Power down
[  340s] ### VM INTERACTION END ###
[  340s] build: extracting built packages...
[  340s] DEBS/osmo-trx_0.4.0_armhf.changes
[  340s] DEBS/osmo-trx_0.4.0.tar.xz
[  340s] DEBS/osmo-trx_0.4.0_all.deb
[  340s] DEBS/osmo-trx_0.4.0.dsc
[  340s] DEBS/osmo-trx-dbg_0.4.0_armhf.deb
[  340s] DEBS/osmo-trx-usrp1_0.4.0_armhf.deb
[  340s] DEBS/osmo-trx-uhd_0.4.0_armhf.deb
[  340s] OTHER/_statistics

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: WIP: Allow lua code to register a fd for reading with the runtime

2018-08-13 Thread Holger Freyther

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/10439


Change subject: WIP: Allow lua code to register a fd for reading with the 
runtime
..

WIP: Allow lua code to register a fd for reading with the runtime

To have bi-directional communication we can pass credentials to the
registry server and now we can register a callback when the registry
is sending data to us.

Change-Id: I8254bdda1df2f8fe0a5eac894b931e7de5b426df
---
M src/host/layer23/src/mobile/script_lua.c
1 file changed, 96 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/39/10439/1

diff --git a/src/host/layer23/src/mobile/script_lua.c 
b/src/host/layer23/src/mobile/script_lua.c
index 4cfe55a..1cfa812 100644
--- a/src/host/layer23/src/mobile/script_lua.c
+++ b/src/host/layer23/src/mobile/script_lua.c
@@ -28,6 +28,7 @@

 #include 

+#include 
 #include 

 #include 
@@ -37,6 +38,12 @@
int cb_ref;
 };

+struct fd_userdata {
+   struct lua_State *state;
+   struct osmo_fd fd;
+   int cb_ref;
+};
+
 static char lua_prim_key[] = "osmocom.org-mobile-prim";

 static struct mobile_prim_intf *get_primitive(lua_State *L)
@@ -430,6 +437,93 @@
return 1;
 }

+static int lua_fd_cb(struct osmo_fd *fd, unsigned int what) {
+   struct fd_userdata *fdu;
+   lua_State *L;
+   int cb_ref;
+   int err;
+
+   if (!fd->data) {
+   LOGP(DLUA, LOGL_ERROR,
+   "fd callback for fd(%d) but no lua callback\n", fd->fd);
+   return 0;
+   }
+
+   fdu = fd->data;
+   L = fdu->state;
+   cb_ref = fdu->cb_ref;
+   lua_rawgeti(L, LUA_REGISTRYINDEX, cb_ref);
+   luaL_unref(L, LUA_REGISTRYINDEX, cb_ref);
+
+   lua_pushinteger(L, fd->fd);
+
+   err = lua_pcall(L, 1, 0, 0);
+   if (err) {
+   LOGP(DLUA, LOGL_ERROR, "lua error: %s\n", lua_tostring(L, -1));
+   lua_pop(L, 1);
+   }
+
+   return 0;
+}
+
+/* Register the fd */
+static int lua_register_fd(lua_State *L)
+{
+   struct fd_userdata *fdu;
+
+   /* fd, cb */
+   luaL_argcheck(L, lua_isnumber(L, -2), 1, "needs to be a 
filedescriptor");
+   luaL_argcheck(L, lua_isfunction(L, -1), 2, "Callback needs to be a 
function");
+
+   /* Cretae a table so a user can unregister (and unregister on GC) */
+   fdu = lua_newuserdata(L, sizeof(*fdu));
+   fdu->state = L;
+   fdu->fd.fd = -1;
+   luaL_getmetatable(L, "Fd");
+   lua_setmetatable(L, -2);
+
+   /* Set the filedescriptor */
+   fdu->fd.fd = (int) lua_tonumber(L, -3);
+   fdu->fd.cb = lua_fd_cb;
+   fdu->fd.when = BSC_FD_READ;
+   fdu->fd.data = fdu;
+
+   /* Assuming that an error here will lead to a GC */
+   if (osmo_fd_register(>fd) != 0) {
+   fdu->cb_ref = LUA_NOREF;
+   lua_pushliteral(L, "Can't register the fd");
+   lua_error(L);
+   return 0;
+   }
+
+   /* Take the callback and keep a reference to it */
+   lua_pushvalue(L, -2);
+   fdu->cb_ref = luaL_ref(L, LUA_REGISTRYINDEX);
+
+   return 1;
+}
+
+static int lua_fd_unregister(lua_State *L) {
+   struct fd_userdata *fdu;
+
+   luaL_argcheck(L, lua_isuserdata(L, -1), 1, "No userdata");
+   fdu = lua_touserdata(L, -1);
+
+   /* Unregister the fd and forget about the callback */
+   osmo_fd_unregister(>fd);
+   if (fdu->cb_ref != LUA_NOREF) {
+   luaL_unref(L, LUA_REGISTRYINDEX, fdu->cb_ref);
+   fdu->cb_ref = LUA_NOREF;
+   }
+   return 0;
+}
+
+
+static const struct luaL_Reg fd_funcs[] = {
+   { "unregister", lua_fd_unregister },
+   { "__gc", lua_fd_unregister },
+};
+
 static const struct luaL_Reg ms_funcs[] = {
{ "imsi", lua_ms_imsi },
{ "imei", lua_ms_imei },
@@ -447,6 +541,7 @@
 static const struct luaL_Reg osmo_funcs[] = {
{ "timeout",lua_osmo_timeout },
{ "unix_passcred", lua_unix_passcred },
+   { "register_fd", lua_register_fd },
{ "ms", lua_osmo_ms },
{ NULL, NULL },
 };
@@ -510,6 +605,7 @@
/* Create metatables so we can GC objects... */
create_meta_table(L, "Timer", timer_funcs);
create_meta_table(L, "MS", ms_funcs);
+   create_meta_table(L, "Fd", fd_funcs);

/* Remember the primitive pointer... store it in the registry */
lua_pushlightuserdata(L, lua_prim_key);

--
To view, visit https://gerrit.osmocom.org/10439
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8254bdda1df2f8fe0a5eac894b931e7de5b426df
Gerrit-Change-Number: 10439
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther

Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10438


Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#
..

osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100#

Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD
processing has been moved to osmo-ghlr and prfix routing needs to be
configured, otherwise USSD requested are answered back to the MS with an
error "ss-NotAvailable (18)".

Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
---
M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/38/10438/1

diff --git a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl 
b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
index ccb8224..014efd3 100644
--- a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
@@ -13,3 +13,4 @@
 hlr
  gsup
   bind ip ${hlr.ip_address.addr}
+ ussd route prefix *#100# internal own-msisdn

--
To view, visit https://gerrit.osmocom.org/10438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: Cleanup of class scoped variables

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10413 )

Change subject: Cleanup of class scoped variables
..

Cleanup of class scoped variables

After bug described in OS#3456 and fixed in last commit, let's
categorize and place variables in its correct plac to avoid similar
issus. We leave under the class keyword (class scoped variables) the
attributes which are to be used as static class attributes. All other
ones are initialized during __init__(). This way w avoid scenarios in
which while using an object from an instance attribute we end up reading
a class scoped variable which is shared among all instances.

Change-Id: I5ad4cac34a9f49eaf42966c01c9c5a4d3f3e9dc8
---
M src/osmo_gsm_tester/bts.py
M src/osmo_gsm_tester/bts_octphy.py
M src/osmo_gsm_tester/bts_osmo.py
M src/osmo_gsm_tester/bts_osmotrx.py
M src/osmo_gsm_tester/bts_sysmo.py
M src/osmo_gsm_tester/esme.py
M src/osmo_gsm_tester/event_loop.py
M src/osmo_gsm_tester/modem.py
M src/osmo_gsm_tester/osmo_bsc.py
M src/osmo_gsm_tester/osmo_ggsn.py
M src/osmo_gsm_tester/osmo_hlr.py
M src/osmo_gsm_tester/osmo_mgcpgw.py
M src/osmo_gsm_tester/osmo_mgw.py
M src/osmo_gsm_tester/osmo_msc.py
M src/osmo_gsm_tester/osmo_nitb.py
M src/osmo_gsm_tester/osmo_sgsn.py
M src/osmo_gsm_tester/osmo_stp.py
M src/osmo_gsm_tester/osmocon.py
M src/osmo_gsm_tester/pcu.py
M src/osmo_gsm_tester/pcu_osmo.py
M src/osmo_gsm_tester/pcu_sysmo.py
M src/osmo_gsm_tester/process.py
M src/osmo_gsm_tester/sms.py
M src/osmo_gsm_tester/smsc.py
M src/osmo_gsm_tester/suite.py
M src/osmo_gsm_tester/test.py
M src/osmo_gsm_tester/trial.py
27 files changed, 92 insertions(+), 145 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/bts.py b/src/osmo_gsm_tester/bts.py
index 0f3ef1c..041b2bc 100644
--- a/src/osmo_gsm_tester/bts.py
+++ b/src/osmo_gsm_tester/bts.py
@@ -25,24 +25,21 @@
 from . import log, config, util, template, process, schema, pcu_osmo

 class Bts(log.Origin, metaclass=ABCMeta):
-suite_run = None
-conf = None
-bsc = None
-sgsn = None
-lac = None
-rac = None
-cellid = None
-bvci = None
-defaults_cfg_name = None
-_num_trx = 1
-_max_trx = None
-overlay_trx_list = []

 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf, name, defaults_cfg_name):
 super().__init__(log.C_RUN, name)
+self.bsc = None
+self.sgsn = None
+self.lac = None
+self.rac = None
+self.cellid = None
+self.bvci = None
+self._num_trx = 1
+self._max_trx = None
+self.overlay_trx_list = []
 self.suite_run = suite_run
 self.conf = conf
 self.defaults_cfg_name = defaults_cfg_name
diff --git a/src/osmo_gsm_tester/bts_octphy.py 
b/src/osmo_gsm_tester/bts_octphy.py
index 318c30d..f1a0ce8 100644
--- a/src/osmo_gsm_tester/bts_octphy.py
+++ b/src/osmo_gsm_tester/bts_octphy.py
@@ -27,16 +27,14 @@
 ##
 # PROTECTED
 ##
-run_dir = None
-inst = None
-env = None

 BIN_BTS_OCTPHY = 'osmo-bts-octphy'
-
 CONF_BTS_OCTPHY = 'osmo-bts-octphy.cfg'

 def __init__(self, suite_run, conf):
 super().__init__(suite_run, conf, OsmoBtsOctphy.BIN_BTS_OCTPHY, 
'osmo_bts_octphy')
+self.run_dir = None
+self.inst = None
 self.env = {}
 self.values = {}

diff --git a/src/osmo_gsm_tester/bts_osmo.py b/src/osmo_gsm_tester/bts_osmo.py
index b9b7fef..32784bd 100644
--- a/src/osmo_gsm_tester/bts_osmo.py
+++ b/src/osmo_gsm_tester/bts_osmo.py
@@ -24,14 +24,14 @@
 from . import log, config, util, template, process, bts, pcu_osmo

 class OsmoBts(bts.Bts, metaclass=ABCMeta):
-proc_bts = None
-_pcu = None

 ##
 # PROTECTED
 ##
 def __init__(self, suite_run, conf, name, defaults_cfg_name):
 super().__init__(suite_run, conf, name, defaults_cfg_name)
+self._pcu = None
+self.proc_bts = None
 if len(self.pcu_socket_path().encode()) > 107:
 raise log.Error('Path for pcu socket is longer than max allowed 
len for unix socket path (107):', self.pcu_socket_path())

@@ -75,9 +75,9 @@
 ##
 # PROTECTED
 ##
-pcu_sk_tmp_dir = None

 def __init__(self, suite_run, conf, name, defaults_cfg_name):
+self.pcu_sk_tmp_dir = None
 super().__init__(suite_run, conf, name, defaults_cfg_name)

 
diff --git a/src/osmo_gsm_tester/bts_osmotrx.py 
b/src/osmo_gsm_tester/bts_osmotrx.py
index b9310f8..1584eb2 100644
--- a/src/osmo_gsm_tester/bts_osmotrx.py
+++ b/src/osmo_gsm_tester/bts_osmotrx.py
@@ -27,10 +27,6 @@
 ##
 # PROTECTED
 ##
-run_dir = None
-inst = None
-env = None
-trx = None

 BIN_BTS_TRX = 'osmo-bts-trx'
 BIN_PCU = 'osmo-pcu'
@@ -39,6

Change in osmo-gsm-tester[master]: Cleanup of class scoped variables

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10413 )

Change subject: Cleanup of class scoped variables
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10413
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4cac34a9f49eaf42966c01c9c5a4d3f3e9dc8
Gerrit-Change-Number: 10413
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 13 Aug 2018 07:51:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: doc: update mgw settings in example config file

2018-08-13 Thread dexter

dexter has posted comments on this change. ( https://gerrit.osmocom.org/10239 )

Change subject: doc: update mgw settings in example config file
..


Patch Set 1:

> do we want this? This would make it impossible to run bsc + msc on
 > the same machine using the example configs, right?

It shouldn't collide, the port in osmo-msc is 2728 and here in osmo-bsc it is 
2727.


--
To view, visit https://gerrit.osmocom.org/10239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1c5097d98ec2ab97d51f99b1105db3de85c75f
Gerrit-Change-Number: 10239
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Mon, 13 Aug 2018 07:43:57 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...

2018-08-13 Thread Pau Espin Pedrol

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10438

to look at the new patch set (#2).

Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix 
expected answer format
..

osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer 
format

Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD
processing has been moved to osmo-hlr and prefix routing needs to be
configured, otherwise USSD requested are answered back to the MS with an
error "ss-NotAvailable (18)".

mesage received for extension resolution (*#100#) had its format change,
so update to new format (carriage return at the end was dropped).

Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
---
M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
M suites/aoip_ussd/assert_extension.py
2 files changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester 
refs/changes/38/10438/2
--
To view, visit https://gerrit.osmocom.org/10438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10438 )

Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix 
expected answer format
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 12:53:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-netif[master]: jibuf: fix indentation in line inside conditional clause

2018-08-13 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10440 )

Change subject: jibuf: fix indentation in line inside conditional clause
..

jibuf: fix indentation in line inside conditional clause

Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
---
M src/jibuf.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/jibuf.c b/src/jibuf.c
index 2632a57..502f6e5 100644
--- a/src/jibuf.c
+++ b/src/jibuf.c
@@ -322,7 +322,7 @@
struct msgb *msg, *tmp;
osmo_timer_del(>timer);
llist_for_each_entry_safe(msg, tmp, >msg_list, list)
-   dequeue_msg(jb, msg);
+   dequeue_msg(jb, msg);

talloc_free(jb);
 }

--
To view, visit https://gerrit.osmocom.org/10440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
Gerrit-Change-Number: 10440
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in libosmo-netif[master]: jibuf: fix indentation in line inside conditional clause

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10440 )

Change subject: jibuf: fix indentation in line inside conditional clause
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
Gerrit-Change-Number: 10440
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 15:38:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: NS_Emulation: support multiple instances at the same time

2018-08-13 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10376 )

Change subject: NS_Emulation: support multiple instances at the same time
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/10376
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9128f9ad5c372779c38799269393137ba52576cd
Gerrit-Change-Number: 10376
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 13 Aug 2018 15:54:16 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-sgsn[master]: vty: add cmd "reset sgsn state"

2018-08-13 Thread lynxis lazus

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10370 )

Change subject: vty: add cmd "reset sgsn state"
..

vty: add cmd "reset sgsn state"

Reset the SGSN internal state. Useful when testing the SGSN via TTCN3.
Depends on the libosmocore commit:
I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325

Change-Id: I92096f3f6ea49e75676e30e9921d00210bac5382
---
M src/gprs/sgsn_vty.c
1 file changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 8092158..057be9f 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -44,6 +45,8 @@
 #include 
 #include 

+#include 
+
 #include 
 #include 

@@ -796,6 +799,34 @@
vty_out(vty, "Use count: %u%s", gsub->use_count, VTY_NEWLINE);
 }

+DEFUN_HIDDEN(reset_sgsn_state,
+  reset_sgsn_state_cmd,
+  "reset sgsn state",
+  "Remove all known subscriber, MM ctx and flush BSSGP queues Useful when 
running tests against the SGSN")
+{
+   struct gprs_subscr *subscr, *tmp_subscr;
+   struct sgsn_mm_ctx *mm, *tmp_mm;
+
+   llist_for_each_entry_safe(mm, tmp_mm, _mm_ctxts, list)
+   {
+   gsm0408_gprs_access_cancelled(mm, SGSN_ERROR_CAUSE_NONE);
+   }
+   vty_out(vty, "Cancelled MM Ctx. %s", VTY_NEWLINE);
+
+   llist_for_each_entry_safe(subscr, tmp_subscr, gprs_subscribers, entry) {
+   gprs_subscr_get(subscr);
+   gprs_subscr_cancel(subscr);
+   gprs_subscr_put(subscr);
+   }
+   vty_out(vty, "Removed all gprs subscribers.%s", VTY_NEWLINE);
+
+   bssgp_flush_all_queues();
+   vty_out(vty, "Flushed all BSSGPs queues.%s", VTY_NEWLINE);
+
+   /* remove all queues to bssgp */
+   return CMD_SUCCESS;
+}
+
 DEFUN(show_subscr_cache,
   show_subscr_cache_cmd,
   "show subscriber cache",
@@ -1310,6 +1341,7 @@
install_element(ENABLE_NODE, _subscr_cancel_cmd);
install_element(ENABLE_NODE, _subscr_update_location_result_cmd);
install_element(ENABLE_NODE, _subscr_update_auth_info_cmd);
+   install_element(ENABLE_NODE, _sgsn_state_cmd);

install_element(CONFIG_NODE, _sgsn_cmd);
install_node(_node, config_write_sgsn);

--
To view, visit https://gerrit.osmocom.org/10370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I92096f3f6ea49e75676e30e9921d00210bac5382
Gerrit-Change-Number: 10370
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus

Change in libosmo-sccp[master]: sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer...

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10443


Change subject: sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
..

sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer_ind_xua

Fixes following error provided by LeakSanitizer:

Indirect leak of 1496 byte(s) in 11 object(s) allocated from:
#0 0x7f1eb3332d99 in __interceptor_malloc 
/build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
#1 0x7f1eae617b61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)
#2 0x7f1eb063e365 in xua_msg_alloc 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:49
#3 0x7f1eb0650ee3 in osmo_sccp_to_xua 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp2sua.c:1298
#4 0x7f1eb0668d6a in mtp_user_prim_cb 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp_user.c:173
#5 0x7f1eb068ba86 in deliver_to_mtp_user 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:94
#6 0x7f1eb068bf00 in hmdt_message_for_distribution 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:133
#7 0x7f1eb068d345 in m3ua_hmdc_rx_from_l2 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:275
#8 0x7f1eb063c08f in m3ua_rx_xfer 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:586
#9 0x7f1eb063cea6 in m3ua_rx_msg 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:739
#10 0x7f1eb0687188 in xua_cli_read_cb 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590
#11 0x7f1eaff77db4 in osmo_stream_cli_read 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192
#12 0x7f1eaff79091 in osmo_stream_cli_fd_cb 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276
#13 0x7f1eaf259795 in osmo_fd_disp_fds 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217
#14 0x7f1eaf259abb in osmo_select_main 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257
#15 0x55666c1bebd3 in main 
/home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697
#16 0x7f1ead1c306a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
#17 0x55666c1bc649 in _start 
(/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)

The code path is the following, starting from mpt_user_prim_cb:
mtp_user_prim_cb
osmo_sccp_to_xua
xua_msg_alloc
scrc_rx_mtp_xfer_ind_xua
sccp_scoc_rx_from_scrc
scrc_node_6
scrc_node_4
scrc_translate_node_9

So the xua_msg is created in mtp_user_prim_cb through osmo_sccp_to_xua
and then handed over to scrc_rx_mtp_xfer_ind_xua which transfers the
xua_msg and thus should take ownserhip of it, and consecuently freeing
it once it's done using it.

Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
---
M src/sccp_scrc.c
1 file changed, 12 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/43/10443/1

diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c
index cd01774..4cb3714 100644
--- a/src/sccp_scrc.c
+++ b/src/sccp_scrc.c
@@ -438,13 +438,14 @@
 }

 /* Figure C.1/Q.714 Sheet 1 of 12, after we converted the
- * MTP-TRANSFER.ind to SUA */
+ * MTP-TRANSFER.ind to SUA. Gains ownsership of /ref xua and frees it once 
processed. */
 int scrc_rx_mtp_xfer_ind_xua(struct osmo_sccp_instance *inst,
 struct xua_msg *xua)
 {
struct osmo_sccp_addr called;
uint32_t proto_class;
struct xua_msg_part *hop_ctr_part;
+   int rc;

LOGP(DLSS7, LOGL_DEBUG, "%s: %s\n", __func__, xua_msg_dump(xua, 
_dialect_sua));
/* TODO: SCCP or nodal congestion? */
@@ -454,6 +455,7 @@
/* Node 1 (Sheet 3) */
/* deliver to SCOC */
sccp_scoc_rx_from_scrc(inst, xua);
+   xua_msg_free(xua);
return 0;
}
/* We only treat connectionless and CR below */
@@ -463,7 +465,9 @@
/* Route on GT? */
if (called.ri != OSMO_SCCP_RI_GT) {
/* Node 6 (Sheet 3) */
-   return scrc_node_6(inst, xua, );
+   rc = scrc_node_6(inst, xua, );
+   xua_msg_free(xua);
+   return rc;
}
/* Message with hop-counter? */
hop_ctr_part = xua_msg_find_tag(xua, SUA_IEI_S7_HOP_CTR);
@@ -472,7 +476,9 @@
if (hop_counter <= 1) {
/* Error: hop-counter violation */
/* node 4 */
-   return scrc_node_4(inst, xua, 
SCCP_RETURN_CAUSE_HOP_COUNTER_VIOLATION);
+   rc = scrc_node_4(inst, xua, 
SCCP_RETURN_CAUSE_HOP_COUNTER_VIOLATION);
+   xua_msg_free(xua);
+   return rc;
}
/* Decrement hop-counter */
hop_counter--;
@@ -492,5 +498,7 @@
default:

Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10442


Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
..

xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
---
M src/xua_msg.c
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/42/10442/1

diff --git a/src/xua_msg.c b/src/xua_msg.c
index ed0cdc7..3bd6a6d 100644
--- a/src/xua_msg.c
+++ b/src/xua_msg.c
@@ -27,6 +27,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 

@@ -55,6 +56,12 @@

 void xua_msg_free(struct xua_msg *msg)
 {
+   struct xua_msg_part *part, *tmp;
+   llist_for_each_entry_safe(part, tmp, >headers, entry) {
+   llist_del(>entry);
+   talloc_free(part);
+   }
+
talloc_free(msg);
 }


--
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-ttcn3-hacks[master]: NS_Emulation: support multiple instances at the same time

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10376 )

Change subject: NS_Emulation: support multiple instances at the same time
..


Patch Set 8: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10376
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9128f9ad5c372779c38799269393137ba52576cd
Gerrit-Change-Number: 10376
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:17:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10444


Change subject: xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp
..

xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp

>From LeakSanitizer report:
Indirect leak of 384 byte(s) in 3 object(s) allocated from:
#0 0x7f986da27d99 in __interceptor_malloc 
/build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
#1 0x7f9868d0cb61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)
#2 0x7f986ad33766 in xua_msg_add_data 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:73
#3 0x7f986ad343c3 in xua_from_msg_common 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:143
#4 0x7f986ad347d2 in xua_from_nested 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:201
#5 0x7f986ad65563 in m3ua_rx_rkm_reg_rsp 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:431
#6 0x7f986ad65f96 in m3ua_rx_rkm 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_rkm.c:510
#7 0x7f986ad31ef7 in m3ua_rx_msg 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:749
#8 0x7f986ad7c1e8 in xua_cli_read_cb 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590
#9 0x7f986a66cdb4 in osmo_stream_cli_read 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192
#10 0x7f986a66e091 in osmo_stream_cli_fd_cb 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276
#11 0x7f986994e795 in osmo_fd_disp_fds 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217
#12 0x7f986994eabb in osmo_select_main 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257
#13 0x5630cb294bd3 in main 
/home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697
#14 0x7f98678b806a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
#15 0x5630cb292649 in _start 
(/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)

Following code paths:
m3ua_rx_rkm_reg_rsp
xua_from_nested
xua_from_msg_common
xua_msg_add_data
talloc_zero (part)
handle_rkey_reg_resp

Take the chance to fix the same issue in m3ua_rx_rkm_dereg_rsp.

Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc
---
M src/xua_rkm.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/10444/1

diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index b79f7f3..a77460d 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -433,6 +433,7 @@
continue;

handle_rkey_reg_resp(asp, inner);
+   xua_msg_free(inner);
}
return 0;
 }
@@ -485,6 +486,7 @@
continue;

handle_rkey_dereg_resp(asp, inner);
+   xua_msg_free(inner);
}
return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/10444
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc
Gerrit-Change-Number: 10444
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-sgsn[master]: vty: add cmd "reset sgsn state"

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10370 )

Change subject: vty: add cmd "reset sgsn state"
..


Patch Set 4: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10370
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92096f3f6ea49e75676e30e9921d00210bac5382
Gerrit-Change-Number: 10370
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 13 Aug 2018 15:38:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in docker-playground[master]: SGSN_Tests: fix module parameters

2018-08-13 Thread lynxis lazus

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/10441


Change subject: SGSN_Tests: fix module parameters
..

SGSN_Tests: fix module parameters

ttcn commit I9128f9ad5c372779c38799269393137ba52576cd moves the
modules parameters from NS_Emulation to SGSN_Tests.

Change-Id: I8d46c37b9c932582fe94e670d9347209bb599192
---
M ttcn3-sgsn-test/SGSN_Tests.cfg
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/docker-playground 
refs/changes/41/10441/1

diff --git a/ttcn3-sgsn-test/SGSN_Tests.cfg b/ttcn3-sgsn-test/SGSN_Tests.cfg
index ea193ef..92ed77b 100644
--- a/ttcn3-sgsn-test/SGSN_Tests.cfg
+++ b/ttcn3-sgsn-test/SGSN_Tests.cfg
@@ -12,8 +12,10 @@
 *.SGSNVTY.CTRL_HOSTNAME := "172.18.8.10"

 [MODULE_PARAMETERS]
-NS_Emulation.mp_local_ip := "172.18.8.103"
-NS_Emulation.mp_remote_ip := "172.18.8.10"
+SGSN_Tests.mp_nsconfig := {
+   local_ip := "172.18.8.103",
+   remote_ip := "172.18.8.10"
+}
 SGSN_Tests.mp_hlr_ip := "172.18.8.103"
 SGSN_Tests.mp_ggsn_ip := "172.18.8.103"


--
To view, visit https://gerrit.osmocom.org/10441
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d46c37b9c932582fe94e670d9347209bb599192
Gerrit-Change-Number: 10441
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus

Change in osmo-ttcn3-hacks[master]: sgsn: use vty cmd `reset sgsn state`.

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10388 )

Change subject: sgsn: use vty cmd `reset sgsn state`.
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10388
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idff3de6f1b8f5cb503edc5c6256ce2bf7ec7aaa2
Gerrit-Change-Number: 10388
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:16:08 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10442 )

Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10442/1/src/xua_msg.c
File src/xua_msg.c:

https://gerrit.osmocom.org/#/c/10442/1/src/xua_msg.c@59
PS1, Line 59:   struct xua_msg_part *part, *tmp;
why are we leaking parts  As the xua_msg_part should all be allocated as 
children of the xua_msg, talloc should neatly clean all of the parts up.

If you find parts that are allocated not as children of the xua_msg parent 
context, then I would think the bug is at that point.



--
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:19:19 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: jibuf: fix indentation in line inside conditional clause

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10440


Change subject: jibuf: fix indentation in line inside conditional clause
..

jibuf: fix indentation in line inside conditional clause

Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
---
M src/jibuf.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/10440/1

diff --git a/src/jibuf.c b/src/jibuf.c
index 2632a57..502f6e5 100644
--- a/src/jibuf.c
+++ b/src/jibuf.c
@@ -322,7 +322,7 @@
struct msgb *msg, *tmp;
osmo_timer_del(>timer);
llist_for_each_entry_safe(msg, tmp, >msg_list, list)
-   dequeue_msg(jb, msg);
+   dequeue_msg(jb, msg);

talloc_free(jb);
 }

--
To view, visit https://gerrit.osmocom.org/10440
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cb356a4a13d53e7f88a5e4595899bb2eb510d20
Gerrit-Change-Number: 10440
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in osmo-gsm-tester[master]: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expecte...

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10438 )

Change subject: osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix 
expected answer format
..

osmo-hlr.cfg.tmpl: Add ussd routing prefix for *#100# and fix expected answer 
format

Since osmo-hlr.git I1d09fab810a6bb9ab02904de72dbc9e8a414f9f9, USSD
processing has been moved to osmo-hlr and prefix routing needs to be
configured, otherwise USSD requested are answered back to the MS with an
error "ss-NotAvailable (18)".

mesage received for extension resolution (*#100#) had its format change,
so update to new format (carriage return at the end was dropped).

Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
---
M src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
M suites/aoip_ussd/assert_extension.py
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl 
b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
index ccb8224..014efd3 100644
--- a/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-hlr.cfg.tmpl
@@ -13,3 +13,4 @@
 hlr
  gsup
   bind ip ${hlr.ip_address.addr}
+ ussd route prefix *#100# internal own-msisdn
diff --git a/suites/aoip_ussd/assert_extension.py 
b/suites/aoip_ussd/assert_extension.py
index 56d853b..475de09 100755
--- a/suites/aoip_ussd/assert_extension.py
+++ b/suites/aoip_ussd/assert_extension.py
@@ -46,4 +46,5 @@

 print('Sending ussd code %s' % USSD_COMMAND_GET_EXTENSION)
 response = ms.ussd_send(USSD_COMMAND_GET_EXTENSION)
-assert ' ' + ms.msisdn + '\r' in response
+log('got ussd response: %r' % repr(response))
+assert response.endswith(' ' + ms.msisdn)

--
To view, visit https://gerrit.osmocom.org/10438
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f75eff0df2d20d7f9b39e69184cffb0e635713d
Gerrit-Change-Number: 10438
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol

Change in libosmo-sccp[master]: sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer...

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10443 )

Change subject: sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/10443/1/src/sccp_scrc.c
File src/sccp_scrc.c:

https://gerrit.osmocom.org/#/c/10443/1/src/sccp_scrc.c@441
PS1, Line 441: ref
isn't it /a or /arg xua if you're referrin to an argument? I thought /ref is 
for references to other symbols/functions?



--
To view, visit https://gerrit.osmocom.org/10443
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
Gerrit-Change-Number: 10443
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:20:52 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10442 )

Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
..


Patch Set 1:

I'm not sure it this one is actually needed thanks to talloc. I did this first 
before finding more "core" problems, or finding out tha tthe parent structure 
was neither freed.


--
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:21:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in libosmo-sccp[master]: xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp

2018-08-13 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10444 )

Change subject: xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10444
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b15d81099a9f8274b7e39962caa339da644e0dc
Gerrit-Change-Number: 10444
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:22:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10442 )

Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
..


Patch Set 1:

parts are allocated like this:

int xua_msg_add_data(struct xua_msg *msg, uint16_t tag,
  uint16_t len, uint8_t *dat)
{
struct xua_msg_part *part;

part = talloc_zero(msg, struct xua_msg_part);

so probably no need, but still more clear to free them explicitly and cleanup 
the list anyway.


--
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:23:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: NS_Emulation: support multiple instances at the same time

2018-08-13 Thread lynxis lazus

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10376 )

Change subject: NS_Emulation: support multiple instances at the same time
..

NS_Emulation: support multiple instances at the same time

The NS_Emulation has configuration values hardcoded or bound
to module parameters which prevents multiple instances.
Replace the module parameter based configuration with configuration
given when starting the NS_Emaulation.

Change-Id: I9128f9ad5c372779c38799269393137ba52576cd
---
M library/NS_Emulation.ttcn
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.ttcn
M sgsn/SGSN_Tests.default
M sgsn/SGSN_Tests.ttcn
5 files changed, 62 insertions(+), 38 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/library/NS_Emulation.ttcn b/library/NS_Emulation.ttcn
index 01d45b4..7cccb25 100644
--- a/library/NS_Emulation.ttcn
+++ b/library/NS_Emulation.ttcn
@@ -72,7 +72,8 @@
out NsUnitdataRequest;
} with { extension "internal" };

-   function NSStart() runs on NS_CT {
+   function NSStart(NSConfiguration init_config) runs on NS_CT {
+   config := init_config;
f_init();
f_ScanEvents();
}
@@ -80,7 +81,7 @@
private function f_init() runs on NS_CT {
var Result res;
/* Connect the UDP socket */
-   res := f_IPL4_connect(NSCP, mp_remote_ip, mp_remote_udp_port, 
mp_local_ip, mp_local_udp_port, 0, { udp := {}});
+   res := f_IPL4_connect(NSCP, config.remote_ip, 
config.remote_udp_port, config.local_ip, config.local_udp_port, 0, { udp := 
{}});
if (not ispresent(res.connId)) {
setverdict(fail, "Could not connect NS UDP socket, 
check your configuration");
mtc.stop;
@@ -97,6 +98,8 @@
/* NS-User SAP towards the user */
port NS_SP_PT NS_SP;

+   var NSConfiguration config;
+
var NseStateg_state := NSE_S_DEAD_BLOCKED;
var ConnectionIdg_conn_id := -1;

@@ -105,24 +108,24 @@
timer Tns_block := 10.0;
}

-   modulepar {
-   PortNumber mp_local_udp_port := 23000;
-   charstring mp_local_ip := "127.0.0.1";
-   PortNumber mp_remote_udp_port := 21000;
-   charstring mp_remote_ip := "127.0.0.1";
-   Nsvci mp_nsvci := 0;
-   Nsvci mp_nsei := 2342;
-   };
+   type record NSConfiguration {
+   PortNumber local_udp_port,
+   charstring local_ip,
+   PortNumber remote_udp_port,
+   charstring remote_ip,
+   Nsvci nsvci,
+   Nsvci nsei
+   }

private function f_change_state(NseState new_state) runs on NS_CT {
var NseState old_state := g_state;
g_state := new_state;
log("NS State Transition: ", old_state, " -> ", new_state);
-   NS_SP.send(t_NsStsInd(mp_nsei, mp_nsvci, old_state, new_state));
+   NS_SP.send(t_NsStsInd(config.nsei, config.nsvci, old_state, 
new_state));
}

private function f_sendReset() runs on NS_CT {
-   NSCP.send(t_NS_Send(g_conn_id, 
t_NS_RESET(NS_CAUSE_OM_INTERVENTION, mp_nsvci, mp_nsei)));
+   NSCP.send(t_NS_Send(g_conn_id, 
t_NS_RESET(NS_CAUSE_OM_INTERVENTION, config.nsvci, config.nsei)));
g_state := NSE_S_WAIT_RESET;
}

@@ -137,7 +140,7 @@
}

private function f_sendBlock(NsCause cause) runs on NS_CT {
-   NSCP.send(t_NS_Send(g_conn_id, t_NS_BLOCK(cause, mp_nsvci)));
+   NSCP.send(t_NS_Send(g_conn_id, t_NS_BLOCK(cause, 
config.nsvci)));
Tns_block.start;
}

@@ -176,9 +179,9 @@
}

/* Respond to RESET with correct NSEI/NSVCI */
-   [] NSCP.receive(t_NS_RecvFrom(t_NS_RESET(?, mp_nsvci, 
mp_nsei))) -> value rf {
+   [] NSCP.receive(t_NS_RecvFrom(t_NS_RESET(?, config.nsvci, 
config.nsei))) -> value rf {
f_change_state(NSE_S_ALIVE_BLOCKED);
-   NSCP.send(t_NS_Send(g_conn_id, t_NS_RESET_ACK(mp_nsvci, 
mp_nsei)));
+   NSCP.send(t_NS_Send(g_conn_id, 
t_NS_RESET_ACK(config.nsvci, config.nsei)));
}

/* Respond to RESET with wrong NSEI/NSVCI */
@@ -210,7 +213,7 @@
}
} else if (g_state == NSE_S_WAIT_RESET) {
alt {
-   [] 
NSCP.receive(t_NS_RecvFrom(t_NS_RESET_ACK(mp_nsvci, mp_nsei))) -> value rf {
+   [] 
NSCP.receive(t_NS_RecvFrom(t_NS_RESET_ACK(config.nsvci, config.nsei))) -> value 
rf {

Change in osmo-msc[master]: osmo-msc: Improve shutdown due to signal and print talloc report on exit

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10445


Change subject: osmo-msc: Improve shutdown due to signal and print talloc 
report on exit
..

osmo-msc: Improve shutdown due to signal and print talloc report on exit

Same as we do in osmo-hlr.

Change-Id: If6ea9171fd79f03251342f75987690b0d9dc3814
---
M src/osmo-msc/msc_main.c
1 file changed, 26 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/10445/1

diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index aa06fb9..b1bb52a 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -110,6 +110,8 @@

 static struct osmo_timer_list db_sync_timer;

+static int quit = 0;
+
 static void print_usage()
 {
printf("Usage: osmo-msc\n");
@@ -233,10 +235,8 @@
switch (signal) {
case SIGINT:
case SIGTERM:
-   msc_network_shutdown(msc_network);
-   osmo_signal_dispatch(SS_L_GLOBAL, S_L_GLOBAL_SHUTDOWN, NULL);
-   sleep(3);
-   exit(0);
+   LOGP(DMSC, LOGL_NOTICE, "Terminating due to signal %d\n", 
signal);
+   quit++;
break;
case SIGABRT:
osmo_generate_backtrace();
@@ -692,8 +692,29 @@
}
}

-   while (1) {
+   while (!quit) {
log_reset_context();
osmo_select_main(0);
}
+
+   msc_network_shutdown(msc_network);
+   osmo_signal_dispatch(SS_L_GLOBAL, S_L_GLOBAL_SHUTDOWN, NULL);
+   sleep(3);
+
+   log_fini();
+
+   /**
+* Report the heap state of root context, then free,
+* so both ASAN and Valgrind are happy...
+*/
+   talloc_report_full(tall_msc_ctx, stderr);
+   talloc_free(tall_msc_ctx);
+
+   /**
+* Report the heap state of NULL context, then free,
+* so both ASAN and Valgrind are happy...
+*/
+   talloc_report_full(NULL, stderr);
+   talloc_disable_null_tracking();
+   return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/10445
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6ea9171fd79f03251342f75987690b0d9dc3814
Gerrit-Change-Number: 10445
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in libosmo-sccp[master]: sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer...

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10443 )

Change subject: sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10443/1/src/sccp_scrc.c
File src/sccp_scrc.c:

https://gerrit.osmocom.org/#/c/10443/1/src/sccp_scrc.c@441
PS1, Line 441: ref
> isn't it /a or /arg xua if you're referrin to an argument? I thought /ref is 
> for references to other […]
\a, actually with the inverted slash. 
https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmda



--
To view, visit https://gerrit.osmocom.org/10443
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
Gerrit-Change-Number: 10443
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:31:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-sccp[master]: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free

2018-08-13 Thread Pau Espin Pedrol

Pau Espin Pedrol has abandoned this change. ( https://gerrit.osmocom.org/10442 )

Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/10442
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624
Gerrit-Change-Number: 10442
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Harald Welte

Change in libosmo-sccp[master]: sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer...

2018-08-13 Thread Pau Espin Pedrol

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10443

to look at the new patch set (#2).

Change subject: sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
..

sscp_scrc: Fix memleak of xua_msg when handing it to scrc_rx_mtp_xfer_ind_xua

Fixes following error provided by LeakSanitizer:

Indirect leak of 1496 byte(s) in 11 object(s) allocated from:
#0 0x7f1eb3332d99 in __interceptor_malloc 
/build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:86
#1 0x7f1eae617b61 in _talloc_zero (/usr/lib/libtalloc.so.2+0x5b61)
#2 0x7f1eb063e365 in xua_msg_alloc 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/xua_msg.c:49
#3 0x7f1eb0650ee3 in osmo_sccp_to_xua 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp2sua.c:1298
#4 0x7f1eb0668d6a in mtp_user_prim_cb 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/sccp_user.c:173
#5 0x7f1eb068ba86 in deliver_to_mtp_user 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:94
#6 0x7f1eb068bf00 in hmdt_message_for_distribution 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:133
#7 0x7f1eb068d345 in m3ua_hmdc_rx_from_l2 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7_hmrt.c:275
#8 0x7f1eb063c08f in m3ua_rx_xfer 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:586
#9 0x7f1eb063cea6 in m3ua_rx_msg 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/m3ua.c:739
#10 0x7f1eb0687188 in xua_cli_read_cb 
/home/pespin/dev/sysmocom/git/libosmo-sccp/src/osmo_ss7.c:1590
#11 0x7f1eaff77db4 in osmo_stream_cli_read 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:192
#12 0x7f1eaff79091 in osmo_stream_cli_fd_cb 
/home/pespin/dev/sysmocom/git/libosmo-netif/src/stream.c:276
#13 0x7f1eaf259795 in osmo_fd_disp_fds 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:217
#14 0x7f1eaf259abb in osmo_select_main 
/home/pespin/dev/sysmocom/git/libosmocore/src/select.c:257
#15 0x55666c1bebd3 in main 
/home/pespin/dev/sysmocom/git/osmo-msc/src/osmo-msc/msc_main.c:697
#16 0x7f1ead1c306a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
#17 0x55666c1bc649 in _start 
(/home/pespin/dev/sysmocom/build/new/out/bin/osmo-msc+0x185649)

The code path is the following, starting from mpt_user_prim_cb:
mtp_user_prim_cb
osmo_sccp_to_xua
xua_msg_alloc
scrc_rx_mtp_xfer_ind_xua
sccp_scoc_rx_from_scrc
scrc_node_6
scrc_node_4
scrc_translate_node_9

So the xua_msg is created in mtp_user_prim_cb through osmo_sccp_to_xua
and then handed over to scrc_rx_mtp_xfer_ind_xua which transfers the
xua_msg and thus should take ownserhip of it, and consecuently freeing
it once it's done using it.

Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
---
M src/sccp_scrc.c
1 file changed, 12 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/43/10443/2
--
To view, visit https://gerrit.osmocom.org/10443
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I43e159c82b64bd85b185f77ee19b6455a96e082f
Gerrit-Change-Number: 10443
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol

Change in osmo-ttcn3-hacks[master]: sgsn: create 3 instances of BSSGP at the same time

2018-08-13 Thread lynxis lazus

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10378

to look at the new patch set (#2).

Change subject: sgsn: create 3 instances of BSSGP at the same time
..

sgsn: create 3 instances of BSSGP at the same time

Allows to use different BSSGP connection within a single
test.

Change-Id: I01d7f264a0a52e248d6e754485c807266c0b14bf
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 65 insertions(+), 56 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/78/10378/2
--
To view, visit https://gerrit.osmocom.org/10378
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01d7f264a0a52e248d6e754485c807266c0b14bf
Gerrit-Change-Number: 10378
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus

Change in osmo-ttcn3-hacks[master]: sgsn: add optional bssgp index for f_upd_ptmsi_and_tlli f_bssgp_clien...

2018-08-13 Thread lynxis lazus

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10386

to look at the new patch set (#2).

Change subject: sgsn: add optional bssgp index for f_upd_ptmsi_and_tlli 
f_bssgp_client_llgmm_assign f_process_rau_accept
..

sgsn: add optional bssgp index for f_upd_ptmsi_and_tlli 
f_bssgp_client_llgmm_assign f_process_rau_accept

f_process_rau_accept can send the RAU Complete over the correct BSSGP

Change-Id: Ib9a65f0d09d3689911843a1b40e2a4114710e5b5
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/86/10386/2
--
To view, visit https://gerrit.osmocom.org/10386
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9a65f0d09d3689911843a1b40e2a4114710e5b5
Gerrit-Change-Number: 10386
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: move LLC layer out of BSSGP

2018-08-13 Thread lynxis lazus

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10383

to look at the new patch set (#2).

Change subject: BSSGP_Emulation: move LLC layer out of BSSGP
..

BSSGP_Emulation: move LLC layer out of BSSGP

The LLC layer needs to be accessed by the SGSN tests
in order to do multi-BSSGP tests.
Otherwise the sgsn will see LLC frame with wrong sequence
numbers and drop them.

Change-Id: Ie9e9d7da0a78a96f4f431c9085b9e273a39535f1
---
M library/BSSGP_Emulation.ttcn
M sgsn/SGSN_Tests.ttcn
2 files changed, 54 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/83/10383/2
--
To view, visit https://gerrit.osmocom.org/10383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie9e9d7da0a78a96f4f431c9085b9e273a39535f1
Gerrit-Change-Number: 10383
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: move LLC layer out of BSSGP

2018-08-13 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10383 )

Change subject: BSSGP_Emulation: move LLC layer out of BSSGP
..


Patch Set 2:

I've renamed the function to f_send_l3_gmm_llc


--
To view, visit https://gerrit.osmocom.org/10383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e9d7da0a78a96f4f431c9085b9e273a39535f1
Gerrit-Change-Number: 10383
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:42:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: move LLC layer out of BSSGP

2018-08-13 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10383 )

Change subject: BSSGP_Emulation: move LLC layer out of BSSGP
..


Patch Set 2:

I've renamed the function to f_send_l3_gmm_llc


--
To view, visit https://gerrit.osmocom.org/10383
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e9d7da0a78a96f4f431c9085b9e273a39535f1
Gerrit-Change-Number: 10383
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:42:35 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach

2018-08-13 Thread lynxis lazus

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/10392

to look at the new patch set (#3).

Change subject: sgsn: add TC_attach_gmm_attach_req_while_gmm_attach
..

sgsn: add TC_attach_gmm_attach_req_while_gmm_attach

Testing the corner case of receiving a Attach Request
while not (yet) sent an Attach Request.

MS -> SGSN: Attach Request IMSI
MS <- SGSN: Identity Request IMSI (optional)
MS -> SGSN: Identity Response IMSI (optional)
MS <- SGSN: Identity Request IMEI
MS -> SGSN: Attach Request (2nd)
MS <- SGSN: Identity Response IMEI
MS <- SGSN: Attach Accept
MS -> SGSN: Attach Complete

Change-Id: I0bac50dc5a72ba8f9010b05bcb98aa7ff0b81cf6
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 73 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/92/10392/3
--
To view, visit https://gerrit.osmocom.org/10392
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0bac50dc5a72ba8f9010b05bcb98aa7ff0b81cf6
Gerrit-Change-Number: 10392
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in docker-playground[master]: SGSN_Tests: fix module parameters

2018-08-13 Thread lynxis lazus

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/10441 )

Change subject: SGSN_Tests: fix module parameters
..


Patch Set 1: Verified+1

tested it on my machine


--
To view, visit https://gerrit.osmocom.org/10441
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d46c37b9c932582fe94e670d9347209bb599192
Gerrit-Change-Number: 10441
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 13 Aug 2018 16:45:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

49 matches

Mail list logo