Patch Set 2:
Here are a couple valid SID samples:
const uint8_t sid1[] = { d7, e0, a3, 61, 2c, 00, 00, 80, 49, 00, 00, 49, 00,
00, 80, 00, 04, 00, 00, 00, 00, 12, 40, 00, 10, 08, 00, 00, 00, 08, 2d, 04, 09
};
const uint8_t sid2[] = { d7, a2, bb, 65, e5, 00, 00, 10, 00, 04, 82, 00, 00,
00,
Review at https://gerrit.osmocom.org/2450
Add remote user for RemoteProcress
Use it to set root user for SysmoBTS, otherwise if osmo-gsm-tester is
run by another user it will fail to connect
Change-Id: I67d4126fc75cb9c2d249c713cd6f14db1f1e21da
---
M selftest/process_test.py
M
Patch Set 2:
Max, please could you explain why is this required? What kind of build issues
are you seeing? Would be nice to have at least a short version of this in the
commit message with a potentially longer explanation in the comments here.
--
To view, visit
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2286
to look at the new patch set (#7).
Make BTS type and variant converters shareable
* move value_string definition and corresponding functions for BTS type
to shared
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2445
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89751fc0d598734c64ef1fdced75b7c4fa77c616
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2446
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bc887f68d1963d28c6fcd631ac20ccd893d6d6
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2445
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89751fc0d598734c64ef1fdced75b7c4fa77c616
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2446
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78bc887f68d1963d28c6fcd631ac20ccd893d6d6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2446
to look at the new patch set (#2).
gsm0808: fixup length check of the element decoder functions
The length check of the decoder functions is not entirely
correct. The check also checks
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2448
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I987df905c5d64294488b5a6cdcf4306307616fc6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Review at https://gerrit.osmocom.org/2449
ofono_client: Implement network registration during connect()
Change-Id: I1db8c7cba8a83746c16e1ca45f4b8aa0d595caf8
---
M src/osmo_gsm_tester/ofono_client.py
1 file changed, 28 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/2448
gitignore: Add *.pyc
Change-Id: I987df905c5d64294488b5a6cdcf4306307616fc6
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/48/2448/1
diff --git a/.gitignore
Review at https://gerrit.osmocom.org/2447
libmsc: make pitfall in gsm0408_dispatch() more obvious
The function gsm0408_dispatch() accepts a message buffer pointer
and accesses the l3h pointer. Even in a properly allocated
message buffer, this may lead into a segfault if the user forgets
to set
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2313
to look at the new patch set (#3).
Prepare for extended SI2quater support
SI2quater support as per 3GPP TS 44.018 will require chnages to the way
System Information is
Review at https://gerrit.osmocom.org/2446
gsm0808: fixup length check of the element decoder functions
The length check of the decoder functions is not entirely
correct. The check also checks for values below zero,
which does not make sense, since the length is encoded
as uint8_t.
For some
Review at https://gerrit.osmocom.org/2445
gsm0808: fix control folow issue
Coverity Scan reported a control flow issue in line 206:
CID 166898: Control flow issues (DEADCODE)
The second branch of the if statement can not be reached. The
purpose of the second if branch was to filter out zero
Max has submitted this change and it was merged.
Change subject: Add gsm_bts_type_variant to gsm_bts struct
..
Add gsm_bts_type_variant to gsm_bts struct
Previously it was only in gsm_bts_model which is not initialized on BTS
Patch Set 3:
Not sure which comment you're referring to. Probably smth from 1582?
--
To view, visit https://gerrit.osmocom.org/1974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36c0558cdbd1790c167f290a40007b42f5de65d
Max has submitted this change and it was merged.
Change subject: osmo-bts-trx: cosmetic log fix
..
osmo-bts-trx: cosmetic log fix
Print actual value causing error and the check range.
Change-Id:
Max has submitted this change and it was merged.
Change subject: Add SW Description (de)marshalling
..
Add SW Description (de)marshalling
* data structure representing 3GPP TS 52.021 ยง9.4.62 SW Description
* function to
Max has submitted this change and it was merged.
Change subject: Save PCU version reported by BTS
..
Save PCU version reported by BTS
When BTS reports PCU disconnect - clear it.
Change-Id:
Pau Espin Pedrol has abandoned this change.
Change subject: OsmoGSMTester: fix typo in example
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2442
To unsubscribe, visit https://gerrit.osmocom.org/settings
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmux: Fix delay between RTP packets
..
osmux: Fix delay between RTP packets
AMR frame contains 160 samples at 8000Hz -> 20 ms long
Change-Id:
Patch Set 2:
not quite sure what happened to Holgers comment? Is this moving to a separate
patch?
--
To view, visit https://gerrit.osmocom.org/1974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic36c0558cdbd1790c167f290a40007b42f5de65d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1994
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec65a3490dd2a6c91f0a573aea482f3d113b0c6a
Gerrit-PatchSet: 3
Gerrit-Project: osmo-sip-connector
Gerrit-Branch:
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2166
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94db414e94a2a1f234ac6f1cb346dca1c7a8be3
Gerrit-PatchSet: 8
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2289
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb32c73036413ee912f633604150ee17b611cfa7
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 6: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2286/6/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:
Line 74:{ BTS_OSMO_SYSMO, "Sysmo" },
should be "sysmoBTS"
--
To view, visit https://gerrit.osmocom.org/2286
To
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2397
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36dc69f9caf591dd1b578bc914a2ce426c7f2813
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2294
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54fde8c4ccd5d994af08074f5864446e79a93a25
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2398
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14abe8a061d218ca81dd2d101b218d3030324aa2
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
we should introduce a test case at the same time we fix this, just to validate
the old code was wrong, the new code works, and that future versions will not
introduce regressions. It should be as straight-forward as to checking against
a valid and an invalid FR SID
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2313/2/src/common/rsl.c
File src/common/rsl.c:
Line 435: static inline void lapdm_ui_prefix(uint8_t *buf, uint32_t *valid,
const uint8_t *current, uint8_t osmo_si, uint16_t len)
might make sense to have a comment on top of the
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2312
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74e4e3cb86364cec869a1472a41b4a95af0d50dd
Gerrit-PatchSet: 8
Gerrit-Project: openbsc
Gerrit-Branch: master
35 matches
Mail list logo
