[MERGED] osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: drop double check

2017-05-09 Thread Vadim Yanitskiy
Vadim Yanitskiy has submitted this change and it was merged. Change subject: osmo-bts-trx/l1_if.c: cosmetic: drop double check .. osmo-bts-trx/l1_if.c: cosmetic: drop double check Change-Id:

osmo-bts[master]: osmo-bts-trx/l1_if.c: cosmetic: drop double check

2017-05-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2474 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a8f85ee65e1c0dd54049ffacc039702ca36c8f Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Set BTS variant while initializing BTS model

2017-05-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2520 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c49d6c39fb4dac7a46ee25ceacf4c6ef0f0b736 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-gsm-tester[master]: run dir: add a second log file containing a non-debug log

2017-05-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2512 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51b8f87abc52cc4af3672ee70045ba08334f62e Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

openbsc[vlr_3G]: examples: Change IP address of config files

2017-05-09 Thread Harald Welte
Patch Set 2: Code-Review+1 migt be useful to document the rationale/motivation in the commit log message. -- To view, visit https://gerrit.osmocom.org/2538 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

openbsc[master]: Add forgotten items to .gitignore

2017-05-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2543 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b2ec1115f6207bd238489db9317bfaee58f3bc Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: Use define for limit on number of BTS features

2017-05-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2546 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief81db0b3653fec180e60776ff9bcb0ac1357217 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openggsn[master]: contrib: Start openggsn after networking

2017-05-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: contrib: Start openggsn after networking .. contrib: Start openggsn after networking Change-Id: Ic617c618db17e7109ee864c4e6c86f3bee081d02 --- M

openggsn[master]: contrib: Start openggsn after networking

2017-05-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2547 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic617c618db17e7109ee864c4e6c86f3bee081d02 Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master

libosmocore[master]: timer: add osmo_timer_setup()

2017-05-09 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2542 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa49972ecaab3748b25168b26d92034e9145666 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Harald Welte
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2548 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3128f9768f95c1f5f955db242e71c81384c6c Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Vadim Yanitskiy
Patch Set 1: BTW: I have checked project configuration with CC=arm-elf-gcc: > ~/osmocom/libosmocore/configure --host arm-elf > [...] > checking for arm-elf-gcc... arm-elf-gcc > checking whether the C compiler works... yes > [...] > checking for TALLOC... yes > checking for PCSC... yes >

libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2548/1/m4/ax_check_simd.m4 File m4/ax_check_simd.m4: Line 44: AM_CONDITIONAL(HAVE_AVX2, false) > QEMU: Great! Odd: Why do you think so? Original macro used to check whether *both* CPU and compiler do support some set of SIMD features.

libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Holger Freyther
Patch Set 1: (1 comment) So I would merge it as a stop-gap but something doesn't seem right. :) https://gerrit.osmocom.org/#/c/2548/1/m4/ax_check_simd.m4 File m4/ax_check_simd.m4: Line 44: AM_CONDITIONAL(HAVE_AVX2, false) > All AM_CONDITIONAL expressions weren't in generic macro - QEMU:

libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Vadim Yanitskiy
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2548/1/m4/ax_check_simd.m4 File m4/ax_check_simd.m4: Line 44: AM_CONDITIONAL(HAVE_AVX2, false) > Unlikely that the generic macro needs a fix? How did you test without avx s All AM_CONDITIONAL expressions weren't in generic macro - it

osmo-trx[master]: buildenv: Split up SSE3 and SSE4.1 code

2017-05-09 Thread Vadim Yanitskiy
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2134/4/config/ax_sse.m4 File config/ax_sse.m4: PS4, Line 44: case $host_cpu in : i[[3456]]86*|x86_64*|amd64*) On some CPU architectures (e.g. ARM), which don't match this condition, both HAVE_SSE3 and

libosmocore[master]: configure.ac: add SIMD detection capabilities

2017-05-09 Thread Vadim Yanitskiy
Patch Set 6: > Fails on systems without SIMD support: > > checking whether arm-poky-linux-gnueabi-gcc -march=armv5te -marm > -mthumb-interwork > --sysroot=/home/oebuilds/jenkins/workspace/201310-nightly/label/OE/build/tmp/sysroots/sysmobts-v2 > has __builtin_cpu_supports built-in... no

[PATCH] libosmocore[master]: configure.ac: fix build on systems without SIMD support

2017-05-09 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/2548 configure.ac: fix build on systems without SIMD support HAVE_AVX2, HAVE_SSE3 and HAVE_SSE4_1 were never defined if CPU architecture doesn't match the (86*|x86_64*|amd64*) condition. Change-Id: If0c3128f9768f95c1f5f955db242e71c81384c6c --- M

[PATCH] openggsn[master]: contrib: Start openggsn after networking

2017-05-09 Thread daniel
Review at https://gerrit.osmocom.org/2547 contrib: Start openggsn after networking Change-Id: Ic617c618db17e7109ee864c4e6c86f3bee081d02 --- M contrib/openggsn.service 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/47/2547/1

[PATCH] openbsc[master]: Get basic BTS attributes

2017-05-09 Thread Max
Review at https://gerrit.osmocom.org/2544 Get basic BTS attributes Request BTS attributes via OML on connection and parse the response: * make attribute list const * expand gsm_bts-features * add sub_model to gsm_bts * request/parse incoming response as sw-config Note: only basic BTS-wide KV

osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-09 Thread Pau Espin Pedrol
Patch Set 2: (9 comments) https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/netlogger.py File src/osmo_gsm_tester/netlogger.py: Line 27: class NetLogger(log.Origin): > don't really like the name, sounds like the gsm tester would write its own Fine with change it to PcapRecorder Line

osmo-gsm-tester[master]: Log network activity using tcpdump for nitb interface

2017-05-09 Thread Neels Hofmeyr
Patch Set 2: (9 comments) https://gerrit.osmocom.org/#/c/2541/2/src/osmo_gsm_tester/netlogger.py File src/osmo_gsm_tester/netlogger.py: Line 27: class NetLogger(log.Origin): don't really like the name, sounds like the gsm tester would write its own log files to a remote host or something --

[MERGED] osmo-gsm-tester[master]: suite: Terminate processes in LIFO order

2017-05-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: suite: Terminate processes in LIFO order .. suite: Terminate processes in LIFO order Usually the first process we started is the one we want to stay

osmo-gsm-tester[master]: suite: Terminate processes in LIFO order

2017-05-09 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2540 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ea01a42af68191a659fdf8173e3fec9b1e1cfd Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] openbsc[master]: Add forgotten items to .gitignore

2017-05-09 Thread Max
Review at https://gerrit.osmocom.org/2543 Add forgotten items to .gitignore Change-Id: I04b2ec1115f6207bd238489db9317bfaee58f3bc --- M openbsc/.gitignore 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/43/2543/1 diff --git

libosmocore[master]: timer: add osmo_timer_setup()

2017-05-09 Thread Pablo Neira Ayuso
Patch Set 5: I seem to be puzzling a bit with Gerrit, still getting used to it :) -- To view, visit https://gerrit.osmocom.org/2542 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa49972ecaab3748b25168b26d92034e9145666

[PATCH] libosmocore[master]: timer: add osmo_timer_setup()

2017-05-09 Thread Pablo Neira Ayuso
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2542 to look at the new patch set (#5). timer: add osmo_timer_setup() Add a new function timer function to set up the timer, similar to what we have in the Linux kernel. This

libosmocore[master]: timer: add osmo_timer_setup()

2017-05-09 Thread Pablo Neira Ayuso
Patch Set 3: (1 comment) Sorry. I misunderstood. I'm recovering the previous version, I missed that you added Code Review+2 there. So you seem to be fine with the previous version. Thanks! https://gerrit.osmocom.org/#/c/2542/2/src/timer.c File src/timer.c: Line 73:

[MERGED] libosmocore[master]: vty: cleanup logging functions

2017-05-09 Thread Max
Max has submitted this change and it was merged. Change subject: vty: cleanup logging functions .. vty: cleanup logging functions * remove unused parameter from logging_vty_add_cmds() * mark log level descriptors static *

[MERGED] osmo-bts[master]: Prepare for extended SI2quater support

2017-05-09 Thread Max
Max has submitted this change and it was merged. Change subject: Prepare for extended SI2quater support .. Prepare for extended SI2quater support SI2quater support as per 3GPP TS 44.018 will require chnages to the way System

[MERGED] libosmocore[master]: gprs: add value strings for NS PDU type

2017-05-09 Thread Max
Max has submitted this change and it was merged. Change subject: gprs: add value strings for NS PDU type .. gprs: add value strings for NS PDU type Add value strings for Service Control PDUs according to 3GPP TS 48.016 ยง9 and

osmo-bts[master]: Name systemd service after the software

2017-05-09 Thread Pau Espin Pedrol
Patch Set 2: This needs to be coordinated with commits to OE layers to avoid breaking OE builds. I have patches available for OE repo pushed in a branch which should adapt the recipes to use new names. However, I don't have a setup available to test them. -- To view, visit