Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3000
to look at the new patch set (#2).
osmo_sock_get_name(): clearly indicate local and remote
In a string like
127.0.0.1:2905<->127.0.0.1:60661
it is hard to tell which is the local
Patch Set 1: Code-Review+1
I prefer this one.
--
To view, visit https://gerrit.osmocom.org/3001
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3e32de19fe07ed5b19ee5e67494926a511266b5
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Patch Set 1:
Another contestant for this change is https://gerrit.osmocom.org/3001 -- let
the votes decide which one wins.
--
To view, visit https://gerrit.osmocom.org/3000
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2986
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea5b88cbe9cb54702429158bf47e768e04e8fe7
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
the rationale of not changing this code is that it was inherited from the Linux
kernel, and all related whitespace changes will make it more difficult to
re-sync with a more recent kernel version of that file. So I'm a bit undecided
here...
--
To view, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2985
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1cd5b10e7beccb61f370d7f8fa2666e56542cf
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2982
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb64f497f55368e396872083237c9ff28da2dd93
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
slightly unrelated: we should probably disable the EXTRACT_STATIC part to avoid
documenting functions that users of the library cannot call anyway?
--
To view, visit https://gerrit.osmocom.org/2981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5dc22ca65740a88540dacc61c0742fede172de9c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
we've had this discussion before, and I remember not being convinced about it.
How does AUTOBRIEF decide which part is "brief" and which part is "verbose"?
--
To view, visit https://gerrit.osmocom.org/2983
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2253df3509595d7393ec6631ef846dbebae73ca4
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48b1f75179b9008d65219dd5a47c1ab3b886408
Gerrit-PatchSet: 11
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2891
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47f5a6cc88e784c5662b0dab4ddc03ce9a35132
Gerrit-PatchSet: 11
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/2831/8/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 691: int gsm0808_extrapolate_speech_codec(struct gsm0808_speech_codec *sc,
name: what about gsm0808_speech_codec_from_chan_type() ? I think current name
leaves it unclear
Patch Set 8:
(1 comment)
https://gerrit.osmocom.org/#/c/2830/8/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 653: int gsm0808_convert_to_speech_codec_type(uint8_t perm_spch)
I would call it 'gsm0808_chan_type_to_speech_codec() to make it more clear.
thanks.
--
To view, visit
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2829
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dc0165d76a022b2c1b7418bc3133407e61b7261
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: gsm0808: add speech codec type constants
..
gsm0808: add speech codec type constants
The codec type to be set in member type in struct
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: Add info about coresponding codecs to permitted
speech consts
..
cosmetic: Add info about coresponding codecs to permitted speech consts
The
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408: update bearer capability speech version
..
gsm0408: update bearer capability speech version
3GPP TS 24.008 specifies two new speech versions
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: Add codec references to Speech Version Indication
..
cosmetic: Add codec references to Speech Version Indication
Add the information which GSM
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2924
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I068ed7f7d113dab88424a9d47bab7fc703bb7942
Gerrit-PatchSet: 9
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: sccp: add addressbook functionality for sccp addresses
..
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a
Patch Set 2: Code-Review-1
I think we should drop this, avoiding any unneccessary incompatibility between
lc15 and sbts2100
--
To view, visit https://gerrit.osmocom.org/2935
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
I can confirm that the same warning appears
when compiling with clang-4.0:
warning: suggest braces around initialization
of subobject [-Wmissing-braces]
--
To view, visit https://gerrit.osmocom.org/2955
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2924
to look at the new patch set (#9).
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2924
to look at the new patch set (#8).
sccp: add addressbook functionality for sccp addresses
SCCP addresses are defined through a number of compoinents, not
just an
Patch Set 7:
(1 comment)
https://gerrit.osmocom.org/#/c/2924/7/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 1250: memcpy(ip_addr_backup,>addr.ip,sizeof(entry->addr.ip));
space, space, space. Please consider instructing your editor to do this for
you, if you don't do this
Review at https://gerrit.osmocom.org/2999
configure.ac: Use -Werror in C(PP)FLAGS
Change-Id: Ia753a3080ef54ac248dacce5cd692fdd38f7649a
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/99/2999/1
diff --git
Review at https://gerrit.osmocom.org/2998
configure.ac: Use -Wall in C(PP)FLAGS
Change-Id: I1e49427b8267bbdb05d0121971a56359dbecd690
---
M configure.ac
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/98/2998/1
diff --git
Review at https://gerrit.osmocom.org/2997
xua_test.c: remove useless keyword in struct declaration
Fixes following warning:
warning: useless storage class specifier in empty declaratio
Change-Id: I5cea7b6ec2cc755ad8cec69b771f6e3b297e607d
---
M tests/xua/xua_test.c
1 file changed, 1
Review at https://gerrit.osmocom.org/2996
stp_main.c: Add missing header
stp_main uses osmo_fsm_vty_add_cmds which is defined in /osmocom/vty/misc.h
Fixes 'implicit declaration of function' compilation warning.
Change-Id: I3cc9543fcb908eeb172d36fa472a19b01bf52c46
---
M stp/stp_main.c
1 file
Review at https://gerrit.osmocom.org/2994
sccp_test_vty: Fix compilation warning: Unused variable
Instead of removing the variable, leave it there with unused attribute
set because it is an example and gives extra information to potential
readers of the function (it provides you with the
Review at https://gerrit.osmocom.org/2993
sccp_scrc: Fix warning: uneeded constant evaulation
translate function is always present in the same file, thus we can
remove this check.
Fixes following warning:
warning: the address of ‘translate’ will always evaluate as ‘true’ [-Waddress]
if
Review at https://gerrit.osmocom.org/2992
configure.ac: Use -Werror in C(PP)FLAGS
Change-Id: Ic674bf28d781b9806dc023777e1fea4ee1a0257a
---
M configure.ac
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/92/2992/1
diff --git
Review at https://gerrit.osmocom.org/2991
configure.ac: Use -Wall in C(PP)FLAGS
Change-Id: I5033387e4a4206f7d34d1db3c6ede9255d199941
---
M configure.ac
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/91/2991/1
diff --git
Review at https://gerrit.osmocom.org/2990
osmo_ortp.c: Fix warning: use updated ortp API
Since ortp commit 5ab29c50adc7948b11449e3aeee66010379ff7dc preceeding
ortp 0.22, the API is fixed and requests a pointer instead of an
unsigned long.
As we now require at least ortp 0.22 since
Review at https://gerrit.osmocom.org/2989
osmo_ortp.c: Fix warning: implicit use of function
Explicitly state that we are using an internal API from ortp, and
define the function we are using to avoid printing a warning.
Change-Id: I9cadcb31ce7ade3632d83753be97fdc9ea518b5b
---
M
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2697/2/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 122: 'origin' a log.Origin() instance which can be sued to log
information.
To sue someone means to take them to court. Ah! It's a typo! "used" lol
Patch Set 1:
I agree with Neels' comments
--
To view, visit https://gerrit.osmocom.org/2961
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61cd83d4c8570af1e452c945ac6f194baf7e6ac4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Patch Set 4:
It's not th efirst because I was first fixing the ones I got without -Wall,
then enabled -Wall and continued fixing. Should not be any issue, the important
one is -Werror which needs to be the last one.
--
To view, visit https://gerrit.osmocom.org/2958
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2961/1//COMMIT_MSG
Commit Message:
Line 7: pseudotalloc: Add poor implementation of talloc_asprintf
better word would be "simplistic". "poor" always means bad, we don't want to
merge poor code.
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2956
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57fd3e1bf74ec24dec692710359a1ce00ecde75a
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2957
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3060cfee8ece86c4c89a65f93c9f5424df0c410b
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1e3255800999669ca9619bfceb4124c773eff2d
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c441b20b250c34656f1e8330d6bb4b1ce2b8423
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2953
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24c11226cd5bb5b6032f4ece7d1a0695dc82f0dd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2963/1/src/logging.c
File src/logging.c:
Line 850: name[j] = tolower((unsigned char)
info->cat[i].name[j]);
(usually no space in-between cast and casted value, in several places)
--
To view,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2959
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iced451be255cfde8a6cf38380bef71ef29673994
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2964
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d6cb31f38721f79e2cf93f9b8e4776f3720aa07
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 4:
I think we already have some tests disabled on FreeBSD in some project. If so,
than we can do the same here (if the tests would actually fail of course).
--
To view, visit https://gerrit.osmocom.org/2825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2938
to look at the new patch set (#6).
cosmetic: Add info about coresponding codecs to permitted speech consts
The constants in enum gsm0808_permitted_speech are not very
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2831
to look at the new patch set (#8).
gsm0808: add function gsm0808_extrapolate_speech_codec()
The contents of the speech codec element (struct gsm0808_speech_codec),
that
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2829
to look at the new patch set (#7).
gsm0808: add default speech codec configuration
In an AoIP scenario, the speech codec list field specifies the
codecs used in the RTP
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2830
to look at the new patch set (#8).
gsm0808: add function to translate perm speech to speech codec type
The permitted speech field used in channel type element (struct
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/2825/4/tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py
File tests/auc/gen_ts_55_205_test_sets/pdftxt_2_c.py:
Line 2
> since the code seems to work with python2 as well as python3, why not go fo
I remember that in an unrelated patch this
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2983
to look at the new patch set (#2).
doxygen: enable AUTOBRIEF, drop \brief
Especially for short descriptions, it is annoying to have to type \brief for
every single API doc.
Drop all
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2982
to look at the new patch set (#2).
doxygen: add missing gb API doc generation
Files in include/osmocom/gprs/ and src/gb/ are not included in any doxygen
generated API docs. Add
dexter has submitted this change and it was merged.
Change subject: vty: additional nodes for sccp-address configuration
..
vty: additional nodes for sccp-address configuration
The planned sccp-addressbook implementation in
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#11).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC headers checkout into
shared jenkins
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2974
to look at the new patch set (#5).
Use generic L1 headers helper
Change-Id: I2253df3509595d7393ec6631ef846dbebae73ca4
---
M contrib/jenkins_lc15.sh
M contrib/jenkins_oct.sh
M
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2894
to look at the new patch set (#10).
Move common steps into common jenkins helper
Move value_string termination check and OpenBSC headers checkout into
shared jenkins
Patch Set 9:
Hmm... you're right. It's weird that it doesn't cause build failure.
--
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic48b1f75179b9008d65219dd5a47c1ab3b886408
Patch Set 9: Code-Review-1
(4 comments)
Again apologies, in my last comment I didn't notice that the patches are now
independent. Still there is no way to commit the lc15 without the code undup,
which I would have liked to do now. I would accept both at this point, but
there's still a
Patch Set 9:
The patch order is also visible in top right corner of web UI in "Related
changes". I do agree though that it would be easier if gerrit would
automatically mark patches submitted together explicitly like [1/3].
--
To view, visit https://gerrit.osmocom.org/2894
To unsubscribe,
Patch Set 4:
FYI: I've created OS#2334 to track jenkins build slave package updates.
--
To view, visit https://gerrit.osmocom.org/2825
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb59b79021b2c935b326496ed339f12e13c96b8e
65 matches
Mail list logo
