Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3117
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad15a9edbfe74de3deb7298441d54fd9d0178ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
I did the same in my simplified version of scheduler for OsmocomBB.
--
To view, visit https://gerrit.osmocom.org/3116
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c2e166e6f182f703ccf49aa883c223e377c8421
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3120
to look at the new patch set (#3).
transceiver: Avoid sending clock indications when trx is not powered on
Stop calling writeClockInterface() when receiving commands in
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3048
to look at the new patch set (#5).
utils: add function gsm_fn_as_gsmtime_str()
Convert a given frame number into a printable string that displays
the sub components of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3120
to look at the new patch set (#2).
transceiver: Avoid sending clock indications when trx is not powered on
Otherwise this fools osmo-bts-trx clock skew check because it is
always
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3119
to look at the new patch set (#2).
cosmetic: transciever: Remove trailing whitespaces
Change-Id: Ib3fbe768048b2a34a75ace9688e306720e67019a
---
M Transceiver52M/Transceiver.cpp
M
Review at https://gerrit.osmocom.org/3120
transceiver: Avoid sending clock indications when trx is not powered on
Otherwise this fools osmo-bts-trx clock sanity check because it is
always sending a clock indication with the same fn when it issues any
commands during the time in between CMD
Review at https://gerrit.osmocom.org/3119
cosmetic: transciever: Remove trailing whitespaces
Change-Id: Ib3fbe768048b2a34a75ace9688e306720e67019a
---
M Transceiver52M/Transceiver.cpp
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Patch Set 1:
so should we go for this kind of patch, or should I push another version that
does it unconditionally? My preference would be to go for the latter, to have
a "sane default" configureation.
--
To view, visit https://gerrit.osmocom.org/3080
To unsubscribe, visit
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3107
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie017946b9099460ac6758ff84ec7a10df13390a1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3107
to look at the new patch set (#2).
OsmoGSMTester: use proper systemd service names
* use osmo-bts-sysmo for sysmoBTS systemd service name which is available
since
Harald Welte has submitted this change and it was merged.
Change subject: Fix annoying trailing whitespace
..
Fix annoying trailing whitespace
This whitespace keeps being automatically fixed by editor, polluting my
patches.
Harald Welte has submitted this change and it was merged.
Change subject: sysmo, litecell15: Make sure all TCH events are triggered
..
sysmo, litecell15: Make sure all TCH events are triggered
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Use L1P instead of L1C for TCH logging and allocation
..
Use L1P instead of L1C for TCH logging and allocation
L1C is for L1-Control primitives, while
Harald Welte has submitted this change and it was merged.
Change subject: octphy: complete value strings (octphy_cid_vals)
..
octphy: complete value strings (octphy_cid_vals)
The value string table octphy_cid_vals lacks the
Max has submitted this change and it was merged.
Change subject: Copy sysmopcu.service to osmo-pcu
..
Copy sysmopcu.service to osmo-pcu
This way the name of systemd service file will match the name of the
binary similar to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3106
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ca6f6c486bd6fcf4d5b3d0a05d25dc04f020c26
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3060
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib857b7dab490ad426c48d6a9e5e6fa10ef5a0838
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3104
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e608253212415bddbb4c7dcf5d3b5e79c8d28e
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3102
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6d92b1d135063dfd0a26bc23a89802cb3b1a78
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3113/1/src/hnbgw_cn.c
File src/hnbgw_cn.c:
Line 243: static bool osmo_sccp_addr_match(const struct osmo_sccp_addr *a,
const struct osmo_sccp_addr *b)
please don't introduce functions with osmo_ prefix which are not part of
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3111
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe510bf0aca5eadbc0ce6031d3026e770de6559f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3110
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd64b92b00461cace5c476c8bcf69eec3fdbbdd3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3112
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie91953f7e9033419257d556d3a9f14e125f5c60d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3109
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ac15fa2fd25bedb26297177e416976a5389b573
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3114
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a193846902a0477af0873f78283c4f2bedaf5dd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3108
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6274e3738dc04646d0dc18332c12237e6910d18
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3098
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I049f58d51333d3590361db5c0105e6899a862af6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3048/4/src/gsm/gsm_utils.c
File src/gsm/gsm_utils.c:
Line 757: static char result[256];
I think this is too large. Please do a more realistic calculaition. Without
computing, I'm sure we never even hit 128 or even 64
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3118/1/src/osmo-bts-octphy/l1_if.c
File src/osmo-bts-octphy/l1_if.c:
Line 816: static uint32_t translate_tch_meas_rep_fn104_reverse(uint32_t fn)
what about all the other cases that are != TCH/H?
--
To view, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3116
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c2e166e6f182f703ccf49aa883c223e377c8421
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3115
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib057b5e5219ad2acfaee2dcc9ade098daa9ac985
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3117
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ad15a9edbfe74de3deb7298441d54fd9d0178ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3118
octphy: remap frame number in MEAS_IND
The octasic phy stamps the SACCH channel that carries the
measurmenet indication with the frame number of the last
SACCH that falls within the measurement period.
The higher layers expect the frame number to be
dexter has submitted this change and it was merged.
Change subject: Revert "osmo-bts-sysmo: Include frame number in MEAS IND"
..
Revert "osmo-bts-sysmo: Include frame number in MEAS IND"
This reverts commit
Patch Set 8: Code-Review+1
Looks good to me, but I am not familiar with all the osmo-bts configurations.
--
To view, visit https://gerrit.osmocom.org/3008
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/3117
cosmetic: Move error goto path to the end of the function
Change-Id: I3ad15a9edbfe74de3deb7298441d54fd9d0178ad
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Review at https://gerrit.osmocom.org/3116
cosmetic: scheduler_trx.c: Add function to get rid of ugly goto path
Change-Id: I9c2e166e6f182f703ccf49aa883c223e377c8421
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 22 insertions(+), 15 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3115
cosmetic: scheduler_trx: Remove trailing whitespace
Change-Id: Ib057b5e5219ad2acfaee2dcc9ade098daa9ac985
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#8).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#7).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual
Patch Set 4: -Code-Review
--
To view, visit https://gerrit.osmocom.org/3048
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8015d2ded3940b01b35df7b72fc35c70c25e9926
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 6:
> Is it really necessary to pass $deps and $base args?
Good point, updated, thanks.
--
To view, visit https://gerrit.osmocom.org/3008
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d09c5f2693b5ac0a4d8f2c840971e13d1ec58cf
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3008
to look at the new patch set (#6).
Simplify jenkins build scripts
* move duplicated code into separate functions in jenkins_common.sh
* use that function in individual
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/3008/5/contrib/jenkins_lc15.sh
File contrib/jenkins_lc15.sh:
PS5, Line 18: "$deps" "$base"
Is it really necessary to pass $deps and $base args?
Imho the 4th line takes already care that those two are exported, so
build_bts() should be
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3100
to look at the new patch set (#2).
Move dump_gsmtime to libosmocore as osmo_dump_gsmtime
Internal l1sap dump_gsmtime has been moved to libosmocore as osmo_dump_gsmtime.
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3098
to look at the new patch set (#3).
Use osmo_dump_gsmtime to log fn across different layers
This commit also fixes a missing end of line in the log output of
48 matches
Mail list logo
