Review at https://gerrit.osmocom.org/3922
vty tests: drop testBSCreload
We are having continued problems with the testBSCreload reliability on the
jenkins builds. The trouble the test makes outweighs its benefit, so drop it.
We may want to add this test to be built on a build that is not
Review at https://gerrit.osmocom.org/3921
fix vty tests: vty no longer goes to parent node implicitly
Fix three instances of VTY tests working because it used to include implicit
'exit' commands to the parent node.
Since libosmocore change-id Id73cba2dd34676bad8a130e9c45e67a272f19588 = commit
Gerrit verification jobs as Jenkins Job Builder YAML [1] file.
[1] https://docs.openstack.org/infra/jenkins-job-builder/
Change-Id: I04387367a6e2d737bfb50423c81a8908d3c2a89f
---
A jobs/gerrit-verifications.yml
1 file changed, 273 insertions(+), 0 deletions(-)
git pull
Patch Set 1:
(1 comment)
Of course, we can remove jobs which raise questions, but they may just point
out "unwanted" deviations e.g. compiler warnings v3/v4.
Which jobs should be removed in your opinion?
https://gerrit.osmocom.org/#/c/3911/1/jobs/gerrit-verifications.yml
File
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3722
to look at the new patch set (#6).
config: Fix combination of lists
This commit fixes combination of resources containing lists.
For lists containing complex types, it
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3907
to look at the new patch set (#3).
suite: Replicate resources based on times attr before calling combine
As suite.conf and scenarios need to match 1-to-1 in lists, it's
Review at https://gerrit.osmocom.org/3920
Simplify TS alloc: use define for constant
Define and use constant for occupied TFI instead copying the same
magic number all over the place.
Change-Id: I2699ceebf0cbec01652a02fa68ccc9e9419d0293
Related: OS#2282
---
M src/bts.cpp
M src/bts.h
M
Review at https://gerrit.osmocom.org/3919
config: replicate_times: insert replicates in place
In the following suite.conf, position matters when matching against scenarios:
[suite.conf]
resources:
bts:
- type: sysmo
times: 2
- type: osmo-bts-trx
times: 1
[scenario]
resources:
Review at https://gerrit.osmocom.org/3917
resource: times is expected to be a non-zero positive integer
Change-Id: Ie9e313727053a411cec2f698c3bd654d27e8013f
---
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/schema.py
2 files changed, 8 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/3918
Move code to replicate dicts based on times attr to its own function
Change-Id: I26ddae2124813bfb63a7c97c466e056cd2ef991a
---
M src/osmo_gsm_tester/config.py
M src/osmo_gsm_tester/resource.py
2 files changed, 16 insertions(+), 10 deletions(-)
git
Review at https://gerrit.osmocom.org/3916
resource: ipa_unit_id is expected to be a positive integer
Change-Id: I26d7a4351089b73716d193496d7161bf3d9988bb
---
M src/osmo_gsm_tester/resource.py
M src/osmo_gsm_tester/schema.py
2 files changed, 8 insertions(+), 1 deletion(-)
git pull
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3722
to look at the new patch set (#4).
config: Fix combination of lists
This commit fixes combination of resources containing lists.
For lists containing complex types, it
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3723
to look at the new patch set (#6).
Add cipher cfg param for modem and bts
This parameter is contains a list of supported encryption ciphers by the
modem or bts setting
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3907
to look at the new patch set (#2).
suite: Replicate resources based on times attr before calling combine
As suite.conf and scenarios need to match 1-to-1 in lists, it's
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3731
to look at the new patch set (#5).
Reserve ARFCN dynamically based on BTS band support
Instead of statically specifying a band for a BTS to use, declare a list
of
Patch Set 2:
>
> Play around with it to see if it cures the neverending loop there.
Seeing your comment after I pushed last patch set..
Hmm. How could it cure the loop? You need to give up at some point if all
possibilities are exhausted, no?
--
To view, visit
Patch Set 2:
> Build Failed
>
> http://jenkins.osmocom.org/jenkins/job/OpenBSC-gerrit/2457/ :
> FAILURE
Hmm that's annoying. must be a different libdbi or sqlite? string was the only
type I could ask libdbi for that didn't give me this error.
--
To view, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3910
to look at the new patch set (#2).
libmsc: db_subscriber_alloc_exten() remove infinite loop
This is not right, but at least it prevents entering an
infinite loop in the case that you
Patch Set 1:
(1 comment)
I think it would be easier to introduce this gradually - for example first add
all the jobs which do not raise questions, make sure it works as expected and
than add the remaining one, clarifying stuff on a case-by-case basis.
Patch Set 2:
(1 comment)
I guess we agree that removing that sleep() can be done more in the future and
doesn't belong to this patch.
https://gerrit.osmocom.org/#/c/3901/1/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 524:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Use tmpdir to create bts pcu-socket
..
Use tmpdir to create bts pcu-socket
In commit 329b6f4 pcu-socket path was moved to run inside the test run
Patch Set 1:
I see... it's from the VTY itself that hangs with a valid configuration.
Would you send a v2 of this patch that does something like this?
... extension_alloc(...)
{
range = max - min;
extension = min + (rand() % range);
return extension
}
Then:
if extension is
Patch Set 1:
I see... it's from the VTY itself that hangs with a valid configuration.
Would you send a v2 of this patch that does something like this?
... extension_alloc(...)
{
range = max - min;
extension = min + (rand() % range);
return extension
}
Then:
if extension is
Review at https://gerrit.osmocom.org/3915
Expand bit pretty-printer
Add OSMO_BIT_PRINT_EX() which is like OSMO_BIT_PRINT() but allows to
specify character to be printed for set bits. It's useful to print bytes
used as mask where set bit has particular semantics - for example TS
mask in
Review at https://gerrit.osmocom.org/3914
Simplify TS alloc: cosmetic, use proper format
The find_multi_slots() function has 4 nested for(;;) loops but it's
formatted as one. Before trying to split this into smth saner, let's
first fix code formatting to make nested loops obvious. Also, fix
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#13).
Simplify TS alloc: improve readability
* consistently format log messages to make it possible to grep for test
output in source
Patch Set 1:
> > (1 comment)
>
> sqlite> select count(*) from subscriber;
> count(*)
> --
> 21024
>
I guess (smax - smin) - the_above_result is your max_i in the loop at which
point you should bale?
--
To view, visit https://gerrit.osmocom.org/3910
To unsubscribe, visit
Patch Set 1:
> (1 comment)
I dunno.. I just came across this as I was taking a quick look at the failing
vty tests. I configured
subscriber-create-on-demand random 1 10010
and noticed the hang.
Here's a busy rhizomatica site:
sqlite> select count(*) from subscriber;
count(*)
Patch Set 3: Code-Review+1
I think we are still not exactly fixing 1st point of commit description
according to what I understand from snprintf specs. My interpretation from
snprintf manual is that if an error is returned, the behavior is unexpected,
meaning an implementation of snprintf
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3910/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:
Line 1419: try = (rand() % (smax - smin + 1) + smin);
Why don't we better update this code to use something better than a random
function? To keep it simple,
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3807
to look at the new patch set (#7).
Simplify TS alloc: adjust allocator signatures
* drop unused parameters (from both functions and structs)
* document used parameters
Review at https://gerrit.osmocom.org/3912
Simplify TS alloc: adjust function signatures
* document used parameters and return values
* use consistent formatting
* constify function parameters where appropriate (adjusting parameter
types if necessary)
Tests are adjusted accordingly but test
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3830
to look at the new patch set (#3).
src: _snprintf() helper functions nul-terminate buffers, if possible
This patch inconditionally initializes the buffer we get to
André Boddenberg has abandoned this change.
Change subject: Make use of osmo-build.sh, which introduces dependency
artifacts.
..
Abandoned
Already outdated as we will probably move to docker builds in tmpfs.
--
To view,
Review at https://gerrit.osmocom.org/3911
Gerrit verification jobs as Jenkins Job Builder YAML [1] file.
[1] https://docs.openstack.org/infra/jenkins-job-builder/
Change-Id: I04387367a6e2d737bfb50423c81a8908d3c2a89f
---
A jobs/gerrit-verifications.yml
1 file changed, 288 insertions(+), 0
Patch Set 2:
(1 comment)
Sorry for keeping you busy with this, I'm just pointing out possibilities of
crash I see in the code though. If you don't want to invest more time on these
then just write the requirements for each parameter in documentation of the
function, and it can be fixed later
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3909
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29270652957f58093be8bf7f2e898b0b4933bd93
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Hello Pau Espin Pedrol, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3830
to look at the new patch set (#2).
src: _snprintf() helper functions always nul-terminate buffers
This patch inconditionally initializes the buffer we get to
Patch Set 1:
> Uploaded patch set 1.
How should this be done? If we don't go sequentially, how many times to try a
random extension before we give up?
--
To view, visit https://gerrit.osmocom.org/3910
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/3910
libmsc: db_subscriber_alloc_exten() remove infinite loop
This is not right, but at least it prevents entering an
infinite loop in the case that you actually have exhasuted
all available extensions.
Change-Id: Icf0f1e5a7f360bc27592a55890f74a9a12bc9f42
Max has submitted this change and it was merged.
Change subject: TS alloc: properly count UL slots
..
TS alloc: properly count UL slots
Add cycle to mark multiple allocated UL slots similar to the way we
count DL slots in
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3760
to look at the new patch set (#11).
Simplify TS alloc: re-arrange code
* consistently format log messages to make it possible to grep for test
output in source code
*
Review at https://gerrit.osmocom.org/3909
libmsc: Log Rx DELIVER-SM RESP before calling gsm411_send_rp_ack
This patch just makes the log match chronologically what
is happening. We receive the deliver_sm_resp before we send
the RP ACK to the MS.
Change-Id:
43 matches
Mail list logo
