Patch Set 3: Code-Review-1
The Alloctest change still seems to require an update... As I said on the
mailinglist. I want to get this patch in first. So it is blocking everything
else.
--
To view, visit https://gerrit.osmocom.org/4072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/xUbuntu_16.04/x86_64
Package network:osmocom:latest/libosmocore failed to build in
xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:latest libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/armv7l
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/aarch64
Package network:osmocom:nightly/libosmocore failed to build in
Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build
Review at https://gerrit.osmocom.org/4672
vty: Fix bad use of vector_slot()
Commit in e9e9e427b78271941a25a63567fc2ec2bb9e4433 attempted to fix a
compilation warning but introduced a regression documented in OS#2613.
The commit was reverted in 4aa0258269296f078e685e21fb08b115567e814.
After
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4598
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a408f9e651c5fb3424a84ceaaa603e20ad595c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: make dummy packet handling more explicit
..
cosmetic: make dummy packet handling more explicit
The way how osmo-mgw decides when to send a
Harald Welte has submitted this change and it was merged.
Change subject: network: autdetect rtp bind ip-address
..
network: autdetect rtp bind ip-address
Currently there are two ways to set the rtp bind ip-address (local
ip
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4593
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77866ce65acf524b768882c751a4f9c0635740b
Gerrit-PatchSet: 9
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Enable GnuTLS fallback
..
Enable GnuTLS fallback
On systems with GNU/Linux kernel older than 3.17 (Debian 8 "jessie" for
example) the osmo_get_rand_id()
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4657
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb811bc984c8d576984b038b391cf8130cc465e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4658
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132bf7681a1a435c161c4048e41c28dc75c1fa28
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4659
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I384ec8cd55cfaa68ee1f461de99ceac78c5d8414
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4655
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66bbcd028f03290797c2c467271d0f0982698b47
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4656
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5dbc3b4689b282db6fae4668e2838be59e88da8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4653
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7978c7e96c8f1d43837271c94dd64893649974e0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4652
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id803eca3791137b04bc24d195119d5c511fcfc49
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4651
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I893beb114d47edd3f67183dd9ea5acc19462496c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4654
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice37093dc9f8e03a2a9f5e3f7df79d1b589b6991
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Bump version: 0.10.1 → 0.10.2
..
Bump version: 0.10.1 → 0.10.2
Change-Id: I88c0d0327fb022b0626ab0feff3f34468b122d4b
---
M debian/changelog
1 file
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4671
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c0d0327fb022b0626ab0feff3f34468b122d4b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4671
Bump version: 0.10.1 → 0.10.2
Change-Id: I88c0d0327fb022b0626ab0feff3f34468b122d4b
---
M debian/changelog
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/4671/1
diff --git
Review at https://gerrit.osmocom.org/4667
OsmoGSMTester: Add scenarios_dir section
It explains how scenario combination works
Change-Id: I3f89bd3d71400da14cda7ea8bb9c190fe80a539f
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 34 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4669
OsmoGSMTester: Add state_dir section
Change-Id: Ie12e3933747a4e698de59ff9ac57281e9f261d3d
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4666
OsmoGSMTester: Improve Trial section content
Change-Id: I8d74b02166ea33ad9ab7f987894f4f02064fbebc
---
M OsmoGSMTester/chapters/trial.adoc
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4668
OsmoGSMTester: Add suites_dir section
Change-Id: Ie25fd742f484981f5e5b25397c2637eda38f0424
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4670
OsmoGsmTester: Put several permission categories under cat User Permission
Change-Id: Ie9f846af0311d768c5dd6f9da572c8f6482f4d39
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4662
OsmoGSMTester: Document how to setup main unit to set CAP_NET_RAW as
non-root
Change-Id: I011beaa929efcabe9a9dc4f9c7222ba36fa2aae4
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 30 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4664
OsmoGSMTester: Remove resolved TODO
Change-Id: Ie0f18293e566a690d2434d08cbaaf2fdf71d88e4
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4663
OsmoGSMTester: Update resources cfg documentation
Change-Id: I6ec9fc5468ce6ead52d9c8b35d8991cac4bfa97e
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 38 insertions(+), 11 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4665
OsmoGSMTester: Update defaults.conf example
Change-Id: If12df88b4088ecec6d6cb20c83a693c019b8af4a
---
M OsmoGSMTester/chapters/config.adoc
1 file changed, 31 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4651
OsmoGSMTester: Improve setup graph
* Add sysmocell5000
* Remove 1 modem, showing 2 of them is enough
* Split osmo-bts-trx from osmo-trx node as sysmocell500 doesn't use the
later.
* Update OsmoNITB node to show we also support split openbsc.git
Review at https://gerrit.osmocom.org/4658
OSmoGsmTester: Specify group in Main unit intro
Change-Id: I132bf7681a1a435c161c4048e41c28dc75c1fa28
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/4660
OsmoGSMTester: Installation: change some confusing terminology
It's difficult to understand when it referrs to jenkins job in general
and when it talks about specific jenkins jobs that builds binaries required for
osmo-gsm-tester and the ones which run
Review at https://gerrit.osmocom.org/4655
OsmoGSMTester: Use a more up-to-date resources.conf example
It showcases new features such as osmo-trx support, cipher support,
modem features support, etc.
Change-Id: I66bbcd028f03290797c2c467271d0f0982698b47
---
M OsmoGSMTester/chapters/intro.adoc
1
Review at https://gerrit.osmocom.org/4657
OsmoGSMTester: Explain patchelf is used sometimes to modify RPATH
Change-Id: I7bb811bc984c8d576984b038b391cf8130cc465e
---
M OsmoGSMTester/chapters/intro.adoc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/4661
OsmoGSMTester: Move TODO comment to a redmine task
Following task has been created: OS#2612
Change-Id: I79837e49f3e6af4254e9f0c7f53037eae66cda6d
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 0 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4659
OsmoGSMTester: Add deps required for osmo-bts-octphy support
Change-Id: I384ec8cd55cfaa68ee1f461de99ceac78c5d8414
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 3 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4652
OsmoGSMTester: Update trial graph with current data
The osmo-bts-trx tgz doesn't exist anymore and it does not contain
osmo-trx, which comes in its own tgz.
Change-Id: Id803eca3791137b04bc24d195119d5c511fcfc49
---
M OsmoGSMTester/chapters/intro.adoc
1
Review at https://gerrit.osmocom.org/4656
OsmoGSMTester: Update suite.conf example
This is the one we are usig nowadays in suite.conf, which explicitly
asks to be run with modems supporting sms features.
Change-Id: If5dbc3b4689b282db6fae4668e2838be59e88da8
---
M
Review at https://gerrit.osmocom.org/4653
OsmoGSMTester: Update sample test script with an AoIP example
Change-Id: I7978c7e96c8f1d43837271c94dd64893649974e0
---
M OsmoGSMTester/chapters/intro.adoc
1 file changed, 23 insertions(+), 11 deletions(-)
git pull
Review at https://gerrit.osmocom.org/4654
OsmoGSMTester: Improve Resource Resolution section content
Change-Id: Ice37093dc9f8e03a2a9f5e3f7df79d1b589b6991
---
M OsmoGSMTester/chapters/intro.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
Max has submitted this change and it was merged.
Change subject: Check OML state per-BTS
..
Check OML state per-BTS
To properly decide if a given OML link is degraded we have to use
BTS-specific information about MO state.
*
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4649
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc7a4d20fbb95a6566eed1487a12733e5adb9e2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4650
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia57cf7dab8421fd3ab6e1515727db0080373485e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4650
network: autdetect rtp bind ip-address
Currently there are two ways to set the rtp bind ip-address (local
ip address where the rtp streams are bound to). It is possible to
set no set an rtp bind ip, if none no address is configured, then
the ip address
Review at https://gerrit.osmocom.org/4649
Check OML state per-BTS
To properly decide if a given OML link is degraded we have to use
BTS-specific information about MO state.
* move check function into BTS-specific part
* add generic wrapper
Related: OS#2486
Change-Id:
Max has submitted this change and it was merged.
Change subject: OsmoBSC: update CTRL docs
..
OsmoBSC: update CTRL docs
* use proper naming scheme for BTS-specific CTRL commands
* add/update oml-* commands
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: mobile/main.c: fix deprecated call to msgb_set_talloc_ctx()
..
mobile/main.c: fix deprecated call to msgb_set_talloc_ctx()
The usage of
Harald Welte has submitted this change and it was merged.
Change subject: mobile/vty_interface.c: add missing 'vty/misc.h' header
..
mobile/vty_interface.c: add missing 'vty/misc.h' header
This header contains declaration of
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4617
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7ee9409baec50a09fb357d655b5253434fae924
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: correct whitespaces
..
cosmetic: correct whitespaces
Change-Id: I22302ae8a48a2c776025a60267f5ef5af706e576
---
M src/libosmo-mgcp/mgcp_sdp.c
1
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix commenting style
..
cosmetic: fix commenting style
Change-Id: Ib717d9dd3b17250ef4d6c67be0463a407cb83fbe
---
M src/libosmo-mgcp/mgcp_sdp.c
Harald Welte has submitted this change and it was merged.
Change subject: client: fix stderror logging in unit-test
..
client: fix stderror logging in unit-test
When testing the file name and the line numbers are output to
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix coding style for mgcp_parse_sdp_data()
..
cosmetic: fix coding style for mgcp_parse_sdp_data()
move variable declaration to the top
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: rename bts_codec to codec_str
..
cosmetic: rename bts_codec to codec_str
make variable name more meaningful
e enter the commit message for
Harald Welte has submitted this change and it was merged.
Change subject: client: add ip address parsing to the client
..
client: add ip address parsing to the client
Some MGCP messages (CRCX, MDCX) return IP-Addresses. Make
Harald Welte has submitted this change and it was merged.
Change subject: protocol: allow wildcarded DLCX
..
protocol: allow wildcarded DLCX
In many cases it is simpler to instruct the mgcp-gw to drop all
connections at once
Harald Welte has submitted this change and it was merged.
Change subject: client: add unified function to generate MGCP messages
..
client: add unified function to generate MGCP messages
currently the only way to generate MGCP
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: remove port/timeslot calculator functions from mgcp.h
..
mgcp: remove port/timeslot calculator functions from mgcp.h
the functions
Harald Welte has submitted this change and it was merged.
Change subject: sdp: refactoring sdp parser/generator
..
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to
Harald Welte has submitted this change and it was merged.
Change subject: network: add separate log category
..
network: add separate log category
the network (mgcp_network.c) part and the protocol part
(mgcp_protoocl.c) share
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4006
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324
Gerrit-PatchSet: 16
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Fix typo in .deb dependency
..
Fix typo in .deb dependency
Change-Id: Ie6b8770febebcd280e86725dffb5cb86046baeb5
---
M debian/control
1 file changed, 1
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4647
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b8770febebcd280e86725dffb5cb86046baeb5
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4646
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2edf64348502cbe498d9fd27a686c712b044c926
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4648
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b2cd940b4d84c140fce871f236aeab091b27360
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Review at https://gerrit.osmocom.org/4648
OsmoBSC: update CTRL docs
* use proper naming scheme for BTS-specific CTRL commands
* add/update oml-* commands
Change-Id: I5b2cd940b4d84c140fce871f236aeab091b27360
Related: OS#2486
---
M OsmoBSC/chapters/control.adoc
1 file changed, 14 insertions(+),
Review at https://gerrit.osmocom.org/4647
Fix typo in .deb dependency
Change-Id: Ie6b8770febebcd280e86725dffb5cb86046baeb5
---
M debian/control
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/47/4647/1
diff --git
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4617
to look at the new patch set (#3).
cosmetic: make dummy packet handling more explicit
The way how osmo-mgw decides when to send a dummy packet and
when not
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#16).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to
Patch Set 9:
OS#2610 is created to track optimization suggestion.
--
To view, visit https://gerrit.osmocom.org/4593
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77866ce65acf524b768882c751a4f9c0635740b
Gerrit-PatchSet: 9
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4593
to look at the new patch set (#9).
Enable GnuTLS fallback
On systems with GNU/Linux kernel older than 3.17 (Debian 8 "jessie" for
example) the osmo_get_rand_id() would
Review at https://gerrit.osmocom.org/4646
Fix build with default paths
If LIBOSMO_DIR is not set explicitly than ~/source/gsm/libosmocore is
used which is base for MERGE_DOC which is used by
vty_reference_combine.sh as it is. If the shell used by
vty_reference_combine.sh does not expand ~ than
Patch Set 8: Code-Review+2
(1 comment)
I'm happy to merge it, but my original review comments about using a static
variable to cache whether the syscall works has not been implemented. Please
follow up with that in a later patch (or create a ticket as a reminder for this
optimization)
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/4446/3/src/osmo-bts-octphy/main.c
File src/osmo-bts-octphy/main.c:
Line 58:return 0;
I think if you introduce bts-specific command line options, you should also
document them in the --help output.
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c415deb85187feb42fb6d24cc86273eb722936
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id867ffed9b2b67025320d002e1e009e19c759a23
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4643
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I58150e9b74699e5f54b9a83416ad8efcb2eccd8e
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4640
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55e43eaaebdd9fe0d74a030b1057ae82804a77e
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdafb22758897cfb67e249f37991f4af4213a5fa
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4639
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56440d8e2152c4bb2e5ad677f88c61742d2ad9ca
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4642
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4499b592a0dfea71462aed19fe641419d79b3cbd
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1:
(1 comment)
If I interpret the code correctly it's impossible for 'value' to be negative at
this point. So it's just to get rid of compile warning? If so than you could,
perhaps, use size_t instead of int for 'value' type: that's what memset expects
anyway.
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4644/1/src/host/layer23/src/mobile/gsm411_sms.c
File src/host/layer23/src/mobile/gsm411_sms.c:
Line 238: /* uint8_t sms_mms = !!(*smsp & 0x04); */
Why keeping it? If it's not used anywhere than it should be simply removed.
--
To
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4640
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55e43eaaebdd9fe0d74a030b1057ae82804a77e
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4641/1/src/host/layer23/src/mobile/gsm480_ss.c
File src/host/layer23/src/mobile/gsm480_ss.c:
Line 205: if (response[i] == '\r')
That doesn't seem to be related to change to secure functions. And it also
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4639
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56440d8e2152c4bb2e5ad677f88c61742d2ad9ca
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdafb22758897cfb67e249f37991f4af4213a5fa
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/4640
mobile/vty_interface.c: fix incompatible pointer type warning
According to the vty_app_info struct definition, the go_parent_cb()
should return an integer, but not enum. So, this change fixes the
following compiler warning:
> warning: initialization
1 - 100 of 108 matches
Mail list logo
