osmo-mgw[master]: mgcp_test: test_no_cycle: sanitize: free endp

2017-11-21 Thread Holger Freyther
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4919 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78d16ffc435c0f967fe99c6e38dde829b6fa0dc9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-mgw Gerrit-Branch: master

osmo-iuh[master]: ranap_msg_factory: sanitize: memcpy instead of unaligned int...

2017-11-21 Thread Holger Freyther
Patch Set 3: > > Why not use osmo_load32be()? > > it's the other way round, writing *to* a buffer. ah there's > osmo_store32be() ... but ntohl() highlights the network byte order > in a way store32be doesn't..? Yes the otherway around. But what was the conclusion on the ntohl here? -- To

osmo-iuh[master]: tests: sanitize: fix mem leaks, clean after tests

2017-11-21 Thread Holger Freyther
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4916 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic66c005f2a264774e18bb54e58b87bef5944511c Gerrit-PatchSet: 4 Gerrit-Project: osmo-iuh Gerrit-Branch: master

[ABANDON] osmo-bsc[master]: NOT FOR MERGE: testing gerrit build with V=1

2017-11-21 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: NOT FOR MERGE: testing gerrit build with V=1 .. Abandoned -- To view, visit https://gerrit.osmocom.org/4950 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] libosmocore[master]: NOT FOR MERGE: test gerrit sanitizer build

2017-11-21 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: NOT FOR MERGE: test gerrit sanitizer build .. Abandoned -- To view, visit https://gerrit.osmocom.org/4858 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] osmo-iuh[master]: NOT FOR MERGE -- test build on deb9 build slave

2017-11-21 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: NOT FOR MERGE -- test build on deb9 build slave .. Abandoned -- To view, visit https://gerrit.osmocom.org/4921 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-iuh[master]: tests: sanitize: fix mem leaks, clean after tests

2017-11-21 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4916 to look at the new patch set (#4). tests: sanitize: fix mem leaks, clean after tests Fix various mem leaks in the testing code. Add

[PATCH] osmo-iuh[master]: test_common: fix compiler warning: include ranap_common.h

2017-11-21 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/4962 test_common: fix compiler warning: include ranap_common.h test_common.c:85:2: warning: implicit declaration of function ‘ranap_set_log_area’ Change-Id: Ice192e1f7f1bdafe0941160f43e573349aaceb75 --- M src/tests/test_common.c 1 file changed, 2

osmo-iuh[master]: ranap_msg_factory: sanitize: memcpy instead of unaligned int...

2017-11-21 Thread Neels Hofmeyr
Patch Set 2: > Why not use osmo_load32be()? it's the other way round, writing *to* a buffer. ah there's osmo_store32be() ... but ntohl() highlights the network byte order in a way store32be doesn't..? -- To view, visit https://gerrit.osmocom.org/4928 To unsubscribe, visit

osmo-mgw[master]: osmo-mgw: Use libosmocore socket abstraction

2017-11-21 Thread Neels Hofmeyr
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/4900/3/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: Line 301: perror("Gateway failed to bind"); (this error reporting is different from the others... even though the patch is adopting the previous

osmo-bsc[master]: use _NUM_CHREQ_T to define the size of ctype_by_chreq

2017-11-21 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4947 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-mgw[master]: mgcp_test: test_no_cycle: sanitize: free endp

2017-11-21 Thread Neels Hofmeyr
Hello Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4919 to look at the new patch set (#2). mgcp_test: test_no_cycle: sanitize: free endp Release endpoint to avoid sanitizer errors. Change-Id:

[MERGED] libosmocore[master]: osmo_strlcpy: sanitize: don't memcpy from NULL src even if l...

2017-11-21 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: osmo_strlcpy: sanitize: don't memcpy from NULL src even if len is 0 .. osmo_strlcpy: sanitize: don't memcpy from NULL src even if len is 0 Some

[PATCH] osmo-pcu[master]: Replace '.' in counter names with ':'

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4961 Replace '.' in counter names with ':' The '.' is an illegal character in counter names, as they are exported via CTRL interface, where '.' has a special meaning that cannot be used by strings comprising the variable name. Change-Id:

[MERGED] osmo-iuh[master]: sccp_sap_up(): Fix never-hit "default" case in switch

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sccp_sap_up(): Fix never-hit "default" case in switch .. sccp_sap_up(): Fix never-hit "default" case in switch As the default was called "defualt", it

[MERGED] osmo-iuh[master]: Add "-Wall" to the compile rules of the non-asn1c-generated ...

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Add "-Wall" to the compile rules of the non-asn1c-generated source code .. Add "-Wall" to the compile rules of the non-asn1c-generated source code This

[MERGED] osmo-iuh[master]: hnbgw.c: Remove dead code creating libsctp linker dependency

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: hnbgw.c: Remove dead code creating libsctp linker dependency .. hnbgw.c: Remove dead code creating libsctp linker dependency Since

[MERGED] osmo-iuh[master]: Fix various compiler warnings in hnb-gw code

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix various compiler warnings in hnb-gw code .. Fix various compiler warnings in hnb-gw code Since we finally started to use -Wall, the related warnings

[MERGED] osmo-hlr[master]: db_test: don't verify SQLite issued error messages, they mig...

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: db_test: don't verify SQLite issued error messages, they might change .. db_test: don't verify SQLite issued error messages, they might change A user

osmo-hlr[master]: db_test: don't verify SQLite issued error messages, they mig...

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4948 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2513d71cc0072aef8d08f47d0a1959f311176229 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

[MERGED] osmo-ci[master]: osmocom-latest-packages: introduce $TOP dir variable

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-latest-packages: introduce $TOP dir variable .. osmocom-latest-packages: introduce $TOP dir variable Using a $TOP variable makes directory paths

[MERGED] osmo-ci[master]: osmocom-latest-packages: fix shellcheck warnings

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-latest-packages: fix shellcheck warnings .. osmocom-latest-packages: fix shellcheck warnings Change-Id:

[MERGED] osmo-bsc[master]: bsc_init: fix Werror: define rc for 2quater with si2q_count ...

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_init: fix Werror: define rc for 2quater with si2q_count == 0 .. bsc_init: fix Werror: define rc for 2quater with si2q_count == 0

[MERGED] osmo-ci[master]: osmocom-latest-packages: set -e: exit on any failure

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-latest-packages: set -e: exit on any failure .. osmocom-latest-packages: set -e: exit on any failure Change-Id:

osmo-ci[master]: osmocom-latest-packages: only publish source tar balls if a ...

2017-11-21 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4954 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife10c9819e5971b001c5be9d313781eb3fd19e23 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-bsc[master]: bsc_init: fix Werror: define rc for 2quater with si2q_count ...

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4949 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedad1efcb477c77db8c741777ea076761658c7d1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: fix shellcheck warnings

2017-11-21 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4953 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1733658ce9b3de595b6087a58da0cb8c8bcf928f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: introduce $TOP dir variable

2017-11-21 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4952 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a87532a3232fbcfb5f676588991dbc59a34f739 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-ci[master]: osmocom-latest-packages: only publish source tar balls if a ...

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-latest-packages: only publish source tar balls if a new tag was created .. osmocom-latest-packages: only publish source tar balls if a new tag

osmo-ci[master]: osmocom-latest-packages: only publish source tar balls if a ...

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4954 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife10c9819e5971b001c5be9d313781eb3fd19e23 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: set -e: exit on any failure

2017-11-21 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/4951 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dbf32a731d01b6eba933b8af22500c5edd1502d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: fix shellcheck warnings

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4953 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1733658ce9b3de595b6087a58da0cb8c8bcf928f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: introduce $TOP dir variable

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4952 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a87532a3232fbcfb5f676588991dbc59a34f739 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: set -e: exit on any failure

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4951 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dbf32a731d01b6eba933b8af22500c5edd1502d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

libosmocore[master]: osmo_strlcpy: sanitize: don't memcpy from NULL src even if l...

2017-11-21 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4940 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883048cf2807e606c6481634dbd569fc12aed889 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-msc[master]: libmsc/vty: don't access old bsc rate counters

2017-11-21 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4959 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c72ab8bf781d3f9a436eb1a27ac4d13df5e656b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmo-abis[master]: unixsocket: fix a potential string overflow

2017-11-21 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4213 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80 Gerrit-PatchSet: 2 Gerrit-Project: libosmo-abis Gerrit-Branch: master

[MERGED] libosmo-abis[master]: unixsocket: fix a potential string overflow

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: unixsocket: fix a potential string overflow .. unixsocket: fix a potential string overflow Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80

[MERGED] osmo-msc[master]: libmsc/vty: don't access old bsc rate counters

2017-11-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc/vty: don't access old bsc rate counters .. libmsc/vty: don't access old bsc rate counters The BSC rate counters are a leftover from the nitb

osmo-iuh[master]: tests: sanitize: clean after tests

2017-11-21 Thread Harald Welte
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4916 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic66c005f2a264774e18bb54e58b87bef5944511c Gerrit-PatchSet: 3 Gerrit-Project: osmo-iuh Gerrit-Branch: master

osmo-msc[master]: libmsc/vty: don't access old bsc rate counters

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4959 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c72ab8bf781d3f9a436eb1a27ac4d13df5e656b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-pcu[master]: AllocTest: adjust test_alloc_b()

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4960 AllocTest: adjust test_alloc_b() This function contains 3 independent test cases. Let's split them into separate functions to simplify further modifications: * split test cases into separate functions * use them for mass test as well * change function

[PATCH] osmo-pcu[master]: Add multislot classes from latest spec

2017-11-21 Thread Max
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4072 to look at the new patch set (#5). Add multislot classes from latest spec The table B.1 is copy-pasted from 3GPP TS 45.002 and reformatted via Emacs

[PATCH] osmo-msc[master]: libmsc/vty: don't access old bsc rate counters

2017-11-21 Thread lynxis lazus
Review at https://gerrit.osmocom.org/4959 libmsc/vty: don't access old bsc rate counters The BSC rate counters are a leftover from the nitb split. Accessing them would result into a null-pointer exception, because the struct isn't initialized. Change-Id:

osmo-pcu[master]: AllocTest: remove assumption on max MS class

2017-11-21 Thread Holger Freyther
Patch Set 1: Code-Review-1 (3 comments) Well. There are more assumptions in this code.. I pointed to two.. there is probably another one... https://gerrit.osmocom.org/#/c/4958/1/tests/alloc/AllocTest.cpp File tests/alloc/AllocTest.cpp: Line 444: for (int ms_class = 0; ms_class < 30;

libosmocore[master]: osmo_strlcpy: sanitize: don't memcpy from NULL src even if l...

2017-11-21 Thread Max
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4940 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883048cf2807e606c6481634dbd569fc12aed889 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: introduce $TOP dir variable

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4952 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a87532a3232fbcfb5f676588991dbc59a34f739 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: set -e: exit on any failure

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4951 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dbf32a731d01b6eba933b8af22500c5edd1502d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: osmocom-latest-packages: fix shellcheck warnings

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4953 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1733658ce9b3de595b6087a58da0cb8c8bcf928f Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-bsc[master]: bsc_init: fix Werror: define rc for 2quater with si2q_count ...

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4949 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedad1efcb477c77db8c741777ea076761658c7d1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-pcu[master]: Add multislot classes from latest spec

2017-11-21 Thread Max
Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4072 to look at the new patch set (#4). Add multislot classes from latest spec The table B.1 is copy-pasted from 3GPP TS 45.002 and reformatted via Emacs

[PATCH] osmo-pcu[master]: Clarify alloc tests

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4956 Clarify alloc tests * add wrapper for single-class tests * rename top-level function to avoid confusion * reformat to improve readability * drop confusing wrapper Change-Id: I3feeb92237ffb9557ac6998540b740f1f67186b3 Related: OS#2282 --- M

[PATCH] osmo-pcu[master]: Add function to get max supported MS class

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4955 Add function to get max supported MS class It's useful for allocation tests. Change-Id: I31d503af700ec3364042ff7e661710953cacf9f8 Related: OS#2282 --- M src/mslot_class.c M src/mslot_class.h 2 files changed, 6 insertions(+), 0 deletions(-) git

[PATCH] osmo-pcu[master]: AllocTest: remove assumption on max MS class

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4958 AllocTest: remove assumption on max MS class So far the allocation was only tested up to hardcoded MS class 29. Drop that assumption and test for all supported MS classes. Adjust expected test output as necessary. Change-Id:

[PATCH] osmo-pcu[master]: Add tests for find_multi_slots()

2017-11-21 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4636 to look at the new patch set (#2). Add tests for find_multi_slots() * make function public * add tests Change-Id: I4174703808335c19341cd5b5f4422496d958967f --- M src/gprs_rlcmac.h M

[PATCH] osmo-pcu[master]: AllocTest: expand test output

2017-11-21 Thread Max
Review at https://gerrit.osmocom.org/4957 AllocTest: expand test output * print MS classes * unify test mode description * print additional info on test completion Change-Id: I30a4b8f561a9677f4e9ded33a051a249bd15a6a2 Related: OS#2282 --- M tests/alloc/AllocTest.cpp M tests/alloc/AllocTest.ok

[PATCH] osmo-bsc[master]: bsc_init: fix Werror: define rc for 2quater with si2q_count ...

2017-11-21 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/4949 bsc_init: fix Werror: define rc for 2quater with si2q_count == 0 src/libbsc/bsc_init.c: In function ‘rsl_si’: src/libbsc/bsc_init.c:153:2: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] return rc; ^

[PATCH] osmo-ci[master]: osmocom-latest-packages: only publish source tar balls if a ...

2017-11-21 Thread lynxis lazus
Review at https://gerrit.osmocom.org/4954 osmocom-latest-packages: only publish source tar balls if a new tag was created OBS should only be updated if there is a new tag. Change-Id: Ife10c9819e5971b001c5be9d313781eb3fd19e23 --- M scripts/osmocom-latest-packages.sh 1 file changed, 27

[PATCH] osmo-bsc[master]: NOT FOR MERGE: testing gerrit build with V=1

2017-11-21 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/4950 NOT FOR MERGE: testing gerrit build with V=1 Change-Id: I48f65170cfd2319ffe19b12cfa01a70e7b8e779a --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/4950/1 diff

[PATCH] osmo-ci[master]: osmocom-latest-packages: set -e: exit on any failure

2017-11-21 Thread lynxis lazus
Review at https://gerrit.osmocom.org/4951 osmocom-latest-packages: set -e: exit on any failure Change-Id: I8dbf32a731d01b6eba933b8af22500c5edd1502d --- M scripts/osmocom-latest-packages.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: osmocom-latest-packages: introduce $TOP dir variable

2017-11-21 Thread lynxis lazus
Review at https://gerrit.osmocom.org/4952 osmocom-latest-packages: introduce $TOP dir variable Using a $TOP variable makes directory paths more clear to understandable. Path now expressed starting from the TOP dir instead of using ../../../foo Change-Id:

[PATCH] libosmocore[master]: osmo_strlcpy: sanitize: don't memcpy from NULL src even if l...

2017-11-21 Thread Neels Hofmeyr
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4940 to look at the new patch set (#2). osmo_strlcpy: sanitize: don't memcpy from NULL src even if len is 0 Some callers pass NULL and len == 0. The semantics are that we then

[MERGED] osmo-sgsn[master]: Replace '.' in counter names with ':'

2017-11-21 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Replace '.' in counter names with ':' .. Replace '.' in counter names with ':' '.' is an illegal character in counter names, as they are exported via

libosmocore[master]: osmo_strlcpy: sanitize: don't memcpy from NULL src even if l...

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4940 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I883048cf2807e606c6481634dbd569fc12aed889 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bsc[master]: use _NUM_CHREQ_T to define the size of ctype_by_chreq

2017-11-21 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/4947 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-hlr[master]: db_test: don't verify SQLite issued error messages, they mig...

2017-11-21 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/4948 db_test: don't verify SQLite issued error messages, they might change A user on openbsc@ complained that with SQLite 3.8.2, the db_test fails with --- expected +++ stderr -DDB (2067) abort at 18 in [INSERT INTO subscriber (imsi) VALUES ($imsi)]:

osmo-ggsn[master]: sanitize build: ensure uint16/32 alignment in gtpie_test and...

2017-11-21 Thread Max
Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/4915/3/tests/gtp/gtpie_test.c File tests/gtp/gtpie_test.c: Line 11: #include It's enough to just include bits.h - no need to use generated headers directly. -- To view, visit https://gerrit.osmocom.org/4915 To unsubscribe, visit

osmo-iuh[master]: Fix various compiler warnings in hnb-gw code

2017-11-21 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4945 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516700eab2aa7c3412dd62775c4960aed9d4b682 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master

[PATCH] osmo-iuh[master]: Fix various compiler warnings in hnb-gw code

2017-11-21 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4945 to look at the new patch set (#2). Fix various compiler warnings in hnb-gw code Since we finally started to use -Wall, the related warnings became visible. Change-Id:

osmo-iuh[master]: Fix various compiler warnings in hnb-gw code

2017-11-21 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/4945/1/src/hnbgw_hnbap.c File src/hnbgw_hnbap.c: Line 358: DEBUGP(DHNBAP, "HNB-DE-REGISTER cause=%ld\n", %s -- To view, visit https://gerrit.osmocom.org/4945 To unsubscribe, visit https://gerrit.osmocom.org/settings

openbsc[master]: openbsc: use _NUM_CHREQ_T to define the size of ctype_by_chreq

2017-11-21 Thread lynxis lazus
Patch Set 2: https://gerrit.osmocom.org/#/c/4947/ -- To view, visit https://gerrit.osmocom.org/2054 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2acab2af8d67bccb2bc495512c1f259ae649a832 Gerrit-PatchSet: 2 Gerrit-Project: openbsc

[ABANDON] openbsc[master]: openbsc: use _NUM_CHREQ_T to define the size of ctype_by_chreq

2017-11-21 Thread lynxis lazus
lynxis lazus has abandoned this change. Change subject: openbsc: use _NUM_CHREQ_T to define the size of ctype_by_chreq .. Abandoned moved to projecty osmo-bsc -- To view, visit https://gerrit.osmocom.org/2054 To unsubscribe,

[PATCH] osmo-bsc[master]: use _NUM_CHREQ_T to define the size of ctype_by_chreq

2017-11-21 Thread lynxis lazus
Review at https://gerrit.osmocom.org/4947 use _NUM_CHREQ_T to define the size of ctype_by_chreq Make it future compatible for changes. Otherwise it will break when additional enums are adding to chreq in libosmocore. Depends on libosmocore Id67ba8de89dd6288e449197438e9e1c5d7f5a134 Change-Id:

[PATCH] libosmo-abis[master]: unixsocket: fix a potential string overflow

2017-11-21 Thread lynxis lazus
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4213 to look at the new patch set (#2). unixsocket: fix a potential string overflow Change-Id: I8e3ec741247d728232f8c07c94eb63f068597d80 Found-by: coverity --- M

[MERGED] osmo-pcu[master]: Remove unused parameter

2017-11-21 Thread Max
Max has submitted this change and it was merged. Change subject: Remove unused parameter .. Remove unused parameter Change-Id: Ifd6e04a29e27b1862cf9e98dec7481d3e0efcd48 --- M src/gprs_rlcmac_ts_alloc.cpp 1 file changed, 2

[MERGED] osmo-pcu[master]: Move multislot table to separate file

2017-11-21 Thread Max
Max has submitted this change and it was merged. Change subject: Move multislot table to separate file .. Move multislot table to separate file To facilitate testing and addition of support for new multislot classes, hide

osmo-pcu[master]: Move multislot table to separate file

2017-11-21 Thread Max
Patch Set 1: > What information does this have? Same as gprs_rlcmac_ts_alloc.cpp which I've used as an example. What information should it have? -- To view, visit https://gerrit.osmocom.org/4635 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-pcu[master]: Move multislot table to separate file

2017-11-21 Thread Holger Freyther
Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/4635/1/src/mslot_class.c File src/mslot_class.c: Line 1: /* mslot_class.c What information does this have? -- To view, visit https://gerrit.osmocom.org/4635 To unsubscribe, visit https://gerrit.osmocom.org/settings

osmo-pcu[master]: Remove unused parameter

2017-11-21 Thread Holger Freyther
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4634 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd6e04a29e27b1862cf9e98dec7481d3e0efcd48 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master