[PATCH] osmo-iuh[master]: hnbgw: use proper talloc ctx for vty telnet init

Review at https://gerrit.osmocom.org/5522 hnbgw: use proper talloc ctx for vty telnet init Change-Id: I355c6e5489f24566612528cd679c5cab21eed008 --- M src/hnbgw.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/22/5522/1 diff

[PATCH] osmo-iuh[master]: hnbgw: use proper VTY port number defined in libosmocore (4261)

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5521 to look at the new patch set (#2). hnbgw: use proper VTY port number defined in libosmocore (4261) We used to have hardcoded 2323 from early development, use the proper libosmocore

[PATCH] osmo-gsm-manuals[master]: ports: add osmo-hnbgw as on port-numbers wiki page

Review at https://gerrit.osmocom.org/5519 ports: add osmo-hnbgw as on port-numbers wiki page Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers Related: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore) Change-Id: I28bd7a97d24455f88fadc6724d45c3264ba2fce4 ---

[PATCH] osmo-iuh[master]: hnbgw: use proper VTY port number defined in libosmocore (4261)

Review at https://gerrit.osmocom.org/5521 hnbgw: use proper VTY port number defined in libosmocore (4261) We used to have hardcoded 2323 from early development, use the proper libosmocore definition instead. Depends: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore) Change-Id:

[PATCH] libosmocore[master]: ports: define proper VTY and CTRL ports for OsmoHNBGW

Review at https://gerrit.osmocom.org/5520 ports: define proper VTY and CTRL ports for OsmoHNBGW So far it uses 2323, a development default. Instead, assign new ports, appending to the common range of VTY and CTRL ports: 4261 and 4262. Related:

Re: Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

This is most probably related to / fixed by https://gerrit.osmocom.org/5516 : [ 142s] <001e> rate_ctr.c:195 counter group 'msc' already exists for index 0 [ 142s] /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/1/test-source: line 25: 20213 Segmentation fault

osmo-iuh[master]: iu client: store multiple LAC, RAC per RNC = fix paging for m...

Patch Set 4: -Code-Review Verified+1 verified to work in manual test with two nano3G -- To view, visit https://gerrit.osmocom.org/5381 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I189f8e2663353276b1c615d2f78455dafe568045

[PATCH] osmo-sgsn[master]: gprs_gmm: segfault: gracefully handle failure to alloc context

Review at https://gerrit.osmocom.org/5517 gprs_gmm: segfault: gracefully handle failure to alloc context This counter allocation error I hit uncovers a segfault when allocating an MM context fails in the GSM_MI_TYPE_TMSI case: DRANAP <001a> ../../../src/osmo-iuh/src/iu_client.c:509

libosmo-sccp[master]: ss7: Re-bind xUA server socket after setting new IP

Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c File src/osmo_ss7.c: Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto, > to keep the public API backwards compatible, you should rather introduce os We don't

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

meta-telephony[201705]: osmo-sgsn: no longer depend on libpcap

Patch Set 1: Verified-1 This should actually be merged against branch laforge/nightly instead of 201705, since 201705 still doesn't use an osmo-sgsn new enough. -- To view, visit https://gerrit.osmocom.org/5485 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

osmo-ci[master]: jobs: master: fix: libosmoabis should trigger osmo-hlr

Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5514 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a122cee4fa98115140e4a34f623958697affed2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch:

[MERGED] osmo-ci[master]: jobs: master: fix: libosmoabis should trigger osmo-hlr

Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs: master: fix: libosmoabis should trigger osmo-hlr .. jobs: master: fix: libosmoabis should trigger osmo-hlr Change-Id:

[PATCH] osmo-ci[master]: jobs: master: fix: libosmoabis should trigger osmo-hlr

Review at https://gerrit.osmocom.org/5514 jobs: master: fix: libosmoabis should trigger osmo-hlr Change-Id: I9a122cee4fa98115140e4a34f623958697affed2 --- M jobs/master-builds.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/aarch64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 150s]

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

[MERGED] osmo-bsc[master]: remove unused 'lac' member of 'struct gsm_subscriber_connect...

Harald Welte has submitted this change and it was merged. Change subject: remove unused 'lac' member of 'struct gsm_subscriber_connection' .. remove unused 'lac' member of 'struct gsm_subscriber_connection' This field was used

osmo-bsc[master]: Remove unused struct osmo_bsc_sccp_con member sccp_queue_size

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5504 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: gsm_data.h: Document all fields of gsm_subscriber_connection

Harald Welte has submitted this change and it was merged. Change subject: gsm_data.h: Document all fields of gsm_subscriber_connection .. gsm_data.h: Document all fields of gsm_subscriber_connection Change-Id:

[MERGED] osmo-bsc[master]: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

Harald Welte has submitted this change and it was merged. Change subject: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con' .. osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con' Change-Id:

[MERGED] osmo-bsc[master]: osmo-bsc: Move user plane/voice related bits into sub-structure

Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc: Move user plane/voice related bits into sub-structure .. osmo-bsc: Move user plane/voice related bits into sub-structure This clarifies which

[PATCH] osmo-bsc[master]: Remove unused struct osmo_bsc_sccp_con member sccp_queue_size

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5504 to look at the new patch set (#4). Remove unused struct osmo_bsc_sccp_con member sccp_queue_size Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f --- M

[MERGED] osmo-gsm-tester[master]: osmo-bsc.cfg.tmpl: Remove bogus VTY commands

Harald Welte has submitted this change and it was merged. Change subject: osmo-bsc.cfg.tmpl: Remove bogus VTY commands .. osmo-bsc.cfg.tmpl: Remove bogus VTY commands There are plenty of VTY commands that were inherited from

osmo-gsm-tester[master]: osmo-bsc.cfg.tmpl: Remove bogus VTY commands

Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/5513 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79ff48983d9cb7b875c1859870d5e3bce2c0ef22 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester

[PATCH] osmo-gsm-tester[master]: osmo-bsc.cfg.tmpl: Remove bogus VTY commands

Review at https://gerrit.osmocom.org/5513 osmo-bsc.cfg.tmpl: Remove bogus VTY commands There are plenty of VTY commands that were inherited from OsmoNITB, but which make no sense in a BSC. Upstream OsmoBSC has removed them in change-ids Ib626f43a3a3ca69dfc127afe5832eb58f7fb6a38,

[MERGED] osmo-bsc[master]: Remove unused RRLP options/codec

Harald Welte has submitted this change and it was merged. Change subject: Remove unused RRLP options/codec .. Remove unused RRLP options/codec RRLP is handled in OsmoMSC after the split from NITB, so let's remove any bogus VTY

[MERGED] osmo-bsc[master]: remove libosmo-sccp dependency for osmo-bsc

Harald Welte has submitted this change and it was merged. Change subject: remove libosmo-sccp dependency for osmo-bsc .. remove libosmo-sccp dependency for osmo-bsc libosmo-sccp is the old sccp-lite-focused SCCP implementation

[MERGED] osmo-bsc[master]: Remove bogus vty config for LU reject cause

Harald Welte has submitted this change and it was merged. Change subject: Remove bogus vty config for LU reject cause .. Remove bogus vty config for LU reject cause The LU reject cause (like anything MM related) is under

[MERGED] osmo-bsc[master]: osmo_bsc_bssap.c: Spelling fixes in comment

Harald Welte has submitted this change and it was merged. Change subject: osmo_bsc_bssap.c: Spelling fixes in comment .. osmo_bsc_bssap.c: Spelling fixes in comment Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6 --- M

[MERGED] osmo-bsc[master]: Remove bogus MM INFO configuration

Harald Welte has submitted this change and it was merged. Change subject: Remove bogus MM INFO configuration .. Remove bogus MM INFO configuration The network name and other MM INFO is controlled by the MSC, not the BSC.

osmo-bsc[master]: Remove some more dead code

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5479 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I919bffe88babd90227c89abd4434322965c32ebb Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Remove some more dead code

Harald Welte has submitted this change and it was merged. Change subject: Remove some more dead code .. Remove some more dead code Change-Id: I919bffe88babd90227c89abd4434322965c32ebb --- M include/osmocom/bsc/gsm_data.h M

osmo-bsc[master]: Remove unused RRLP options/codec

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5476 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib626f43a3a3ca69dfc127afe5832eb58f7fb6a38 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: Remove bogus MM INFO configuration

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5478 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cbf72fc50cff29e7c1633ba752cbf15b4b84c58 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: Remove bogus vty config for LU reject cause

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5477 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I559ae31d67726845c9699c8b6127e21c6f63ace6 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: remove unused 'lac' member of 'struct gsm_subscriber_connect...

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5508 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: gsm_data.h: Document all fields of gsm_subscriber_connection

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5507 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5505 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: osmo_bsc_bssap.c: Spelling fixes in comment

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5503 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: osmo-bsc: Move user plane/voice related bits into sub-structure

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5506 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: bsc_test.c: Use proper network/bts/lchan structures

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: Remove dead code left over from NITB split

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5475 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e0af56a158f25a4f1384d667c03eb20e72df5b8 Gerrit-PatchSet: 4 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: Remove unneeded .py scripts

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5501 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4285b18b152b070c148228604d1e61a8adedba1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: remove libosmo-sccp dependency for osmo-bsc

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5502 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f274be7d196cd7a5b1ec9ada949130fb06e984d Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Remove unneeded .py scripts

Harald Welte has submitted this change and it was merged. Change subject: Remove unneeded .py scripts .. Remove unneeded .py scripts The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for vty and ctrl tests

[MERGED] osmo-sgsn[master]: Remove unneeded .py scripts

Harald Welte has submitted this change and it was merged. Change subject: Remove unneeded .py scripts .. Remove unneeded .py scripts The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for vty and ctrl tests

osmo-sgsn[master]: Remove unneeded .py scripts

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5512 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ef4ca790878921a5846f64942a8de8a6ff9c11c Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

[PATCH] osmo-bsc[master]: Remove bogus MM INFO configuration

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5478 to look at the new patch set (#4). Remove bogus MM INFO configuration The network name and other MM INFO is controlled by the MSC, not the BSC. Change-Id:

[PATCH] osmo-bsc[master]: Remove unused RRLP options/codec

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5476 to look at the new patch set (#4). Remove unused RRLP options/codec RRLP is handled in OsmoMSC after the split from NITB, so let's remove any bogus VTY commands left over in the BSC.

[PATCH] osmo-bsc[master]: Remove bogus vty config for LU reject cause

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5477 to look at the new patch set (#4). Remove bogus vty config for LU reject cause The LU reject cause (like anything MM related) is under control of OsmoMSC, not BSC. Change-Id:

[PATCH] osmo-bsc[master]: Remove dead code left over from NITB split

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5475 to look at the new patch set (#4). Remove dead code left over from NITB split There still is a lot of dead code that we inherited from the NITB days, let's remove more of it. libtrau

[PATCH] osmo-sgsn[master]: Remove unneeded .py scripts

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5512 to look at the new patch set (#2). Remove unneeded .py scripts The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for vty and ctrl tests instead of local copy. The

python/osmo-python-tests[master]: fix osmo_interact_* and osmo_verify_transcript_* after dir s...

Patch Set 2: How to reproduce the issues you mention in commit log? -- To view, visit https://gerrit.osmocom.org/5492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40a37b212274cb70ebb1e1d9d1b3743eb2d64d05 Gerrit-PatchSet: 2

[PATCH] osmo-bsc[master]: remove libosmo-sccp dependency for osmo-bsc

remove libosmo-sccp dependency for osmo-bsc libosmo-sccp is the old sccp-lite-focused SCCP implementation that we used before libosmo-sigtran was created. The new osmo-bsc in this repository is using libosmo-sigtran and shouldn't be using parts of libosmo-sccp anymore. We only keep it around

[PATCH] osmo-bsc[master]: Remove some more dead code

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5479 to look at the new patch set (#3). Remove some more dead code Change-Id: I919bffe88babd90227c89abd4434322965c32ebb --- M include/osmocom/bsc/gsm_data.h M

[PATCH] osmo-bsc[master]: cosmetic: Hide all accesses to conn->bts behind conn_get_bts()

cosmetic: Hide all accesses to conn->bts behind conn_get_bts() This is a new inline function that hides all accesses to conn->bts. A follow-up patch will then point this to conn->lchan->ts->trx->bts to get rid of the bts field. Change-Id: Ib6cf7097ced34eebe80441c29ab1534f21956a33 --- M

[PATCH] osmo-bsc[master]: remove obsolete gsm_subscriber_connection.bts member

remove obsolete gsm_subscriber_connection.bts member This member was merely a cache for conn->lchan->ts->trx->bts, so let's avoid having to keep copies of the same data (which needs to be kept up to date). Change-Id: Id3bff8b18425ef5d45eb460ac9eb620023013ba0 --- M include/osmocom/bsc/gsm_data.h

[PATCH] osmo-bsc[master]: osmo_bsc_bssap.c: Spelling fixes in comment

osmo_bsc_bssap.c: Spelling fixes in comment Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/5503/2 diff --git

[PATCH] osmo-bsc[master]: Remove bogus vty config for LU reject cause

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5477 to look at the new patch set (#3). Remove bogus vty config for LU reject cause The LU reject cause (like anything MM related) is under control of OsmoMSC, not BSC. Change-Id:

[PATCH] osmo-bsc[master]: Remove bogus MM INFO configuration

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5478 to look at the new patch set (#3). Remove bogus MM INFO configuration The network name and other MM INFO is controlled by the MSC, not the BSC. Change-Id:

[PATCH] osmo-bsc[master]: Remove unused RRLP options/codec

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5476 to look at the new patch set (#3). Remove unused RRLP options/codec RRLP is handled in OsmoMSC after the split from NITB, so let's remove any bogus VTY commands left over in the BSC.

[PATCH] osmo-bsc[master]: remove unused 'lac' member of 'struct gsm_subscriber_connect...

remove unused 'lac' member of 'struct gsm_subscriber_connection' This field was used in write-pnly mode, i.e. set but never read. Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/bsc_api.c 2 files changed, 0 insertions(+), 3 deletions(-)

[PATCH] osmo-bsc[master]: bsc_test.c: Use proper network/bts/lchan structures

bsc_test.c: Use proper network/bts/lchan structures don't mock them, simply call the respective functions to get a gsm_network and a gsm_bts with all its subordinate members. Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce --- M tests/bsc/bsc_test.c 1 file changed, 4 insertions(+), 5

[PATCH] osmo-bsc[master]: gsm_data.h: Document all fields of gsm_subscriber_connection

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5507 to look at the new patch set (#2). gsm_data.h: Document all fields of gsm_subscriber_connection Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0 --- M

[PATCH] osmo-bsc[master]: Remove dead code left over from NITB split

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5475 to look at the new patch set (#3). Remove dead code left over from NITB split There still is a lot of dead code that we inherited from the NITB days, let's remove more of it. libtrau

[PATCH] osmo-bsc[master]: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5505 to look at the new patch set (#2). osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con' Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6 --- M

[PATCH] osmo-bsc[master]: osmo-bsc: Move user plane/voice related bits into sub-structure

osmo-bsc: Move user plane/voice related bits into sub-structure This clarifies which members of the struct are for what. Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412 --- M include/osmocom/bsc/osmo_bsc.h M src/osmo-bsc/osmo_bsc_api.c M src/osmo-bsc/osmo_bsc_audio.c M

[PATCH] osmo-sgsn[master]: Remove unneeded .py scripts

Review at https://gerrit.osmocom.org/5512 Remove unneeded .py scripts The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for vty and ctrl tests instead of local copy. The soap.py and twisted_ipa.py are not SGSN-specific: leftovers from repository split which are now available

[PATCH] osmo-bsc[master]: remove obsolete gsm_subscriber_connection.bts member

Review at https://gerrit.osmocom.org/5511 remove obsolete gsm_subscriber_connection.bts member This member was merely a cache for conn->lchan->ts->trx->bts, so let's avoid having to keep copies of the same data (which needs to be kept up to date). Change-Id:

[PATCH] osmo-bsc[master]: osmo-bsc: Move user plane/voice related bits into sub-structure

Review at https://gerrit.osmocom.org/5506 osmo-bsc: Move user plane/voice related bits into sub-structure This clarifies which members of the struct are for what. Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412 --- M include/osmocom/bsc/osmo_bsc.h M src/osmo-bsc/osmo_bsc_api.c M

[PATCH] osmo-bsc[master]: more remove

Review at https://gerrit.osmocom.org/5504 more remove Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f --- M include/osmocom/bsc/osmo_bsc.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/5504/1 diff --git

[PATCH] osmo-bsc[master]: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'

Review at https://gerrit.osmocom.org/5505 osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con' Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6 --- M include/osmocom/bsc/osmo_bsc.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull

[PATCH] osmo-bsc[master]: remove unused 'lac' member of 'struct gsm_subscriber_connect...

Review at https://gerrit.osmocom.org/5508 remove unused 'lac' member of 'struct gsm_subscriber_connection' This field was used in write-pnly mode, i.e. set but never read. Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256 --- M include/osmocom/bsc/gsm_data.h M src/libbsc/bsc_api.c 2 files

[PATCH] osmo-bsc[master]: cosmetic: Hide all accesses to conn->bts behind conn_get_bts()

Review at https://gerrit.osmocom.org/5510 cosmetic: Hide all accesses to conn->bts behind conn_get_bts() This is a new inline function that hides all accesses to conn->bts. A follow-up patch will then point this to conn->lchan->ts->trx->bts to get rid of the bts field. Change-Id:

[PATCH] osmo-bsc[master]: bsc_test.c: Use proper network/bts/lchan structures

Review at https://gerrit.osmocom.org/5509 bsc_test.c: Use proper network/bts/lchan structures don't mock them, simply call the respective functions to get a gsm_network and a gsm_bts with all its subordinate members. Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce --- M

[PATCH] osmo-bsc[master]: remove libosmo-sccp dependency for osmo-bsc

Review at https://gerrit.osmocom.org/5502 remove libosmo-sccp dependency for osmo-bsc libosmo-sccp is the old sccp-lite-focused SCCP implementation that we used before libosmo-sigtran was created. The new osmo-bsc in this repository is using libosmo-sigtran and shouldn't be using parts of

[PATCH] osmo-bsc[master]: osmo_bsc_bssap.c: Spelling fixes in comment

Review at https://gerrit.osmocom.org/5503 osmo_bsc_bssap.c: Spelling fixes in comment Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

[PATCH] osmo-bsc[master]: Remove unneeded .py scripts

Review at https://gerrit.osmocom.org/5501 Remove unneeded .py scripts The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for vty and ctrl tests instead of local copy. The soap.py and twisted_ipa.py are not BSC-specific: leftovers from repository split which are now available

[PATCH] osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/4980 to look at the new patch set (#14). mgcp: use osmo-mgw to switch rtp streams in the current implementation we still use osmo-bsc_mgcp, which has many problems and is

[PATCH] osmo-iuh[master]: iu: iu_helpers: add functions to decode ip/port from rab-ass

Review at https://gerrit.osmocom.org/5498 iu: iu_helpers: add functions to decode ip/port from rab-ass add ranap_transp_assoc_decode() to decode the port information from an RANAP_IuTransportAssociation_t field. add ranap_transp_layer_addr_decode() to decode the ip-address from an

[PATCH] osmo-iuh[master]: ranap_msg_factory: check IE encoder return codes

Review at https://gerrit.osmocom.org/5499 ranap_msg_factory: check IE encoder return codes in many functions, the returncode (rc) from the IE encoder functions is not checked. Add a return code check and log error message (like it is already done in the functions which already check the

[PATCH] osmo-iuh[master]: ranap_msg_factory: remove unusued variable

Review at https://gerrit.osmocom.org/5500 ranap_msg_factory: remove unusued variable remove variable i in ranap_new_msg_sec_mod_compl() as it is not used (compiler warning) Change-Id: I93d9e95109fb78bc6cc161745b9e14de8b623d4f --- M src/ranap_msg_factory.c 1 file changed, 1 insertion(+), 1

python/osmo-python-tests[master]: README: mention twisted_ipa.py in scripts section, not as lib

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5496 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie536d61c5af89a530533b22d8ecab1c804a38289 Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests

python/osmo-python-tests[master]: scripts: add symlink to osmopy

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5493 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I880c8afa8d02ef112a80cb54f649ec71902bbd4c Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests

[PATCH] python/osmo-python-tests[master]: Ignore compilation byproducts

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5483 to look at the new patch set (#3). Ignore compilation byproducts Change-Id: Ic04a1b9411b851547ef7ce7a9b562cb290081ca9 --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-)

[PATCH] python/osmo-python-tests[master]: Improve python3 compatibility

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5038 to look at the new patch set (#4). Improve python3 compatibility Use proper print() function to make scripts compatible with both python 2 and 3. This

[PATCH] python/osmo-python-tests[master]: Update ctrl command parsing for python3

Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5028 to look at the new patch set (#5). Update ctrl command parsing for python3 * make parse() return command id in addition to variable name and value * introduce parse_kv()

[PATCH] python/osmo-python-tests[master]: Add rate counter dumper

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5029 to look at the new patch set (#7). Add rate counter dumper This simple tool dump all the rate counters available via ctrl interface to cvs file (or

python/osmo-python-tests[master]: fix osmo_interact_* and osmo_verify_transcript_* after dir s...

Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/5492/2/osmopy/osmo_interact/ctrl.py File osmopy/osmo_interact/ctrl.py: Line 1: #!/usr/bin/env python3 (this is actually mostly a file rename from scripts/osmo_interact_ctrl.py, no idea why gerrit doesn't pick up the rename.)

python/osmo-python-tests[master]: fix osmo_interact_* and osmo_verify_transcript_* after dir s...

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5492/1/osmopy/osmo_interact/ctrl.py File osmopy/osmo_interact/ctrl.py: Line 101: def main_verify_transcript_ctrl(): > Why this is here and not in actual script? personal preference. that code was so alone in that file way over there in

[PATCH] python/osmo-python-tests[master]: fix osmo_interact_* and osmo_verify_transcript_* after dir s...

Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5492 to look at the new patch set (#2). fix osmo_interact_* and osmo_verify_transcript_* after dir split After I30cdf0f85b2a60a235960911c9827f4129da40db, * the

[MERGED] osmo-hlr[master]: fix test_subscriber_errors.ctrl after libosmocore change

Neels Hofmeyr has submitted this change and it was merged. Change subject: fix test_subscriber_errors.ctrl after libosmocore change .. fix test_subscriber_errors.ctrl after libosmocore change libosmocore

osmo-hlr[master]: fix test_subscriber_errors.ctrl after libosmocore change

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5497 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aee1507721cd073f72369150d0fb3cff0fdf66f Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master

  1   2   >