Patch Set 2:
Just curious - have validity time calculation been fixed in mainline? I
remember my patches for it have not been merged when i looked into it several
months ago.
--
To view, visit https://gerrit.osmocom.org/5996
To unsubscribe, visit https://gerrit.osmocom.org/settings
Max has submitted this change and it was merged.
Change subject: Don't ignore top-level Makefile
..
Don't ignore top-level Makefile
Move corresponding .gitignore entry inside virt-phy to avoid interfering
with other
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5991
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19a8661b74ae0b28da51cf2e81f0ca40de76fcbd
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5996
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56cbe716e52b679c4b94f6cbb4a171306975be2e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I833c3abd290d2bc5fceec7457e3933c9600e6c24
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(24 comments)
Regarding to the gprs_* files, i.e. samples and decoding references,
I would prefer to keep them in a separate directory, for example,
called 'samples' or 'test', since they only used for testing.
Regarding to the CRC code, may we use the code from
Review at https://gerrit.osmocom.org/5997
Accept SMS for any receiver
Accept any SMS and store it in the database, even if the receiver of
the message cannot be determined when the message arrives at the MSC.
This fixes https://osmocom.org/issues/2354 ("SMSC: Store not
working for subscribed
Delete expired SMS automatically.
Delete expired SMS whenever we are done processing an SMS-related signal.
In order to minimize additional latency only one SMS is removed at a time.
Change-Id: I56cbe716e52b679c4b94f6cbb4a171306975be2e
Related: OS#2354
---
M include/osmocom/msc/db.h
M
Review at https://gerrit.osmocom.org/5996
Delete expired SMS automatically.
Delete expired SMS whenever we are done processing an SMS-related signal.
In order to minimize additional latency only one SMS is removed at a time.
Change-Id: I56cbe716e52b679c4b94f6cbb4a171306975be2e
Depends:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5995
to look at the new patch set (#2).
Fix value of stored SMS validity time.
Quote the argument to sqlite's datetime(). Otherwise, the timestamp
stored in the database reads back as a
Review at https://gerrit.osmocom.org/5995
Fix value of stored SMS validity time.
Quote the argument to sqlite's datetime(). Otherwise, the timestamp
stored in the database reads back as a negative value for some reason.
Change-Id: Icf786f9b1efabfe7407fb6414ec0d326d8f7244a
---
M
Review at https://gerrit.osmocom.org/5993
client: make callid in MDCX mandatory
An MDCX without call-id does not make much sense. The call-id is
an integral element of the MDCX message to ensure that the correct
call is modified.
- update the presence check bitmasks to mark the call-id field
Review at https://gerrit.osmocom.org/5994
client: add missing mandatory SDP fields
The mcgp message generator function mgcp_msg_gen() lacks support
for the mandatory SDP fields (v)ersion, (o)rigin, (s)ession and
(t)ime.
- Automatically generate the missing fields when SDP is
generated.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5881
to look at the new patch set (#5).
client: add an optional FSM interface
the client API is not very intuitive and requires a lot of extra
care when it is used from an osmo-fsm.
- Add
Review at https://gerrit.osmocom.org/5991
Don't ignore top-level Makefile
Move corresponding .gitignore entry inside virt-phy to avoid interfering
with other subprojects still using hand-crafted Makefiles.
Change-Id: I19a8661b74ae0b28da51cf2e81f0ca40de76fcbd
---
M .gitignore
M
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5989
to look at the new patch set (#2).
Add a VTY command which deletes all expired SMS.
We already delete SMS which have been sent successfully. However, there
are plans to accept SMS for
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5832
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d18cbd4ada903cf3720b3ad2a89fc643085beef
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5988
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9852b57736432032542bd96b6fdd4a2f08fc1f64
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: socket: use inet_ntop() instead of inet_ntoa() in
osmo_sock_local_ip()
..
socket: use inet_ntop() instead of inet_ntoa() in osmo_sock_local_ip()
The
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: fix Makefile whitespace
..
cosmetic: fix Makefile whitespace
Change-Id: Ia55d54d7ec7ec04e122d2e5250037c2d166abeb5
---
M src/Makefile
1 file
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5990
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia55d54d7ec7ec04e122d2e5250037c2d166abeb5
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5990
cosmetic: fix Makefile whitespace
Change-Id: Ia55d54d7ec7ec04e122d2e5250037c2d166abeb5
---
M src/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/90/5990/1
diff --git
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5832
to look at the new patch set (#7).
fsm: add functions for unlinking and changing parents
At the moment it is not possible to unlink a child from from
its parent, nor is
Review at https://gerrit.osmocom.org/5989
Add a VTY command which deletes all expired SMS.
We already delete SMS which have been sent successfully. However, there
are plans to accept SMS for any subscriber in order to fix the problem
described in https://osmocom.org/issues/2354 ("SMSC: Store
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5832
to look at the new patch set (#6).
fsm: add functions for unlinking and changing parents
At the moment it is not possible to unlink a child from from
its parent, nor is
Review at https://gerrit.osmocom.org/5988
socket: use inet_ntop() instead of inet_ntoa() in osmo_sock_local_ip()
The function inet_ntoa() stores its result in a static buffer and
returns the pointer. When inet_ntoa() is called subsequently it
overwrite the content of its static buffer with the
Max has submitted this change and it was merged.
Change subject: GSUP: don't fail test on first error
..
GSUP: don't fail test on first error
Instead of forcing test failure via assert on first error encountered,
let it run
Review at https://gerrit.osmocom.org/5985
jenkins: fix jobs template
The sequential parameter was silently skipped because it was absent from
the project template. Fix this for both master- and gerrit- jobs.
Change-Id: I0bc28695f4f270bc7b1cc4bcd5d4d43ede6172f3
---
M
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: msc_vty: Fix compilation warning
..
libmsc: msc_vty: Fix compilation warning
As the include file gsm_data.h is generic (does not depend on
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5982
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b63ee350911bdf772a2324fff55035275a455c4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5983
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I016a28fe04f7b194e22c15e936095004c5f079d1
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 4: Code-Review+1
(1 comment)
fine with me, if we add that extra 'void * ctx' argument to the unlink function.
https://gerrit.osmocom.org/#/c/5832/4/src/fsm.c
File src/fsm.c:
Line 285: talloc_steal(NULL, fi);
I think it makes sense to pass in the new talloc context as
Harald Welte has submitted this change and it was merged.
Change subject: socket: fix socket leak in osmo_sock_local_ip()
..
socket: fix socket leak in osmo_sock_local_ip()
The socket that is opend to probe the correct local
Review at https://gerrit.osmocom.org/5984
socket: fix socket leak in osmo_sock_local_ip()
The socket that is opend to probe the correct local ip-address is
not closed when the test is done.
- Close socket when it is not needed anymore
Change-Id: I7f3562a344b58f6298d2068314be1626a96e1b1d
---
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1538
to look at the new patch set (#5).
Use define for key buffers
This effectively doubles the Kc buffer which enable us to match the
requirements for future A5/4 and GEA4
Review at https://gerrit.osmocom.org/5983
GSUP: don't fail test on first error
Instead of forcing test failure via assert on first error encountered,
let it run until completion and print detailed error log. This
simplifies troubleshooting by letting user to see more errors from
single run and
Review at https://gerrit.osmocom.org/5982
libmsc: msc_vty: Fix compilation warning
As the include file gsm_data.h is generic (does not depend on osmo-iuh0s
iu_client.h), rab_assign_addr_enc is declared as "int" instead of "enum
ranap_nsap_addr_enc".
osmo-msc/src/libmsc/msc_vty.c: In function
Patch Set 1:
> what does the spec say about line endings?
RFC3435 Appendix A: Formal Syntax Description of the Protocol (which is hard to
follow) defines EOL as CRLF / LF. In RFC2327 Chapter 6 SDP Specification it is
mentioned that it should be an \r\n but \n should be tolerated as well,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5937
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8a0652e60f2b3d72ee1cedfa6e2d5547d88455
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1:
what does the spec say about line endings?
--
To view, visit https://gerrit.osmocom.org/5981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd80afae65accd3b4ddc5d82e5d30385879141c
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5980
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6261971040db527b96fe79676520ccd7794bd327
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5981
protocol: fix missing carriage return
Some of the line breaks lack the \r character, which leads to an
inconsistancy. While our software and even wireshark does ignore
the problem, other third party implementations might reject those
messages.
- Add
Review at https://gerrit.osmocom.org/5980
protocol: fix problem with line break and OSMUX
The SDP parameter block must be detached from the regular parameters
using an additional line break (empty line). At the moment this works
because the empty OSMOX variable is added and by this also adds a
Harald Welte has submitted this change and it was merged.
Change subject: sysmobts: move header check to appropriate place
..
sysmobts: move header check to appropriate place
Move the header check specific to sysmoBTS 2050
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/1538
to look at the new patch set (#4).
Extend Kc buffer
Double the Kc buffer to match the requirements of A5/4 and GEA4.
Related: OS#1910
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5978
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I165c373b58146658a5a69a2d7222d60cff4db79a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove wrapper script
..
cosmetic: remove wrapper script
The jenkins.sh is just a tiny wrapper around coverity_Osmocom.sh - let's
remove this
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove unused function
..
cosmetic: remove unused function
Change-Id: Ie3885237cea2afbe5e8c0f89d2280284bb4d9150
---
M
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5976
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3885237cea2afbe5e8c0f89d2280284bb4d9150
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5977
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead3b8f39327f1d0dd80e12a9d38563c35701993
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: Coverity: specify sysmoBTS L1 headers explicitly
..
Coverity: specify sysmoBTS L1 headers explicitly
Fix upload by specifying L1 headers location
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba55922295cb2a258f90c5345f592d7d5f34ac51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: tests/ussd: prevent uninitialized memory access
..
tests/ussd: prevent uninitialized memory access
Previously an incorrect length value was passed to
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5934
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic31805b6a5a917dfc6284edba6ffdd21246ac20c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Use Osmocom-patched UNIX_DOMAIN_SOCKETasp for SEQPACKET support
..
Use Osmocom-patched UNIX_DOMAIN_SOCKETasp for SEQPACKET support
Upstream TITAN
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5979
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa3661d8f818564d595c4612e5612a245a31a8f4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/5979
Use Osmocom-patched UNIX_DOMAIN_SOCKETasp for SEQPACKET support
Upstream TITAN doesn't have this yet (it's submitted, though),
so we have to use our own repo for titan.TestPorts.UNIX_DOMAIN_SOCKETasp
and at the same time make sure that our MNCC port is
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5978
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I165c373b58146658a5a69a2d7222d60cff4db79a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5874
to look at the new patch set (#2).
jenkins: move make invocation into shared function
Change-Id: Ied8c1085b8bee2cc4fa65592e805838b8cdae287
---
M contrib/jenkins_amd64.sh
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5978
to look at the new patch set (#2).
sysmobts: move header check to appropriate place
Move the header check specific to sysmoBTS 2050 next to generic sysmoBTS
header check.
Change-Id:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5978/1/configure.ac
File configure.ac:
Line 92:AM_CONDITIONAL(BUILD_SBTS2050, test "x$sysmo_uc_header" =
"xyes")
Be careful because there may be difference with previous logic, as in
BUILD_SBTS2050 probably being always defined
Patch Set 2:
> > You can also check putting a debug printf
>
> That's actually good idea: you can add this printf and update
> expected test output to remove any doubts.
But unrelated to USSD testing at all ;)
@Harald, the answer to this question is in the commit msg now.
--
To view,
Review at https://gerrit.osmocom.org/5978
sysmobts: move header check to appropriate place
Move the header check specific to sysmoBTS 2050 next to generic sysmoBTS
header check.
Change-Id: I165c373b58146658a5a69a2d7222d60cff4db79a
---
M configure.ac
1 file changed, 8 insertions(+), 11
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5976
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3885237cea2afbe5e8c0f89d2280284bb4d9150
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5977
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iead3b8f39327f1d0dd80e12a9d38563c35701993
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba55922295cb2a258f90c5345f592d7d5f34ac51
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5977
cosmetic: remove wrapper script
The jenkins.sh is just a tiny wrapper around coverity_Osmocom.sh - let's
remove this unnecessary indirection and move the code directly to
jenkins.sh
Change-Id: Iead3b8f39327f1d0dd80e12a9d38563c35701993
---
D
Review at https://gerrit.osmocom.org/5976
cosmetic: remove unused function
Change-Id: Ie3885237cea2afbe5e8c0f89d2280284bb4d9150
---
M coverity/build_Osmocom.sh
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/5976/1
diff --git
Review at https://gerrit.osmocom.org/5975
Coverity: specify sysmoBTS L1 headers explicitly
Fix upload by specifying L1 headers location properly.
Fixes: OS#2845
Change-Id: Iba55922295cb2a258f90c5345f592d7d5f34ac51
---
M coverity/build_Osmocom.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Patch Set 2:
> You can also check putting a debug printf
That's actually good idea: you can add this printf and update expected test
output to remove any doubts.
--
To view, visit https://gerrit.osmocom.org/5934
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
70 matches
Mail list logo
