[MERGED] osmo-bsc[master]: drop unused common.h

Neels Hofmeyr has submitted this change and it was merged. Change subject: drop unused common.h .. drop unused common.h Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f --- M include/osmocom/bsc/Makefile.am D

[MERGED] osmo-bsc[master]: drop libcommon-cs completely

Neels Hofmeyr has submitted this change and it was merged. Change subject: drop libcommon-cs completely .. drop libcommon-cs completely Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9 --- M configure.ac M

[MERGED] osmo-bsc[master]: libcommon-cs: move a_reset.c into libbsc

Neels Hofmeyr has submitted this change and it was merged. Change subject: libcommon-cs: move a_reset.c into libbsc .. libcommon-cs: move a_reset.c into libbsc a_reset.c was originally used by both libmsc and libbsc in the old

[MERGED] osmo-bsc[master]: libcommon-cs: move vty bits to libbsc/bsc_vty.c

Neels Hofmeyr has submitted this change and it was merged. Change subject: libcommon-cs: move vty bits to libbsc/bsc_vty.c .. libcommon-cs: move vty bits to libbsc/bsc_vty.c The gsm_network VTY was partly shared between libmsc

[PATCH] osmo-bsc[master]: libcommon_cs: move gsm48 bits to libbsc

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6440 to look at the new patch set (#4). libcommon_cs: move gsm48 bits to libbsc These functions were originally shared between libmsc and libbsc in the old openbsc.git; now

[PATCH] osmo-bsc[master]: libcommon-cs: move vty bits to libbsc/bsc_vty.c

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6441 to look at the new patch set (#4). libcommon-cs: move vty bits to libbsc/bsc_vty.c The gsm_network VTY was partly shared between libmsc and libbsc in the old openbsc.git;

[MERGED] osmo-bsc[master]: libcommon-cs: move gsm_network_init() into bsc_network_init()

Neels Hofmeyr has submitted this change and it was merged. Change subject: libcommon-cs: move gsm_network_init() into bsc_network_init() .. libcommon-cs: move gsm_network_init() into bsc_network_init() Some part of the network

[PATCH] osmo-bsc[master]: gsm_network: drop unused subscr_epxire_timer

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6445 to look at the new patch set (#4). gsm_network: drop unused subscr_epxire_timer Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9 --- M include/osmocom/bsc/gsm_data.h

[PATCH] osmo-bsc[master]: drop unused common.h

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6444 to look at the new patch set (#4). drop unused common.h Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f --- M include/osmocom/bsc/Makefile.am D

[PATCH] osmo-bsc[master]: drop libcommon-cs completely

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6443 to look at the new patch set (#4). drop libcommon-cs completely Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9 --- M configure.ac M include/osmocom/bsc/Makefile.am

[MERGED] osmo-bsc[master]: libcommon_cs: move gsm48 bits to libbsc

Neels Hofmeyr has submitted this change and it was merged. Change subject: libcommon_cs: move gsm48 bits to libbsc .. libcommon_cs: move gsm48 bits to libbsc These functions were originally shared between libmsc and libbsc in

[MERGED] osmo-bsc[master]: gsm_network: drop unused trans_list

Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm_network: drop unused trans_list .. gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M

[MERGED] osmo-bsc[master]: common_cs.h: mv gsm_encr to gsm_data.h

Neels Hofmeyr has submitted this change and it was merged. Change subject: common_cs.h: mv gsm_encr to gsm_data.h .. common_cs.h: mv gsm_encr to gsm_data.h This leaves common_cs.h practically empty. Leave its removal to the

[PATCH] osmo-bsc[master]: libcommon-cs: move a_reset.c into libbsc

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6437 to look at the new patch set (#4). libcommon-cs: move a_reset.c into libbsc a_reset.c was originally used by both libmsc and libbsc in the old openbsc.git repository. Now

[MERGED] osmo-bsc[master]: gsm_network: drop unused subscr_epxire_timer

Neels Hofmeyr has submitted this change and it was merged. Change subject: gsm_network: drop unused subscr_epxire_timer .. gsm_network: drop unused subscr_epxire_timer Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9 --- M

[PATCH] osmo-bsc[master]: common_cs.h: mv gsm_encr to gsm_data.h

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6442 to look at the new patch set (#4). common_cs.h: mv gsm_encr to gsm_data.h This leaves common_cs.h practically empty. Leave its removal to the next patch, which removes

[PATCH] osmo-bsc[master]: gsm_network: drop unused trans_list

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6439 to look at the new patch set (#4). gsm_network: drop unused trans_list Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 --- M include/osmocom/bsc/gsm_data.h M

[PATCH] osmo-bsc[master]: libcommon-cs: move gsm_network_init() into bsc_network_init()

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6438 to look at the new patch set (#4). libcommon-cs: move gsm_network_init() into bsc_network_init() Some part of the network init was common between libbsc and libmsc in the

Build failure of network:osmocom:nightly/osmo-pcap in Debian_9.0/aarch64

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-pcap failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build

[MERGED] osmo-ttcn3-hacks[master]: ggsn: Switch over to new shared/common configuration file la...

Harald Welte has submitted this change and it was merged. Change subject: ggsn: Switch over to new shared/common configuration file layout .. ggsn: Switch over to new shared/common configuration file layout Change-Id:

osmo-ttcn3-hacks[master]: ggsn: Switch over to new shared/common configuration file la...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6456 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I491819c8bad8efa45cee161ea6f47c3f97941a17 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: ggsn: Switch over to new shared/common configuration file la...

Review at https://gerrit.osmocom.org/6456 ggsn: Switch over to new shared/common configuration file layout Change-Id: I491819c8bad8efa45cee161ea6f47c3f97941a17 --- M ggsn_tests/GGSN_Tests.cfg A ggsn_tests/GGSN_Tests.default 2 files changed, 24 insertions(+), 29 deletions(-) git pull

osmo-pcu[master]: Make osmo-pcu wait for BTS to become available at start-up t...

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6453/1/src/osmobts_sock.cpp File src/osmobts_sock.cpp: Line 288: osmo_timer_schedule(>timer, 5, 0); Do we actually need to wait 5 seconds now that we can reeschedule it in case it fails? we could this way speedup. -- To

[MERGED] osmo-pcu[master]: Make osmo-pcu wait for BTS to become available at start-up t...

Harald Welte has submitted this change and it was merged. Change subject: Make osmo-pcu wait for BTS to become available at start-up time. .. Make osmo-pcu wait for BTS to become available at start-up time. After the PCU

osmo-pcu[master]: Make osmo-pcu wait for BTS to become available at start-up t...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6453 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic42a5601a43b81d260721fef5d9fa52447f9d309 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come a...

Harald Welte has submitted this change and it was merged. Change subject: BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come active .. BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come active We don't have a

osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come a...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6455 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a43b3e381405f3af30b3ffe04bc50e64ec66f57 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come a...

Review at https://gerrit.osmocom.org/6455 BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come active We don't have a good way to make the BSSMAP code wait for the lower SIGTRAN layers to be up and running. To avoid the RESET being sent before the lower layers are up, introduce a sleep

[MERGED] osmo-ttcn3-hacks[master]: re-organize configuration files; add tcpdump integration

Harald Welte has submitted this change and it was merged. Change subject: re-organize configuration files; add tcpdump integration .. re-organize configuration files; add tcpdump integration Let's make sure we share common

osmo-ttcn3-hacks[master]: re-organize configuration files; add tcpdump integration

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6454 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3db452e24e5238aa05254d903739c64d202e61db Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: re-organize configuration files; add tcpdump integration

Review at https://gerrit.osmocom.org/6454 re-organize configuration files; add tcpdump integration Let's make sure we share common configuration between the test suites and split the config file into a "default" part which is used (but not copied) in the Docker images, and a "local" part which

[MERGED] osmo-bsc[master]: libcommon: join gsm_data_shared.* into gsm_data.*

Harald Welte has submitted this change and it was merged. Change subject: libcommon: join gsm_data_shared.* into gsm_data.* .. libcommon: join gsm_data_shared.* into gsm_data.* The separation of gsm_data_shared.* from

[MERGED] osmo-bsc[master]: libcommon: eliminate common_vty.c

Harald Welte has submitted this change and it was merged. Change subject: libcommon: eliminate common_vty.c .. libcommon: eliminate common_vty.c Move bsc_vty_go_parent() to osmo_bsc_main.c and bsc_nat.c, and drop those nodes

[MERGED] osmo-bsc[master]: libcommon: eliminate socket.c

Harald Welte has submitted this change and it was merged. Change subject: libcommon: eliminate socket.c .. libcommon: eliminate socket.c Replace calls to make_sock() with osmo_sock_init_ofd(). Shame on me for not testing every

[MERGED] osmo-bsc[master]: libcommon: eliminate bsc_version.c

Harald Welte has submitted this change and it was merged. Change subject: libcommon: eliminate bsc_version.c .. libcommon: eliminate bsc_version.c Move the copyright string into osmo_bsc_main.c. No other users of it exist.

[MERGED] osmo-bsc[master]: drop libcommon completely, move remaining files to libbsc

Harald Welte has submitted this change and it was merged. Change subject: drop libcommon completely, move remaining files to libbsc .. drop libcommon completely, move remaining files to libbsc Move gsm_data.c and

[MERGED] osmo-bsc[master]: libcommon: eliminate debug.c

Harald Welte has submitted this change and it was merged. Change subject: libcommon: eliminate debug.c .. libcommon: eliminate debug.c Provide concise log categories for each main scope. Move the complete log categories 1:1

[MERGED] osmo-bsc[master]: ipaccess-proxy: don't redefine tall_bsc_ctx

Harald Welte has submitted this change and it was merged. Change subject: ipaccess-proxy: don't redefine tall_bsc_ctx .. ipaccess-proxy: don't redefine tall_bsc_ctx Curiously, ipaccess-proxy.c is able to define its own

[MERGED] osmo-bsc[master]: libcommon: eliminate talloc_ctx.c

Harald Welte has submitted this change and it was merged. Change subject: libcommon: eliminate talloc_ctx.c .. libcommon: eliminate talloc_ctx.c Interestingly enough, talloc_ctx_init() actually had not a single caller. While

osmo-bsc[master]: common_cs.h: mv gsm_encr to gsm_data.h

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6442 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3233f03580aa8c0ab178dfd33e68ecab5b9f042 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: drop libcommon-cs completely

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6443 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: drop unused common.h

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6444 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon-cs: move vty bits to libbsc/bsc_vty.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6441 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f3a596f31762b48afed39a85a343c400826300f Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: gsm_network: drop unused subscr_epxire_timer

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6445 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon_cs: move gsm48 bits to libbsc

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6440 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie411c2ce8008accee54782a442d6361e50777a54 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: gsm_network: drop unused trans_list

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6439 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon-cs: move gsm_network_init() into bsc_network_init()

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6438 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8968787a5f0b078619264f0cb42349a9bc7943af Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon-cs: move a_reset.c into libbsc

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6437 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30e4b5dab9c6d761d20a3a0e5b9ec2d65e64ebc5 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: drop libcommon completely, move remaining files to libbsc

Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6435 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6178061fa30c7e1a4c22c29d3c8f508b1033569f Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: join gsm_data_shared.* into gsm_data.*

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6434 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie247bc492efb331871d970c56700595ad3f7e201 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: ipaccess-proxy: don't redefine tall_bsc_ctx

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6433 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c9c8540419876696e65a690717144d497d60fb2 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate talloc_ctx.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6432 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344a3d07e146999e154824837ed95db2b9879356 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate socket.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6431 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6e4e0e1eed3328fa25b3b90be376d532ad0e56b Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate debug.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6430 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib524e49ec211662e0dfde8161495a72aa8ad76cf Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate bsc_version.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6428 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f48924f484e4e4b98be4ca8bee253e6ea9c0576 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate common_vty.c

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6429 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22ebb76742e9c5ab9dd608ac089a5c558aceeb36 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

[MERGED] osmo-msc[master]: libmsc: bssap: Fix typo in log message

Harald Welte has submitted this change and it was merged. Change subject: libmsc: bssap: Fix typo in log message .. libmsc: bssap: Fix typo in log message Change-Id: I941cd7f4e9eec3e4f2786100a0e64770d5aee4a7 --- M

osmo-msc[master]: libmsc: bssap: Fix typo in log message

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6450 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I941cd7f4e9eec3e4f2786100a0e64770d5aee4a7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: libmsc: bssap: Refactor rx paths to to avoid parse_tlv code ...

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6448 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: libmsc: bssap: Catch TLV parse failures

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6451 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d1951f4a5daf200e85c76fea14a35e952491d27 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: libmsc: bssap: Fix compilation warning

Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: Line 313: memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION), msgb_l3len(msg)); I still don't get why we would want to copy the payload

libosmocore[master]: fsm: allow graceful exit on FSM termination

Patch Set 1: I think we can introduce this. However, I'm not happy with the naming. First, "grace" is different from "grace period" or "graceful" (think of "holy grace", ...). Second, I think it's not very indicative/explanatory of what is actually happening. Withouht thinking too much

[PATCH] libosmocore[master]: fsm: allow graceful exit on FSM termination

Review at https://gerrit.osmocom.org/6452 fsm: allow graceful exit on FSM termination The function _osmo_fsm_inst_term() terminates all child FSMs befor it calls fi->fsm_cleanup(). This prevents the cleanup callback to perform last actions on the child FSMs (e.g.

osmo-ttcn3-hacks[master]: Add tests for OS#2714, "close RSL connections from unknown U...

Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/6406/3/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: Line 1244: testcase TC_rsl_unknown_unit_id() runs on test_CT { > I think it makes sense t owrap those two into one function and call that fu Yes, I was just being lazy and copy/pasted :)

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Patch Set 1: > Would it make sense to try to port this to master? No idea, but probably unrelated to the fix/patch. If the answer is yes, then somebody can create an issue in redmine about it. -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit

[PATCH] osmo-msc[master]: libmsc: bssap: Fix compilation warning

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5424 to look at the new patch set (#4). libmsc: bssap: Fix compilation warning Fixes following compilation warning: osmo-msc/src/libmsc/a_iface_bssap.c:328:11: warning:

[PATCH] osmo-msc[master]: libmsc: bssap: Refactor rx paths to to avoid parse_tlv code ...

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6448 to look at the new patch set (#2). libmsc: bssap: Refactor rx paths to to avoid parse_tlv code duplication Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f --- M

[PATCH] osmo-msc[master]: libmsc: bssap: Catch TLV parse failures

Review at https://gerrit.osmocom.org/6451 libmsc: bssap: Catch TLV parse failures Change-Id: I1d1951f4a5daf200e85c76fea14a35e952491d27 --- M src/libmsc/a_iface_bssap.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/51/6451/1

[PATCH] osmo-msc[master]: libmsc: bssap: Fix typo in log message

Review at https://gerrit.osmocom.org/6450 libmsc: bssap: Fix typo in log message Change-Id: I941cd7f4e9eec3e4f2786100a0e64770d5aee4a7 --- M src/libmsc/a_iface_bssap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/50/6450/1 diff

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Patch Set 1: Would it make sense to try to port this to master? -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1

osmo-bsc[master]: drop libcommon completely, move remaining files to libbsc

Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6435 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6178061fa30c7e1a4c22c29d3c8f508b1033569f Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate talloc_ctx.c

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6432 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I344a3d07e146999e154824837ed95db2b9879356 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: ipaccess-proxy: don't redefine tall_bsc_ctx

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6433 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c9c8540419876696e65a690717144d497d60fb2 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate common_vty.c

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6429 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22ebb76742e9c5ab9dd608ac089a5c558aceeb36 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: libcommon: eliminate bsc_version.c

Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6428 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f48924f484e4e4b98be4ca8bee253e6ea9c0576 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Patch Set 1: Jenkins Builder failed because it's an old branch which has no jenkins.sh script, but the this trx feature doesn't seem to be available in master yet. roox, can you test it with your env and Verify+1 it? -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit

osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6449 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmocom-bb Gerrit-Branch:

[PATCH] osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

Review at https://gerrit.osmocom.org/6449 transceiver: Fix RSP SETSLOT format According to osmo-trx README: SETSLOT sets the format of the uplink timeslots in the ARFCN. The indicates the timeslot of interest. The indicates the type of channel that occupies the timeslot. A chantype of zero

osmo-msc[master]: libmsc: bssap: Catch TLV parse failures

Patch Set 1: Code-Review-1 (1 comment) Sorry, I think it's ugly to have the same code copy+pasted everywhere. Can't we simply do the TLV parsing at a common/shared point and hand the already-parsed tlv_parsed into the indiividual functions? This way there's reduction of code duplication

[PATCH] gapk[master]: Ignore build products

Hello Vadim Yanitskiy, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6383 to look at the new patch set (#3). Ignore build products Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 --- M .gitignore 1 file changed, 3 insertions(+), 0

[PATCH] gapk[master]: Ignore build products

Hello Vadim Yanitskiy, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6383 to look at the new patch set (#2). Ignore build products Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8 --- M .gitignore 1 file changed, 1 insertion(+), 0

[ABANDON] osmo-bsc[master]: drop libcommon completely

Neels Hofmeyr has abandoned this change. Change subject: drop libcommon completely .. Abandoned merged with previous patch ("libcommon: move remaining files to libbsc") as an easy way out of the hundredth build failure which

[PATCH] osmo-bsc[master]: drop libcommon completely, move remaining files to libbsc

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6435 to look at the new patch set (#5). drop libcommon completely, move remaining files to libbsc Move gsm_data.c and handover_cfg.c to libbsc, where they belong. This leaves libcommon

gapk[master]: Ignore build products

Patch Set 1: > Must be leftover from earlier compilation. Shouldn't be here now. -- To view, visit https://gerrit.osmocom.org/6383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8

gapk[master]: Ignore build products

Patch Set 1: > Patch Set 1: Code-Review+2 Harald? This change isn't ready I think. -- To view, visit https://gerrit.osmocom.org/6383 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8

[PATCH] osmo-bsc[master]: libcommon: move remaining files to libbsc

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6435 to look at the new patch set (#4). libcommon: move remaining files to libbsc Move gsm_data.c and handover_cfg.c to libbsc, where they belong. This leaves libcommon utterly empty, and

[PATCH] osmo-bsc[master]: drop libcommon completely

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6436 to look at the new patch set (#4). drop libcommon completely Change-Id: Ifa3486f04cdd5fda1e92630dfc1a5f670773bc14 --- M configure.ac M src/Makefile.am M src/ipaccess/Makefile.am D

[PATCH] osmo-msc[master]: libmsc: bssap: Catch TLV parse failures

Review at https://gerrit.osmocom.org/6448 libmsc: bssap: Catch TLV parse failures Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f --- M src/libmsc/a_iface_bssap.c 1 file changed, 49 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/6448/1

[PATCH] osmo-bsc[master]: libcommon_cs: move gsm48 bits to libbsc

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6440 to look at the new patch set (#3). libcommon_cs: move gsm48 bits to libbsc These functions were originally shared between libmsc and libbsc in the old openbsc.git; now osmo-bsc.git has

[PATCH] osmo-bsc[master]: libcommon: eliminate common_vty.c

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6429 to look at the new patch set (#3). libcommon: eliminate common_vty.c Move bsc_vty_go_parent() to osmo_bsc_main.c and bsc_nat.c, and drop those nodes that aren't used in the respective

osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option reject cause

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6446 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac1948113514414e7573f3bbfb3ce82e6c49adb6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[MERGED] osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option reject cause

Pau Espin Pedrol has submitted this change and it was merged. Change subject: templates: osmo-msc: Remove unused option reject cause .. templates: osmo-msc: Remove unused option reject cause Commit osmo-msc

osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option auth policy

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6447 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I928379ebabfc776f33b9f345d92a7a4a533fe25f Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[MERGED] osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option auth policy

Pau Espin Pedrol has submitted this change and it was merged. Change subject: templates: osmo-msc: Remove unused option auth policy .. templates: osmo-msc: Remove unused option auth policy Commit osmo-msc

[PATCH] osmo-bsc[master]: libcommon: eliminate bsc_version.c

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6428 to look at the new patch set (#3). libcommon: eliminate bsc_version.c Move the copyright string into osmo_bsc_main.c. No other users of it exist. Change-Id:

[PATCH] osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option reject cause

Review at https://gerrit.osmocom.org/6446 templates: osmo-msc: Remove unused option reject cause Commit osmo-msc 27b40c601c41fde70446ad553629494234c07662 removes this option from default configuration as it is really not used in osmo-msc, it comes from osmo-nitb times. Change-Id:

[PATCH] osmo-gsm-tester[master]: templates: osmo-msc: Remove unused option auth policy

Review at https://gerrit.osmocom.org/6447 templates: osmo-msc: Remove unused option auth policy Commit osmo-msc 098aa71e83a86200a18088927b4753909f5ed518 removes this option from default configuration as it is really not used in osmo-msc, it comes from osmo-nitb times. Change-Id:

[MERGED] gapk[master]: Add basic CI integration

Max has submitted this change and it was merged. Change subject: Add basic CI integration .. Add basic CI integration Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 --- A contrib/jenkins.sh 1 file changed, 42

gapk[master]: Add basic CI integration

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6384 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

  1   2   >