Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/7080/1/src/common/l1sap.c
File src/common/l1sap.c:
Line 1199
this busy_thresh check here is above the "ber10k" check...
Line 1234: btsb->load.rach.busy++;
...but here the "busy_thresh" check comes after the
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6667
to look at the new patch set (#8).
gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf
Move from using deprecated gsm48_construct_ra(), which uses a buf, to
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6667
to look at the new patch set (#7).
gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf
Move from using deprecated gsm48_construct_ra(), which uses a buf, to
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7081
to look at the new patch set (#2).
ctrl_test_runner: add tests for 3-digit MNC
Expand MCC-MNC test cases: show that the CTRL interface currently does not
preserve the third digit of
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#8).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Patch Set 7: -Code-Review
ok fixed it; but it won't build because of an added dependency on
I020a4f11791c61742a3d795f782805f7b7e8733e
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/7083
gsm23003: add osmo_mcc_from_str()
I found myself often using osmo_mnc_from_str() to also decode an MCC and be
strict about it, but each time I felt the need to comment like "using
osmo_mnc_from_str() also for MCC". Rather formalize this properly.
Use
Review at https://gerrit.osmocom.org/7082
fix osmo_mnc_from_str(): don't try to parse NULL
In osmo_mnc_from_str() do not try to return some values even if the validation
fails; hence don't try to decode a NULL pointer. That whole idea was half-baked
and a can of worms to begin with.
Patch Set 7: Code-Review-2
ok can verify the failure now with address sanitizer on. Still need to fix
something apparently.
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#7).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Patch Set 6:
meh, can't reproduce the ctrl test failure!
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 6
Gerrit-Project:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6669
to look at the new patch set (#5).
pcu_if: implement support for 3-digit MNC
Add the mnc_3_digits member to the info_ind.
Instead of changing to e.g. osmo_plmn_id, add
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#6).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Review at https://gerrit.osmocom.org/7081
ctrl_test_runner: add tests for 3-digit MNC
Expand MCC-MNC test cases: show that the CTRL interface currently does not
preserve the third digit of the MNC if it is zero.
Change-Id: I5b097dbb6329f284e3b4914a744d5c3ad628f715
---
M
Review at https://gerrit.osmocom.org/7077
scheduler_trx.c: remove ToA (Time of Arrival) hack
This was useful for software simulation of burst delay, expressed
by ToA (Time of Arrival). Since we have FakeTRX toolkit, ToA value
may be simulated in a more flexible way, so let's remove this code.
Review at https://gerrit.osmocom.org/7080
common/l1sap.c: also check BER and ToA for handover RACH
Both BER and ToA values are currently used to filter out possible
noise, interference or ghosts. Previously this filtering was only
performed for non-handover bursts, so let's fix this.
Review at https://gerrit.osmocom.org/7079
common/l1sap.c: limit the minimal ToA for RACH bursts
In general, RACH bursts should not arrive with negative offset.
Let's limit early signal arrival up to 2 symbols, otherwise
it is most likely noise, interference or a ghost.
Change-Id:
Review at https://gerrit.osmocom.org/7078
common/l1sap.c: clean up RACH ToA (Timing of Arrival) check
And use units of 1/256 symbol periods for better precision.
Change-Id: Icfe1256cba117a5735107a25bf7cdb47479454ee
---
M src/common/l1sap.c
1 file changed, 8 insertions(+), 13 deletions(-)
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Patch Set 5: -Code-Review
(1 comment)
https://gerrit.osmocom.org/#/c/6667/4/src/libbsc/abis_nm.c
File src/libbsc/abis_nm.c:
Line 2851: void abis_nm_ipaccess_cgi(uint8_t *buf, struct gsm_bts *bts)
hmm, looking at this again, I don't actually like this part anymore: passing a
gsm48_ra_id* to
Review at https://gerrit.osmocom.org/7075
add test for gsm48_ra_id_by_bts()
Change-Id: I7bd55126848ed2c246d64cf672e1e6772da64be7
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 121 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7076
add test for abis_nm_ipaccess_cgi()
Change-Id: I90fefd5073ee07fc975a810859a32142b8b27904
---
M tests/abis/abis_test.c
M tests/abis/abis_test.ok
2 files changed, 94 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Hello Vadim Yanitskiy, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6667
to look at the new patch set (#5).
gsm48_ra_id_by_bts(): struct gsm48_ra_id* instead of buf
Move from using deprecated gsm48_construct_ra(), which uses a buf, to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#5).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 159s]
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7074
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f0e0d0a9fa849f41c34059431f62f956eac
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmo-trx: Add cfg template
..
osmo-trx: Add cfg template
Since commit 3da1f8352e337fb032bf7a58c2909d3ba918e237, osmo-trx requires
a cfg file to
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7074
to look at the new patch set (#3).
osmo-trx: Add cfg template
Since commit 3da1f8352e337fb032bf7a58c2909d3ba918e237, osmo-trx requires
a cfg file to start successfully.
Change-Id:
osmo-trx: Add cfg template
Since commit 3da1f8352e337fb032bf7a58c2909d3ba918e237, osmo-trx requires
a cfg file to start successfully.
Change-Id: I8f0e0d0a9fa849f41c34059431f62f956eac
---
M src/osmo_gsm_tester/bts_osmotrx.py
A src/osmo_gsm_tester/templates/osmo-trx.cfg.tmpl
2 files changed,
Review at https://gerrit.osmocom.org/7074
osmo-trx: Add cfg template
Since commit 3da1f8352e337fb032bf7a58c2909d3ba918e237, osmo-trx requires
a cfg file to start successfully.
Change-Id: I8f0e0d0a9fa849f41c34059431f62f956eac
---
M src/osmo_gsm_tester/bts_osmotrx.py
A
Patch Set 1:
I think this patch also suffered rebase issues.
--
To view, visit https://gerrit.osmocom.org/6203
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a899d9c866ed09dc301694dbbcad304b1ed49e5
Gerrit-PatchSet: 1
Gerrit-Project:
Patch Set 1:
It's been too long since looking at this: but isn't sending packet related
assignments (for DL tbf) what we do all the time even with existing bts-located
pcu? If so, why does the PCU socket interface need to change? Please
clarify/explain
--
To view, visit
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-PatchSet: 6
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+1 Verified+1
Please make sure we have a test case for this in the BSC_Tests.ttcn suite.
Sounds like an easy enough condition to test for?
--
To view, visit https://gerrit.osmocom.org/6840
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6673
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb85c1933a30b2aa491b495119919f45782e2c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: bsc_vty: Merge more VTY documentation string #defines
..
bsc_vty: Merge more VTY documentation string #defines
Change-Id:
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6594
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fcbcd319813e3b220daf8170cadd4ebb2aefa0f
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
Pau must review this series
--
To view, visit https://gerrit.osmocom.org/7019
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic49c94e9e6639e43f6ae14b868bc826af3ce2085
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Patch Set 4: Code-Review+1
What wie need now is proper coverage in the ttcn3 testsuite: usw vty to changfe
config and verify the Encoded value in all messages containing MNC/lai/rai
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
43 matches
Mail list logo
