docker-playground[master]: fix 'make -C subdir': use $(CURDIR) instead of $PWD

Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7633 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd0fd1ad89fdee18fdbea851ccc831ad60aeccf Gerrit-PatchSet: 2 Gerrit-Project: docker-playground Gerrit-Branch: master

docker-playground[master]: osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong

Patch Set 1: Code-Review+2 Verified+1 going to push this through now, to see if the next ttcn3-bts-test will work again. Still relevant are https://osmocom.org/issues/3135 https://gerrit.osmocom.org/7635 -- To view, visit https://gerrit.osmocom.org/7635 To unsubscribe, visit

[MERGED] docker-playground[master]: osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong

Neels Hofmeyr has submitted this change and it was merged. Change subject: osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong .. osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong Change-Id:

docker-playground[master]: fix 'make -C subdir': use $(CURDIR) instead of $PWD

Patch Set 2: thanks, CURDIR is even better -- To view, visit https://gerrit.osmocom.org/7633 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd0fd1ad89fdee18fdbea851ccc831ad60aeccf Gerrit-PatchSet: 2 Gerrit-Project: docker-playground

[PATCH] docker-playground[master]: fix 'make -C subdir': use $(CURDIR) instead of $PWD

fix 'make -C subdir': use $(CURDIR) instead of $PWD $(PWD) reflects the dir of 'make' invocation, $(CURDIR) the dir stepped into. So obtain the current dir from $(CURDIR) instead of $(PWD). So far, when doing 'make -C osmo-foo-maser', the image's name would be derived from the root dir's

[PATCH] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7618 to look at the new patch set (#3). ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) The CTRL interface has a ctrl_cmd_def_* API that allows deferring a CTRL

[PATCH] libosmocore[master]: ctrl: test deferred cmd, show current failure

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7636 to look at the new patch set (#2). ctrl: test deferred cmd, show current failure Handling a deferred command currently deallocates the struct ctrl_cmd upon exiting the initial command

[PATCH] libosmocore[master]: GSUP: add USSD messages support according to 3GPP TS 09.02

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7600 to look at the new patch set (#3). GSUP: add USSD messages support according to 3GPP TS 09.02 In order to be able to transfer USSD messages via GSUP, this change introduces the new

[PATCH] libosmocore[master]: use osmo_init_logging2() with proper talloc ctx

Review at https://gerrit.osmocom.org/7637 use osmo_init_logging2() with proper talloc ctx Ironically, when deprecating osmo_init_logging() in I216837780e9405fdaec8059c63d10699c695b360, I forgot to change the callers within libosmocore itself, i.e. in the various regression tests. Change-Id:

[PATCH] libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7618 to look at the new patch set (#2). ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'clock-info' cmd) The CTRL interface has a ctrl_cmd_def_* API that allows deferring a CTRL

[PATCH] libosmocore[master]: ctrl: test deferred cmd, show current failure

Review at https://gerrit.osmocom.org/7636 ctrl: test deferred cmd, show current failure Handling a deferred command currently deallocates the struct ctrl_cmd upon exiting the initial command handling, while it should actually stay around for the asynchronous/deferred handling of the ctrl

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #329

See -- Started by upstream project "master-osmo-gmr" build number 329 originally caused by: Started by upstream

[PATCH] osmo-msc[master]: unify allocation of gsm_subscriber_connection

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7616 to look at the new patch set (#2). unify allocation of gsm_subscriber_connection The current msc_subscr_con_allocate() was in fact only used by msc_vlr_tests, while both

Jenkins build is back to normal : master-osmo-bts » sysmo,superfemto_v3.0.1pre,default,osmocom-master-debian9 #459

See

[PATCH] osmo-bsc[master]: vty: re-add 'timeout-ping' and 'timeout-pong' as dummy commands

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7634 to look at the new patch set (#2). vty: re-add 'timeout-ping' and 'timeout-pong' as dummy commands Legacy VTY commands were removed in commit c74a5616bf1c77ac40ddd92f4927dca7a1b45bc8

[PATCH] docker-playground[master]: osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong

Review at https://gerrit.osmocom.org/7635 osmo-bsc.cfg: drop legacy config: timeout-ping, timeout-pong Change-Id: I70bffa7ed96da03ba0cedc50178ca9e00db4 --- M osmo-bsc-master/osmo-bsc.cfg M ttcn3-bsc-test/osmo-bsc.cfg 2 files changed, 0 insertions(+), 6 deletions(-) git pull

Build failed in Jenkins: master-osmo-bts » sysmo, superfemto_v3.0.1pre,default,osmocom-master-debian9 #458

See -- Started by upstream project "master-osmo-bts" build number 458 originally

Build failed in Jenkins: master-osmo-gmr » a1=default,a2=default,a3=default,osmocom-master-debian9 #328

See -- Started by upstream project "master-osmo-gmr" build number 328 originally caused by: Started by upstream

[MERGED] libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Vadim Yanitskiy has submitted this change and it was merged. Change subject: gsm0480: copy the raw USSD data, its DCS and length .. gsm0480: copy the raw USSD data, its DCS and length As it was already documented before, the

[MERGED] libosmocore[master]: gsm0480: drop messages with incorrect data length

Vadim Yanitskiy has submitted this change and it was merged. Change subject: gsm0480: drop messages with incorrect data length .. gsm0480: drop messages with incorrect data length If either an INVOKE, either a RETURN_RESULT

[MERGED] libosmocore[master]: gsm0480: document the 'ss_request' structure

Vadim Yanitskiy has submitted this change and it was merged. Change subject: gsm0480: document the 'ss_request' structure .. gsm0480: document the 'ss_request' structure Change-Id: I22144dd759e0c1bb1965574b7ddd676606e5d6b7 ---

docker-playground[master]: fix 'make -C subdir': use $(shell pwd) instead of $PWD

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7633/1/make/Makefile File make/Makefile: Line 18: NAME=$(shell basename $(shell pwd)) Hm looks related to the issues I had and fixed in this other makefile. The solution merged in there may be worth a try:

osmo-bsc[master]: Revert "cosmetic: remove dead code"

Neels Hofmeyr has reverted this change. Change subject: Revert "cosmetic: remove dead code" .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/7634 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-bsc[master]: Revert "cosmetic: remove dead code"

Review at https://gerrit.osmocom.org/7634 Revert "cosmetic: remove dead code" Removing the dead VTY commands currently breaks our ttcn3-bts-test. Instead we should keep dummy commands that don't do anything, to not break existing configs. This reverts commit

libosmocore[master]: fsm: id: properly set name in case of NULL id

Patch Set 1: > but .. it's so .. obvious. ... ... ok. we've had similarly "obvious" changes to the name/id handling of osmo_fsm in the past and it broke :/ also, if this patch is fixing a bug, we should explicitly test for it to avoid regressions. -- To view, visit

[PATCH] docker-playground[master]: fix 'make -C subdir': use $(shell pwd) instead of $PWD

Review at https://gerrit.osmocom.org/7633 fix 'make -C subdir': use $(shell pwd) instead of $PWD $PWD does not get updated when make steps into a subdir. The pwd output does. So obtain the current dir from shell pwd instead of $PWD. So far, when doing 'make -C osmo-foo-maser', the image's

[MERGED] osmocom-bb[fixeria/trx]: trx_toolkit: Add cmdline arg to set bind addr

Pau Espin Pedrol has submitted this change and it was merged. Change subject: trx_toolkit: Add cmdline arg to set bind addr .. trx_toolkit: Add cmdline arg to set bind addr Previous hardcoded default of 0.0.0.0 was

[MERGED] osmocom-bb[fixeria/trx]: trxcon/l1ctl.c: hexdump content of unhandled messages

Pau Espin Pedrol has submitted this change and it was merged. Change subject: trxcon/l1ctl.c: hexdump content of unhandled messages .. trxcon/l1ctl.c: hexdump content of unhandled messages Change-Id:

libosmocore[master]: fsm: id: properly set name in case of NULL id

Patch Set 1: but .. it's so .. obvious. ... ... ok. -- To view, visit https://gerrit.osmocom.org/7627 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d6b09a811b82770818f19b189a57d9fc4a8133b Gerrit-PatchSet: 1 Gerrit-Project:

[MERGED] osmo-pcu[master]: use osmo_init_logging2() with proper talloc ctx

Neels Hofmeyr has submitted this change and it was merged. Change subject: use osmo_init_logging2() with proper talloc ctx .. use osmo_init_logging2() with proper talloc ctx There is a duality of initialization: early_init()

[MERGED] osmo-mgw[master]: use osmo_init_logging2() with proper talloc ctx

Neels Hofmeyr has submitted this change and it was merged. Change subject: use osmo_init_logging2() with proper talloc ctx .. use osmo_init_logging2() with proper talloc ctx Change-Id: I3e2a9aef5242efdf11a64536f79099a6e9cec53f

[MERGED] osmo-msc[master]: cosmetic: rename gsm_subscriber_connection->conn_fsm to ->fi

Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: rename gsm_subscriber_connection->conn_fsm to ->fi .. cosmetic: rename gsm_subscriber_connection->conn_fsm to ->fi Match osmo-bsc's naming of

[MERGED] osmo-msc[master]: cosmetic: rename subscr_conn_from to complete_layer3_type

Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: rename subscr_conn_from to complete_layer3_type .. cosmetic: rename subscr_conn_from to complete_layer3_type 'subscr_conn_from' could mean

[MERGED] osmo-msc[master]: test_reject_concurrency: missing assert

Neels Hofmeyr has submitted this change and it was merged. Change subject: test_reject_concurrency: missing assert .. test_reject_concurrency: missing assert I broke this test during dev and saw the failure being noticed only

[MERGED] osmo-msc[master]: drop some dead definitions (gsm_data.h, gsup_client.c)

Neels Hofmeyr has submitted this change and it was merged. Change subject: drop some dead definitions (gsm_data.h, gsup_client.c) .. drop some dead definitions (gsm_data.h, gsup_client.c) Change-Id:

[MERGED] osmo-msc[master]: cosmetic: rx_bssmap: read message type once into local var

Neels Hofmeyr has submitted this change and it was merged. Change subject: cosmetic: rx_bssmap: read message type once into local var .. cosmetic: rx_bssmap: read message type once into local var Instead of referencing

libosmocore[master]: gsm0480: drop messages with incorrect data length

Patch Set 2: Code-Review+2 > Probably, we would need to also change the logging > target for the whole GSM 04.80 code. oh ys. I had no idea it's using '0' everywhere, that seems odd. -- To view, visit https://gerrit.osmocom.org/7630 To unsubscribe, visit https://gerrit.osmocom.org/settings

[MERGED] osmo-ci[master]: jobs/master: optimize trigger chain

Neels Hofmeyr has submitted this change and it was merged. Change subject: jobs/master: optimize trigger chain .. jobs/master: optimize trigger chain Avoid as many multiple triggers as still ensure all dependent projects are

[MERGED] osmo-msc[master]: use osmo_init_logging2() with proper talloc ctx

Neels Hofmeyr has submitted this change and it was merged. Change subject: use osmo_init_logging2() with proper talloc ctx .. use osmo_init_logging2() with proper talloc ctx Since the logging allocations now also show up in

osmo-ci[master]: jobs/master: optimize trigger chain

Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7580 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea2cf25b3872045778f11a985a1c417f37067cd9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7625 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia193d175021e145bb3b131290231f307dbefc64a Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-bts[master]: fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7632 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18e0774fdd48966bc95261e715f798464b8b681f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmocom-bb[fixeria/trx]: trx_toolkit: Add cmdline arg to set bind addr

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7410 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be18fef40967fb7551f4115f22cbbd9cdb0840d Gerrit-PatchSet: 3 Gerrit-Project: osmocom-bb Gerrit-Branch:

[MERGED] osmo-bts[master]: use osmo_init_logging2() with proper talloc ctx

Harald Welte has submitted this change and it was merged. Change subject: use osmo_init_logging2() with proper talloc ctx .. use osmo_init_logging2() with proper talloc ctx Completely drop bts_log_init(), call

osmocom-bb[fixeria/trx]: trxcon/l1ctl.c: hexdump content of unhandled messages

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7414 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec8fc6d49d1e35fe101960dd969de559e37a6a75 Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch:

osmo-bts[master]: use osmo_init_logging2() with proper talloc ctx

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7603 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic049f77bef74123b95350bcae182a468e0086b9c Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH

Review at https://gerrit.osmocom.org/7632 fox chan_nr_is_dchan() for RSL_CHAN_OSMO_PDCH When writing chan_nr_is_dchan() in Change-Id: I43a78bec63aeb36dd67043d237b27fe880209349, I apparently only looked at TS 48.058 without considering the osmocom extension to it for PDCH activation. The

[PATCH] osmo-bts[master]: use osmo_init_logging2() with proper talloc ctx

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7603 to look at the new patch set (#3). use osmo_init_logging2() with proper talloc ctx Completely drop bts_log_init(), call osmo_init_logging2() directly instead: all callers of

[PATCH] osmo-bts[master]: use osmo_init_logging2() with proper talloc ctx

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7603 to look at the new patch set (#2). use osmo_init_logging2() with proper talloc ctx Completely drop bts_log_init(), call osmo_init_logging2() directly instead: all callers of

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #77

See -- [...truncated 3.76 KB...] checking build system type... x86_64-unknown-linux-gnu checking host system type...

[PATCH] osmo-gsm-tester[master]: ms: Create a cumulative distribution function class

Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6230 to look at the new patch set (#8). ms: Create a cumulative distribution function class We are using the CDF to decide which percentage of

osmocom-bb[fixeria/trx]: trxcon/l1ctl.c: hexdump content of unhandled messages

Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/7414/4/src/host/trxcon/l1ctl.c File src/host/trxcon/l1ctl.c: Line 797: LOGP(DL1C, LOGL_ERROR, "Unknown MSG type %u: %s\n", l1h->msg_type, > don't we have a value_string for this? Not yet. There is:

osmocom-bb[fixeria/trx]: trxcon/l1ctl.c: hexdump content of unhandled messages

Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/7414/4/src/host/trxcon/l1ctl.c File src/host/trxcon/l1ctl.c: Line 797: LOGP(DL1C, LOGL_ERROR, "Unknown MSG type %u: %s\n", l1h->msg_type, don't we have a value_string for this? -- To view, visit

libosmocore[master]: gsm0480: drop messages with incorrect data length

Patch Set 1: > Pleased use a proper logging subsystem - if nothing else applies, > DLGLOBAL Done. Probably, we would need to also change the logging target for the whole GSM 04.80 code. -- To view, visit https://gerrit.osmocom.org/7630 To unsubscribe, visit

[PATCH] libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7625 to look at the new patch set (#2). gsm0480: copy the raw USSD data, its DCS and length As it was already documented before, the 'ss_request' struct has a rudiment of deprecated

[PATCH] libosmocore[master]: gsm0480: drop messages with incorrect data length

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7630 to look at the new patch set (#2). gsm0480: drop messages with incorrect data length If either an INVOKE, either a RETURN_RESULT component has the data with incorrect length (see Annex

libosmocore[master]: fsm: collapse an empty id to a NULL id, adjust api doc

Patch Set 1: Code-Review+1 Unit Test -- To view, visit https://gerrit.osmocom.org/7628 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fa6e13ec1c2ab204b6229f4e3fa5f2c0d53a2ba Gerrit-PatchSet: 1 Gerrit-Project: libosmocore

libosmocore[master]: fsm: id: properly set name in case of NULL id

Patch Set 1: Code-Review+1 Unit test? -- To view, visit https://gerrit.osmocom.org/7627 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d6b09a811b82770818f19b189a57d9fc4a8133b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore

libosmocore[master]: fsm: id: properly set name in case of NULL id

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7627 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d6b09a811b82770818f19b189a57d9fc4a8133b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: add osmo_fsm_inst_update_id_f()

Patch Set 1: Fine with me, but should have unit test coverage, including check for no memleak? -- To view, visit https://gerrit.osmocom.org/7629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76743a7642f2449fd33350691ac8ebbf4400371d

libosmocore[master]: gsm0480: drop messages with incorrect data length

Patch Set 1: Pleased use a proper logging subsystem - if nothing else applies, DLGLOBAL -- To view, visit https://gerrit.osmocom.org/7630 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a169b0b84aa26ea2521edd55ff005c27ae6d808

libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Patch Set 1: NeedsmTODO-RELEASE as it breaks ABI -- To view, visit https://gerrit.osmocom.org/7625 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia193d175021e145bb3b131290231f307dbefc64a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore

[PATCH] libosmocore[master]: gsm0480: fix: don't overwrite the data of RELEASE_COMPLETE

Review at https://gerrit.osmocom.org/7631 gsm0480: fix: don't overwrite the data of RELEASE_COMPLETE According to the 3GPP TS 04.80, table 2.5 'Release complete', a RELEASE_COMPLETE message may containg optional FACILITY element. Meanwhile, the 0xff byte is used to indicate that there is no

[PATCH] libosmocore[master]: gsm0480: drop messages with incorrect data length

Review at https://gerrit.osmocom.org/7630 gsm0480: drop messages with incorrect data length If either an INVOKE, either a RETURN_RESULT component has the data with incorrect length (see Annex A, 3GPP TS 04.80), the whole message is probably incorrect. Let's drop such messages instead of

libosmocore[master]: add osmo_fsm_inst_update_id_f()

Patch Set 1: I'm not sure if this is just code bloat or worth the API real estate. What do you guys think? -- To view, visit https://gerrit.osmocom.org/7629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] libosmocore[master]: add osmo_fsm_inst_update_id_f()

Review at https://gerrit.osmocom.org/7629 add osmo_fsm_inst_update_id_f() In the osmo-msc, I would like to set the subscr conn FSM identifier by a string format, to include the type of Complete Layer 3 that is taking place. I could each time talloc a string and free it again. This API is more

[PATCH] libosmocore[master]: fsm: collapse an empty id to a NULL id, adjust api doc

Review at https://gerrit.osmocom.org/7628 fsm: collapse an empty id to a NULL id, adjust api doc If the FSM instance id were passed as empty string, we would print "()" in the instance name. Instead, evaluate an empty id just like a NULL id. Describe that properly in the API docs. Change-Id:

[PATCH] libosmocore[master]: fsm: id: properly set name in case of NULL id

Review at https://gerrit.osmocom.org/7627 fsm: id: properly set name in case of NULL id Since alloc relies on osmo_fsm_inst_update_id() to set the name, never skip that. In osmo_fsm_inst_alloc(), we allow passing a NULL id, and in osmo_fsm_inst_update_id(), we set the name without id if id is

libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7625/1/include/osmocom/gsm/gsm0480.h File include/osmocom/gsm/gsm0480.h: Line 77:uint8_t ussd_data[GSM0480_USSD_OCTET_STRING_LEN]; > why do we have the new fields in addition to the old fields? Can a single > why do we have the

osmocom-bb[fixeria/trx]: trxcon/l1ctl.c: hexdump content of unhandled messages

Patch Set 4: ping. This and previous commit have been here with a +1 for 2 weeks now. Is there something preventing to +2 and merge them? -- To view, visit https://gerrit.osmocom.org/7414 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-gsm-tester[master]: Drop event_loop global functions and import MainLoop

Pau Espin Pedrol has submitted this change and it was merged. Change subject: Drop event_loop global functions and import MainLoop .. Drop event_loop global functions and import MainLoop Take the chance to identify and drop

[MERGED] osmo-gsm-tester[master]: event_loop: Use glib as mainloop impl and move modem to use ...

Pau Espin Pedrol has submitted this change and it was merged. Change subject: event_loop: Use glib as mainloop impl and move modem to use event_loop .. event_loop: Use glib as mainloop impl and move modem to use event_loop

osmo-gsm-tester[master]: nanobts: Attempt at fixing race condition using ipaccess-con...

Patch Set 1: Tested running several times in prod and no conn rejected from nanobts. Merging. -- To view, visit https://gerrit.osmocom.org/7626 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec8adb2cd13d808a6ca1843dc95b81bd1a97d1c0

osmo-gsm-tester[master]: event_loop: Use glib as mainloop impl and move modem to use ...

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7559 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3bc44bbe443703077110cdc67207e9cbb43767 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: Drop event_loop global functions and import MainLoop

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7560 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa1940cd00138ebc72fbcfd45a0e28246f7a5ed9 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: nanobts: Attempt at fixing race condition using ipaccess-con...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7626 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec8adb2cd13d808a6ca1843dc95b81bd1a97d1c0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

[PATCH] osmo-gsm-tester[master]: nanobts: Attempt at fixing race condition using ipaccess-con...

Review at https://gerrit.osmocom.org/7626 nanobts: Attempt at fixing race condition using ipaccess-config after power up It seems there's a period of time in between the nanoBTS starts announcing itself and it can actually be managed by the BSC (ipaccess-config in this case). If

osmo-ttcn3-hacks[master]: document the purpose of IP addresses used by GGSN tests

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7617 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I079efcff3dab09d71330625f5b661cd81e42bf38 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: document the purpose of IP addresses used by GGSN tests

Harald Welte has submitted this change and it was merged. Change subject: document the purpose of IP addresses used by GGSN tests .. document the purpose of IP addresses used by GGSN tests The purpose of the various IP

libosmocore[master]: cosmetic: flatten ctrl_handle_msg()

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7619 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a711f5c974b7f56e27b333d390d1a706fb57007 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: ctrl: fix deferred commands (and hence fix osmo-bts-sysmo 'c...

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7618/1/include/osmocom/ctrl/control_cmd.h File include/osmocom/ctrl/control_cmd.h: Line 69:struct ctrl_cmd_def *defer; doesn't this constitute an ABI change and hence require an entry in TOOO-RELEASE? -- To view, visit

[MERGED] osmo-ttcn3-hacks[master]: bts: enable CTRL interface tests

Harald Welte has submitted this change and it was merged. Change subject: bts: enable CTRL interface tests .. bts: enable CTRL interface tests Start and stop the CTRL interface and provide CTRL bind interface config

[MERGED] docker-playground[master]: ttcn3-bts-test: properly configure CTRL interface

Harald Welte has submitted this change and it was merged. Change subject: ttcn3-bts-test: properly configure CTRL interface .. ttcn3-bts-test: properly configure CTRL interface osmo-ttcn3-hacks adds configuration of the CTRL

docker-playground[master]: ttcn3-bts-test: properly configure CTRL interface

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7622 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec86b157ebd46bf622a0ca51eba225f15c99fbb Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch: master

docker-playground[master]: ttcn3-bts-test: properly configure CTRL interface

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7622 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec86b157ebd46bf622a0ca51eba225f15c99fbb Gerrit-PatchSet: 1 Gerrit-Project: docker-playground Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: enable CTRL interface tests

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7621 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I502b4891e6720ae2fb251c03542f707880a6f728 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: test GGSN support for optional GTP-U sequence numbers

Patch Set 1: (10 comments) https://gerrit.osmocom.org/#/c/7623/1/ggsn_tests/GGSN_Tests.ttcn File ggsn_tests/GGSN_Tests.ttcn: Line 196: } while (g_d_seq_nr == 0); > All this way of differentiating looks tricky. What about if we want to test I agree. The more "TTCN-3-esque"

libosmocore[master]: gsm0480: document the 'ss_request' structure

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7624 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22144dd759e0c1bb1965574b7ddd676606e5d6b7 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: gsm0480: copy the raw USSD data, its DCS and length

Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/7625/1/include/osmocom/gsm/gsm0480.h File include/osmocom/gsm/gsm0480.h: Line 77:uint8_t ussd_data[GSM0480_USSD_OCTET_STRING_LEN]; why do we have the new fields in addition to the old fields? Can a single message contain both