[PATCH] osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

2018-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7771 to look at the new patch set (#2). */regen_makefile.sh: drop multiple naming of main ttcn file In FILES="*.ttcn", the main FOO_Tests.ttcn is already included, no need to name it a

osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

2018-04-11 Thread Neels Hofmeyr
Patch Set 2: Is there any reason why the main file should be listed first? Couldn't see any adverse effects in running the BSC tests without that. -- To view, visit https://gerrit.osmocom.org/7771 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-ttcn3-hacks[master]: bsc/regen_makefile.sh: drop multiple naming of BSC_Tests.ttcn

2018-04-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7771 bsc/regen_makefile.sh: drop multiple naming of BSC_Tests.ttcn Change-Id: I94f37d64198ce2e36c5cd8892ccd33987e1fba32 --- M bsc/regen_makefile.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks

Jenkins build is back to normal : master-osmo-bts » lc15,origin/nrw/litecell15-next,default,osmocom-master-debian9 #501

2018-04-11 Thread jenkins
See

Build failed in Jenkins: master-osmo-bts » lc15, origin/nrw/litecell15-next,default,osmocom-master-debian9 #500

2018-04-11 Thread jenkins
See -- [...truncated 112.74 KB...] + project=libosmo-abis + branch=master

Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #909

2018-04-11 Thread jenkins
See

[MERGED] osmo-msc[master]: fix BSC Clear Request

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix BSC Clear Request .. fix BSC Clear Request On receiving a Clear Request, don't send a Clear Command "out of band", let the FSM do the release

[MERGED] osmo-msc[master]: cosmetic: embed compl_l3_type in FSM id

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: embed compl_l3_type in FSM id .. cosmetic: embed compl_l3_type in FSM id In the subscr_conn_fsm instance's ID, include the Complete Layer 3

[MERGED] osmo-msc[master]: refactor subscr_conn and subscr_conn_fsm de-/alloc

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: refactor subscr_conn and subscr_conn_fsm de-/alloc .. refactor subscr_conn and subscr_conn_fsm de-/alloc Refactor: 1. Glue the

[MERGED] osmo-msc[master]: CC: intentionally release T308 on BSSMAP Clear Request from BSC

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: CC: intentionally release T308 on BSSMAP Clear Request from BSC .. CC: intentionally release T308 on BSSMAP Clear Request from BSC So far we hit a

osmo-msc[master]: properly receive BSSMAP Clear Complete and Iu Release Complete

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7706 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4c6aaba3866d6e5b98004e8870a215e8cf8ffc1 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: refactor subscr_conn and subscr_conn_fsm de-/alloc

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7705 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55feb379e176a96a831e105b86202b17a0ffe889 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: CC: intentionally release T308 on BSSMAP Clear Request from BSC

2018-04-11 Thread Harald Welte
Patch Set 2: If the bsc tells us the (radio) connection is gone , there would be no point in giving transactions more time to clean up. -- To view, visit https://gerrit.osmocom.org/7704 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-msc[master]: CC: intentionally release T308 on BSSMAP Clear Request from BSC

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7704 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231fdb574a086a206321148474cbdc7ca9cf39f0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: mask timestamps and source file nrs in expected-results.xml ...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: mask timestamps and source file nrs in expected-results.xml files .. mask timestamps and source file nrs in expected-results.xml files Prepare for

osmo-ttcn3-hacks[master]: add update_expected_results_from_jenkins.sh

2018-04-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7754 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ad8554fc59112c11325425ccd70ca1dbd8c123 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: gsm-tester-bts: add OBS osmocom:nightly to install osmocom utilities .. ansible: gsm-tester-bts: add OBS osmocom:nightly to install osmocom

[MERGED] osmo-ci[master]: osmocom-jenkins-slave: call fstrim periodically

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-jenkins-slave: call fstrim periodically .. osmocom-jenkins-slave: call fstrim periodically Change-Id: I82c497f476abf43148e8d7c027f53b87b5a738fb

[MERGED] osmo-ttcn3-hacks[master]: add update_expected_results_from_jenkins.sh

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add update_expected_results_from_jenkins.sh .. add update_expected_results_from_jenkins.sh Change-Id: Ib3ad8554fc59112c11325425ccd70ca1dbd8c123 --- A

[MERGED] osmo-ci[master]: ansible: gsm-tester: move usrp tasks to gsm-tester-bts

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: gsm-tester: move usrp tasks to gsm-tester-bts .. ansible: gsm-tester: move usrp tasks to gsm-tester-bts Change-Id:

[MERGED] osmo-ci[master]: ansible: hosts: gsm-tester: use ansible_host to have more re...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: hosts: gsm-tester: use ansible_host to have more readable ansible output .. ansible: hosts: gsm-tester: use ansible_host to have more readable

[MERGED] osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: gsm-tester-bts: install ip.access dependencies .. ansible: gsm-tester-bts: install ip.access dependencies Change-Id:

osmo-ttcn3-hacks[master]: mask timestamps and source file nrs in expected-results.xml ...

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7753 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f006aa8db1b477598605e0525faeb229b03641 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ci[master]: ansible: add role udhcpd: setup a udhcpd server

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: add role udhcpd: setup a udhcpd server .. ansible: add role udhcpd: setup a udhcpd server Change-Id: Ia272ae9c2b245d0a06f84b91f50dd875d4488e02

osmo-ttcn3-hacks[master]: bsc, msc: update expected results

2018-04-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7755 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3a36efeb086fd995d7dad4e040f5a46b1b1ca0a Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ci[master]: ansible: gsm-tester: install sispmctl to control usb power s...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: gsm-tester: install sispmctl to control usb power sockets .. ansible: gsm-tester: install sispmctl to control usb power sockets Change-Id:

[MERGED] osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: setup-gsm-tester: use udhcpd as dhcp server .. ansible: setup-gsm-tester: use udhcpd as dhcp server Required for ip.access Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: bsc, msc: update expected results

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc, msc: update expected results .. bsc, msc: update expected results Mark TC_paging_imsi_a_reset fixed. Add various new tests. Change-Id:

[MERGED] osmo-ci[master]: ansible: gsm-tester-modems: improve name

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ansible: gsm-tester-modems: improve name .. ansible: gsm-tester-modems: improve name Use same scheme as of gsm-tester-bts. This should improve

[MERGED] osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add mask_expected_results.sh .. add mask_expected_results.sh Provide a script to mask timestamps and source file lines in expected results files: when

osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7752 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785e126b1f5afddd1b722bc5e922ed90970efa8a Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-11 Thread Harald Welte
Patch Set 1: Please also test with osmo-bts -- To view, visit https://gerrit.osmocom.org/7770 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I097a113a3a63de02bcb8277020beb59cf485b176 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc

[MERGED] osmo-bsc[master]: rename helper functions in the acc ramp code to avoid confusion

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rename helper functions in the acc ramp code to avoid confusion .. rename helper functions in the acc ramp code to avoid confusion The word 'enabled'

osmo-bsc[master]: rename helper functions in the acc ramp code to avoid confusion

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7750 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia67e84270cd50f4c55b8cf616ca38b00482f765c Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

libosmocore[master]: msgb: msgb_get: Drop unneeded tmp var

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7768 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bb2ab59408c9cd1363b3b5acb2263128c55732 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: msgb: msgb_get: Drop unneeded tmp var

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msgb: msgb_get: Drop unneeded tmp var .. msgb: msgb_get: Drop unneeded tmp var Change-Id: I27bb2ab59408c9cd1363b3b5acb2263128c55732 --- M

[MERGED] libosmocore[master]: msgb: msgb_pull: Abort when pulling more than avail size

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msgb: msgb_pull: Abort when pulling more than avail size .. msgb: msgb_pull: Abort when pulling more than avail size Change-Id:

libosmocore[master]: msgb: msgb_pull: Abort when pulling more than avail size

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7769 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512ff2035ae7a929e6c96df82938cc1ddbcc4e2a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: msgb: msgb_pull: Abort when pulling more than avail size

2018-04-11 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7769 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512ff2035ae7a929e6c96df82938cc1ddbcc4e2a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: msgb: msgb_get: Drop unneeded tmp var

2018-04-11 Thread Vadim Yanitskiy
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/7768 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bb2ab59408c9cd1363b3b5acb2263128c55732 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmo-bsc[master]: rename helper functions in the acc ramp code to avoid confusion

2018-04-11 Thread Stefan Sperling
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7750 to look at the new patch set (#2). rename helper functions in the acc ramp code to avoid confusion The word 'enabled' was used in two contexts: Whether ACC ramp is

[PATCH] osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-11 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7770 trigger acc ramping on state-changed-event reports Trigger ACC ramping not only when an Administrative State Change ACK is received from a BTS, but also when an administrative state change is reported for TRX 0 in a State Changed Event Report. This

[PATCH] libosmocore[master]: msgb: msgb_pull: Abort when pulling more than avail size

2018-04-11 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7769 msgb: msgb_pull: Abort when pulling more than avail size Change-Id: I512ff2035ae7a929e6c96df82938cc1ddbcc4e2a --- M include/osmocom/core/msgb.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[PATCH] libosmocore[master]: msgb: msgb_get: Drop unneeded tmp var

2018-04-11 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7768 msgb: msgb_get: Drop unneeded tmp var Change-Id: I27bb2ab59408c9cd1363b3b5acb2263128c55732 --- M include/osmocom/core/msgb.h 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/68/7768/1

[PATCH] osmo-ttcn3-hacks[master]: add update_expected_results_from_jenkins.sh

2018-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7754 to look at the new patch set (#3). add update_expected_results_from_jenkins.sh Change-Id: Ib3ad8554fc59112c11325425ccd70ca1dbd8c123 --- A update_expected_results_from_jenkins.sh 1 file

osmo-ttcn3-hacks[master]: add update_expected_results_from_jenkins.sh

2018-04-11 Thread Neels Hofmeyr
Patch Set 2: > I think this script deserves some usage documentation / comments? It's fire and forget, but agreed. -- To view, visit https://gerrit.osmocom.org/7754 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-ttcn3-hacks[master]: mask timestamps and source file nrs in expected-results.xml ...

2018-04-11 Thread Neels Hofmeyr
Patch Set 2: we still want the timings to show up in jenkins. The masking script only masks the expected-results.xml, for the sole purpose that updating the expected results by overwriting with a new file doesn't diff all over the place, but only exactly where we changed an expectation. The

[PATCH] osmo-ttcn3-hacks[master]: mask timestamps and source file nrs in expected-results.xml ...

2018-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7753 to look at the new patch set (#2). mask timestamps and source file nrs in expected-results.xml files Prepare for upcoming updates with concise diffs. Change-Id:

[PATCH] osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7752 to look at the new patch set (#2). add mask_expected_results.sh Provide a script to mask timestamps and source file lines in expected results files: when updating

osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7752/1/mask_expected_results.sh File mask_expected_results.sh: Line 5: sed -i "s/time='[^']*'/time='MASKED'/g" "$target" > does the "MASKED" still constitute valid Juni2-XML? Is there a DTD availabl not sure if the timestamp number

osmo-ttcn3-hacks[master]: fix build: don't clean out expected-results.log: rename to *...

2018-04-11 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7751 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic334f6b758eef865e3a497aa430691a3ae696d25 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[MERGED] osmo-ttcn3-hacks[master]: fix build: don't clean out expected-results.log: rename to *...

2018-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: fix build: don't clean out expected-results.log: rename to *.xml .. fix build: don't clean out expected-results.log: rename to *.xml 'make clean' as

[PATCH] osmo-ttcn3-hacks[master]: fix build: don't clean out expected-results.log: rename to *...

2018-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7751 to look at the new patch set (#2). fix build: don't clean out expected-results.log: rename to *.xml 'make clean' as generated by ttcn3_makefilegen removes all *.log

osmo-ci[master]: ansible: add role udhcpd: setup a udhcpd server

2018-04-11 Thread Pau Espin Pedrol
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7735 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia272ae9c2b245d0a06f84b91f50dd875d4488e02 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: add role udhcpd: setup a udhcpd server

2018-04-11 Thread lynxis lazus
Patch Set 1: Verified+1 (1 comment) https://gerrit.osmocom.org/#/c/7735/1/ansible/roles/udhcpd/defaults/main.yml File ansible/roles/udhcpd/defaults/main.yml: Line 16: udhcpd_static_leases: [] > we are missing the leases here? no. this is the default value. it will be overridden from outside.

osmo-ci[master]: osmocom-jenkins-slave: call fstrim periodically

2018-04-11 Thread lynxis lazus
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7724 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c497f476abf43148e8d7c027f53b87b5a738fb Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: setup-gsm-tester: use udhcpd as dhcp server

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7736 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae43ebcd3c87e625110d8ff6afa0476f4b1facf Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester: move usrp tasks to gsm-tester-bts

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7738 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9caebed94c3473051b82e2cdc35f6dfb9f862084 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-modems: improve name

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7739 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4186baaf565442c96555b723622c93b1cbd9f4f7 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-bts: install ip.access dependencies

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7737 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47f578c4b9bb7b1dc81ccf93a7e82a335f6968a2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester-bts: add OBS osmocom:nightly to install ...

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7741 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b704d402c83db54401d1c06acb715cce821f2e4 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: hosts: gsm-tester: use ansible_host to have more re...

2018-04-11 Thread lynxis lazus
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7734 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b60ace8afd0e2cc47c535da1856d4f34fdd735 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ci[master]: ansible: gsm-tester: install sispmctl to control usb power s...

2018-04-11 Thread lynxis lazus
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7740 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1af197d4b24e25196e10d2afa3ab8eea73ad729 Gerrit-PatchSet: 2 Gerrit-Project: osmo-ci Gerrit-Branch: master

osmo-ttcn3-hacks[master]: MNCC: don't delete call table entries

2018-04-11 Thread Harald Welte
Patch Set 1: > Seems to ma a test case shall decide when to clean up the call > table entries. > IIUC, it's impossible to derive what the test wants to do with the > call and discard automatically in all the right places. > So we'd make f_call_table_del() non-private and call that from test

[MERGED] osmo-pcu[master]: cosmetic: remove runaway semicolon

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: remove runaway semicolon .. cosmetic: remove runaway semicolon Change-Id: I33c335dc8d564a8357ffb5b1163c2c4b1a578b49 Related: SYS#4139

[MERGED] osmo-pcu[master]: pcu_l1_if: add frame number to log output

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_l1_if: add frame number to log output .. pcu_l1_if: add frame number to log output Currently, the log output lacks the frame number. - make

[MERGED] osmo-bsc[master]: ensure that acc_ramp_init() is only called once

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: ensure that acc_ramp_init() is only called once .. ensure that acc_ramp_init() is only called once There are plans to register signal handlers in

[MERGED] osmo-bsc[master]: trigger acc ramping based on trx rf-locked state

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: trigger acc ramping based on trx rf-locked state .. trigger acc ramping based on trx rf-locked state Make ACC ramping listen to network management

[MERGED] osmo-bsc[master]: bsc_nat: forward_to_bsc: remove one level of indentation

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: forward_to_bsc: remove one level of indentation .. bsc_nat: forward_to_bsc: remove one level of indentation Change-Id:

[MERGED] osmo-bsc[master]: libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorr...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc .. libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc

[MERGED] osmo-bsc[master]: bsc_nat: ctrl: fix memleak on reply receival

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: ctrl: fix memleak on reply receival .. bsc_nat: ctrl: fix memleak on reply receival Change-Id: I163d4d12d8656628dc88ff3e59a4c3e53b760a0c --- M

[MERGED] openbsc[master]: libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorr...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc .. libbsc: set_net_mcc_mnc_apply: Fix memleak on parsing incorrect mcc mnc

[MERGED] openbsc[master]: bsc_nat: ctrl: fix memleak on reply receival

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: ctrl: fix memleak on reply receival .. bsc_nat: ctrl: fix memleak on reply receival Change-Id: I146c4a561b0cd62779d60da3b55b96e24438bd89 --- M

[MERGED] openbsc[master]: bsc_nat: forward_to_bsc: remove one level of indentation

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: forward_to_bsc: remove one level of indentation .. bsc_nat: forward_to_bsc: remove one level of indentation Change-Id:

[MERGED] openbsc[master]: bsc_nat: forward_to_bsc: Fix memleak on send failure

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: forward_to_bsc: Fix memleak on send failure .. bsc_nat: forward_to_bsc: Fix memleak on send failure Change-Id:

[MERGED] openbsc[master]: bsc_nat: Drop redundant ccon ptr in bsc_cmd_list

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: Drop redundant ccon ptr in bsc_cmd_list .. bsc_nat: Drop redundant ccon ptr in bsc_cmd_list Change-Id:

[MERGED] osmo-bsc[master]: bsc_nat: forward_to_bsc: Fix memleak on send failure

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: forward_to_bsc: Fix memleak on send failure .. bsc_nat: forward_to_bsc: Fix memleak on send failure Change-Id:

[MERGED] osmo-bsc[master]: bsc_nat: Drop redundant ccon ptr in bsc_cmd_list

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: Drop redundant ccon ptr in bsc_cmd_list .. bsc_nat: Drop redundant ccon ptr in bsc_cmd_list It can be obtained from cmd field, so no need to

[MERGED] openbsc[master]: bsc_nat: ctrl: Fix crash on receveing bsc reply

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bsc_nat: ctrl: Fix crash on receveing bsc reply .. bsc_nat: ctrl: Fix crash on receveing bsc reply Since libosmocore

[MERGED] osmo-bsc[master]: only log actual access control class ramping changes

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: only log actual access control class ramping changes .. only log actual access control class ramping changes Silence log messages about no-op changes to

[MERGED] osmo-ci[master]: osmocom-jenkins-slave: install gsm-manual dependencies

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmocom-jenkins-slave: install gsm-manual dependencies .. osmocom-jenkins-slave: install gsm-manual dependencies Change-Id:

osmo-ci[master]: jobs: master-builds.yml: allow osmo-gsm-manuals to build any...

2018-04-11 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7727 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5fe39b643e7a15dbfd2efd55dce78dde30cf099 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-ci[master]: jobs: master-builds.yml: allow osmo-gsm-manuals to build any...

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jobs: master-builds.yml: allow osmo-gsm-manuals to build anywhere .. jobs: master-builds.yml: allow osmo-gsm-manuals to build anywhere When

osmo-ci[master]: osmocom-jenkins-slave: install gsm-manual dependencies

2018-04-11 Thread Harald Welte
Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/7726 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa60bd986220e065b1e9eca4308f2b089d505d9 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: MSC_Tests: fix TC_mo_crcx_ran_reject

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: MSC_Tests: fix TC_mo_crcx_ran_reject .. MSC_Tests: fix TC_mo_crcx_ran_reject The testcase intentionally responds to the RAN sided CRCX with a garbeled

osmo-ttcn3-hacks[master]: mask timestamps and source file nrs in expected-results.xml ...

2018-04-11 Thread Harald Welte
Patch Set 1: see my other comment. Not sure if this is still valid Junit2-XML. Various parsers might expect a float value, not some string? As the "time" attribute is an optional attribute AFAICT, it might be best to find or implement a way to suppress it being generated by titan in the

[MERGED] osmo-msc[master]: msc_mgcp: do not send wildcarded DLCX messages

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc_mgcp: do not send wildcarded DLCX messages .. msc_mgcp: do not send wildcarded DLCX messages If an error on the MGW side occurs, the MSC may send

osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Harald Welte
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7752/1/mask_expected_results.sh File mask_expected_results.sh: Line 5: sed -i "s/time='[^']*'/time='MASKED'/g" "$target" does the "MASKED" still constitute valid Juni2-XML? Is there a DTD available somewhere for Junit2-XML? Did you try

osmo-bsc[master]: bsc_nat: forward_to_bsc: Fix memleak on send failure

2018-04-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7758 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56235eb05e4beed1bf9151319b64d67de4718e36 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: add mask_expected_results.sh

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7752 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I785e126b1f5afddd1b722bc5e922ed90970efa8a Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: fix build: don't clean out expected-results.log: rename to *...

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7751 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic334f6b758eef865e3a497aa430691a3ae696d25 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: add update_expected_results_from_jenkins.sh

2018-04-11 Thread Harald Welte
Patch Set 1: I think this script deserves some usage documentation / comments? -- To view, visit https://gerrit.osmocom.org/7754 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3ad8554fc59112c11325425ccd70ca1dbd8c123 Gerrit-PatchSet: 1

osmo-msc[master]: msc_mgcp.c: log endpoint name instead of pointer

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7762 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01b3d07aeedd72be60361249a5bf80fbb68b7bb8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: msc_mgcp.c: log endpoint name instead of pointer

2018-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc_mgcp.c: log endpoint name instead of pointer .. msc_mgcp.c: log endpoint name instead of pointer The logtext currently logs the pointer (address) of

osmo-msc[master]: msc_mgcp: do not send wildcarded DLCX messages

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7763 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64c2a82016d854ad446fd49a5d76a28324e8bd4b Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-bsc[master]: bsc_nat: forward_to_bsc: remove one level of indentation

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7756 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12d86a45a6b2cdc3af7a7b6c28f8f337fa95c903 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

openbsc[master]: bsc_nat: Drop redundant ccon ptr in bsc_cmd_list

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7761 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e4ca7d8eb4e8f71dc773b3f2c0f09709d90a94 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: bsc_nat: forward_to_bsc: Fix memleak on send failure

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7759 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0dfae40f03db297eeb4e296daf5fe78ba53a11b Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: bsc_nat: forward_to_bsc: remove one level of indentation

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7757 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I105be500399259a97ef711f17b4a51e72dc8cc53 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: bsc_nat: ctrl: Fix crash on receveing bsc reply

2018-04-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7764 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e1fb79746d4a4f3e30254fdb7a7e851c2cd0e4 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master

  1   2   >