Change in osmo-mgw[master]: mgcp-client: add mgcp_conn_get_ci()

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/9586


Change subject: mgcp-client: add mgcp_conn_get_ci()
..

mgcp-client: add mgcp_conn_get_ci()

Return the CI string allocated by the MGW and sent back during CRCX ACK.

So far the CI that identifies one connection of an MGW endpoint is "hidden"
behind mgcp_conn_* API. This CI string is however very interesting, for
logging, to be able to correlate with MGCP messages in network traces.

For osmo-bsc, there is an upcoming mgw_endpoint_fsm that will log the CI string
using this function.

Change-Id: I0c802c0cc3fa0aae9558bd7f15aad1cb9a8b12b2
---
M include/osmocom/mgcp_client/mgcp_client_fsm.h
M src/libosmo-mgcp-client/mgcp_client_fsm.c
2 files changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/86/9586/1

diff --git a/include/osmocom/mgcp_client/mgcp_client_fsm.h 
b/include/osmocom/mgcp_client/mgcp_client_fsm.h
index 7d06178..93fe582 100644
--- a/include/osmocom/mgcp_client/mgcp_client_fsm.h
+++ b/include/osmocom/mgcp_client/mgcp_client_fsm.h
@@ -31,3 +31,5 @@
   uint32_t parent_evt, struct 
mgcp_conn_peer *conn_peer);
 int mgcp_conn_modify(struct osmo_fsm_inst *fi, uint32_t parent_evt, struct 
mgcp_conn_peer *conn_peer);
 void mgcp_conn_delete(struct osmo_fsm_inst *fi);
+
+const char *mgcp_conn_get_ci(struct osmo_fsm_inst *fi);
diff --git a/src/libosmo-mgcp-client/mgcp_client_fsm.c 
b/src/libosmo-mgcp-client/mgcp_client_fsm.c
index 6f84ffa..10a5b6d 100644
--- a/src/libosmo-mgcp-client/mgcp_client_fsm.c
+++ b/src/libosmo-mgcp-client/mgcp_client_fsm.c
@@ -215,6 +215,14 @@
}
 }

+/* Return the CI that the MGW allocated during CRCX response. This is purely 
informational for logging
+ * and identity tracking; the mgcp_conn_*() functions take care of using the 
right CI internally. */
+const char *mgcp_conn_get_ci(struct osmo_fsm_inst *fi)
+{
+   struct mgcp_ctx *mgcp_ctx = fi->priv;
+   return mgcp_ctx->conn_id;
+}
+
 static void mgw_crcx_resp_cb(struct mgcp_response *r, void *priv)
 {
struct osmo_fsm_inst *fi = priv;

--
To view, visit https://gerrit.osmocom.org/9586
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c802c0cc3fa0aae9558bd7f15aad1cb9a8b12b2
Gerrit-Change-Number: 9586
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 

Change in osmo-ttcn3-hacks[master]: sgsn: TC_hlr_location_cancel_request_update: remove superflous Update...

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9580


Change subject: sgsn: TC_hlr_location_cancel_request_update: remove superflous 
Update Location Response
..

sgsn: TC_hlr_location_cancel_request_update: remove superflous Update Location 
Response

There shouldn't be any update location pending

Change-Id: I94b9307311a8095065212e1820cacc6cd2be0a3a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/80/9580/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 802c3e6..f812fbe 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1255,7 +1255,6 @@
/* HLR: cancel the location request */
GSUP.send(ts_GSUP_CL_REQ(g_pars.imsi, OSMO_GSUP_CANCEL_TYPE_UPDATE));
GSUP.receive(tr_GSUP_CL_RES(g_pars.imsi));
-   GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));

/* ensure no Detach Request got received */
timer T := 5.0;

--
To view, visit https://gerrit.osmocom.org/9580
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94b9307311a8095065212e1820cacc6cd2be0a3a
Gerrit-Change-Number: 9580
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: lib/BSSGP_Emulation: fix removal of items in ClientList

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9582


Change subject: lib/BSSGP_Emulation: fix removal of items in ClientList
..

lib/BSSGP_Emulation: fix removal of items in ClientList

Previous the old entries aren't removed. This only had an
impact if two different f_TC_* were using the same imsi.
When the second function tried to remove the Client again from
the ClientList, the BSSGP_Emulation failed.

Change-Id: I71103e8f8c5f18e8ebadc057cd62d85affd7ca8c
---
M library/BSSGP_Emulation.ttcn
1 file changed, 8 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/82/9582/1

diff --git a/library/BSSGP_Emulation.ttcn b/library/BSSGP_Emulation.ttcn
index 38666b8..540413c 100644
--- a/library/BSSGP_Emulation.ttcn
+++ b/library/BSSGP_Emulation.ttcn
@@ -297,12 +297,18 @@
for (i := 0; i < sizeof(ClientTable); i := i+1) {
if (isvalue(ClientTable[i].imsi) and ClientTable[i].imsi == 
imsi) {
if (ClientTable[i].comp_ref != vc_conn) {
-   setverdict(fail, "Cannot unregister IMSI ", 
imsi, " registred to ",
+   setverdict(fail, "Cannot unregister index=", i, 
" IMSI ", imsi, " registred to ",
   ClientTable[i].comp_ref, " from ", 
vc_conn);
self.stop;
}
log("Removing Client IMSI=", imsi, ", index=", i);
-   ClientTable[i] := { -, omit, -, -, - };
+   ClientTable[i] := {
+   tlli := -,
+   tlli_old := omit,
+   imsi := ''H,
+   cell_id := -,
+   comp_ref := -,
+   llc := - };
return;
}
}

--
To view, visit https://gerrit.osmocom.org/9582
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71103e8f8c5f18e8ebadc057cd62d85affd7ca8c
Gerrit-Change-Number: 9582
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_check_complete_resend()

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9585


Change subject: sgsn: add TC_attach_check_complete_resend()
..

sgsn: add TC_attach_check_complete_resend()

MS -> SGSN: Attach Request IMSI
MS <- SGSN: Identity Request *
MS -> SGSN: Identity Response *
MS <- SGSN: Attach Complete 5x

Change-Id: I9bbbda01f3c41a2f8acf13042d6bcc86f18d74ce
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 37 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/85/9585/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 466c3ed..017c724 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1553,6 +1553,42 @@
vc_conn.done;
 }

+/* Attempt an attach, but never answer a Attach Complete */
+private function f_TC_attach_check_complete_resend(charstring id) runs on 
BSSGP_ConnHdlr {
+   var integer count_req := 0;
+
+   BSSGP.send(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, 
false, omit, omit));
+   f_gmm_auth();
+
+   alt {
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_REJECT(?))) {
+   /* break */
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_ACCEPT(*, *, *))) {
+   /* ignore */
+   count_req := count_req + 1;
+   repeat;
+   }
+   }
+   if (count_req != 5) {
+   setverdict(fail, "Did not received GMM Attach Complete.");
+   }
+   setverdict(pass);
+}
+
+testcase TC_attach_check_complete_resend() runs on test_CT {
+   /* MS -> SGSN: Attach Request IMSI
+* MS <- SGSN: Identity Request *
+* MS -> SGSN: Identity Response *
+* MS <- SGSN: Attach Complete 5x
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := f_start_handler(refers(f_TC_attach_check_complete_resend), 
testcasename(), g_gb[0], 36, 60.0);
+   vc_conn.done;
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1571,6 +1607,7 @@
execute( TC_attach_closed_add_vty(), 10.0 );
execute( TC_attach_check_subscriber_list(), 10.0 );
execute( TC_attach_detach_check_subscriber_list(), 10.0 );
+   execute( TC_attach_check_complete_resend() );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
10.0 );

--
To view, visit https://gerrit.osmocom.org/9585
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bbbda01f3c41a2f8acf13042d6bcc86f18d74ce
Gerrit-Change-Number: 9585
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: f_TC_attach_closed_foreign: fail on recv an Attach Accept

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9584


Change subject: sgsn: f_TC_attach_closed_foreign: fail on recv an Attach Accept
..

sgsn: f_TC_attach_closed_foreign: fail on recv an Attach Accept

The test expect a reject. Recv an attach accept should fail then.

Change-Id: I8a4ae671dabb1d8a2ee7585e624b962a3500
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/9584/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 17abb95..466c3ed 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -706,6 +706,9 @@
[] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_REJECT(?))) {
setverdict(pass);
}
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_ACCEPT(*, *, *))) {
+   setverdict(fail);
+   }
}
 }
 testcase TC_attach_closed() runs on test_CT {

--
To view, visit https://gerrit.osmocom.org/9584
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a4ae671dabb1d8a2ee7585e624b962a3500
Gerrit-Change-Number: 9584
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_detach_check_subscriber_list

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9579


Change subject: sgsn: add TC_attach_detach_check_subscriber_list
..

sgsn: add TC_attach_detach_check_subscriber_list

MS <-> SGSN: Attach
MS ->  SGSN: Detach Req (Power off)
VTY -> SGSN: Check if MS is NOT in subscriber cache

Change-Id: I0956d54760f19ca556fa0d16ea4c5b96ac13f2fa
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 20 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/79/9579/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 9632718..802c3e6 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1248,7 +1248,6 @@
vc_conn.done;
 }

-
 private function f_TC_hlr_location_cancel_request_update(charstring id) runs 
on BSSGP_ConnHdlr {
/* MS: perform regular attach */
f_TC_attach(id);
@@ -1365,7 +1364,26 @@
vc_conn.done;
 }

+private function f_TC_attach_detach_check_subscriber_list(charstring id) runs 
on BSSGP_ConnHdlr {
+   f_TC_attach(id);
+   f_detach_mo(c_GMM_DTT_MO_GPRS, true, true);
+}

+testcase TC_attach_detach_check_subscriber_list() runs on test_CT {
+   /* MS <-> SGSN: Attach
+* MS ->  SGSN: Detach Req (Power off)
+* VTY -> SGSN: Check if MS is NOT in subscriber cache
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   var integer id := 33;
+   var charstring imsi := hex2str(f_gen_imsi(id));
+
+   f_init();
+   vc_conn := 
f_start_handler(refers(f_TC_attach_detach_check_subscriber_list), 
testcasename(), g_gb[0], id);
+   vc_conn.done;
+
+   f_vty_transceive_not_match(SGSNVTY, "show subscriber cache", pattern "* 
IMSI: {imsi}*");
+}

 /* Attempt an attach, but loose the Identification Request (IMEI) */
 private function f_TC_attach_no_imei_response(charstring id) runs on 
BSSGP_ConnHdlr {
@@ -1473,6 +1491,7 @@
execute( TC_attach_closed() );
execute( TC_attach_no_imei_response() );
execute( TC_attach_no_imsi_response() );
+   execute( TC_attach_detach_check_subscriber_list(), 10.0 );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
10.0 );

--
To view, visit https://gerrit.osmocom.org/9579
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0956d54760f19ca556fa0d16ea4c5b96ac13f2fa
Gerrit-Change-Number: 9579
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_closed_add_vty

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9583


Change subject: sgsn: add TC_attach_closed_add_vty
..

sgsn: add TC_attach_closed_add_vty

Check acl policy closed.

VTY-> SGSN: policy close
MS -> SGSN: Attach Request
MS <- SGSN: Identity Request IMSI
MS -> SGSN: Identity Response IMSI
MS <- SGSN: Attach Reject
VTY-> SGSN: policy imsi-acl add IMSI
MS -> SGSN: Attach Request
MS <- SGSN: Identity Request IMSI
MS -> SGSN: Identity Response IMSI
MS <- SGSN: Identity Request IMEI
MS -> SGSN: Identity Response IMEI
MS <- SGSN: Attach Accept

Change-Id: I1832c339a9d54c0038433ad44e292031a8905e20
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 55 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/83/9583/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 4b6fc4c..17abb95 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1496,6 +1496,60 @@
f_sgsn_vty_destroy_subscriber_imsi(SGSNVTY, imsi);
 }

+private function f_TC_attach_closed_imsi_added(charstring id) runs on 
BSSGP_ConnHdlr {
+   var RoutingAreaIdentificationV old_ra := f_random_RAI();
+   var BssgpDecoded bd;
+
+   /* unregister the old IMSI */
+   f_bssgp_client_unregister(g_pars.imsi);
+   /* Simulate a foreign IMSI */
+   g_pars.imsi := '001010123456789'H;
+   f_bssgp_client_register(g_pars.imsi, g_pars.tlli, g_pars.bssgp_cell_id);
+
+   /* there is no auth */
+   g_pars.net.expect_auth := false;
+
+   BSSGP.send(ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, 
omit));
+   f_gmm_auth();
+   alt {
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_REJECT(?))) {
+   setverdict(fail, "Received unexpected GMM Attach 
REJECT");
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_ACCEPT(*, *, *))) -> 
value bd {
+   
f_process_attach_accept(bd.l3_mt.msgs.gprs_mm.attachAccept);
+   BSSGP.send(ts_GMM_ATTACH_COMPL);
+   setverdict(pass);
+   }
+   }
+}
+testcase TC_attach_closed_add_vty() runs on test_CT {
+   /* VTY-> SGSN: policy close
+* MS -> SGSN: Attach Request
+* MS <- SGSN: Identity Request IMSI
+* MS -> SGSN: Identity Response IMSI
+* MS <- SGSN: Attach Reject
+* VTY-> SGSN: policy imsi-acl add IMSI
+* MS -> SGSN: Attach Request
+* MS <- SGSN: Identity Request IMSI
+* MS -> SGSN: Identity Response IMSI
+* MS <- SGSN: Identity Request IMEI
+* MS -> SGSN: Identity Response IMEI
+* MS <- SGSN: Attach Accept
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   f_vty_config(SGSNVTY, "sgsn", "auth-policy closed");
+   f_vty_config(SGSNVTY, "sgsn", "imsi-acl del 001010123456789");
+   /* test with foreign IMSI: Must Reject */
+   vc_conn := f_start_handler(refers(f_TC_attach_closed_foreign), 
testcasename(), g_gb[0], 9);
+   vc_conn.done;
+   f_vty_config(SGSNVTY, "sgsn", "imsi-acl add 001010123456789");
+   /* test with same IMSI: Must Accept */
+   vc_conn := f_start_handler(refers(f_TC_attach_closed_imsi_added), 
testcasename(), g_gb[0], 10);
+   vc_conn.done;
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1511,6 +1565,7 @@
execute( TC_attach_closed() );
execute( TC_attach_no_imei_response() );
execute( TC_attach_no_imsi_response() );
+   execute( TC_attach_closed_add_vty(), 10.0 );
execute( TC_attach_check_subscriber_list(), 10.0 );
execute( TC_attach_detach_check_subscriber_list(), 10.0 );
execute( TC_hlr_location_cancel_request_update(), 10.0 );

--
To view, visit https://gerrit.osmocom.org/9583
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1832c339a9d54c0038433ad44e292031a8905e20
Gerrit-Change-Number: 9583
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_check_subscriber_list

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9581


Change subject: sgsn: add TC_attach_check_subscriber_list
..

sgsn: add TC_attach_check_subscriber_list

MS <-> SGSN: Attach
VTY -> SGSN: Check if MS is in subscriber cache

Change-Id: If19073ef4a5b1e2219bd5184ae30d55ffb71844a
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 22 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/81/9581/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index f812fbe..4b6fc4c 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1475,6 +1475,27 @@
vc_conn.done;
 }

+private function f_sgsn_vty_destroy_subscriber_imsi(TELNETasp_PT pt, 
charstring imsi) {
+   f_vty_transceive(pt, "update-subscriber imsi " & imsi & " destroy");
+}
+
+testcase TC_attach_check_subscriber_list() runs on test_CT {
+   /* MS <-> SGSN: Attach
+* VTY -> SGSN: Check if MS is in subscriber cache
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   var integer id := 34;
+   var charstring imsi := hex2str(f_gen_imsi(id));
+
+   f_init();
+   f_sleep(1.0);
+   vc_conn := f_start_handler(refers(f_TC_attach), testcasename(), 
g_gb[0], id);
+   vc_conn.done;
+
+   f_vty_transceive_match(SGSNVTY, "show subscriber cache", pattern "* 
IMSI: {imsi}*");
+   f_sgsn_vty_destroy_subscriber_imsi(SGSNVTY, imsi);
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1490,6 +1511,7 @@
execute( TC_attach_closed() );
execute( TC_attach_no_imei_response() );
execute( TC_attach_no_imsi_response() );
+   execute( TC_attach_check_subscriber_list(), 10.0 );
execute( TC_attach_detach_check_subscriber_list(), 10.0 );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );

--
To view, visit https://gerrit.osmocom.org/9581
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If19073ef4a5b1e2219bd5184ae30d55ffb71844a
Gerrit-Change-Number: 9581
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()

[lynxis lazus]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9558

to look at the new patch set (#2).

Change subject: Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()
..

Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()

fails when vty response match template.

Change-Id: I489d2a47cd4690dcfc3f1042c332014593d082a2
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/9558/2
--
To view, visit https://gerrit.osmocom.org/9558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I489d2a47cd4690dcfc3f1042c332014593d082a2
Gerrit-Change-Number: 9558
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: *.default: change logging filemask from ERROR | WARNING to += PARALLE...

[lynxis lazus]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9556

to look at the new patch set (#2).

Change subject: *.default: change logging filemask from ERROR | WARNING to += 
PARALLEL | VERDICTOP
..

*.default: change logging filemask from ERROR | WARNING to += PARALLEL | 
VERDICTOP

PARALLEL | VERDICTOP will log when the port is dying or when other
components will change to fail. This helped to find a timeout in the
SGSN tests where a function call message timed out.

Change-Id: I770ac964dc37e2752e7d35e493f707b091c739b0
---
M bsc/BSC_Tests.default
M bts/BTS_Tests.default
M msc/MSC_Tests.default
M sgsn/SGSN_Tests.default
M sip/SIP_Tests.default
5 files changed, 23 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/56/9556/2
--
To view, visit https://gerrit.osmocom.org/9556
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I770ac964dc37e2752e7d35e493f707b091c739b0
Gerrit-Change-Number: 9556
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_no_imei_response

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9577


Change subject: sgsn: add TC_attach_no_imei_response
..

sgsn: add TC_attach_no_imei_response

Ignores Identity Request IMEI.

MS -> SGSN: Attach Request IMSI
MS <- SGSN: Identity Request IMSI (optional)
MS -> SGSN: Identity Response IMSI (optional)
MS <- SGSN: Identity Request IMEI
MS -x SGSN: no response
MS <- SGSN: re-send: Identity Request IMEI 4x
MS <- SGSN: Attach Reject

Change-Id: Ie50c75e62e31e01c5b17969fb067664e44fd68a5
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 45 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/77/9577/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 46b7b74..c1d4cdf 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1367,6 +1367,50 @@



+/* Attempt an attach, but loose the Identification Request (IMEI) */
+private function f_TC_attach_no_imei_response(charstring id) runs on 
BSSGP_ConnHdlr {
+   var integer count_req := 0;
+   var MobileL3_CommonIE_Types.MobileIdentityLV mi;
+
+   BSSGP.send(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, 
false, omit, omit));
+
+   alt {
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_REJECT(?))) {
+   /* break */
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ID_REQ('001'B))) {
+   mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
+   BSSGP.send(ts_GMM_ID_RESP(mi));
+   repeat;
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ID_REQ('010'B))) {
+   /* ignore ID REQ IMEI */
+   count_req := count_req + 1;
+   repeat;
+   }
+   }
+   if (count_req != 5) {
+   setverdict(fail, "Did not received GMM ID Request Type IMEI 5 
times!");
+   }
+   setverdict(pass);
+}
+
+testcase TC_attach_no_imei_response() runs on test_CT {
+   /* MS -> SGSN: Attach Request IMSI
+* MS <- SGSN: Identity Request IMSI (optional)
+* MS -> SGSN: Identity Response IMSI (optional)
+* MS <- SGSN: Identity Request IMEI
+* MS -x SGSN: no response
+* MS <- SGSN: re-send: Identity Request IMEI 4x
+* MS <- SGSN: Attach Reject
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := f_start_handler(refers(f_TC_attach_no_imei_response), 
testcasename(), g_gb[0], 32, 60.0);
+   vc_conn.done;
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1380,6 +1424,7 @@
execute( TC_attach_combined() );
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
+   execute( TC_attach_no_imei_response() );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
10.0 );

--
To view, visit https://gerrit.osmocom.org/9577
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie50c75e62e31e01c5b17969fb067664e44fd68a5
Gerrit-Change-Number: 9577
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: add TC_attach_no_imsi_response

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9578


Change subject: sgsn: add TC_attach_no_imsi_response
..

sgsn: add TC_attach_no_imsi_response

Ignores Identity Request IMSI.

MS -> SGSN: Attach Request TMSI (unknown)
MS <- SGSN: Identity Request IMEI (optional)
MS -> SGSN: Identity Response IMEI (optional)
MS <- SGSN: Identity Request IMSI
MS -x SGSN: no response
MS <- SGSN: re-send: Identity Request IMSI 4x
MS <- SGSN: Attach Reject

Change-Id: I4f41d59cfe6b0168b5e0874082fd700b56a7f0da
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 48 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/78/9578/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index c1d4cdf..9632718 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1411,6 +1411,53 @@
vc_conn.done;
 }

+/* Attempt an attach, but loose the Identification Request (IMSI) */
+private function f_TC_attach_no_imsi_response(charstring id) runs on 
BSSGP_ConnHdlr {
+   var integer count_req := 0;
+   var MobileL3_CommonIE_Types.MobileIdentityLV mi;
+
+   /* set p_tmsi to use it in Attach Req via f_mi_get_lv() */
+   g_pars.p_tmsi := 'c035'O;
+
+   BSSGP.send(ts_GMM_ATTACH_REQ(f_mi_get_lv(), f_random_RAI(), true, 
false, omit, omit));
+
+   alt {
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ATTACH_REJECT(?))) {
+   /* break */
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ID_REQ('001'B))) {
+   /* ignore ID REQ IMSI */
+   count_req := count_req + 1;
+   repeat;
+   }
+   [] BSSGP.receive(tr_BD_L3_MT(tr_GMM_ID_REQ('010'B))) {
+   mi := valueof(ts_MI_IMEI_LV(g_pars.imei));
+   BSSGP.send(ts_GMM_ID_RESP(mi));
+   repeat;
+   }
+   }
+   if (count_req != 5) {
+   setverdict(fail, "Did not received GMM ID Request Type IMSI 5 
times!");
+   }
+   setverdict(pass);
+}
+
+testcase TC_attach_no_imsi_response() runs on test_CT {
+   /* MS -> SGSN: Attach Request TMSI (unknown)
+* MS <- SGSN: Identity Request IMEI (optional)
+* MS -> SGSN: Identity Response IMEI (optional)
+* MS <- SGSN: Identity Request IMSI
+* MS -x SGSN: no response
+* MS <- SGSN: re-send: Identity Request IMSI 4x
+* MS <- SGSN: Attach Reject
+*/
+   var BSSGP_ConnHdlr vc_conn;
+   f_init();
+   f_sleep(1.0);
+   vc_conn := f_start_handler(refers(f_TC_attach_no_imsi_response), 
testcasename(), g_gb[0], 35, 60.0);
+   vc_conn.done;
+}
+
 control {
execute( TC_attach() );
execute( TC_attach_mnc3() );
@@ -1425,6 +1472,7 @@
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
execute( TC_attach_no_imei_response() );
+   execute( TC_attach_no_imsi_response() );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );
execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
10.0 );

--
To view, visit https://gerrit.osmocom.org/9578
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f41d59cfe6b0168b5e0874082fd700b56a7f0da
Gerrit-Change-Number: 9578
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short

[lynxis lazus]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9560

to look at the new patch set (#2).

Change subject: sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short
..

sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short

These tests failed on jenkins.

Change-Id: I56a62e70763b7c331fc528cd7e4064a5ec9f2a04
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/60/9560/2
--
To view, visit https://gerrit.osmocom.org/9560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I56a62e70763b7c331fc528cd7e4064a5ec9f2a04
Gerrit-Change-Number: 9560
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder

Change in libosmo-sccp[master]: make it possible to pass parameters to m3ua_example

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/9576


Change subject: make it possible to pass parameters to m3ua_example
..

make it possible to pass parameters to m3ua_example

There are plans to use the m3ua_example tool as an SCCP peer
for a TTCN3 test suite. Make it possible to pass paramters to
this tool so the user can override hard-coded default values
of IP addresses, ports, and point codes.

Change-Id: I52243ae926c76020de41c8dfc7263517c7263d7e
---
M examples/m3ua_example.c
1 file changed, 131 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/76/9576/1

diff --git a/examples/m3ua_example.c b/examples/m3ua_example.c
index a9f455c..2a99450 100644
--- a/examples/m3ua_example.c
+++ b/examples/m3ua_example.c
@@ -4,6 +4,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -23,15 +24,17 @@

 static struct osmo_sccp_instance *g_sccp;

-static struct osmo_sccp_instance *sua_server_helper(void)
+static struct osmo_sccp_instance *sua_server_helper(int local_port, const char 
*local_address, int local_pc,
+   int remote_port, const char 
*remote_address, int remote_pc)
 {
struct osmo_sccp_instance *sccp;

-   sccp = osmo_sccp_simple_server(NULL, 1, OSMO_SS7_ASP_PROT_M3UA,
-   -1, "127.0.0.2");
+   sccp = osmo_sccp_simple_server(NULL, local_pc, OSMO_SS7_ASP_PROT_M3UA, 
local_port, local_address);
+   if (sccp == NULL)
+   return NULL;

-   osmo_sccp_simple_server_add_clnt(sccp, OSMO_SS7_ASP_PROT_M3UA,
-   "23", 23, -1, 0, NULL);
+   osmo_sccp_simple_server_add_clnt(sccp, OSMO_SS7_ASP_PROT_M3UA, 
"client", remote_pc, local_port,
+remote_port, remote_address);

return sccp;
 }
@@ -79,10 +82,118 @@
.version = 0,
 };

+#define DEFAULT_LOCAL_PC   -1
+#define DEFAULT_LOCAL_ADDRESS  "127.0.0.2"
+#define DEFAULT_LOCAL_PORT M3UA_PORT
+#define DEFAULT_REMOTE_PC  23
+#define DEFAULT_REMOTE_ADDRESS "127.0.0.1"
+#define DEFAULT_REMOTE_PORTM3UA_PORT
+
+static void usage(void) {
+   fprintf(stderr, "m3ua_example [-c] [-l LOCAL_ADDRESS[:LOCAL_PORT]]\n"
+   " [-r REMOTE_ADDRESS[:REMOTE_PORT]]\n"
+   " [-L LOCAL_POINT_CODE] [-R 
REMOTE_POINT_CODE]\n"
+   "Options:\n"
+   "  -c: Run in client mode (default is server mode)\n"
+   "  -l: local IP address and SCTP port (default is 
%s:%d)\n"
+   "  -r: remote IP address and SCTP port (default is 
%s:%d)\n"
+   "  -L: local point code (default is %d)\n"
+   "  -R: remote point code (default is %d)\n",
+   DEFAULT_LOCAL_ADDRESS, DEFAULT_LOCAL_PORT,
+   DEFAULT_REMOTE_ADDRESS, DEFAULT_REMOTE_PORT,
+   DEFAULT_LOCAL_PC, DEFAULT_REMOTE_PC);
+   exit(1);
+}
+
+static int is_decimal_string(const char *s)
+{
+   const char *p = s;
+
+   if (*p == '\0')
+   return 0;
+
+   while (*p) {
+   if (!isdigit(*p++))
+   return 0;
+   }
+   return 1;
+}
+
+static int parse_address_port(char **address, int *port, const char *arg)
+{
+   char *s, *colon;
+
+   s = strdup(arg);
+   OSMO_ASSERT(s);
+
+   colon = strrchr(s, ':');
+   if (colon) {
+   char *portstr = colon + 1;
+   *colon = '\0';
+   if (*portstr == '\0') {
+   fprintf(stderr, "missing port number after : in 
'%s'\n", arg);
+   free(s);
+   return 1;
+   }
+   if (!is_decimal_string(portstr)) {
+   fprintf(stderr, "invalid port number: '%s'\n", portstr);
+   free(s);
+   return 1;
+   }
+   *port = atoi(portstr);
+   }
+
+   *address = s;
+   return 0;
+}
+
 int main(int argc, char **argv)
 {
-   bool client;
-   int rc;
+   bool client = false;
+   int rc, ch;
+   char *local_address = DEFAULT_LOCAL_ADDRESS;
+   int local_port = DEFAULT_LOCAL_PORT;
+   int local_pc = DEFAULT_LOCAL_PC;
+   char *remote_address = DEFAULT_REMOTE_ADDRESS;
+   int remote_port = DEFAULT_LOCAL_PORT;
+   int remote_pc = DEFAULT_REMOTE_PC;
+
+   while ((ch = getopt(argc, argv, "cl:r:p:L:R:")) != -1) {
+   switch (ch) {
+   case 'c':
+   client = true;
+   break;
+   case 'l':
+   if (parse_address_port(_address, _port, 
optarg))
+   exit(1);
+   

Change in osmo-ci[master]: ansible: Add various additional packages to osmocom-workstation

[Harald Welte]

Harald Welte has uploaded a new patch set (#3). ( 
https://gerrit.osmocom.org/9574 )

Change subject: ansible: Add various additional packages to osmocom-workstation
..

ansible: Add various additional packages to osmocom-workstation

Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
---
M ansible/roles/osmocom-workstation/tasks/main.yml
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/9574/3
--
To view, visit https://gerrit.osmocom.org/9574
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
Gerrit-Change-Number: 9574
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 

Change in osmo-ci[master]: ansible: Add various additional packages to osmocom-workstation

[Harald Welte]

Harald Welte has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/9574 )

Change subject: ansible: Add various additional packages to osmocom-workstation
..

ansible: Add various additional packages to osmocom-workstation

Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
---
M ansible/roles/osmocom-workstation/tasks/main.yml
1 file changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/9574/2
--
To view, visit https://gerrit.osmocom.org/9574
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
Gerrit-Change-Number: 9574
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 

Change in pysim[master]: __init__: also fetch response bytes for USIMs automatically

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9575


Change subject: __init__: also fetch response bytes for USIMs automatically
..

__init__: also fetch response bytes for USIMs automatically

The method send_apdu() first transmits the APDU in the cards direction.
The card may indicate that there is a response available by responding
with SW1=9F, where SW2 is the number of bytes. send_apdu() will then
craft a get-response APDU to pickup the response bytes. This mechanism
works fine for SIM, but USIM uses SW1=61 to indicate the availability
of a response, so lets also sense on SW1=61 to support USIMs as well.

- Also check on SW1=61 to see if a response is available

Change-Id: Ied7fb78873a7c4109de471c7a5e9c3701ba0c7d5
Related: OS#4245
---
M pySim/transport/__init__.py
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/9575/1

diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py
index dd04bba..158b906 100644
--- a/pySim/transport/__init__.py
+++ b/pySim/transport/__init__.py
@@ -67,7 +67,13 @@
"""
data, sw = self.send_apdu_raw(pdu)

-   if (sw is not None) and (sw[0:2] == '9f'):
+   # When whe have sent the first APDU, the SW may indicate that 
there are response bytes
+   # available. There are two SWs commonly used for this 9fxx 
(sim) and 61xx (usim), where
+   # xx is the number of response bytes available.
+   # See also:
+   # SW1=9F: 3GPP TS 51.011 9.4.1, Responses to commands which are 
correctly executed
+   # SW1=61: ISO/IEC 7816-4, Table 5 — General meaning of the 
interindustry values of SW1-SW2
+   if (sw is not None) and ((sw[0:2] == '9f') or (sw[0:2] == 
'61')):
pdu_gr = pdu[0:2] + 'c0' + sw[2:4]
data, sw = self.send_apdu_raw(pdu_gr)


--
To view, visit https://gerrit.osmocom.org/9575
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied7fb78873a7c4109de471c7a5e9c3701ba0c7d5
Gerrit-Change-Number: 9575
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-ci[master]: osmocom-workstatin: change default user to osmocom

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9573


Change subject: osmocom-workstatin: change default user to osmocom
..

osmocom-workstatin: change default user to osmocom

Change-Id: I35da5f2276730c7f81d5a1c2e6878ea3e23bca3b
---
M ansible/roles/osmocom-workstation/defaults/main.yml
M ansible/setup-desktop.yml
2 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/9573/1

diff --git a/ansible/roles/osmocom-workstation/defaults/main.yml 
b/ansible/roles/osmocom-workstation/defaults/main.yml
index 4a2b6d7..bb3d292 100644
--- a/ansible/roles/osmocom-workstation/defaults/main.yml
+++ b/ansible/roles/osmocom-workstation/defaults/main.yml
@@ -1,4 +1,4 @@
 ---

-osmocom_user: laforge
+osmocom_user: osmocom
 git_destination: "/home/{{ osmocom_user}}/projects/git"
diff --git a/ansible/setup-desktop.yml b/ansible/setup-desktop.yml
index 303a610..507a8f2 100644
--- a/ansible/setup-desktop.yml
+++ b/ansible/setup-desktop.yml
@@ -19,4 +19,3 @@
 - jenkins-slave

 - name: osmocom-workstation
-  osmocom_user: laforge

--
To view, visit https://gerrit.osmocom.org/9573
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35da5f2276730c7f81d5a1c2e6878ea3e23bca3b
Gerrit-Change-Number: 9573
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-ci[master]: ansible: Add various additional packages to osmocom-workstation

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9574


Change subject: ansible: Add various additional packages to osmocom-workstation
..

ansible: Add various additional packages to osmocom-workstation

Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
---
M ansible/roles/osmocom-workstation/tasks/main.yml
1 file changed, 15 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/9574/1

diff --git a/ansible/roles/osmocom-workstation/tasks/main.yml 
b/ansible/roles/osmocom-workstation/tasks/main.yml
index 966d861..8c7a79c 100644
--- a/ansible/roles/osmocom-workstation/tasks/main.yml
+++ b/ansible/roles/osmocom-workstation/tasks/main.yml
@@ -30,4 +30,18 @@
 - gnupg
 - openssh-client
 - openssh-server
-
+- console-common
+- console-data
+- meld
+- emacs
+- gitk
+- okular
+- libreoffice-calc
+- libreoffice-draw
+- libreoffice-impress
+- libreoffice-writer
+- gnumeric
+- openvpn
+- fvwm
+- network-manager
+- modemmanager

--
To view, visit https://gerrit.osmocom.org/9574
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d22cd6e4d3a3c8c685362bb62cd2a6ef467c461
Gerrit-Change-Number: 9574
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmocom-bb[master]: osmocon: Call osmo_init_ignore_signals at startup

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9562 )

Change subject: osmocon: Call osmo_init_ignore_signals at startup
..


Patch Set 1: Code-Review+1

Ok, thanks for clarification :)


--
To view, visit https://gerrit.osmocom.org/9562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id664ca0fadd3a8b3cf4b78bb868b3d78d2354544
Gerrit-Change-Number: 9562
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:34:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_04_08.c: expose gsm48_tx_simple()

[Vadim Yanitskiy]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9553

to look at the new patch set (#2).

Change subject: libmsc/gsm_04_08.c: expose gsm48_tx_simple()
..

libmsc/gsm_04_08.c: expose gsm48_tx_simple()

This function could be also used by other parts of code, e.g.
by gsm_04_11.c or by gsm_09_11.c, during initialization of
a new transaction. No need to hide it.

Change-Id: I9a9d17fca4901163dae10d76455aa4cf54497156
---
M include/osmocom/msc/gsm_04_08.h
M src/libmsc/gsm_04_08.c
2 files changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/9553/2
--
To view, visit https://gerrit.osmocom.org/9553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a9d17fca4901163dae10d76455aa4cf54497156
Gerrit-Change-Number: 9553
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 

Change in osmo-msc[master]: libmsc/gsm_04_80.c: make the API abstract from ss_request struct

[Vadim Yanitskiy]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9555

to look at the new patch set (#2).

Change subject: libmsc/gsm_04_80.c: make the API abstract from ss_request struct
..

libmsc/gsm_04_80.c: make the API abstract from ss_request struct

There is no need to pass a pointer to a ss_request struct when
calling the gsm0480_send_ussd_* functions, because they only
use both transaction ID and InvokeID from there, which may
be passed directly.

This change allows one to use this API without parsing the
whole GSM 04.80 message, or when parsing is failed. Moreover,
if InvokeID is not available, one can pass any incorrect,
(e.g. negative) value, so the universal NULL tag will be used.
Finally, setting a TI flag is also up to the caller.

Change-Id: I13d5abbfdcf8238ebaf0566c420f09cd9255b648
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
M src/libmsc/gsm_09_11.c
3 files changed, 77 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/55/9555/2
--
To view, visit https://gerrit.osmocom.org/9555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I13d5abbfdcf8238ebaf0566c420f09cd9255b648
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-trx[master]: examples: Set rt-prio 18 and print file basename

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9572


Change subject: examples: Set rt-prio 18 and print file basename
..

examples: Set rt-prio 18 and print file basename

Change-Id: I16fbdd46f2d9b6f3e79a4bb357f6a7fbed14244a
---
M doc/examples/osmo-trx-limesdr.cfg
M doc/examples/osmo-trx-umtrx.cfg
M doc/examples/osmo-trx-usrp_b200.cfg
3 files changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/72/9572/1

diff --git a/doc/examples/osmo-trx-limesdr.cfg 
b/doc/examples/osmo-trx-limesdr.cfg
index c7e6b23..7f622b0 100644
--- a/doc/examples/osmo-trx-limesdr.cfg
+++ b/doc/examples/osmo-trx-limesdr.cfg
@@ -3,6 +3,7 @@
   logging color 1
   logging print category 1
   logging timestamp 1
+  logging print file basename
   logging level all info
 !
 line vty
@@ -15,6 +16,7 @@
  egprs disable
  tx-sps 4
  rx-sps 4
+ rt-prio 18
  chan 0
   tx-path BAND1
   rx-path LNAW
diff --git a/doc/examples/osmo-trx-umtrx.cfg b/doc/examples/osmo-trx-umtrx.cfg
index b7a73b0..9c80933 100644
--- a/doc/examples/osmo-trx-umtrx.cfg
+++ b/doc/examples/osmo-trx-umtrx.cfg
@@ -3,6 +3,7 @@
   logging color 1
   logging print category 1
   logging timestamp 1
+  logging print file basename
   logging level all info
 !
 line vty
diff --git a/doc/examples/osmo-trx-usrp_b200.cfg 
b/doc/examples/osmo-trx-usrp_b200.cfg
index 1d6656e..53fa24e 100644
--- a/doc/examples/osmo-trx-usrp_b200.cfg
+++ b/doc/examples/osmo-trx-usrp_b200.cfg
@@ -3,6 +3,7 @@
   logging color 1
   logging print category 1
   logging timestamp 1
+  logging print file basename
   logging level all info
 !
 line vty
@@ -16,5 +17,6 @@
  tx-sps 4
  rx-sps 4
  clock-ref external
+ rt-prio 18
  chan 0


--
To view, visit https://gerrit.osmocom.org/9572
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16fbdd46f2d9b6f3e79a4bb357f6a7fbed14244a
Gerrit-Change-Number: 9572
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-ci[master]: anisble: gsm-tester: uhubctl: add "-n 1d50:4002"

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9493 )

Change subject: anisble: gsm-tester: uhubctl: add "-n 1d50:4002"
..

anisble: gsm-tester: uhubctl: add "-n 1d50:4002"

uhubctl -p 123456 -a 1 is rejecting because uhubctl detects two hubs.
Selecting only one hub.

Fixes the error message:
Error: changing port state for multiple hubs at once is not supported.
Use -l to limit operation to one hub!

Change-Id: I2e3c248e4eaef39f18ff38d1055db6d552fc4d20
---
M ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh 
b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
index 9262f97..626a04e 100755
--- a/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
+++ b/ansible/roles/gsm-tester/templates/quad_modem_power_cycle.sh
@@ -1,9 +1,9 @@
 #!/bin/sh
 set -ex
-uhubctl -p 123456 -a 0
+uhubctl -p 123456 -a 0 -n 1d50:4002
 # give a lot of time to discharge capacitors on the board
 sleep 20
-uhubctl -p 123456 -a 1
+uhubctl -p 123456 -a 1 -n 1d50:4002
 attempts=30
 while [ "x$(uhubctl | grep -e 05c6 -e 1199 -c)" != "x{{ gsm_modems }}" ]; do
attempts=$(($attempts - 1))

--
To view, visit https://gerrit.osmocom.org/9493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e3c248e4eaef39f18ff38d1055db6d552fc4d20
Gerrit-Change-Number: 9493
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ci[master]: ansible: gsm-tester: change production gsm_modems to 3

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9494 )

Change subject: ansible: gsm-tester: change production gsm_modems to 3
..

ansible: gsm-tester: change production gsm_modems to 3

In the production setup, there are only 3 valid modems.
Moving the variable into the host_vars so they can have
different amount of modem between rnd & prod.

Change-Id: Ic51a14a339bb9be50504a27a724f6f428ee7304f
---
M ansible/host_vars/osmo-gsm-tester-prod.yml
M ansible/host_vars/osmo-gsm-tester-rnd.yml
M ansible/setup-gsm-tester.yml
3 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/ansible/host_vars/osmo-gsm-tester-prod.yml 
b/ansible/host_vars/osmo-gsm-tester-prod.yml
index e87d8fb..2f9068e 100644
--- a/ansible/host_vars/osmo-gsm-tester-prod.yml
+++ b/ansible/host_vars/osmo-gsm-tester-prod.yml
@@ -4,3 +4,6 @@
 ip: 10.42.42.53
   - mac: 00:02:95:00:5a:a4
 ip: 10.42.42.54
+
+# how many modems are connected via a quadmodem?
+gsm_modems: 3
diff --git a/ansible/host_vars/osmo-gsm-tester-rnd.yml 
b/ansible/host_vars/osmo-gsm-tester-rnd.yml
index b524752..2e9b0b7 100644
--- a/ansible/host_vars/osmo-gsm-tester-rnd.yml
+++ b/ansible/host_vars/osmo-gsm-tester-rnd.yml
@@ -2,3 +2,6 @@
 udhcpd_static_leases:
   - mac: 00:02:95:00:41:b3
 ip: 10.42.42.53
+
+# how many modems are connected via a quadmodem?
+gsm_modems: 4
diff --git a/ansible/setup-gsm-tester.yml b/ansible/setup-gsm-tester.yml
index 02ebe0f..99cc3e4 100644
--- a/ansible/setup-gsm-tester.yml
+++ b/ansible/setup-gsm-tester.yml
@@ -17,8 +17,6 @@
 - curl
   roles:
 - name: gsm-tester
-  # how many modems are connected via a quadmodem?
-  gsm_modems: 4
   tags:
 - gsm-tester
 

--
To view, visit https://gerrit.osmocom.org/9494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic51a14a339bb9be50504a27a724f6f428ee7304f
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ci[master]: ansible: gsm-tester: change production gsm_modems to 3

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9494 )

Change subject: ansible: gsm-tester: change production gsm_modems to 3
..


Patch Set 3: Verified+1


--
To view, visit https://gerrit.osmocom.org/9494
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic51a14a339bb9be50504a27a724f6f428ee7304f
Gerrit-Change-Number: 9494
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:17:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: osmocon: Call osmo_init_ignore_signals at startup

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9562 )

Change subject: osmocon: Call osmo_init_ignore_signals at startup
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9562/1/src/host/osmocon/osmocon.c
File src/host/osmocon/osmocon.c:

https://gerrit.osmocom.org/#/c/9562/1/src/host/osmocon/osmocon.c@1427
PS1, Line 1427: osmo_init_ignore_signals();
> Wouldn't this also ignore SIGINT? […]
osmo_init_ignore_signals doesn't ignore SIGINT:

>/*! Ignore \ref SIGPIPE, \ref SIGALRM, \ref SIGHUP and \ref >SIGIO */
>void osmo_init_ignore_signals(void)
>{
>   /* Signals that by default would terminate */
>#ifdef SIGPIPE
>   signal(SIGPIPE, SIG_IGN);
>#endif
>   signal(SIGALRM, SIG_IGN);
>#ifdef SIGHUP
>   signal(SIGHUP, _hdlr);
>#endif
>#ifdef SIGIO
>   signal(SIGIO, SIG_IGN);
>#endif
>}



--
To view, visit https://gerrit.osmocom.org/9562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id664ca0fadd3a8b3cf4b78bb868b3d78d2354544
Gerrit-Change-Number: 9562
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:16:48 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: anisble: gsm-tester: uhubctl: add "-n 1d50:4002"

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9493 )

Change subject: anisble: gsm-tester: uhubctl: add "-n 1d50:4002"
..


Patch Set 2: Verified+1


--
To view, visit https://gerrit.osmocom.org/9493
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e3c248e4eaef39f18ff38d1055db6d552fc4d20
Gerrit-Change-Number: 9493
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:17:04 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: fix deprecation of filter "| changed"

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9498 )

Change subject: ansible: fix deprecation of filter "| changed"
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/9498
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf11d54d60b78733ed212f04940cee15b3a55400
Gerrit-Change-Number: 9498
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:16:03 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: fix deprecation of "include:"

[lynxis lazus]

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/9499 )

Change subject: ansible: fix deprecation of "include:"
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/9499
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e1bb11e9392f7da9ed554c37f9625daa0950308
Gerrit-Change-Number: 9499
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:16:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ci[master]: ansible: fix deprecation of "include:"

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9499 )

Change subject: ansible: fix deprecation of "include:"
..

ansible: fix deprecation of "include:"

"include:" has been deprecated in favour of "include_tasks:".

Change-Id: I6e1bb11e9392f7da9ed554c37f9625daa0950308
---
M ansible/roles/osmocom-jenkins-slave/tasks/main.yml
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml 
b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
index 215c988..f76489c 100644
--- a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
+++ b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml
@@ -1,7 +1,7 @@
 ---

 - name: install jenkins packages
-  include: debian.yml
+  include_tasks: debian.yml
   when: ansible_distribution == 'Debian'

 - name: install build utilities
@@ -100,11 +100,11 @@
 key: "{{ lookup('file', 'jenkins.osmocom.org.pub') }}"

 - name: include generic slave
-  include: generic-slave.yml
+  include_tasks: generic-slave.yml
   when: generic_slave

 - name: install ttcn3 dependencies
-  include: ttcn3-slave.yml
+  include_tasks: ttcn3-slave.yml
   when: ttcn3_slave and ansible_distribution == 'Debian' and 
ansible_distribution_release == 'stretch'

 - name: copy .gitconfig

--
To view, visit https://gerrit.osmocom.org/9499
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e1bb11e9392f7da9ed554c37f9625daa0950308
Gerrit-Change-Number: 9499
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in osmo-ci[master]: ansible: fix deprecation of filter "| changed"

[lynxis lazus]

lynxis lazus has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9498 )

Change subject: ansible: fix deprecation of filter "| changed"
..

ansible: fix deprecation of filter "| changed"

"| changed" filter will be removed in ansible 2.9

Change-Id: Idf11d54d60b78733ed212f04940cee15b3a55400
---
M ansible/roles/gsm-tester-bts/tasks/main.yml
M ansible/roles/gsm-tester-network/tasks/main.yml
M ansible/roles/udhcpd/tasks/main.yml
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  lynxis lazus: Verified



diff --git a/ansible/roles/gsm-tester-bts/tasks/main.yml 
b/ansible/roles/gsm-tester-bts/tasks/main.yml
index fa4bccd..e979605 100644
--- a/ansible/roles/gsm-tester-bts/tasks/main.yml
+++ b/ansible/roles/gsm-tester-bts/tasks/main.yml
@@ -27,7 +27,7 @@
   command: uhd_images_downloader
   args:
 creates: /usr/share/uhd/images
-  when: uhd_installed | changed
+  when: uhd_installed is changed

 - name: usrp allow jenkins to access
   user:
diff --git a/ansible/roles/gsm-tester-network/tasks/main.yml 
b/ansible/roles/gsm-tester-network/tasks/main.yml
index 0a023a7..210bf1e 100644
--- a/ansible/roles/gsm-tester-network/tasks/main.yml
+++ b/ansible/roles/gsm-tester-network/tasks/main.yml
@@ -8,4 +8,4 @@

 - name: start all network interface
   command: ifup -a
-  when: gsm_tester_network_interface | changed
+  when: gsm_tester_network_interface is changed
diff --git a/ansible/roles/udhcpd/tasks/main.yml 
b/ansible/roles/udhcpd/tasks/main.yml
index e444684..e1e7b36 100644
--- a/ansible/roles/udhcpd/tasks/main.yml
+++ b/ansible/roles/udhcpd/tasks/main.yml
@@ -22,7 +22,7 @@
 - name: systemctl daemon-reload
   systemd:
 daemon_reload: yes
-  when: udhcpdservice | changed
+  when: udhcpdservice is changed

 - name: ensure the systemd service is installed
   systemd:

--
To view, visit https://gerrit.osmocom.org/9498
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf11d54d60b78733ed212f04940cee15b3a55400
Gerrit-Change-Number: 9498
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Reviewer: lynxis lazus 

Change in pysim[master]: __init__: allow wildcards in expected SW for send_apdu_checksw()

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9571


Change subject: __init__: allow wildcards in expected SW for send_apdu_checksw()
..

__init__: allow wildcards in expected SW for send_apdu_checksw()

The method send_apdu_checksw() is used to check the SW of the final
response against some pre defined value. However, in many cases the
last two digits of the SW are used to return varying information
(e.g. length information or a more specific status info). To cover
those cases it would be helfpul to define status words that contain
wildcards (e.g. 61**) in order to be able to accept all SWs from
6100 to 61ff.

- When the user supplies an expected SW with wildcards, mask out
  those digits in the response before comparing

Change-Id: I5bfc0522b4228b5d9b3415f6e708abcf0da0a7b7
---
M pySim/transport/__init__.py
1 file changed, 13 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/71/9571/1

diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py
index dd04bba..f285c28 100644
--- a/pySim/transport/__init__.py
+++ b/pySim/transport/__init__.py
@@ -77,12 +77,23 @@
"""send_apdu_checksw(pdu,sw): Sends an APDU and check returned 
SW

   pdu: string of hexadecimal characters (ex. 
"A0A4023F00")
-  sw : string of 4 hexadecimal characters (ex. "9000")
+  sw : string of 4 hexadecimal characters (ex. "9000"). The
+   user may mask out certain digits using a '*' to add 
some
+   ambiguity if needed.
   return : tuple(data, sw), where
data : string (in hex) of returned data (ex. 
"074F4E")
sw   : string (in hex) of status word (ex. "9000")
"""
rv = self.send_apdu(pdu)
-   if sw.lower() != rv[1]:
+
+# Create a masked version of the returned status word
+   sw_masked = ""
+   for i in range(0, 4):
+   if sw.lower()[i] == '*':
+   sw_masked = sw_masked + '*'
+   else:
+   sw_masked = sw_masked + rv[1][i].lower()
+
+   if sw.lower() != sw_masked:
raise RuntimeError("SW match failed ! Expected %s and 
got %s." % (sw.lower(), rv[1]))
return rv

--
To view, visit https://gerrit.osmocom.org/9571
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bfc0522b4228b5d9b3415f6e708abcf0da0a7b7
Gerrit-Change-Number: 9571
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmocom-bb[master]: osmocon: Call osmo_init_ignore_signals at startup

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9562 )

Change subject: osmocon: Call osmo_init_ignore_signals at startup
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9562/1/src/host/osmocon/osmocon.c
File src/host/osmocon/osmocon.c:

https://gerrit.osmocom.org/#/c/9562/1/src/host/osmocon/osmocon.c@1427
PS1, Line 1427: osmo_init_ignore_signals();
Wouldn't this also ignore SIGINT?
In other words, would Ctrl+C terminate the program as usually?



--
To view, visit https://gerrit.osmocom.org/9562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id664ca0fadd3a8b3cf4b78bb868b3d78d2354544
Gerrit-Change-Number: 9562
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:01:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ci[master]: ansible: Use SDK/toolchain for 2.3.4, not 2.3.2

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9568


Change subject: ansible: Use SDK/toolchain for 2.3.4, not 2.3.2
..

ansible: Use SDK/toolchain for 2.3.4, not 2.3.2

Change-Id: Ia39284acce65c5779b71154662f3f55349a86960
---
M ansible/roles/install-poky-sdk/defaults/main.yml
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/9568/1

diff --git a/ansible/roles/install-poky-sdk/defaults/main.yml 
b/ansible/roles/install-poky-sdk/defaults/main.yml
index 976a03f..9b8eb04 100644
--- a/ansible/roles/install-poky-sdk/defaults/main.yml
+++ b/ansible/roles/install-poky-sdk/defaults/main.yml
@@ -2,6 +2,6 @@
 # OS user
 jenkins_user: jenkins

-poky_installer_file: 
poky-glibc-x86_64-meta-toolchain-osmo-armv5te-toolchain-osmo-2.3.2.sh
-poky_version: 2.3.2
+poky_installer_file: 
poky-glibc-x86_64-meta-toolchain-osmo-armv5te-toolchain-osmo-2.3.4.sh
+poky_version: 2.3.4


--
To view, visit https://gerrit.osmocom.org/9568
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia39284acce65c5779b71154662f3f55349a86960
Gerrit-Change-Number: 9568
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-ci[master]: ansible: osmocom-workstation: Add user to 'docker' group

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9570


Change subject: ansible: osmocom-workstation: Add user to 'docker' group
..

ansible: osmocom-workstation: Add user to 'docker' group

Change-Id: I43169dfb39525ffe16a3ed1cbf5360b47f9f8a00
---
M ansible/roles/osmocom-workstation/tasks/main.yml
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/70/9570/1

diff --git a/ansible/roles/osmocom-workstation/tasks/main.yml 
b/ansible/roles/osmocom-workstation/tasks/main.yml
index 42d213f..966d861 100644
--- a/ansible/roles/osmocom-workstation/tasks/main.yml
+++ b/ansible/roles/osmocom-workstation/tasks/main.yml
@@ -7,6 +7,7 @@
 ssh_key_bits: 4096
 ssh_key_type: rsa
 shell: /usr/bin/zsh
+groups: docker

 - name: include git repos
   include: git-repos.yml

--
To view, visit https://gerrit.osmocom.org/9570
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43169dfb39525ffe16a3ed1cbf5360b47f9f8a00
Gerrit-Change-Number: 9570
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-ci[master]: ansible: osmocom-workstation: clone ttcn-3 deps

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/9569


Change subject: ansible: osmocom-workstation: clone ttcn-3 deps
..

ansible: osmocom-workstation: clone ttcn-3 deps

Change-Id: Ib0169c858c3c0610e49d01f1dafee5c725ddc7df
---
M ansible/roles/osmocom-workstation/tasks/git-repos.yml
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/9569/1

diff --git a/ansible/roles/osmocom-workstation/tasks/git-repos.yml 
b/ansible/roles/osmocom-workstation/tasks/git-repos.yml
index 624162c..79f7f31 100644
--- a/ansible/roles/osmocom-workstation/tasks/git-repos.yml
+++ b/ansible/roles/osmocom-workstation/tasks/git-repos.yml
@@ -98,6 +98,10 @@
  - osmo-tcap-map
  - osmo-tetra

+- name: install TTCN3 dependency git repos
+  command: make deps
+  args:
+ chdir: "{{ git_destination }}/osmo-ttcn3-hacks"

 - name: install sysmocom git repos
   git: repo=git://git.sysmocom.de/{{ item }}.git

--
To view, visit https://gerrit.osmocom.org/9569
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0169c858c3c0610e49d01f1dafee5c725ddc7df
Gerrit-Change-Number: 9569
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-ttcn3-hacks[master]: move M3UA_Emulation dependency repository to commit R.2.A-2-g742cf02

[Stefan Sperling]

Stefan Sperling has uploaded this change for review. ( 
https://gerrit.osmocom.org/9567


Change subject: move M3UA_Emulation dependency repository to commit 
R.2.A-2-g742cf02
..

move M3UA_Emulation dependency repository to commit R.2.A-2-g742cf02

Change-Id: Ifd258da7a0fb53eadb2aa080348a5250c307fe85
---
M deps/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/67/9567/1

diff --git a/deps/Makefile b/deps/Makefile
index cf0bf4d..cb9e359 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -55,7 +55,7 @@
 # In order to keep local changes in the repository of a dependency, set its 
commit to the
 # name of a local branch here (e.g. 'master').
 titan.Libraries.TCCUsefulFunctions_commit= R.30.A
-titan.ProtocolEmulations.M3UA_commit=  R.2.A-1-g53dead2
+titan.ProtocolEmulations.M3UA_commit=  R.2.A-2-g742cf02
 titan.ProtocolEmulations.SCCP_commit=  R.7.A-2-g724c83f
 titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A
 titan.ProtocolModules.BSSGP_v13.0.0_commit=R.2.A

--
To view, visit https://gerrit.osmocom.org/9567
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd258da7a0fb53eadb2aa080348a5250c307fe85
Gerrit-Change-Number: 9567
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling 

Change in osmocom-bb[master]: osmocon: Fix printf format

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9564


Change subject: osmocon: Fix printf format
..

osmocon: Fix printf format

Fixes compilation warning:
osmocon.c:650:21: warning: format ‘%u’ expects argument of type ‘unsigned int’, 
but argument 3 has type ‘long int’ [-Wformat=]
  printf("%u bytes (%u/%u)\n", rc, dnload.write_ptr - dnload.data,
~^ ~~
%lu

Change-Id: I1e9e10e756d8a612425ee71f4ac0139b2293d3bb
---
M src/host/osmocon/osmocon.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/9564/1

diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index be6e244..2e822e8 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -647,7 +647,7 @@

dnload.write_ptr += rc;

-   printf("%u bytes (%u/%u)\n", rc, dnload.write_ptr - dnload.data,
+   printf("%u bytes (%lu/%u)\n", rc, dnload.write_ptr - dnload.data,
dnload.data_len);

return 0;

--
To view, visit https://gerrit.osmocom.org/9564
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e9e10e756d8a612425ee71f4ac0139b2293d3bb
Gerrit-Change-Number: 9564
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: osmocon: Remove unused variables

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9565


Change subject: osmocon: Remove unused variables
..

osmocon: Remove unused variables

Change-Id: If4c6814ada85956975e687eb43dcfd4ad70b8b94
---
M src/host/osmocon/osmocon.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/65/9565/1

diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 2e822e8..0475103 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -210,13 +210,11 @@

 /* Calypso romloader specific */
 static const uint8_t romload_ident_cmd[] = { 0x3c, 0x69 }; /* i */
 static const uint8_t romload_param_ack[] = { 0x3e, 0x70 }; /* >p */
-static const uint8_t romload_param_nack[] ={ 0x3e, 0x50 }; /* >P */
 static const uint8_t romload_block_ack[] = { 0x3e, 0x77 }; /* >w */
 static const uint8_t romload_block_nack[] ={ 0x3e, 0x57 }; /* >W */
 static const uint8_t romload_checksum_ack[] =  { 0x3e, 0x63 }; /* >c */

--
To view, visit https://gerrit.osmocom.org/9565
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4c6814ada85956975e687eb43dcfd4ad70b8b94
Gerrit-Change-Number: 9565
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: osmoload: Remove duplicate const keyword

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9563


Change subject: osmoload: Remove duplicate const keyword
..

osmoload: Remove duplicate const keyword

Fixes compilation warning:
warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
  const uint8_t const *endptr = bufptr + len;
^

Change-Id: Ibafa439c9d7f7aab6d417eca5ff045766ac27b4f
---
M src/host/osmocon/osmoload.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/63/9563/1

diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c
index e83f98a..8ce755d 100644
--- a/src/host/osmocon/osmoload.c
+++ b/src/host/osmocon/osmoload.c
@@ -149,7 +149,7 @@
 static void osmoload_osmo_hexdump(const uint8_t *data, unsigned int len)
 {
const uint8_t *bufptr = data;
-   const uint8_t const *endptr = bufptr + len;
+   const uint8_t *endptr = bufptr + len;
int n, m, i, hexchr;

for (n=0; n < len; n+=32, bufptr += 32) {

--
To view, visit https://gerrit.osmocom.org/9563
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibafa439c9d7f7aab6d417eca5ff045766ac27b4f
Gerrit-Change-Number: 9563
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmocom-bb[master]: osmoload: Remove unused function

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9566


Change subject: osmoload: Remove unused function
..

osmoload: Remove unused function

Change-Id: I8e838cbb5ae7c9a2f4d0e249fc14f7cbcbc2cb07
---
M src/host/osmocon/osmoload.c
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/66/9566/1

diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c
index 8ce755d..f513836 100644
--- a/src/host/osmocon/osmoload.c
+++ b/src/host/osmocon/osmoload.c
@@ -552,12 +552,6 @@
 }

 static void
-loader_start_flash_query(uint8_t command, uint8_t chip, uint32_t address) {
-   loader_send_flash_query(command, chip, address);
-   osmoload.state = STATE_QUERY_PENDING;
-}
-
-static void
 loader_start_memget(uint8_t length, uint32_t address) {
struct msgb *msg = msgb_alloc(MSGB_MAX, "loader");
msgb_put_u8(msg, LOADER_MEM_READ);

--
To view, visit https://gerrit.osmocom.org/9566
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e838cbb5ae7c9a2f4d0e249fc14f7cbcbc2cb07
Gerrit-Change-Number: 9566
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #152

[jenkins]

See 


--
[...truncated 3.67 KB...]

+ ./configure
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking 

Change in osmocom-bb[master]: osmocon: Call osmo_init_ignore_signals at startup

[Pau Espin Pedrol]

Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/9562


Change subject: osmocon: Call osmo_init_ignore_signals at startup
..

osmocon: Call osmo_init_ignore_signals at startup

It disables undesirable signals such as SIGPIPE, which exits the program
if the client connected to osmocon closes the connection and osmocon
writes to the connection fd. After SIGPIPE is disabled, write returns
-EPIPE.

This is required to keep osmocon running for BTS_Tests.ttcn TTCN3 tests.

Change-Id: Id664ca0fadd3a8b3cf4b78bb868b3d78d2354544
---
M src/host/osmocon/osmocon.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/62/9562/1

diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 76f6037..be6e244 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -44,6 +44,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 

@@ -1423,6 +1424,8 @@
dnload.beacon_interval = DEFAULT_BEACON_INTERVAL;
dnload.do_chainload = 0;

+   osmo_init_ignore_signals();
+
while ((opt = getopt(argc, argv, "d:hl:p:m:cs:i:v")) != -1) {
switch (opt) {
case 'p':

--
To view, visit https://gerrit.osmocom.org/9562
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id664ca0fadd3a8b3cf4b78bb868b3d78d2354544
Gerrit-Change-Number: 9562
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 

Change in osmo-msc[master]: Use proper naming for GSM TS 09.11 implementation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9552 )

Change subject: Use proper naming for GSM TS 09.11 implementation
..


Patch Set 1: Code-Review+1

> (1 comment)

sory, I was thinking of libosmocore.  Of course we don't need this inside 
osmo-msc.


--
To view, visit https://gerrit.osmocom.org/9552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1eaceddb58132318e4e941be542da34b8ebefe1
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 12 Jun 2018 12:52:53 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Use proper naming for GSM TS 09.11 implementation

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9552 )

Change subject: Use proper naming for GSM TS 09.11 implementation
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h
File include/osmocom/msc/ussd.h:

https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h@a5
PS1, Line 5:
> what's your plan for backwards compatibility here? I suggest you keep the old 
> symbol, mark it as dep […]
Hmm, do we really need backwards compatibility here?

This header is not being installed to the system include
directory, and AFAIK only used by gsm_04_08.c in a single
place.

This is an internal symbol within the project, so
I don't see any reason to keep the old one. Am I wrong? ;)



--
To view, visit https://gerrit.osmocom.org/9552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1eaceddb58132318e4e941be542da34b8ebefe1
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Tue, 12 Jun 2018 12:17:47 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in pysim[master]: cards: update smsp with fixed record length

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/9561 )

Change subject: cards: update smsp with fixed record length
..


Patch Set 1:

> Uploaded patch set 1.

As far as I can see FairwavesSIM is currently the only card class that calls 
the update_smsp() method. However, I would love to use the method with some 
other card (USIM). Unfortunately this card does not give me any details about 
the record size back. Since the smsp record that is sent to the card is padded 
to a fixed size anyway I think it is ok set the force length too.


--
To view, visit https://gerrit.osmocom.org/9561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea078f8171b6dbe94bd966807802bc30b5824758
Gerrit-Change-Number: 9561
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Alexander Chemeris 
Gerrit-Reviewer: dexter 
Gerrit-Comment-Date: Tue, 12 Jun 2018 12:14:45 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in pysim[master]: cards: update smsp with fixed record length

[dexter]

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9561


Change subject: cards: update smsp with fixed record length
..

cards: update smsp with fixed record length

When updating ths spsp then rpad() is used to pad the supplied smsp
to 48 bytes length. So the length than update_record will dreive is
always the same.

the method update_record() will then do a select_file() and will
use the response to determine the record length from the response.
Then this length is used in the APDU that is sent to the card.

However, the record size is fixed since it is gets padded to a
hardcoded fixed size but not all cards (USIM?) seem to return the
record length with their response so we should set the force_len flag
in order to cover also those cases.

Change-Id: Iea078f8171b6dbe94bd966807802bc30b5824758
Related: SYS#4245
---
M pySim/cards.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/9561/1

diff --git a/pySim/cards.py b/pySim/cards.py
index 0c9c2b8..a3c4d87 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -84,7 +84,7 @@
return sw

def update_smsp(self, smsp):
-   data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 
84))
+   data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 
84), True)
return sw

def read_spn(self):

--
To view, visit https://gerrit.osmocom.org/9561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea078f8171b6dbe94bd966807802bc30b5824758
Gerrit-Change-Number: 9561
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 

Change in osmo-ttcn3-hacks[master]: sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9560


Change subject: sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short
..

sgsn: TC_hlr_location_cancel_*: 5 seconds timeout is to short

Increase the timeout to 10 seconds.
These tests fails on jenkins.

Change-Id: I56a62e70763b7c331fc528cd7e4064a5ec9f2a04
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/60/9560/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index f8ce5e7..4dab9a8 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1381,9 +1381,9 @@
execute( TC_attach_accept_all() );
execute( TC_attach_closed() );
execute( TC_hlr_location_cancel_request_update(), 10.0 );
-   execute( TC_hlr_location_cancel_request_withdraw(), 5.0 );
-   execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
5.0 );
-   execute( TC_hlr_location_cancel_request_unknown_subscriber_update(), 
5.0 );
+   execute( TC_hlr_location_cancel_request_withdraw(), 10.0 );
+   execute( TC_hlr_location_cancel_request_unknown_subscriber_withdraw(), 
10.0 );
+   execute( TC_hlr_location_cancel_request_unknown_subscriber_update(), 
10.0 );
execute( TC_rau_unknown() );
execute( TC_attach_rau() );
execute( TC_detach_unknown_nopoweroff() );

--
To view, visit https://gerrit.osmocom.org/9560
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56a62e70763b7c331fc528cd7e4064a5ec9f2a04
Gerrit-Change-Number: 9560
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: SGSN: fix spaces/tabs in TC_hlr_location_cancel_request_unknown_subsc...

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9559


Change subject: SGSN: fix spaces/tabs in 
TC_hlr_location_cancel_request_unknown_subscriber_{withdraw,update}
..

SGSN: fix spaces/tabs in 
TC_hlr_location_cancel_request_unknown_subscriber_{withdraw,update}

Fixes: 6c47f294954f ("SGSN: add 
TC_hlr_location_cancel_request_unknown_subscriber_{withdraw,update}")
Change-Id: I5074dadf53ec75a9c709b28ff324e23fdcd13bfa
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/59/9559/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index f8ce5e7..04865fd 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -1334,7 +1334,7 @@
 }

 private function 
f_TC_hlr_location_cancel_request_unknown_subscriber_withdraw(charstring id) 
runs on BSSGP_ConnHdlr {
-f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
+   f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
 }

 testcase TC_hlr_location_cancel_request_unknown_subscriber_withdraw() runs on 
test_CT {
@@ -1350,7 +1350,7 @@
 }

 private function 
f_TC_hlr_location_cancel_request_unknown_subscriber_update(charstring id) runs 
on BSSGP_ConnHdlr {
-f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
+   f_hlr_location_cancel_request_unknown_subscriber(id, 
OSMO_GSUP_CANCEL_TYPE_WITHDRAW);
 }

 testcase TC_hlr_location_cancel_request_unknown_subscriber_update() runs on 
test_CT {

--
To view, visit https://gerrit.osmocom.org/9559
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5074dadf53ec75a9c709b28ff324e23fdcd13bfa
Gerrit-Change-Number: 9559
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9558


Change subject: Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()
..

Osmocom_VTY_Functions: introduce f_vty_transceive_not_match()

f_vty_transceive_not_match(TELNETasp_PT pt, charstring cmd, template charstring 
exp_ret)
fails when vty response match template.

Change-Id: I489d2a47cd4690dcfc3f1042c332014593d082a2
---
M library/Osmocom_VTY_Functions.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/58/9558/1

diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index f118865..c7f4441 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -136,5 +136,13 @@
}
 }

+function f_vty_transceive_not_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
+   var charstring ret := f_vty_transceive_ret(pt, cmd);
+   if (match(ret, exp_ret)) {
+   setverdict(fail, "Unexpected matching VTY response: ", ret);
+   self.stop;
+   }
+}
+

 }

--
To view, visit https://gerrit.osmocom.org/9558
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I489d2a47cd4690dcfc3f1042c332014593d082a2
Gerrit-Change-Number: 9558
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this l...

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9557


Change subject: Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to 
this library
..

Osmocom_VTY_Functions: move f_vty_transceive_match from HLR to this library

f_vty_transceive_match will be used by future SGSN tests.

Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
---
M hlr/HLR_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
2 files changed, 8 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/57/9557/1

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index 90a00bf..b4cf195 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -172,14 +172,6 @@
f_ipa_ctrl_start(mp_hlr_ip, mp_hlr_ctrl_port);
 }

-function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
-   var charstring ret := f_vty_transceive_ret(pt, cmd);
-   if (not match(ret, exp_ret)) {
-   setverdict(fail, "Non-matching VTY response: ", ret);
-   self.stop;
-   }
-}
-
 private template (value) charstring t_subscr_prefix(hexstring imsi) :=
"subscriber imsi " & hex2str(imsi) & " ";

diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index 2b74694..f118865 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -128,5 +128,13 @@
f_vty_config2(pt, {config_node}, cmd);
 }

+function f_vty_transceive_match(TELNETasp_PT pt, charstring cmd, template 
charstring exp_ret) {
+   var charstring ret := f_vty_transceive_ret(pt, cmd);
+   if (not match(ret, exp_ret)) {
+   setverdict(fail, "Non-matching VTY response: ", ret);
+   self.stop;
+   }
+}
+

 }

--
To view, visit https://gerrit.osmocom.org/9557
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia69ab6d5639c2e10059f88c8cc97463820cb72e6
Gerrit-Change-Number: 9557
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 

Change in osmo-ttcn3-hacks[master]: *.default: change logging filemask from ERROR | WARNING to += PARALLE...

[lynxis lazus]

lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/9556


Change subject: *.default: change logging filemask from ERROR | WARNING to += 
PARALLEL | VERDICTOP
..

*.default: change logging filemask from ERROR | WARNING to += PARALLEL | 
VERDICTOP

PARALLEL | VERDICTOP will log when the port is dying or when other
components will change to fail. This helped to find a timeout in the
SGSN tests where a function call message timed out.

Change-Id: I770ac964dc37e2752e7d35e493f707b091c739b0
---
M bsc/BSC_Tests.default
M bts/BTS_Tests.default
M msc/MSC_Tests.default
M sgsn/SGSN_Tests.default
M sip/SIP_Tests.default
5 files changed, 23 insertions(+), 23 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/56/9556/1

diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default
index 6ba9ea2..c13f7b0 100644
--- a/bsc/BSC_Tests.default
+++ b/bsc/BSC_Tests.default
@@ -1,10 +1,10 @@
 [LOGGING]
 BSSAP.FileMask := LOG_NOTHING;
-"VirtMSC-M3UA".FileMask := ERROR | WARNING;
-"VirtMSC-SCCP".FileMask := ERROR | WARNING;
-"VirtMSC-MGCP".FileMask := ERROR | WARNING;
-"IPA0-RSL-IPA".FileMask := ERROR | WARNING;
-"IPA0-CTRL-IPA".FileMask := ERROR | WARNING;
+"VirtMSC-M3UA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"VirtMSC-SCCP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"VirtMSC-MGCP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"IPA0-RSL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"IPA0-CTRL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
 mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING | DEBUG_ENCDEC;

 [TESTPORT_PARAMETERS]
diff --git a/bts/BTS_Tests.default b/bts/BTS_Tests.default
index 196d088..502c17f 100644
--- a/bts/BTS_Tests.default
+++ b/bts/BTS_Tests.default
@@ -1,7 +1,7 @@
 [LOGGING]
-"BTS-Test-RSL-IPA".FileMask := ERROR | WARNING;
-"BTS-Test-RSL".FileMask := ERROR | WARNING;
-"IPA0-CTRL-IPA".FileMask := ERROR | WARNING;
+"BTS-Test-RSL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"BTS-Test-RSL".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"IPA0-CTRL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
 mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING | DEBUG_ENCDEC;

 [TESTPORT_PARAMETERS]
diff --git a/msc/MSC_Tests.default b/msc/MSC_Tests.default
index e8508c2..bcaae06 100644
--- a/msc/MSC_Tests.default
+++ b/msc/MSC_Tests.default
@@ -2,14 +2,14 @@
 FileMask := LOG_ALL | TTCN_MATCHING;

 BSSAP.FileMask := LOG_NOTHING;
-"MSC_Test_0-M3UA".FileMask := ERROR | WARNING;
-"MSC_Test_0-SCCP".FileMask := ERROR | WARNING;
-"MSC_Test_1-M3UA".FileMask := ERROR | WARNING;
-"MSC_Test_1-SCCP".FileMask := ERROR | WARNING;
-"MSC_Test-GSUP-IPA".FileMask := ERROR | WARNING;
-"MSC_Test-GSUP".FileMask := ERROR | WARNING;
-"IPA-CTRL-IPA".FileMask := ERROR | WARNING;
-mtc.FileMask := ERROR | WARNING;
+"MSC_Test_0-M3UA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"MSC_Test_0-SCCP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"MSC_Test_1-M3UA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"MSC_Test_1-SCCP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"MSC_Test-GSUP-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"MSC_Test-GSUP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"IPA-CTRL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+mtc.FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;

 [TESTPORT_PARAMETERS]
 "MSC_Test-MNCC".MNCC.socket_type := "SEQPACKET";
diff --git a/sgsn/SGSN_Tests.default b/sgsn/SGSN_Tests.default
index 67a8032..bac5fdd 100644
--- a/sgsn/SGSN_Tests.default
+++ b/sgsn/SGSN_Tests.default
@@ -1,11 +1,11 @@
 [LOGGING]
 FileMask := LOG_ALL | TTCN_MATCHING;

-"IPA-CTRL-IPA".FileMask := ERROR | WARNING;
-"SGSN_Test-GSUP-IPA".FileMask := ERROR | WARNING;
-"SGSN_Test-Gb0-NS".FileMask := ERROR | WARNING;
-"SGSN_Test-Gb0-BSSGP".FileMask := ERROR | WARNING;
-"SGSN_Test-GSUP".FileMask := ERROR | WARNING;
+"IPA-CTRL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"SGSN_Test-GSUP-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"SGSN_Test-Gb0-NS".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"SGSN_Test-Gb0-BSSGP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+"SGSN_Test-GSUP".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;

 [TESTPORT_PARAMETERS]
 *.SGSNVTY.CTRL_MODE := "client"
diff --git a/sip/SIP_Tests.default b/sip/SIP_Tests.default
index 5f7de90..2576b33 100644
--- a/sip/SIP_Tests.default
+++ b/sip/SIP_Tests.default
@@ -1,8 +1,8 @@
 [LOGGING]
 FileMask := LOG_ALL | TTCN_MATCHING;

-"IPA-CTRL-IPA".FileMask := ERROR | WARNING;
-mtc.FileMask := ERROR | WARNING;
+"IPA-CTRL-IPA".FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;
+mtc.FileMask := ERROR | WARNING | PARALLEL | VERDICTOP;

 [TESTPORT_PARAMETERS]
 "SIP_Test-MNCC".MNCC.socket_type := "SEQPACKET";

--
To view, visit https://gerrit.osmocom.org/9556
To unsubscribe, or 

Change in osmo-msc[master]: libmsc/gsm_04_80.c: make the API abstract from ss_request struct

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9555 )

Change subject: libmsc/gsm_04_80.c: make the API abstract from ss_request struct
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9555/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9555/1//COMMIT_MSG@16
PS1, Line 16: one can pass any incorrect,
: (e.g. negative) value, so the universal NULL tag will be used.
that's exactly the kind of documentation you'd want to have in a [doxygen] 
comment above the respective function(s).



--
To view, visit https://gerrit.osmocom.org/9555
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13d5abbfdcf8238ebaf0566c420f09cd9255b648
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 12 Jun 2018 06:34:23 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: libmsc/gsm_09_11.c: properly indicate transaction errors

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9554 )

Change subject: libmsc/gsm_09_11.c: properly indicate transaction errors
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9554
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecba2dccada9bbcdeb3a9dfd868719aeedc07022
Gerrit-Change-Number: 9554
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 12 Jun 2018 06:32:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: libmsc/gsm_04_08.c: expose gsm48_tx_simple()

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9553 )

Change subject: libmsc/gsm_04_08.c: expose gsm48_tx_simple()
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9553/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

https://gerrit.osmocom.org/#/c/9553/1/src/libmsc/gsm_04_08.c@1346
PS1, Line 1346: int gsm48_tx_simple(struct gsm_subscriber_connection *conn,
there was something about doxygen for newly-introduced public API :P



--
To view, visit https://gerrit.osmocom.org/9553
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a9d17fca4901163dae10d76455aa4cf54497156
Gerrit-Change-Number: 9553
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Tue, 12 Jun 2018 06:31:40 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-msc[master]: Use proper naming for GSM TS 09.11 implementation

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9552 )

Change subject: Use proper naming for GSM TS 09.11 implementation
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h
File include/osmocom/msc/ussd.h:

https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h@a5
PS1, Line 5:
what's your plan for backwards compatibility here? I suggest you keep the old 
symbol, mark it as deprecated using the related macro and simply turn it into a 
wrapper function for the new symbol.



--
To view, visit https://gerrit.osmocom.org/9552
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1eaceddb58132318e4e941be542da34b8ebefe1
Gerrit-Change-Number: 9552
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 12 Jun 2018 06:31:02 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes