date:20180620

Change in osmo-ttcn3-hacks[master]: msc/USSD: add test cases with network-initiaded SS/USSD

2018-06-20 Thread Vadim Yanitskiy

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9686

to look at the new patch set (#3).

Change subject: msc/USSD: add test cases with network-initiaded SS/USSD
..

msc/USSD: add test cases with network-initiaded SS/USSD

This change introduces two new test cases for network-initiaded
USSD notification and network-initiaded USSD request, which are
based on the existing SS/USSD related test cases.

The idea of TC_lu_and_mt_ussd_notification is to verify that
a network-initiaded USSD notification can arrive subscriber in
IDLE mode using Paging procedure.

The idea of TC_lu_and_mt_ussd_during_mt_call is to verify that
a network-initiaded USSD notification can arrive subscriber in
DEDICATED mode (in this case during a call) on a separate
transaction.

Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 215 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/86/9686/3
--
To view, visit https://gerrit.osmocom.org/9686
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
Gerrit-Change-Number: 9686
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte

Change in osmo-ttcn3-hacks[master]: msc/USSD: expect and reply SS/USSD messages over GSUP

2018-06-20 Thread Vadim Yanitskiy

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9685

to look at the new patch set (#2).

Change subject: msc/USSD: expect and reply SS/USSD messages over GSUP
..

msc/USSD: expect and reply SS/USSD messages over GSUP

As we are about to finish the implementation of GSM TS 09.11,
OsmoMSC will forward all SS/USSD messages over GSUP to HLR,
and will expect responses back from HLR. The SS/USSD payload
processing will be out of scope for OsmoMSC itself.

Let's modify the existing test cases in order to expect and
reply SS/USSD messages over GSUP protocol.

Change-Id: I01de73aced6057328a121577a5a83bc2615fb2d4
---
M msc/MSC_Tests.ttcn
1 file changed, 81 insertions(+), 40 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/85/9685/2
--
To view, visit https://gerrit.osmocom.org/9685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01de73aced6057328a121577a5a83bc2615fb2d4
Gerrit-Change-Number: 9685
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: add empty SS REQ/RSP templates

2018-06-20 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/9688


Change subject: library/GSUP_Types.ttcn: add empty SS REQ/RSP templates
..

library/GSUP_Types.ttcn: add empty SS REQ/RSP templates

The 'SS Info' IE is optional for GSUP_PROC_SS_{REQ|RSP} messages,
so it makes sense to add the corresponding empty templates.

Please note that matching with constructions like:

  tr_GSUP(
OSMO_GSUP_MSGT_PROC_SS_REQUEST,
{
  tr_GSUP_IE_IMSI(...),
  tr_GSUP_IE_SessionId(...),
  tr_GSUP_IE_SessionState(...),
  omit
}
  )

wouldn't work for some reason, and this is why the new
99% identical templates are introduced.

Change-Id: I20d9028acbe0c457d2a2cf72eff372b749d8dc30
---
M library/GSUP_Types.ttcn
1 file changed, 50 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/88/9688/1

diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 359e272..d595b00 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -581,6 +581,31 @@
}
 }

+template (value) GSUP_PDU ts_GSUP_PROC_SS_REQ_EMPTY(
+   hexstring imsi,
+   OCT4 sid,
+   GSUP_SessionState state
+) := ts_GSUP(
+   OSMO_GSUP_MSGT_PROC_SS_REQUEST,
+   {
+   valueof(ts_GSUP_IE_IMSI(imsi)),
+   valueof(ts_GSUP_IE_SessionId(sid)),
+   valueof(ts_GSUP_IE_SessionState(state))
+   }
+);
+template GSUP_PDU tr_GSUP_PROC_SS_REQ_EMPTY(
+   template hexstring imsi,
+   template OCT4 sid := ?,
+   template GSUP_SessionState state := ?
+) := tr_GSUP(
+   OSMO_GSUP_MSGT_PROC_SS_REQUEST,
+   {
+   tr_GSUP_IE_IMSI(imsi),
+   tr_GSUP_IE_SessionId(sid),
+   tr_GSUP_IE_SessionState(state)
+   }
+);
+
 template (value) GSUP_PDU ts_GSUP_PROC_SS_REQ(
hexstring imsi,
OCT4 sid,
@@ -610,6 +635,31 @@
}
 );

+template (value) GSUP_PDU ts_GSUP_PROC_SS_RES_EMPTY(
+   hexstring imsi,
+   OCT4 sid,
+   GSUP_SessionState state
+) := ts_GSUP(
+   OSMO_GSUP_MSGT_PROC_SS_RESULT,
+   {
+   valueof(ts_GSUP_IE_IMSI(imsi)),
+   valueof(ts_GSUP_IE_SessionId(sid)),
+   valueof(ts_GSUP_IE_SessionState(state))
+   }
+);
+template GSUP_PDU tr_GSUP_PROC_SS_RES_EMPTY(
+   template hexstring imsi,
+   template OCT4 sid := ?,
+   template GSUP_SessionState state := ?
+) := tr_GSUP(
+   OSMO_GSUP_MSGT_PROC_SS_RESULT,
+   {
+   tr_GSUP_IE_IMSI(imsi),
+   tr_GSUP_IE_SessionId(sid),
+   tr_GSUP_IE_SessionState(state)
+   }
+);
+
 template (value) GSUP_PDU ts_GSUP_PROC_SS_RES(
hexstring imsi,
OCT4 sid,

--
To view, visit https://gerrit.osmocom.org/9688
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20d9028acbe0c457d2a2cf72eff372b749d8dc30
Gerrit-Change-Number: 9688
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy

Change in osmo-ttcn3-hacks[master]: msc/USSD: introduce TC_lu_and_mo_ussd_mo_release

2018-06-20 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/9689


Change subject: msc/USSD: introduce TC_lu_and_mo_ussd_mo_release
..

msc/USSD: introduce TC_lu_and_mo_ussd_mo_release

The idea of this test case is to check the reaction of OsmoMSC
on MS-initiated release during an active transaction. In other
words, when the network is waiting for some response from a MS,
subscriber can press the 'red button' in order to terminate
this conversation.

It is expected that the MSC would terminate the transaction
as on DTAP interface, as on GSUP interface.

Change-Id: I7936ed5072ed2ae02f039dc90a1fece1e7f70a70
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 99 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/89/9689/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 5157d28..6030171 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2525,6 +2525,103 @@
vc_conn.done;
 }

+/* LU followed by MO USSD request and MO Release during transaction */
+private function f_tc_lu_and_mo_ussd_mo_release(charstring id, 
BSC_ConnHdlrPars pars)
+runs on BSC_ConnHdlr {
+   f_init_handler(pars);
+
+   /* Perform location update */
+   f_perform_lu();
+
+   /* Send CM Service Request for SS/USSD */
+   f_establish_fully(EST_TYPE_SS_ACT);
+
+   /* We need to inspect GSUP activity */
+   f_create_gsup_expect(hex2str(g_pars.imsi));
+
+   var template OCTN facility_ms_req := f_USSD_FACILITY_IE_INVOKE(
+   invoke_id := 1, /* Initial request */
+   op_code := SS_OP_CODE_PROCESS_USS_REQ,
+   ussd_string := "*6766*266#"
+   );
+
+   var template OCTN facility_net_req := f_USSD_FACILITY_IE_INVOKE(
+   invoke_id := 2, /* Counter request */
+   op_code := SS_OP_CODE_USS_REQUEST,
+   ussd_string := "Password?!?"
+   )
+
+   /* Compose MO SS/REGISTER message with request */
+   var template (value) PDU_ML3_MS_NW ussd_ms_req := ts_ML3_MO_SS_REGISTER(
+   tid := 1, /* We just need a single transaction */
+   ti_flag := c_TIF_ORIG, /* Sent from the side that originates 
the TI */
+   facility := valueof(facility_ms_req)
+   );
+
+   /* Compose expected MSC -> HLR message */
+   var template GSUP_PDU gsup_ms_req := tr_GSUP_PROC_SS_REQ(
+   imsi := g_pars.imsi,
+   state := OSMO_GSUP_SESSION_STATE_BEGIN,
+   ss := valueof(facility_ms_req)
+   );
+
+   /* To be used for sending response with correct session ID */
+   var GSUP_PDU gsup_ms_req_complete;
+
+   /* Initiate a new transaction */
+   BSSAP.send(ts_PDU_DTAP_MO(ussd_ms_req));
+   /* Expect GSUP request with original Facility IE */
+   gsup_ms_req_complete := f_expect_gsup_msg(gsup_ms_req);
+
+   /* Compose the response from HLR using received session ID */
+   var template (value) GSUP_PDU gsup_net_req := ts_GSUP_PROC_SS_REQ(
+   imsi := g_pars.imsi,
+   sid := gsup_ms_req_complete.ies[1].val.session_id,
+   state := OSMO_GSUP_SESSION_STATE_CONTINUE,
+   ss := valueof(facility_net_req)
+   );
+
+   /* Compose expected MT SS/FACILITY template with counter request */
+   var template PDU_ML3_NW_MS ussd_net_req := tr_ML3_MT_SS_FACILITY(
+   tid := 1, /* Response should arrive within the same transaction 
*/
+   ti_flag := c_TIF_REPL, /* Sent to the side that originates the 
TI */
+   facility := valueof(facility_net_req)
+   );
+
+   /* Send response over GSUP */
+   GSUP.send(gsup_net_req);
+   /* Expect MT SS/FACILITY message with counter request */
+   f_expect_mt_bssap_msg(ussd_net_req);
+
+   /* Compose MO SS/RELEASE COMPLETE */
+   var template (value) PDU_ML3_MS_NW ussd_abort := 
ts_ML3_MO_SS_RELEASE_COMPLETE(
+   tid := 1, /* Response should arrive within the same transaction 
*/
+   ti_flag := c_TIF_ORIG, /* Sent from the side that originates 
the TI */
+   facility := omit
+   /* TODO: cause? */
+   );
+
+   /* Compose expected HLR -> MSC abort message */
+   var template GSUP_PDU gsup_abort := tr_GSUP_PROC_SS_REQ_EMPTY(
+   imsi := g_pars.imsi,
+   sid := gsup_ms_req_complete.ies[1].val.session_id,
+   state := OSMO_GSUP_SESSION_STATE_END
+   );
+
+   /* Abort transaction */
+   BSSAP.send(ts_PDU_DTAP_MO(ussd_abort));
+   /* Expect GSUP message indicating abort */
+   f_expect_gsup_msg(gsup_abort);
+
+   f_expect_clear();
+}
+testcase TC_lu_and_mo_ussd_mo_release() runs on MTC_CT {
+   var BSC_ConnHdlr vc_conn;
+   f_init();
+   vc_conn := f_start_handler(refers(f_tc_lu_and_mo_ussd_mo_release),

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/armv7l

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  334s] make[3]: Nothing to be done for 'install-data-am'.
[  334s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  334s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  334s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  334s]dh_install
[  334s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  334s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  334s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  334s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  334s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  334s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  334s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  334s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  334s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  334s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  334s] dh_install: missing files, aborting
[  334s] debian/rules:6: recipe for target 'binary' failed
[  334s] make: *** [binary] Error 2
[  334s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  334s] 
[  334s] armbuild24 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 21:38:54 
UTC 2018.
[  334s] 
[  334s] ### VM INTERACTION START ###
[  337s] [  322.748578] SysRq : Power Off
[  337s] [  322.749924] reboot: Power down
[  337s] ### VM INTERACTION END ###
[  337s] 
[  337s] armbuild24 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 21:38:58 
UTC 2018.
[  337s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_17.10/x86_64

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  317s]dh_install
[  317s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in ., 
debian/tmp)
[  317s] 
[  317s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  317s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  317s] 
[  317s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  317s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in ., 
debian/tmp)
[  317s] 
[  317s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  317s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in ., debian/tmp)
[  317s] 
[  317s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  317s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  317s] 
[  317s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  317s] dh_install: missing files, aborting
[  317s] debian/rules:6: recipe for target 'binary' failed
[  317s] make: *** [binary] Error 25
[  317s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  317s] 
[  317s] cloud126 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:02:43 UTC 
2018.
[  317s] 
[  317s] ### VM INTERACTION START ###
[  320s] [  284.698297] reboot: Power down
[  321s] ### VM INTERACTION END ###
[  321s] 
[  321s] cloud126 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:02:47 UTC 
2018.
[  321s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_18.04/x86_64

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_18.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  233s]dh_install
[  233s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in ., 
debian/tmp)
[  233s] 
[  233s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  233s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  233s] 
[  233s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  233s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in ., 
debian/tmp)
[  233s] 
[  233s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  233s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in ., debian/tmp)
[  233s] 
[  233s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  233s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in ., 
debian/tmp)
[  233s] 
[  233s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  233s] dh_install: missing files, aborting
[  233s] debian/rules:6: recipe for target 'binary' failed
[  233s] make: *** [binary] Error 25
[  233s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess 
returned exit status 2
[  233s] 
[  233s] lamb23 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:01:09 UTC 
2018.
[  233s] 
[  233s] ### VM INTERACTION START ###
[  236s] [  223.722774] reboot: Power down
[  236s] ### VM INTERACTION END ###
[  236s] 
[  236s] lamb23 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:01:12 UTC 
2018.
[  236s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/x86_64

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  203s] make[3]: Nothing to be done for 'install-exec-am'.
[  203s] make[3]: Nothing to be done for 'install-data-am'.
[  203s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  203s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  203s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  203s]dh_install
[  203s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  203s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  203s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  203s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  203s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  203s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  203s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  203s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  203s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  203s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  203s] dh_install: missing files, aborting
[  203s] debian/rules:6: recipe for target 'binary' failed
[  203s] make: *** [binary] Error 2
[  203s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  203s] 
[  203s] lamb10 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:00:08 UTC 
2018.
[  203s] 
[  203s] ### VM INTERACTION START ###
[  206s] [  195.574535] reboot: Power down
[  206s] ### VM INTERACTION END ###
[  206s] 
[  206s] lamb10 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:00:11 UTC 
2018.
[  206s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in Debian_9.0/i586

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_9.0/i586

Package network:osmocom:nightly/osmo-trx failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  223s] make[3]: Nothing to be done for 'install-exec-am'.
[  223s] make[3]: Nothing to be done for 'install-data-am'.
[  223s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  223s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  223s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  223s]dh_install
[  223s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  223s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  223s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  223s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  223s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  223s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  223s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  223s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  223s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  223s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  223s] dh_install: missing files, aborting
[  223s] debian/rules:6: recipe for target 'binary' failed
[  223s] make: *** [binary] Error 2
[  223s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  223s] 
[  223s] lamb54 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:59:58 UTC 
2018.
[  223s] 
[  223s] ### VM INTERACTION START ###
[  226s] [  216.077028] reboot: Power down
[  226s] ### VM INTERACTION END ###
[  226s] 
[  226s] lamb54 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 20:00:02 UTC 
2018.
[  226s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/i586

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  210s] make[3]: Nothing to be done for 'install-exec-am'.
[  210s] make[3]: Nothing to be done for 'install-data-am'.
[  210s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  210s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  210s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  210s]dh_install
[  210s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  210s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  210s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  210s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  210s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  210s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  210s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  210s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  210s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  210s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  210s] dh_install: missing files, aborting
[  210s] debian/rules:6: recipe for target 'binary' failed
[  210s] make: *** [binary] Error 2
[  210s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  210s] 
[  210s] lamb18 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:59:30 UTC 
2018.
[  210s] 
[  210s] ### VM INTERACTION START ###
[  213s] [  204.091005] reboot: Power down
[  213s] ### VM INTERACTION END ###
[  213s] 
[  213s] lamb18 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:59:33 UTC 
2018.
[  213s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/x86_64

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  189s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  189s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  189s] make[2]: Entering directory '/usr/src/packages/BUILD'
[  189s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  189s] make[3]: Nothing to be done for 'install-exec-am'.
[  189s] make[3]: Nothing to be done for 'install-data-am'.
[  189s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  189s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  189s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  189s]dh_install
[  189s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  189s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  189s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  189s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  189s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  189s] dh_install: missing files, aborting
[  189s] debian/rules:6: recipe for target 'binary' failed
[  189s] make: *** [binary] Error 2
[  189s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  189s] 
[  189s] lamb19 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:58:46 UTC 
2018.
[  189s] 
[  189s] ### VM INTERACTION START ###
[  192s] [  184.544695] reboot: Power down
[  192s] ### VM INTERACTION END ###
[  192s] 
[  192s] lamb19 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:58:49 UTC 
2018.
[  192s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.10/x86_64

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  206s] make[3]: Nothing to be done for 'install-exec-am'.
[  206s] make[3]: Nothing to be done for 'install-data-am'.
[  206s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  206s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  206s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  206s]dh_install
[  206s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg" (tried in "." and 
"debian/tmp")
[  206s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  206s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  206s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  206s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg" (tried in "." and 
"debian/tmp")
[  206s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  206s] dh_install: Cannot find (any matches for) "/usr/bin/osmo-trx-lms" 
(tried in "." and "debian/tmp")
[  206s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  206s] dh_install: Cannot find (any matches for) 
"/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg" (tried in "." and 
"debian/tmp")
[  206s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  206s] dh_install: missing files, aborting
[  206s] debian/rules:6: recipe for target 'binary' failed
[  206s] make: *** [binary] Error 2
[  206s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  206s] 
[  206s] lamb59 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:58:33 UTC 
2018.
[  206s] 
[  206s] ### VM INTERACTION START ###
[  209s] [  200.010365] reboot: Power down
[  209s] ### VM INTERACTION END ###
[  209s] 
[  209s] lamb59 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:58:37 UTC 
2018.
[  209s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-trx in xUbuntu_16.04/i586

2018-06-20 Thread OBS Notification

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-trx failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-trx

Last lines of build log:
[  191s] make[4]: Leaving directory '/usr/src/packages/BUILD/tests'
[  191s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  191s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  191s] make[2]: Entering directory '/usr/src/packages/BUILD'
[  191s] make[3]: Entering directory '/usr/src/packages/BUILD'
[  191s] make[3]: Nothing to be done for 'install-exec-am'.
[  191s] make[3]: Nothing to be done for 'install-data-am'.
[  191s] make[3]: Leaving directory '/usr/src/packages/BUILD'
[  191s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  191s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  191s]dh_install
[  191s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg
[  191s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg
[  191s] dh_install: osmo-trx-uhd missing files: 
/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg
[  191s] dh_install: osmo-trx-lms missing files: /usr/bin/osmo-trx-lms
[  191s] dh_install: osmo-trx-lms missing files: 
/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg
[  191s] dh_install: missing files, aborting
[  191s] debian/rules:6: recipe for target 'binary' failed
[  191s] make: *** [binary] Error 2
[  191s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit 
status 2
[  191s] 
[  191s] lamb04 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:57:44 UTC 
2018.
[  191s] 
[  191s] ### VM INTERACTION START ###
[  194s] [  184.863278] reboot: Power down
[  194s] ### VM INTERACTION END ###
[  194s] 
[  194s] lamb04 failed "build osmo-trx_0.4.0.dsc" at Wed Jun 20 19:57:47 UTC 
2018.
[  194s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-ttcn3-hacks[master]: msc/USSD: add test cases with network-initiaded SS/USSD

2018-06-20 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9686 )

Change subject: msc/USSD: add test cases with network-initiaded SS/USSD
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn@2257
PS1, Line 2257: [] BSSAP.receive {
> those "alt" clauses are identical and copy+pasted several times below. […]
Done, thanks!

Please see: https://gerrit.osmocom.org/9687/



--
To view, visit https://gerrit.osmocom.org/9686
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
Gerrit-Change-Number: 9686
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 20 Jun 2018 19:28:05 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: msc/USSD: introduce common GSUP/BSSAP matching functions

2018-06-20 Thread Vadim Yanitskiy

Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/9687


Change subject: msc/USSD: introduce common GSUP/BSSAP matching functions
..

msc/USSD: introduce common GSUP/BSSAP matching functions

In order to avoid code duplication in the upcoming test cases,
let's introduce a few functions which basically do a GSUP/BSSAP
message matching within the alternative statement.

Change-Id: I846c2d40a7c37afa8647e644673b4df905e3e116
---
M msc/MSC_Tests.ttcn
1 file changed, 54 insertions(+), 56 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/87/9687/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 1af77cd..c56b9cc 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -2109,6 +2109,48 @@
  * USSD Testing
  ***/

+private function f_expect_gsup_msg(template GSUP_PDU gsup_msg)
+runs on BSC_ConnHdlr return GSUP_PDU {
+   var GSUP_PDU gsup_msg_complete;
+
+   alt {
+   [] GSUP.receive(gsup_msg) -> value gsup_msg_complete {
+   setverdict(pass);
+   }
+   [] GSUP.receive {
+   setverdict(fail, "Unknown/unexpected GSUP received");
+   self.stop;
+   }
+   [] BSSAP.receive {
+   setverdict(fail, "Unexpected BSSAP message received");
+   self.stop;
+   }
+   }
+
+   return gsup_msg_complete;
+}
+
+private function f_expect_mt_bssap_msg(template PDU_ML3_NW_MS bssap_msg)
+runs on BSC_ConnHdlr return PDU_ML3_NW_MS {
+   var PDU_DTAP_MT bssap_msg_complete;
+
+   alt {
+   [] BSSAP.receive(tr_PDU_DTAP_MT(bssap_msg)) -> value bssap_msg_complete 
{
+   setverdict(pass);
+   }
+   [] BSSAP.receive {
+   setverdict(fail, "Unknown/unexpected BSSAP received");
+   self.stop;
+   }
+   [] GSUP.receive {
+   setverdict(fail, "Unexpected GSUP message received");
+   self.stop;
+   }
+   }
+
+   return bssap_msg_complete.dtap;
+}
+
 /* LU followed by MO USSD request */
 private function f_tc_lu_and_mo_ussd_single_request(charstring id, 
BSC_ConnHdlrPars pars)
 runs on BSC_ConnHdlr {
@@ -2159,21 +2201,10 @@
/* To be used for sending response with correct session ID */
var GSUP_PDU gsup_req_complete;

-   /* Request own number request, wait for GSUP-request */
+   /* Request own number */
BSSAP.send(ts_PDU_DTAP_MO(ussd_req));
-   alt {
-   [] GSUP.receive(gsup_req) -> value gsup_req_complete {
-   setverdict(pass);
-   }
-   [] GSUP.receive {
-   setverdict(fail, "Unknown/unexpected GSUP received");
-   self.stop;
-   }
-   [] BSSAP.receive {
-   setverdict(fail, "Unexpected BSSAP message received");
-   self.stop;
-   }
-   }
+   /* Expect GSUP request with original Facility IE */
+   gsup_req_complete := f_expect_gsup_msg(gsup_req);

/* Compose the response from HLR using received session ID */
var template GSUP_PDU gsup_rsp := ts_GSUP_PROC_SS_REQ(
@@ -2183,21 +2214,10 @@
ss := valueof(facility_rsp)
);

+   /* Send response over GSUP */
GSUP.send(gsup_rsp);
-   alt {
-   /* We expect RELEASE_COMPLETE message with the response */
-   [] BSSAP.receive(tr_PDU_DTAP_MT(ussd_rsp)) {
-   setverdict(pass);
-   }
-   [] BSSAP.receive {
-   setverdict(fail, "Unknown/unexpected BSSAP received");
-   self.stop;
-   }
-   [] GSUP.receive {
-   setverdict(fail, "Unexpected GSUP message received");
-   self.stop;
-   }
-   }
+   /* Expect MT RELEASE COMPLETE message with USSD response */
+   f_expect_mt_bssap_msg(ussd_rsp);
 
f_expect_clear();
 }
@@ -2263,21 +2283,10 @@
/* To be used for sending response with correct session ID */
var GSUP_PDU gsup_req_complete;

-   /* Request own number request, wait for GSUP-request */
+   /* Request own number */
BSSAP.send(ts_PDU_DTAP_MO(ussd_req));
-   alt {
-   [] GSUP.receive(gsup_req) -> value gsup_req_complete {
-   setverdict(pass);
-   }
-   [] GSUP.receive {
-   setverdict(fail, "Unknown/unexpected GSUP received");
-   self.stop;
-   }
-   [] BSSAP.receive {
-   setverdict(fail, "Unexpected BSSAP message received");
-   self.stop;
-   }
-   }
+   /* Expect GSUP request with original Facility IE */
+   gsup_req_complete := f_expect_gsup_msg(gsup_req);

/* Compose the response from HLR using received session ID */
var template GSUP_PDU

Change in osmo-ttcn3-hacks[master]: msc/USSD: add test cases with network-initiaded SS/USSD

2018-06-20 Thread Vadim Yanitskiy

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9686

to look at the new patch set (#2).

Change subject: msc/USSD: add test cases with network-initiaded SS/USSD
..

msc/USSD: add test cases with network-initiaded SS/USSD

This change introduces two new test cases for network-initiaded
USSD notification and network-initiaded USSD request, which are
based on the existing SS/USSD related test cases.

The idea of TC_lu_and_mt_ussd_notification is to verify that
a network-initiaded USSD notification can arrive subscriber in
IDLE mode using Paging procedure.

The idea of TC_lu_and_mt_ussd_during_mt_call is to verify that
a network-initiaded USSD notification can arrive subscriber in
DEDICATED mode (in this case during a call) on a separate
transaction.

Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
---
M msc/MSC_Tests.ttcn
M msc/expected-results.xml
2 files changed, 227 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/86/9686/2
--
To view, visit https://gerrit.osmocom.org/9686
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
Gerrit-Change-Number: 9686
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #160

2018-06-20 Thread jenkins

See 


--
[...truncated 3.74 KB...]
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style

Change in osmo-ttcn3-hacks[master]: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case

2018-06-20 Thread Vadim Yanitskiy

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9683 )

Change subject: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case
..


Patch Set 1:

> I'm not sure this test should be dropped.  Rather, the test should
 > be adapted to simulate the HLR part which then rejects/denies the
 > USSD code.

Even if we simulate the Reject coming from HLR via GSUP, this test
case would merely duplicate the existing TC_lu_and_mo_ussd_single_request.

>From the OsmoMSC point of view, there is no difference, which kind of
GSM 04.80 payload (Invoke, ReturnResult or Reject components) is being
forwarded. This test case is only actual for the current OsmoMSC
implementation, which handles the SS/USSD itself.


--
To view, visit https://gerrit.osmocom.org/9683
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic104a49bb2dce2127063bcef8443ee6b639c9f19
Gerrit-Change-Number: 9683
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 20 Jun 2018 10:53:44 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-bsc[master]: doc: update/fix FSM charts

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9667 )

Change subject: doc: update/fix FSM charts
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9667
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29e31b753e23a4207662e0e385a337e7df836f45
Gerrit-Change-Number: 9667
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 08:09:11 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9666 )

Change subject: inter-BSC HO: add neighbor_ident API to manage 
neighbor-BSS-cells
..


Patch Set 3:

(5 comments)

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/gsm_data.h@755
PS3, Line 755: struct gsm_bts_ref {
not a request to change, just a general reminder: We also have the "vector" of 
libosmovty, which is sort of a dynamically-sized array of pointers to other 
objects which one might have used rather than a linked list.


https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h
File include/osmocom/bsc/neighbor_ident.h:

https://gerrit.osmocom.org/#/c/9666/3/include/osmocom/bsc/neighbor_ident.h@18
PS3, Line 18:   BSIC_9BIT,
huh, where's that 9 bit BSIC coming from? Do you have a spec reference for me?


https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c
File src/osmo-bsc/gsm_data.c:

https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/gsm_data.c@567
PS3, Line 567: bool gsm_bts_matches_cell_id(struct gsm_bts *bts, const struct 
gsm0808_cell_id *ci)
not important, but I'd expect 'bts' could also be a const pointer, as we're 
just reading/comparing/matching?


https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c
File src/osmo-bsc/neighbor_ident_vty.c:

https://gerrit.osmocom.org/#/c/9666/3/src/osmo-bsc/neighbor_ident_vty.c@560
PS3, Line 560:  install_element(BTS_NODE, _neighbor_resolve_cmd);
the BTS_NODE is a sub-node of the CONFIG NODE. Inside "configure terminal" we 
should only permit configuration commands, but not any query-type commands.  I 
think the proper place for a query command is the VIEW+ENABLE node. So you can 
do something like "bts 0 neighbor resolve ...".  If you still want to do it 
while in the CONFIG/BTS node, you can execute any VIEW/ENABLE command by 
prefixing it with "do".


https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c
File tests/handover/neighbor_ident_test.c:

https://gerrit.osmocom.org/#/c/9666/3/tests/handover/neighbor_ident_test.c@33
PS3, Line 33: arfcn
it might be interesting to have test cases for ARFCNs in different bands.  
Particularly take into consideration PCS band neighbor cells, where the PCS/DCS 
is indicated as 0x8000 bit of the uint16_t arfcn.  This gets easily missed in a 
lot of code.

I don't understand your current changes sufficiently to state if it's needed 
exactly here.  Just in general we need to consider neighbor cells in different 
bands, including PCS neigbors.



--
To view, visit https://gerrit.osmocom.org/9666
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0153d7069817fba9146ddc11214de2757d7d37bf
Gerrit-Change-Number: 9666
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 20 Jun 2018 08:09:08 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: msc/USSD: add test cases with network-initiaded SS/USSD

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9686 )

Change subject: msc/USSD: add test cases with network-initiaded SS/USSD
..


Patch Set 1:

(1 comment)

I love your work on the tests.  We can just redoce verbosity and number of 
copy+paste by using more TTCN3 language features. Thanks!

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9686/1/msc/MSC_Tests.ttcn@2257
PS1, Line 2257: [] BSSAP.receive {
those "alt" clauses are identical and copy+pasted several times below.  You 
should abstract those out into one or two altsteps and then either
a) call the altstep explicitly, i.e. "[] as_fail_on_gsup()", or
b) activating it/them as "default" so they become an implicit part of every 
"alt" or even stand-alone receive statement



--
To view, visit https://gerrit.osmocom.org/9686
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I073893c6e11be27e9e36f98f11c1491d0c173985
Gerrit-Change-Number: 9686
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:50:58 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: msc/USSD: expect and reply SS/USSD messages over GSUP

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9685 )

Change subject: msc/USSD: expect and reply SS/USSD messages over GSUP
..


Patch Set 1: Code-Review+1

looks good to me, but we should delay merging until the osmo-msc part is 
merged...


--
To view, visit https://gerrit.osmocom.org/9685
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01de73aced6057328a121577a5a83bc2615fb2d4
Gerrit-Change-Number: 9685
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:47:28 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: msc/USSD: use more informative names for test cases

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9684 )

Change subject: msc/USSD: use more informative names for test cases
..


Patch Set 1: Code-Review+2

it's important to get the naming right the first time when the tests are added. 
 The reason is that otherwise, the Jenkins test results analyzer (or any other 
consumer of the junit-xml output) will not be able to track the history across 
the renames of the tests.  It will simply add new lines and consider the 
renamed tests new.

So I can approve this once, but please don't make a habit of renaming test 
cases in the future.  Thanks!


--
To view, visit https://gerrit.osmocom.org/9684
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87f16f935f015dbd2ac2867d8ea5e155cc365e3f
Gerrit-Change-Number: 9684
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:46:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9683 )

Change subject: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case
..


Patch Set 1:

I'm not sure this test should be dropped.  Rather, the test should be adapted 
to simulate the HLR part which then rejects/denies the USSD code.


--
To view, visit https://gerrit.osmocom.org/9683
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic104a49bb2dce2127063bcef8443ee6b639c9f19
Gerrit-Change-Number: 9683
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte 
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:44:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: No

Change in osmo-ttcn3-hacks[master]: library/SS_Templates.ttcn: add empty Return Result template

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9681 )

Change subject: library/SS_Templates.ttcn: add empty Return Result template
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9681
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaff110c5f61cc87eda6143cd841f9832f6074bf
Gerrit-Change-Number: 9681
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:43:30 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: library/L3_Templates.ttcn: fix f_facility_or_wc(omit)

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9682 )

Change subject: library/L3_Templates.ttcn: fix f_facility_or_wc(omit)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9682
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I216195ef71c95997708dad8c31b172b6f6cdc461
Gerrit-Change-Number: 9682
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:43:46 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: lms: Allow values diff than 34dB to be set by setRxGain()

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9678 )

Change subject: lms: Allow values diff than 34dB to be set by setRxGain()
..

lms: Allow values diff than 34dB to be set by setRxGain()

Until now, setRxGain in LMSDevice did not take into account the setter
parameter and was always using hardcoded 34dB, which was experimentally
found to be a good default value.

Let's force that value during initialization, but still allow the upper
layers (controlled by BTS) to set different values. osmo-bts only sends
a SETRXGAIN command (which calls setRxGain in osmo-trx) if a value is
explicitly set in its VTY config, so we are on the safe side if the user
doesn't explicitly configure a desired dB.

Change-Id: I5684e675281a3f581855dbb56d199a6fe238a712
---
M Transceiver52M/device/lms/LMSDevice.cpp
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/device/lms/LMSDevice.cpp 
b/Transceiver52M/device/lms/LMSDevice.cpp
index 16585e6..ffea505 100644
--- a/Transceiver52M/device/lms/LMSDevice.cpp
+++ b/Transceiver52M/device/lms/LMSDevice.cpp
@@ -223,7 +223,7 @@

// Set gains to midpoint
setTxGain((minTxGain() + maxTxGain()) / 2, i);
-   setRxGain((minRxGain() + maxRxGain()) / 2, i);
+   setRxGain(34.0, i);

m_lms_stream_rx[i] = {};
m_lms_stream_rx[i].isTx = false;
@@ -327,8 +327,6 @@
return 0.0;
}

-   dB = 34.0;
-
if (dB > maxRxGain())
dB = maxRxGain();
if (dB < minRxGain())

--
To view, visit https://gerrit.osmocom.org/9678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5684e675281a3f581855dbb56d199a6fe238a712
Gerrit-Change-Number: 9678
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-trx[master]: lms: Allow values diff than 34dB to be set by setRxGain()

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9678 )

Change subject: lms: Allow values diff than 34dB to be set by setRxGain()
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5684e675281a3f581855dbb56d199a6fe238a712
Gerrit-Change-Number: 9678
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:41:15 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in openbsc[master]: bsc-nat: show running-config now prints bsc nodes

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9644 )

Change subject: bsc-nat: show running-config now prints bsc nodes
..

bsc-nat: show running-config now prints bsc nodes

Fixes: OS#3335
Change-Id: I847e84d5cc50619059cbae7a2c6471c60609aec6
---
M openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
1 file changed, 41 insertions(+), 39 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c 
b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
index e51de53..057d9ab 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat_vty.c
@@ -87,6 +87,46 @@
dump_lac(vty, >lists);
 }

+static void config_write_bsc_single(struct vty *vty, struct bsc_config *bsc)
+{
+   vty_out(vty, " bsc %u%s", bsc->nr, VTY_NEWLINE);
+   vty_out(vty, "  token %s%s", bsc->token, VTY_NEWLINE);
+   if (bsc->key_present)
+   vty_out(vty, "  auth-key %s%s", osmo_hexdump(bsc->key, 16), 
VTY_NEWLINE);
+   dump_lac(vty, >lac_list);
+   if (bsc->description)
+   vty_out(vty, "  description %s%s", bsc->description, 
VTY_NEWLINE);
+   if (bsc->acc_lst_name)
+   vty_out(vty, "  access-list-name %s%s", bsc->acc_lst_name, 
VTY_NEWLINE);
+   vty_out(vty, "  max-endpoints %d%s", bsc->max_endpoints, VTY_NEWLINE);
+   if (bsc->paging_group != -1)
+   vty_out(vty, "  paging group %d%s", bsc->paging_group, 
VTY_NEWLINE);
+   vty_out(vty, "  paging forbidden %d%s", bsc->forbid_paging, 
VTY_NEWLINE);
+   switch (bsc->osmux) {
+   case OSMUX_USAGE_ON:
+   vty_out(vty, "  osmux on%s", VTY_NEWLINE);
+   break;
+   case OSMUX_USAGE_ONLY:
+   vty_out(vty, "  osmux only%s", VTY_NEWLINE);
+   break;
+   }
+   if (bsc->bts_use_jibuf_override)
+   vty_out(vty, "  %sbts-jitter-buffer%s", bsc->bts_use_jibuf? "" 
: "no ", VTY_NEWLINE);
+   if (bsc->bts_jitter_delay_min_override)
+   vty_out(vty, "  bts-jitter-delay-min %"PRIu32"%s", 
bsc->bts_jitter_delay_min, VTY_NEWLINE);
+   if (bsc->bts_jitter_delay_max_override)
+   vty_out(vty, "  bts-jitter-delay-max %"PRIu32"%s", 
bsc->bts_jitter_delay_max, VTY_NEWLINE);
+}
+
+static int config_write_bsc(struct vty *vty)
+{
+   struct bsc_config *bsc;
+
+   llist_for_each_entry(bsc, &_nat->bsc_configs, entry)
+   config_write_bsc_single(vty, bsc);
+   return CMD_SUCCESS;
+}
+
 static int config_write_nat(struct vty *vty)
 {
struct bsc_msg_acc_lst *lst;
@@ -148,46 +188,8 @@
vty_out(vty, " %ssdp-ensure-amr-mode-set%s",
_nat->sdp_ensure_amr_mode_set ? "" : "no ", VTY_NEWLINE);

-   return CMD_SUCCESS;
-}
+   config_write_bsc(vty);

-static void config_write_bsc_single(struct vty *vty, struct bsc_config *bsc)
-{
-   vty_out(vty, " bsc %u%s", bsc->nr, VTY_NEWLINE);
-   vty_out(vty, "  token %s%s", bsc->token, VTY_NEWLINE);
-   if (bsc->key_present)
-   vty_out(vty, "  auth-key %s%s", osmo_hexdump(bsc->key, 16), 
VTY_NEWLINE);
-   dump_lac(vty, >lac_list);
-   if (bsc->description)
-   vty_out(vty, "  description %s%s", bsc->description, 
VTY_NEWLINE);
-   if (bsc->acc_lst_name)
-   vty_out(vty, "  access-list-name %s%s", bsc->acc_lst_name, 
VTY_NEWLINE);
-   vty_out(vty, "  max-endpoints %d%s", bsc->max_endpoints, VTY_NEWLINE);
-   if (bsc->paging_group != -1)
-   vty_out(vty, "  paging group %d%s", bsc->paging_group, 
VTY_NEWLINE);
-   vty_out(vty, "  paging forbidden %d%s", bsc->forbid_paging, 
VTY_NEWLINE);
-   switch (bsc->osmux) {
-   case OSMUX_USAGE_ON:
-   vty_out(vty, "  osmux on%s", VTY_NEWLINE);
-   break;
-   case OSMUX_USAGE_ONLY:
-   vty_out(vty, "  osmux only%s", VTY_NEWLINE);
-   break;
-   }
-   if (bsc->bts_use_jibuf_override)
-   vty_out(vty, "  %sbts-jitter-buffer%s", bsc->bts_use_jibuf? "" 
: "no ", VTY_NEWLINE);
-   if (bsc->bts_jitter_delay_min_override)
-   vty_out(vty, "  bts-jitter-delay-min %"PRIu32"%s", 
bsc->bts_jitter_delay_min, VTY_NEWLINE);
-   if (bsc->bts_jitter_delay_max_override)
-   vty_out(vty, "  bts-jitter-delay-max %"PRIu32"%s", 
bsc->bts_jitter_delay_max, VTY_NEWLINE);
-}
-
-static int config_write_bsc(struct vty *vty)
-{
-   struct bsc_config *bsc;
-
-   llist_for_each_entry(bsc, &_nat->bsc_configs, entry)
-   config_write_bsc_single(vty, bsc);
return CMD_SUCCESS;
 }
 

--
To view, visit https://gerrit.osmocom.org/9644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged

Change in openbsc[master]: bsc-nat: show running-config now prints bsc nodes

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9644 )

Change subject: bsc-nat: show running-config now prints bsc nodes
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I847e84d5cc50619059cbae7a2c6471c60609aec6
Gerrit-Change-Number: 9644
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:40:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, TC_ho_into_this_bsc

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9674 )

Change subject: bsc: inter-BSC HO: add TC_ho_out_of_this_bsc, 
TC_ho_into_this_bsc
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/9674/1/bsc/BSC_Tests.ttcn@2668
PS1, Line 2668: template PDU_BSSAP ts_BSSMAP_HandoverRequest(
> I can't get this to compile as a "template (value)", with or without 
> 'template' arguments, with or w […]
all the template arguments of a (value) template also need to be (value).  As 
"value" is a constraint on the more wider template type, you can only build 
such a constrained template type from other similarly constrained templates.

So you're saying it still failed if both the template itself as well as all its 
input arguments are constrained  to (value)?



--
To view, visit https://gerrit.osmocom.org/9674
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22852d4be7f127d827e7a8beeec55db27c07f03
Gerrit-Change-Number: 9674
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:38:17 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-trx[master]: Add -V param to print version

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9637 )

Change subject: Add -V param to print version
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9637
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f2d6c4b1a508aceb1ccc0559f0902eedf2ec5af
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:38:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Add -V param to print version

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9637 )

Change subject: Add -V param to print version
..

Add -V param to print version

Change-Id: I9f2d6c4b1a508aceb1ccc0559f0902eedf2ec5af
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 09ba14e..1c40fcf 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -49,6 +49,8 @@
 #include 
 #include 
 #include 
+#include 
+
 #include "convolve.h"
 #include "convert.h"
 #include "trx_vty.h"
@@ -194,6 +196,7 @@
fprintf(stdout, "Options:\n"
"  -hThis text\n"
"  -CFilename The config file to use\n"
+   "  -VPrint the version of OsmoTRX\n"
);
 }

@@ -211,7 +214,7 @@
std::vector rx_paths, tx_paths;
bool rx_paths_set = false, tx_paths_set = false;

-   while ((option = getopt(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:")) != -1) {
+   while ((option = getopt(argc, argv, 
"ha:l:i:j:p:c:dmxgfo:s:b:r:A:R:Set:y:z:C:V")) != -1) {
switch (option) {
case 'h':
print_help();
@@ -311,6 +314,10 @@
case 'C':
config_file = optarg;
break;
+   case 'V':
+   print_version(1);
+   exit(0);
+   break;
default:
goto bad_config;
}

--
To view, visit https://gerrit.osmocom.org/9637
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f2d6c4b1a508aceb1ccc0559f0902eedf2ec5af
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-trx[master]: contrib: Add systemd services for all backends

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9677 )

Change subject: contrib: Add systemd services for all backends
..

contrib: Add systemd services for all backends

Change-Id: I38a7ff7b9dafc3d6aa0426777036e3d7666045a7
---
A contrib/systemd/osmo-trx-lms.service
A contrib/systemd/osmo-trx-uhd.service
A contrib/systemd/osmo-trx-usrp1.service
A debian/osmo-trx-lms.service
A debian/osmo-trx-uhd.service
A debian/osmo-trx-usrp1.service
6 files changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/contrib/systemd/osmo-trx-lms.service 
b/contrib/systemd/osmo-trx-lms.service
new file mode 100644
index 000..df63e21
--- /dev/null
+++ b/contrib/systemd/osmo-trx-lms.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Osmocom SDR BTS L1 Transceiver (LimeSuite backend)
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-trx-lms -C /etc/osmocom/osmo-trx-lms.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
diff --git a/contrib/systemd/osmo-trx-uhd.service 
b/contrib/systemd/osmo-trx-uhd.service
new file mode 100644
index 000..ba27f37
--- /dev/null
+++ b/contrib/systemd/osmo-trx-uhd.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Osmocom SDR BTS L1 Transceiver (UHD Backend)
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-trx-uhd -C /etc/osmocom/osmo-trx-uhd.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
diff --git a/contrib/systemd/osmo-trx-usrp1.service 
b/contrib/systemd/osmo-trx-usrp1.service
new file mode 100644
index 000..fbff631
--- /dev/null
+++ b/contrib/systemd/osmo-trx-usrp1.service
@@ -0,0 +1,11 @@
+[Unit]
+Description=Osmocom SDR BTS L1 Transceiver (libusrp backend)
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/osmo-trx-usrp1 -C /etc/osmocom/osmo-trx-usrp1.cfg
+RestartSec=2
+
+[Install]
+WantedBy=multi-user.target
diff --git a/debian/osmo-trx-lms.service b/debian/osmo-trx-lms.service
new file mode 12
index 000..d2d697a
--- /dev/null
+++ b/debian/osmo-trx-lms.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-trx-lms.service
\ No newline at end of file
diff --git a/debian/osmo-trx-uhd.service b/debian/osmo-trx-uhd.service
new file mode 12
index 000..c67648f
--- /dev/null
+++ b/debian/osmo-trx-uhd.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-trx-uhd.service
\ No newline at end of file
diff --git a/debian/osmo-trx-usrp1.service b/debian/osmo-trx-usrp1.service
new file mode 12
index 000..a7b33ad
--- /dev/null
+++ b/debian/osmo-trx-usrp1.service
@@ -0,0 +1 @@
+../contrib/systemd/osmo-trx-usrp1.service
\ No newline at end of file

--
To view, visit https://gerrit.osmocom.org/9677
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a7ff7b9dafc3d6aa0426777036e3d7666045a7
Gerrit-Change-Number: 9677
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-ttcn3-hacks[master]: ttcn3-tcpdump-stop.sh: print colored verdict

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9675 )

Change subject: ttcn3-tcpdump-stop.sh: print colored verdict
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9675
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2d6171430f1eebb5377edac5e237a99ddbd743
Gerrit-Change-Number: 9675
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:33:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: contrib: Add systemd services for all backends

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9677 )

Change subject: contrib: Add systemd services for all backends
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9677
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a7ff7b9dafc3d6aa0426777036e3d7666045a7
Gerrit-Change-Number: 9677
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:33:17 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: debian: Add package osmo-trx-lms

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9679 )

Change subject: debian: Add package osmo-trx-lms
..

debian: Add package osmo-trx-lms

Change-Id: I3213c66907fbf0c7e531835b4993fa1bdc89edc3
---
M debian/control
A debian/osmo-trx-lms.install
2 files changed, 22 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/control b/debian/control
index b7e499e..ffb9ac1 100644
--- a/debian/control
+++ b/debian/control
@@ -13,6 +13,7 @@
libfftw3-dev,
libtalloc-dev,
libusrp-dev,
+   liblimesuite-dev,
libosmocore-dev (>= 0.10.0)
 Standards-Version: 3.9.6
 Vcs-Browser: http://cgit.osmocom.org/osmo-trx
@@ -28,7 +29,7 @@
 Architecture: any
 Section: debug
 Priority: extra
-Depends: osmo-trx-uhd (= ${binary:Version}), osmo-trx-usrp1 (= 
${binary:Version}), ${misc:Depends}
+Depends: osmo-trx-uhd (= ${binary:Version}), osmo-trx-usrp1 (= 
${binary:Version}), osmo-trx-lms (= ${binary:Version}), ${misc:Depends}
 Description: Debug symbols for the osmo-trx-*
  Make debugging possible

@@ -69,3 +70,22 @@
  3GPP is the "3rd Generation Partnership Project" which is the collaboration
  between different telecommunication associations for developing new
  generations of mobile phone networks. (post-2G/GSM)
+
+Package: osmo-trx-lms
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: SDR transceiver that implements Layer 1 of a GSM BTS (LimeSuite)
+ OsmoTRX is a software-defined radio transceiver that implements the Layer 1
+ physical layer of a BTS comprising the following 3GPP specifications:
+ .
+ TS 05.01 "Physical layer on the radio path"
+ TS 05.02 "Multiplexing and Multiple Access on the Radio Path"
+ TS 05.04 "Modulation"
+ TS 05.10 "Radio subsystem synchronization"
+ .
+ In this context, BTS is "Base transceiver station". It's the stations that
+ connect mobile phones to the mobile network.
+ .
+ 3GPP is the "3rd Generation Partnership Project" which is the collaboration
+ between different telecommunication associations for developing new
+ generations of mobile phone networks. (post-2G/GSM)
diff --git a/debian/osmo-trx-lms.install b/debian/osmo-trx-lms.install
new file mode 100644
index 000..5937edb
--- /dev/null
+++ b/debian/osmo-trx-lms.install
@@ -0,0 +1 @@
+/usr/bin/osmo-trx-lms

--
To view, visit https://gerrit.osmocom.org/9679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3213c66907fbf0c7e531835b4993fa1bdc89edc3
Gerrit-Change-Number: 9679
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-trx[master]: debian: Add cfg file examples for osmo-trx-{lms, uhd}

2018-06-20 Thread Harald Welte

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9680 )

Change subject: debian: Add cfg file examples for osmo-trx-{lms,uhd}
..

debian: Add cfg file examples for osmo-trx-{lms,uhd}

Sort cfg files according to their osmo-trx binary.
Install them during make install.
Add the installed cfg files to related debian packages.

Change-Id: I905cdac30b441e4df0a3f5c0924d1637b9f67b90
---
M Makefile.am
M configure.ac
M debian/osmo-trx-lms.install
M debian/osmo-trx-uhd.install
A doc/Makefile.am
A doc/examples/Makefile.am
R doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg
C doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg
R doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg
R doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg
10 files changed, 32 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/Makefile.am b/Makefile.am
index 71f7b91..8ab73a6 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,6 +28,7 @@

 # Order must be preserved
 SUBDIRS = \
+   doc \
CommonLibs \
GSM \
Transceiver52M \
diff --git a/configure.ac b/configure.ac
index aae151b..974a611 100644
--- a/configure.ac
+++ b/configure.ac
@@ -225,6 +225,8 @@
 tests/Makefile \
 tests/CommonLibs/Makefile \
 tests/Transceiver52M/Makefile \
+doc/Makefile \
+doc/examples/Makefile \
 ])

 AC_OUTPUT
diff --git a/debian/osmo-trx-lms.install b/debian/osmo-trx-lms.install
index 5937edb..e8bb867 100644
--- a/debian/osmo-trx-lms.install
+++ b/debian/osmo-trx-lms.install
@@ -1 +1,2 @@
 /usr/bin/osmo-trx-lms
+/usr/share/doc/osmo-trx-lms/examples/osmo-trx-limesdr.cfg 
/usr/share/doc/osmo-trx-lms/examples
diff --git a/debian/osmo-trx-uhd.install b/debian/osmo-trx-uhd.install
index 0005b76..2db0142 100644
--- a/debian/osmo-trx-uhd.install
+++ b/debian/osmo-trx-uhd.install
@@ -1 +1,4 @@
 /usr/bin/osmo-trx-uhd
+/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-usrp_b200.cfg 
/usr/share/doc/osmo-trx-uhd/examples
+/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-limesdr.cfg 
/usr/share/doc/osmo-trx-uhd/examples
+/usr/share/doc/osmo-trx-uhd/examples/osmo-trx-umtrx.cfg 
/usr/share/doc/osmo-trx-uhd/examples
diff --git a/doc/Makefile.am b/doc/Makefile.am
new file mode 100644
index 000..1d42b0a
--- /dev/null
+++ b/doc/Makefile.am
@@ -0,0 +1,3 @@
+SUBDIRS = \
+examples \
+$(NULL)
diff --git a/doc/examples/Makefile.am b/doc/examples/Makefile.am
new file mode 100644
index 000..530c3fa
--- /dev/null
+++ b/doc/examples/Makefile.am
@@ -0,0 +1,22 @@
+CFG_FILES = find $(srcdir) -name '*.cfg*' | sed -e 's,^$(srcdir),,'
+
+dist-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(distdir)/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+install-data-hook:
+   for f in $$($(CFG_FILES)); do \
+   j="$(DESTDIR)$(docdir)/examples/$$f" && \
+   mkdir -p "$$(dirname $$j)" && \
+   $(INSTALL_DATA) $(srcdir)/$$f $$j; \
+   done
+
+uninstall-hook:
+   @$(PRE_UNINSTALL)
+   for f in $$($(CFG_FILES)); do \
+   j="$(DESTDIR)$(docdir)/examples/$$f" && \
+   $(RM) $$j; \
+   done
diff --git a/doc/examples/osmo-trx-limesdr.cfg 
b/doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg
similarity index 100%
rename from doc/examples/osmo-trx-limesdr.cfg
rename to doc/examples/osmo-trx-lms/osmo-trx-limesdr.cfg
diff --git a/doc/examples/osmo-trx-limesdr.cfg 
b/doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg
similarity index 100%
copy from doc/examples/osmo-trx-limesdr.cfg
copy to doc/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg
diff --git a/doc/examples/osmo-trx-umtrx.cfg 
b/doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg
similarity index 100%
rename from doc/examples/osmo-trx-umtrx.cfg
rename to doc/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg
diff --git a/doc/examples/osmo-trx-usrp_b200.cfg 
b/doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg
similarity index 100%
rename from doc/examples/osmo-trx-usrp_b200.cfg
rename to doc/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg

--
To view, visit https://gerrit.osmocom.org/9680
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I905cdac30b441e4df0a3f5c0924d1637b9f67b90
Gerrit-Change-Number: 9680
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in osmo-trx[master]: debian: Add cfg file examples for osmo-trx-{lms, uhd}

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9680 )

Change subject: debian: Add cfg file examples for osmo-trx-{lms,uhd}
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9680
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I905cdac30b441e4df0a3f5c0924d1637b9f67b90
Gerrit-Change-Number: 9680
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:33:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: debian: Add package osmo-trx-lms

2018-06-20 Thread Harald Welte

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9679 )

Change subject: debian: Add package osmo-trx-lms
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3213c66907fbf0c7e531835b4993fa1bdc89edc3
Gerrit-Change-Number: 9679
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Jun 2018 07:32:59 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

40 matches

Mail list logo