Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9953 ) Change subject: add osmo_xua_msg_tall_ctx_init() .. Patch Set 2: I need this for https://gerrit.osmocom.org/9955 -- To view, visit

Change in libosmocore[master]: vty: fix use-after-free and memleaks in is_cmd_ambiguous()

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9939 ) Change subject: vty: fix use-after-free and memleaks in is_cmd_ambiguous() .. Patch Set 2: looking at my earlier comment it sounds like a

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9953 ) Change subject: add osmo_xua_msg_tall_ctx_init() .. Patch Set 2: ok, thought it was only libosmocore... -- To view, visit

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-11 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9953 to look at the new patch set (#2). Change subject: add osmo_xua_msg_tall_ctx_init() ..

Change in libosmo-sccp[master]: fix memleaks in mtp_user_prim_cb()

2018-07-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9957 to look at the new patch set (#2). Change subject: fix memleaks in mtp_user_prim_cb() .. fix memleaks

Change in libosmo-sccp[master]: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/9952 ) Change subject: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr .. cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr

Change in libosmo-sccp[master]: fix memleak in ipa_rx_msg_sccp

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/9951 ) Change subject: fix memleak in ipa_rx_msg_sccp .. fix memleak in ipa_rx_msg_sccp After m3ua_xfer_from_data() has copied the msgb

Change in libosmo-sccp[master]: comment: explain xua_msg free in m3ua_rx_xfer()

2018-07-11 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9958 to look at the new patch set (#3). Change subject: comment: explain xua_msg free in m3ua_rx_xfer()

Change in libosmo-sccp[master]: fix two memleaks in ipa_rx_msg_sccp()

2018-07-11 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9956 to look at the new patch set (#2). Change subject: fix two memleaks in ipa_rx_msg_sccp()

Change in osmo-ttcn3-hacks[master]: log / comment tweaks

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9627 ) Change subject: log / comment tweaks .. Patch Set 3: (exuse the double pasting typo) -- To view, visit https://gerrit.osmocom.org/9627 To

Change in osmo-ttcn3-hacks[master]: log / comment tweaks

2018-07-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9627 ) Change subject: log / comment tweaks .. Patch Set 3: ok, so the package summary shows "RSL ip.access CRCX ACK" but in the packet details

Jenkins build is back to normal : master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #4160

2018-07-11 Thread jenkins
See

Build failed in Jenkins: master-osmo-sgsn » --enable-iu,a2=default,a3=default,osmocom-master-debian9 #4159

2018-07-11 Thread jenkins
See -- [...truncated 992.49 KB...] void (*free)(type *); \ ^

Jenkins build is back to normal : master-osmo-mgw » --enable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1108

2018-07-11 Thread jenkins
See

Change in pysim[master]: cards: add update method for EF:PLMNsel to Card class

2018-07-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9970 Change subject: cards: add update method for EF:PLMNsel to Card class .. cards: add update method for EF:PLMNsel to Card class The Card class offers

Change in pysim[master]: pySim-read: read contents of PLMN related files.

2018-07-11 Thread dexter
dexter has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/9969 ) Change subject: pySim-read: read contents of PLMN related files. .. pySim-read: read contents of PLMN related files. The files EF.PLMNsel,

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

2018-07-11 Thread Holger Freyther
Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/9914 ) Change subject: Move from libc random() to osmo_get_rand_id .. Move from libc random() to osmo_get_rand_id When starting multiple

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

2018-07-11 Thread Holger Freyther
Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9914 ) Change subject: Move from libc random() to osmo_get_rand_id .. Patch Set 2: Code-Review+2 -- To view, visit

Change in pysim[master]: pySim-read: Print exception when reading of EF.MSISDN fails

2018-07-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9968 Change subject: pySim-read: Print exception when reading of EF.MSISDN fails .. pySim-read: Print exception when reading of EF.MSISDN fails At the

Change in pysim[master]: pySim-read: read contents of PLMN related files.

2018-07-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9969 Change subject: pySim-read: read contents of PLMN related files. .. pySim-read: read contents of PLMN related files. The files EF.PLMNsel,

Change in pysim[master]: cosmetic: fix excess space in log output (typo)

2018-07-11 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9967 Change subject: cosmetic: fix excess space in log output (typo) .. cosmetic: fix excess space in log output (typo) There shouldn't be a space

Change in python/osmo-python-tests[master]: Introduce script ctrl2cgi.py

2018-07-11 Thread Pau Espin Pedrol
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9963 to look at the new patch set (#2). Change subject: Introduce script ctrl2cgi.py .. Introduce script

Change in osmo-pcu[master]: tbf: Replace '.' in counter names with ':'

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9942 ) Change subject: tbf: Replace '.' in counter names with ':' .. tbf: Replace '.' in counter names with ':' The '.' is illegal

Change in osmo-pcu[master]: tbf: Use incrementing id for rate_ctr_group_alloc

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9943 ) Change subject: tbf: Use incrementing id for rate_ctr_group_alloc .. tbf: Use incrementing id for rate_ctr_group_alloc

Change in simtrace2[master]: sniff: add checksum verification for ATR and PPS

2018-07-11 Thread Kévin Redon
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9966 to look at the new patch set (#6). Change subject: sniff: add checksum verification for ATR and PPS ..

Change in simtrace2[master]: make adc2uv common

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9964 ) Change subject: make adc2uv common .. make adc2uv common when building the trace app for the simtrace board gcc was outputing the

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9946 ) Change subject: host sniff: add functions to print flags .. host sniff: add functions to print flags Change-Id:

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9946 ) Change subject: host sniff: add functions to print flags .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9946 To

Change in simtrace2[master]: fix 'ISO_S_IN_ATR not handled' gcc warning

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9965 ) Change subject: fix 'ISO_S_IN_ATR not handled' gcc warning .. fix 'ISO_S_IN_ATR not handled' gcc warning when building the cardem

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Kévin Redon
Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9946 ) Change subject: host sniff: add functions to print flags .. Patch Set 6: thanks for pointing it out. I wasn't aware of it. I only used struct

Change in simtrace2[master]: minor: fix linker warning

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9925 ) Change subject: minor: fix linker warning .. minor: fix linker warning linker warning: obj/simtrace/dfu_sniffer.o: In function

Change in simtrace2[master]: sniffer: move reset handling from ISR to main loop

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9922 ) Change subject: sniffer: move reset handling from ISR to main loop .. sniffer: move reset handling from ISR to main loop Change-Id:

Change in simtrace2[master]: sniffer: move data print before USB send

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9921 ) Change subject: sniffer: move data print before USB send .. sniffer: move data print before USB send when the host software does not

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9946 to look at the new patch set (#6). Change subject: host sniff: add functions to print flags .. host sniff: add

Change in simtrace2[master]: LED: add need pattern

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9923 ) Change subject: LED: add need pattern .. LED: add need pattern new LED pattern: off for 200 ms and then on Change-Id:

Change in simtrace2[master]: DFU: use central DFU override check

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9913 ) Change subject: DFU: use central DFU override check .. DFU: use central DFU override check TRACE_INFO will also provide the DFU

Change in simtrace2[master]: set linux end of line

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9917 ) Change subject: set linux end of line .. set linux end of line Change-Id: I5200f0d6f39b0641cac26a4109a3cd33e8474b9b --- M

Change in simtrace2[master]: host sniff: process remaining usb messages in buffer

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9945 ) Change subject: host sniff: process remaining usb messages in buffer .. host sniff: process remaining usb messages in buffer

Change in simtrace2[master]: USB: add flags for sniff data and centralise transfer

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9920 ) Change subject: USB: add flags for sniff data and centralise transfer .. USB: add flags for sniff data and centralise transfer Also

Change in simtrace2[master]: sniffer: set LED pattern

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9924 ) Change subject: sniffer: set LED pattern .. sniffer: set LED pattern The red and green LEDs are now used as follows: - red on =

Change in simtrace2[master]: cosmetic: put spaces around operations

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9919 ) Change subject: cosmetic: put spaces around operations .. cosmetic: put spaces around operations Change-Id:

Change in simtrace2[master]: sniffer: also send malformed message over USB

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9926 ) Change subject: sniffer: also send malformed message over USB .. sniffer: also send malformed message over USB Change-Id:

Change in simtrace2[master]: sniffer: only allocate USB message if queue is not too long

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9927 ) Change subject: sniffer: only allocate USB message if queue is not too long .. sniffer: only allocate USB message if queue is not too

Change in simtrace2[master]: sniffer: fix inverted reset meaning

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9944 ) Change subject: sniffer: fix inverted reset meaning .. sniffer: fix inverted reset meaning Change-Id:

Change in simtrace2[master]: host: set license to GPLv2+

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9915 ) Change subject: host: set license to GPLv2+ .. host: set license to GPLv2+ Change-Id: I0948d74874af1d3a0f1b4cbcb4a838e4ecd9fe3f ---

Change in simtrace2[master]: host: set license to GPLv2+

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9915 ) Change subject: host: set license to GPLv2+ .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9915 To unsubscribe,

Change in osmo-sgsn[master]: osmo-sgsn: ping GGSN periodically and check for restart counter

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9934 ) Change subject: osmo-sgsn: ping GGSN periodically and check for restart counter .. Set Ready For Review -- To view, visit

Change in osmo-ttcn3-hacks[master]: lib: GTP_Emulation: Allow receiving packets with TEID 0

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9949 ) Change subject: lib: GTP_Emulation: Allow receiving packets with TEID 0 .. lib: GTP_Emulation: Allow receiving packets with TEID

Change in osmo-pcu[master]: tbf: Replace '.' in counter names with ':'

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9942 ) Change subject: tbf: Replace '.' in counter names with ':' .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/9942

Change in pysim[master]: tests: add test program to verify pysim-prog.py (and pysim-read.py)

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9947 ) Change subject: tests: add test program to verify pysim-prog.py (and pysim-read.py) .. Patch Set 1: (1 comment) fine except the whitespace

Change in osmo-pcu[master]: tbf: Replace '.' in counter names with ':'

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9942 ) Change subject: tbf: Replace '.' in counter names with ':' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9942

Change in osmo-pcu[master]: tbf: Use incrementing id for rate_ctr_group_alloc

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9943 ) Change subject: tbf: Use incrementing id for rate_ctr_group_alloc .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: examples: Enable by default echo req towards active GGSNs

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9936 ) Change subject: examples: Enable by default echo req towards active GGSNs .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: vty: Add cmd to disable echo loop explictly

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9948 ) Change subject: vty: Add cmd to disable echo loop explictly .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9948

Change in osmo-ttcn3-hacks[master]: lib: GTP_Emulation: Allow receiving packets with TEID 0

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9949 ) Change subject: lib: GTP_Emulation: Allow receiving packets with TEID 0 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in python/osmo-python-tests[master]: Move twisted_ipa.py to osmopy lib

2018-07-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/9960 ) Change subject: Move twisted_ipa.py to osmopy lib .. Move twisted_ipa.py to osmopy lib twisted_ipa is a module expected to be

Change in libosmocore[master]: gsm0808: Add value_string for encryption algorithms

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9901 ) Change subject: gsm0808: Add value_string for encryption algorithms .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: fix memleaks in mtp_user_prim_cb()

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9957 ) Change subject: fix memleaks in mtp_user_prim_cb() .. Patch Set 1: Code-Review+1 looks fine to me, but should be thoroughly tested -- To

Change in simtrace2[master]: host: set license to GPLv2+

2018-07-11 Thread Kévin Redon
Kévin Redon has posted comments on this change. ( https://gerrit.osmocom.org/9915 ) Change subject: host: set license to GPLv2+ .. Patch Set 5: argh, wrong copy paste. now fixed -- To view, visit

Change in libosmo-sccp[master]: fix two memleaks in ipa_rx_msg_sccp()

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9956 ) Change subject: fix two memleaks in ipa_rx_msg_sccp() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9956 To

Change in libosmo-sccp[master]: add osmo_xua_msg_tall_ctx_init()

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9953 ) Change subject: add osmo_xua_msg_tall_ctx_init() .. Patch Set 1: Code-Review-1 (1 comment) let's please remove the misleading part from the

Change in libosmo-sccp[master]: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9952 ) Change subject: cosmetic: sccp2sua.c: log the IEI for parsed SCCP addr .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: fix memleak in ipa_rx_msg_sccp

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9951 ) Change subject: fix memleak in ipa_rx_msg_sccp .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9951 To

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: split up as_media into separate altsteps

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9961 ) Change subject: MSC_ConnectionHandler: split up as_media into separate altsteps .. MSC_ConnectionHandler: split up as_media into

Change in osmo-ttcn3-hacks[master]: BSC_Tests: count MGCP operations in as_media

2018-07-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9962 ) Change subject: BSC_Tests: count MGCP operations in as_media .. BSC_Tests: count MGCP operations in as_media as_media handles the

Change in osmo-ttcn3-hacks[master]: BSC_Tests: count MGCP operations in as_media

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9962 ) Change subject: BSC_Tests: count MGCP operations in as_media .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: split up as_media into separate altsteps

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9961 ) Change subject: MSC_ConnectionHandler: split up as_media into separate altsteps .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests_LCLS: try call legs with different codec/rate

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9941 ) Change subject: BSC_Tests_LCLS: try call legs with different codec/rate .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests: Also test LCLS with halfrate codecs

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9900 ) Change subject: BSC_Tests: Also test LCLS with halfrate codecs .. Patch Set 2: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniff: add checksum verification for ATR and PPS

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9966 ) Change subject: sniff: add checksum verification for ATR and PPS .. Patch Set 3: Code-Review+2 -- To view, visit

Change in simtrace2[master]: fix 'ISO_S_IN_ATR not handled' gcc warning

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9965 ) Change subject: fix 'ISO_S_IN_ATR not handled' gcc warning .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9965

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9946 ) Change subject: host sniff: add functions to print flags .. Patch Set 4: (1 comment)

Change in simtrace2[master]: make adc2uv common

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9964 ) Change subject: make adc2uv common .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9964 To unsubscribe, or for

Change in simtrace2[master]: host sniff: process remaining usb messages in buffer

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9945 ) Change subject: host sniff: process remaining usb messages in buffer .. Patch Set 4: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniffer: fix inverted reset meaning

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9944 ) Change subject: sniffer: fix inverted reset meaning .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9944 To

Change in simtrace2[master]: sniffer: also send malformed message over USB

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9926 ) Change subject: sniffer: also send malformed message over USB .. Patch Set 5: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniffer: only allocate USB message if queue is not too long

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9927 ) Change subject: sniffer: only allocate USB message if queue is not too long .. Patch Set 5: Code-Review+2 -- To view, visit

Change in simtrace2[master]: minor: fix linker warning

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9925 ) Change subject: minor: fix linker warning .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9925 To unsubscribe,

Change in simtrace2[master]: LED: add need pattern

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9923 ) Change subject: LED: add need pattern .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9923 To unsubscribe, or

Change in simtrace2[master]: sniffer: move reset handling from ISR to main loop

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9922 ) Change subject: sniffer: move reset handling from ISR to main loop .. Patch Set 5: Code-Review+2 -- To view, visit

Change in simtrace2[master]: sniffer: set LED pattern

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9924 ) Change subject: sniffer: set LED pattern .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9924 To unsubscribe, or

Change in simtrace2[master]: sniffer: move data print before USB send

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9921 ) Change subject: sniffer: move data print before USB send .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9921 To

Change in simtrace2[master]: USB: add flags for sniff data and centralise transfer

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9920 ) Change subject: USB: add flags for sniff data and centralise transfer .. Patch Set 5: Code-Review+2 -- To view, visit

Change in simtrace2[master]: replace leading spaces with tabs

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9918 ) Change subject: replace leading spaces with tabs .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9918 To

Change in simtrace2[master]: cosmetic: put spaces around operations

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9919 ) Change subject: cosmetic: put spaces around operations .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9919 To

Change in simtrace2[master]: firmware: set license to GPLv2+

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9916 ) Change subject: firmware: set license to GPLv2+ .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9916 To

Change in simtrace2[master]: host: set license to GPLv2+

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9915 ) Change subject: host: set license to GPLv2+ .. Patch Set 4: Code-Review-1 I'm sorry, but as mentioned several times, it should be "version 2

Change in simtrace2[master]: DFU: use central DFU override check

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9913 ) Change subject: DFU: use central DFU override check .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9913 To

Change in python/osmo-python-tests[master]: Move twisted_ipa.py to osmopy lib

2018-07-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9960 ) Change subject: Move twisted_ipa.py to osmopy lib .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/9960 To

Change in simtrace2[master]: sniffer: also send malformed message over USB

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9926 to look at the new patch set (#5). Change subject: sniffer: also send malformed message over USB .. sniffer: also

Change in simtrace2[master]: fix 'ISO_S_IN_ATR not handled' gcc warning

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9965 to look at the new patch set (#3). Change subject: fix 'ISO_S_IN_ATR not handled' gcc warning .. fix 'ISO_S_IN_ATR

Change in simtrace2[master]: USB: add flags for sniff data and centralise transfer

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9920 to look at the new patch set (#5). Change subject: USB: add flags for sniff data and centralise transfer .. USB: add

Change in simtrace2[master]: host sniff: add functions to print flags

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9946 to look at the new patch set (#4). Change subject: host sniff: add functions to print flags .. host sniff: add

Change in simtrace2[master]: sniffer: set LED pattern

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9924 to look at the new patch set (#5). Change subject: sniffer: set LED pattern .. sniffer: set LED pattern The red and

Change in simtrace2[master]: sniff: add checksum verification for ATR and PPS

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9966 to look at the new patch set (#3). Change subject: sniff: add checksum verification for ATR and PPS .. sniff: add

Change in simtrace2[master]: LED: add need pattern

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9923 to look at the new patch set (#5). Change subject: LED: add need pattern .. LED: add need pattern new LED pattern:

Change in simtrace2[master]: make adc2uv common

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9964 to look at the new patch set (#3). Change subject: make adc2uv common .. make adc2uv common when building the trace

Change in simtrace2[master]: sniffer: only allocate USB message if queue is not too long

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9927 to look at the new patch set (#5). Change subject: sniffer: only allocate USB message if queue is not too long ..

Change in simtrace2[master]: DFU: use central DFU override check

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9913 to look at the new patch set (#4). Change subject: DFU: use central DFU override check .. DFU: use central DFU

Change in simtrace2[master]: minor: fix linker warning

2018-07-11 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/9925 to look at the new patch set (#5). Change subject: minor: fix linker warning .. minor: fix linker warning linker

  1   2   >