Change in libosmocore[master]: add osmo_classmark_* API

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12659 )

Change subject: add osmo_classmark_* API
..


Patch Set 2:

(8 comments)

https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1199
PS2, Line 1199: snprintf(cm1, sizeof(cm1), "no-cm1");
> Again, I suggest to avoid this snprintf() call. Just initialize the cm1[]: […]
PoC: https://pastebin.com/rUvt095q


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1230
PS2, Line 1230: const struct osmo_classmark *src, struct osmo_classmark *dst
Let's follow the common (for memcpy, strcpy and memset) sequence here: dst, src.


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1234
PS2, Line 1234: dst->classmark1_set
Should we assign false otherwise?


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1238
PS2, Line 1238: sizeof(dst->classmark2)
Why not classmark2_len?


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1242
PS2, Line 1242: sizeof
same


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1269
PS2, Line 1269: } else {
Cosmetic: nesting is not required here, because we return from the main 'if' 
branch.


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1271
PS2, Line 1271: /* Inverted logic for this bit! */
This comment is actually related to the prev. line, please move it.


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1303
PS2, Line 1303: return 0;
(just wondering) shouldn't we indicate this 'out of range' case somehow?



--
To view, visit https://gerrit.osmocom.org/12659
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd27bab0380f7ad0c44c719aa6c8bd62cf7b034c
Gerrit-Change-Number: 12659
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 21 Jan 2019 05:28:22 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: add osmo_classmark_* API

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12659 )

Change subject: add osmo_classmark_* API
..


Patch Set 2: Code-Review-1

(5 comments)

Looks good, but I would prefer to avoid useless snprintf() calls in the 'else' 
branches.

https://gerrit.osmocom.org/#/c/12659/2/include/osmocom/gsm/protocol/gsm_04_08.h
File include/osmocom/gsm/protocol/gsm_04_08.h:

https://gerrit.osmocom.org/#/c/12659/2/include/osmocom/gsm/protocol/gsm_04_08.h@59
PS2, Line 59: osmo_classmark
Since this is a part of GSM 04.08, can we use "osmo_gsm48_" as prefix?


https://gerrit.osmocom.org/#/c/12659/2/include/osmocom/gsm/protocol/gsm_04_08.h@63
PS2, Line 63: classmark2
(just wondering) we also have gsm48_classmark2, why not to use it here?


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1199
PS2, Line 1199: snprintf(cm1, sizeof(cm1), "no-cm1");
Again, I suggest to avoid this snprintf() call. Just initialize the cm1[]:

  char cm1[42] = "no-cm1";


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1207
PS2, Line 1207: snprintf
same


https://gerrit.osmocom.org/#/c/12659/2/src/gsm/gsm48.c@1217
PS2, Line 1217: snprintf
too



--
To view, visit https://gerrit.osmocom.org/12659
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd27bab0380f7ad0c44c719aa6c8bd62cf7b034c
Gerrit-Change-Number: 12659
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 21 Jan 2019 05:14:37 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 9: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm0808_utils.c@1373
PS9, Line 1373: gsm0808_cell_id_u_name
Are there any users of this function outside the library?
Maybe we should mark it as deprecated instead?


https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c
File src/gsm/gsm23003.c:

https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c@339
PS9, Line 339: a->lac > b->lac
If not a < b, and not a > b, then a != b, right?


https://gerrit.osmocom.org/#/c/11504/9/src/gsm/gsm23003.c@356
PS9, Line 356: a->cell_identity > b->cell_identity
same here.


https://gerrit.osmocom.org/#/c/11504/9/src/gsm/libosmogsm.map
File src/gsm/libosmogsm.map:

https://gerrit.osmocom.org/#/c/11504/9/src/gsm/libosmogsm.map@213
PS9, Line 213: gsm0808_cell_id_u_match
So, you're making this symbol static, thus breaking the API, but still keeping 
it here?



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Mon, 21 Jan 2019 05:01:34 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: Add SGs Interface

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11642 )

Change subject: Add SGs Interface
..


Patch Set 30:

(1 comment)

https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c@564
PS30, Line 564: conn->via_ran == OSMO_RAT_UTRAN_IU ? "Iu" : "A",
> here maybe rather use osmo_rat_type_name(), otherwise all SGs conns are shown 
> as "A".
(BTW, for the inter-MSC stuff, this will have to change anyway, so it's enough 
to solve it trivially / quickly and not spend much time on it.)



--
To view, visit https://gerrit.osmocom.org/11642
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d
Gerrit-Change-Number: 11642
Gerrit-PatchSet: 30
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-CC: Stefan Sperling 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Mon, 21 Jan 2019 01:45:58 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/armv7l

Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  159s]   ^
[  159s] In file included from /usr/include/osmocom/gsm/gsm48.h:7:0,
[  159s]  from ../../include/osmocom/msc/gsm_data.h:13,
[  159s]  from gsm_04_80.c:32:
[  159s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  159s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  159s]   ^
[  159s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  159s] make[4]: *** [gsm_04_80.o] Error 1
[  159s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  159s] Makefile:421: recipe for target 'all-recursive' failed
[  159s] make[3]: *** [all-recursive] Error 1
[  159s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  159s] Makefile:457: recipe for target 'all-recursive' failed
[  159s] make[2]: *** [all-recursive] Error 1
[  159s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  159s] Makefile:389: recipe for target 'all' failed
[  159s] make[1]: *** [all] Error 2
[  159s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  159s] dh_auto_build: make -j1 returned exit code 2
[  159s] debian/rules:45: recipe for target 'build' failed
[  159s] make: *** [build] Error 2
[  159s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  159s] 
[  159s] armbuild13 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:41:25 
UTC 2019.
[  159s] 
[  159s] ### VM INTERACTION START ###
[  162s] [  128.958091] SysRq : Power Off
[  162s] [  128.959518] reboot: Power down

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_9.0/aarch64

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  230s] Got LLC message, CRC: ea7648 (computed ea7648)
[  230s] Unhandled GSM 04.08 message type ATTACH COMPLETE for protocol 
discriminator GMM.
[  230s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x327330 CMD=UI DATA 
[  230s] Got LLC message, CRC: 327330 (computed 327330)
[  230s] RA_UPD_REQ: Got TLLI efe2b700, BSSGP RAID 112-332-16464-96, old RAID 
112-332-16464-96
[  230s] gbproxy_validate_tlli({current = afe2b700, assigned = efe2b700, 
net_vld = 0, bss_vld = 1}, efe2b700)
[  230s] gbproxy_validate_tlli({current = afe2b700, assigned = efe2b700, 
net_vld = 0, bss_vld = 1}, efe2b700)
[  230s] Updated LLC message, CRC: 327330 -> 327330
[  230s] NSEI=4096 proxying BTS->SGSN (NS_BVCI=4098, NSEI=256)
[  230s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0x327330 CMD=UI DATA 
[  230s] Got LLC message, CRC: 327330 (computed 327330)
[  230s] LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa73041 CMD=UI DATA 
[  230s] Got LLC message, CRC: a73041 (computed a73041)
[  230s] RA_UPD_REJ: Got TLLI efe2b700, IMSI 12131415161718, invalidate, 
re-attach
[  230s] gbproxy_validate_tlli({current = afe2b700, assigned = efe2b700, 
net_vld = 0, bss_vld = 1}, efe2b700)
[  230s] The TLLI efe2b700 has been validated (was afe2b700)
[  230s] gbproxy_validate_tlli({current = afe2b700, assigned = efe2b700, 
net_vld = 0, bss_vld = 1}, efe2b700)
[  230s] The TLLI efe2b700 has been validated (was afe2b700)
[  230s] Unregistering TLLI efe2b700
[  230s] NSEI=256 proxying SGSN->BSS (NS_BVCI=4098, NSEI=4096)
[  230s] LLC SAPI=1 R   U GEA? IOV-UI=0x00 FCS=0xa73041 CMD=UI DATA 
[  230s] Got LLC message, CRC: a73041 (computed a73041)
[  230s] LLC SAPI=1 C   U GEA? IOV-UI=0x00 FCS=0xc3cc50 CMD=UI DATA 
[  232s] Got LLC message, CRC: c3cc50 (computed[  209.227465] sysrq: SysRq : 
Power Off
[  232s] [  209.231727] reboot: Power down
[  232s] ### VM INTERACTION END ###
[  232s] 
[  232s] obs-arm-3 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:38:29 
UTC 2019.
[  232s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/aarch64

Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   89s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   89s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   89s]   ^
[   89s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   89s] make[4]: *** [gsm_04_80.o] Error 1
[   89s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   89s] Makefile:421: recipe for target 'all-recursive' failed
[   89s] make[3]: *** [all-recursive] Error 1
[   89s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   89s] Makefile:457: recipe for target 'all-recursive' failed
[   89s] make[2]: *** [all-recursive] Error 1
[   89s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   89s] Makefile:389: recipe for target 'all' failed
[   89s] make[1]: *** [all] Error 2
[   89s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   89s] dh_auto_build: make -j1 returned exit code 2
[   89s] debian/rules:45: recipe for target 'build' failed
[   89s] make: *** [build] Error 2
[   89s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   89s] 
[   89s] obs-arm-7 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:36:05 UTC 
2019.
[   89s] 
[   89s] ### VM INTERACTION START ###
[   92s] [   79.677043] sysrq: SysRq : Power Off
[   92s] [   79.698476] reboot: Power down
[   92s] ### VM INTERACTION END ###
[   92s] 
[   92s] obs-arm-7 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:36:08 UTC 
2019.
[   92s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_9.0/armv7l

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  146s]  06 
[  146s]  
[  146s] -==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  146s] -
[  146s]  MESSAGE to BSS at 0x01020304:, msg length 1
[  146s]  07 
[  146s]  
[  146s] +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  146s] +
[  146s]  result (UNBLOCK) = 1
[  146s]  
[  146s]  PROCESSING ALIVE_ACK from 0x01020304:
[  146s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  146s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  146s] make[1]: *** [override_dh_auto_test] Error 1
[  146s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  146s] debian/rules:45: recipe for target 'build' failed
[  146s] make: *** [build] Error 2
[  146s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  146s] 
[  146s] armbuild22 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:35:41 
UTC 2019.
[  146s] 
[  146s] ### VM INTERACTION START ###
[  148s] [  132.138690] SysRq : Power Off
[  148s] [  132.140308] reboot: Power down
[  148s] ### VM INTERACTION END ###
[  148s] 
[  148s] armbuild22 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:35:44 
UTC 2019.
[  148s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_17.10/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  144s] | #define HAVE_STRING_H 1
[  144s] | #define HAVE_MEMORY_H 1
[  144s] | #define HAVE_STRINGS_H 1
[  144s] | #define HAVE_INTTYPES_H 1
[  144s] | #define HAVE_STDINT_H 1
[  144s] | #define HAVE_UNISTD_H 1
[  144s] | #define HAVE_DLFCN_H 1
[  144s] | #define LT_OBJDIR ".libs/"
[  144s] | #define STDC_HEADERS 1
[  144s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  144s] | 
[  144s] | configure: exit 0
[  144s] 
[  144s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  144s] make[1]: *** [override_dh_auto_test] Error 1
[  144s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  144s] debian/rules:45: recipe for target 'build' failed
[  144s] make: *** [build] Error 2
[  144s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  144s] 
[  144s] cloud122 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:26:13 UTC 
2019.
[  144s] 
[  144s] ### VM INTERACTION START ###
[  148s] [  123.683161] sysrq: SysRq : Power Off
[  148s] [  123.687797] reboot: Power down
[  149s] ### VM INTERACTION END ###
[  149s] 
[  149s] cloud122 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:26:18 UTC 
2019.
[  149s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_18.04/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  134s] | #define HAVE_STRING_H 1
[  134s] | #define HAVE_MEMORY_H 1
[  134s] | #define HAVE_STRINGS_H 1
[  134s] | #define HAVE_INTTYPES_H 1
[  134s] | #define HAVE_STDINT_H 1
[  134s] | #define HAVE_UNISTD_H 1
[  134s] | #define HAVE_DLFCN_H 1
[  134s] | #define LT_OBJDIR ".libs/"
[  134s] | #define STDC_HEADERS 1
[  134s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  134s] | 
[  134s] | configure: exit 0
[  134s] 
[  134s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  134s] make[1]: *** [override_dh_auto_test] Error 1
[  134s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  134s] debian/rules:45: recipe for target 'build' failed
[  134s] make: *** [build] Error 2
[  134s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  134s] 
[  134s] morla3 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:26:26 UTC 
2019.
[  134s] 
[  134s] ### VM INTERACTION START ###
[  137s] [  123.102846] sysrq: SysRq : Power Off
[  137s] [  123.107476] reboot: Power down
[  137s] ### VM INTERACTION END ###
[  137s] 
[  137s] morla3 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:26:30 UTC 
2019.
[  137s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_17.04/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  118s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  118s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  118s]   ^
[  118s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  118s] make[4]: *** [gsm_04_80.o] Error 1
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  118s] Makefile:421: recipe for target 'all-recursive' failed
[  118s] make[3]: *** [all-recursive] Error 1
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  118s] Makefile:457: recipe for target 'all-recursive' failed
[  118s] make[2]: *** [all-recursive] Error 1
[  118s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  118s] Makefile:389: recipe for target 'all' failed
[  118s] make[1]: *** [all] Error 2
[  118s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  118s] dh_auto_build: make -j1 returned exit code 2
[  118s] debian/rules:45: recipe for target 'build' failed
[  118s] make: *** [build] Error 2
[  118s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  118s] 
[  118s] cloud112 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:26:04 UTC 
2019.
[  118s] 
[  118s] ### VM INTERACTION START ###
[  121s] [  100.905042] sysrq: SysRq : Power Off
[  121s] [  100.909543] reboot: Power down
[  123s] ### VM INTERACTION END ###
[  123s] 
[  123s] cloud112 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:26:10 UTC 
2019.
[  123s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_17.10/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   49s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   49s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   49s]   ^
[   49s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   49s] make[4]: *** [gsm_04_80.o] Error 1
[   49s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   49s] Makefile:421: recipe for target 'all-recursive' failed
[   49s] make[3]: *** [all-recursive] Error 1
[   49s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   49s] Makefile:457: recipe for target 'all-recursive' failed
[   49s] make[2]: *** [all-recursive] Error 1
[   49s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   49s] Makefile:389: recipe for target 'all' failed
[   49s] make[1]: *** [all] Error 2
[   49s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   49s] dh_auto_build: make -j1 returned exit code 2
[   49s] debian/rules:45: recipe for target 'build' failed
[   49s] make: *** [build] Error 2
[   49s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   49s] 
[   49s] build79 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:31 UTC 
2019.
[   49s] 
[   49s] ### VM INTERACTION START ###
[   52s] [   44.049475] sysrq: SysRq : Power Off
[   52s] [   44.051491] reboot: Power down
[   52s] ### VM INTERACTION END ###
[   52s] 
[   52s] build79 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:35 UTC 
2019.
[   52s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_17.04/i586

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  141s]  06 
[  141s]  
[  141s] -==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  141s] -
[  141s]  MESSAGE to BSS at 0x01020304:, msg length 1
[  141s]  07 
[  141s]  
[  141s] +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  141s] +
[  141s]  result (UNBLOCK) = 1
[  141s]  
[  141s]  PROCESSING ALIVE_ACK from 0x01020304:
[  141s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  141s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  141s] make[1]: *** [override_dh_auto_test] Error 1
[  141s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  141s] debian/rules:45: recipe for target 'build' failed
[  141s] make: *** [build] Error 2
[  141s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  141s] 
[  141s] cloud117 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:24:54 UTC 
2019.
[  141s] 
[  141s] ### VM INTERACTION START ###
[  144s] [  121.335062] sysrq: SysRq : Power Off
[  144s] [  121.339641] reboot: Power down
[  145s] ### VM INTERACTION END ###
[  145s] 
[  145s] cloud117 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:24:59 UTC 
2019.
[  145s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_17.04/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[   60s] | #define HAVE_STRING_H 1
[   60s] | #define HAVE_MEMORY_H 1
[   60s] | #define HAVE_STRINGS_H 1
[   60s] | #define HAVE_INTTYPES_H 1
[   60s] | #define HAVE_STDINT_H 1
[   60s] | #define HAVE_UNISTD_H 1
[   60s] | #define HAVE_DLFCN_H 1
[   60s] | #define LT_OBJDIR ".libs/"
[   60s] | #define STDC_HEADERS 1
[   60s] | #define HAVE_TM_GMTOFF_IN_TM 1
[   60s] | 
[   60s] | configure: exit 0
[   60s] 
[   60s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[   60s] make[1]: *** [override_dh_auto_test] Error 1
[   60s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   60s] debian/rules:45: recipe for target 'build' failed
[   60s] make: *** [build] Error 2
[   60s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   60s] 
[   60s] build74 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:25:02 UTC 
2019.
[   60s] 
[   60s] ### VM INTERACTION START ###
[   63s] [   55.496143] sysrq: SysRq : Power Off
[   63s] [   55.498061] reboot: Power down
[   63s] ### VM INTERACTION END ###
[   63s] 
[   63s] build74 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:25:06 UTC 
2019.
[   63s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_18.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_18.04/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_18.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  108s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  108s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  108s]   ^
[  108s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  108s] make[4]: *** [gsm_04_80.o] Error 1
[  108s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  108s] Makefile:421: recipe for target 'all-recursive' failed
[  108s] make[3]: *** [all-recursive] Error 1
[  108s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  108s] Makefile:457: recipe for target 'all-recursive' failed
[  108s] make[2]: *** [all-recursive] Error 1
[  108s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  108s] Makefile:389: recipe for target 'all' failed
[  108s] make[1]: *** [all] Error 2
[  108s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  108s] dh_auto_build: make -j1 returned exit code 2
[  108s] debian/rules:45: recipe for target 'build' failed
[  108s] make: *** [build] Error 2
[  108s] dpkg-buildpackage: error: debian/rules build subprocess returned exit 
status 2
[  108s] 
[  108s] lamb57 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:25:58 UTC 
2019.
[  108s] 
[  108s] ### VM INTERACTION START ###
[  111s] [   99.886164] sysrq: SysRq : Power Off
[  111s] [   99.894369] reboot: Power down
[  111s] ### VM INTERACTION END ###
[  111s] 
[  111s] lamb57 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:26:02 UTC 
2019.
[  111s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_9.0/i586

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  109s] | #define HAVE_STRING_H 1
[  109s] | #define HAVE_MEMORY_H 1
[  109s] | #define HAVE_STRINGS_H 1
[  109s] | #define HAVE_INTTYPES_H 1
[  109s] | #define HAVE_STDINT_H 1
[  109s] | #define HAVE_UNISTD_H 1
[  109s] | #define HAVE_DLFCN_H 1
[  109s] | #define LT_OBJDIR ".libs/"
[  109s] | #define STDC_HEADERS 1
[  109s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  109s] | 
[  109s] | configure: exit 0
[  109s] 
[  109s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  109s] make[1]: *** [override_dh_auto_test] Error 1
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  109s] debian/rules:45: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] lamb54 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:25:37 UTC 
2019.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  113s] [  101.230205] sysrq: SysRq : Power Off
[  113s] [  101.237442] reboot: Power down
[  113s] ### VM INTERACTION END ###
[  113s] 
[  113s] lamb54 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:25:41 UTC 
2019.
[  113s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_17.04/i586

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  118s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  118s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  118s]   ^
[  118s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  118s] make[4]: *** [gsm_04_80.o] Error 1
[  118s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  118s] Makefile:421: recipe for target 'all-recursive' failed
[  118s] make[3]: *** [all-recursive] Error 1
[  118s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  118s] Makefile:457: recipe for target 'all-recursive' failed
[  118s] make[2]: *** [all-recursive] Error 1
[  118s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  118s] Makefile:389: recipe for target 'all' failed
[  118s] make[1]: *** [all] Error 2
[  118s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  118s] dh_auto_build: make -j1 returned exit code 2
[  118s] debian/rules:45: recipe for target 'build' failed
[  118s] make: *** [build] Error 2
[  118s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  118s] 
[  118s] cloud128 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:30 UTC 
2019.
[  118s] 
[  118s] ### VM INTERACTION START ###
[  121s] [  100.463173] sysrq: SysRq : Power Off
[  121s] [  100.478519] reboot: Power down
[  123s] ### VM INTERACTION END ###
[  123s] 
[  123s] cloud128 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:36 UTC 
2019.
[  123s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/x86_64

Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  117s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  117s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  117s]   ^
[  117s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  117s] make[4]: *** [gsm_04_80.o] Error 1
[  117s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  117s] Makefile:421: recipe for target 'all-recursive' failed
[  117s] make[3]: *** [all-recursive] Error 1
[  117s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  117s] Makefile:457: recipe for target 'all-recursive' failed
[  117s] make[2]: *** [all-recursive] Error 1
[  117s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  117s] Makefile:389: recipe for target 'all' failed
[  117s] make[1]: *** [all] Error 2
[  117s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  117s] dh_auto_build: make -j1 returned exit code 2
[  117s] debian/rules:45: recipe for target 'build' failed
[  117s] make: *** [build] Error 2
[  117s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  117s] 
[  117s] cloud111 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:52 UTC 
2019.
[  117s] 
[  117s] ### VM INTERACTION START ###
[  120s] [   93.861199] sysrq: SysRq : Power Off
[  120s] [   93.866178] reboot: Power down
[  121s] ### VM INTERACTION END ###
[  121s] 
[  121s] cloud111 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:24:57 UTC 
2019.
[  121s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_9.0/i586

Package network:osmocom:latest/osmo-msc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   88s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   88s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   88s]   ^
[   88s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   88s] make[4]: *** [gsm_04_80.o] Error 1
[   88s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   88s] Makefile:421: recipe for target 'all-recursive' failed
[   88s] make[3]: *** [all-recursive] Error 1
[   88s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   88s] Makefile:457: recipe for target 'all-recursive' failed
[   88s] make[2]: *** [all-recursive] Error 1
[   88s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   88s] Makefile:389: recipe for target 'all' failed
[   88s] make[1]: *** [all] Error 2
[   88s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   88s] dh_auto_build: make -j1 returned exit code 2
[   88s] debian/rules:45: recipe for target 'build' failed
[   88s] make: *** [build] Error 2
[   88s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   88s] 
[   88s] lamb52 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:25:13 UTC 
2019.
[   88s] 
[   88s] ### VM INTERACTION START ###
[   91s] [   79.411279] sysrq: SysRq : Power Off
[   91s] [   79.418921] reboot: Power down
[   91s] ### VM INTERACTION END ###
[   91s] 
[   91s] lamb52 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:25:17 UTC 
2019.
[   91s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_16.10/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[   61s] | #define HAVE_STRING_H 1
[   61s] | #define HAVE_MEMORY_H 1
[   61s] | #define HAVE_STRINGS_H 1
[   61s] | #define HAVE_INTTYPES_H 1
[   61s] | #define HAVE_STDINT_H 1
[   61s] | #define HAVE_UNISTD_H 1
[   61s] | #define HAVE_DLFCN_H 1
[   61s] | #define LT_OBJDIR ".libs/"
[   61s] | #define STDC_HEADERS 1
[   61s] | #define HAVE_TM_GMTOFF_IN_TM 1
[   61s] | 
[   61s] | configure: exit 0
[   61s] 
[   61s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[   61s] make[1]: *** [override_dh_auto_test] Error 1
[   61s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   61s] debian/rules:45: recipe for target 'build' failed
[   61s] make: *** [build] Error 2
[   61s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   61s] 
[   61s] build72 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:23:42 UTC 
2019.
[   61s] 
[   61s] ### VM INTERACTION START ###
[   64s] [   56.164750] sysrq: SysRq : Power Off
[   64s] [   56.166492] reboot: Power down
[   65s] ### VM INTERACTION END ###
[   65s] 
[   65s] build72 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:23:46 UTC 
2019.
[   65s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_9.0/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  103s]  06 
[  103s]  
[  103s] -==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  103s] -
[  103s]  MESSAGE to BSS at 0x01020304:, msg length 1
[  103s]  07 
[  103s]  
[  103s] +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  103s] +
[  103s]  result (UNBLOCK) = 1
[  103s]  
[  103s]  PROCESSING ALIVE_ACK from 0x01020304:
[  103s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  103s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  103s] make[1]: *** [override_dh_auto_test] Error 1
[  103s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  103s] debian/rules:45: recipe for target 'build' failed
[  103s] make: *** [build] Error 2
[  103s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  103s] 
[  103s] lamb15 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:24:28 UTC 
2019.
[  103s] 
[  103s] ### VM INTERACTION START ###
[  106s] [   94.401949] sysrq: SysRq : Power Off
[  106s] [   94.409476] reboot: Power down
[  106s] ### VM INTERACTION END ###
[  106s] 
[  106s] lamb15 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:24:32 UTC 
2019.
[  106s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_16.10/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   68s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   68s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   68s]   ^
[   68s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   68s] make[4]: *** [gsm_04_80.o] Error 1
[   68s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   68s] Makefile:421: recipe for target 'all-recursive' failed
[   68s] make[3]: *** [all-recursive] Error 1
[   68s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   68s] Makefile:457: recipe for target 'all-recursive' failed
[   68s] make[2]: *** [all-recursive] Error 1
[   68s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   68s] Makefile:389: recipe for target 'all' failed
[   68s] make[1]: *** [all] Error 2
[   68s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   68s] dh_auto_build: make -j1 returned exit code 2
[   68s] debian/rules:45: recipe for target 'build' failed
[   68s] make: *** [build] Error 2
[   68s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   68s] 
[   68s] sheep83 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:23:44 UTC 
2019.
[   68s] 
[   68s] ### VM INTERACTION START ###
[   71s] [   64.244752] sysrq: SysRq : Power Off
[   71s] [   64.250675] reboot: Power down
[   71s] ### VM INTERACTION END ###
[   71s] 
[   71s] sheep83 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:23:48 UTC 
2019.
[   71s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_16.04/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  192s] | #define HAVE_STRING_H 1
[  192s] | #define HAVE_MEMORY_H 1
[  192s] | #define HAVE_STRINGS_H 1
[  192s] | #define HAVE_INTTYPES_H 1
[  192s] | #define HAVE_STDINT_H 1
[  192s] | #define HAVE_UNISTD_H 1
[  192s] | #define HAVE_DLFCN_H 1
[  192s] | #define LT_OBJDIR ".libs/"
[  192s] | #define STDC_HEADERS 1
[  192s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  192s] | 
[  192s] | configure: exit 0
[  192s] 
[  192s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  192s] make[1]: *** [override_dh_auto_test] Error 1
[  192s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  192s] debian/rules:45: recipe for target 'build' failed
[  192s] make: *** [build] Error 2
[  192s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  192s] 
[  192s] build35 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:23:05 UTC 
2019.
[  192s] 
[  192s] ### VM INTERACTION START ###
[  196s] [  171.477358] sysrq: SysRq : Power Off
[  196s] [  171.479845] reboot: Power down
[  196s] ### VM INTERACTION END ###
[  196s] 
[  196s] build35 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:23:10 UTC 
2019.
[  196s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_16.04/i586

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  109s] | #define HAVE_STRING_H 1
[  109s] | #define HAVE_MEMORY_H 1
[  109s] | #define HAVE_STRINGS_H 1
[  109s] | #define HAVE_INTTYPES_H 1
[  109s] | #define HAVE_STDINT_H 1
[  109s] | #define HAVE_UNISTD_H 1
[  109s] | #define HAVE_DLFCN_H 1
[  109s] | #define LT_OBJDIR ".libs/"
[  109s] | #define STDC_HEADERS 1
[  109s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  109s] | 
[  109s] | configure: exit 0
[  109s] 
[  109s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  109s] make[1]: *** [override_dh_auto_test] Error 1
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  109s] debian/rules:45: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] lamb54 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:22:53 UTC 
2019.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  112s] [  102.632723] sysrq: SysRq : Power Off
[  112s] [  102.639892] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] lamb54 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:22:57 UTC 
2019.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/xUbuntu_16.10/i586

Package network:osmocom:latest/osmo-sgsn failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  110s] | #define HAVE_STRING_H 1
[  110s] | #define HAVE_MEMORY_H 1
[  110s] | #define HAVE_STRINGS_H 1
[  110s] | #define HAVE_INTTYPES_H 1
[  110s] | #define HAVE_STDINT_H 1
[  110s] | #define HAVE_UNISTD_H 1
[  110s] | #define HAVE_DLFCN_H 1
[  110s] | #define LT_OBJDIR ".libs/"
[  110s] | #define STDC_HEADERS 1
[  110s] | #define HAVE_TM_GMTOFF_IN_TM 1
[  110s] | 
[  110s] | configure: exit 0
[  110s] 
[  110s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  110s] make[1]: *** [override_dh_auto_test] Error 1
[  110s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  110s] debian/rules:45: recipe for target 'build' failed
[  110s] make: *** [build] Error 2
[  110s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  110s] 
[  110s] lamb03 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:22:54 UTC 
2019.
[  110s] 
[  110s] ### VM INTERACTION START ###
[  113s] [  103.219243] sysrq: SysRq : Power Off
[  113s] [  103.227298] reboot: Power down
[  113s] ### VM INTERACTION END ###
[  113s] 
[  113s] lamb03 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:22:58 UTC 
2019.
[  113s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_16.04/i586

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   74s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   74s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   74s]   ^
[   74s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   74s] make[4]: *** [gsm_04_80.o] Error 1
[   74s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   74s] Makefile:421: recipe for target 'all-recursive' failed
[   74s] make[3]: *** [all-recursive] Error 1
[   74s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   74s] Makefile:457: recipe for target 'all-recursive' failed
[   74s] make[2]: *** [all-recursive] Error 1
[   74s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   74s] Makefile:389: recipe for target 'all' failed
[   74s] make[1]: *** [all] Error 2
[   74s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   74s] dh_auto_build: make -j1 returned exit code 2
[   74s] debian/rules:45: recipe for target 'build' failed
[   74s] make: *** [build] Error 2
[   74s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   74s] 
[   74s] sheep83 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:22:16 UTC 
2019.
[   74s] 
[   74s] ### VM INTERACTION START ###
[   77s] [   70.843937] sysrq: SysRq : Power Off
[   77s] [   70.850038] reboot: Power down
[   77s] ### VM INTERACTION END ###
[   77s] 
[   77s] sheep83 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:22:19 UTC 
2019.
[   77s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_16.10/i586

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   91s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   91s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   91s]   ^
[   91s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[   91s] make[4]: *** [gsm_04_80.o] Error 1
[   91s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   91s] Makefile:421: recipe for target 'all-recursive' failed
[   91s] make[3]: *** [all-recursive] Error 1
[   91s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   91s] Makefile:457: recipe for target 'all-recursive' failed
[   91s] make[2]: *** [all-recursive] Error 1
[   91s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   91s] Makefile:389: recipe for target 'all' failed
[   91s] make[1]: *** [all] Error 2
[   91s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   91s] dh_auto_build: make -j1 returned exit code 2
[   91s] debian/rules:45: recipe for target 'build' failed
[   91s] make: *** [build] Error 2
[   91s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   91s] 
[   91s] lamb14 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:22:36 UTC 
2019.
[   91s] 
[   91s] ### VM INTERACTION START ###
[   94s] [   83.448948] sysrq: SysRq : Power Off
[   94s] [   83.457073] reboot: Power down
[   94s] ### VM INTERACTION END ###
[   94s] 
[   94s] lamb14 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:22:39 UTC 
2019.
[   94s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/xUbuntu_16.04/x86_64

Package network:osmocom:latest/osmo-msc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[  115s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  115s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  115s]   ^
[  115s] Makefile:504: recipe for target 'gsm_04_80.o' failed
[  115s] make[4]: *** [gsm_04_80.o] Error 1
[  115s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[  115s] Makefile:421: recipe for target 'all-recursive' failed
[  115s] make[3]: *** [all-recursive] Error 1
[  115s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[  115s] Makefile:457: recipe for target 'all-recursive' failed
[  115s] make[2]: *** [all-recursive] Error 1
[  115s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[  115s] Makefile:389: recipe for target 'all' failed
[  115s] make[1]: *** [all] Error 2
[  115s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  115s] dh_auto_build: make -j1 returned exit code 2
[  115s] debian/rules:45: recipe for target 'build' failed
[  115s] make: *** [build] Error 2
[  115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  115s] 
[  115s] cloud120 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:21:08 UTC 
2019.
[  115s] 
[  115s] ### VM INTERACTION START ###
[  118s] [   96.592491] sysrq: SysRq : Power Off
[  118s] [   96.606589] reboot: Power down
[  119s] ### VM INTERACTION END ###
[  119s] 
[  119s] cloud120 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:21:12 UTC 
2019.
[  119s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_8.0/i586

Package network:osmocom:latest/osmo-msc failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   87s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   87s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   87s]   ^
[   87s] Makefile:492: recipe for target 'gsm_04_80.o' failed
[   87s] make[4]: *** [gsm_04_80.o] Error 1
[   87s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   87s] Makefile:409: recipe for target 'all-recursive' failed
[   87s] make[3]: *** [all-recursive] Error 1
[   87s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   87s] Makefile:445: recipe for target 'all-recursive' failed
[   87s] make[2]: *** [all-recursive] Error 1
[   87s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   87s] Makefile:376: recipe for target 'all' failed
[   87s] make[1]: *** [all] Error 2
[   87s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   87s] dh_auto_build: make -j1 returned exit code 2
[   87s] debian/rules:45: recipe for target 'build' failed
[   87s] make: *** [build] Error 2
[   87s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   87s] 
[   87s] lamb54 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:20:29 UTC 
2019.
[   87s] 
[   87s] ### VM INTERACTION START ###
[   88s] Powering off.
[   88s] [   77.490057] reboot: Power down
[   88s] ### VM INTERACTION END ###
[   88s] 
[   88s] lamb54 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:20:31 UTC 
2019.
[   88s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/armv7l

Package network:osmocom:latest/openbsc failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  223s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  223s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  223s]   ^
[  223s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  223s] make[4]: *** [gsm_04_80.o] Error 1
[  223s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  223s] Makefile:447: recipe for target 'all-recursive' failed
[  223s] make[3]: *** [all-recursive] Error 1
[  223s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  223s] Makefile:518: recipe for target 'all-recursive' failed
[  223s] make[2]: *** [all-recursive] Error 1
[  223s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  223s] Makefile:427: recipe for target 'all' failed
[  223s] make[1]: *** [all] Error 2
[  223s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  223s] dh_auto_build: make -j1 returned exit code 2
[  223s] debian/rules:13: recipe for target 'build' failed
[  223s] make: *** [build] Error 2
[  223s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  223s] 
[  223s] armbuild14 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:19:56 UTC 
2019.
[  223s] 
[  223s] ### VM INTERACTION START ###
[  226s] [  192.552406] sysrq: SysRq : Power Off
[  226s] [  192.554160] reboot: Power down
[  226s] ### VM INTERACTION END ###
[  226s] 
[  226s] armbuild14 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:19:59 UTC 
2019.
[  226s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_8.0/i586

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[   61s] | #define HAVE_STRING_H 1
[   61s] | #define HAVE_MEMORY_H 1
[   61s] | #define HAVE_STRINGS_H 1
[   61s] | #define HAVE_INTTYPES_H 1
[   61s] | #define HAVE_STDINT_H 1
[   61s] | #define HAVE_UNISTD_H 1
[   61s] | #define HAVE_DLFCN_H 1
[   61s] | #define LT_OBJDIR ".libs/"
[   61s] | #define STDC_HEADERS 1
[   61s] | #define HAVE_TM_GMTOFF_IN_TM 1
[   61s] | 
[   61s] | configure: exit 0
[   61s] 
[   61s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[   61s] make[1]: *** [override_dh_auto_test] Error 1
[   61s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   61s] debian/rules:45: recipe for target 'build' failed
[   61s] make: *** [build] Error 2
[   61s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   61s] 
[   61s] build81 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:20:06 UTC 
2019.
[   61s] 
[   61s] ### VM INTERACTION START ###
[   63s] Powering off.
[   63s] [   54.450993] reboot: Power down
[   63s] ### VM INTERACTION END ###
[   63s] 
[   63s] build81 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:20:08 UTC 
2019.
[   63s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-sgsn in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_8.0/x86_64

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  133s]  06 
[  133s]  
[  133s] -==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  133s] -
[  133s]  MESSAGE to BSS at 0x01020304:, msg length 1
[  133s]  07 
[  133s]  
[  133s] +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  133s] +
[  133s]  result (UNBLOCK) = 1
[  133s]  
[  133s]  PROCESSING ALIVE_ACK from 0x01020304:
[  133s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  133s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  133s] make[1]: *** [override_dh_auto_test] Error 1
[  133s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  133s] debian/rules:45: recipe for target 'build' failed
[  133s] make: *** [build] Error 2
[  133s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  133s] 
[  133s] cloud128 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:19:18 UTC 
2019.
[  133s] 
[  133s] ### VM INTERACTION START ###
[  134s] Powering off.
[  134s] [  111.338367] reboot: Power down
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] cloud128 failed "build osmo-sgsn_1.3.0.dsc" at Mon Jan 21 01:19:21 UTC 
2019.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-msc in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_8.0/x86_64

Package network:osmocom:latest/osmo-msc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-msc

Last lines of build log:
[   86s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[   86s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[   86s]   ^
[   86s] Makefile:492: recipe for target 'gsm_04_80.o' failed
[   86s] make[4]: *** [gsm_04_80.o] Error 1
[   86s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc'
[   86s] Makefile:409: recipe for target 'all-recursive' failed
[   86s] make[3]: *** [all-recursive] Error 1
[   86s] make[3]: Leaving directory '/usr/src/packages/BUILD/src'
[   86s] Makefile:445: recipe for target 'all-recursive' failed
[   86s] make[2]: *** [all-recursive] Error 1
[   86s] make[2]: Leaving directory '/usr/src/packages/BUILD'
[   86s] Makefile:376: recipe for target 'all' failed
[   86s] make[1]: *** [all] Error 2
[   86s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   86s] dh_auto_build: make -j1 returned exit code 2
[   86s] debian/rules:45: recipe for target 'build' failed
[   86s] make: *** [build] Error 2
[   86s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   86s] 
[   86s] lamb51 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:18:23 UTC 
2019.
[   86s] 
[   86s] ### VM INTERACTION START ###
[   87s] Powering off.
[   87s] [   76.569923] reboot: Power down
[   87s] ### VM INTERACTION END ###
[   87s] 
[   87s] lamb51 failed "build osmo-msc_1.2.0.dsc" at Mon Jan 21 01:18:24 UTC 
2019.
[   87s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/aarch64

Package network:osmocom:latest/openbsc failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  223s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  223s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  223s]   ^
[  223s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  223s] make[4]: *** [gsm_04_80.o] Error 1
[  223s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  223s] Makefile:447: recipe for target 'all-recursive' failed
[  223s] make[3]: *** [all-recursive] Error 1
[  223s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  223s] Makefile:518: recipe for target 'all-recursive' failed
[  223s] make[2]: *** [all-recursive] Error 1
[  223s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  223s] Makefile:427: recipe for target 'all' failed
[  223s] make[1]: *** [all] Error 2
[  223s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  223s] dh_auto_build: make -j1 returned exit code 2
[  223s] debian/rules:13: recipe for target 'build' failed
[  223s] make: *** [build] Error 2
[  223s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  223s] 
[  223s] obs-arm-3 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:18:24 UTC 
2019.
[  223s] 
[  223s] ### VM INTERACTION START ###
[  226s] [  203.049309] sysrq: SysRq : Power Off
[  226s] [  203.053631] reboot: Power down
[  226s] ### VM INTERACTION END ###
[  226s] 
[  226s] obs-arm-3 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:18:28 UTC 
2019.
[  226s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_17.10/x86_64

Package network:osmocom:latest/openbsc failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  138s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  138s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  138s]   ^
[  138s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  138s] make[4]: *** [gsm_04_80.o] Error 1
[  138s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  138s] Makefile:447: recipe for target 'all-recursive' failed
[  138s] make[3]: *** [all-recursive] Error 1
[  138s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  138s] Makefile:518: recipe for target 'all-recursive' failed
[  138s] make[2]: *** [all-recursive] Error 1
[  138s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  138s] Makefile:427: recipe for target 'all' failed
[  138s] make[1]: *** [all] Error 2
[  138s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  138s] dh_auto_build: make -j1 returned exit code 2
[  138s] debian/rules:13: recipe for target 'build' failed
[  138s] make: *** [build] Error 2
[  138s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  138s] 
[  138s] cloud128 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:41 UTC 
2019.
[  138s] 
[  138s] ### VM INTERACTION START ###
[  141s] [  120.997056] sysrq: SysRq : Power Off
[  141s] [  121.010285] reboot: Power down
[  143s] ### VM INTERACTION END ###
[  143s] 
[  143s] cloud128 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:47 UTC 
2019.
[  143s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/i586

Package network:osmocom:latest/openbsc failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  107s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  107s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  107s]   ^
[  107s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  107s] make[4]: *** [gsm_04_80.o] Error 1
[  107s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  107s] Makefile:447: recipe for target 'all-recursive' failed
[  107s] make[3]: *** [all-recursive] Error 1
[  107s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  107s] Makefile:518: recipe for target 'all-recursive' failed
[  107s] make[2]: *** [all-recursive] Error 1
[  107s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  107s] Makefile:427: recipe for target 'all' failed
[  107s] make[1]: *** [all] Error 2
[  107s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  107s] dh_auto_build: make -j1 returned exit code 2
[  107s] debian/rules:13: recipe for target 'build' failed
[  107s] make: *** [build] Error 2
[  107s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  107s] 
[  107s] lamb51 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:12 UTC 
2019.
[  107s] 
[  107s] ### VM INTERACTION START ###
[  110s] [   98.888362] sysrq: SysRq : Power Off
[  110s] [   98.896264] reboot: Power down
[  110s] ### VM INTERACTION END ###
[  110s] 
[  110s] lamb51 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:15 UTC 
2019.
[  110s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_9.0/x86_64

Package network:osmocom:latest/openbsc failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  134s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  134s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  134s]   ^
[  134s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  134s] make[4]: *** [gsm_04_80.o] Error 1
[  134s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  134s] Makefile:447: recipe for target 'all-recursive' failed
[  134s] make[3]: *** [all-recursive] Error 1
[  134s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  134s] Makefile:518: recipe for target 'all-recursive' failed
[  134s] make[2]: *** [all-recursive] Error 1
[  134s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  134s] Makefile:427: recipe for target 'all' failed
[  134s] make[1]: *** [all] Error 2
[  134s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  134s] dh_auto_build: make -j1 returned exit code 2
[  134s] debian/rules:13: recipe for target 'build' failed
[  134s] make: *** [build] Error 2
[  134s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  134s] 
[  134s] cloud118 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:15:06 UTC 
2019.
[  134s] 
[  134s] ### VM INTERACTION START ###
[  137s] [  114.572670] sysrq: SysRq : Power Off
[  137s] [  114.577157] reboot: Power down
[  138s] ### VM INTERACTION END ###
[  138s] 
[  138s] cloud118 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:15:11 UTC 
2019.
[  138s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_17.04/i586

Package network:osmocom:latest/openbsc failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  127s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  127s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  127s]   ^
[  127s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  127s] make[4]: *** [gsm_04_80.o] Error 1
[  127s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  127s] Makefile:447: recipe for target 'all-recursive' failed
[  127s] make[3]: *** [all-recursive] Error 1
[  127s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  127s] Makefile:518: recipe for target 'all-recursive' failed
[  127s] make[2]: *** [all-recursive] Error 1
[  127s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  127s] Makefile:427: recipe for target 'all' failed
[  127s] make[1]: *** [all] Error 2
[  127s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  127s] dh_auto_build: make -j1 returned exit code 2
[  127s] debian/rules:13: recipe for target 'build' failed
[  127s] make: *** [build] Error 2
[  127s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  127s] 
[  127s] build30 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:33 UTC 
2019.
[  127s] 
[  127s] ### VM INTERACTION START ###
[  130s] [  112.275384] sysrq: SysRq : Power Off
[  130s] [  112.278695] reboot: Power down
[  131s] ### VM INTERACTION END ###
[  131s] 
[  131s] build30 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:38 UTC 
2019.
[  131s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_17.04/x86_64

Package network:osmocom:latest/openbsc failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  114s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  114s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  114s]   ^
[  114s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  114s] make[4]: *** [gsm_04_80.o] Error 1
[  114s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  114s] Makefile:447: recipe for target 'all-recursive' failed
[  114s] make[3]: *** [all-recursive] Error 1
[  114s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  114s] Makefile:518: recipe for target 'all-recursive' failed
[  114s] make[2]: *** [all-recursive] Error 1
[  114s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  114s] Makefile:427: recipe for target 'all' failed
[  114s] make[1]: *** [all] Error 2
[  114s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  114s] dh_auto_build: make -j1 returned exit code 2
[  114s] debian/rules:13: recipe for target 'build' failed
[  114s] make: *** [build] Error 2
[  115s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  115s] 
[  115s] build32 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:33 UTC 
2019.
[  115s] 
[  115s] ### VM INTERACTION START ###
[  118s] [  105.041393] sysrq: SysRq : Power Off
[  118s] [  105.044548] reboot: Power down
[  118s] ### VM INTERACTION END ###
[  118s] 
[  118s] build32 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:37 UTC 
2019.
[  118s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_16.10/x86_64

Package network:osmocom:latest/openbsc failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  145s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  145s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  145s]   ^
[  145s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  145s] make[4]: *** [gsm_04_80.o] Error 1
[  145s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  145s] Makefile:447: recipe for target 'all-recursive' failed
[  145s] make[3]: *** [all-recursive] Error 1
[  145s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  145s] Makefile:518: recipe for target 'all-recursive' failed
[  145s] make[2]: *** [all-recursive] Error 1
[  145s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  145s] Makefile:427: recipe for target 'all' failed
[  145s] make[1]: *** [all] Error 2
[  145s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  145s] dh_auto_build: make -j1 returned exit code 2
[  145s] debian/rules:13: recipe for target 'build' failed
[  145s] make: *** [build] Error 2
[  145s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  145s] 
[  145s] cloud112 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:00 UTC 
2019.
[  145s] 
[  145s] ### VM INTERACTION START ###
[  148s] [  124.580786] sysrq: SysRq : Power Off
[  148s] [  124.591069] reboot: Power down
[  150s] ### VM INTERACTION END ###
[  150s] 
[  150s] cloud112 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:14:05 UTC 
2019.
[  150s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_16.04/x86_64

Package network:osmocom:latest/openbsc failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  109s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  109s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  109s]   ^
[  109s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  109s] make[4]: *** [gsm_04_80.o] Error 1
[  109s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  109s] Makefile:447: recipe for target 'all-recursive' failed
[  109s] make[3]: *** [all-recursive] Error 1
[  109s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  109s] Makefile:518: recipe for target 'all-recursive' failed
[  109s] make[2]: *** [all-recursive] Error 1
[  109s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  109s] Makefile:427: recipe for target 'all' failed
[  109s] make[1]: *** [all] Error 2
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  109s] dh_auto_build: make -j1 returned exit code 2
[  109s] debian/rules:13: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] lamb14 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:47 UTC 
2019.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  112s] [  102.412689] sysrq: SysRq : Power Off
[  112s] [  102.420844] reboot: Power down
[  112s] ### VM INTERACTION END ###
[  112s] 
[  112s] lamb14 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:50 UTC 
2019.
[  112s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_8.0/x86_64

Package network:osmocom:latest/openbsc failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  104s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  104s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  104s]   ^
[  104s] Makefile:472: recipe for target 'gsm_04_80.o' failed
[  104s] make[4]: *** [gsm_04_80.o] Error 1
[  104s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  104s] Makefile:435: recipe for target 'all-recursive' failed
[  104s] make[3]: *** [all-recursive] Error 1
[  104s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  104s] Makefile:507: recipe for target 'all-recursive' failed
[  104s] make[2]: *** [all-recursive] Error 1
[  104s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  104s] Makefile:415: recipe for target 'all' failed
[  104s] make[1]: *** [all] Error 2
[  104s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  104s] dh_auto_build: make -j1 returned exit code 2
[  104s] debian/rules:13: recipe for target 'build' failed
[  104s] make: *** [build] Error 2
[  104s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  104s] 
[  104s] lamb04 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:54 UTC 
2019.
[  104s] 
[  104s] ### VM INTERACTION START ###
[  105s] Powering off.
[  105s] [   94.298430] reboot: Power down
[  105s] ### VM INTERACTION END ###
[  105s] 
[  105s] lamb04 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:56 UTC 
2019.
[  105s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/openbsc in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/xUbuntu_16.10/i586

Package network:osmocom:latest/openbsc failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:latest openbsc

Last lines of build log:
[  111s] /usr/include/osmocom/core/msgb.h:371:30: note: previous definition of 
'msgb_wrap_with_TL' was here
[  111s]  static inline unsigned char *msgb_wrap_with_TL(struct msgb *msgb, 
uint8_t tag)
[  111s]   ^
[  111s] Makefile:484: recipe for target 'gsm_04_80.o' failed
[  111s] make[4]: *** [gsm_04_80.o] Error 1
[  111s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/libmsc'
[  111s] Makefile:447: recipe for target 'all-recursive' failed
[  111s] make[3]: *** [all-recursive] Error 1
[  111s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src'
[  111s] Makefile:518: recipe for target 'all-recursive' failed
[  111s] make[2]: *** [all-recursive] Error 1
[  111s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  111s] Makefile:427: recipe for target 'all' failed
[  111s] make[1]: *** [all] Error 2
[  111s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc'
[  111s] dh_auto_build: make -j1 returned exit code 2
[  111s] debian/rules:13: recipe for target 'build' failed
[  111s] make: *** [build] Error 2
[  111s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  111s] 
[  111s] lamb24 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:47 UTC 
2019.
[  111s] 
[  111s] ### VM INTERACTION START ###
[  114s] [  103.716586] sysrq: SysRq : Power Off
[  114s] [  103.724402] reboot: Power down
[  114s] ### VM INTERACTION END ###
[  114s] 
[  114s] lamb24 failed "build openbsc_1.1.0.dsc" at Mon Jan 21 01:12:50 UTC 
2019.
[  114s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-trx in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_9.0/armv7l

Package network:osmocom:latest/osmo-trx failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-trx

Last lines of build log:
[  231s] #define HAVE_MEMORY_H 1
[  231s] #define HAVE_STRINGS_H 1
[  231s] #define HAVE_INTTYPES_H 1
[  231s] #define HAVE_STDINT_H 1
[  231s] #define HAVE_UNISTD_H 1
[  231s] #define HAVE_DLFCN_H 1
[  231s] #define LT_OBJDIR ".libs/"
[  231s] #define STDC_HEADERS 1
[  231s] #define HAVE_BYTESWAP_H 1
[  231s] #define TIME_WITH_SYS_TIME 1
[  231s] 
[  231s] configure: exit 1
[  231s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf 
--prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man 
--infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=${prefix}/lib/arm-linux-gnueabihf 
--libexecdir=${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode 
--disable-dependency-tracking --with-uhd --with-usrp1 --with-lms 
--with-systemdsystemunitdir=/lib/systemd/system returned exit code 1
[  231s] debian/rules:12: recipe for target 'override_dh_auto_configure' failed
[  231s] make[1]: *** [override_dh_auto_configure] Error 2
[  231s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  231s] debian/rules:6: recipe for target 'build' failed
[  231s] make: *** [build] Error 2
[  231s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  231s] 
[  231s] armbuild13 failed "build osmo-trx_1.0.0.dsc" at Mon Jan 21 01:08:54 
UTC 2019.
[  231s] 
[  231s] ### VM INTERACTION START ###
[  233s] [  195.623631] SysRq : Power Off
[  233s] [  195.625146] reboot: Power down
[  233s] ### VM INTERACTION END ###
[  233s] 
[  233s] armbuild13 failed "build osmo-trx_1.0.0.dsc" at Mon Jan 21 01:08:58 
UTC 2019.
[  233s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:latest/osmo-trx in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_9.0/aarch64

Package network:osmocom:latest/osmo-trx failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-trx

Last lines of build log:
[  240s] configure:10923: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5
[  240s] configure:10923: $? = 0
[  240s] configure:10923: result: yes
[  240s] configure:10923: checking for inttypes.h
[  240s] configure:10923: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5
[  240s] configure:10923: $? = 0
[  240s] configure:10923: result: yes
[  240s] configure:10923: checking for stdint.h
[  240s] configure:10923: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5
[  240s] configure:10923: $? = 0
[  240s] configure:10923: result: yes
[  240s] configure:10923: checking for unistd.h
[  240s] configure:10923: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5
[  240s] configure:10923: $? = 0
[  240s] configure:10923: result: yes
[  240s] configure:10937: checking for dlfcn.h
[  240s] configure:10937: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5
[  240s] configure:10937: $? = 0
[  240s] configure:10937: result: yes
[  240s] configure:11141: checking for objdir
[  240s] configure:11156: result: .libs
[  240s] configure:11420: checking if gcc supports -fno-rtti -fno-exceptions
[  240s] configure:11438: gcc -c -g -O2 
-fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fno-rtti 
-fno-exceptions conftest.c >&5
[  242s] cc1: warning: command line option '-fno-rtti'[  217.676215] sysrq: 
SysRq : Power Off
[  242s] [  217.680558] reboot: Power down
[  242s] ### VM INTERACTION END ###
[  242s] 
[  242s] obs-arm-3 failed "build osmo-trx_1.0.0.dsc" at Mon Jan 21 01:09:02 UTC 
2019.
[  242s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmo-iuh[master]: Bump version: 0.3.0.10-9e66-dirty → 0.4.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12660


Change subject: Bump version: 0.3.0.10-9e66-dirty → 0.4.0
..

Bump version: 0.3.0.10-9e66-dirty → 0.4.0

Change-Id: Ib2943b7fd0a1f7ca79f761116cba30aa3aa29b88
---
M debian/changelog
M src/Makefile.am
2 files changed, 32 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/60/12660/1

diff --git a/debian/changelog b/debian/changelog
index 1ec6437..26f7525 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,34 @@
+osmo-iuh (0.4.0) unstable; urgency=medium
+
+  [ Bernhard M. Wiedemann ]
+  * asn1tostruct: allow to override build date
+
+  [ Alexander Couzens ]
+  * hnbgw: remove close_cb() to fix a crash when releasing a hnbgw
+
+  [ Harald Welte ]
+  * debian/rules: Don't overwrite .tarball-version
+  * hnbgw_tx_hnb_register_rej(): Missing return statement
+
+  [ Neels Hofmeyr ]
+  * fix decoding of incoming X.213 NSAP addr
+  * hnbgw: vty: add SCCP related vty commands
+  * fix transport layer addr again, for nano3g
+
+  [ Pau Espin Pedrol ]
+  * debian: package osmo-hnbgw.service
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+
+  [ Stefan Sperling ]
+  * add a VTY command which shows a specific HNB
+
+  [ Oliver Smith ]
+  * Fix DISTCHECK_CONFIGURE_FLAGS override
+  * contrib: fix makedistcheck with disabled systemd
+
+ -- Harald Welte   Sun, 20 Jan 2019 21:46:05 +0100
+
 osmo-iuh (0.3.0) unstable; urgency=medium

   [ Neels Hofmeyr ]
diff --git a/src/Makefile.am b/src/Makefile.am
index 7802384..586c689 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -48,7 +48,7 @@

 # build the shared RANAP library
 #
-RANAP_LIBVERSION=2:0:0
+RANAP_LIBVERSION=2:1:0
 lib_LTLIBRARIES = libosmo-ranap.la
 libosmo_ranap_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RANAP_LIBVERSION)
 libosmo_ranap_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOVTY_LIBS) 
$(OSMOSIGTRAN_LIBS) \

--
To view, visit https://gerrit.osmocom.org/12660
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2943b7fd0a1f7ca79f761116cba30aa3aa29b88
Gerrit-Change-Number: 12660
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-msc[master]: Add SGs Interface

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11642 )

Change subject: Add SGs Interface
..


Patch Set 30:

(1 comment)

vty_dump_one_conn() in msc_vty.c:

https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c@564
PS30, Line 564: conn->via_ran == OSMO_RAT_UTRAN_IU ? "Iu" : "A",
here maybe rather use osmo_rat_type_name(), otherwise all SGs conns are shown 
as "A".



--
To view, visit https://gerrit.osmocom.org/11642
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d
Gerrit-Change-Number: 11642
Gerrit-PatchSet: 30
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-CC: Stefan Sperling 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 20 Jan 2019 22:58:39 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmo-bsc[master]: LCLS: constify helper parameters

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12485 )

Change subject: LCLS: constify helper parameters
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12485
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341f4ea172432b94e8e96919926a5fb6870c2a30
Gerrit-Change-Number: 12485
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: daniel 
Gerrit-Comment-Date: Sun, 20 Jan 2019 22:40:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Hello Max, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/11504

to look at the new patch set (#9).

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..

gsm0808: add BSSMAP Cell Identifier matching API

Add
* osmo_lai_cmp() (to use in gsm0808_cell_id_u_matches())
* osmo_cgi_cmp() (to use in gsm0808_cell_id_u_matches())
* gsm0808_cell_id_u_match() (to re-use for single IDs and lists)
* gsm0808_cell_ids_match()
* gsm0808_cell_id_matches_list()
* Unit tests in gsm0808_test.c

Rationale:

For inter-BSC handover, it is interesting to find matches between *differing*
Cell Identity kinds. For example, if a cell as CGI 23-42-3-5, and a HO for
LAC-CI 3-5 should be handled, we need to see the match.

This is most interesting for osmo-msc, i.e. to direct the BSSMAP Handover
Request towards the correct BSC or MSC.

It is also interesting for osmo-bsc's VTY interface, to be able to manage
cells' neighbors and to trigger manual handovers by various Cell Identity
handles, as the user would expect them.

Change-Id: I5535f0d149c2173294538df75764dd181b023312
---
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M src/gsm/gsm0808_utils.c
M src/gsm/gsm23003.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
M tests/gsm0808/gsm0808_test.ok
7 files changed, 648 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/11504/9
--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 

Change in libosmocore[master]: gsm0808: add BSSMAP Cell Identifier matching API

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11504 )

Change subject: gsm0808: add BSSMAP Cell Identifier matching API
..


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/11504/7/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/11504/7/src/gsm/gsm0808_utils.c@1450
PS7, Line 1450: {
> Is there any use-case where this would be called directly instead of 
> gsm0808_cell_ids_match() and gs […]
>From my POV it is a useful addition, but you have a point



--
To view, visit https://gerrit.osmocom.org/11504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5535f0d149c2173294538df75764dd181b023312
Gerrit-Change-Number: 11504
Gerrit-PatchSet: 9
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-CC: Pau Espin Pedrol 
Gerrit-CC: Stefan Sperling 
Gerrit-Comment-Date: Sun, 20 Jan 2019 22:38:13 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmocore[master]: add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf()

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12658


Change subject: add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf()
..

add osmo_hexdump_b(), osmo_hexdump_nospc_b(), osmo_hexdump_buf()

Add osmo_hexdump_b() and osmo_hexdump_nospc_b() to use a second static buffer,
allowing more than one hexdump per printf()-like call.

Add osmo_hexdump_buf() as an all-purpose hexdump function, which all other
osmo_hexdump_*() implementations now call. It absorbs the static
_osmo_hexdump(). Add tests for osmo_hexdump_buf().

Rationale: recently during patch review, a situation came up where two hexdumps
in a single printf would have been useful. Now I've faced a similar situation
again, in ongoing development. So I decided it is time to provide this API.

Naming: before, I named functions that use a secondary string buffer with a '2'
suffix, like osmo_plmn_name() and osmo_plmn_name2(). This time, I decided to
use a '_b' suffix, osmo_hexdump_b(), instead. The reason is, by now I think
that '2' is a bad choice for secondary-buffer functions: the '2' suffix is
already used for introducing a newer API version of function signatures. If we,
for example, introduce an osmo_hexdump() that has no final delimiter after the
last byte, that would qualify for osmo_hexdump2(); and that would confuse with
the implementation simply using a secondary buffer. Sometimes during code
review, I assume that the existence of a foo2() function means the patch
submitter should use foo2() instead of foo(), and am annoyed by my previous
choice of overloading the '2' suffix with a secondary meaning besides "this is
newer API".

Change-Id: I590595567b218b24e53c9eb1fd8736c0324d371d
---
M include/osmocom/core/utils.h
M src/utils.c
M tests/utils/utils_test.c
M tests/utils/utils_test.ok
4 files changed, 186 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/12658/1

diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 987080e..ffe6cdd 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -55,7 +55,12 @@

 char *osmo_ubit_dump(const uint8_t *bits, unsigned int len);
 char *osmo_hexdump(const unsigned char *buf, int len);
+char *osmo_hexdump_b(const unsigned char *buf, int len);
 char *osmo_hexdump_nospc(const unsigned char *buf, int len);
+char *osmo_hexdump_nospc_b(const unsigned char *buf, int len);
+char *osmo_hexdump_buf(char *out_buf, size_t out_buf_size, const unsigned char 
*buf, int len, const char *delim,
+  bool delim_after_last);
+
 char *osmo_osmo_hexdump_nospc(const unsigned char *buf, int len) 
__attribute__((__deprecated__));

 #define osmo_static_assert(exp, name) typedef int dummy##name [(exp) ? 1 : -1] 
__attribute__((__unused__));
diff --git a/src/utils.c b/src/utils.c
index d1da4fa..06c2f8a 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -217,32 +217,58 @@
 }

 static char hexd_buff[4096];
+static char hexd_buff2[4096];
 static const char hex_chars[] = "0123456789abcdef";

-static char *_osmo_hexdump(const unsigned char *buf, int len, char *delim)
+/*! Convert binary sequence to hexadecimal ASCII string.
+ *  \param[out] out_buf  Output buffer to write the resulting string to.
+ *  \param[in] out_buf_size  sizeof(out_buf).
+ *  \param[in] buf  Input buffer, pointer to sequence of bytes.
+ *  \param[in] len  Length of input buf in number of bytes.
+ *  \param[in] delim  String to separate each byte; NULL or "" for no delim.
+ *  \param[in] delim_after_last  If true, end the string in delim (true: 
"1a:ef:d9:", false: "1a:ef:d9");
+ *   if out_buf has insufficient space, the string 
will always end in a delim.
+ *  \returns out_buf, containing a zero-terminated string, or NULL if out_buf 
== NULL or out_buf_size < 1.
+ *
+ * This function will print a sequence of bytes as hexadecimal numbers, adding 
one delim between each byte (e.g. for
+ * delim passed as ":", return a string like "1a:ef:d9").
+ *
+ * The delim_after_last argument exists to be able to exactly show the 
original osmo_hexdump() behavior, which always
+ * ends the string with a delimiter.
+ */
+char *osmo_hexdump_buf(char *out_buf, size_t out_buf_size, const unsigned char 
*buf, int len, const char *delim,
+  bool delim_after_last)
 {
int i;
-   char *cur = hexd_buff;
+   char *cur = out_buf;
+   size_t delim_len;
 
-   hexd_buff[0] = 0;
+   if (!out_buf || !out_buf_size)
+   return NULL;
+
+   delim = delim ? : "";
+   delim_len = strlen(delim);
+
for (i = 0; i < len; i++) {
const char *delimp = delim;
-   int len_remain = sizeof(hexd_buff) - (cur - hexd_buff);
-   if (len_remain < 3)
+   int len_remain = out_buf_size - (cur - out_buf) - 1;
+   if (len_remain < (2 + 

Change in libosmocore[master]: add osmo_classmark_* API

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/12659


Change subject: add osmo_classmark_* API
..

add osmo_classmark_* API

osmo-bsc and osmo-msc implement identical Classmark structures. It makes sense
to define once near the gsm48 protocol definitions.

Also move along some generic Classmark API from osmo-msc.

Change-Id: Ifd27bab0380f7ad0c44c719aa6c8bd62cf7b034c
---
M include/osmocom/gsm/protocol/gsm_04_08.h
M src/gsm/gsm48.c
M src/gsm/libosmogsm.map
3 files changed, 171 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/59/12659/1

diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h 
b/include/osmocom/gsm/protocol/gsm_04_08.h
index 234fa79..1e782d5 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -56,6 +56,22 @@
 #endif
 } __attribute__ ((packed));

+struct osmo_classmark {
+   bool classmark1_set;
+   struct gsm48_classmark1 classmark1;
+   uint8_t classmark2_len;
+   uint8_t classmark2[3];
+   uint8_t classmark3_len;
+   uint8_t classmark3[14]; /* if cm3 gets extended by spec, it will be 
truncated */
+};
+
+bool osmo_classmark_is_r99(const struct osmo_classmark *cm);
+bool osmo_classmark1_is_r99(const struct gsm48_classmark1 *cm1);
+bool osmo_classmark2_is_r99(const uint8_t *cm2, uint8_t cm2_len);
+int osmo_classmark_supports_a5(const struct osmo_classmark *cm, uint8_t a5);
+const char *osmo_classmark_a5_name(const struct osmo_classmark *cm);
+void osmo_classmark_update(const struct osmo_classmark *src, struct 
osmo_classmark *dst);
+
 /* Chapter 10.5.2.1b.3 */
 #if OSMO_IS_LITTLE_ENDIAN == 1
 struct gsm48_range_1024 {
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 795e98b..dd193a3 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -1156,4 +1156,152 @@
{}
 };

+bool osmo_classmark1_is_r99(const struct gsm48_classmark1 *cm1)
+{
+   return cm1->rev_lev >= 2;
+}
+
+bool osmo_classmark2_is_r99(const uint8_t *cm2, uint8_t cm2_len)
+{
+   uint8_t rev_lev;
+   if (!cm2_len)
+   return false;
+   rev_lev = (cm2[0] >> 5) & 0x3;
+   return rev_lev >= 2;
+}
+
+/*! Return true if any of Classmark 1 or Classmark 2 are present and indicate 
R99 capability.
+ * \param[in] cm  Classmarks.
+ * \returns True if R99 or later, false if pre-R99 or no Classmarks are 
present.
+ */
+bool osmo_classmark_is_r99(const struct osmo_classmark *cm)
+{
+   if (cm->classmark1_set)
+   return osmo_classmark1_is_r99(>classmark1);
+   return osmo_classmark2_is_r99(cm->classmark2, cm->classmark2_len);
+}
+
+/*! Return a string representation of A5 cipher algorithms indicated by 
Classmark 1, 2 and 3.
+ * \param[in] cm  Classmarks.
+ * \returns A statically allocated string like "cm1{a5/1=supported} cm2{0x23= 
A5/2 A5/3} no-cm3"
+ */
+const char *osmo_classmark_a5_name(const struct osmo_classmark *cm)
+{
+   static char buf[128];
+   char cm1[42];
+   char cm2[42];
+   char cm3[42];
+
+   if (cm->classmark1_set)
+   snprintf(cm1, sizeof(cm1), "cm1{a5/1=%s}",
+cm->classmark1.a5_1 ? "not-supported":"supported" /* 
inverted logic */);
+   else
+   snprintf(cm1, sizeof(cm1), "no-cm1");
+
+   if (cm->classmark2_len >= 3)
+   snprintf(cm2, sizeof(cm2), " cm2{0x%x=%s%s}",
+cm->classmark2[2],
+cm->classmark2[2] & 0x1 ? " A5/2" : "",
+cm->classmark2[2] & 0x2 ? " A5/3" : "");
+   else
+   snprintf(cm2, sizeof(cm2), " no-cm2");
+
+   if (cm->classmark3_len >= 1)
+   snprintf(cm3, sizeof(cm3), " cm3{0x%x=%s%s%s%s}",
+cm->classmark3[0],
+cm->classmark3[0] & (1 << 0) ? " A5/4" : "",
+cm->classmark3[0] & (1 << 1) ? " A5/5" : "",
+cm->classmark3[0] & (1 << 2) ? " A5/6" : "",
+cm->classmark3[0] & (1 << 3) ? " A5/7" : "");
+   else
+   snprintf(cm3, sizeof(cm3), " no-cm3");
+
+   snprintf(buf, sizeof(buf), "%s%s%s", cm1, cm2, cm3);
+   return buf;
+}
+
+/*! Overwrite dst with the Classmark information present in src.
+ * Add an new Classmark and overwrite in dst what src has to offer, but where 
src has no Classmark information, leave
+ * dst unchanged. (For Classmark 2 and 3, dst will exactly match any non-zero 
Classmark length from src, hence may end
+ * up with a shorter Classmark after this call.)
+ * \param[in] src  The new Classmark information to read from.
+ * \param[out] dst  The target Classmark storage to be updated.
+ */
+void osmo_classmark_update(const struct osmo_classmark *src, struct 
osmo_classmark *dst)
+{
+   if (src->classmark1_set) {
+   dst->classmark1 = src->classmark1;
+   

Change in openbsc[master]: Remove meas_* utils

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12655


Change subject: Remove meas_* utils
..

Remove meas_* utils

The counterparts in OsmoBSC repo are actively maintained and (partially) 
packaged
for .deb - let's drop old versions to minimize user confusion.

Change-Id: Ia0cedaad4b717c8c5198842e2acd610f8e03f957
---
M openbsc/src/utils/Makefile.am
D openbsc/src/utils/meas_db.c
D openbsc/src/utils/meas_db.h
D openbsc/src/utils/meas_json.c
D openbsc/src/utils/meas_pcap2db.c
D openbsc/src/utils/meas_udp2db.c
D openbsc/src/utils/meas_vis.c
7 files changed, 0 insertions(+), 1,199 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/55/12655/1

diff --git a/openbsc/src/utils/Makefile.am b/openbsc/src/utils/Makefile.am
index 26494e1..76a73a3 100644
--- a/openbsc/src/utils/Makefile.am
+++ b/openbsc/src/utils/Makefile.am
@@ -18,30 +18,10 @@
$(COVERAGE_LDFLAGS) \
$(NULL)

-noinst_HEADERS = \
-   meas_db.h \
-   $(NULL)
-
 bin_PROGRAMS = \
bs11_config \
isdnsync \
-   meas_json \
$(NULL)
-if HAVE_SQLITE3
-bin_PROGRAMS += \
-   osmo-meas-udp2db \
-   $(NULL)
-if HAVE_PCAP
-bin_PROGRAMS += \
-   osmo-meas-pcap2db \
-   $(NULL)
-endif
-endif
-if HAVE_LIBCDK
-bin_PROGRAMS += \
-   meas_vis \
-   $(NULL)
-endif

 if BUILD_SMPP
 noinst_PROGRAMS = \
@@ -77,71 +57,3 @@
$(LIBOSMOGSM_LIBS) \
$(LIBSMPP34_LIBS) \
$(NULL)
-
-meas_vis_SOURCES = \
-   meas_vis.c \
-   $(NULL)
-
-meas_vis_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   -lcdk \
-   -lncurses \
-   $(NULL)
-
-meas_vis_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(NULL)
-
-osmo_meas_pcap2db_SOURCES = \
-   meas_pcap2db.c \
-   meas_db.c \
-   $(NULL)
-
-osmo_meas_pcap2db_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(SQLITE3_LIBS) \
-   -lpcap \
-   $(NULL)
-
-osmo_meas_pcap2db_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
-osmo_meas_udp2db_SOURCES = \
-   meas_udp2db.c \
-   meas_db.c \
-   $(NULL)
-
-osmo_meas_udp2db_LDADD = \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(SQLITE3_LIBS) \
-   $(NULL)
-
-osmo_meas_udp2db_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
-meas_json_SOURCES = \
-   meas_json.c \
-   $(NULL)
-
-meas_json_LDADD = \
-   $(top_builddir)/src/libcommon/libcommon.a \
-   $(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOGSM_LIBS) \
-   $(NULL)
-
-meas_json_CFLAGS = \
-   $(LIBOSMOCORE_CFLAGS) \
-   $(LIBOSMOGSM_CFLAGS) \
-   $(LIBOSMOABIS_CFLAGS) \
-   $(NULL)
-
diff --git a/openbsc/src/utils/meas_db.c b/openbsc/src/utils/meas_db.c
deleted file mode 100644
index d81efca..000
--- a/openbsc/src/utils/meas_db.c
+++ /dev/null
@@ -1,330 +0,0 @@
-/* Routines for storing measurement reports in SQLite3 database */
-
-/* (C) 2012 by Harald Welte 
- *
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see .
- *
- */
-
-#include 
-#include 
-#include 
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include "meas_db.h"
-
-#define INS_MR "INSERT INTO meas_rep (time, imsi, name, scenario, nr, 
bs_power, ms_timing_offset, fpc, ms_l1_pwr, ms_l1_ta) VALUES 
(?,?,?,?,?,?,?,?,?,?)"
-#define INS_UD "INSERT INTO meas_rep_unidir (meas_id, rx_lev_full, rx_lev_sub, 
rx_qual_full, rx_qual_sub, dtx, uplink) VALUES (?,?,?,?,?,?,?)"
-#define UPD_MR "UPDATE meas_rep SET ul_unidir=?, dl_unidir=? WHERE id=?"
-
-struct meas_db_state {
-   sqlite3 *db;
-   sqlite3_stmt *stmt_ins_ud;
-   sqlite3_stmt *stmt_ins_mr;
-   sqlite3_stmt *stmt_upd_mr;
-};
-
-/* macros to check for SQLite3 result codes */
-#define _SCK_OK(db, call, exp) \
-   do {\
-   int rc = call;  \
-   if (rc != exp) {\
-   fprintf(stderr,"SQL Error in line %u: %s\n",\
-   __LINE__, 

Change in openbsc[master]: Remove openbsc-dev package

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12656


Change subject: Remove openbsc-dev package
..

Remove openbsc-dev package

There're no external utilities which rely on it anymore so we can
simplify our packaging by removing it.

Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
---
M debian/control
D debian/openbsc-dev.install
M openbsc/Makefile.am
M openbsc/configure.ac
D openbsc/openbsc.pc.in
5 files changed, 0 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/56/12656/1

diff --git a/debian/control b/debian/control
index a841acf..a78ff3e 100644
--- a/debian/control
+++ b/debian/control
@@ -69,17 +69,6 @@
  ${misc:Depends}
 Description: OsmoBSC-MGCP: Osmocom's Legacy Media Gateway.

-Package: openbsc-dev
-Architecture: all
-Depends: ${misc:Depends}
-Description: Header file needed by tools tightly integrated
- Some other programs depend on gsm_data_shared.h and gsm_data_shared.c
- from OpenBSC. This package installs these files to your file system so
- that the other packages can build-depend on this package.
- .
- The directory structure is copied after the structure in the repository
- and the header and .c file are installed into /usr/src/osmocom/openbsc/.
-
 Package: osmocom-bsc-sccplite-dbg
 Architecture: any
 Section: debug
diff --git a/debian/openbsc-dev.install b/debian/openbsc-dev.install
deleted file mode 100644
index b669b0f..000
--- a/debian/openbsc-dev.install
+++ /dev/null
@@ -1,3 +0,0 @@
-openbsc/include/openbsc/gsm_data_shared.h 
usr/src/osmocom/openbsc/openbsc/include/openbsc/
-openbsc/src/libcommon/gsm_data_shared.c 
usr/src/osmocom/openbsc/openbsc/src/libcommon/
-usr/lib/*/pkgconfig/openbsc.pc
diff --git a/openbsc/Makefile.am b/openbsc/Makefile.am
index 1b1..f42e6d0 100644
--- a/openbsc/Makefile.am
+++ b/openbsc/Makefile.am
@@ -16,9 +16,6 @@
contrib \
$(NULL)

-pkgconfigdir = $(libdir)/pkgconfig
-pkgconfig_DATA = openbsc.pc
-
 BUILT_SOURCES = $(top_srcdir)/.version
 EXTRA_DIST = git-version-gen osmoappdesc.py .version

diff --git a/openbsc/configure.ac b/openbsc/configure.ac
index 64285e0..109bad8 100644
--- a/openbsc/configure.ac
+++ b/openbsc/configure.ac
@@ -243,7 +243,6 @@
 AM_CONFIG_HEADER(bscconfig.h)

 AC_OUTPUT(
-openbsc.pc
 include/openbsc/Makefile
 include/Makefile
 src/Makefile
diff --git a/openbsc/openbsc.pc.in b/openbsc/openbsc.pc.in
deleted file mode 100644
index 17e265d..000
--- a/openbsc/openbsc.pc.in
+++ /dev/null
@@ -1,10 +0,0 @@
-prefix=@prefix@
-exec_prefix=@exec_prefix@
-libdir=@libdir@
-includedir=@includedir@/
-
-Name: OpenBSC
-Description: OpenBSC base station controller
-Requires:
-Version: @VERSION@
-Cflags: -I${includedir}

--
To view, visit https://gerrit.osmocom.org/12656
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a96c217999416099aa7ce690845f56fc132274c
Gerrit-Change-Number: 12656
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in openbsc[master]: Remove osmocom-ipaccess-utils-dbg package

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12657


Change subject: Remove osmocom-ipaccess-utils-dbg package
..

Remove osmocom-ipaccess-utils-dbg package

The rest was dropped in I9c04f9b469e60802461a2a6e421d3ba27e6dafa1.

Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
---
M debian/control
1 file changed, 0 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/57/12657/1

diff --git a/debian/control b/debian/control
index a78ff3e..557467e 100644
--- a/debian/control
+++ b/debian/control
@@ -85,14 +85,6 @@
 Description: Debug symbols for the OpenBSC NITB
  Make debugging possible

-Package: osmocom-ipaccess-utils-dbg
-Architecture: any
-Section: debug
-Priority: extra
-Depends: osmocom-ipaccess-utils (= ${binary:Version}), ${misc:Depends}
-Description: Debug symbols for the OpenBSC ip.access utils
- Make debugging possible
-
 Package: osmocom-bs11-utils-dbg
 Architecture: any
 Section: debug

--
To view, visit https://gerrit.osmocom.org/12657
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
Gerrit-Change-Number: 12657
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in libosmo-abis[master]: Log peer's port in accept callback

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12654


Change subject: Log peer's port in accept callback
..

Log peer's port in accept callback

* log port from which we accept() the connection in addition to address
* use macro helper for logging

Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
---
M src/input/ipa.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/54/12654/1

diff --git a/src/input/ipa.c b/src/input/ipa.c
index 9853ffa..e41ec42 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -266,8 +266,8 @@
link->addr = talloc_strdup(link, ipbuf);
}

-   LOGP(DLINP, LOGL_NOTICE, "accept()ed new link from %s to port %u\n",
-   inet_ntoa(sa.sin_addr), link->port);
+   LOGIPA(link, LOGL_NOTICE, "accept()ed new link from %s:%u\n",
+   inet_ntoa(sa.sin_addr), ntohs(sa.sin_port));

ret = link->accept_cb(link, fd);
if (ret < 0) {

--
To view, visit https://gerrit.osmocom.org/12654
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I186974dae1819af8c92f9ea9eeb966ec7c9c9f55
Gerrit-Change-Number: 12654
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in libosmo-abis[master]: Set local IP in ipa_server_link properly

[Max]

Max has uploaded this change for review. ( https://gerrit.osmocom.org/12653


Change subject: Set local IP in ipa_server_link properly
..

Set local IP in ipa_server_link properly

When creating IPA link for server we might be called without explicit
address (which is legit - it means bind to all available
addresses). However in this case we won't have 'addr' field of
ipa_server_link initialized properly.

Fix this by following changes:

* don't copy NULL value as address
* use socket's local IP when no address set explicitly

Change-Id: I33679bb35f426d4cafb223b9200fccbf407e0cf6
---
M src/input/ipa.c
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/53/12653/1

diff --git a/src/input/ipa.c b/src/input/ipa.c
index 09e3426..9853ffa 100644
--- a/src/input/ipa.c
+++ b/src/input/ipa.c
@@ -248,6 +248,7 @@
 static int ipa_server_fd_cb(struct osmo_fd *ofd, unsigned int what)
 {
int fd, ret;
+   char ipbuf[INET6_ADDRSTRLEN + 1];
struct sockaddr_in sa;
socklen_t sa_len = sizeof(sa);
struct ipa_server_link *link = ofd->data;
@@ -258,6 +259,13 @@
"peer, reason=`%s'\n", strerror(errno));
return fd;
}
+
+   if (!link->addr) {
+   ret = osmo_sock_get_local_ip(fd, ipbuf, INET6_ADDRSTRLEN + 1);
+   if (ret == 0)
+   link->addr = talloc_strdup(link, ipbuf);
+   }
+
LOGP(DLINP, LOGL_NOTICE, "accept()ed new link from %s to port %u\n",
inet_ntoa(sa.sin_addr), link->port);

@@ -290,7 +298,8 @@
ipa_link->ofd.when |= BSC_FD_READ | BSC_FD_WRITE;
ipa_link->ofd.cb = ipa_server_fd_cb;
ipa_link->ofd.data = ipa_link;
-   ipa_link->addr = talloc_strdup(ipa_link, addr);
+   if (addr)
+   ipa_link->addr = talloc_strdup(ipa_link, addr);
ipa_link->port = port;
ipa_link->accept_cb = accept_cb;
ipa_link->line = line;

--
To view, visit https://gerrit.osmocom.org/12653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33679bb35f426d4cafb223b9200fccbf407e0cf6
Gerrit-Change-Number: 12653
Gerrit-PatchSet: 1
Gerrit-Owner: Max 

Change in osmo-ggsn[master]: Bump version: 1.2.2.44-6da8-dirty → 1.3.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12652 )

Change subject: Bump version: 1.2.2.44-6da8-dirty → 1.3.0
..

Bump version: 1.2.2.44-6da8-dirty → 1.3.0

Change-Id: Ie12af1d57df178a9ab27937ef0b764c98dd96e32
---
M TODO-RELEASE
M debian/changelog
M debian/control
R debian/libgtp4.install
M debian/rules
M gtp/Makefile.am
6 files changed, 67 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/TODO-RELEASE b/TODO-RELEASE
index bbad169..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,3 @@
 # If any interfaces have been added since the last public release: c:r:a + 1.
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
-libmisctun_t   tun_t structure has grown due to switch 
from in_addr to in46_addr (g#11870)
diff --git a/debian/changelog b/debian/changelog
index 3db4bd7..21bd8ff 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,64 @@
+osmo-ggsn (1.3.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * ggsn: ctrl iface: listen on IP configured by VTY
+  * gtp: Log type name of unexpected signalling message
+  * gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn
+  * gtp: Log ignore CTX DEL REQ due to no teardown and only 1 ctx active
+  * gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ
+  * gtp: Add new replacement cb_recovery2 for cb_recovery
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+
+  [ Stefan Sperling ]
+  * fix unaligned access in build_ipcp_pco()
+  * fix support for multiple IPCP in PDP protocol configuration options
+  * check ioctl() call return value in tun_new()
+  * fix allocation of ippool's hash table
+  * replace bogus memcpy() call in ippool_newip()
+  * initialize local variable addr in ippool_new()
+  * fix format string error in ippool_printaddr()
+  * fix a format string directives in queue_seqset()
+  * properly store IPv6 addresses in struct tun_t
+
+  [ Harald Welte ]
+  * debian/rules: Don't overwrite .tarball-version
+  * osmo-ggsn.cfg: Ensure well-formed config file example
+  * sgsnemu: Fix printing of tun device name
+  * ippool.c: Use "%td" format string for ptrdiff_t
+  * initial version of OsmoGGSN user manual
+  * OsmoGGSN: Add VTY reference manual
+  * GGSN: Document how 'ip tuntap' is used for non-root; call netdev 'apn0'
+  * vty-ref: Update URI of docbook 5.0 schema
+
+  [ Alexander Couzens ]
+  * libgtp: implement gtp_clear_queues to clear req/resp queue
+
+  [ Neels Hofmeyr ]
+  * Importing history from osmo-gsm-manuals.git
+  * refactor Makefile build rules, don't use the FORCE
+  * GGSN: don't say 'NITB'
+  * OsmoGGSN: more info on non-root operation / tun creation
+  * OsmoGGSN: multiple instances: mention GTP port
+  * OsmoGGSN: add Routing section for IP forward and masquerading
+  * OsmoGGSN: typo: priveleges
+  * OsmoGGSN VTY ref: prep: convert newlines to unix
+  * OsmoGGSN vty: update VTY reference
+  * OsmoGGSN: fix VTY additions' node IDs
+  * OsmoGGSN: update vty reference
+  * ggsn: update vty reference
+
+  [ Max ]
+  * Expand OsmoGGSN manual
+
+  [ Oliver Smith ]
+  * build manuals moved here from osmo-gsm-manuals.git
+  * Fix DISTCHECK_CONFIGURE_FLAGS override
+  * contrib/jenkins.sh: build and publish manuals
+  * contrib: fix makedistcheck with disabled systemd
+
+ -- Harald Welte   Sun, 20 Jan 2019 21:34:22 +0100
+
 osmo-ggsn (1.2.2) unstable; urgency=medium

   [ Vadim Yanitskiy ]
diff --git a/debian/control b/debian/control
index c8aa0b7..1524438 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@
  operators as the interface between the Internet and the rest of the
  mobile network infrastructure.

-Package: libgtp3
+Package: libgtp4
 Architecture: any
 Multi-Arch: same
 Section: libs
@@ -41,7 +41,7 @@
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
- libgtp3 (= ${binary:Version})
+ libgtp4 (= ${binary:Version})
 Description: Development files for libgtp
  OsmoGGSN is a Gateway GPRS Support Node (GGSN). It is used by mobile
  operators as the interface between the Internet and the rest of the
@@ -54,7 +54,7 @@
 Section: debug
 Architecture: any
 Priority: extra
-Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp3 (= ${binary:Version}), 
osmo-ggsn (= ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp4 (= ${binary:Version}), 
osmo-ggsn (= ${binary:Version})
 Multi-Arch: same
 Description: Debug symbols for OsmoGGSN
  OsmoGGSN is a Gateway GPRS Support Node (GGSN). It is used by mobile
@@ -65,7 +65,7 @@
 Section: debug
 Architecture: any
 Priority: extra
-Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp3 (= ${binary:Version})
+Depends: ${shlibs:Depends}, 

Change in osmo-bsc[master]: Bump version: 1.3.0.293-605c → 1.4.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12651 )

Change subject: Bump version: 1.3.0.293-605c → 1.4.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12651
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaedf16a3a03868c5ca6b1afe9fbac7b042905d51
Gerrit-Change-Number: 12651
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:44:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: Bump version: 1.3.0.293-605c → 1.4.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12651 )

Change subject: Bump version: 1.3.0.293-605c → 1.4.0
..

Bump version: 1.3.0.293-605c → 1.4.0

Change-Id: Iaedf16a3a03868c5ca6b1afe9fbac7b042905d51
---
M debian/changelog
1 file changed, 322 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/changelog b/debian/changelog
index 2e07507..a4f4d40 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,325 @@
+osmo-bsc (1.4.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells
+  * inter-BSC HO: neighbor_ident API: drop 9bit BSIC
+  * doc: update/fix FSM charts
+  * fix / clarify rsl dtap cache
+  * rename gsm_04_08_utils.[hc] to gsm_04_08_rr
+  * cosmetic: move RR functions from bsc_api.c to gsm_04_08_rr.c
+  * add gsm_timers, for Tnnn definitions usable by FSMs
+  * large refactoring: use FSMs for lchans; add inter-BSC HO
+  * fix nanobts: timeslot FSM: use flags to remember OML,RSL status
+  * fix: dispatch TS_EV_RSL_DOWN when losing RSL
+  * timeslot FSM: fix infinite recursion on failure to send PDCH ACT
+  * timeslot FSM: permit entering broken state from anywhere
+  * cosmetic: FSMs: allow ignorable events
+  * fix BSC_CTR_ASSIGNMENT doc strings
+  * lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier
+  * lchan_fsm: add in_release_handler flag
+  * allocate larger lchans if no SDCCH are available
+  * create separate logging categories for lchan,ts,as FSMs
+  * cosmetic: constify gsm_bts_num() net arg
+  * vty: 'handover any': pick more random chans, use lchan_select_by_type()
+  * cosmetic: dissolve bsc_api.c
+  * cosmetic: reduce bsc_api.h
+  * cosmetic: rename bsc_api.h to gsm_08_08.h
+  * cosmetic: rename osmo_bsc_api.c to gsm_08_08.c
+  * cosmetic: gscon: don't re-enter ST_CLEARING
+  * use __FILE__, not __BASE_FILE__
+  * fix lchan_rtp_fsm: missing event handling
+  * MGCP: add 'X-Osmo-IGN: C' for SCCPlite by default
+  * cosmetic: neighbor_ident_vty.c: add and use common string defs
+  * neighbor_ident_vty.c: fix CI format, should be 16bit
+  * inter-BSC HO incoming: continue despite missing Classmark
+  * inter-BSC HO incoming: drop old/wrong RTP port code
+  * lchan_fsm: lchan_fail_to(): store target state early
+  * cosmetic: lchan_fsm failure: log about state transitions
+  * lchan_fsm: safer 'concluded' flag
+  * log: lchan_rtp_fsm: add missing '\n'
+  * log: 'sending BSSMAP HO Request ACK'
+  * inter-BSC HO: send failure msg directly
+  * log: tweaks and more context in osmo_bsc_sigtran_send()
+  * fix dependency bug: include mgcp_client/, not mgcp/
+  * cosmetic: lchan activ: no need to clear mr again
+  * cosmetic: lchan activ: drop todo comments
+  * lchan: pick proper power and ta values
+  * SCCPlite Assignment Complete: include Speech Codec (Chosen)
+  * inter-BSC HO incoming: send BSSMAP HO Complete directly
+  * inter-BSC HO outgoing: fix L3 forwarding
+  * ho fsm: handle RR HO Failure for inter-BSC outgoing
+  * lchan_fsm: allow late RTP release events without erroring
+  * ts,lchan_fsm: do not attempt to allocate CBCH subslots
+  * Implement RR Classmark Enquiry
+  * fix LCLS during Assignment: actually use new TCH lchan
+  * cosmetic: drop param from send_assignment_complete()
+  * vty: add SCCP related vty commands
+  * make: allow vty-tests without configure
+  * test neighbor ident vty docs
+  * neighbor vty: drop keyword 'add'
+  * neighbor vty: rather 'no neighbor', not 'neighbor del'
+  * neighbor vty: allow setting local neighbors by CGI
+  * vty: write local neighbors by bts nr, not lac-ci
+  * fix counters for inter-BSC outgoing
+  * gscon_forget_lchan(): no Clear Request after Clear Command
+  * gscon_forget_lchan(): Clear Request iff no lchans remain
+  * subscr conn: properly forget lchan before release
+  * lchan_fsm: fix failure handling: notify conn when released
+  * handover_decision_2.c: tweak comments
+  * handover_decision_2.c: tweak ho candidate logging
+  * handover_decision_2.c: find_alternative_lchan: drop goto
+  * handover_decision_2.c: drop redundant debug_candidate() args
+  * lchan_fsm: notify conn of released lchan upon RF Release
+  * handover_fsm: adjust inter-BSC HO failure handling to spec
+  * remote-BSS neighbors: allow only one cell ID
+  * handover_decision_2.c: refactor trigger_*()
+  * handover_decision_2.c: implement HO to remote BSS
+  * abis_rsl.c: fix uninitialized RSL cause issues
+  * handover_fsm: fix missing newline for log statement
+  * handover_fsm: fix failure logging of uninitialized chan mode
+  * fix build: revert bad neighbor_ident.vty change
+  * vty doc: drop "(HO algo 2 only)" strings
+  * lchan_fsm_cleanup: drop redundant 'forget_lchan' call
+  * lchan: rf release: make sure conn is NULL
+  * dbug log: verbosely detach conn<->lchan
+  * 

Change in osmo-ggsn[master]: Bump version: 1.2.2.44-6da8-dirty → 1.3.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12652 )

Change subject: Bump version: 1.2.2.44-6da8-dirty → 1.3.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12652
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie12af1d57df178a9ab27937ef0b764c98dd96e32
Gerrit-Change-Number: 12652
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:45:01 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ggsn[master]: Bump version: 1.2.2.44-6da8-dirty → 1.3.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12652


Change subject: Bump version: 1.2.2.44-6da8-dirty → 1.3.0
..

Bump version: 1.2.2.44-6da8-dirty → 1.3.0

Change-Id: Ie12af1d57df178a9ab27937ef0b764c98dd96e32
---
M TODO-RELEASE
M debian/changelog
M debian/control
R debian/libgtp4.install
M debian/rules
M gtp/Makefile.am
6 files changed, 67 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/52/12652/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index bbad169..d0852fc 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,4 +7,3 @@
 # If any interfaces have been added since the last public release: c:r:a + 1.
 # If any interfaces have been removed or changed since the last public 
release: c:r:0.
 #library   whatdescription / commit summary line
-libmisctun_t   tun_t structure has grown due to switch 
from in_addr to in46_addr (g#11870)
diff --git a/debian/changelog b/debian/changelog
index 3db4bd7..21bd8ff 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,64 @@
+osmo-ggsn (1.3.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * ggsn: ctrl iface: listen on IP configured by VTY
+  * gtp: Log type name of unexpected signalling message
+  * gtp: Allow recv DEL CTX REQ in sgsn and DEL CTX RSP in ggsn
+  * gtp: Log ignore CTX DEL REQ due to no teardown and only 1 ctx active
+  * gtp: Add new API to avoid freeing pdp contexts during DEL CTX REQ
+  * gtp: Add new replacement cb_recovery2 for cb_recovery
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+
+  [ Stefan Sperling ]
+  * fix unaligned access in build_ipcp_pco()
+  * fix support for multiple IPCP in PDP protocol configuration options
+  * check ioctl() call return value in tun_new()
+  * fix allocation of ippool's hash table
+  * replace bogus memcpy() call in ippool_newip()
+  * initialize local variable addr in ippool_new()
+  * fix format string error in ippool_printaddr()
+  * fix a format string directives in queue_seqset()
+  * properly store IPv6 addresses in struct tun_t
+
+  [ Harald Welte ]
+  * debian/rules: Don't overwrite .tarball-version
+  * osmo-ggsn.cfg: Ensure well-formed config file example
+  * sgsnemu: Fix printing of tun device name
+  * ippool.c: Use "%td" format string for ptrdiff_t
+  * initial version of OsmoGGSN user manual
+  * OsmoGGSN: Add VTY reference manual
+  * GGSN: Document how 'ip tuntap' is used for non-root; call netdev 'apn0'
+  * vty-ref: Update URI of docbook 5.0 schema
+
+  [ Alexander Couzens ]
+  * libgtp: implement gtp_clear_queues to clear req/resp queue
+
+  [ Neels Hofmeyr ]
+  * Importing history from osmo-gsm-manuals.git
+  * refactor Makefile build rules, don't use the FORCE
+  * GGSN: don't say 'NITB'
+  * OsmoGGSN: more info on non-root operation / tun creation
+  * OsmoGGSN: multiple instances: mention GTP port
+  * OsmoGGSN: add Routing section for IP forward and masquerading
+  * OsmoGGSN: typo: priveleges
+  * OsmoGGSN VTY ref: prep: convert newlines to unix
+  * OsmoGGSN vty: update VTY reference
+  * OsmoGGSN: fix VTY additions' node IDs
+  * OsmoGGSN: update vty reference
+  * ggsn: update vty reference
+
+  [ Max ]
+  * Expand OsmoGGSN manual
+
+  [ Oliver Smith ]
+  * build manuals moved here from osmo-gsm-manuals.git
+  * Fix DISTCHECK_CONFIGURE_FLAGS override
+  * contrib/jenkins.sh: build and publish manuals
+  * contrib: fix makedistcheck with disabled systemd
+
+ -- Harald Welte   Sun, 20 Jan 2019 21:34:22 +0100
+
 osmo-ggsn (1.2.2) unstable; urgency=medium

   [ Vadim Yanitskiy ]
diff --git a/debian/control b/debian/control
index c8aa0b7..1524438 100644
--- a/debian/control
+++ b/debian/control
@@ -22,7 +22,7 @@
  operators as the interface between the Internet and the rest of the
  mobile network infrastructure.

-Package: libgtp3
+Package: libgtp4
 Architecture: any
 Multi-Arch: same
 Section: libs
@@ -41,7 +41,7 @@
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
- libgtp3 (= ${binary:Version})
+ libgtp4 (= ${binary:Version})
 Description: Development files for libgtp
  OsmoGGSN is a Gateway GPRS Support Node (GGSN). It is used by mobile
  operators as the interface between the Internet and the rest of the
@@ -54,7 +54,7 @@
 Section: debug
 Architecture: any
 Priority: extra
-Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp3 (= ${binary:Version}), 
osmo-ggsn (= ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp4 (= ${binary:Version}), 
osmo-ggsn (= ${binary:Version})
 Multi-Arch: same
 Description: Debug symbols for OsmoGGSN
  OsmoGGSN is a Gateway GPRS Support Node (GGSN). It is used by mobile
@@ -65,7 +65,7 @@
 Section: debug
 Architecture: any
 Priority: extra
-Depends: ${shlibs:Depends}, ${misc:Depends}, libgtp3 (= ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, 

Change in osmo-bts[master]: Bump version: 0.8.1.199-5c93-dirty → 1.0.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12650 )

Change subject: Bump version: 0.8.1.199-5c93-dirty → 1.0.0
..

Bump version: 0.8.1.199-5c93-dirty → 1.0.0

Change-Id: Ie33252aef4144f9bb825d7c234970fd4e6083bb2
---
M configure.ac
M debian/changelog
2 files changed, 242 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index e3fefea..15c4259 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,14 +62,14 @@
 fi

 dnl checks for libraries
-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore  >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
-PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore  >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.6.0)
+PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 0.6.0)

 AC_MSG_CHECKING([whether to enable support for sysmobts calibration tool])
 AC_ARG_ENABLE(sysmobts-calib,
diff --git a/debian/changelog b/debian/changelog
index 09e2a83..a33d21f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,237 @@
+osmo-bts (1.0.0) unstable; urgency=medium
+
+  [ Stefan Sperling ]
+  * let osmo-bts log a special notice if OML connection is closed early
+  * log reception of PCU_IF_MSG_PAG_REQ messages from osmo-pcu
+  * update sysinfo copies in all lchans upon SACCH FILL
+  * preserve lchan-specific SI overrides on SACCH FILL
+  * fix timespec subtraction in compute_elapsed_us()
+  * fix conditions for sending fill frames during RTS IND
+  * send TCH/F fill frames in DTX mode (WIP)
+  * Revert "send TCH/F fill frames in DTX mode (WIP)"
+  * prevent potential NULL dereference in virtbts's tx_tchh_fn
+  * properly initialize si3 in test_is_ccch_for_agch_setup()
+  * add missing check of osmo_wqueue_enqueue() return value
+
+  [ Harald Welte ]
+  * scheduler_trx: Add reminders to use libosmocore functions
+  * cosmetic: it's n_r in check_for_first_ciphrd(), not n_s
+  * Add min/max/std-dev measurement reporting for TOA256
+  * debian/rules: Don't overwrite .tarball-version
+  * CBCH: Fix rejecting SMS-CB related RSL messages
+  * [sysmo,lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()
+  * CBCH: Move processing via L1SAP
+  * CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
+  * CBCH: Use llist_first_entry_or_null() instead of reinventing it
+  * l1sap/scheduler: Consistently print chan_nr as hex number
+  * CBCH: Fix CBCH via L1SAP for osmo-bts-{sysmo,octphy,litecell15}
+  * get_lchan_by_chan_nr(): Fix resolution of CBCH
+  * CBCH: Add FIXME comments on queue overflow/underflow handling
+  * CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure
+  * CBCH: Fix CBCH implementation for osmo-bts-trx
+  * CBCH: Some more scheduler_mframe cleanup
+  * ensure all config file examples are well-formed
+  * lc15bts_mgr_vty: Ensure writing well-formed config files
+  * paging_test: Fix AGCH/PCH split test for second half of 102 multiframe
+  * Fix computing CCCH block number from frame number
+  * sysmo, virtual: properly handle BS-AG-BLKS-RES as received from BSC
+  * scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0
+  * initial checkin of manuals to public repo
+  * Add link to Asciidoc source code of manual
+  * spelling: message discriminator, not descriminator
+  * osmobts-abis: Add Revision log regarding dynamic cannels
+  * Documentation on AMR RTP in case of DTX
+  * rtp-amr.adoc: TCH/AFS Uplink
+  * rtp-amr.adoc: TCH/AFS Downlink: Inhibiting
+  * rtp-amr: TCH/AHS Uplink: FACCH/H During DTX
+  * rtp-amr.adoc: New TCH/AHS downlink chapters
+  * rtp-amr.adoc: Fixes to Message Sequence Charts
+  * update osmo-bts-virtual documentation, now that code is merged
+  * vty-ref: Update URI of docbook 5.0 schema
+  * osmo-bts-trx/loops.c: Add comments documenting TA + MS power control loop
+  * osmo-bts-trx/loops.[ch]: Make functions "void" if they always return 0
+  * osmo-bts-trx/loops.c: Use lchan name based logging
+  * osmo-bts-trx/loops.c: Make code control flow more readable
+
+  [ Philipp Maier ]
+  * rtp: make port range configurable, assign correct port numbers
+  * octphy: add support for 16x oversampling mode
+  * cosmetic: separate measurement testcase definitions
+  * cosmetic: unify measurement sample handling 

Change in osmo-bts[master]: Bump version: 0.8.1.199-5c93-dirty → 1.0.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12650 )

Change subject: Bump version: 0.8.1.199-5c93-dirty → 1.0.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12650
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33252aef4144f9bb825d7c234970fd4e6083bb2
Gerrit-Change-Number: 12650
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:38:22 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-bsc[master]: Bump version: 1.3.0.293-605c → 1.4.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12651


Change subject: Bump version: 1.3.0.293-605c → 1.4.0
..

Bump version: 1.3.0.293-605c → 1.4.0

Change-Id: Iaedf16a3a03868c5ca6b1afe9fbac7b042905d51
---
M debian/changelog
1 file changed, 322 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/12651/1

diff --git a/debian/changelog b/debian/changelog
index 2e07507..a4f4d40 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,325 @@
+osmo-bsc (1.4.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * inter-BSC HO: add neighbor_ident API to manage neighbor-BSS-cells
+  * inter-BSC HO: neighbor_ident API: drop 9bit BSIC
+  * doc: update/fix FSM charts
+  * fix / clarify rsl dtap cache
+  * rename gsm_04_08_utils.[hc] to gsm_04_08_rr
+  * cosmetic: move RR functions from bsc_api.c to gsm_04_08_rr.c
+  * add gsm_timers, for Tnnn definitions usable by FSMs
+  * large refactoring: use FSMs for lchans; add inter-BSC HO
+  * fix nanobts: timeslot FSM: use flags to remember OML,RSL status
+  * fix: dispatch TS_EV_RSL_DOWN when losing RSL
+  * timeslot FSM: fix infinite recursion on failure to send PDCH ACT
+  * timeslot FSM: permit entering broken state from anywhere
+  * cosmetic: FSMs: allow ignorable events
+  * fix BSC_CTR_ASSIGNMENT doc strings
+  * lchan_fsm: split off lchan_rtp_fsm, establish RTP a bit earlier
+  * lchan_fsm: add in_release_handler flag
+  * allocate larger lchans if no SDCCH are available
+  * create separate logging categories for lchan,ts,as FSMs
+  * cosmetic: constify gsm_bts_num() net arg
+  * vty: 'handover any': pick more random chans, use lchan_select_by_type()
+  * cosmetic: dissolve bsc_api.c
+  * cosmetic: reduce bsc_api.h
+  * cosmetic: rename bsc_api.h to gsm_08_08.h
+  * cosmetic: rename osmo_bsc_api.c to gsm_08_08.c
+  * cosmetic: gscon: don't re-enter ST_CLEARING
+  * use __FILE__, not __BASE_FILE__
+  * fix lchan_rtp_fsm: missing event handling
+  * MGCP: add 'X-Osmo-IGN: C' for SCCPlite by default
+  * cosmetic: neighbor_ident_vty.c: add and use common string defs
+  * neighbor_ident_vty.c: fix CI format, should be 16bit
+  * inter-BSC HO incoming: continue despite missing Classmark
+  * inter-BSC HO incoming: drop old/wrong RTP port code
+  * lchan_fsm: lchan_fail_to(): store target state early
+  * cosmetic: lchan_fsm failure: log about state transitions
+  * lchan_fsm: safer 'concluded' flag
+  * log: lchan_rtp_fsm: add missing '\n'
+  * log: 'sending BSSMAP HO Request ACK'
+  * inter-BSC HO: send failure msg directly
+  * log: tweaks and more context in osmo_bsc_sigtran_send()
+  * fix dependency bug: include mgcp_client/, not mgcp/
+  * cosmetic: lchan activ: no need to clear mr again
+  * cosmetic: lchan activ: drop todo comments
+  * lchan: pick proper power and ta values
+  * SCCPlite Assignment Complete: include Speech Codec (Chosen)
+  * inter-BSC HO incoming: send BSSMAP HO Complete directly
+  * inter-BSC HO outgoing: fix L3 forwarding
+  * ho fsm: handle RR HO Failure for inter-BSC outgoing
+  * lchan_fsm: allow late RTP release events without erroring
+  * ts,lchan_fsm: do not attempt to allocate CBCH subslots
+  * Implement RR Classmark Enquiry
+  * fix LCLS during Assignment: actually use new TCH lchan
+  * cosmetic: drop param from send_assignment_complete()
+  * vty: add SCCP related vty commands
+  * make: allow vty-tests without configure
+  * test neighbor ident vty docs
+  * neighbor vty: drop keyword 'add'
+  * neighbor vty: rather 'no neighbor', not 'neighbor del'
+  * neighbor vty: allow setting local neighbors by CGI
+  * vty: write local neighbors by bts nr, not lac-ci
+  * fix counters for inter-BSC outgoing
+  * gscon_forget_lchan(): no Clear Request after Clear Command
+  * gscon_forget_lchan(): Clear Request iff no lchans remain
+  * subscr conn: properly forget lchan before release
+  * lchan_fsm: fix failure handling: notify conn when released
+  * handover_decision_2.c: tweak comments
+  * handover_decision_2.c: tweak ho candidate logging
+  * handover_decision_2.c: find_alternative_lchan: drop goto
+  * handover_decision_2.c: drop redundant debug_candidate() args
+  * lchan_fsm: notify conn of released lchan upon RF Release
+  * handover_fsm: adjust inter-BSC HO failure handling to spec
+  * remote-BSS neighbors: allow only one cell ID
+  * handover_decision_2.c: refactor trigger_*()
+  * handover_decision_2.c: implement HO to remote BSS
+  * abis_rsl.c: fix uninitialized RSL cause issues
+  * handover_fsm: fix missing newline for log statement
+  * handover_fsm: fix failure logging of uninitialized chan mode
+  * fix build: revert bad neighbor_ident.vty change
+  * vty doc: drop "(HO algo 2 only)" strings
+  * lchan_fsm_cleanup: drop redundant 'forget_lchan' call
+  * lchan: rf release: make sure conn is NULL
+  * dbug log: verbosely detach conn<->lchan
+  * fix: send RR 

Change in osmo-trx[master]: tests: Rework the convolve_test

[Harald Welte]

Harald Welte has removed a vote on this change.

Change subject: tests: Rework the convolve_test
..


Removed Code-Review+2 by Harald Welte 
--
To view, visit https://gerrit.osmocom.org/12416
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4e203d2c4b778af77d630ed15d4cef6b0c0eb76d
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 4
Gerrit-Owner: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-bts[master]: Bump version: 0.8.1.199-5c93-dirty → 1.0.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12650


Change subject: Bump version: 0.8.1.199-5c93-dirty → 1.0.0
..

Bump version: 0.8.1.199-5c93-dirty → 1.0.0

Change-Id: Ie33252aef4144f9bb825d7c234970fd4e6083bb2
---
M configure.ac
M debian/changelog
2 files changed, 242 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/50/12650/1

diff --git a/configure.ac b/configure.ac
index e3fefea..15c4259 100644
--- a/configure.ac
+++ b/configure.ac
@@ -62,14 +62,14 @@
 fi

 dnl checks for libraries
-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore  >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
-PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore  >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCODEC, libosmocodec >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCODING, libosmocoding >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.6.0)
+PKG_CHECK_MODULES(LIBOSMOTRAU, libosmotrau >= 0.6.0)

 AC_MSG_CHECKING([whether to enable support for sysmobts calibration tool])
 AC_ARG_ENABLE(sysmobts-calib,
diff --git a/debian/changelog b/debian/changelog
index 09e2a83..a33d21f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,237 @@
+osmo-bts (1.0.0) unstable; urgency=medium
+
+  [ Stefan Sperling ]
+  * let osmo-bts log a special notice if OML connection is closed early
+  * log reception of PCU_IF_MSG_PAG_REQ messages from osmo-pcu
+  * update sysinfo copies in all lchans upon SACCH FILL
+  * preserve lchan-specific SI overrides on SACCH FILL
+  * fix timespec subtraction in compute_elapsed_us()
+  * fix conditions for sending fill frames during RTS IND
+  * send TCH/F fill frames in DTX mode (WIP)
+  * Revert "send TCH/F fill frames in DTX mode (WIP)"
+  * prevent potential NULL dereference in virtbts's tx_tchh_fn
+  * properly initialize si3 in test_is_ccch_for_agch_setup()
+  * add missing check of osmo_wqueue_enqueue() return value
+
+  [ Harald Welte ]
+  * scheduler_trx: Add reminders to use libosmocore functions
+  * cosmetic: it's n_r in check_for_first_ciphrd(), not n_s
+  * Add min/max/std-dev measurement reporting for TOA256
+  * debian/rules: Don't overwrite .tarball-version
+  * CBCH: Fix rejecting SMS-CB related RSL messages
+  * [sysmo,lc15]: Consider CBCH channel combinations in chan_nr_by_sapi()
+  * CBCH: Move processing via L1SAP
+  * CBCH: Implement CBCH support for osmo-bts-{trx,virtual}
+  * CBCH: Use llist_first_entry_or_null() instead of reinventing it
+  * l1sap/scheduler: Consistently print chan_nr as hex number
+  * CBCH: Fix CBCH via L1SAP for osmo-bts-{sysmo,octphy,litecell15}
+  * get_lchan_by_chan_nr(): Fix resolution of CBCH
+  * CBCH: Add FIXME comments on queue overflow/underflow handling
+  * CBCH: sprinkle some OMSO_ASSERT() and guard against talloc failure
+  * CBCH: Fix CBCH implementation for osmo-bts-trx
+  * CBCH: Some more scheduler_mframe cleanup
+  * ensure all config file examples are well-formed
+  * lc15bts_mgr_vty: Ensure writing well-formed config files
+  * paging_test: Fix AGCH/PCH split test for second half of 102 multiframe
+  * Fix computing CCCH block number from frame number
+  * sysmo, virtual: properly handle BS-AG-BLKS-RES as received from BSC
+  * scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0
+  * initial checkin of manuals to public repo
+  * Add link to Asciidoc source code of manual
+  * spelling: message discriminator, not descriminator
+  * osmobts-abis: Add Revision log regarding dynamic cannels
+  * Documentation on AMR RTP in case of DTX
+  * rtp-amr.adoc: TCH/AFS Uplink
+  * rtp-amr.adoc: TCH/AFS Downlink: Inhibiting
+  * rtp-amr: TCH/AHS Uplink: FACCH/H During DTX
+  * rtp-amr.adoc: New TCH/AHS downlink chapters
+  * rtp-amr.adoc: Fixes to Message Sequence Charts
+  * update osmo-bts-virtual documentation, now that code is merged
+  * vty-ref: Update URI of docbook 5.0 schema
+  * osmo-bts-trx/loops.c: Add comments documenting TA + MS power control loop
+  * osmo-bts-trx/loops.[ch]: Make functions "void" if they always return 0
+  * osmo-bts-trx/loops.c: Use lchan name based logging
+  * osmo-bts-trx/loops.c: Make code control flow more readable
+
+  [ Philipp Maier ]
+  * rtp: make port range configurable, assign correct port numbers
+  * octphy: add support for 16x oversampling mode
+  * cosmetic: separate measurement testcase definitions
+  * cosmetic: unify measurement sample handling in one function
+ 

Change in osmo-hlr[master]: Bump version: 0.2.1.55-607c-dirty → 1.0.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12647 )

Change subject: Bump version: 0.2.1.55-607c-dirty → 1.0.0
..

Bump version: 0.2.1.55-607c-dirty → 1.0.0

Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
---
M configure.ac
M debian/changelog
2 files changed, 77 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 618ae23..6694f80 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,11 +34,11 @@

 PKG_CHECK_MODULES(TALLOC, [talloc >= 2.0.1])

-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.6.0)

 PKG_CHECK_MODULES(SQLITE3, sqlite3)

diff --git a/debian/changelog b/debian/changelog
index 3763f55..ecb36d3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,75 @@
+osmo-hlr (1.0.0) unstable; urgency=medium
+
+  [ Stefan Sperling ]
+  * move creation of insert subscriber data messages to a common function
+
+  [ Harald Welte ]
+  * Return proper GSUP error in case of too short IMSI
+  * disable blind subscriber insertion into every VLR/SGSN
+  * gsup_server: Add "priv" pointer and make it point to 'struct hlr'
+  * move osmo_gsup_addr_send() declaration from luop.h to gsup_router.h
+  * gsup_router: Use "#pragma once" and add missing #includes
+  * Add "show gsup-connections" VTY command
+  * import gsup_client.c as new libosmo-gsup-client
+  * gsup_client: rename gsup_client_* to osmo_gsup_client_*
+  * GSUP: Log GSUP route add/remove
+  * hlr: Export + Declare global g_hlr symbol
+  * USSD: Add Core USSD handling + VTY routing config to HLR
+  * USSD: Add basic dispatch + decode of GSUP-encapsulated SS/USSD
+  * hlr_ussd: Introduce LOGPSS() macro
+  * USSD: Send ReturnError component if USSD Code unknown / EUSE disconnected
+  * USSD: Further unification of log output; Use LOGPSS when possible
+  * osmo-hlr.cfg: Don't enable DEBUG logging by default
+  * USSD: Add new "DSS" logging category and use it appropriately
+  * USSD: fix null-pointer deref in "default-route" vty/config cmd
+  * Add osmo-euse-demo as minimalistic test of a External USSD (EUSE) handler
+  * USSD: Add support for internal USSD handlers
+  * debian: Add sub-package for libosmo-gsup-client
+  * pkg-config: Fix libosmo-gsup-client pkg-config file
+  * gitignore: Add .tarball-version
+  * debian: Make libosmo-gsup-client-dev depend on libosmo-gsup-client0
+  * USSD: Fix "ussd default-route"
+  * libosmo-gsup-client: License is GPLv2-or-later
+  * osmo-hlr.cfg: Ensure well-formed config file example
+  * test_nodes.vty: Since libosmocore 1.0.0, we only have one space
+
+  [ Martin Hauke ]
+  * sql/Makefile.am: Make docsdir completely configurable
+  * debian: Fix typo in package description
+
+  [ Pau Espin Pedrol ]
+  * debian: Avoid installing duplicate cfg file in /etc
+  * sql/Makefile: Install hlr_data.sql as example together with hlr.sql
+  * sql/Makefile: Install sql files under doc/.../sql subdir
+  * sql/Makefile: Create empty /var/lib/osmocom directory at install time
+  * Install systemd services with autotools
+  * Move doc/Makefile.am to doc/examples/Makefile.am
+  * Install sample cfg file to /etc/osmocom
+
+  [ Vadim Yanitskiy ]
+  * hlr.c: move deinitialization code from SIGINT handler
+  * hlr.c: free root talloc context on exit
+  * hlr.c: track the use of talloc NULL memory contexts
+  * src/db.c: fix: make sure the database is properly closed
+  * src/db.c: don't ignore the result of db_bootstrap()
+  * hlr_vty_subscr.c: fix subscriber creation command help
+  * Update .gitignore: add missing build products
+  * tests/Makefile.am: also remove temporary sqlite files
+  * hlr_ussd.h: add #pragma once include guard
+  * hlr_ussd.h: use proper libc headers
+  * Update .gitignore: ignore osmo-euse-demo
+  * hlr_ussd.h: drop meaningless forward declaration
+  * USSD/hlr_vty.c: print error if EUSE is not found
+  * hlr_ussd.c: fix: properly print a EUSE / IUSE name
+  * hlr_ussd.c: avoid using CR and NL in IUSE responses
+
+  [ Neels Hofmeyr ]
+  * fix build: adjust test_nodes.vty to logging change
+  * tweak example config
+  * make: always allow running python tests manually
+
+ -- Harald Welte   Sun, 20 Jan 2019 19:29:58 +0100
+
 osmo-hlr (0.2.1) unstable; urgency=medium

   [ Neels Hofmeyr ]

--
To view, visit https://gerrit.osmocom.org/12647
To unsubscribe, or for help writing mail filters, visit 

Change in osmo-hlr[master]: Bump version: 0.2.1.55-607c-dirty → 1.0.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12647 )

Change subject: Bump version: 0.2.1.55-607c-dirty → 1.0.0
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
Gerrit-Change-Number: 12647
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:08:13 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: test_nodes.vty: Since libosmocore 1.0.0, we only have one space

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12649 )

Change subject: test_nodes.vty: Since libosmocore 1.0.0, we only have one space
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
Gerrit-Change-Number: 12649
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:08:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: test_nodes.vty: Since libosmocore 1.0.0, we only have one space

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12649 )

Change subject: test_nodes.vty: Since libosmocore 1.0.0, we only have one space
..

test_nodes.vty: Since libosmocore 1.0.0, we only have one space

The output of "logging level" was wrongly indented with two speaces, and
in commit 0d67f483e2d240089105a4d241cb8c9085e245af of libosmocore, first
released as part of libosmcoore-1.0.0 it was fixed.

This makes "make check" pass against libosmocore-1.0.0, but not against
earlier releases.

Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
---
0 files changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified




--
To view, visit https://gerrit.osmocom.org/12649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
Gerrit-Change-Number: 12649
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: Bump version: 0.4.0.125-7c78 → 1.0.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12648 )

Change subject: Bump version: 0.4.0.125-7c78 → 1.0.0
..

Bump version: 0.4.0.125-7c78 → 1.0.0

Change-Id: Ibb888f55a1ab27088d5f21ee8ad699f4f747abde
---
M debian/changelog
1 file changed, 146 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/debian/changelog b/debian/changelog
index a9724d8..dc20ec8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,149 @@
+osmo-trx (1.0.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * doc: examples: Add umtrx sample config
+  * UHDDevice: Fix setup failure with LimeSuite > 18.04.1
+  * examples: Set rt-prio 18 and print file basename
+  * lms: Several improvements and compilation/runtime fixes
+  * build: Add support for LimeSuite device backend
+  * LMSDevice: Set correct values for Max{Tx,Rx}Gain
+  * LMSDevice: Fix setup failure with LimeSuite > 18.04.1
+  * lms: Makefile.am: Reorder params to fix link issue
+  * lms: Check LPBFW to set is within supported range
+  * debian: Add package osmo-trx-lms
+  * contrib: Add systemd services for all backends
+  * debian: Add cfg file examples for osmo-trx-{lms,uhd}
+  * Add -V param to print version
+  * lms: Allow values diff than 34dB to be set by setRxGain()
+  * Use correct paths when installing example files
+  * debian: Enable build of osmo-trx-lms
+  * debian: Explicitly enable osmo-trx-uhd build
+  * configure.ac: Fix typo in with-lms help string
+  * vty: Fix typo in gpsdo clock reference type
+  * configure.ac: Add --enable-werror option
+  * Logger: Disable pthread cancel point inside Logger destructor
+  * cosmetic: Fix trailing whitespace
+  * radioInterface: forward errors from RadioDevice to Transceiver in recv path
+  * lms: Return error on device read timeout
+  * osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on 
error
+  * radioInterface: Fix variable storing integer return value
+  * configure.ac: Specify default language as C++
+  * UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
+  * SigProcLib: Use available copyTo Vector API instead of memcopy
+  * cosmetic: Fix trailing whitespace in several files
+  * radioInterfaceMulti:pullBuffer: Sanely convert float array to complex array
+  * Vector: Copy arrays in a sane way for non-trivially copyable types
+  * jenkins.sh: Add --enable-werror flag to osmo-trx configure step
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+  * cosmetic: Use proper whitespace in several for loops
+  * Use pthread_setname_np to name threads
+  * CommonLibs/Makefile.am: Specify libcommon_la_LIBADD
+  * Transciever: Log values causing Tx underrun
+  * examples: Use logging level 'set-all' instead of 'all'
+  * jenkins.sh: Enable build of osmo-trx-lms
+  * ChannelizerBase: Fix ASan alloc-dealloc-mismatch
+  * UHDDevice: setRxGain on chan 0 when using multi-arfcn
+  * lms: Use LimeSuite.h log level defines instead of hardcoded values
+  * lms: Apply LMS->OSMO log level conversion
+  * Introduce OsmoTRX manual
+  * Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS
+  * trx: Add reference to project wiki page in overfiew section
+  * trx: Add Hardware architecture support section
+  * trx: Add Hardware device support section
+  * osmotrx: Split Device specific section from backend one
+  * osmotrx: Write initial documentation for several supported devices
+  * osmotrx: configuration: Add section to document multi-arfcn feature
+  * osmotrx: Create a common chapter for section documenting backends
+  * osmotrx: Introduce code architecture chapter
+  * lms: Fix start after stop of device
+  * lms: Destroy streams on device stop
+  * radioInterface: Fix memleak during close()
+  * PointerFIFO: Fix memleak of ListNode
+  * lms: Make sure LMS_Close is called when Device is torn down
+  * osmo-trx: Change some lines to use libosmocore logging instead of cout
+  * lms: Close device on LMS_Init failure
+  * SigProcLib: Improve Vector buffer allocation mess
+  * lms: Allow setting Tx/RxGain for chan!=0
+  * lms: Allow setting Tx/RxFreq for lchan!=0
+  * lms: Improve Set{Rx,Tx}{Gain,Freq} logging
+  * transceiver: log chan on CTRL command received
+  * Add TRXCTRL log category
+  * transceiver: Log TRXCTRL iface responses towards osmo-bts-trx
+  * lms: Move {under,over}run checks into separate method
+  * lms: Do {under,over}run checks even if LMS_RecvStream fails
+  * Timeval: passed() returns true if time is equal
+  * Timeval: Move implementation to use clock_gettime and timespec
+  * Timeval: Move to osmo_clock_gettime
+  * TimevalTest: Make test deterministic with fake time
+  * lms: Fix build against LimeSuite > 18.10
+  * configure.ac: check boost only if USRP1 support is enabled
+
+  [ Vadim Yanitskiy ]
+  * trx_vty.c: fix: use 

Change in osmo-trx[master]: Bump version: 0.4.0.125-7c78 → 1.0.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12648 )

Change subject: Bump version: 0.4.0.125-7c78 → 1.0.0
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12648
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb888f55a1ab27088d5f21ee8ad699f4f747abde
Gerrit-Change-Number: 12648
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 20:05:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-hlr[master]: test_nodes.vty: Since libosmocore 1.0.0, we only have one space

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12649


Change subject: test_nodes.vty: Since libosmocore 1.0.0, we only have one space
..

test_nodes.vty: Since libosmocore 1.0.0, we only have one space

The output of "logging level" was wrongly indented with two speaces, and
in commit 0d67f483e2d240089105a4d241cb8c9085e245af of libosmocore, first
released as part of libosmcoore-1.0.0 it was fixed.

This makes "make check" pass against libosmocore-1.0.0, but not against
earlier releases.

Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
---
M tests/test_nodes.vty
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/49/12649/1

diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 95e132d..a9d4ac4 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -108,10 +108,10 @@
 !
 log stderr
 ...
-  logging level main notice
-  logging level db notice
-  logging level auc notice
-  logging level ss info
+ logging level main notice
+ logging level db notice
+ logging level auc notice
+ logging level ss info
 ...
 hlr
  gsup

--
To view, visit https://gerrit.osmocom.org/12649
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cc12b3f0df19d9055022db41f7f3f2789bd19c6
Gerrit-Change-Number: 12649
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in osmo-hlr[master]: Bump version: 0.2.1.55-607c-dirty → 1.0.0

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12647

to look at the new patch set (#2).

Change subject: Bump version: 0.2.1.55-607c-dirty → 1.0.0
..

Bump version: 0.2.1.55-607c-dirty → 1.0.0

Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
---
M configure.ac
M debian/changelog
2 files changed, 77 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/47/12647/2
--
To view, visit https://gerrit.osmocom.org/12647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
Gerrit-Change-Number: 12647
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in osmo-trx[master]: tests: Rework the convolve_test

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/12416 )

Change subject: tests: Rework the convolve_test
..


Patch Set 4: Code-Review-1

Talking with tnt my comments pointed out a bug, so setting -1 on this one.


--
To view, visit https://gerrit.osmocom.org/12416
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e203d2c4b778af77d630ed15d4cef6b0c0eb76d
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 4
Gerrit-Owner: tnt 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 20 Jan 2019 19:59:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-trx[master]: Bump version: 0.4.0.125-7c78 → 1.0.0

[Harald Welte]

Harald Welte has uploaded a new patch set (#2). ( 
https://gerrit.osmocom.org/12648 )

Change subject: Bump version: 0.4.0.125-7c78 → 1.0.0
..

Bump version: 0.4.0.125-7c78 → 1.0.0

Change-Id: Ibb888f55a1ab27088d5f21ee8ad699f4f747abde
---
M debian/changelog
1 file changed, 146 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/12648/2
--
To view, visit https://gerrit.osmocom.org/12648
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibb888f55a1ab27088d5f21ee8ad699f4f747abde
Gerrit-Change-Number: 12648
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-CC: Jenkins Builder (102)

Change in osmo-trx[master]: Bump version: 0.4.0.125-7c78 → 1.0.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12648


Change subject: Bump version: 0.4.0.125-7c78 → 1.0.0
..

Bump version: 0.4.0.125-7c78 → 1.0.0

Change-Id: Ibb888f55a1ab27088d5f21ee8ad699f4f747abde
---
M debian/changelog
1 file changed, 147 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/12648/1

diff --git a/debian/changelog b/debian/changelog
index a9724d8..7461107 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,150 @@
+osmo-trx (1.0.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * doc: examples: Add umtrx sample config
+  * UHDDevice: Fix setup failure with LimeSuite > 18.04.1
+  * examples: Set rt-prio 18 and print file basename
+  * lms: Several improvements and compilation/runtime fixes
+  * build: Add support for LimeSuite device backend
+  * LMSDevice: Set correct values for Max{Tx,Rx}Gain
+  * LMSDevice: Fix setup failure with LimeSuite > 18.04.1
+  * lms: Makefile.am: Reorder params to fix link issue
+  * lms: Check LPBFW to set is within supported range
+  * debian: Add package osmo-trx-lms
+  * contrib: Add systemd services for all backends
+  * debian: Add cfg file examples for osmo-trx-{lms,uhd}
+  * Add -V param to print version
+  * lms: Allow values diff than 34dB to be set by setRxGain()
+  * Use correct paths when installing example files
+  * debian: Enable build of osmo-trx-lms
+  * debian: Explicitly enable osmo-trx-uhd build
+  * configure.ac: Fix typo in with-lms help string
+  * vty: Fix typo in gpsdo clock reference type
+  * configure.ac: Add --enable-werror option
+  * Logger: Disable pthread cancel point inside Logger destructor
+  * cosmetic: Fix trailing whitespace
+  * radioInterface: forward errors from RadioDevice to Transceiver in recv path
+  * lms: Return error on device read timeout
+  * osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on 
error
+  * radioInterface: Fix variable storing integer return value
+  * configure.ac: Specify default language as C++
+  * UHHDDevice: Replace deprecated header uhd/utils/thread_priority.hpp
+  * SigProcLib: Use available copyTo Vector API instead of memcopy
+  * cosmetic: Fix trailing whitespace in several files
+  * radioInterfaceMulti:pullBuffer: Sanely convert float array to complex array
+  * Vector: Copy arrays in a sane way for non-trivially copyable types
+  * jenkins.sh: Add --enable-werror flag to osmo-trx configure step
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+  * cosmetic: Use proper whitespace in several for loops
+  * Use pthread_setname_np to name threads
+  * CommonLibs/Makefile.am: Specify libcommon_la_LIBADD
+  * Transciever: Log values causing Tx underrun
+  * examples: Use logging level 'set-all' instead of 'all'
+  * jenkins.sh: Enable build of osmo-trx-lms
+  * ChannelizerBase: Fix ASan alloc-dealloc-mismatch
+  * UHDDevice: setRxGain on chan 0 when using multi-arfcn
+  * lms: Use LimeSuite.h log level defines instead of hardcoded values
+  * lms: Apply LMS->OSMO log level conversion
+  * Introduce OsmoTRX manual
+  * Introduce chapter trx_if.adoc and add it to OsmoTRX and OsmoBTS
+  * trx: Add reference to project wiki page in overfiew section
+  * trx: Add Hardware architecture support section
+  * trx: Add Hardware device support section
+  * osmotrx: Split Device specific section from backend one
+  * osmotrx: Write initial documentation for several supported devices
+  * osmotrx: configuration: Add section to document multi-arfcn feature
+  * osmotrx: Create a common chapter for section documenting backends
+  * osmotrx: Introduce code architecture chapter
+  * lms: Fix start after stop of device
+  * lms: Destroy streams on device stop
+  * radioInterface: Fix memleak during close()
+  * PointerFIFO: Fix memleak of ListNode
+  * lms: Make sure LMS_Close is called when Device is torn down
+  * osmo-trx: Change some lines to use libosmocore logging instead of cout
+  * lms: Close device on LMS_Init failure
+  * SigProcLib: Improve Vector buffer allocation mess
+  * lms: Allow setting Tx/RxGain for chan!=0
+  * lms: Allow setting Tx/RxFreq for lchan!=0
+  * lms: Improve Set{Rx,Tx}{Gain,Freq} logging
+  * transceiver: log chan on CTRL command received
+  * Add TRXCTRL log category
+  * transceiver: Log TRXCTRL iface responses towards osmo-bts-trx
+  * lms: Move {under,over}run checks into separate method
+  * lms: Do {under,over}run checks even if LMS_RecvStream fails
+  * Timeval: passed() returns true if time is equal
+  * Timeval: Move implementation to use clock_gettime and timespec
+  * Timeval: Move to osmo_clock_gettime
+  * TimevalTest: Make test deterministic with fake time
+  * lms: Fix build against LimeSuite > 18.10
+  * configure.ac: check boost only if USRP1 support is enabled
+
+  [ Vadim Yanitskiy ]
+  * trx_vty.c: fix: use CONFIG_NODE as 

Change in osmo-hlr[master]: Bump version: 0.2.1.55-607c-dirty → 1.0.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12647


Change subject: Bump version: 0.2.1.55-607c-dirty → 1.0.0
..

Bump version: 0.2.1.55-607c-dirty → 1.0.0

Change-Id: I696beb6f0b82dfaf664f62066cffbcc94e31b700
---
M configure.ac
M debian/changelog
2 files changed, 76 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/47/12647/1

diff --git a/configure.ac b/configure.ac
index 99f7829..866da39 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,11 +34,11 @@

 PKG_CHECK_MODULES(TALLOC, [talloc >= 2.0.1])

-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 0.11.0)
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.6.0)

 PKG_CHECK_MODULES(SQLITE3, sqlite3)

diff --git a/debian/changelog b/debian/changelog
index 3763f55..d120866 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,74 @@
+osmo-hlr (1.0.0) unstable; urgency=medium
+
+  [ Stefan Sperling ]
+  * move creation of insert subscriber data messages to a common function
+
+  [ Harald Welte ]
+  * Return proper GSUP error in case of too short IMSI
+  * disable blind subscriber insertion into every VLR/SGSN
+  * gsup_server: Add "priv" pointer and make it point to 'struct hlr'
+  * move osmo_gsup_addr_send() declaration from luop.h to gsup_router.h
+  * gsup_router: Use "#pragma once" and add missing #includes
+  * Add "show gsup-connections" VTY command
+  * import gsup_client.c as new libosmo-gsup-client
+  * gsup_client: rename gsup_client_* to osmo_gsup_client_*
+  * GSUP: Log GSUP route add/remove
+  * hlr: Export + Declare global g_hlr symbol
+  * USSD: Add Core USSD handling + VTY routing config to HLR
+  * USSD: Add basic dispatch + decode of GSUP-encapsulated SS/USSD
+  * hlr_ussd: Introduce LOGPSS() macro
+  * USSD: Send ReturnError component if USSD Code unknown / EUSE disconnected
+  * USSD: Further unification of log output; Use LOGPSS when possible
+  * osmo-hlr.cfg: Don't enable DEBUG logging by default
+  * USSD: Add new "DSS" logging category and use it appropriately
+  * USSD: fix null-pointer deref in "default-route" vty/config cmd
+  * Add osmo-euse-demo as minimalistic test of a External USSD (EUSE) handler
+  * USSD: Add support for internal USSD handlers
+  * debian: Add sub-package for libosmo-gsup-client
+  * pkg-config: Fix libosmo-gsup-client pkg-config file
+  * gitignore: Add .tarball-version
+  * debian: Make libosmo-gsup-client-dev depend on libosmo-gsup-client0
+  * USSD: Fix "ussd default-route"
+  * libosmo-gsup-client: License is GPLv2-or-later
+  * osmo-hlr.cfg: Ensure well-formed config file example
+
+  [ Martin Hauke ]
+  * sql/Makefile.am: Make docsdir completely configurable
+  * debian: Fix typo in package description
+
+  [ Pau Espin Pedrol ]
+  * debian: Avoid installing duplicate cfg file in /etc
+  * sql/Makefile: Install hlr_data.sql as example together with hlr.sql
+  * sql/Makefile: Install sql files under doc/.../sql subdir
+  * sql/Makefile: Create empty /var/lib/osmocom directory at install time
+  * Install systemd services with autotools
+  * Move doc/Makefile.am to doc/examples/Makefile.am
+  * Install sample cfg file to /etc/osmocom
+
+  [ Vadim Yanitskiy ]
+  * hlr.c: move deinitialization code from SIGINT handler
+  * hlr.c: free root talloc context on exit
+  * hlr.c: track the use of talloc NULL memory contexts
+  * src/db.c: fix: make sure the database is properly closed
+  * src/db.c: don't ignore the result of db_bootstrap()
+  * hlr_vty_subscr.c: fix subscriber creation command help
+  * Update .gitignore: add missing build products
+  * tests/Makefile.am: also remove temporary sqlite files
+  * hlr_ussd.h: add #pragma once include guard
+  * hlr_ussd.h: use proper libc headers
+  * Update .gitignore: ignore osmo-euse-demo
+  * hlr_ussd.h: drop meaningless forward declaration
+  * USSD/hlr_vty.c: print error if EUSE is not found
+  * hlr_ussd.c: fix: properly print a EUSE / IUSE name
+  * hlr_ussd.c: avoid using CR and NL in IUSE responses
+
+  [ Neels Hofmeyr ]
+  * fix build: adjust test_nodes.vty to logging change
+  * tweak example config
+  * make: always allow running python tests manually
+
+ -- Harald Welte   Sun, 20 Jan 2019 19:29:58 +0100
+
 osmo-hlr (0.2.1) unstable; urgency=medium

   [ Neels Hofmeyr ]

--
To view, visit https://gerrit.osmocom.org/12647
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master

Change in osmo-mgw[master]: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12646 )

Change subject: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12646
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f7c7b75f38ebd1ee48605596424af48cc1ad53d
Gerrit-Change-Number: 12646
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 15:47:00 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-mgw[master]: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12646 )

Change subject: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0
..

Bump version: 1.4.0.90-ed0c-dirty → 1.5.0

Change-Id: I8f7c7b75f38ebd1ee48605596424af48cc1ad53d
---
M TODO-RELEASE
M configure.ac
M debian/changelog
M debian/control
R debian/libosmo-mgcp-client5.install
M src/libosmo-mgcp-client/Makefile.am
6 files changed, 114 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/TODO-RELEASE b/TODO-RELEASE
index 3969146..c5a3b36 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -24,4 +24,3 @@
 # If any interfaces have been removed or changed since the last public 
release, a=0.
 #
 #library   whatdescription / commit summary line
-libosmo-mgcp-clientvarious Drop legacy API functions and 
mgcp_client_conf members
diff --git a/configure.ac b/configure.ac
index 6f6ad4b..15976e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,10 +39,10 @@
 AC_SUBST(LIBRARY_DL)


-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.3.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.4.0)

 AC_ARG_ENABLE(sanitize,
[AS_HELP_STRING(
diff --git a/debian/changelog b/debian/changelog
index e731351..c1708fa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,110 @@
+osmo-mgw (1.5.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * gitignore: Filter *.pc
+  * configure: Find correct libgsm's gsm.h header
+  * vty: Fix typo writing bts-jitter-buffer-delay-{min,max}
+  * Remove libosmo-legacy-mgcp and osmo-bsc-mgcp
+  * debian: Remove dangling symlink to osmo-bsc-mgcp.service
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+  * mgcp: Fix osmux_cid_bitmap static array size calculation
+  * mgcp_osmux: Use define to calculate rtp_ssrc_winlen
+  * osmux: Avoid initing output without enabling osmux
+  * mgcp: Log endpoint nr consistently as hex
+  * osmux_send_dummy: Avoid logging incorrectly and sending if osmux not 
enabled
+  * osmux: Don't process regular osmux frames if disabled by cfg
+  * osmux: Move parse_cid of legacy dummy frames to own function
+  * osmux: Make func handling dummy frames independent of endp type
+  * osmux: allow enabling osmux only on correct activating state
+  * osmux: Improve checks around activating and using enabled osmux
+  * osmux.h: Document enum osmux_state
+  * osmux: Avoid processing further frames if conn not found
+
+  [ Philipp Maier ]
+  * mgcp_client_fsm: allow ptmap in mgcp_client_fsm as well
+  * mgcp_network: translate payload type numbers in RTP packets
+  * mgcp_client: use IETF source port as for MGCP
+  * mgcp_client: increment local port number when port is in use
+  * mgcp_test: release endpoints after use
+  * network: do not patch PT of RTCP packets
+  * network: check packets before further processing
+  * Cosmetic: remove misplaced line break
+  * mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap)
+  * mgcp_sdp: restructure mgcp_write_response_sdp() (audio)
+  * mgcp_client: check local port only once
+  * mgcp_client_fsm: switch to MGCP_CONN_RECV_SEND in add_audio()
+  * mgcp_protocol: increase buffer space for codec name in LCO
+  * osmo-mgw: Add vty reference manual
+
+  [ Neels Hofmeyr ]
+  * fix handling of "Wrong domain name" error
+  * interpret domain '*' as 'allow any domain'
+  * cosmetic: log: fix "CallIDs does not match"
+  * fix 3G hack: allow any IP for loopback and 0.0.0.0
+  * cosmetic: drop code dup in mgcp_client_fsm.c CRCX
+  * add X-Osmo-IGN MGCP header to ignore CallID
+  * X-Osmo-IGN: rather parse items by token, not char
+  * mgcp_test: fix log of conn_id presence
+  * mgcp_test: fix get_conn_id_from_response() CI length
+  * mgcp_client_test: cosmetically re-arrange reply_to() args
+  * mgcp_client_test: use "\r\n\r\n" instead of "\n\n"
+  * mgcp_client_test: also verify received conn_id
+  * mgcp_client_test: test long conn_id
+  * mgcp_client: error on too long conn id
+  * mgcp_common: rename to MGCP_CONN_ID_MAXLEN
+  * doc: fix mgcp_verify_ci() return val doc
+  * mgcp_verify_ci(): return meaningful error codes
+  * fix mgcp_verify_ci(): off-by-one in max len check
+  * generate shorter 'I:' conn IDs
+  * mgcp_conn_get(): compare conn Id ('I:') case insensitively
+  * mgcp_conn_get(): match conn Id ('I:') despite leading zeros
+  * cosmetic: mgcp_test: fix get_conn_id_from_response()
+  * comment: indicate struct type for mgcp_endpoint.conns
+  * log: avoid logging early media as error
+  * fix 

Change in osmo-mgw[master]: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12646


Change subject: Bump version: 1.4.0.90-ed0c-dirty → 1.5.0
..

Bump version: 1.4.0.90-ed0c-dirty → 1.5.0

Change-Id: I8f7c7b75f38ebd1ee48605596424af48cc1ad53d
---
M TODO-RELEASE
M configure.ac
M debian/changelog
M debian/control
R debian/libosmo-mgcp-client5.install
M src/libosmo-mgcp-client/Makefile.am
6 files changed, 114 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/46/12646/1

diff --git a/TODO-RELEASE b/TODO-RELEASE
index 3969146..c5a3b36 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -24,4 +24,3 @@
 # If any interfaces have been removed or changed since the last public 
release, a=0.
 #
 #library   whatdescription / commit summary line
-libosmo-mgcp-clientvarious Drop legacy API functions and 
mgcp_client_conf members
diff --git a/configure.ac b/configure.ac
index 6f6ad4b..15976e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -39,10 +39,10 @@
 AC_SUBST(LIBRARY_DL)


-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.3.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.4.0)

 AC_ARG_ENABLE(sanitize,
[AS_HELP_STRING(
diff --git a/debian/changelog b/debian/changelog
index e731351..c1708fa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,110 @@
+osmo-mgw (1.5.0) unstable; urgency=medium
+
+  [ Pau Espin Pedrol ]
+  * gitignore: Filter *.pc
+  * configure: Find correct libgsm's gsm.h header
+  * vty: Fix typo writing bts-jitter-buffer-delay-{min,max}
+  * Remove libosmo-legacy-mgcp and osmo-bsc-mgcp
+  * debian: Remove dangling symlink to osmo-bsc-mgcp.service
+  * Install systemd services with autotools
+  * Install sample cfg file to /etc/osmocom
+  * mgcp: Fix osmux_cid_bitmap static array size calculation
+  * mgcp_osmux: Use define to calculate rtp_ssrc_winlen
+  * osmux: Avoid initing output without enabling osmux
+  * mgcp: Log endpoint nr consistently as hex
+  * osmux_send_dummy: Avoid logging incorrectly and sending if osmux not 
enabled
+  * osmux: Don't process regular osmux frames if disabled by cfg
+  * osmux: Move parse_cid of legacy dummy frames to own function
+  * osmux: Make func handling dummy frames independent of endp type
+  * osmux: allow enabling osmux only on correct activating state
+  * osmux: Improve checks around activating and using enabled osmux
+  * osmux.h: Document enum osmux_state
+  * osmux: Avoid processing further frames if conn not found
+
+  [ Philipp Maier ]
+  * mgcp_client_fsm: allow ptmap in mgcp_client_fsm as well
+  * mgcp_network: translate payload type numbers in RTP packets
+  * mgcp_client: use IETF source port as for MGCP
+  * mgcp_client: increment local port number when port is in use
+  * mgcp_test: release endpoints after use
+  * network: do not patch PT of RTCP packets
+  * network: check packets before further processing
+  * Cosmetic: remove misplaced line break
+  * mgcp_sdp: restructure mgcp_write_response_sdp() (rtpmap)
+  * mgcp_sdp: restructure mgcp_write_response_sdp() (audio)
+  * mgcp_client: check local port only once
+  * mgcp_client_fsm: switch to MGCP_CONN_RECV_SEND in add_audio()
+  * mgcp_protocol: increase buffer space for codec name in LCO
+  * osmo-mgw: Add vty reference manual
+
+  [ Neels Hofmeyr ]
+  * fix handling of "Wrong domain name" error
+  * interpret domain '*' as 'allow any domain'
+  * cosmetic: log: fix "CallIDs does not match"
+  * fix 3G hack: allow any IP for loopback and 0.0.0.0
+  * cosmetic: drop code dup in mgcp_client_fsm.c CRCX
+  * add X-Osmo-IGN MGCP header to ignore CallID
+  * X-Osmo-IGN: rather parse items by token, not char
+  * mgcp_test: fix log of conn_id presence
+  * mgcp_test: fix get_conn_id_from_response() CI length
+  * mgcp_client_test: cosmetically re-arrange reply_to() args
+  * mgcp_client_test: use "\r\n\r\n" instead of "\n\n"
+  * mgcp_client_test: also verify received conn_id
+  * mgcp_client_test: test long conn_id
+  * mgcp_client: error on too long conn id
+  * mgcp_common: rename to MGCP_CONN_ID_MAXLEN
+  * doc: fix mgcp_verify_ci() return val doc
+  * mgcp_verify_ci(): return meaningful error codes
+  * fix mgcp_verify_ci(): off-by-one in max len check
+  * generate shorter 'I:' conn IDs
+  * mgcp_conn_get(): compare conn Id ('I:') case insensitively
+  * mgcp_conn_get(): match conn Id ('I:') despite leading zeros
+  * cosmetic: mgcp_test: fix get_conn_id_from_response()
+  * comment: indicate struct type for mgcp_endpoint.conns
+  * log: avoid logging early media as error
+  * fix osmo-mgw -s; 

Change in libosmo-sccp[master]: Bump version: 0.10.0.39-b723 → 1.0.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12644 )

Change subject: Bump version: 0.10.0.39-b723 → 1.0.0
..

Bump version: 0.10.0.39-b723 → 1.0.0

Change-Id: I9b9d9331bdd1d9cdebdef5c3e0c49a1b18972abd
---
M debian/changelog
M debian/control
R debian/libosmo-sigtran3.install
M debian/rules
M src/Makefile.am
5 files changed, 65 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index 135d08e..06496c1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,61 @@
+libosmo-sccp (1.0.0) unstable; urgency=medium
+
+  [ Harald Welte ]
+  * Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()
+  * debian/rules: Don't overwrite .tarball-version
+  * Revert "Install systemd services with autotools"
+  * osmo-stp.cfg: Ensure example config is well-formed
+  * First step towards an OsmoSTP manual
+  * STP: Update vty reference XML file
+  * vty-ref: Update URI of docbook 5.0 schema
+
+  [ Pau Espin Pedrol ]
+  * sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
+  * xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp
+  * Install systemd services with autotools
+  * Install systemd services with autotools
+  * debian/rules: Remove duplicated override_dh_auto_test section
+  * Install sample cfg file to /etc/osmocom
+  * debian: Document why enable-static is used in dh_auto_configure
+
+  [ Neels Hofmeyr ]
+  * ipa_asp_fsm: init: expect IPA ID ACK, not GET
+  * cosmetic: sccp_scoc.c: fix timers definition units
+  * drop inaccurate comment from osmo_ss7_vty.c
+  * vty: fix 'show asp' from within 'asp' node
+  * allow less characters for SCCP address book entries
+  * add tests/vty: VTY UI transcript testing
+  * sccp_vty: define SCCP_STR once
+  * vty: tweak two printed strings
+  * vty: install 'show cs7' for sccp addrs on _ve nodes
+  * cosmetic: allocate ss7->sccp in one common function
+  * sccp_vty: fix doc strings for show ... ssn,connections
+  * make SCCP timers configurable
+  * build: move include/{mtp,sccp} to include/osmocom/
+  * osmo-stp: add SCCP related VTY commands
+  * Importing history from osmo-gsm-manuals.git
+  * OsmoSTP: update VTY reference
+  * stp: update vty reference
+  * stp: update vty reference with added SCCP commands
+
+  [ Stefan Sperling ]
+  * skip simple-client default as/asp when saving VTY config
+  * return error code from xua_srv_conn_cb() if conn is freed
+  * fix ipa_asp_fsm down state transition
+
+  [ Max ]
+  * Make pointcode width function public
+  * Log ip:port for created SS7 server
+  * SS7: safeguard against wrong number of pointcode component
+
+  [ Oliver Smith ]
+  * build manuals moved here from osmo-gsm-manuals.git
+  * Fix DISTCHECK_CONFIGURE_FLAGS override
+  * contrib/jenkins.sh: build and publish manuals
+  * contrib: fix makedistcheck with disabled systemd
+
+ -- Harald Welte   Sun, 20 Jan 2019 11:33:22 +0100
+
 libosmo-sccp (0.10.0) unstable; urgency=medium

   [ Harald Welte ]
diff --git a/debian/control b/debian/control
index 8680bba..44d0fc6 100644
--- a/debian/control
+++ b/debian/control
@@ -33,7 +33,7 @@
  .
  This package contains the development files for the library.

-Package: libosmo-sigtran0
+Package: libosmo-sigtran3
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -52,7 +52,7 @@
 Architecture: any
 Section: debug
 Multi-Arch: same
-Depends: libosmo-sigtran0 (= ${binary:Version}),
+Depends: libosmo-sigtran3 (= ${binary:Version}),
  ${misc:Depends}
 Description: Documentation for the Osmocom SIGTRAN library
   libosmo-sigtran is a shared library containing SS7/SIGTRAN related 
functionality,
@@ -67,7 +67,7 @@
 Architecture: all
 Section: doc
 Depends: ${misc:Depends},
- libosmo-sigtran0 (= ${binary:Version}),
+ libosmo-sigtran3 (= ${binary:Version}),
  libjs-jquery
 Description: Documentation for the Osmocom SIGTRAN library
   libosmo-sigtran is a shared library containing SS7/SIGTRAN related 
functionality,
@@ -82,7 +82,7 @@
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
- libosmo-sigtran0 (= ${binary:Version}),
+ libosmo-sigtran3 (= ${binary:Version}),
  libosmocore-dev,
  libosmo-netif-dev
 Description: Development headers for the Osmocom SIGTRAN library
@@ -97,7 +97,7 @@
 Architecture: any
 Multi-Arch: same
 Section: net
-Depends: libosmo-sigtran0,
+Depends: libosmo-sigtran3,
  ${shlibs:Depends},
  ${misc:Depends}
 Description: Osmocom SIGTRAN STP (Signaling Transfer Point)
diff --git a/debian/libosmo-sigtran0.install b/debian/libosmo-sigtran3.install
similarity index 100%
rename from debian/libosmo-sigtran0.install
rename to debian/libosmo-sigtran3.install
diff --git a/debian/rules b/debian/rules
index 0bf9673..f443aee 100755
--- a/debian/rules
+++ b/debian/rules
@@ 

Change in libosmo-sccp[master]: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12645 )

Change subject: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized
..

sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized

This fixes the following compiler warning when using -Werror on gcc-8.2:

sccp.c: In function ‘sccp_system_incoming_ctx’:
sccp.c:1039:10: error: ‘result.destination_local_reference’ may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
   && memcmp(>source_local_reference,
  result.destination_local_reference,
  sizeof(conn->source_local_reference)) == 0
sccp.c:1030:27: note: ‘result.destination_local_reference’ was declared here
  struct sccp_parse_result result;
   ^~

Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
---
M src/sccp.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/sccp.c b/src/sccp.c
index 8c3641c..ec0f3b7 100644
--- a/src/sccp.c
+++ b/src/sccp.c
@@ -1027,7 +1027,7 @@
 /* Handle the release confirmed */
 static int _sccp_handle_connection_release_complete(struct msgb *msgb)
 {
-   struct sccp_parse_result result;
+   struct sccp_parse_result result = {};
struct sccp_connection *conn;

if (_sccp_parse_connection_release_complete(msgb, ) != 0)

--
To view, visit https://gerrit.osmocom.org/12645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmo-sccp[master]: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12645 )

Change subject: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 14:17:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: Bump version: 0.10.0.39-b723 → 1.0.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12644 )

Change subject: Bump version: 0.10.0.39-b723 → 1.0.0
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12644
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9d9331bdd1d9cdebdef5c3e0c49a1b18972abd
Gerrit-Change-Number: 12644
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 14:17:58 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmo-sccp[master]: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12645


Change subject: sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized
..

sccp.c: Fix gcc-8.2 -Werror=maybe-uninitialized

This fixes the following compiler warning when using -Werror on gcc-8.2:

sccp.c: In function ‘sccp_system_incoming_ctx’:
sccp.c:1039:10: error: ‘result.destination_local_reference’ may be used 
uninitialized in this function [-Werror=maybe-uninitialized]
   && memcmp(>source_local_reference,
  result.destination_local_reference,
  sizeof(conn->source_local_reference)) == 0
sccp.c:1030:27: note: ‘result.destination_local_reference’ was declared here
  struct sccp_parse_result result;
   ^~

Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
---
M src/sccp.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/45/12645/1

diff --git a/src/sccp.c b/src/sccp.c
index 8c3641c..ec0f3b7 100644
--- a/src/sccp.c
+++ b/src/sccp.c
@@ -1027,7 +1027,7 @@
 /* Handle the release confirmed */
 static int _sccp_handle_connection_release_complete(struct msgb *msgb)
 {
-   struct sccp_parse_result result;
+   struct sccp_parse_result result = {};
struct sccp_connection *conn;

if (_sccp_parse_connection_release_complete(msgb, ) != 0)

--
To view, visit https://gerrit.osmocom.org/12645
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied41f7c8ddaa5f616dd6556079a54d8d70274490
Gerrit-Change-Number: 12645
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in libosmo-sccp[master]: Bump version: 0.10.0.39-b723 → 1.0.0

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12644


Change subject: Bump version: 0.10.0.39-b723 → 1.0.0
..

Bump version: 0.10.0.39-b723 → 1.0.0

Change-Id: I9b9d9331bdd1d9cdebdef5c3e0c49a1b18972abd
---
M debian/changelog
M debian/control
R debian/libosmo-sigtran3.install
M debian/rules
M src/Makefile.am
5 files changed, 65 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/44/12644/1

diff --git a/debian/changelog b/debian/changelog
index 135d08e..06496c1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,61 @@
+libosmo-sccp (1.0.0) unstable; urgency=medium
+
+  [ Harald Welte ]
+  * Migrate from ipa_ccm_idtag_parse() to ipa_ccm_id_resp_parse()
+  * debian/rules: Don't overwrite .tarball-version
+  * Revert "Install systemd services with autotools"
+  * osmo-stp.cfg: Ensure example config is well-formed
+  * First step towards an OsmoSTP manual
+  * STP: Update vty reference XML file
+  * vty-ref: Update URI of docbook 5.0 schema
+
+  [ Pau Espin Pedrol ]
+  * sscp_scrc: Fix memleak of xua_msg when handing it to 
scrc_rx_mtp_xfer_ind_xua
+  * xua_rkm: Fix xua_msg memleank in handle_rkey_reg_resp
+  * Install systemd services with autotools
+  * Install systemd services with autotools
+  * debian/rules: Remove duplicated override_dh_auto_test section
+  * Install sample cfg file to /etc/osmocom
+  * debian: Document why enable-static is used in dh_auto_configure
+
+  [ Neels Hofmeyr ]
+  * ipa_asp_fsm: init: expect IPA ID ACK, not GET
+  * cosmetic: sccp_scoc.c: fix timers definition units
+  * drop inaccurate comment from osmo_ss7_vty.c
+  * vty: fix 'show asp' from within 'asp' node
+  * allow less characters for SCCP address book entries
+  * add tests/vty: VTY UI transcript testing
+  * sccp_vty: define SCCP_STR once
+  * vty: tweak two printed strings
+  * vty: install 'show cs7' for sccp addrs on _ve nodes
+  * cosmetic: allocate ss7->sccp in one common function
+  * sccp_vty: fix doc strings for show ... ssn,connections
+  * make SCCP timers configurable
+  * build: move include/{mtp,sccp} to include/osmocom/
+  * osmo-stp: add SCCP related VTY commands
+  * Importing history from osmo-gsm-manuals.git
+  * OsmoSTP: update VTY reference
+  * stp: update vty reference
+  * stp: update vty reference with added SCCP commands
+
+  [ Stefan Sperling ]
+  * skip simple-client default as/asp when saving VTY config
+  * return error code from xua_srv_conn_cb() if conn is freed
+  * fix ipa_asp_fsm down state transition
+
+  [ Max ]
+  * Make pointcode width function public
+  * Log ip:port for created SS7 server
+  * SS7: safeguard against wrong number of pointcode component
+
+  [ Oliver Smith ]
+  * build manuals moved here from osmo-gsm-manuals.git
+  * Fix DISTCHECK_CONFIGURE_FLAGS override
+  * contrib/jenkins.sh: build and publish manuals
+  * contrib: fix makedistcheck with disabled systemd
+
+ -- Harald Welte   Sun, 20 Jan 2019 11:33:22 +0100
+
 libosmo-sccp (0.10.0) unstable; urgency=medium
 
   [ Harald Welte ]
diff --git a/debian/control b/debian/control
index 8680bba..44d0fc6 100644
--- a/debian/control
+++ b/debian/control
@@ -33,7 +33,7 @@
  .
  This package contains the development files for the library.

-Package: libosmo-sigtran0
+Package: libosmo-sigtran3
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -52,7 +52,7 @@
 Architecture: any
 Section: debug
 Multi-Arch: same
-Depends: libosmo-sigtran0 (= ${binary:Version}),
+Depends: libosmo-sigtran3 (= ${binary:Version}),
  ${misc:Depends}
 Description: Documentation for the Osmocom SIGTRAN library
   libosmo-sigtran is a shared library containing SS7/SIGTRAN related 
functionality,
@@ -67,7 +67,7 @@
 Architecture: all
 Section: doc
 Depends: ${misc:Depends},
- libosmo-sigtran0 (= ${binary:Version}),
+ libosmo-sigtran3 (= ${binary:Version}),
  libjs-jquery
 Description: Documentation for the Osmocom SIGTRAN library
   libosmo-sigtran is a shared library containing SS7/SIGTRAN related 
functionality,
@@ -82,7 +82,7 @@
 Multi-Arch: same
 Section: libdevel
 Depends: ${misc:Depends},
- libosmo-sigtran0 (= ${binary:Version}),
+ libosmo-sigtran3 (= ${binary:Version}),
  libosmocore-dev,
  libosmo-netif-dev
 Description: Development headers for the Osmocom SIGTRAN library
@@ -97,7 +97,7 @@
 Architecture: any
 Multi-Arch: same
 Section: net
-Depends: libosmo-sigtran0,
+Depends: libosmo-sigtran3,
  ${shlibs:Depends},
  ${misc:Depends}
 Description: Osmocom SIGTRAN STP (Signaling Transfer Point)
diff --git a/debian/libosmo-sigtran0.install b/debian/libosmo-sigtran3.install
similarity index 100%
rename from debian/libosmo-sigtran0.install
rename to debian/libosmo-sigtran3.install
diff --git a/debian/rules b/debian/rules
index 0bf9673..f443aee 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,7 +12,7 @@
 

Change in libosmo-netif[master]: Bump version: 0.3.0.6-a555 → 0.4.0

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/12640 )

Change subject: Bump version: 0.3.0.6-a555 → 0.4.0
..

Bump version: 0.3.0.6-a555 → 0.4.0

Change-Id: I99a3244f922382468251df675287520ca40d9d0d
---
M configure.ac
M debian/changelog
M src/Makefile.am
3 files changed, 23 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index 4246c00..66ec57f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,10 +82,10 @@
 dnl Generate the output
 AM_CONFIG_HEADER(config.h)

-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.12.0)
-PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 0.12.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.0.0)
 dnl FIXME: We depend on libosmoabis by now until we can move LAPD code here
-PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.5.1)
+PKG_CHECK_MODULES(LIBOSMOABIS, libosmoabis >= 0.6.0)

 old_LIBS=$LIBS
 AC_SEARCH_LIBS([sctp_send], [sctp], [
diff --git a/debian/changelog b/debian/changelog
index c08bf9e..6c56148 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,22 @@
+libosmo-netif (0.4.0) unstable; urgency=medium
+
+  [ Neels Hofmeyr ]
+  * fix strncpy bug in rs232.c
+  * logging: fix typo in stream.c
+
+  [ Harald Welte ]
+  * Migrate from osmo_ipa_idtag_parse() to ipa_ccm_id_resp_parse()
+  * link libosmo-netif against libosmogsm
+  * debian/rules: Don't overwrite .tarball-version
+
+  [ Pau Espin Pedrol ]
+  * jibuf: fix indentation in line inside conditional clause
+
+  [ Stefan Sperling ]
+  * detect freed connections in osmo_stream_srv_read()
+
+ -- Harald Welte   Sat, 19 Jan 2019 22:28:01 +0100
+
 libosmo-netif (0.3.0) unstable; urgency=medium

   [ Pau Espin Pedrol ]
diff --git a/src/Makefile.am b/src/Makefile.am
index de7dff5..d92d0f6 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,6 +1,6 @@
 # This is _NOT_ the library release version, it's an API version.
 # Please read Chapter 6 "Library interface versions" of the libtool 
documentation before making any modification
-LIBVERSION=6:0:0
+LIBVERSION=6:1:0

 AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_builddir)
 AM_CFLAGS= -fPIC -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) 
$(LIBOSMOABIS_CFLAGS) $(COVERAGE_CFLAGS) $(LIBSCTP_CFLAGS)

--
To view, visit https://gerrit.osmocom.org/12640
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99a3244f922382468251df675287520ca40d9d0d
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: constrain gsm48_generate_mid() output array bounds

[tnt]

tnt has posted comments on this change. ( https://gerrit.osmocom.org/12641 )

Change subject: constrain gsm48_generate_mid() output array bounds
..


Patch Set 3: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
Gerrit-Change-Number: 12641
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: tnt 
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 20 Jan 2019 13:31:38 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: constrain gsm48_generate_mid() output array bounds

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12641

to look at the new patch set (#3).

Change subject: constrain gsm48_generate_mid() output array bounds
..

constrain gsm48_generate_mid() output array bounds

The longest BCd-digit type identity is the IMEISV with 16, so there's
no point in trying to parse up to 255 decimal digits, which will do
nothing but to overflow the caller-provided output buffer.

Let's also clearly define the required minimum size of the output
buffer and add a reltead #define for it.

Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
---
M include/osmocom/gsm/gsm48.h
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_bss.c
M src/gsm/gsm48.c
4 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12641/3
--
To view, visit https://gerrit.osmocom.org/12641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
Gerrit-Change-Number: 12641
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 

Change in libosmocore[master]: WIP: Work around bogus gcc-8.2 array-bounds warning/error

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12643


Change subject: WIP: Work around bogus gcc-8.2 array-bounds warning/error
..

WIP: Work around bogus gcc-8.2 array-bounds warning/error

gcc-8.2 is printing the following warning, which is an error
when used -Werror like our --enable-werror:

In file included from gprs_bssgp.c:34:
In function ‘tl16v_put’,
inlined from ‘tvlv_put.part.3’ at ../../include/osmocom/gsm/tlv.h:156:9,
inlined from ‘tvlv_put’ at ../../include/osmocom/gsm/tlv.h:147:24,
inlined from ‘msgb_tvlv_push’ at ../../include/osmocom/gsm/tlv.h:386:2,
inlined from ‘bssgp_tx_dl_ud’ at gprs_bssgp.c:1162:4:
../../include/osmocom/gsm/tlv.h:131:2: error: ‘memcpy’ forming offset [12, 130] 
is out of the bounds [0, 11] of object ‘mi’ with type ‘uint8_t[11]’ {aka 
‘unsigned char[11]’} [-Werror=array-bounds]
  memcpy(buf, val, len);

Where "130" seems to be the maximum value of uint8_t, shifted right one +
2.  But even as we use strnlen() with "16" as maximum upper bound, gcc
still believes there's a way that the return value of 
gsm48_generate_mid_from_imsi()
could be 130.  In fact, even the newly-added OSMO_ASSERT() inside
gsm48_generate_mid() doesn't help and gcc still insists there is a problem :(

Change-Id: I0a06daa19b7b5b5badbb8b3d81a54c45b88a60ec
---
M src/gb/gprs_bssgp.c
M src/gb/gprs_bssgp_bss.c
2 files changed, 21 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/43/12643/1

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index be7ef9f..4a4bab3 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -1157,10 +1157,17 @@
/* IMSI */
if (dup->imsi && strlen(dup->imsi)) {
uint8_t mi[GSM48_MID_MAX_SIZE];
+/* gsm48_generate_mid_from_imsi() is guaranteed to never return more than 11,
+ * but somehow gcc (8.2) is not smart enough to figure this out and claims that
+ * the memcpy in msgb_tvlv_put() below will cause and out-of-bounds access up 
to
+ * mi[131], which is wrong */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
int imsi_len = gsm48_generate_mid_from_imsi(mi, dup->imsi);
if (imsi_len > 2)
msgb_tvlv_push(msg, BSSGP_IE_IMSI,
imsi_len-2, mi+2);
+#pragma GCC diagnostic pop
}

/* DRX parameters */
@@ -1220,7 +1227,14 @@
else
bgph->pdu_type = BSSGP_PDUT_PAGING_CS;
/* IMSI */
+/* gsm48_generate_mid_from_imsi() is guaranteed to never return more than 11,
+ * but somehow gcc (8.2) is not smart enough to figure this out and claims that
+ * the memcpy in msgb_tvlv_put() below will cause and out-of-bounds access up 
to
+ * mi[131], which is wrong */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
msgb_tvlv_put(msg, BSSGP_IE_IMSI, imsi_len-2, mi+2);
+#pragma GCC diagnostic pop
/* DRX Parameters */
msgb_tvlv_put(msg, BSSGP_IE_DRX_PARAMS, 2,
(uint8_t *) _params);
diff --git a/src/gb/gprs_bssgp_bss.c b/src/gb/gprs_bssgp_bss.c
index 77350e2..bef9bb1 100644
--- a/src/gb/gprs_bssgp_bss.c
+++ b/src/gb/gprs_bssgp_bss.c
@@ -183,10 +183,16 @@

if (!msg)
return -ENOMEM;
-
+/* gsm48_generate_mid_from_imsi() is guaranteed to never return more than 11,
+ * but somehow gcc (8.2) is not smart enough to figure this out and claims that
+ * the memcpy in msgb_tvlv_put() below will cause and out-of-bounds access up 
to
+ * mi[131], which is wrong */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
/* strip the MI type and length values (2 bytes) */
if (imsi_len > 2)
msgb_tvlv_put(msg, BSSGP_IE_IMSI, imsi_len-2, mi+2);
+#pragma GCC diagnostic pop
LOGPC(DBSSGP, LOGL_NOTICE, "IMSI=%s ", imsi);

return common_tx_radio_status2(msg, cause);

--
To view, visit https://gerrit.osmocom.org/12643
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a06daa19b7b5b5badbb8b3d81a54c45b88a60ec
Gerrit-Change-Number: 12643
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in libosmocore[master]: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12641 )

Change subject: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error
..


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/12641/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12641/2//COMMIT_MSG@23
PS2, Line 23: the return value of gsm48_generate_mid_from_imsi()
: could be 130
Oh, wow...


https://gerrit.osmocom.org/#/c/12641/2/src/gsm/gsm48.c
File src/gsm/gsm48.c:

https://gerrit.osmocom.org/#/c/12641/2/src/gsm/gsm48.c@668
PS2, Line 668: 2 + buf[1]
Hmm, why do we add 2 here?

We use buf[0], buf[1], and buf[2], and then buf[2 + i], where i starts from 1...

I think one byte is lost, and we should return 3 + buf[1].



--
To view, visit https://gerrit.osmocom.org/12641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
Gerrit-Change-Number: 12641
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 20 Jan 2019 10:38:54 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in libosmo-netif[master]: Bump version: 0.3.0.6-a555 → 0.4.0

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12640

to look at the new patch set (#2).

Change subject: Bump version: 0.3.0.6-a555 → 0.4.0
..

Bump version: 0.3.0.6-a555 → 0.4.0

Change-Id: I99a3244f922382468251df675287520ca40d9d0d
---
M configure.ac
M debian/changelog
M src/Makefile.am
3 files changed, 23 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/40/12640/2
--
To view, visit https://gerrit.osmocom.org/12640
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a3244f922382468251df675287520ca40d9d0d
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmo-netif[master]: Bump version: 0.3.0.6-a555 → 0.4.0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12640 )

Change subject: Bump version: 0.3.0.6-a555 → 0.4.0
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/12640
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a3244f922382468251df675287520ca40d9d0d
Gerrit-Change-Number: 12640
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 20 Jan 2019 10:23:19 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in gr-gsm[master]: trx/ctrl_if_bb.py: reset transceiver on POWEROFF

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12634 )

Change subject: trx/ctrl_if_bb.py: reset transceiver on POWEROFF
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12634/1/python/trx/radio_if.py
File python/trx/radio_if.py:

https://gerrit.osmocom.org/#/c/12634/1/python/trx/radio_if.py@273
PS1, Line 273: do we need
I think yes, but trxcon would need to always send both RXTUNE and TXTUNE before 
POWERON. Currently it doesn't :/



--
To view, visit https://gerrit.osmocom.org/12634
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e7f74c56388a431794a0b32b8a9537c360f5d33
Gerrit-Change-Number: 12634
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 20 Jan 2019 09:54:45 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Build failure of network:osmocom:latest/osmo-sgsn in Debian_9.0/aarch64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_9.0/aarch64

Package network:osmocom:latest/osmo-sgsn failed to build in Debian_9.0/aarch64

Check out the package for editing:
  osc checkout network:osmocom:latest osmo-sgsn

Last lines of build log:
[  109s]  06 
[  109s]  
[  109s] -==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  109s] -
[  109s]  MESSAGE to BSS at 0x01020304:, msg length 1
[  109s]  07 
[  109s]  
[  109s] +==> got signal NS_UNBLOCK, NS-VC 0x1001/1.2.3.4:
[  109s] +
[  109s]  result (UNBLOCK) = 1
[  109s]  
[  109s]  PROCESSING ALIVE_ACK from 0x01020304:
[  109s] 2. testsuite.at:10: 2. gbproxy (testsuite.at:10): FAILED 
(testsuite.at:13)
[  109s] debian/rules:65: recipe for target 'override_dh_auto_test' failed
[  109s] make[1]: *** [override_dh_auto_test] Error 1
[  109s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  109s] debian/rules:45: recipe for target 'build' failed
[  109s] make: *** [build] Error 2
[  109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  109s] 
[  109s] obs-arm-7 failed "build osmo-sgsn_1.3.0.dsc" at Sun Jan 20 09:49:25 
UTC 2019.
[  109s] 
[  109s] ### VM INTERACTION START ###
[  111s] [   98.856975] sysrq: SysRq : Power Off
[  111s] [   98.858345] reboot: Power down
[  111s] ### VM INTERACTION END ###
[  111s] 
[  111s] obs-arm-7 failed "build osmo-sgsn_1.3.0.dsc" at Sun Jan 20 09:49:29 
UTC 2019.
[  111s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in libosmocore[master]: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/12641

to look at the new patch set (#2).

Change subject: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error
..

WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error

gcc-8.2 is printing the following warning, which is an error
when used -Werror like our --enable-werror:

In file included from gprs_bssgp.c:34:
In function ‘tl16v_put’,
inlined from ‘tvlv_put.part.3’ at ../../include/osmocom/gsm/tlv.h:156:9,
inlined from ‘tvlv_put’ at ../../include/osmocom/gsm/tlv.h:147:24,
inlined from ‘msgb_tvlv_push’ at ../../include/osmocom/gsm/tlv.h:386:2,
inlined from ‘bssgp_tx_dl_ud’ at gprs_bssgp.c:1162:4:
../../include/osmocom/gsm/tlv.h:131:2: error: ‘memcpy’ forming offset [11, 130] 
is out of the bounds [0, 10] of object ‘mi’ with type ‘uint8_t[10]’ {aka 
‘unsigned char[10]’} [-Werror=array-bounds]
  memcpy(buf, val, len);

Where "130" sems to be the maximum value of uint8_t, shifted right one +
2.  But even if we use strnlen() with "16" as maximum upper bound, gcc
still believes there's a way that the return value of 
gsm48_generate_mid_from_imsi()
could be 130.  In fact, even when adding OSMO_ASSERTs inside
gsm48_generate_mid(), gcc insists there is a problem :(

Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
---
M src/gsm/gsm48.c
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12641/2
--
To view, visit https://gerrit.osmocom.org/12641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
Gerrit-Change-Number: 12641
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)

Change in libosmocore[master]: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error

[Harald Welte]

Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/12641


Change subject: WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error
..

WIP: Attempt to avoid bogus gcc-8.2 array-bounds warning/error

gcc-8.2 is printing the following warning, which is an error
when used -Werror like our --enable-werror:

In file included from gprs_bssgp.c:34:
In function ‘tl16v_put’,
inlined from ‘tvlv_put.part.3’ at ../../include/osmocom/gsm/tlv.h:156:9,
inlined from ‘tvlv_put’ at ../../include/osmocom/gsm/tlv.h:147:24,
inlined from ‘msgb_tvlv_push’ at ../../include/osmocom/gsm/tlv.h:386:2,
inlined from ‘bssgp_tx_dl_ud’ at gprs_bssgp.c:1162:4:
../../include/osmocom/gsm/tlv.h:131:2: error: ‘memcpy’ forming offset [11, 130] 
is out of the bounds [0, 10] of object ‘mi’ with type ‘uint8_t[10]’ {aka 
‘unsigned char[10]’} [-Werror=array-bounds]
  memcpy(buf, val, len);

Where "130" sems to be the maximum value of uint8_t, shifted right one +
2.  But even if we use strnlen() with "16" as maximum upper bound, gcc
still believes there's a way that the return value of 
gsm48_generate_mid_from_imsi()
could be 130.  In fact, even when adding OSMO_ASSERTs inside
gsm48_generate_mid(), gcc insists there is a problem :(

Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
---
M src/gsm/gsm48.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12641/1

diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 795e98b..7e2564a 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -644,13 +644,15 @@
  *  \returns number of bytes used in \a buf */
 uint8_t gsm48_generate_mid(uint8_t *buf, const char *id, uint8_t mi_type)
 {
-   uint8_t length = strnlen(id, 255), i, off = 0, odd = (length & 1) == 1;
+   uint8_t length = strnlen(id, 16), i, off = 0, odd = (length & 1) == 1;
+   /* maximum length == 16 */

buf[0] = GSM48_IE_MOBILE_ID;
buf[2] = osmo_char2bcd(id[0]) << 4 | (mi_type & GSM_MI_TYPE_MASK) | 
(odd << 3);

/* if the length is even we will fill half of the last octet */
buf[1] = (length + (odd ? 1 : 2)) >> 1;
+   /* buf[1] maximum = 18/2 = 9 */

for (i = 1; i < buf[1]; ++i) {
uint8_t upper, lower = osmo_char2bcd(id[++off]);
@@ -662,6 +664,7 @@
buf[2 + i] = (upper << 4) | lower;
}

+   /* maximum return value: 2 + 9 = 11 */
return 2 + buf[1];
 }


--
To view, visit https://gerrit.osmocom.org/12641
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8488bc7f77dc9182e372741b88f0f06100dddc9
Gerrit-Change-Number: 12641
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 

Change in gr-gsm[master]: trx/radio_if.py: do not print anything if freq. shift is 0

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/12636 )

Change subject: trx/radio_if.py: do not print anything if freq. shift is 0
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/12636
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I100ce2ab8effc00e164e13253894445bdc816f06
Gerrit-Change-Number: 12636
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Comment-Date: Sun, 20 Jan 2019 09:09:52 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes