Change in osmo-ttcn3-hacks[master]: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth()

2020-01-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16889 ) Change subject: MSC: fix TC_iu_cmserv_imsi_unknown: do not call f_mm_auth() .. MSC: fix TC_iu_cmserv_imsi_unknown: do not

Change in osmo-trx[master]: lms: Make ts_offset and smpl rate coefs device-specific

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16877 ) Change subject: lms: Make ts_offset and smpl rate coefs device-specific .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: Initial multi-arfcn support

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16878 ) Change subject: lms: Initial multi-arfcn support .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group()

2020-01-15 Thread fixeria
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16888 ) Change subject: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group() .. pcu_l1_if.cpp: fix NULL-pointer dereference in

Change in osmo-pcu[master]: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group()

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16888 ) Change subject: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-pcu[master]: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group()

2020-01-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/16888 ) Change subject: pcu_l1_if.cpp: fix NULL-pointer dereference in imsi2paging_group() .. pcu_l1_if.cpp: fix NULL-pointer dereference

Change in osmo-bts[master]: l1sap: merge MEAS IND into PRIM PH DATA / PRIM TCH

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15918 ) Change subject: l1sap: merge MEAS IND into PRIM PH DATA / PRIM TCH .. Patch Set 10: (2 comments)

Change in osmo-trx[master]: lms: Initial multi-arfcn support

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16878 ) Change subject: lms: Initial multi-arfcn support .. Patch Set 3: (1 comment)

Change in osmo-bsc[master]: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TE...

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TEI_DN .. Patch Set 2: > Patch Set 2: > > you

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. Patch Set 4: (1 comment)

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 ) Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print received PDU .. MSC/SMS-over-GSUP: cosmetic: use a

Change in osmo-ttcn3-hacks[master]: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16884 ) Change subject: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT .. library/L3_Templates.ttcn: fix length matching in

Change in osmo-ttcn3-hacks[master]: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing()

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16880 ) Change subject: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing() .. MSC: fix coding style in

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883 ) Change subject: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms .. MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms The MSC

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 ) Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print received PDU .. Patch Set 1: Code-Review+2

Change in osmo-ttcn3-hacks[master]: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16884 ) Change subject: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing()

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16880 ) Change subject: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing() .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883 ) Change subject: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ci[master]: docker: move to docker-playground.git

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16871 ) Change subject: docker: move to docker-playground.git .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. Patch Set 4: Code-Review-1 I would think it's sufficient to

Change in osmo-ci[master]: docker_images_require: add symlink code path

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16870 ) Change subject: docker_images_require: add symlink code path .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: hlr: add TC_gsup_sai_num_auth_vectors

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16790 ) Change subject: hlr: add TC_gsup_sai_num_auth_vectors .. hlr: add TC_gsup_sai_num_auth_vectors TC_gsup_sai_num_auth_vectors tests the

Change in osmo-ttcn3-hacks[master]: hlr: add TC_gsup_sai_num_auth_vectors

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16790 ) Change subject: hlr: add TC_gsup_sai_num_auth_vectors .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update Socket-API + IPL4 upstream tags

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16879 ) Change subject: deps/Makefile: Update Socket-API + IPL4 upstream tags .. deps/Makefile: Update Socket-API + IPL4 upstream tags

Change in osmo-bsc[master]: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TE...

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16352 ) Change subject: fix inp_sig_cb(): notify all timeslots of all TRXes on OML S_L_INP_TEI_DN .. Patch Set 2: you need to be careful

Change in osmo-ci[master]: OBS: clone from gerrit.osmocom.org

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16561 ) Change subject: OBS: clone from gerrit.osmocom.org .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmo-sccp[master]: ss7: Improve checks in osmo_ss7_asp_peer_add_host()

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16831 ) Change subject: ss7: Improve checks in osmo_ss7_asp_peer_add_host() .. ss7: Improve checks in osmo_ss7_asp_peer_add_host() * Introduce

Change in libosmo-sccp[master]: ss7: Improve checks in osmo_ss7_asp_peer_add_host()

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16831 ) Change subject: ss7: Improve checks in osmo_ss7_asp_peer_add_host() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: Make reference to std::vector unambiguous

2020-01-15 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16887 ) Change subject: lms: Make reference to std::vector unambiguous .. lms: Make reference to std::vector unambiguous Change-Id:

Change in osmo-trx[master]: lms: Move rx_buffers allocation to constructor

2020-01-15 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16875 ) Change subject: lms: Move rx_buffers allocation to constructor .. lms: Move rx_buffers allocation to constructor Release is done in

Change in osmo-trx[master]: lms: Move rx_buffers allocation to constructor

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16875 ) Change subject: lms: Move rx_buffers allocation to constructor .. Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit

Change in osmo-trx[master]: lms: Initial multi-arfcn support

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16878 ) Change subject: lms: Initial multi-arfcn support .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: bsc_main: use higher default loglevels.

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16886 ) Change subject: bsc_main: use higher default loglevels. .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: lms: Make ts_offset and smpl rate coefs device-specific

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16877 ) Change subject: lms: Make ts_offset and smpl rate coefs device-specific .. Patch Set 2: Code-Review+1 -- To view, visit

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. Patch Set 4: Code-Review-1 I think it makes more sense to

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. Patch Set 3: (1 comment)

Change in osmo-trx[master]: lms: Store device type specific parameters in one place

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16876 ) Change subject: lms: Store device type specific parameters in one place .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: ta_control: move timing advance code from osmo-bts-trx to common

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16885 ) Change subject: ta_control: move timing advance code from osmo-bts-trx to common .. Patch Set 1: Waiting for jenkins success before

Change in osmo-trx[master]: lms: Move rx_buffers allocation to constructor

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16875 ) Change subject: lms: Move rx_buffers allocation to constructor .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: lms: Make reference to std::vector unambiguous

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16887 ) Change subject: lms: Make reference to std::vector unambiguous .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-15 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. libmsc: SMS, Avoid premature RP-ACK to MS There was one libmsc commit to openbsc

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-15 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what it is

Change in osmo-trx[master]: lms: Make reference to std::vector unambiguous

2020-01-15 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/16887 ) Change subject: lms: Make reference to std::vector unambiguous .. lms: Make reference to std::vector unambiguous Change-Id:

Change in osmo-trx[master]: lms: Store device type specific parameters in one place

2020-01-15 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/16876 to look at the new patch set (#2). Change subject: lms: Store device type specific parameters in one place

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
Hello pespin, fixeria, laforge, Jenkins Builder, Pablo Neira Ayuso, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/16873 to look at the new patch set (#4). Change subject: libmsc: SMS, Avoid premature RP-ACK to MS

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 4: (1 comment)

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.20

2020-01-15 Thread pespin
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16848 ) Change subject: layer23: Fix build against gpsd >= 3.20 .. layer23: Fix build against gpsd >= 3.20 During 3.19->3.20 dev cycle, some fields

Change in osmocom-bb[master]: layer23: Fix build against gpsd >= 3.20

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16848 ) Change subject: layer23: Fix build against gpsd >= 3.20 .. Patch Set 1: > Patch Set 1: Code-Review+2 > > They seem to like

Change in osmo-hlr[master]: D-GSM 1/n: add mslookup server in osmo-hlr

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16209 ) Change subject: D-GSM 1/n: add mslookup server in osmo-hlr .. Patch Set 28: Code-Review+1 -- To view, visit

Change in osmo-hlr[master]: D-GSM 1/n: add mslookup server in osmo-hlr

2020-01-15 Thread osmith
osmith has uploaded a new patch set (#28) to the change originally created by neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16209 ) Change subject: D-GSM 1/n: add mslookup server in osmo-hlr .. D-GSM 1/n: add mslookup server

Change in osmo-hlr[master]: D-GSM 1/n: add mslookup server in osmo-hlr

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16209 ) Change subject: D-GSM 1/n: add mslookup server in osmo-hlr .. Patch Set 27: (1 comment)

Change in osmo-hlr[master]: D-GSM 3/n: implement roaming by mslookup in osmo-hlr

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 ) Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr .. Patch Set 19: Code-Review+1 -- To view, visit

Change in docker-playground[master]: debian-stretch-jenkins: move from osmo-ci.git

2020-01-15 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16867 ) Change subject: debian-stretch-jenkins: move from osmo-ci.git .. debian-stretch-jenkins: move from osmo-ci.git Put

Change in docker-playground[master]: debian-buster-erlang: rename user to "build"

2020-01-15 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16868 ) Change subject: debian-buster-erlang: rename user to "build" .. debian-buster-erlang: rename user to "build" Match username of

Change in docker-playground[master]: debian-buster-erlang: rename user to "build"

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16868 ) Change subject: debian-buster-erlang: rename user to "build" .. Patch Set 3: Verified+1 -- To view, visit

Change in docker-playground[master]: debian-stretch-jenkins: move from osmo-ci.git

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16867 ) Change subject: debian-stretch-jenkins: move from osmo-ci.git .. Patch Set 2: Verified+1 -- To view, visit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 3: Code-Review+2 (1 comment)

Change in osmo-ci[master]: docker: move to docker-playground.git

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16871 ) Change subject: docker: move to docker-playground.git .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-ci[master]: docker_images_require: add symlink code path

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16870 ) Change subject: docker_images_require: add symlink code path .. Patch Set 2: Code-Review+1 -- To view, visit

Change in docker-playground[master]: debian-stretch-jenkins: move from osmo-ci.git

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16867 ) Change subject: debian-stretch-jenkins: move from osmo-ci.git .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16883 ) Change subject: MSC/SMPP: fix RP-ACK expectations in TC_smpp_mo_sms .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update Socket-API + IPL4 upstream tags

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16879 ) Change subject: deps/Makefile: Update Socket-API + IPL4 upstream tags .. Patch Set 1: Code-Review+2 Any specific reason to

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. Patch Set 3: Code-Review+1 (1 comment)

Change in osmo-ttcn3-hacks[master]: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print receive...

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16881 ) Change subject: MSC/SMS-over-GSUP: cosmetic: use a single log() call to print received PDU .. Patch Set 1: Code-Review+2

Change in osmo-ttcn3-hacks[master]: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16884 ) Change subject: library/L3_Templates.ttcn: fix length matching in tr_RP_ERROR_MT .. Patch Set 1: Code-Review+1 -- To view,

Change in osmo-trx[master]: lms: Initial multi-arfcn support

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16878 ) Change subject: lms: Initial multi-arfcn support .. Patch Set 2: (1 comment)

Change in osmo-ttcn3-hacks[master]: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing()

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16880 ) Change subject: MSC: fix coding style in f_tc_lu_and_mt_sms_paging_and_nothing() .. Patch Set 1: Code-Review+2 -- To view,

Change in osmo-trx[master]: lms: Store device type specific parameters in one place

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16876 ) Change subject: lms: Store device type specific parameters in one place .. Patch Set 1: (5 comments)

Change in osmo-hlr[master]: D-GSM 3/n: implement roaming by mslookup in osmo-hlr

2020-01-15 Thread osmith
osmith has uploaded a new patch set (#19) to the change originally created by neels. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 ) Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr .. D-GSM 3/n: implement

Change in osmo-hlr[master]: D-GSM 3/n: implement roaming by mslookup in osmo-hlr

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 ) Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr .. Patch Set 18: (1 comment)

Change in osmo-trx[master]: lms: Make ts_offset and smpl rate coefs device-specific

2020-01-15 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/16877 ) Change subject: lms: Make ts_offset and smpl rate coefs device-specific .. Patch Set 1: (1 comment)

Change in osmo-bsc[master]: bsc_main: use higher default loglevels.

2020-01-15 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/16886 ) Change subject: bsc_main: use higher default loglevels. .. bsc_main: use higher default loglevels. The loglevels of DNM, DFILTER

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. Patch Set 4: (2 comments)

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread dexter
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/16833 to look at the new patch set (#4). Change subject: application.c: check default loglevels on startup

Change in osmo-bts[master]: l1sap: merge MEAS IND into PRIM PH DATA / PRIM TCH

2020-01-15 Thread dexter
Hello fixeria, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/15918 to look at the new patch set (#10). Change subject: l1sap: merge MEAS IND into PRIM PH DATA / PRIM TCH

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 ) Change subject: application.c: check default loglevels on startup .. Patch Set 2: Code-Review-1 (1 comment)

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 2: (1 comment)

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 3: Code-Review+1 -- To view, visit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
Hello fixeria, Jenkins Builder, Pablo Neira Ayuso, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/16873 to look at the new patch set (#3). Change subject: libmsc: SMS, Avoid premature RP-ACK to MS

Change in libosmocore[master]: application.c: check default loglevels on startup

2020-01-15 Thread dexter
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/16833 to look at the new patch set (#2). Change subject: application.c: check default loglevels on startup

Change in libosmocore[master]: logging.c: Add valuestrings for loglevels

2020-01-15 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16832 ) Change subject: logging.c: Add valuestrings for loglevels .. Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16832

Change in osmo-bts[master]: ta_control: move timing advance code from osmo-bts-trx to common

2020-01-15 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16885 ) Change subject: ta_control: move timing advance code from osmo-bts-trx to common .. ta_control: move timing advance code from

Change in osmo-ci[master]: docker: move to docker-playground.git

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16871 ) Change subject: docker: move to docker-playground.git .. Patch Set 2: (3 comments)

Change in osmo-ci[master]: docker: move to docker-playground.git

2020-01-15 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ci/+/16871 ) Change subject: docker: move to docker-playground.git .. docker: move to docker-playground.git Instead of building "osmocom:deb9_amd64"

Change in osmo-ci[master]: docker_images_require: add symlink code path

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16870 ) Change subject: docker_images_require: add symlink code path .. Patch Set 2: > Patch Set 1: > > Can you document here what's the

Change in osmo-ci[master]: docker_images_require: add symlink code path

2020-01-15 Thread osmith
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ci/+/16870 ) Change subject: docker_images_require: add symlink code path .. docker_images_require: add symlink code path Make development easier by

Change in osmo-ci[master]: gerrit-verifications: introduce "gerrit_url" var

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16869 ) Change subject: gerrit-verifications: introduce "gerrit_url" var .. Patch Set 1: Verified+1 -- To view, visit

Change in osmo-ci[master]: gerrit-verifications: introduce "gerrit_url" var

2020-01-15 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/16869 ) Change subject: gerrit-verifications: introduce "gerrit_url" var .. gerrit-verifications: introduce "gerrit_url" var Prepare for erlang

Change in docker-playground[master]: debian-stretch-jenkins: move from osmo-ci.git

2020-01-15 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/16867 ) Change subject: debian-stretch-jenkins: move from osmo-ci.git .. Patch Set 2: (1 comment) > Patch Set 1: > > Why do we

Change in docker-playground[master]: debian-stretch-jenkins: move from osmo-ci.git

2020-01-15 Thread osmith
Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/16867 to look at the new patch set (#2). Change subject: debian-stretch-jenkins: move from osmo-ci.git ..