Change in ...osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-06-11 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989 )

Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Tue, 11 Jun 2019 14:53:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-06-11 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989 )

Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
..

SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message 
for normal detach

Merge the case with the fail when doing a power-off detach.

Change-Id: I957994376583959758417dccf419a55c43a0c61b
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 1f63dfa..03c9d05 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -924,10 +924,6 @@
mtc.stop;
/* TODO: check if any PDP contexts are deactivated on network 
side? */
}
-   [power_off] BSSGP[bssgp_index].receive(tr_BD_L3_MT(?)) -> value bd {
-   setverdict(fail, "Unexpected Layer 3 package received in 
power-off DETACH");
-   mtc.stop;
-   }
[power_off] T.timeout {
setverdict(pass);
}
@@ -936,6 +932,14 @@
setverdict(pass);
/* TODO: check if any PDP contexts are deactivated on network 
side? */
}
+   [] BSSGP[bssgp_index].receive(tr_BD_L3_MT(?)) -> value bd {
+   if (power_off) {
+   setverdict(fail, "Unexpected Layer 3 package received 
in power-off DETACH");
+   } else {
+   setverdict(fail, "Unexpected Layer 3 package received 
in normal DETACH");
+   }
+   mtc.stop;
+   }
[] BSSGP[bssgp_index].receive { repeat; }
}
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-06-06 Thread lynxis lazus 
Hello laforge, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989

to look at the new patch set (#2).

Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
..

SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message 
for normal detach

Merge the case with the fail when doing a power-off detach.

Change-Id: I957994376583959758417dccf419a55c43a0c61b
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/89/13989/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: newpatchset

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-05-11 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/13989 )

Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
..


Patch Set 1: Code-Review-1

This can be merged with the identical Claude for the power-offf case that you 
added two patches earlier.


--
To view, visit https://gerrit.osmocom.org/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sat, 11 May 2019 06:02:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 ...

2019-05-10 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/13989


Change subject: SGSN_Tests: f_detach_mo(): fail when receiving any unhandled 
layer 3 message for normal detach
..

SGSN_Tests: f_detach_mo(): fail when receiving any unhandled layer 3 message 
for normal detach

Change-Id: I957994376583959758417dccf419a55c43a0c61b
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/89/13989/1

diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index a3dbed1..5e04246 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -912,6 +912,10 @@
setverdict(pass);
/* TODO: check if any PDP contexts are deactivated on network 
side? */
}
+   [not power_off] BSSGP[bssgp_index].receive(tr_BD_L3_MT(?)) -> value bd {
+   setverdict(fail, "Unexpected Layer 3 package received in normal 
DETACH");
+   mtc.stop;
+   }
[] BSSGP[bssgp_index].receive { repeat; }
}
 }

--
To view, visit https://gerrit.osmocom.org/13989
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I957994376583959758417dccf419a55c43a0c61b
Gerrit-Change-Number: 13989
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus