Patch Set 5:
I would very much like to replace the command line and control socket
interface. There are more than enough configuration options so that a config
file makes sense - that is the direction that I prefer over command line
arguments.
For the control socket interface, we need to
Patch Set 2:
> Maybe we can replace both -r and -E with new --filler which will
> figure out appropriate filler based on other options by checking if
> edge is enabled or not?
That's exactly what this patch is moving away from. Right now -r option has
different behavior based on whether -e
Patch Set 2:
Maybe we can replace both -r and -E with new --filler which will figure out
appropriate filler based on other options by checking if edge is enabled or
not? In general, there's GNU gengetopt which supports mutually exclusive groups
of options but it's only used for OpenGGSN so
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2143/2/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 419: case 'E':
> So user can still specify ... -E 123 -r 321 ... without enabling EDGE and i
In general, I would very much like to stop adding more
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2143/2/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 419: case 'E':
So user can still specify ... -E 123 -r 321 ... without enabling EDGE and it'll
work (provided options are parsed from
Review at https://gerrit.osmocom.org/2143
osmo-trx: Separate command line switch to enable EDGE filler.
Now -r comand line switch always enables GMSK filler even when EDGE mode is
enabled with -e switch. If you want to enable EDGE filler, use -E switch.
Change-Id:
