Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3102
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6d92b1d135063dfd0a26bc23a89802cb3b1a78
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: vty: Check returncode of osmo_ss7_pointcode_parse()
..
vty: Check returncode of osmo_ss7_pointcode_parse()
The result of osmo_ss7_pointcode_parse() is
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3102
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae6d92b1d135063dfd0a26bc23a89802cb3b1a78
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3102
to look at the new patch set (#2).
vty: Check returncode of osmo_ss7_pointcode_parse()
The result of osmo_ss7_pointcode_parse() is currently not
checked. This means that
Patch Set 1: Code-Review+1
(1 comment)
good, but can be improved:
https://gerrit.osmocom.org/#/c/3102/1/src/osmo_ss7_vty.c
File src/osmo_ss7_vty.c:
Line 170: vty_out(vty, "Invalid point code%s", VTY_NEWLINE);
also log the invalid point code: argv[0]. Same below.
--
To view,
Review at https://gerrit.osmocom.org/3102
vty: Check returncode of osmo_ss7_pointcode_parse()
The result of osmo_ss7_pointcode_parse() is currently not
checked. This means that -EINVAL could end up as value
in the pointcode configuration.
Check the return code of osmo_ss7_pointcode_parse()
