[ABANDON] libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-27 Thread Max
Max has abandoned this change. Change subject: Add and use macros to set/get/clear/toggle bit flags .. Abandoned Harald is not convinced. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Harald Welte
Patch Set 3: Actually, I'm sorry, I think I stay with my original assessment. It makes code harder to figure out, and as Holger points out it would even be restricted in terms of what type it could be applied to. In Linux kernel we have some macros in linux/bitops.h, but then they exist for

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Harald Welte
Patch Set 3: Holger, Neels:Any input on this? For me it's really hard. I personally believe it makes code less readable, but Max and Pau claim it is helpful for them... -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Max
Patch Set 3: Code-Review+1 Yepp, he's the boss. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Vadim Yanitskiy
Patch Set 3: > Shall I abandon this or +1 x 3 outweight Harald's -1? Let's wait for the final response from Harald. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Vadim Yanitskiy
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-26 Thread Pau Espin Pedrol
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-22 Thread Pau Espin Pedrol
Patch Set 3: I do think it's useful. At least to me it's clearer when looking at it, and easier to grep if I want to know when a bit it set or cleared or checked. -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-22 Thread Harald Welte
Patch Set 3: Code-Review-1 I'm not sure if this is really useful. Actually, to me, you are hiding what the code does. Every c programmer knows what "foo & (1 << bit)" means. By introducing "non-standard" syntax for such basic operations, I think you're actually making code harder to read.

libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-22 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2857 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9d38b837ce84649c2975dbe8b889fe3a769885f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] libosmocore[master]: Add and use macros to set/get/clear/toggle bit flags

2017-06-19 Thread Max
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2857 to look at the new patch set (#3). Add and use macros to set/get/clear/toggle bit flags We extensively use bit masks and flags but do not have any convenience wrappers