Harald Welte has submitted this change and it was merged.
Change subject: ensure that osmo_fsm vty commands are only installed once
..
ensure that osmo_fsm vty commands are only installed once
There is a desire to install
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6843
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10b0b1c1c1bf44c3b8eafc465c1ee06ea2590682
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6843/1/src/vty/fsm_vty.c
File src/vty/fsm_vty.c:
Line 192: if (!osmo_fsm_vty_cmds_installed) {
> what we normally do is
I doubt we have cases where distinct libraries are installing *the same* vty
commands already. Any such case
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6843
to look at the new patch set (#2).
ensure that osmo_fsm vty commands are only installed once
There is a desire to install osmo_fsm vty commands automatically in
a library context,
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6843/1/src/vty/fsm_vty.c
File src/vty/fsm_vty.c:
Line 192: if (!osmo_fsm_vty_cmds_installed) {
what we normally do is
if (osmo_fsm_vty_cmds_installed)
return;
to avoid having to indent all of the other statements in the
Review at https://gerrit.osmocom.org/6843
ensure that osmo_fsm vty commands are only installed once
There is a desire to install osmo_fsm vty commands automatically in
a library context, rather than requiring every application which
directly or indirectly uses osmo_fsm to run
