Vadim Yanitskiy has abandoned this change.
Change subject: gsm0480: modify USSD structures to support external handling
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit
Patch Set 4: Code-Review-1
normally the clean thing to do here is to support both the old API/ABI and the
new one. Merging you change would mean that no old versions of any
openbsc/osmocom programs can be built against new versions of the library,
which is not acceptable, sorry.
--
To
Patch Set 4: Code-Review+1
Sorry,missed that patch
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Patch Set 4:
> Sorry, forgot to ask this:
> What happened to this change?
> Do you plan to submit it as a separate patch?
> > #define MAX_LEN_USSD_STRING182
It's already submitted, see the next one in this set.
I decided to do that separately because it requires
a bit more detailed
Patch Set 4: Code-Review-1
Sorry, forgot to ask this:
What happened to this change? Do you plan to submit it as a separate patch?
> #define MAX_LEN_USSD_STRING 182
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3374
to look at the new patch set (#4).
gsm0480: modify USSD structures to support external handling
This change renames the 'ss_request' struct to
'gsm0480_ss_request', and adds the
Patch Set 3:
> the old version of the library will no longer work
Which osmo-* are actually using it? Do we have patches for them too? Would be
nice to reference them in commit message or to clarify why it's unnecessary.
This would help to unsure that we won't break build of some other
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3374
to look at the new patch set (#3).
gsm0480: modify USSD structures to support external handling
This change renames the 'ss_request' struct to 'gsm0480_ss_request',
and adds the
Patch Set 2:
> I thought the idea was to use TODO-RELEASE file to track API/ABI
> breakage until release. I've documented it here
> https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release
Looks like a good option to me
--
To view, visit https://gerrit.osmocom.org/3374
Patch Set 2:
I thought the idea was to use TODO-RELEASE file to track API/ABI breakage until
release. I've documented it here
https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit
Patch Set 2:
> Hi Harald,
>
> Sorry for late response. Regarding to the ABI / API breaking
> problem,
> we have discussed suggested solution with Alexander: adding an
> 'osmo'
> prefix that is currently missed for exposed symbols would be great.
We may want to change the structure again
Patch Set 2:
Hi Harald,
Sorry for late response. Regarding to the ABI / API breaking problem,
we have discussed suggested solution with Alexander: adding an 'osmo'
prefix that is currently missed for exposed symbols would be great.
--
To view, visit https://gerrit.osmocom.org/3374
To
Patch Set 2:
The problem is that you're breaking API + ABI. The symbol stll exists, and
code compiled against the old version of the symbol will crash in a non-obvious
way.
So I would prefer any solution that avoids this. Simply renaming the function
would solve it, as then an old program
Patch Set 2:
> in general, what is your strategy for forward/backward
> compatibility here? you're changing the API and ABI while keeping
> the symbol name identical, breaking existing applications
Should we just bump the lib version? Otherwise we'll have to maintain two
similar structures
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3374/2/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:
Line 10: #define MAX_LEN_USSD_STRING182
Could we add a reference to the standard here to point at where this value is
coming from?
--
To view, visit
Review at https://gerrit.osmocom.org/3374
gsm0480: modify USSD structures to support external handling
This change adds the following new fields to ss_request struct:
- message_type - GSM 04.80 Chapter 2.2
- component_type - GSM 04.80 Chapter 3.6.2
- error_code - GSM 04.80 Chapter 3.6.6
18 matches
Mail list logo
