[MERGED] openbsc[master]: pcu_sock: add basic pcu interface support

2017-05-25 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu_sock: add basic pcu interface support .. pcu_sock: add basic pcu interface support Adds a basic version of a pcu socket interface, similar to the

openbsc[master]: pcu_sock: add basic pcu interface support

2017-05-25 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2056 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13cb4099d12fa71e9e0b8727e19ab29e11909b2 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master

openbsc[master]: pcu_sock: add basic pcu interface support

2017-03-15 Thread Max
Patch Set 1: > Let's say we change the interface and bump the version inside the pcu. So what shall we do if we have to make changes to BSC's copy of the protocol? We have to checkout latest version of OsmoPCU, see which version was used there and +1 to it to make sure we don't have different

openbsc[master]: pcu_sock: add basic pcu interface support

2017-03-15 Thread Harald Welte
Patch Set 1: -Code-Review (3 comments) https://gerrit.osmocom.org/#/c/2056/1/openbsc/include/openbsc/pcu_if.h File openbsc/include/openbsc/pcu_if.h: Line 13:struct osmo_fd conn_bfd;/* fd for connection to lcr */ to lrc?!?

openbsc[master]: pcu_sock: add basic pcu interface support

2017-03-15 Thread Harald Welte
Patch Set 1: Code-Review+1 > Can we use shared header installed by osmo-pcu similar to #1258? Actually, I think I start to like the idea of having copies of the header file. This way, each version in the git repository has the matching version of the header file to its code. Let's say we