Pau Espin Pedrol has abandoned this change.
Change subject: octphy: Allow passing low quality buffers to upper layers
..
Abandoned
Abandon, all hw specific commits are merged into the same commit because on the
new version
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3078/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 201: rmsg = msgb_alloc_headroom(256, 128, "L1C-to-RTP");
> L1C is L1 Control (channel activation, ...). L1P is L1 [data] primitive. L1
I actually
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3078/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 201: rmsg = msgb_alloc_headroom(256, 128, "L1C-to-RTP");
L1C is L1 Control (channel activation, ...). L1P is L1 [data] primitive. L1C
Patch Set 1:
> why bother with the extra argument? A length of 0 bytes must mean
> a frame with invalid CRC. What other case for zero-length can you
> think of?
>From the FIXME in the code in l1_if.c, I understand that at some point we want
>to check for low quality link in a similar way
Patch Set 1:
why bother with the extra argument? A length of 0 bytes must mean a frame with
invalid CRC. What other case for zero-length can you think of?
--
To view, visit https://gerrit.osmocom.org/3078
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Review at https://gerrit.osmocom.org/3078
octphy: Allow passing low quality buffers to upper layers
We want to always call l1if_tch_rx in order to avoid losing triggering
events on the upper layer.
With this change, the upper layer will increase correctly seq + ts for
RTP. It will then send
