Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Create Bts abstract class and make OsmoBts inherit from it
..
Create Bts abstract class and make OsmoBts inherit from it
This base class will be used
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13133e61abda73a8b507c1a1bd7b98c677460f9
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/7160/3/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 26: class Bts(log.Origin, metaclass=ABCMeta):
> could you explain ABCMeta? What does it help us with?
https://docs.python.org/3/library/abc.html
It helps us specifyi
Patch Set 3: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/7160/3/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 26: class Bts(log.Origin, metaclass=ABCMeta):
could you explain ABCMeta? What does it help us with?
Line 45: # PUBLIC - INTERNAL API
what now, public
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7160
to look at the new patch set (#2).
Create Bts abstract class and make OsmoBts inherit from it
This base class will be used to describe the required accessors for all
BTS o
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7160/1/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 3: # Copyright (C) 2016-2017 by sysmocom - s.f.m.c. GmbH
2018?
--
To view, visit https://gerrit.osmocom.org/7160
To unsubscribe, visit https://gerrit.
Review at https://gerrit.osmocom.org/7160
Create Bts abstract class and make OsmoBts inherit from it
This base class will be used to describe the required accessors for all
BTS objects, be it an osmocom BTS or not.
It is introduced in this commit and will be further used in the future
when add
