Vadim Yanitskiy has submitted this change and it was merged.
Change subject: libmsc/gsm_04_80.c: drop unused 'in_msg' argument
..
libmsc/gsm_04_80.c: drop unused 'in_msg' argument
It isn't used, so no need to pass it.
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7674
to look at the new patch set (#3).
libmsc/gsm_04_80.c: drop unused 'in_msg' argument
It isn't used, so no need to pass it.
Change-Id:
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/7674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1:
> About indenting style, personally I don't like this style. [..]
Everyone of course has their own preference, and everyone is entitled to have
that.
However, in any software project it is generally good if there is a common
style to be
followed by all the code, as it enhances
Patch Set 2:
About indenting style, personally I don't like this style.
This occupies the potential space, that could be used
for listing arguments, by useless spaces and tabs
just in order to make the code look aligned...
Also, some parts of this code are to be modified in the
near future, so
Patch Set 1: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/7674/1/include/osmocom/msc/gsm_04_80.h
File include/osmocom/msc/gsm_04_80.h:
Line 10:const char* response_text, const struct ss_request *req);
(I would rather keep the same indenting style as below, and for added
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7674
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7674
libmsc/gsm_04_80.c: drop unused 'in_msg' argument
Change-Id: I4248ebf8626d3f7f0bf273fd20cc4f64e979938b
---
M include/osmocom/msc/gsm_04_80.h
M src/libmsc/gsm_04_80.c
M src/libmsc/ussd.c
3 files changed, 10 insertions(+), 13 deletions(-)
git pull
