Alexander Chemeris has submitted this change and it was merged.
Change subject: BitVector: Convert SoftVector from 0..1 to -1..+1 soft bits.
..
BitVector: Convert SoftVector from 0..1 to -1..+1 soft bits.
This makes code
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ecc3d4c829dcf0f619ad995bc9d4a4ed8af0a4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2142
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ecc3d4c829dcf0f619ad995bc9d4a4ed8af0a4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2:
(1 comment)
> (1 comment)
https://gerrit.osmocom.org/#/c/2142/2/CommonLibs/BitVector.h
File CommonLibs/BitVector.h:
Line 305: return (*dp)>0.0F;
> Can we just compare "> 0" in here?
Yes, but I want to make it clear it's a floating point value.
--
To view, visit
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2142/2/CommonLibs/BitVector.h
File CommonLibs/BitVector.h:
Line 305: return (*dp)>0.0F;
Can we just compare "> 0" in here?
--
To view, visit https://gerrit.osmocom.org/2142
To unsubscribe, visit
Review at https://gerrit.osmocom.org/2142
BitVector: Convert SoftVector from 0..1 to -1..+1 soft bits.
This makes code simpler and will allow us send -127..127 soft bits towards
osmo-bts instead of 0..255 bits.
Change-Id: I16ecc3d4c829dcf0f619ad995bc9d4a4ed8af0a4
---
M
